ntex 4.0.0-beta.17

Framework for composable network services
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
//! Payload stream
use std::collections::VecDeque;
use std::task::{Context, Poll, Waker};
use std::{cell::Cell, cell::RefCell, fmt, future::poll_fn, pin::Pin, rc::Rc, rc::Weak};

use ntex_h2::{self as h2};

use crate::http::HeaderMap;
use crate::util::{Bytes, Stream};
use crate::{http::error::PayloadError, task::LocalWaker};

bitflags::bitflags! {
    #[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash)]
    struct Flags: u8 {
        const EOF = 0b0000_0001;
        const DROPPED = 0b0000_0010;
        const ERROR = 0b0000_0100;
    }
}

/// Buffered HTTP/2 payload stream.
///
/// Use [`Payload::read`] to receive the next chunk asynchronously, or consume
/// the payload through its [`Stream`] implementation. Waiting tasks are woken
/// when data, end-of-stream, or an error becomes available.
///
/// This type is not thread-safe and can also be used as a
/// [`Response`](crate::http::Response) body stream.
#[derive(Debug)]
pub struct Payload {
    inner: Rc<Inner>,
}

impl Payload {
    /// Create payload stream.
    ///
    /// This method construct two objects responsible for bytes stream
    /// generation.
    ///
    /// * `PayloadSender` - *Sender* side of the stream
    ///
    /// * `Payload` - *Receiver* side of the stream
    pub fn create(cap: h2::Capacity) -> (PayloadSender, Payload) {
        let shared = Rc::new(Inner::new(cap));

        (
            PayloadSender {
                inner: Rc::downgrade(&shared),
            },
            Payload { inner: shared },
        )
    }

    #[inline]
    /// Receives the next payload chunk.
    ///
    /// Returns `None` after the complete payload has been received.
    pub async fn read(&self) -> Option<Result<Bytes, PayloadError>> {
        poll_fn(|cx| self.poll_read(cx)).await
    }

    #[inline]
    /// Polls for the next payload chunk.
    pub fn poll_read(&self, cx: &mut Context<'_>) -> Poll<Option<Result<Bytes, PayloadError>>> {
        self.inner.readany(cx)
    }

    /// Returns the trailer fields received at the end of the payload.
    ///
    /// Trailers are available after the payload is complete, None is
    /// returned if the payload is not complete or has no trailers.
    pub fn trailers(&self) -> Option<HeaderMap> {
        if self.inner.items.borrow().is_empty() {
            self.inner.trailers.borrow().clone()
        } else {
            None
        }
    }
}

impl Drop for Payload {
    fn drop(&mut self) {
        self.inner.io_task.wake();
        self.inner.insert_flags(Flags::DROPPED);
        if let Some(f) = self.inner.on_drop.take() {
            f();
        }
    }
}

impl Stream for Payload {
    type Item = Result<Bytes, PayloadError>;

    fn poll_next(
        self: Pin<&mut Self>,
        cx: &mut Context<'_>,
    ) -> Poll<Option<Result<Bytes, PayloadError>>> {
        self.inner.readany(cx)
    }
}

#[derive(Debug)]
/// Sender part of the payload stream
pub struct PayloadSender {
    inner: Weak<Inner>,
}

impl Drop for PayloadSender {
    fn drop(&mut self) {
        if let Some(shared) = self.inner.upgrade() {
            drop(shared.on_drop.take());
            shared.set_error(PayloadError::Incomplete(None));
        }
    }
}

impl PayloadSender {
    /// Checks if the payload stream is dropped.
    pub(crate) fn is_dropped(&self) -> bool {
        self.inner.strong_count() == 0
    }

    /// Closes the payload stream with an error.
    pub fn set_error(&self, err: PayloadError) {
        if let Some(shared) = self.inner.upgrade() {
            shared.set_error(err);
        }
    }

    /// Sends the final payload chunk and closes the stream.
    pub fn feed_eof(&self, data: Bytes, cap: Option<h2::Capacity>) {
        if let Some(shared) = self.inner.upgrade() {
            shared.feed_eof(data, cap);
        }
    }

    /// Sends the trailer fields and closes the stream.
    pub fn feed_trailers(&self, trailers: HeaderMap) {
        if let Some(shared) = self.inner.upgrade() {
            shared.feed_trailers(trailers);
        }
    }

    /// Sends a payload chunk and updates the HTTP/2 flow-control capacity.
    pub fn feed_data(&self, data: Bytes, cap: h2::Capacity) {
        if let Some(shared) = self.inner.upgrade() {
            shared.feed_data(data, cap);
        }
    }

    /// Registers a callback that runs if the payload is dropped while the sender is alive.
    pub(crate) fn on_drop(&self, f: impl FnOnce() + 'static) {
        if let Some(shared) = self.inner.upgrade() {
            shared.on_drop.set(Some(Box::new(f)));
        }
    }

    pub(crate) fn on_cancel(&self, w: &Waker) -> Poll<()> {
        if let Some(shared) = self.inner.upgrade() {
            if shared.flags.get().contains(Flags::DROPPED) {
                Poll::Ready(())
            } else {
                shared.io_task.register(w);
                Poll::Pending
            }
        } else {
            Poll::Ready(())
        }
    }
}

struct Inner {
    flags: Cell<Flags>,
    cap: Cell<Option<h2::Capacity>>,
    err: Cell<Option<PayloadError>>,
    items: RefCell<VecDeque<Bytes>>,
    trailers: RefCell<Option<HeaderMap>>,
    task: LocalWaker,
    io_task: LocalWaker,
    on_drop: Cell<Option<Box<dyn FnOnce()>>>,
}

impl Inner {
    fn new(cap: h2::Capacity) -> Self {
        Inner {
            cap: Cell::new(Some(cap)),
            flags: Cell::new(Flags::empty()),
            err: Cell::new(None),
            items: RefCell::new(VecDeque::new()),
            trailers: RefCell::new(None),
            task: LocalWaker::new(),
            io_task: LocalWaker::new(),
            on_drop: Cell::new(None),
        }
    }

    fn insert_flags(&self, f: Flags) {
        let mut flags = self.flags.get();
        flags.insert(f);
        self.flags.set(flags);
    }

    fn set_error(&self, err: PayloadError) {
        // the first error is kept, a finished payload is not failed
        if !self.flags.get().intersects(Flags::EOF | Flags::ERROR) {
            self.insert_flags(Flags::ERROR);
            self.err.set(Some(err));
            self.task.wake();
        }
    }

    fn feed_eof(&self, data: Bytes, cap: Option<h2::Capacity>) {
        if let Some(cap) = cap {
            self.cap.set(Some(self.cap.take().unwrap() + cap));
        }
        self.insert_flags(Flags::EOF);
        if !data.is_empty() {
            self.items.borrow_mut().push_back(data);
        }
        self.task.wake();
    }

    fn feed_trailers(&self, trailers: HeaderMap) {
        if !self.flags.get().intersects(Flags::EOF | Flags::ERROR) {
            *self.trailers.borrow_mut() = Some(trailers);
            self.insert_flags(Flags::EOF);
            self.task.wake();
        }
    }

    fn feed_data(&self, data: Bytes, cap: h2::Capacity) {
        self.cap.set(Some(self.cap.take().unwrap() + cap));
        // empty DATA frames are not flow controlled, queueing them is unbounded
        if !data.is_empty() {
            self.items.borrow_mut().push_back(data);
            self.task.wake();
        }
    }

    fn readany(&self, cx: &mut Context<'_>) -> Poll<Option<Result<Bytes, PayloadError>>> {
        if let Some(data) = self.items.borrow_mut().pop_front() {
            let cap = self.cap.take().unwrap();
            cap.consume(data.len() as u32);
            self.cap.set(Some(cap));
            Poll::Ready(Some(Ok(data)))
        } else if let Some(err) = self.err.take() {
            // the payload ends after an error
            self.insert_flags(Flags::EOF);
            Poll::Ready(Some(Err(err)))
        } else if self.flags.get().contains(Flags::EOF) {
            Poll::Ready(None)
        } else {
            self.task.register(cx.waker());
            Poll::Pending
        }
    }
}

impl fmt::Debug for Inner {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        let cap = self.cap.take().unwrap();
        let err = self.err.take();
        let result = f
            .debug_struct("Inner")
            .field("flags", &self.flags.get())
            .field("capacity", &cap)
            .field("error", &err)
            .field("items", &self.items.borrow())
            .field("trailers", &self.trailers.borrow())
            .finish();

        self.cap.set(Some(cap));
        self.err.set(err);
        result
    }
}

#[cfg(test)]
mod tests {
    use std::sync::{Arc, atomic::AtomicUsize, atomic::Ordering};
    use std::task::Wake;

    use ntex_h2::client::SimpleClient;

    use super::*;
    use crate::http::{HeaderMap, Method};
    use crate::io::{Io, IoBoxed, testing::IoTest};
    use crate::{SharedCfg, time::Millis, time::sleep, util::ByteString};

    struct Counter(AtomicUsize);

    impl Wake for Counter {
        fn wake(self: Arc<Self>) {
            self.0.fetch_add(1, Ordering::SeqCst);
        }
    }

    /// A pending read does not wake the payload io task, only dropping the payload does.
    #[crate::rt_test]
    async fn test_pending_read_does_not_wake_io_task() {
        let (io, server) = IoTest::create();
        io.remote_buffer_cap(64 * 1024);
        let client = SimpleClient::new(
            IoBoxed::from(Io::new(io, SharedCfg::default())),
            false,
            ByteString::from_static("localhost"),
        );
        server.write([0, 0, 0, 4, 0, 0, 0, 0, 0]);
        sleep(Millis(50)).await;
        let (snd, _rcv) = client
            .send(Method::GET, "/".into(), HeaderMap::default(), true)
            .await
            .unwrap();

        let (sender, payload) = Payload::create(snd.stream().empty_capacity());
        let io_task = Arc::new(Counter(AtomicUsize::new(0)));
        let io_waker = io_task.clone().into();
        assert!(sender.on_cancel(&io_waker).is_pending());

        let reader = Arc::new(Counter(AtomicUsize::new(0)));
        let reader_waker = reader.clone().into();
        let mut cx = Context::from_waker(&reader_waker);
        for _ in 0..3 {
            assert!(payload.poll_read(&mut cx).is_pending());
        }
        assert_eq!(io_task.0.load(Ordering::SeqCst), 0);

        drop(payload);
        assert_eq!(io_task.0.load(Ordering::SeqCst), 1);
        assert!(sender.on_cancel(&io_waker).is_ready());
    }

    /// A ready read does not register the reader waker, new data does not wake
    /// a reader that is not waiting.
    #[crate::rt_test]
    async fn test_ready_read_does_not_register_waker() {
        let (io, server) = IoTest::create();
        io.remote_buffer_cap(64 * 1024);
        let client = SimpleClient::new(
            IoBoxed::from(Io::new(io, SharedCfg::default())),
            false,
            ByteString::from_static("localhost"),
        );
        server.write([0, 0, 0, 4, 0, 0, 0, 0, 0]);
        sleep(Millis(50)).await;
        let (snd, rcv) = client
            .send(Method::GET, "/".into(), HeaderMap::default(), true)
            .await
            .unwrap();

        // `200` response and two DATA frames
        server.write([0, 0, 1, 1, 4, 0, 0, 0, 1, 0x88]);
        server.write([0, 0, 2, 0, 0, 0, 0, 0, 1, b'a', b'b']);
        server.write([0, 0, 2, 0, 0, 0, 0, 0, 1, b'c', b'd']);
        let _ = rcv.recv().await.unwrap();
        let mut chunks = Vec::new();
        for _ in 0..2 {
            let msg = rcv.recv().await.unwrap();
            let h2::MessageKind::Data(data, cap) = msg.kind else {
                panic!("unexpected message: {msg:?}")
            };
            chunks.push((data, cap));
        }

        let (sender, payload) = Payload::create(snd.stream().empty_capacity());
        let reader = Arc::new(Counter(AtomicUsize::new(0)));
        let reader_waker = reader.clone().into();
        let mut cx = Context::from_waker(&reader_waker);

        let (data, cap) = chunks.remove(0);
        sender.feed_data(data, cap);
        assert!(matches!(payload.poll_read(&mut cx), Poll::Ready(Some(Ok(ref d))) if d == "ab"));

        let (data, cap) = chunks.remove(0);
        sender.feed_data(data, cap);
        assert_eq!(reader.0.load(Ordering::SeqCst), 0);
        assert!(matches!(payload.poll_read(&mut cx), Poll::Ready(Some(Ok(ref d))) if d == "cd"));
    }

    /// Trailers are available after all queued data is read.
    #[crate::rt_test]
    async fn test_trailers_after_data() {
        let (io, server) = IoTest::create();
        io.remote_buffer_cap(64 * 1024);
        let client = SimpleClient::new(
            IoBoxed::from(Io::new(io, SharedCfg::default())),
            false,
            ByteString::from_static("localhost"),
        );
        server.write([0, 0, 0, 4, 0, 0, 0, 0, 0]);
        sleep(Millis(50)).await;
        let (snd, rcv) = client
            .send(Method::GET, "/".into(), HeaderMap::default(), true)
            .await
            .unwrap();

        // `200` response and a DATA frame
        server.write([0, 0, 1, 1, 4, 0, 0, 0, 1, 0x88]);
        server.write([0, 0, 2, 0, 0, 0, 0, 0, 1, b'a', b'b']);
        let _ = rcv.recv().await.unwrap();
        let msg = rcv.recv().await.unwrap();
        let h2::MessageKind::Data(data, cap) = msg.kind else {
            panic!("unexpected message: {msg:?}")
        };

        let (sender, payload) = Payload::create(snd.stream().empty_capacity());
        sender.feed_data(data, cap);
        let mut trailers = HeaderMap::default();
        trailers.insert(
            crate::http::header::HeaderName::from_static("x-trailer"),
            crate::http::header::HeaderValue::from_static("1"),
        );
        sender.feed_trailers(trailers);
        // ignored, the payload is complete
        sender.set_error(PayloadError::Incomplete(None));
        assert!(payload.trailers().is_none());

        assert_eq!(payload.read().await.unwrap().unwrap(), "ab");
        assert_eq!(payload.trailers().unwrap().get("x-trailer").unwrap(), "1");
        assert!(payload.read().await.is_none());
        assert!(payload.trailers().is_some());
    }

    #[crate::rt_test]
    async fn test_debug_and_stream() {
        use crate::util::stream_recv;

        let (io, server) = IoTest::create();
        io.remote_buffer_cap(64 * 1024);
        let client = SimpleClient::new(
            IoBoxed::from(Io::new(io, SharedCfg::default())),
            false,
            ByteString::from_static("localhost"),
        );
        server.write([0, 0, 0, 4, 0, 0, 0, 0, 0]);
        sleep(Millis(50)).await;
        let (snd, _rcv) = client
            .send(Method::GET, "/".into(), HeaderMap::default(), true)
            .await
            .unwrap();

        let (sender, mut payload) = Payload::create(snd.stream().empty_capacity());
        let s = format!("{payload:?}");
        assert!(s.contains("Inner") && s.contains("capacity"), "{s}");

        let mut trailers = HeaderMap::default();
        trailers.insert(
            crate::http::header::HeaderName::from_static("x-trailer"),
            crate::http::header::HeaderValue::from_static("1"),
        );
        sender.feed_trailers(trailers);
        assert!(stream_recv(&mut payload).await.is_none());
        assert_eq!(payload.trailers().unwrap().len(), 1);
    }
}