1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
//! Timer and rate-tracking state for keep-alive, request-head read-rate, and
//! request-payload read-rate handling.
use crate::io::{IoRef, cfg::FrameReadRate};
use crate::time::Seconds;
/// Dispatcher timer and read-rate state.
///
/// The transport has a single dispatcher timer, `active` records what it is
/// currently armed for.
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
pub(super) struct Timers {
pub(super) active: Timer,
pub(super) progress: ReadProgress,
/// Unused part of the period of a read timer suspended by a filter
/// pause, see [`Timers::suspend_read`].
pub(super) suspended: Option<Seconds>,
/// The write timer is not armed while the filter chain pauses writing.
pub(super) write_suspended: bool,
}
/// The purpose of the armed dispatcher timer.
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
pub(super) enum Timer {
Stopped,
/// New connection, waiting for the first byte of the first request.
/// The transport timer is armed only if request-head timing is
/// configured, otherwise waiting is unbounded.
ClientTimeout,
/// Idle persistent connection, waiting for the next request.
KeepAlive,
/// A request is processed after a keep-alive wait. The keep-alive timer is
/// left armed, so the next keep-alive wait can reuse it. Its expiry is
/// ignored, other timers stop it before they start.
Idle,
/// Request-head read rate.
Headers,
/// Request-payload read rate.
Payload,
/// Payload timing is paused by application or write backpressure, the
/// transport timer is stopped but the remaining budget is kept.
PayloadPaused,
/// Write backpressure timeout.
Write,
/// Write backpressure timeout, paused payload timing is restored once
/// backpressure is disabled.
WriteWithPayload,
}
impl Timer {
/// Returns `true` for the write backpressure timer.
pub(super) fn is_write(self) -> bool {
matches!(self, Timer::Write | Timer::WriteWithPayload)
}
}
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
pub(super) struct ReadProgress {
/// Application read buffer length at the last decode attempt.
pub(super) remains: u32,
/// Bytes received during the current rate period.
pub(super) consumed: u32,
/// Remaining cumulative read budget, after the current period.
pub(super) max_timeout: Seconds,
/// Unused part of the current period while payload timing is paused.
pub(super) period: Seconds,
}
impl ReadProgress {
const EMPTY: ReadProgress = ReadProgress {
remains: 0,
consumed: 0,
max_timeout: Seconds::ZERO,
period: Seconds::ZERO,
};
}
/// Splits the first period from the cumulative budget.
///
/// Returns the period to arm and the budget left after it.
pub(super) fn read_timeout(timeout: Seconds, max_timeout: Seconds) -> (Seconds, Seconds) {
if max_timeout.is_zero() {
(timeout, Seconds::ZERO)
} else {
let timeout = Seconds(timeout.0.min(max_timeout.0));
(timeout, Seconds(max_timeout.0.saturating_sub(timeout.0)))
}
}
impl Timers {
/// Starts the client timeout when request-head timing is configured, so
/// a new connection must start sending its first request in time.
///
/// Request-head read-rate timing starts with the first received byte.
///
/// A timer or timeout left on the transport does not apply to the new
/// dispatcher.
pub(super) fn new(io: &IoRef, headers: Option<FrameReadRate>) -> Self {
io.stop_timer();
if let Some(cfg) = headers {
io.start_timer(cfg.timeout);
}
Timers {
active: Timer::ClientTimeout,
progress: ReadProgress::EMPTY,
suspended: None,
write_suspended: false,
}
}
/// Arms the transport timer for a rate period of `timer`.
fn start(&mut self, io: &IoRef, timer: Timer, cfg: FrameReadRate, max_timeout: Seconds) {
let (timeout, max_timeout) = read_timeout(cfg.timeout, max_timeout);
self.stop_idle(io);
self.active = timer;
self.suspended = None;
self.progress.max_timeout = max_timeout;
io.start_timer(timeout);
}
/// Stops the transport timer and clears any pending timeout.
pub(super) fn stop(&mut self, io: &IoRef) {
self.active = Timer::Stopped;
self.suspended = None;
io.stop_timer();
}
/// Stops a keep-alive timer left armed, this also clears its expiry.
fn stop_idle(&mut self, io: &IoRef) {
if self.active == Timer::Idle {
self.stop(io);
}
}
/// Resets the state after a request head has been decoded.
///
/// A running write timer keeps running, buffered requests can be decoded
/// during write backpressure. A running keep-alive timer is left armed,
/// restarting it for every request of a persistent connection is not
/// needed.
pub(super) fn reset(&mut self, io: &IoRef) {
self.progress = ReadProgress::EMPTY;
self.suspended = None;
if self.active == Timer::KeepAlive {
self.active = Timer::Idle;
} else {
self.payload_done(io);
}
}
/// Stops payload timing after the payload has been decoded.
///
/// A running write timer keeps running.
pub(super) fn payload_done(&mut self, io: &IoRef) {
match self.active {
Timer::Write | Timer::WriteWithPayload => self.active = Timer::Write,
Timer::Idle => (),
_ => self.stop(io),
}
}
/// Starts the keep-alive timer for an idle connection, a running
/// keep-alive timer keeps running.
///
/// A keep-alive timer left armed is updated, it must not have a pending
/// expiry.
pub(super) fn start_keepalive(&mut self, io: &IoRef, timeout: Seconds) {
if self.active != Timer::KeepAlive {
log::debug!("{}: Start keep-alive timer {:?}", io.tag(), timeout);
self.active = Timer::KeepAlive;
self.suspended = None;
io.start_timer(timeout);
}
}
/// Starts request-head timing with a fresh budget.
///
/// Without a headers read rate, any timer is stopped.
pub(super) fn start_headers(
&mut self,
io: &IoRef,
cfg: Option<FrameReadRate>,
consumed: u32,
remains: u32,
) {
self.progress.remains = remains;
self.progress.consumed = consumed;
if let Some(cfg) = cfg {
log::debug!("{}: Start headers read timer {:?}", io.tag(), cfg.timeout);
self.start(io, Timer::Headers, cfg, cfg.max_timeout);
} else {
self.stop(io);
}
}
/// Records a request-head decode attempt, counting bytes received since
/// the previous attempt.
///
/// `buffered` is the application read buffer length before the attempt
/// and `remains` the length after it.
pub(super) fn headers_decoded(&mut self, buffered: u32, remains: u32) {
if self.active == Timer::Headers {
let p = &mut self.progress;
p.consumed = p
.consumed
.saturating_add(buffered.saturating_sub(p.remains));
p.remains = remains;
}
}
/// Starts request-payload timing with a fresh budget.
///
/// During write backpressure, payload timing starts paused and resumes
/// once backpressure is disabled.
pub(super) fn start_payload(&mut self, io: &IoRef, cfg: Option<FrameReadRate>) {
if let Some(cfg) = cfg {
self.progress.consumed = 0;
if self.active.is_write() {
let (period, max_timeout) = read_timeout(cfg.timeout, cfg.max_timeout);
self.progress.period = period;
self.progress.max_timeout = max_timeout;
self.active = Timer::WriteWithPayload;
} else {
log::debug!("{}: Start payload timer {:?}", io.tag(), cfg.timeout);
self.start(io, Timer::Payload, cfg, cfg.max_timeout);
}
}
}
/// Records payload bytes consumed during running payload timing.
pub(super) fn payload_consumed(&mut self, consumed: u32) {
if self.active == Timer::Payload {
self.progress.consumed = self.progress.consumed.saturating_add(consumed);
}
}
/// Records payload bytes consumed by a decode attempt.
///
/// Resumes paused payload timing, keeping the received bytes, the
/// unused part of the interrupted period, and the cumulative budget.
/// Stopped timing is not started, paused timing is not resumed while
/// the filter chain pauses reading.
pub(super) fn payload_decoded(&mut self, io: &IoRef, consumed: u32) {
match self.active {
Timer::Payload => self.payload_consumed(consumed),
Timer::PayloadPaused if !io.is_read_filter_paused() => {
let period = self.progress.period;
log::trace!("{}: Resume payload timer {:?}", io.tag(), period);
self.active = Timer::Payload;
self.payload_consumed(consumed);
self.progress.period = Seconds::ZERO;
if period.is_zero() {
// the interrupted period has expired, check the read rate
io.notify_timeout();
} else {
io.start_timer(period);
}
}
_ => (),
}
}
/// Pauses payload timing, keeping the unused part of the current period.
///
/// The period continues when payload timing resumes, a period that
/// expired before pausing is checked on resume.
pub(super) fn pause_payload(&mut self, io: &IoRef) {
if self.active == Timer::Payload {
self.progress.period = io.timer_handle().remains();
io.stop_timer();
self.active = Timer::PayloadPaused;
}
}
/// Suspends a running client, keep-alive or request-head timer while
/// the filter chain pauses reading, the peer is not charged for the
/// pause. Payload timing is paused.
///
/// The unused part of the current period is kept.
pub(super) fn suspend_read(&mut self, io: &IoRef) {
match self.active {
Timer::Payload => self.pause_payload(io),
Timer::ClientTimeout | Timer::KeepAlive | Timer::Headers
if self.suspended.is_none() && io.timer_handle().is_set() =>
{
log::trace!("{}: Suspend read timer {:?}", io.tag(), self.active);
self.suspended = Some(io.timer_handle().remains());
io.stop_timer();
}
_ => (),
}
}
/// Resumes a read timer suspended by a filter pause, a period that
/// expired before suspending is checked on resume.
///
/// Paused payload timing resumes with the next decoded payload.
pub(super) fn resume_read(&mut self, io: &IoRef) {
if let Some(period) = self.suspended.take() {
log::trace!("{}: Resume read timer {:?}", io.tag(), period);
if period.is_zero() {
io.notify_timeout();
} else {
io.start_timer(period);
}
}
}
/// Starts the write backpressure timer, a running write timer keeps
/// running.
///
/// Running payload timing is paused, other read timers are stopped.
/// The timer does not run while the filter chain pauses writing, the
/// peer is not charged for the pause, and starts over once writing
/// resumes.
pub(super) fn start_write(&mut self, io: &IoRef, timeout: Seconds) {
if timeout.is_zero() {
return;
}
if !self.active.is_write() {
log::debug!("{}: Start write timer {:?}", io.tag(), timeout);
self.pause_payload(io);
self.active = if self.active == Timer::PayloadPaused {
Timer::WriteWithPayload
} else {
Timer::Write
};
self.suspended = None;
self.write_suspended = true;
io.stop_timer();
}
if io.is_write_filter_paused() {
if !self.write_suspended {
log::trace!("{}: Suspend write timer", io.tag());
self.write_suspended = true;
io.stop_timer();
}
} else if self.write_suspended {
self.write_suspended = false;
io.start_timer(timeout);
}
}
/// Stops the write backpressure timer and restores paused payload timing.
pub(super) fn stop_write(&mut self, io: &IoRef) {
match self.active {
Timer::Write => {
io.stop_timer();
self.active = Timer::Stopped;
}
Timer::WriteWithPayload => {
io.stop_timer();
self.active = Timer::PayloadPaused;
}
_ => return,
}
self.write_suspended = false;
}
/// Handles expiry of a read-rate period.
///
/// Starts the next period and returns `true` if more than the required
/// number of bytes was received and the cumulative budget allows it.
pub(super) fn extend(&mut self, io: &IoRef, cfg: FrameReadRate) -> bool {
let p = &mut self.progress;
let total = p.consumed;
p.consumed = 0;
if total > cfg.rate {
let timeout = if cfg.max_timeout.is_zero() {
Some(cfg.timeout)
} else if p.max_timeout.is_zero() {
None
} else {
let (timeout, remaining) = read_timeout(cfg.timeout, p.max_timeout);
p.max_timeout = remaining;
Some(timeout)
};
if let Some(timeout) = timeout {
log::trace!("{}: Bytes read rate {:?}, extend timer", io.tag(), total);
io.start_timer(timeout);
return true;
}
}
false
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::io::{Io, testing::IoTest};
/// Decoding buffered requests during write backpressure does not restart
/// the write timer.
#[crate::rt_test]
async fn test_write_timer_survives_decoded_requests() {
let (_client, server) = IoTest::create();
let io = Io::from(server);
let io = io.get_ref();
let rate = Some(FrameReadRate {
rate: 1,
timeout: Seconds(2),
max_timeout: Seconds(10),
});
let mut timers = Timers::new(&io, None);
timers.start_write(&io, Seconds(5));
assert_eq!(timers.active, Timer::Write);
let deadline = io.timer_handle();
assert!(deadline.is_set());
timers.reset(&io);
assert_eq!(timers.active, Timer::Write);
timers.start_payload(&io, rate);
assert_eq!(timers.active, Timer::WriteWithPayload);
assert_eq!(timers.progress.period, Seconds(2));
assert_eq!(timers.progress.max_timeout, Seconds(8));
timers.payload_done(&io);
assert_eq!(timers.active, Timer::Write);
timers.start_write(&io, Seconds(5));
assert_eq!(io.timer_handle(), deadline);
timers.start_payload(&io, rate);
timers.stop_write(&io);
assert_eq!(timers.active, Timer::PayloadPaused);
assert!(!io.timer_handle().is_set());
}
/// Bytes consumed by a request-head decode attempt are not counted
/// again, and do not hide input received before the next attempt.
#[crate::rt_test]
async fn test_headers_progress_follows_decoded_input() {
let (_client, server) = IoTest::create();
let io = Io::from(server);
let io = io.get_ref();
let rate = Some(FrameReadRate {
rate: 1,
timeout: Seconds(2),
max_timeout: Seconds(10),
});
let mut timers = Timers::new(&io, None);
// 5 bytes of a partial head are buffered
timers.start_headers(&io, rate, 5, 5);
assert_eq!(timers.active, Timer::Headers);
// 7 bytes received, the decoder consumes 10 of 12 buffered bytes
timers.headers_decoded(12, 2);
assert_eq!(timers.progress.consumed, 12);
// 3 bytes received
timers.headers_decoded(5, 5);
assert_eq!(timers.progress.consumed, 15);
}
/// The keep-alive timer is not restarted for every request of a
/// persistent connection.
#[crate::rt_test]
async fn test_keepalive_timer_is_reused() {
let (_client, server) = IoTest::create();
let io = Io::from(server);
let ioref = io.get_ref();
let rate = Some(FrameReadRate {
rate: 1,
timeout: Seconds(2),
max_timeout: Seconds(10),
});
let mut timers = Timers::new(&ioref, None);
timers.reset(&ioref);
timers.start_keepalive(&ioref, Seconds(5));
let deadline = ioref.timer_handle();
assert!(deadline.is_set());
timers.reset(&ioref);
assert_eq!(timers.active, Timer::Idle);
assert_eq!(ioref.timer_handle(), deadline);
timers.payload_done(&ioref);
assert_eq!(timers.active, Timer::Idle);
timers.start_keepalive(&ioref, Seconds(5));
assert_eq!(timers.active, Timer::KeepAlive);
assert_eq!(ioref.timer_handle(), deadline);
// other timers do not see an expiry of the idle timer
timers.reset(&ioref);
ioref.notify_timeout();
timers.start_payload(&ioref, rate);
assert_eq!(timers.active, Timer::Payload);
assert!(
crate::util::lazy(|cx| io.poll_status_update(cx))
.await
.is_pending()
);
}
#[test]
fn test_read_timeout_is_bounded_by_maximum() {
let (timeout, remaining) = read_timeout(Seconds(10), Seconds(15));
assert_eq!(timeout, Seconds(10));
assert_eq!(remaining, Seconds(5));
let (timeout, remaining) = read_timeout(Seconds(10), remaining);
assert_eq!(timeout, Seconds(5));
assert_eq!(remaining, Seconds::ZERO);
let (timeout, remaining) = read_timeout(Seconds(10), Seconds(3));
assert_eq!(timeout, Seconds(3));
assert_eq!(remaining, Seconds::ZERO);
let (timeout, remaining) = read_timeout(Seconds(10), Seconds::ZERO);
assert_eq!(timeout, Seconds(10));
assert_eq!(remaining, Seconds::ZERO);
}
}