ntex-io 4.3.0

Utilities for abstracting io streams
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
use std::{any, cell::UnsafeCell, mem, ptr};

use crate::{Filter, FilterLayer, Layer, Sealed, filter::NullFilter};

enum Repr {
    Filter(*const u8, *const dyn Filter),
    Sealed(Box<dyn Filter>),
}

impl Repr {
    fn typed<F: Filter>(filter: F) -> Self {
        // derive the `dyn` pointer from the raw pointer, a reference taken
        // from the `Box` is invalidated by `Box::into_raw`
        let ptr = Box::into_raw(Box::new(filter));
        Repr::Filter(
            ptr.cast_const().cast(),
            ptr.cast_const() as *const dyn Filter,
        )
    }
}

impl Default for Repr {
    fn default() -> Self {
        Repr::Filter(ptr::null(), NullFilter::get())
    }
}

pub(crate) struct FilterPtr(UnsafeCell<Repr>);

impl FilterPtr {
    pub(crate) const fn null() -> Self {
        Self(UnsafeCell::new(Repr::Filter(
            ptr::null(),
            NullFilter::get(),
        )))
    }

    pub(crate) fn get(&self) -> &dyn Filter {
        match self.as_ref() {
            Repr::Filter(_, filter) => unsafe { filter.as_ref().unwrap() },
            Repr::Sealed(b) => b.as_ref(),
        }
    }

    pub(crate) fn set<F: Filter>(&self, filter: F) {
        *self.as_mut() = Repr::typed(filter);
    }

    /// Get filter, panic if it is not filter
    pub(crate) fn filter<F: Filter>(&self) -> &F {
        if let Repr::Filter(ptr, _) = self.as_ref() {
            assert!(!ptr.is_null(), "Filter is not set");
            unsafe { (*ptr).cast::<F>().as_ref().unwrap() }
        } else {
            panic!("Filter is sealed")
        }
    }

    #[allow(clippy::mut_from_ref)]
    fn as_mut(&self) -> &mut Repr {
        unsafe { &mut *self.0.get() }
    }

    fn as_ref(&self) -> &Repr {
        unsafe { &*self.0.get() }
    }

    #[allow(clippy::unnecessary_box_returns)]
    /// Get filter, panic if it is not set
    pub(crate) fn take_filter<F>(&self) -> Box<F> {
        if let Repr::Filter(ptr, _) = mem::take(self.as_mut()) {
            assert!(!ptr.is_null(), "Filter is not set");
            unsafe { Box::from_raw(ptr as *mut F) }
        } else {
            panic!("Filter is sealed")
        }
    }

    /// Get sealed, panic if it is already sealed
    fn take_sealed(&self) -> Sealed {
        if let Repr::Sealed(sealed) = mem::take(self.as_mut()) {
            Sealed(sealed)
        } else {
            panic!("Filter is not sealed")
        }
    }

    pub(crate) fn is_set(&self) -> bool {
        match self.as_ref() {
            Repr::Filter(ptr, _) => !ptr.is_null(),
            Repr::Sealed(_) => true,
        }
    }

    pub(crate) fn add_filter<F: Filter, T: FilterLayer>(&self, new: T) {
        assert!(self.is_set(), "Filter is not set");

        let repr = match self.as_ref() {
            Repr::Filter(..) => Repr::typed(Layer::new(new, *self.take_filter::<F>())),
            // The new layer is typed, only a bare `Sealed` stays in `Repr::Sealed`
            Repr::Sealed(..) => Repr::typed(Layer::new(new, self.take_sealed())),
        };
        *self.as_mut() = repr;
    }

    pub(crate) fn map_filter<F: Filter, U, R>(&self, f: U)
    where
        U: FnOnce(F) -> R,
        R: Filter,
    {
        *self.as_mut() = Repr::typed(f(self.take_owned::<F>()));
    }

    /// Takes the filter by value, `F` is `Sealed` if the filter is sealed
    fn take_owned<F: Filter>(&self) -> F {
        if matches!(self.as_ref(), Repr::Sealed(..)) {
            assert!(
                any::TypeId::of::<F>() == any::TypeId::of::<Sealed>(),
                "Filter is sealed"
            );
            let sealed = mem::ManuallyDrop::new(self.take_sealed());
            // Safety: `F` is `Sealed`
            unsafe { ptr::read(ptr::from_ref(&*sealed).cast::<F>()) }
        } else {
            *self.take_filter::<F>()
        }
    }

    pub(crate) fn seal<F: Filter>(&self) {
        assert!(self.is_set(), "Filter is not set");

        if matches!(self.as_ref(), Repr::Filter(..)) {
            *self.as_mut() = Repr::Sealed(Box::new(*self.take_filter::<F>()));
        }
    }

    /// Replaces the filter with `NullFilter` without dropping it.
    ///
    /// The filter is neither read nor moved, so it may be in use.
    pub(crate) fn leak(&self) {
        // SAFETY: the old value is overwritten without being read, a `Box`
        // holding the filter is not touched while the filter is borrowed
        unsafe { ptr::write(self.0.get(), Repr::default()) }
    }

    pub(crate) fn drop_filter<F>(&self) {
        if let Repr::Filter(ptr, _) = self.as_ref() {
            if !ptr.is_null() {
                self.take_filter::<F>();
            }
        } else {
            self.take_sealed();
        }
    }
}

#[cfg(test)]
mod tests {
    use std::{
        cell::Cell,
        io,
        rc::Rc,
        task::{Context, Poll},
    };

    use ntex_bytes::Bytes;
    use ntex_codec::BytesCodec;

    use super::*;
    use crate::{
        Base, FilterBuf, FilterCtx, Handle, Io, IoContext, IoStream, Readiness, testing::IoTest,
    };

    const BIN: &[u8] = b"GET /test HTTP/1\r\n\r\n";
    const TEXT: &str = "GET /test HTTP/1\r\n\r\n";

    #[derive(Debug)]
    struct DropFilter {
        p: Rc<Cell<usize>>,
    }

    impl Drop for DropFilter {
        fn drop(&mut self) {
            self.p.set(self.p.get() + 1);
        }
    }

    impl FilterLayer for DropFilter {
        fn process_read_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            buf.with_read_buffers(|src, dst| {
                if let Some(src) = src.take() {
                    dst.extend_from_slice(&src);
                }
                Ok(())
            })
        }

        fn process_write_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            buf.with_write_buffers(|src, dst| {
                src.move_to(dst);
                Ok(())
            })
        }
    }

    struct IoTestWrapper;

    impl IoStream for IoTestWrapper {
        fn start(self, _: IoContext) -> Box<dyn Handle> {
            Box::new(TestHandle)
        }
    }

    struct TestHandle;

    impl Handle for TestHandle {}

    #[ntex::test]
    async fn drop_filter() {
        let p = Rc::new(Cell::new(0));

        let (client, server) = IoTest::create();
        let f = DropFilter { p: p.clone() };
        let _ = format!("{f:?}");
        let io = Io::from(server).add_filter(f);

        client.remote_buffer_cap(1024);
        client.write(TEXT);
        let msg = io.recv(&BytesCodec).await.unwrap().unwrap();
        assert_eq!(msg, Bytes::from_static(BIN));

        io.send(Bytes::from_static(b"test"), &BytesCodec)
            .await
            .unwrap();
        let buf = client.read().await.unwrap();
        assert_eq!(buf, Bytes::from_static(b"test"));

        let io2 = unsafe { io.take() };
        let mut io3: crate::IoBoxed = io2.into();
        let io4 = io3.take();

        drop(io);
        drop(io3);
        drop(io4);

        assert_eq!(p.get(), 1);
    }

    #[test]
    fn miri_sealed_filter() {
        let p = Rc::new(Cell::new(0));
        let f = DropFilter { p: p.clone() };

        let io = Io::from(IoTestWrapper).seal();
        let _io: Io<Layer<DropFilter, Sealed>> = io.add_filter(f);
    }

    #[test]
    fn miri_sealed_layer_typed_access() {
        let p = Rc::new(Cell::new(0));

        let io = Io::from(IoTestWrapper).seal();
        let io = io.add_filter(DropFilter { p: p.clone() });
        assert!(Rc::ptr_eq(&io.filter().p, &p));

        let io = io.map_filter(|layer| layer);
        assert!(Rc::ptr_eq(&io.filter().p, &p));
        let io = io.add_filter(DropFilter { p: p.clone() });
        assert!(Rc::ptr_eq(&io.filter().p, &p));
        assert_eq!(p.get(), 0);

        drop(io);
        assert_eq!(p.get(), 2);
    }

    #[test]
    fn miri_sealed_map_filter() {
        let p = Rc::new(Cell::new(0));

        let io = Io::from(IoTestWrapper).seal();
        let io: Io<Sealed> = io.map_filter(|sealed| sealed);
        let io = io.map_filter(|sealed| Layer::new(DropFilter { p: p.clone() }, sealed));
        assert!(Rc::ptr_eq(&io.filter().p, &p));

        drop(io);
        assert_eq!(p.get(), 1);
    }

    #[ntex::test]
    async fn map_filter_panic_closes_connection() {
        let (client, server) = IoTest::create();
        client.remote_buffer_cap(1024);
        let io = Io::from(server);
        let ioref = io.get_ref();
        io.encode_slice(b"out").unwrap();

        let res = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
            io.map_filter(|_: Base| -> Base { panic!("map failed") })
        }));
        assert!(res.is_err());
        assert!(!ioref.is_active());
        drop(client);
    }

    type Hook = Rc<std::cell::RefCell<Option<Box<dyn FnOnce()>>>>;

    fn run(hook: &Hook) {
        let hook = hook.borrow_mut().take();
        if let Some(hook) = hook {
            hook();
        }
    }

    /// Where `HookFilter` runs its hook.
    #[derive(Clone, Copy, PartialEq)]
    enum At {
        /// From every callback.
        Any,
        /// From write processing only, read processing produces output.
        Write,
    }

    /// Runs a hook from its callbacks, to change the filter chain while it
    /// is in use.
    struct HookFilter {
        hook: Hook,
        at: At,
    }

    impl std::fmt::Debug for HookFilter {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            f.write_str("HookFilter")
        }
    }

    impl FilterLayer for HookFilter {
        fn query(&self, _: any::TypeId) -> Option<Box<dyn any::Any>> {
            if self.at == At::Any {
                run(&self.hook);
            }
            None
        }

        fn process_read_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            if self.at == At::Any {
                run(&self.hook);
            } else {
                buf.with_write_buffers(|_, dst| dst.extend_from_slice(b"reply"));
            }
            buf.with_read_buffers(|src, dst| {
                if let Some(src) = src.take() {
                    dst.extend_from_slice(&src);
                }
                Ok(())
            })
        }

        fn process_write_buf(&self, buf: &FilterBuf<'_>) -> io::Result<()> {
            run(&self.hook);
            buf.with_write_buffers(|src, dst| {
                src.move_to(dst);
                Ok(())
            })
        }
    }

    /// Runs a hook when the transport polls readiness.
    struct PollHook<F> {
        inner: F,
        hook: Hook,
        read: bool,
    }

    impl<F: Filter> Filter for PollHook<F> {
        fn query(&self, id: any::TypeId) -> Option<Box<dyn any::Any>> {
            self.inner.query(id)
        }

        fn shutdown(&self, ctx: &mut FilterCtx<'_>) -> io::Result<Poll<()>> {
            self.inner.shutdown(ctx)
        }

        fn process_read_buf(&self, ctx: &mut FilterCtx<'_>) -> io::Result<()> {
            self.inner.process_read_buf(ctx)
        }

        fn process_write_buf(&self, ctx: &mut FilterCtx<'_>) -> io::Result<()> {
            self.inner.process_write_buf(ctx)
        }

        fn poll_read_ready(&self, cx: &mut Context<'_>) -> Poll<Readiness> {
            if self.read {
                run(&self.hook);
            }
            self.inner.poll_read_ready(cx)
        }

        fn poll_write_ready(&self, cx: &mut Context<'_>) -> Poll<Readiness> {
            if !self.read {
                run(&self.hook);
            }
            self.inner.poll_write_ready(cx)
        }
    }

    #[derive(Clone, Copy, Debug)]
    enum Change {
        AddFilter,
        MapFilter,
        Seal,
        Drop,
    }

    impl Change {
        const ALL: [Change; 4] = [
            Change::AddFilter,
            Change::MapFilter,
            Change::Seal,
            Change::Drop,
        ];

        /// The result is leaked: without the check it would be dropped while
        /// the filter is in use.
        fn apply<F: Filter>(self, io: Io<F>) {
            match self {
                Change::AddFilter => mem::forget(io.add_filter(HookFilter {
                    hook: Hook::default(),
                    at: At::Any,
                })),
                Change::MapFilter => mem::forget(io.map_filter(|f| f)),
                Change::Seal => mem::forget(io.seal()),
                Change::Drop => drop(io),
            }
        }

        fn message(self) -> &'static str {
            if let Change::Drop = self {
                "Io is dropped while its filter is in use"
            } else {
                "filter chain is changed while it is in use"
            }
        }
    }

    /// Installs a hook in `slot` applying `change` to `io`, returns whether
    /// the change panicked once the hook ran.
    fn arm<F: Filter>(io: Io<F>, change: Change, slot: &Hook) -> Rc<Cell<Option<bool>>> {
        let panicked = Rc::new(Cell::new(None));
        let result = panicked.clone();
        *slot.borrow_mut() = Some(Box::new(move || {
            let res = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
                change.apply(io);
            }));
            if let Err(e) = &res {
                let msg = e.downcast_ref::<String>().unwrap();
                assert!(msg.contains(change.message()), "{msg}");
            }
            result.set(Some(res.is_err()));
        }));
        panicked
    }

    /// The filter chain cannot be changed, nor its `Io` dropped, from code run
    /// by the connection while it holds references into the chain.
    #[test]
    fn change_while_lent_panics() {
        type Enter = fn(&crate::IoRef, &Hook);
        let entries: [(&str, Enter); 6] = [
            ("with_read_src", |io, f| io.with_read_src(|_| run(f))),
            ("with_read_dst", |io, f| io.with_read_dst(|_| run(f))),
            ("with_write_src", |io, f| {
                io.with_write_src(|_| run(f)).unwrap();
            }),
            ("with_write_dst", |io, f| io.with_write_dst(|_| run(f))),
            ("with_buf", |io, f| io.with_buf(|_| run(f)).unwrap()),
            ("query", |io, _| assert!(io.query::<u8>().get().is_none())),
        ];

        for change in Change::ALL {
            for (name, enter) in entries {
                let slot = Hook::default();
                // only `query` runs the filter's hook
                let filter_hook = if name == "query" {
                    slot.clone()
                } else {
                    Hook::default()
                };
                let io = Io::from(IoTestWrapper).add_filter(HookFilter {
                    hook: filter_hook,
                    at: At::Any,
                });
                let ioref = io.get_ref();
                let panicked = arm(io, change, &slot);
                enter(&ioref, &slot);
                assert_eq!(panicked.get(), Some(true), "{change:?} from {name}");
                if let Change::Drop = change {
                    assert!(!ioref.is_active(), "{name}");
                }
            }
        }
    }

    /// The filter chain cannot be changed, nor its `Io` dropped, from the
    /// filters while they process input or output, or report readiness.
    #[ntex::test]
    async fn change_from_filter_panics() {
        for change in Change::ALL {
            for trigger in ["read", "write", "read-reply", "read-ready", "write-ready"] {
                let (client, server) = IoTest::create();
                client.remote_buffer_cap(1024);
                let slot = Hook::default();
                let poll = trigger.ends_with("-ready");
                let io = Io::from(server).add_filter(HookFilter {
                    hook: if poll { Hook::default() } else { slot.clone() },
                    at: if trigger == "read-reply" {
                        At::Write
                    } else {
                        At::Any
                    },
                });
                let ioref = io.get_ref();
                let panicked = if poll {
                    let hook = slot.clone();
                    let read = trigger == "read-ready";
                    arm(
                        io.map_filter(|inner| PollHook { inner, hook, read }),
                        change,
                        &slot,
                    )
                } else {
                    arm(io, change, &slot)
                };

                if trigger.starts_with("read") {
                    client.write(TEXT);
                } else {
                    let _ = ioref.encode_slice(b"out");
                }
                for _ in 0..100 {
                    if panicked.get().is_some() {
                        break;
                    }
                    ntex_util::time::sleep(ntex_util::time::Millis(10)).await;
                }
                assert_eq!(panicked.get(), Some(true), "{change:?} from {trigger}");
                if let Change::Drop = change {
                    assert!(!ioref.is_active(), "{trigger}");
                }
            }
        }
    }

    /// An `Io` dropped while its filter is in use leaks the filter, the
    /// connection is closed and the filter chain no longer runs.
    #[test]
    fn drop_while_lent_leaks_filter() {
        let p = Rc::new(Cell::new(0));
        let slot = Hook::default();
        let io = Io::from(IoTestWrapper)
            .add_filter(HookFilter {
                hook: slot.clone(),
                at: At::Any,
            })
            .add_filter(DropFilter { p: p.clone() });
        let ioref = io.get_ref();
        let panicked = arm(io, Change::Drop, &slot);
        assert!(ioref.query::<u8>().get().is_none());
        assert_eq!(panicked.get(), Some(true));
        assert!(!ioref.is_active());
        assert_eq!(p.get(), 0);

        let ran = Rc::new(Cell::new(false));
        let r = ran.clone();
        *slot.borrow_mut() = Some(Box::new(move || r.set(true)));
        assert!(ioref.query::<u8>().get().is_none());
        assert!(!ran.get());

        drop(ioref);
        assert_eq!(p.get(), 0);
    }

    /// An `Io` dropped while unwinding from its filter does not panic again,
    /// that would abort.
    #[test]
    fn drop_while_lent_unwinding() {
        let slot = Hook::default();
        let io = Io::from(IoTestWrapper).add_filter(HookFilter {
            hook: slot.clone(),
            at: At::Any,
        });
        let ioref = io.get_ref();
        *slot.borrow_mut() = Some(Box::new(move || {
            let _io = io;
            panic!("hook failed");
        }));

        let res = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
            ioref.query::<u8>().get().is_none()
        }));
        let err = res.unwrap_err();
        assert_eq!(err.downcast_ref::<&str>(), Some(&"hook failed"));
        assert!(!ioref.is_active());
    }

    #[test]
    #[should_panic(expected = "Filter is not set")]
    fn miri_filter_access() {
        let fptr = FilterPtr::null();
        fptr.filter::<Base>();
    }
}