1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
//! HandleLocker - database handle locker.
//!
use hashbrown::HashSet;
use std::sync::Arc;
use crate::lock_manager::LockManager;
use crate::locker::Locker;
use crate::{LockResult, LockType, TxnError};
/// A locker for database handle locks.
///
/// HandleLocker holds locks for the lifetime of a database handle (Database object).
/// Unlike BasicLocker, these locks persist until the handle is closed, not just
/// for the duration of an API call.
///
/// The primary use case is holding a read lock on a NameLN to prevent
/// database rename, removal, or truncation while the database is open.
///
/// HandleLocker can share locks with another locker (the one used to open
/// the database) to avoid conflicts during the open operation.
///
///
pub struct HandleLocker {
/// Unique locker ID.
id: i64,
/// Shared lock manager.
lock_manager: Arc<LockManager>,
/// Set of LSNs currently locked by this locker.
locked_lsns: HashSet<u64>,
/// Lock timeout in milliseconds (0 = infinite).
lock_timeout_ms: u64,
/// Whether this locker is open.
is_open: bool,
/// ID of a transaction locker we share locks with (if any).
share_with_txn_id: Option<i64>,
}
impl HandleLocker {
/// Creates a new HandleLocker.
///
/// # Arguments
/// * `id` - Unique locker ID
/// * `lock_manager` - Shared lock manager
pub fn new(id: i64, lock_manager: Arc<LockManager>) -> Self {
HandleLocker {
id,
lock_manager,
locked_lsns: HashSet::new(),
lock_timeout_ms: 5000, // Default 5 second timeout
is_open: true,
share_with_txn_id: None,
}
}
/// Creates a HandleLocker with a specified timeout.
pub fn with_timeout(
id: i64,
lock_manager: Arc<LockManager>,
timeout_ms: u64,
) -> Self {
HandleLocker {
id,
lock_manager,
locked_lsns: HashSet::new(),
lock_timeout_ms: timeout_ms,
is_open: true,
share_with_txn_id: None,
}
}
/// Creates a HandleLocker that shares locks with another locker.
///
/// This is used during database open to ensure the HandleLocker and
/// the opening locker can both hold NameLN locks without conflict.
pub fn with_buddy(
id: i64,
lock_manager: Arc<LockManager>,
buddy_locker: &dyn Locker,
) -> Self {
let share_with = if buddy_locker.is_transactional() {
Some(buddy_locker.id())
} else {
None
};
let locker = HandleLocker {
id,
lock_manager,
locked_lsns: HashSet::new(),
lock_timeout_ms: 5000,
is_open: true,
share_with_txn_id: share_with,
};
if let Some(bid) = share_with {
locker.register_buddy_sharing(bid);
}
locker
}
/// Release all locks held by this locker.
pub fn release_all_locks(&mut self) -> Result<(), TxnError> {
for &lsn in &self.locked_lsns {
self.lock_manager.release(lsn, self.id)?;
}
self.locked_lsns.clear();
Ok(())
}
/// Sets the lock timeout.
pub fn set_lock_timeout(&mut self, timeout_ms: u64) {
self.lock_timeout_ms = timeout_ms;
}
/// Registers sharing with a buddy locker in the LockManager sharing registry.
///
/// Called internally by `with_buddy()` so that `LockImpl::try_lock()` can
/// bypass conflict detection between this HandleLocker and its buddy txn.
fn register_buddy_sharing(&self, buddy_id: i64) {
self.lock_manager.register_locker_sharing(self.id, buddy_id);
}
}
impl Locker for HandleLocker {
/// Returns true if this locker shares locks with the given locker.
///
/// HandleLocker shares with its buddy transaction (if any), allowing the
/// database-open locker and the handle locker to co-own NameLN locks.
///
///
fn shares_locks_with(&self, other_locker_id: i64) -> bool {
if let Some(buddy_id) = self.share_with_txn_id {
buddy_id == other_locker_id
} else {
false
}
}
fn id(&self) -> i64 {
self.id
}
fn lock(
&mut self,
lsn: u64,
lock_type: LockType,
non_blocking: bool,
) -> Result<LockResult, TxnError> {
if !self.is_open {
return Err(TxnError::StateError("Locker is closed".to_string()));
}
// Ask the lock manager for the lock
let grant = self.lock_manager.lock(
lsn,
self.id,
lock_type,
non_blocking,
false, // jump_ahead
)?;
// Track this lock
if grant.is_granted() {
self.locked_lsns.insert(lsn);
}
// HandleLocker doesn't track write lock info (non-transactional)
Ok(LockResult::simple(grant))
}
fn release_lock(&mut self, lsn: u64) -> Result<(), TxnError> {
if self.locked_lsns.remove(&lsn) {
self.lock_manager.release(lsn, self.id)?;
}
Ok(())
}
fn owns_write_lock(&self, lsn: u64) -> bool {
self.lock_manager.is_owned_write_lock(lsn, self.id)
}
fn is_transactional(&self) -> bool {
false
}
fn lock_timeout_ms(&self) -> u64 {
self.lock_timeout_ms
}
fn close(&mut self) {
self.is_open = false;
let _ = self.release_all_locks();
}
fn is_open(&self) -> bool {
self.is_open
}
}
impl Drop for HandleLocker {
fn drop(&mut self) {
// Ensure locks are released when locker is dropped
let _ = self.release_all_locks();
}
}
#[cfg(test)]
mod tests {
use super::*;
fn setup() -> (Arc<LockManager>, HandleLocker) {
let lm = Arc::new(LockManager::new());
let locker = HandleLocker::new(1, lm.clone());
(lm, locker)
}
#[test]
fn test_new() {
let (_, locker) = setup();
assert_eq!(locker.id(), 1);
assert!(!locker.is_transactional());
assert!(locker.is_open());
assert_eq!(locker.lock_timeout_ms(), 5000);
}
#[test]
fn test_lock_and_release() {
let (_, mut locker) = setup();
// Acquire a write lock
let result = locker.lock(100, LockType::Write, false).unwrap();
assert!(result.is_granted());
// Check that we own the lock
assert!(locker.owns_write_lock(100));
// Release the lock
locker.release_lock(100).unwrap();
assert!(!locker.owns_write_lock(100));
}
#[test]
fn test_release_all_locks() {
let (_, mut locker) = setup();
// Acquire multiple locks (typical for database handles holding NameLN locks)
locker.lock(100, LockType::Read, false).unwrap();
locker.lock(200, LockType::Read, false).unwrap();
locker.release_all_locks().unwrap();
// In a real implementation, we'd verify the locks are released
assert!(locker.locked_lsns.is_empty());
}
#[test]
fn test_close_releases_locks() {
let (_, mut locker) = setup();
locker.lock(100, LockType::Read, false).unwrap();
assert!(locker.is_open());
locker.close();
assert!(!locker.is_open());
assert!(locker.locked_lsns.is_empty());
}
#[test]
fn test_with_timeout() {
let lm = Arc::new(LockManager::new());
let locker = HandleLocker::with_timeout(1, lm, 10000);
assert_eq!(locker.lock_timeout_ms(), 10000);
}
#[test]
fn test_long_lived_lock() {
let (_, mut locker) = setup();
// HandleLocker is designed to hold locks for long periods
locker.lock(100, LockType::Read, false).unwrap();
// Lock persists across multiple operations (unlike BasicLocker)
// This models holding a NameLN lock while database is open
assert!(
locker.owns_write_lock(100) || locker.locked_lsns.contains(&100)
);
// Lock only released on close
locker.close();
assert!(locker.locked_lsns.is_empty());
}
#[test]
fn test_shares_locks_with() {
let lm = Arc::new(LockManager::new());
let locker = HandleLocker::new(1, lm);
// No buddy, so doesn't share with anyone
assert!(!locker.shares_locks_with(2));
assert!(!locker.shares_locks_with(3));
}
}