noxu-log 3.2.0

Log-structured storage engine for Noxu DB
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
//! IN file reader for recovery.
//!
//!
//! Scans log files for Internal Node (IN, BIN, BINDelta) entries during
//! recovery's **IN rebuild** pass.  Optionally tracks the maximum node ID,
//! database ID, and transaction ID seen (used to update ID sequence counters
//! at the end of recovery).

use crate::entry::bin_delta_log_entry::BinDeltaLogEntry;
use crate::entry::in_log_entry::InLogEntry;
use crate::entry_header::{MAX_HEADER_SIZE, MIN_HEADER_SIZE};
use crate::entry_type::LogEntryType;
use crate::error::{NoxuLogError, Result};
use crate::file_reader::LogFileAccess;
use hashbrown::HashSet;
use noxu_util::lsn::{Lsn, NULL_LSN};

// Maximum plausible payload size (64 MiB).
const MAX_SANE_ITEM_SIZE: usize = 64 * 1024 * 1024;

/// Parsed IN/BINDelta entry held after a successful `read_next_entry()` call.
enum CurrentEntry {
    /// Full IN or BIN node entry.
    In { entry: InLogEntry, is_bin_delta: bool },
    /// BIN delta entry.
    BinDelta(BinDeltaLogEntry),
}

impl CurrentEntry {
    fn db_id(&self) -> u64 {
        match self {
            CurrentEntry::In { entry, .. } => entry.db_id,
            CurrentEntry::BinDelta(e) => e.db_id,
        }
    }

    fn is_bin_delta(&self) -> bool {
        matches!(self, CurrentEntry::BinDelta(_))
    }
}

/// Scans log files for IN/BIN/BINDelta entries during recovery.
///
///
///
/// ## Usage
///
/// ```ignore
/// let mut reader = INFileReader::new(file_access, buf_size, start_lsn, finish_lsn)?;
/// reader.add_target_type(LogEntryType::IN);
/// reader.add_target_type(LogEntryType::BIN);
/// reader.add_target_type(LogEntryType::BINDelta);
/// while reader.read_next_entry()? {
///     let db_id = reader.get_database_id();
///     let is_delta = reader.is_bin_delta();
/// }
/// let max_node = reader.get_max_node_id();
/// ```
pub struct INFileReader<F: LogFileAccess> {
    /// File access interface.
    file_access: F,
    /// Starting LSN.
    start_lsn: Lsn,
    /// Stop before this LSN (`NULL_LSN` = no limit).
    finish_lsn: Lsn,
    /// Entry types this reader should return.
    target_types: HashSet<LogEntryType>,
    /// Current file number being scanned.
    current_file_num: u32,
    /// Current byte offset within the current file.
    current_offset: u64,
    /// LSN of the most-recently returned entry.
    current_lsn: Lsn,
    /// Parsed current entry.
    current_entry: Option<CurrentEntry>,
    /// Whether we have reached the end of the log.
    eof: bool,
    // --- ID tracking ---
    /// Maximum node ID seen (across all IN/BIN entries).
    max_node_id: u64,
    /// Maximum database ID seen (across all IN entries).
    max_db_id: u64,
}

impl<F: LogFileAccess> INFileReader<F> {
    /// Create a new INFileReader.
    ///
    /// # Arguments
    /// * `file_access`      – file I/O provider
    /// * `_read_buffer_size`– ignored (kept for API compatibility)
    /// * `start_lsn`        – where to begin scanning
    /// * `finish_lsn`       – stop before this LSN (`NULL_LSN` = no limit)
    pub fn new(
        file_access: F,
        _read_buffer_size: usize,
        start_lsn: Lsn,
        finish_lsn: Lsn,
    ) -> Result<Self> {
        let (current_file_num, current_offset, eof) = if !start_lsn.is_null() {
            (start_lsn.file_number(), start_lsn.file_offset() as u64, false)
        } else if let Some(first) = file_access.get_first_file_num() {
            (first, 0u64, false)
        } else {
            (0u32, 0u64, true)
        };

        Ok(INFileReader {
            file_access,
            start_lsn,
            finish_lsn,
            target_types: HashSet::new(),
            current_file_num,
            current_offset,
            current_lsn: NULL_LSN,
            current_entry: None,
            eof,
            max_node_id: 0,
            max_db_id: 0,
        })
    }

    /// Register a log entry type that this reader should return.
    ///
    ///
    pub fn add_target_type(&mut self, entry_type: LogEntryType) {
        self.target_types.insert(entry_type);
    }

    /// Advance to the next matching log entry.
    ///
    /// Returns `Ok(true)` when an entry was found; `Ok(false)` at end of log.
    ///
    /// See `INFileReader.isTargetEntry()` and `INFileReader.processEntry()`.
    pub fn read_next_entry(&mut self) -> Result<bool> {
        if self.eof {
            return Ok(false);
        }

        loop {
            match self.read_one_raw_entry()? {
                None => return Ok(false),
                Some((lsn, entry_type, payload)) => {
                    // Enforce finish_lsn upper bound.
                    if !self.finish_lsn.is_null() && lsn >= self.finish_lsn {
                        self.eof = true;
                        return Ok(false);
                    }

                    // Update max IDs regardless of whether it is a target.
                    self.update_max_ids(entry_type, &payload);

                    // Return only if in target set.
                    if !self.target_types.contains(&entry_type) {
                        continue;
                    }

                    let parsed = self.parse_entry(entry_type, &payload)?;
                    self.current_lsn = lsn;
                    self.current_entry = Some(parsed);
                    return Ok(true);
                }
            }
        }
    }

    // ------------------------------------------------------------------
    // Accessor methods (valid after read_next_entry() == Ok(true))
    // ------------------------------------------------------------------

    /// Returns the database ID from the current IN entry.
    pub fn get_database_id(&self) -> u64 {
        self.current_entry.as_ref().map(|e| e.db_id()).unwrap_or(0)
    }

    /// Returns `true` if the current entry is a BIN delta.
    pub fn is_bin_delta(&self) -> bool {
        self.current_entry.as_ref().map(|e| e.is_bin_delta()).unwrap_or(false)
    }

    /// Returns the maximum node ID seen across all scanned IN/BIN entries.
    pub fn get_max_node_id(&self) -> u64 {
        self.max_node_id
    }

    /// Returns the maximum database ID seen across all scanned entries.
    pub fn get_max_db_id(&self) -> u64 {
        self.max_db_id
    }

    /// Returns the LSN of the most-recently returned entry.
    pub fn get_current_lsn(&self) -> Lsn {
        self.current_lsn
    }

    // ------------------------------------------------------------------
    // Internal helpers
    // ------------------------------------------------------------------

    /// Read one raw entry from the current log position.
    fn read_one_raw_entry(
        &mut self,
    ) -> Result<Option<(Lsn, LogEntryType, Vec<u8>)>> {
        loop {
            let file_len =
                match self.file_access.get_file_length(self.current_file_num) {
                    Ok(l) => l,
                    Err(_) => {
                        self.eof = true;
                        return Ok(None);
                    }
                };

            if self.current_offset >= file_len {
                match self
                    .file_access
                    .get_following_file_num(self.current_file_num, true)
                {
                    None => {
                        self.eof = true;
                        return Ok(None);
                    }
                    Some(next) => {
                        self.current_file_num = next;
                        self.current_offset = 0;
                        continue;
                    }
                }
            }

            let mut hdr = [0u8; MIN_HEADER_SIZE];
            let n = self.file_access.read_from_file(
                self.current_file_num,
                self.current_offset,
                &mut hdr,
            )?;
            if n < MIN_HEADER_SIZE {
                self.eof = true;
                return Ok(None);
            }

            if hdr[4] == 0 {
                self.eof = true;
                return Ok(None);
            }

            let entry_type_num = hdr[4];
            let flags = hdr[5];
            let item_size =
                u32::from_le_bytes([hdr[10], hdr[11], hdr[12], hdr[13]])
                    as usize;

            if item_size > MAX_SANE_ITEM_SIZE {
                self.eof = true;
                return Ok(None);
            }

            let vlsn_present = (flags & 0x08) != 0 || (flags & 0x20) != 0;
            let header_size =
                if vlsn_present { MAX_HEADER_SIZE } else { MIN_HEADER_SIZE };
            let entry_size = header_size + item_size;

            if self.current_offset + entry_size as u64 > file_len {
                self.eof = true;
                return Ok(None);
            }

            let mut full_buf = vec![0u8; entry_size];
            let n = self.file_access.read_from_file(
                self.current_file_num,
                self.current_offset,
                &mut full_buf,
            )?;
            if n < entry_size {
                self.eof = true;
                return Ok(None);
            }

            let lsn =
                Lsn::new(self.current_file_num, self.current_offset as u32);
            self.current_offset += entry_size as u64;

            let entry_type = match LogEntryType::from_type_num(entry_type_num) {
                Some(t) => t,
                None => continue,
            };

            let payload = full_buf[header_size..].to_vec();
            return Ok(Some((lsn, entry_type, payload)));
        }
    }

    /// Update `max_node_id` and `max_db_id` from an IN/BIN/BINDelta entry.
    ///
    /// Id-tracking logic inside `INFileReader.processEntry()`.
    fn update_max_ids(&mut self, entry_type: LogEntryType, payload: &[u8]) {
        match entry_type {
            LogEntryType::IN | LogEntryType::BIN => {
                if let Ok(e) = InLogEntry::read_from_log(payload)
                    && e.db_id > self.max_db_id
                {
                    self.max_db_id = e.db_id;
                }
                // node_id is embedded in opaque node_data; we cannot
                // extract it without noxu-tree, so max_node_id stays 0.
            }
            LogEntryType::BINDelta => {
                if let Ok(e) = BinDeltaLogEntry::read_from_log(payload)
                    && e.db_id > self.max_db_id
                {
                    self.max_db_id = e.db_id;
                }
            }
            _ => {}
        }
    }

    /// Parse a raw payload into a `CurrentEntry`.
    fn parse_entry(
        &self,
        entry_type: LogEntryType,
        payload: &[u8],
    ) -> Result<CurrentEntry> {
        match entry_type {
            LogEntryType::IN | LogEntryType::BIN => {
                let e = InLogEntry::read_from_log(payload).map_err(|err| {
                    NoxuLogError::Internal(format!("IN parse error: {err}"))
                })?;
                let is_delta = e.is_bin_delta();
                Ok(CurrentEntry::In { entry: e, is_bin_delta: is_delta })
            }
            LogEntryType::BINDelta => {
                let e = BinDeltaLogEntry::read_from_log(payload).map_err(
                    |err| {
                        NoxuLogError::Internal(format!(
                            "BINDelta parse error: {err}"
                        ))
                    },
                )?;
                Ok(CurrentEntry::BinDelta(e))
            }
            _ => Err(NoxuLogError::LogCorrupt(format!(
                "INFileReader: unexpected entry type {:?}",
                entry_type
            ))),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::entry::bin_delta_log_entry::BinDeltaLogEntry;
    use crate::entry::in_log_entry::InLogEntry;
    use crate::entry_header::MIN_HEADER_SIZE;
    use crate::entry_type::LogEntryType;
    use bytes::BytesMut;
    use noxu_util::lsn::NULL_LSN;
    use std::collections::HashMap;
    use std::io;

    // ------------------------------------------------------------------
    // Mock file access
    // ------------------------------------------------------------------

    struct MockFileAccess {
        files: HashMap<u32, Vec<u8>>,
    }

    impl MockFileAccess {
        fn new() -> Self {
            MockFileAccess { files: HashMap::new() }
        }

        fn add_file(&mut self, file_num: u32, data: Vec<u8>) {
            self.files.insert(file_num, data);
        }
    }

    impl LogFileAccess for MockFileAccess {
        fn read_from_file(
            &self,
            file_num: u32,
            offset: u64,
            buf: &mut [u8],
        ) -> Result<usize> {
            if let Some(data) = self.files.get(&file_num) {
                let start = offset as usize;
                if start >= data.len() {
                    return Ok(0);
                }
                let end = (start + buf.len()).min(data.len());
                let n = end - start;
                buf[..n].copy_from_slice(&data[start..end]);
                Ok(n)
            } else {
                Err(io::Error::new(io::ErrorKind::NotFound, "File not found")
                    .into())
            }
        }

        fn get_file_length(&self, file_num: u32) -> Result<u64> {
            self.files.get(&file_num).map(|d| d.len() as u64).ok_or_else(|| {
                io::Error::new(io::ErrorKind::NotFound, "File not found").into()
            })
        }

        fn get_first_file_num(&self) -> Option<u32> {
            self.files.keys().min().copied()
        }

        fn get_following_file_num(
            &self,
            file_num: u32,
            forward: bool,
        ) -> Option<u32> {
            let mut nums: Vec<u32> = self.files.keys().copied().collect();
            nums.sort();
            if forward {
                nums.iter().find(|&&n| n > file_num).copied()
            } else {
                nums.iter().rev().find(|&&n| n < file_num).copied()
            }
        }

        fn get_file_header_prev_offset(&self, _file_num: u32) -> Result<u64> {
            Ok(0)
        }
    }

    // ------------------------------------------------------------------
    // Helpers
    // ------------------------------------------------------------------

    fn make_raw_entry(entry_type: LogEntryType, payload: &[u8]) -> Vec<u8> {
        let item_size = payload.len() as u32;
        let mut buf = vec![0u8; MIN_HEADER_SIZE + payload.len()];
        buf[4] = entry_type.type_num();
        buf[10..14].copy_from_slice(&item_size.to_le_bytes());
        buf[MIN_HEADER_SIZE..].copy_from_slice(payload);
        buf
    }

    fn make_in_payload(db_id: u64) -> Vec<u8> {
        let e =
            InLogEntry::new(db_id, NULL_LSN, NULL_LSN, b"node_data".to_vec());
        let mut buf = BytesMut::new();
        e.write_to_log(&mut buf);
        buf.to_vec()
    }

    fn make_bin_delta_payload(db_id: u64) -> Vec<u8> {
        let e = BinDeltaLogEntry::new(
            db_id,
            NULL_LSN,
            NULL_LSN,
            b"delta_data".to_vec(),
        );
        let mut buf = BytesMut::new();
        e.write_to_log(&mut buf);
        buf.to_vec()
    }

    // ------------------------------------------------------------------
    // Construction tests
    // ------------------------------------------------------------------

    #[test]
    fn test_in_file_reader_new_with_file() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![0u8; 64]);
        let result = INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN);
        assert!(result.is_ok());
    }

    #[test]
    fn test_in_file_reader_new_no_files() {
        let mock = MockFileAccess::new();
        let result = INFileReader::new(mock, 512, NULL_LSN, NULL_LSN);
        assert!(result.is_ok());
    }

    #[test]
    fn test_in_file_reader_with_finish_lsn() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![0u8; 256]);
        let result =
            INFileReader::new(mock, 1024, Lsn::new(0, 0), Lsn::new(0, 128));
        assert!(result.is_ok());
    }

    #[test]
    fn test_in_file_reader_multiple_files() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![0u8; 100]);
        mock.add_file(1, vec![0u8; 200]);
        let result = INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN);
        assert!(result.is_ok());
    }

    #[test]
    fn test_in_file_reader_varying_buffer_sizes() {
        for &buf_size in &[64usize, 512, 2048, 8192] {
            let mut mock = MockFileAccess::new();
            mock.add_file(0, vec![0u8; 50]);
            let result =
                INFileReader::new(mock, buf_size, Lsn::new(0, 0), NULL_LSN);
            assert!(result.is_ok(), "failed for buf_size {}", buf_size);
        }
    }

    // ------------------------------------------------------------------
    // Functional tests
    // ------------------------------------------------------------------

    #[test]
    fn test_read_in_entry() {
        let payload = make_in_payload(42);
        let raw = make_raw_entry(LogEntryType::IN, &payload);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, raw);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);

        assert!(reader.read_next_entry().unwrap());
        assert_eq!(reader.get_database_id(), 42);
        assert!(!reader.is_bin_delta());
    }

    #[test]
    fn test_read_bin_entry() {
        let payload = make_in_payload(55);
        let raw = make_raw_entry(LogEntryType::BIN, &payload);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, raw);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::BIN);

        assert!(reader.read_next_entry().unwrap());
        assert_eq!(reader.get_database_id(), 55);
        assert!(!reader.is_bin_delta());
    }

    #[test]
    fn test_read_bin_delta_entry() {
        let payload = make_bin_delta_payload(77);
        let raw = make_raw_entry(LogEntryType::BINDelta, &payload);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, raw);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::BINDelta);

        assert!(reader.read_next_entry().unwrap());
        assert_eq!(reader.get_database_id(), 77);
        assert!(reader.is_bin_delta());
    }

    #[test]
    fn test_skip_non_target() {
        // File: Trace (skipped) then IN (targeted).
        let trace_raw = make_raw_entry(LogEntryType::Trace, b"hello");
        let in_payload = make_in_payload(11);
        let in_raw = make_raw_entry(LogEntryType::IN, &in_payload);
        let mut data = trace_raw;
        data.extend_from_slice(&in_raw);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, data);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);

        assert!(reader.read_next_entry().unwrap());
        assert_eq!(reader.get_database_id(), 11);

        assert!(!reader.read_next_entry().unwrap());
    }

    #[test]
    fn test_max_db_id_tracking() {
        // Two IN entries with different db_ids; max_db_id should be the larger.
        let p1 = make_in_payload(100);
        let r1 = make_raw_entry(LogEntryType::IN, &p1);
        let p2 = make_in_payload(200);
        let r2 = make_raw_entry(LogEntryType::IN, &p2);
        let mut data = r1;
        data.extend_from_slice(&r2);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, data);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);

        while reader.read_next_entry().unwrap() {}

        assert_eq!(reader.get_max_db_id(), 200);
    }

    #[test]
    fn test_finish_lsn_stops_reading() {
        let payload = make_in_payload(3);
        let raw = make_raw_entry(LogEntryType::IN, &payload);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, raw);

        let mut reader = INFileReader::new(
            mock,
            512,
            Lsn::new(0, 0),
            Lsn::new(0, 0), // finish at very start
        )
        .unwrap();
        reader.add_target_type(LogEntryType::IN);

        assert!(!reader.read_next_entry().unwrap());
    }

    #[test]
    fn test_eof_on_empty_file() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![]);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);

        assert!(!reader.read_next_entry().unwrap());
    }

    #[test]
    fn test_eof_on_no_files() {
        let mock = MockFileAccess::new();
        let mut reader =
            INFileReader::new(mock, 512, NULL_LSN, NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);
        assert!(!reader.read_next_entry().unwrap());
    }

    #[test]
    fn test_get_max_node_id_initial_zero() {
        let mock = MockFileAccess::new();
        let reader = INFileReader::new(mock, 512, NULL_LSN, NULL_LSN).unwrap();
        assert_eq!(reader.get_max_node_id(), 0);
    }

    #[test]
    fn test_current_lsn_after_read() {
        let payload = make_in_payload(5);
        let raw = make_raw_entry(LogEntryType::IN, &payload);

        let mut mock = MockFileAccess::new();
        mock.add_file(0, raw);

        let mut reader =
            INFileReader::new(mock, 512, Lsn::new(0, 0), NULL_LSN).unwrap();
        reader.add_target_type(LogEntryType::IN);

        assert!(reader.read_next_entry().unwrap());
        assert_eq!(reader.get_current_lsn().file_number(), 0);
    }

    // ------------------------------------------------------------------
    // Branch-coverage for MockFileAccess
    // ------------------------------------------------------------------

    #[test]
    fn test_mock_read_from_file_missing() {
        let mock = MockFileAccess::new();
        let mut buf = [0u8; 4];
        assert!(mock.read_from_file(99, 0, &mut buf).is_err());
    }

    #[test]
    fn test_mock_read_from_file_offset_at_end() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![1u8, 2, 3]);
        let mut buf = [0u8; 4];
        let n = mock.read_from_file(0, 3, &mut buf).unwrap();
        assert_eq!(n, 0);
    }

    #[test]
    fn test_mock_read_from_file_offset_past_end() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![1u8, 2]);
        let mut buf = [0u8; 2];
        let n = mock.read_from_file(0, 100, &mut buf).unwrap();
        assert_eq!(n, 0);
    }

    #[test]
    fn test_mock_get_file_length_missing() {
        let mock = MockFileAccess::new();
        assert!(mock.get_file_length(0).is_err());
    }

    #[test]
    fn test_mock_get_file_length_present() {
        let mut mock = MockFileAccess::new();
        mock.add_file(3, vec![0u8; 77]);
        assert_eq!(mock.get_file_length(3).unwrap(), 77);
    }

    #[test]
    fn test_mock_get_first_file_num_empty() {
        let mock = MockFileAccess::new();
        assert_eq!(mock.get_first_file_num(), None);
    }

    #[test]
    fn test_mock_get_first_file_num_returns_min() {
        let mut mock = MockFileAccess::new();
        mock.add_file(10, vec![]);
        mock.add_file(3, vec![]);
        assert_eq!(mock.get_first_file_num(), Some(3));
    }

    #[test]
    fn test_mock_get_following_file_backward() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![]);
        mock.add_file(1, vec![]);
        mock.add_file(2, vec![]);
        assert_eq!(mock.get_following_file_num(2, false), Some(1));
        assert_eq!(mock.get_following_file_num(0, false), None);
    }

    #[test]
    fn test_mock_get_following_file_forward_none() {
        let mut mock = MockFileAccess::new();
        mock.add_file(5, vec![]);
        assert_eq!(mock.get_following_file_num(5, true), None);
    }

    #[test]
    fn test_in_file_reader_null_lsn_with_files() {
        let mut mock = MockFileAccess::new();
        mock.add_file(0, vec![0u8; 64]);
        let result = INFileReader::new(mock, 512, NULL_LSN, NULL_LSN);
        assert!(result.is_ok());
    }
}