nostr-bbs-core 3.0.0-rc7

Shared Nostr protocol primitives for the nostr-bbs forum (client + workers)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
//! NIP-29: Relay-based Groups — group event constructors.
//!
//! NIP-29 defines relay-based groups where the relay manages membership and
//! access control. All group events carry an `["h", "<group-id>"]` tag.
//!
//! Event kinds:
//! - 9: Group chat message
//! - 9000: Add user to group
//! - 9001: Remove user from group
//! - 9005: Delete event from group
//! - 9021: Join request
//! - 9024: Registration request
//! - 39000: Group metadata (name, about, picture) — relay-signed
//! - 39001: Group admins list — relay-signed
//! - 39002: Group members list — relay-signed

use k256::schnorr::SigningKey;
use thiserror::Error;

use crate::event::{sign_event, NostrEvent, UnsignedEvent};

// -- Kind constants -----------------------------------------------------------

const KIND_GROUP_MESSAGE: u64 = 9;
const KIND_ADD_USER: u64 = 9000;
const KIND_REMOVE_USER: u64 = 9001;
const KIND_GROUP_DELETE: u64 = 9005;
const KIND_JOIN_REQUEST: u64 = 9021;
const KIND_REGISTRATION_REQUEST: u64 = 9024;
const KIND_GROUP_METADATA: u64 = 39000;
const KIND_GROUP_ADMINS: u64 = 39001;
const KIND_GROUP_MEMBERS: u64 = 39002;

// -- Error type ---------------------------------------------------------------

/// Errors specific to NIP-29 group event creation.
#[derive(Debug, Error)]
pub enum GroupError {
    /// The group ID is empty.
    #[error("group_id must not be empty")]
    EmptyGroupId,

    /// A pubkey argument is not valid 64-character hex.
    #[error("invalid pubkey hex: {0}")]
    InvalidPubkey(String),

    /// An event ID argument is not valid 64-character hex.
    #[error("invalid event ID hex: {0}")]
    InvalidEventId(String),

    /// The signing key is invalid.
    #[error("invalid signing key: {0}")]
    InvalidKey(String),

    /// Signing the event failed.
    #[error("signing failed: {0}")]
    SigningFailed(String),
}

// -- Helpers ------------------------------------------------------------------

/// Get current Unix timestamp, platform-aware.
fn now_secs() -> u64 {
    #[cfg(target_arch = "wasm32")]
    {
        (js_sys::Date::now() / 1000.0) as u64
    }
    #[cfg(not(target_arch = "wasm32"))]
    {
        std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .expect("system clock before UNIX epoch")
            .as_secs()
    }
}

fn validate_group_id(group_id: &str) -> Result<(), GroupError> {
    if group_id.is_empty() {
        return Err(GroupError::EmptyGroupId);
    }
    Ok(())
}

fn validate_hex_pubkey(pk: &str) -> Result<(), GroupError> {
    if pk.len() != 64 || hex::decode(pk).is_err() {
        return Err(GroupError::InvalidPubkey(pk.to_string()));
    }
    Ok(())
}

fn validate_hex_event_id(id: &str) -> Result<(), GroupError> {
    if id.len() != 64 || hex::decode(id).is_err() {
        return Err(GroupError::InvalidEventId(id.to_string()));
    }
    Ok(())
}

fn build_and_sign(
    privkey: &[u8; 32],
    kind: u64,
    tags: Vec<Vec<String>>,
    content: String,
) -> Result<NostrEvent, GroupError> {
    let signing_key =
        SigningKey::from_bytes(privkey).map_err(|e| GroupError::InvalidKey(e.to_string()))?;
    let pubkey = hex::encode(signing_key.verifying_key().to_bytes());

    let unsigned = UnsignedEvent {
        pubkey,
        created_at: now_secs(),
        kind,
        tags,
        content,
    };

    sign_event(unsigned, &signing_key).map_err(|e| GroupError::SigningFailed(e.to_string()))
}

// -- Public constructors ------------------------------------------------------

/// Create a group chat message (kind 9).
///
/// Content is the message text. Tags: `["h", group_id]`.
pub fn create_group_message(
    privkey: &[u8; 32],
    group_id: &str,
    content: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let tags = vec![vec!["h".to_string(), group_id.to_string()]];
    build_and_sign(privkey, KIND_GROUP_MESSAGE, tags, content.to_string())
}

/// Create group metadata (kind 39000).
///
/// Tags: `["h", group_id]`, `["name", name]`, `["about", about]`, `["picture", picture]`.
pub fn create_group_metadata(
    privkey: &[u8; 32],
    group_id: &str,
    name: &str,
    about: &str,
    picture: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let tags = vec![
        vec!["h".to_string(), group_id.to_string()],
        vec!["name".to_string(), name.to_string()],
        vec!["about".to_string(), about.to_string()],
        vec!["picture".to_string(), picture.to_string()],
    ];
    build_and_sign(privkey, KIND_GROUP_METADATA, tags, String::new())
}

/// Create an add-user event (kind 9000).
///
/// Tags: `["h", group_id]`, `["p", user_pubkey]`.
pub fn create_add_user(
    privkey: &[u8; 32],
    group_id: &str,
    user_pubkey: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    validate_hex_pubkey(user_pubkey)?;
    let tags = vec![
        vec!["h".to_string(), group_id.to_string()],
        vec!["p".to_string(), user_pubkey.to_string()],
    ];
    build_and_sign(privkey, KIND_ADD_USER, tags, String::new())
}

/// Create a remove-user event (kind 9001).
///
/// Tags: `["h", group_id]`, `["p", user_pubkey]`.
pub fn create_remove_user(
    privkey: &[u8; 32],
    group_id: &str,
    user_pubkey: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    validate_hex_pubkey(user_pubkey)?;
    let tags = vec![
        vec!["h".to_string(), group_id.to_string()],
        vec!["p".to_string(), user_pubkey.to_string()],
    ];
    build_and_sign(privkey, KIND_REMOVE_USER, tags, String::new())
}

/// Create a group-delete event (kind 9005) to request deletion of an event within a group.
///
/// Tags: `["h", group_id]`, `["e", event_id]`.
pub fn create_group_delete(
    privkey: &[u8; 32],
    group_id: &str,
    event_id: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    validate_hex_event_id(event_id)?;
    let tags = vec![
        vec!["h".to_string(), group_id.to_string()],
        vec!["e".to_string(), event_id.to_string()],
    ];
    build_and_sign(privkey, KIND_GROUP_DELETE, tags, String::new())
}

/// Create a join request (kind 9021).
///
/// Tags: `["h", group_id]`. Optional message in content.
pub fn create_join_request(
    privkey: &[u8; 32],
    group_id: &str,
    message: Option<&str>,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let tags = vec![vec!["h".to_string(), group_id.to_string()]];
    build_and_sign(
        privkey,
        KIND_JOIN_REQUEST,
        tags,
        message.unwrap_or("").to_string(),
    )
}

/// Create a registration request (kind 9024).
///
/// Tags: `["h", group_id]`. Metadata in content (e.g. JSON profile data).
pub fn create_registration_request(
    privkey: &[u8; 32],
    group_id: &str,
    metadata: &str,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let tags = vec![vec!["h".to_string(), group_id.to_string()]];
    build_and_sign(
        privkey,
        KIND_REGISTRATION_REQUEST,
        tags,
        metadata.to_string(),
    )
}

// -- Relay-signed NIP-29 group metadata events --------------------------------
//
// Kinds 39000-39002 are parameterized-replaceable events published by the relay
// itself.  They carry a `["d", "<group-id>"]` tag (the replaceable identifier)
// and are signed with the relay's own keypair, not an arbitrary admin client.

/// Build a kind 39000 group-metadata event signed by the relay.
///
/// Tags: `["d", group_id]`, `["name", name]`, and optionally
/// `["about", about]`, `["picture", picture]`.
///
/// The event is parameterized-replaceable: the relay replaces any prior
/// kind-39000 event with the same `d` tag value.
pub fn build_group_metadata(
    relay_privkey: &[u8; 32],
    group_id: &str,
    name: &str,
    about: Option<&str>,
    picture: Option<&str>,
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let mut tags = vec![
        vec!["d".to_string(), group_id.to_string()],
        vec!["name".to_string(), name.to_string()],
    ];
    if let Some(a) = about {
        tags.push(vec!["about".to_string(), a.to_string()]);
    }
    if let Some(p) = picture {
        tags.push(vec!["picture".to_string(), p.to_string()]);
    }
    build_and_sign(relay_privkey, KIND_GROUP_METADATA, tags, String::new())
}

/// Build a kind 39001 group-admins event signed by the relay.
///
/// Tags: `["d", group_id]`, one `["p", pubkey, "", "admin"]` per admin.
///
/// The event is parameterized-replaceable: the relay replaces any prior
/// kind-39001 event with the same `d` tag value.
pub fn build_group_admins(
    relay_privkey: &[u8; 32],
    group_id: &str,
    admin_pubkeys: &[&str],
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let mut tags = vec![vec!["d".to_string(), group_id.to_string()]];
    for pk in admin_pubkeys {
        validate_hex_pubkey(pk)?;
        tags.push(vec![
            "p".to_string(),
            pk.to_string(),
            String::new(),
            "admin".to_string(),
        ]);
    }
    build_and_sign(relay_privkey, KIND_GROUP_ADMINS, tags, String::new())
}

/// Build a kind 39002 group-members event signed by the relay.
///
/// Tags: `["d", group_id]`, one `["p", pubkey]` per member.
///
/// The event is parameterized-replaceable: the relay replaces any prior
/// kind-39002 event with the same `d` tag value.
pub fn build_group_members(
    relay_privkey: &[u8; 32],
    group_id: &str,
    member_pubkeys: &[&str],
) -> Result<NostrEvent, GroupError> {
    validate_group_id(group_id)?;
    let mut tags = vec![vec!["d".to_string(), group_id.to_string()]];
    for pk in member_pubkeys {
        validate_hex_pubkey(pk)?;
        tags.push(vec!["p".to_string(), pk.to_string()]);
    }
    build_and_sign(relay_privkey, KIND_GROUP_MEMBERS, tags, String::new())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::event::verify_event;
    use k256::schnorr::SigningKey;

    fn test_key() -> [u8; 32] {
        [0x01u8; 32]
    }

    fn test_pubkey_hex() -> String {
        let sk = SigningKey::from_bytes(&test_key()).unwrap();
        hex::encode(sk.verifying_key().to_bytes())
    }

    // -- Group message (kind 9) -----------------------------------------------

    #[test]
    fn group_message_has_correct_kind_and_h_tag() {
        let event = create_group_message(&test_key(), "general", "hello group").unwrap();
        assert_eq!(event.kind, 9);
        assert_eq!(event.tags[0], vec!["h", "general"]);
        assert_eq!(event.content, "hello group");
        assert!(verify_event(&event));
    }

    #[test]
    fn group_message_empty_group_id_rejected() {
        let result = create_group_message(&test_key(), "", "msg");
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn group_message_signature_valid() {
        let event = create_group_message(&test_key(), "test-group", "test").unwrap();
        assert!(verify_event(&event));
    }

    // -- Group metadata (kind 39000) ------------------------------------------

    #[test]
    fn group_metadata_has_correct_tags() {
        let event = create_group_metadata(
            &test_key(),
            "dev",
            "Developers",
            "A group for devs",
            "https://example.com/pic.png",
        )
        .unwrap();

        assert_eq!(event.kind, 39000);
        assert_eq!(event.tags[0], vec!["h", "dev"]);
        assert_eq!(event.tags[1], vec!["name", "Developers"]);
        assert_eq!(event.tags[2], vec!["about", "A group for devs"]);
        assert_eq!(
            event.tags[3],
            vec!["picture", "https://example.com/pic.png"]
        );
        assert_eq!(event.content, "");
        assert!(verify_event(&event));
    }

    #[test]
    fn group_metadata_empty_group_rejected() {
        let result = create_group_metadata(&test_key(), "", "n", "a", "p");
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn group_metadata_pubkey_matches() {
        let event = create_group_metadata(&test_key(), "g", "n", "a", "p").unwrap();
        assert_eq!(event.pubkey, test_pubkey_hex());
    }

    // -- Add user (kind 9000) -------------------------------------------------

    #[test]
    fn add_user_has_correct_kind_and_tags() {
        let user_pk = "aa".repeat(32);
        let event = create_add_user(&test_key(), "moderators", &user_pk).unwrap();

        assert_eq!(event.kind, 9000);
        assert_eq!(event.tags[0], vec!["h", "moderators"]);
        assert_eq!(event.tags[1], vec!["p", &user_pk]);
        assert!(verify_event(&event));
    }

    #[test]
    fn add_user_invalid_pubkey_rejected() {
        let result = create_add_user(&test_key(), "group", "bad-hex");
        assert!(matches!(result, Err(GroupError::InvalidPubkey(_))));
    }

    #[test]
    fn add_user_short_pubkey_rejected() {
        let result = create_add_user(&test_key(), "group", "aabb");
        assert!(matches!(result, Err(GroupError::InvalidPubkey(_))));
    }

    // -- Remove user (kind 9001) ----------------------------------------------

    #[test]
    fn remove_user_has_correct_kind_and_tags() {
        let user_pk = "bb".repeat(32);
        let event = create_remove_user(&test_key(), "members", &user_pk).unwrap();

        assert_eq!(event.kind, 9001);
        assert_eq!(event.tags[0], vec!["h", "members"]);
        assert_eq!(event.tags[1], vec!["p", &user_pk]);
        assert!(verify_event(&event));
    }

    #[test]
    fn remove_user_invalid_pubkey_rejected() {
        let result = create_remove_user(&test_key(), "group", "xyz");
        assert!(matches!(result, Err(GroupError::InvalidPubkey(_))));
    }

    #[test]
    fn remove_user_empty_group_rejected() {
        let result = create_remove_user(&test_key(), "", &"cc".repeat(32));
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    // -- Group delete (kind 9005) ---------------------------------------------

    #[test]
    fn group_delete_has_correct_kind_and_tags() {
        let event_id = "dd".repeat(32);
        let event = create_group_delete(&test_key(), "general", &event_id).unwrap();

        assert_eq!(event.kind, 9005);
        assert_eq!(event.tags[0], vec!["h", "general"]);
        assert_eq!(event.tags[1], vec!["e", &event_id]);
        assert!(verify_event(&event));
    }

    #[test]
    fn group_delete_invalid_event_id_rejected() {
        let result = create_group_delete(&test_key(), "group", "short");
        assert!(matches!(result, Err(GroupError::InvalidEventId(_))));
    }

    #[test]
    fn group_delete_signature_valid() {
        let event_id = "ee".repeat(32);
        let event = create_group_delete(&test_key(), "g", &event_id).unwrap();
        assert!(verify_event(&event));
    }

    // -- Join request (kind 9021) ---------------------------------------------

    #[test]
    fn join_request_with_message() {
        let event =
            create_join_request(&test_key(), "newcomers", Some("Please let me in")).unwrap();

        assert_eq!(event.kind, 9021);
        assert_eq!(event.tags[0], vec!["h", "newcomers"]);
        assert_eq!(event.content, "Please let me in");
        assert!(verify_event(&event));
    }

    #[test]
    fn join_request_without_message() {
        let event = create_join_request(&test_key(), "open-group", None).unwrap();

        assert_eq!(event.kind, 9021);
        assert_eq!(event.content, "");
        assert!(verify_event(&event));
    }

    #[test]
    fn join_request_empty_group_rejected() {
        let result = create_join_request(&test_key(), "", None);
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    // -- Registration request (kind 9024) -------------------------------------

    #[test]
    fn registration_request_with_metadata() {
        let metadata = r#"{"name":"Alice","bio":"Developer"}"#;
        let event = create_registration_request(&test_key(), "verified-group", metadata).unwrap();

        assert_eq!(event.kind, 9024);
        assert_eq!(event.tags[0], vec!["h", "verified-group"]);
        assert_eq!(event.content, metadata);
        assert!(verify_event(&event));
    }

    #[test]
    fn registration_request_empty_group_rejected() {
        let result = create_registration_request(&test_key(), "", "{}");
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn registration_request_signature_valid() {
        let event = create_registration_request(&test_key(), "g", "data").unwrap();
        assert!(verify_event(&event));
    }

    // -- Relay-signed group metadata (kind 39000) -----------------------------

    #[test]
    fn build_group_metadata_correct_kind_and_d_tag() {
        let event = build_group_metadata(
            &test_key(),
            "rust-dev",
            "Rust Developers",
            Some("A group for Rustaceans"),
            Some("https://example.com/rust.png"),
        )
        .unwrap();

        assert_eq!(event.kind, 39000);
        assert_eq!(event.tags[0], vec!["d", "rust-dev"]);
        assert_eq!(event.tags[1], vec!["name", "Rust Developers"]);
        assert_eq!(event.tags[2], vec!["about", "A group for Rustaceans"]);
        assert_eq!(
            event.tags[3],
            vec!["picture", "https://example.com/rust.png"]
        );
        assert_eq!(event.content, "");
    }

    #[test]
    fn build_group_metadata_optional_fields_omitted() {
        let event =
            build_group_metadata(&test_key(), "minimal", "Minimal Group", None, None).unwrap();

        assert_eq!(event.kind, 39000);
        assert_eq!(event.tags.len(), 2); // d + name only
        assert_eq!(event.tags[0], vec!["d", "minimal"]);
        assert_eq!(event.tags[1], vec!["name", "Minimal Group"]);
    }

    #[test]
    fn build_group_metadata_signed_by_relay_key() {
        let event = build_group_metadata(&test_key(), "g", "G", None, None).unwrap();
        assert_eq!(event.pubkey, test_pubkey_hex());
        assert!(verify_event(&event));
    }

    #[test]
    fn build_group_metadata_empty_group_rejected() {
        let result = build_group_metadata(&test_key(), "", "name", None, None);
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn build_group_metadata_is_parameterized_replaceable() {
        let event = build_group_metadata(&test_key(), "test-group", "Test", None, None).unwrap();
        // Kind 39000 is in the parameterized-replaceable range (30000-39999)
        assert!((30000..=39999).contains(&event.kind));
        // Must have a d tag
        let d_tags: Vec<_> = event.tags.iter().filter(|t| t[0] == "d").collect();
        assert_eq!(d_tags.len(), 1);
        assert_eq!(d_tags[0][1], "test-group");
    }

    // -- Relay-signed group admins (kind 39001) -------------------------------

    #[test]
    fn build_group_admins_correct_kind_and_tags() {
        let pk1 = "aa".repeat(32);
        let pk2 = "bb".repeat(32);
        let event =
            build_group_admins(&test_key(), "moderators", &[pk1.as_str(), pk2.as_str()]).unwrap();

        assert_eq!(event.kind, 39001);
        assert_eq!(event.tags[0], vec!["d", "moderators"]);
        assert_eq!(event.tags[1], vec!["p", &pk1, "", "admin"]);
        assert_eq!(event.tags[2], vec!["p", &pk2, "", "admin"]);
        assert_eq!(event.content, "");
    }

    #[test]
    fn build_group_admins_empty_list() {
        let event = build_group_admins(&test_key(), "empty-admins", &[]).unwrap();
        assert_eq!(event.kind, 39001);
        assert_eq!(event.tags.len(), 1); // only d tag
        assert_eq!(event.tags[0], vec!["d", "empty-admins"]);
    }

    #[test]
    fn build_group_admins_signed_by_relay_key() {
        let event = build_group_admins(&test_key(), "g", &[]).unwrap();
        assert_eq!(event.pubkey, test_pubkey_hex());
        assert!(verify_event(&event));
    }

    #[test]
    fn build_group_admins_invalid_pubkey_rejected() {
        let result = build_group_admins(&test_key(), "g", &["not-a-pubkey"]);
        assert!(matches!(result, Err(GroupError::InvalidPubkey(_))));
    }

    #[test]
    fn build_group_admins_empty_group_rejected() {
        let result = build_group_admins(&test_key(), "", &[]);
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn build_group_admins_is_parameterized_replaceable() {
        let event = build_group_admins(&test_key(), "admin-group", &[]).unwrap();
        assert!((30000..=39999).contains(&event.kind));
        let d_tags: Vec<_> = event.tags.iter().filter(|t| t[0] == "d").collect();
        assert_eq!(d_tags.len(), 1);
        assert_eq!(d_tags[0][1], "admin-group");
    }

    // -- Relay-signed group members (kind 39002) ------------------------------

    #[test]
    fn build_group_members_correct_kind_and_tags() {
        let pk1 = "cc".repeat(32);
        let pk2 = "dd".repeat(32);
        let pk3 = "ee".repeat(32);
        let event = build_group_members(
            &test_key(),
            "devs",
            &[pk1.as_str(), pk2.as_str(), pk3.as_str()],
        )
        .unwrap();

        assert_eq!(event.kind, 39002);
        assert_eq!(event.tags[0], vec!["d", "devs"]);
        assert_eq!(event.tags[1], vec!["p", &pk1]);
        assert_eq!(event.tags[2], vec!["p", &pk2]);
        assert_eq!(event.tags[3], vec!["p", &pk3]);
        assert_eq!(event.content, "");
    }

    #[test]
    fn build_group_members_empty_list() {
        let event = build_group_members(&test_key(), "empty-members", &[]).unwrap();
        assert_eq!(event.kind, 39002);
        assert_eq!(event.tags.len(), 1); // only d tag
    }

    #[test]
    fn build_group_members_signed_by_relay_key() {
        let event = build_group_members(&test_key(), "g", &[]).unwrap();
        assert_eq!(event.pubkey, test_pubkey_hex());
        assert!(verify_event(&event));
    }

    #[test]
    fn build_group_members_invalid_pubkey_rejected() {
        let result = build_group_members(&test_key(), "g", &["short"]);
        assert!(matches!(result, Err(GroupError::InvalidPubkey(_))));
    }

    #[test]
    fn build_group_members_empty_group_rejected() {
        let result = build_group_members(&test_key(), "", &[]);
        assert!(matches!(result, Err(GroupError::EmptyGroupId)));
    }

    #[test]
    fn build_group_members_is_parameterized_replaceable() {
        let event = build_group_members(&test_key(), "member-group", &[]).unwrap();
        assert!((30000..=39999).contains(&event.kind));
        let d_tags: Vec<_> = event.tags.iter().filter(|t| t[0] == "d").collect();
        assert_eq!(d_tags.len(), 1);
        assert_eq!(d_tags[0][1], "member-group");
    }

    // -- Cross-cutting relay-signed checks ------------------------------------

    #[test]
    fn all_relay_signed_events_share_same_author() {
        let key = test_key();
        let meta = build_group_metadata(&key, "g", "G", None, None).unwrap();
        let admins = build_group_admins(&key, "g", &[]).unwrap();
        let members = build_group_members(&key, "g", &[]).unwrap();

        assert_eq!(meta.pubkey, admins.pubkey);
        assert_eq!(admins.pubkey, members.pubkey);
        assert_eq!(meta.pubkey, test_pubkey_hex());
    }

    #[test]
    fn all_relay_signed_events_are_valid() {
        let key = test_key();
        let pk = "ff".repeat(32);
        let meta = build_group_metadata(&key, "g", "G", Some("about"), Some("pic")).unwrap();
        let admins = build_group_admins(&key, "g", &[pk.as_str()]).unwrap();
        let members = build_group_members(&key, "g", &[pk.as_str()]).unwrap();

        assert!(verify_event(&meta));
        assert!(verify_event(&admins));
        assert!(verify_event(&members));
    }
}