nornir 0.5.0

//! Release gates. Each gate returns `Ok(())` on pass, `Err` on fail.
//! Generated binaries propagate the first error and abort the release.

use std::path::Path;

use anyhow::{anyhow, Context, Result};

use crate::bench::{history, BenchRun};

/// Gate 1: no `[patch.crates-io]` znippy entries in the repo's
/// `Cargo.toml`. Implementation: textual scan; refine later with a
/// proper TOML parse if needed.
pub fn no_path_patches(repo_root: &Path) -> Result<()> {
    let cargo = repo_root.join("Cargo.toml");
    let text = std::fs::read_to_string(&cargo)
        .with_context(|| format!("read {}", cargo.display()))?;
    let mut in_patch = false;
    for (i, line) in text.lines().enumerate() {
        let l = line.trim();
        if l.starts_with('[') {
            in_patch = l.starts_with("[patch.crates-io")
                || l.starts_with("[patch.\"crates-io\"");
            continue;
        }
        if in_patch && l.contains("znippy") && !l.starts_with('#') {
            return Err(anyhow!(
                "[patch.crates-io] znippy entry at {}:{} — strip before release",
                cargo.display(),
                i + 1
            ));
        }
    }
    Ok(())
}

/// Gate 3: holger ops/sec must be ≥ nexus ops/sec for every result.
/// Looks for `holger_ops_sec` and `nexus_ops_sec` in each result's
/// metrics map. Results lacking both keys are skipped.
pub fn nexus_floor(run: &BenchRun) -> Result<()> {
    for r in &run.results {
        let h = r.metrics.get("holger_ops_sec").and_then(|v| v.as_f64());
        let n = r.metrics.get("nexus_ops_sec").and_then(|v| v.as_f64());
        if let (Some(h), Some(n)) = (h, n) {
            if h < n {
                return Err(anyhow!(
                    "nexus floor: {} holger={:.0} < nexus={:.0}",
                    r.name,
                    h,
                    n
                ));
            }
        }
    }
    Ok(())
}

/// Gate 4: no result drops more than `max_drop_pct` versus the last
/// same-machine entry in the history. Compares the first numeric
/// metric present in each result (so works for both ops/sec and MB/s
/// shaped runs).
pub fn no_regression(run: &BenchRun, history_path: &Path, max_drop_pct: f64) -> Result<()> {
    let history = history::read_all(history_path)?;
    no_regression_against(run, &history, max_drop_pct)
}

/// Core of [`no_regression`] operating on an in-memory history slice
/// (e.g. read back from the Iceberg warehouse via
/// `query_bench_runs_async`) instead of a JSONL file. The baseline is the
/// **newest** prior run for the same `machine`, chosen deterministically
/// by `timestamp` rather than slice/scan order (warehouse scans don't
/// guarantee ordering). No prior run for the machine ⇒ `Ok` (nothing to
/// regress against — first run bootstraps the baseline).
///
/// Metric direction: treats **higher = better** (throughput-shaped, e.g.
/// `*_mbs`), matching nornir's bench convention. Latency-style
/// (lower=better) metrics are NOT yet handled — see issue note in plan.
pub fn no_regression_against(run: &BenchRun, history: &[BenchRun], max_drop_pct: f64) -> Result<()> {
    let same: Vec<&BenchRun> = history.iter().filter(|h| h.machine == run.machine).collect();
    let Some(last) = pick_baseline(&same) else {
        return Ok(());
    };
    for r in &run.results {
        let Some(prev) = last.find(&r.name) else { continue };
        for (key, new_val) in &r.metrics {
            let Some(new_f) = new_val.as_f64() else { continue };
            let Some(prev_f) = prev.metrics.get(key).and_then(|v| v.as_f64()) else {
                continue;
            };
            if prev_f <= 0.0 {
                continue;
            }
            let drop_pct = (prev_f - new_f) / prev_f * 100.0;
            if drop_pct > max_drop_pct {
                return Err(anyhow!(
                    "regression: {} {} dropped {:.1}% ({:.2} → {:.2})",
                    r.name,
                    key,
                    drop_pct,
                    prev_f,
                    new_f
                ));
            }
        }
    }
    Ok(())
}

/// Pick the newest baseline run deterministically: by `timestamp` when
/// all candidates carry one (lexicographic compare of RFC3339 strings is
/// chronological), else fall back to last-in-slice (legacy JSONL append
/// order). Returns `None` for an empty candidate set.
fn pick_baseline<'a>(runs: &[&'a BenchRun]) -> Option<&'a BenchRun> {
    if runs.is_empty() {
        return None;
    }
    if runs.iter().all(|r| r.timestamp.is_some()) {
        runs.iter().copied().max_by(|a, b| a.timestamp.cmp(&b.timestamp))
    } else {
        runs.last().copied()
    }
}

/// Gate 5: integration round-trip. Caller supplies a closure that
/// performs `agent push → server store → agent pull` for one artifact
/// kind; this gate runs them in order.
pub fn integration_roundtrip<F>(kinds: &[&str], mut run_one: F) -> Result<()>
where
    F: FnMut(&str) -> Result<()>,
{
    for k in kinds {
        run_one(k).with_context(|| format!("roundtrip failed for {k}"))?;
    }
    Ok(())
}

/// Gate 5 driver: invoke gate 5 by shelling out to
/// `cargo test --test roundtrip_<kind> --release` per kind. Consumer
/// repos (holger, znippy) implement the actual roundtrip logic as
/// Rust `#[test]` functions under `tests/roundtrip_<kind>.rs`. This
/// is the one allowed cargo subprocess pattern (matches the
/// `run_cargo_publish` decision), keeping nornir free of bash
/// shellouts.
pub fn integration_roundtrip_via_cargo_test(repo_root: &Path, kinds: &[&str]) -> Result<()> {
    integration_roundtrip(kinds, |k| {
        let test_name = format!("roundtrip_{k}");
        let status = std::process::Command::new("cargo")
            .args(["test", "--test", &test_name, "--release"])
            .current_dir(repo_root)
            .status()
            .with_context(|| format!("spawn cargo test --test {test_name}"))?;
        if !status.success() {
            return Err(anyhow!("cargo test --test {test_name} exited {status}"));
        }
        Ok(())
    })
}

// ─── Cargo-pipeline gates (features 1, 4, 5, 8, 16) ─────────────────

/// One audit finding from [`path_dep_audit`].
#[derive(Debug, Clone)]
pub struct PathDepFinding {
    pub manifest: std::path::PathBuf,
    pub dep_name: String,
    pub dep_path: String,
    pub has_version: bool,
    pub version_req: Option<String>,
}

impl PathDepFinding {
    pub fn ok(&self) -> bool { self.has_version }
}

/// Gate (feature 1): every `path =` dep in every `Cargo.toml` in the
/// workspace must also carry a `version =` field. Otherwise
/// `cargo publish` rejects the manifest because the patched-out
/// path-dep loses its version constraint in the uploaded `.crate`.
///
/// Walks every `Cargo.toml` under `repo_root` (skipping `target/`,
/// `.git/`). Parses with the `toml` crate and inspects
/// `[dependencies.*]`, `[dev-dependencies.*]`, `[build-dependencies.*]`
/// and the `[target.*]`-scoped equivalents.
pub fn path_dep_audit(repo_root: &Path) -> Result<Vec<PathDepFinding>> {
    let mut findings = Vec::new();
    for manifest in walk_cargo_tomls(repo_root)? {
        let text = std::fs::read_to_string(&manifest)
            .with_context(|| format!("read {}", manifest.display()))?;
        let doc: toml::Value = toml::from_str(&text)
            .with_context(|| format!("parse {}", manifest.display()))?;
        for section in [
            "dependencies",
            "dev-dependencies",
            "build-dependencies",
        ] {
            collect_path_deps(&doc, section, &manifest, &mut findings);
        }
        if let Some(targets) = doc.get("target").and_then(|t| t.as_table()) {
            for (_cfg, t) in targets {
                for section in [
                    "dependencies",
                    "dev-dependencies",
                    "build-dependencies",
                ] {
                    collect_path_deps(t, section, &manifest, &mut findings);
                }
            }
        }
    }
    Ok(findings)
}

fn collect_path_deps(
    parent: &toml::Value,
    section: &str,
    manifest: &Path,
    out: &mut Vec<PathDepFinding>,
) {
    let Some(deps) = parent.get(section).and_then(|d| d.as_table()) else { return };
    for (name, v) in deps {
        let Some(t) = v.as_table() else { continue };
        let path = t.get("path").and_then(|p| p.as_str());
        let Some(p) = path else { continue };
        let version = t.get("version").and_then(|v| v.as_str()).map(|s| s.to_string());
        out.push(PathDepFinding {
            manifest: manifest.to_path_buf(),
            dep_name: name.clone(),
            dep_path: p.to_string(),
            has_version: version.is_some(),
            version_req: version,
        });
    }
}

fn walk_cargo_tomls(root: &Path) -> Result<Vec<std::path::PathBuf>> {
    let mut out = Vec::new();
    let mut stack = vec![root.to_path_buf()];
    while let Some(dir) = stack.pop() {
        for entry in std::fs::read_dir(&dir).with_context(|| format!("read_dir {}", dir.display()))? {
            let entry = entry?;
            let p = entry.path();
            let ft = entry.file_type()?;
            // Never follow symlinks (file_type does not traverse the link).
            if ft.is_symlink() {
                continue;
            }
            if ft.is_dir() {
                // Skip build dirs and ALL dot-dir CHILDREN (`.git`, `.claude`, …) — a
                // repo's `.claude/worktrees/` symlinks out to sibling repos, so
                // descending would sweep the whole constellation (facett 26 → 95).
                // Checked on the child (not the popped dir), so the root is always
                // scanned even when it's a dot-named tempdir.
                let cname = p.file_name().and_then(|n| n.to_str()).unwrap_or("");
                if matches!(cname, "target" | "node_modules") || cname.starts_with('.') {
                    continue;
                }
                stack.push(p);
            } else if ft.is_file() && p.file_name().and_then(|n| n.to_str()) == Some("Cargo.toml") {
                out.push(p);
            }
        }
    }
    Ok(out)
}

/// One metadata-check row from [`crate_metadata_check`].
#[derive(Debug, Clone)]
pub struct CrateMetaCheck {
    pub manifest: std::path::PathBuf,
    pub crate_name: String,
    pub version: String,
    pub has_readme: bool,
    pub has_license: bool,
    pub license_expr: Option<String>,
    pub has_repository: bool,
    pub repository_url: Option<String>,
    pub has_description: bool,
    pub description_len: Option<usize>,
}

impl CrateMetaCheck {
    pub fn ok(&self) -> bool {
        self.has_readme && self.has_license && self.has_repository && self.has_description
    }
}

/// Gate (feature 4): every publishable crate's `[package]` table must
/// have `readme`, `license`, `repository`, `description` populated —
/// crates.io rejects missing/short metadata and we discovered this by
/// trial-and-error mid-publish (nornir 0.1.0 needed `readme=README.md`
/// added). Skips workspace virtual roots (no `[package]`) and any
/// manifest with `publish = false`.
pub fn crate_metadata_check(repo_root: &Path) -> Result<Vec<CrateMetaCheck>> {
    let manifests = walk_cargo_tomls(repo_root)?;
    // First pass: capture the workspace root's `[workspace.package]` fields, since
    // members commonly inherit metadata via `license.workspace = true` etc. Without
    // this the gate falsely fails every unified-versioning workspace (e.g. facett).
    let mut ws: std::collections::BTreeMap<String, String> = Default::default();
    for manifest in &manifests {
        let Ok(text) = std::fs::read_to_string(manifest) else { continue };
        let Ok(doc) = toml::from_str::<toml::Value>(&text) else { continue };
        if let Some(wp) = doc
            .get("workspace")
            .and_then(|w| w.get("package"))
            .and_then(|p| p.as_table())
        {
            for k in ["version", "license", "repository", "description", "readme"] {
                if let Some(v) = wp.get(k).and_then(|v| v.as_str()) {
                    ws.entry(k.to_string()).or_insert_with(|| v.to_string());
                }
                // readme can be a bool in [workspace.package] too.
                if k == "readme" {
                    if let Some(true) = wp.get(k).and_then(|v| v.as_bool()) {
                        ws.entry(k.to_string()).or_insert_with(|| "README.md".to_string());
                    }
                }
            }
        }
    }
    // Resolve a package field: an explicit string, a `{ workspace = true }` inherit
    // (→ the [workspace.package] value), or absent. Returns the effective string.
    let resolve = |field: Option<&toml::Value>, key: &str| -> Option<String> {
        match field {
            Some(toml::Value::String(s)) if !s.is_empty() => Some(s.clone()),
            Some(toml::Value::Boolean(true)) if key == "readme" => Some("README.md".to_string()),
            Some(toml::Value::Table(t)) if t.get("workspace").and_then(|w| w.as_bool()) == Some(true) => {
                ws.get(key).cloned()
            }
            _ => None,
        }
    };

    let mut out = Vec::new();
    for manifest in &manifests {
        let text = std::fs::read_to_string(manifest)
            .with_context(|| format!("read {}", manifest.display()))?;
        let doc: toml::Value = toml::from_str(&text)
            .with_context(|| format!("parse {}", manifest.display()))?;
        let Some(pkg) = doc.get("package").and_then(|p| p.as_table()) else { continue };
        if pkg.get("publish").and_then(|p| p.as_bool()) == Some(false) { continue }
        let crate_name = pkg.get("name").and_then(|n| n.as_str()).unwrap_or("?").to_string();
        let version = resolve(pkg.get("version"), "version").unwrap_or_else(|| "0.0.0".to_string());
        let license_expr = resolve(pkg.get("license"), "license");
        let repo_url = resolve(pkg.get("repository"), "repository");
        let desc = resolve(pkg.get("description"), "description");
        let readme_ok = resolve(pkg.get("readme"), "readme").is_some();
        out.push(CrateMetaCheck {
            manifest: manifest.clone(),
            crate_name,
            version,
            has_readme: readme_ok,
            has_license: license_expr.as_ref().map(|s| !s.is_empty()).unwrap_or(false),
            license_expr,
            has_repository: repo_url.as_ref().map(|s| !s.is_empty()).unwrap_or(false),
            repository_url: repo_url,
            has_description: desc.as_ref().map(|s| !s.is_empty()).unwrap_or(false),
            description_len: desc.as_ref().map(|s| s.len()),
        });
    }
    Ok(out)
}

/// One link-declaration record from [`links_declarations_scan`].
#[derive(Debug, Clone)]
pub struct LinkDecl {
    pub crate_name: String,
    pub version: String,
    pub links_value: String,
    pub manifest: std::path::PathBuf,
}

/// One conflict surfaced by [`detect_links_conflicts`].
#[derive(Debug, Clone)]
pub struct LinksConflict {
    pub links_value: String,
    pub crates: Vec<(String, String)>, // (crate_name, version)
}

/// Gate (feature 8): collect every `links =` declaration in the
/// resolved dep tree via `cargo metadata`. Multiple crates with the
/// same `links` key cause cryptic linker failures at build time —
/// detect them up front.
pub fn links_declarations_scan(repo_root: &Path) -> Result<Vec<LinkDecl>> {
    let meta = cargo_metadata::MetadataCommand::new()
        .current_dir(repo_root)
        .exec()
        .with_context(|| format!("cargo metadata in {}", repo_root.display()))?;
    let mut out = Vec::new();
    for pkg in &meta.packages {
        if let Some(links) = &pkg.links {
            out.push(LinkDecl {
                crate_name: pkg.name.to_string(),
                version: pkg.version.to_string(),
                links_value: links.clone(),
                manifest: pkg.manifest_path.clone().into_std_path_buf(),
            });
        }
    }
    Ok(out)
}

pub fn detect_links_conflicts(decls: &[LinkDecl]) -> Vec<LinksConflict> {
    use std::collections::BTreeMap;
    let mut buckets: BTreeMap<String, Vec<(String, String)>> = BTreeMap::new();
    for d in decls {
        buckets.entry(d.links_value.clone())
            .or_default()
            .push((d.crate_name.clone(), d.version.clone()));
    }
    buckets.into_iter()
        .filter(|(_, c)| c.iter().map(|(n, _)| n).collect::<std::collections::HashSet<_>>().len() > 1)
        .map(|(links_value, crates)| LinksConflict { links_value, crates })
        .collect()
}

/// Gate (feature 16): the `v<version>` git tag for the most-recently
/// published crate version must exist locally and point at HEAD.
/// Run after a successful `cargo publish` to catch the "shipped to
/// crates.io but forgot to tag" failure mode.
///
/// Pure-Rust via [`crate::gitio`] (gix); annotated tags are peeled to
/// their target commit before the HEAD comparison.
pub fn git_tag_matches_published(repo_root: &Path, version: &str) -> Result<bool> {
    crate::gitio::tag_points_at_head(repo_root, &format!("v{version}"))
}

/// Gate (autonom n-005): the completeness gate must be GREEN — every discovered
/// surface (viz tabs × {thin,fat}, CLI subcommands, MCP tools, unreached fns)
/// is covered by an inject-assert test or excused by a LIVE allowlist entry, and
/// no allowlist entry is stale. Takes the already-computed [`GateReport`] (the
/// caller has the warehouse + discrete inputs); this is the pure verdict gate.
///
/// HARD zero (not a ratchet): fails if `Gap ≠ ∅` OR any stale allowlist entry.
pub fn coverage_gate(report: &nornir_testmatrix::coverage::GateReport) -> Result<()> {
    if report.is_green() {
        return Ok(());
    }
    let mut parts: Vec<String> = Vec::new();
    if !report.gap.missing.is_empty() {
        let keys: Vec<&str> = report.gap.missing.iter().map(|n| n.id.as_str()).collect();
        parts.push(format!(
            "{} uncovered+un-allowlisted surface(s): {}",
            report.gap.missing.len(),
            keys.join(", ")
        ));
    }
    if !report.stale.is_empty() {
        let keys: Vec<&str> = report.stale.iter().map(|e| e.key.as_str()).collect();
        parts.push(format!("{} stale allowlist entr(ies): {}", report.stale.len(), keys.join(", ")));
    }
    Err(anyhow!("autonom completeness gate RED — {}", parts.join("; ")))
}

/// Gate (autonom S6): the CROSS-WORKSPACE completeness gate must be GREEN — every
/// served workspace's per-workspace [`coverage_gate`] passes AND (where measured)
/// every RESOLVED metro line / reachable surface is green. Mirrors
/// [`coverage_gate`] but over a [`MegaGateReport`](crate::autonom::megagate::MegaGateReport):
/// it fails on the FIRST non-green workspace, naming `(workspace, key)` so the
/// burn-down points at the exact offending surface in the exact workspace.
///
/// HARD zero per workspace (not a ratchet): an uncovered+un-allowlisted surface,
/// a stale allowlist entry, OR an unmet resolved-metro rollup in ANY workspace
/// reds the whole release. Pure verdict over the already-gathered report (the
/// caller swept the warehouse via `gather_all`); this never reads the warehouse.
pub fn coverage_gate_all_workspaces(
    report: &crate::autonom::megagate::MegaGateReport,
) -> Result<()> {
    for wg in &report.workspaces {
        // The per-workspace coverage gate — reuse the single-workspace verdict so
        // the message body (uncovered / stale keys) is identical, just prefixed.
        if let Err(e) = coverage_gate(&wg.coverage) {
            return Err(anyhow!(
                "mega completeness gate RED — workspace `{}`: {}",
                wg.workspace,
                e
            ));
        }
        // The reachable (resolved metro / LAW-9) rollup, when measured: every
        // resolved line must be green. Unresolved bin→lib lines are excluded
        // upstream (allowlistable until scip is populated — S6 step 4 risk note).
        if let Some((green, total)) = wg.reachable {
            if green != total {
                return Err(anyhow!(
                    "mega completeness gate RED — workspace `{}`: only {}/{} resolved metro \
                     lines green (an unlit gating stop on a resolved chain)",
                    wg.workspace,
                    green,
                    total
                ));
            }
        }
    }
    Ok(())
}

/// `release gate coverage <repo>` rendered as the uniform
/// [`crate::cli_outcome::CommandOutcome`] — the CLI's `state_json` for the autonom
/// completeness verdict. Pure SHAPER over the already-computed [`GateReport`] (the
/// caller gathered the surface + covered set via `gate_coverage_for_repo`); it never
/// reads the warehouse.
///
/// GATE ok-semantics: `ok ⟺ the gate PASSED` (`report.is_green()` — `Gap == ∅` and no
/// stale allowlist entry). A FAILING gate is `ok:false` with the uncovered surface +
/// stale entries surfaced in `data` (machine-readable, the actionable burn-down) — that
/// is the CORRECT verdict, not a process error. Both verdicts carry real `data`; only the
/// passing one is `is_sannr` (a red gate is a red surface, by the RAGNARÖK rule). AUT9.
pub fn coverage_gate_outcome(
    repo: &str,
    report: &nornir_testmatrix::coverage::GateReport,
) -> crate::cli_outcome::CommandOutcome {
    use crate::cli_outcome::CommandOutcome;
    let cmd = "release gate coverage";
    let passed = report.is_green();
    let missing: Vec<&str> = report.gap.missing.iter().map(|n| n.id.as_str()).collect();
    let stale: Vec<&str> = report.stale.iter().map(|e| e.key.as_str()).collect();
    let data = serde_json::json!({
        "repo": repo,
        "gate": "coverage",
        "passed": passed,
        "covered": report.gap.covered,
        "total": report.gap.total,
        "missing_count": report.gap.missing.len(),
        "stale_count": report.stale.len(),
        "missing": missing,
        "stale": stale,
    });
    let human = format!("release gate coverage `{repo}`: {}", report.summary());
    CommandOutcome { command: cmd.into(), ok: passed, data, human }
}

/// `release gate-all <repo>` rendered as the uniform
/// [`crate::cli_outcome::CommandOutcome`] — the CLI's `state_json` for the full
/// per-repo gate sweep. Pure SHAPER over the already-run `passed` / `failed`
/// verdicts (the caller ran every configured gate); it runs no gate itself.
///
/// GATE ok-semantics: `ok ⟺ EVERY enabled gate passed` (`failed` is empty). A run with any
/// failing gate is `ok:false`, with the failed gate names + their error messages in `data`
/// (and `human`) — the correct red verdict, not a process error. The passing verdict (with
/// ≥1 gate run) is `is_sannr`; the failing one is RED. AUT9.
pub fn gate_all_outcome(
    repo: &str,
    passed: &[String],
    failed: &[(String, String)],
) -> crate::cli_outcome::CommandOutcome {
    use crate::cli_outcome::CommandOutcome;
    use std::fmt::Write;
    let cmd = "release gate-all";
    let all_pass = failed.is_empty();
    let failed_json: Vec<serde_json::Value> = failed
        .iter()
        .map(|(n, e)| serde_json::json!({ "name": n, "error": e }))
        .collect();
    let data = serde_json::json!({
        "repo": repo,
        "passed": passed,
        "failed": failed_json,
        "passed_count": passed.len(),
        "failed_count": failed.len(),
        "all_pass": all_pass,
    });
    let mut human = format!("=== gate-all: {repo} ===\n");
    for n in passed {
        let _ = writeln!(human, "  ✓ {n}");
    }
    for (n, e) in failed {
        let _ = writeln!(human, "  ✗ {n}: {e}");
    }
    if all_pass {
        let _ = write!(human, "{} gate(s) passed", passed.len());
    } else {
        let _ = write!(human, "{} gate(s) failed", failed.len());
    }
    CommandOutcome { command: cmd.into(), ok: all_pass, data, human }
}

/// Release gate (plan #5): the repo's **test matrix** must be green. Takes the
/// repo's `test_results` rows (the SAME rows `nornir test history`/`Ops.
/// RunTestMatrix` produce + persist), rolls them into per-run summaries
/// (newest-first via [`summarize_runs`]), and fails the release if:
///
///   * there is NO recorded run (a release must have exercised its tests), or
///   * the newest run is RED (any `fail`/`stalled` case), or
///   * a REGRESSION vs the last green run: a test that passed in the last green
///     run is failing/stalled in the newest run (caught even if the newest run
///     also added brand-new failures — the regression is named explicitly).
///
/// Pure over already-collected rows so it's unit-testable and identical whether
/// the rows came from an embedded warehouse read or `Ops.RunTestMatrix`. The
/// heavy part (actually RUNNING the matrix) is the caller's job — this is the
/// verdict gate, mirroring `coverage_gate`.
pub fn tests_gate(rows: &[crate::warehouse::test_results::TestResultRow]) -> Result<()> {
    use crate::warehouse::test_results::{status, summarize_runs};
    let summaries = summarize_runs(rows);
    let newest = summaries
        .first()
        .ok_or_else(|| anyhow!("release tests gate RED — no test run recorded; run the matrix first"))?;

    // Names of the newest run's red (failing/stalled) cases, for the message.
    let red_cases: Vec<String> = rows
        .iter()
        .filter(|r| r.run_id == newest.run_id && status::is_red(&r.status))
        .map(|r| format!("{}::{}", r.suite, r.test_name))
        .collect();

    // Regression check: a test green in the last green run, red in the newest.
    let regressions: Vec<String> = if let Some(last_green) =
        summaries.iter().skip(1).find(|s| s.green())
    {
        use std::collections::BTreeSet;
        let was_green: BTreeSet<(&str, &str)> = rows
            .iter()
            .filter(|r| r.run_id == last_green.run_id && status::is_green(&r.status))
            .map(|r| (r.suite.as_str(), r.test_name.as_str()))
            .collect();
        rows.iter()
            .filter(|r| r.run_id == newest.run_id && status::is_red(&r.status))
            .filter(|r| was_green.contains(&(r.suite.as_str(), r.test_name.as_str())))
            .map(|r| format!("{}::{}", r.suite, r.test_name))
            .collect()
    } else {
        Vec::new()
    };

    if newest.green() {
        return Ok(());
    }
    let mut msg = format!(
        "release tests gate RED — newest run {} has {} failing/stalled case(s)",
        crate::warehouse::test_results::short_run(&newest.run_id),
        newest.failed + newest.stalled,
    );
    if !red_cases.is_empty() {
        msg.push_str(&format!(": {}", red_cases.join(", ")));
    }
    if !regressions.is_empty() {
        msg.push_str(&format!(
            "; REGRESSION (was green last green run): {}",
            regressions.join(", ")
        ));
    }
    Err(anyhow!(msg))
}

/// Plan #5 release test-DRIVE: actually RUN the repo's test matrix
/// (`run_full_matrix`) over `repo_root`, fold the fresh rows together with the
/// repo's persisted `history` rows, and apply [`tests_gate`]. The freshly-run
/// rows carry a newer `run_id`/`ts` than any history row (the matrix stamps a
/// new run id + `now()`), so they always lead in the newest-first summary — the
/// gate verdicts the run we just drove, and uses the history to catch a
/// regression vs the last green run.
///
/// HEAVY: this compiles + runs the suite. It is invoked release/on-request only
/// (the `[gates].tests` toggle), never on workspace load — same policy as the
/// rest of the heavy matrix. Returns the freshly-run rows on success so the
/// caller can persist them to the warehouse.
pub fn run_tests_gate(
    repo_root: &Path,
    history: &[crate::warehouse::test_results::TestResultRow],
    aspects: &[crate::test_matrix::Aspect],
) -> Result<Vec<crate::warehouse::test_results::TestResultRow>> {
    let fresh = crate::test_matrix::run_full_matrix(repo_root, aspects);
    if fresh.is_empty() {
        return Err(anyhow!(
            "release tests gate RED — the matrix produced no rows for {} (nothing ran)",
            repo_root.display()
        ));
    }
    // History first, fresh last — summarize_runs sorts newest-first by ts, so
    // the just-run rows lead regardless of input order; this is belt-and-braces.
    let mut all = history.to_vec();
    all.extend(fresh.iter().cloned());
    tests_gate(&all)?;
    Ok(fresh)
}

/// Outcome of [`render_and_stage_docs`].
#[derive(Debug, Default)]
pub struct RenderStageReport {
    /// Repo-relative paths that were (re)rendered AND `git add`-ed (only the ones
    /// that actually changed on disk).
    pub staged: Vec<std::path::PathBuf>,
    /// `true` if the whole-documentation book PDF was (re)built + staged.
    pub book_built: bool,
}

/// Release **render-and-stage** (the authoritative docs backstop).
///
/// Unlike the [`docs_fresh`](crate::config::Gates::docs_fresh) gate — which only
/// *checks* for drift and fails the release — this **renders** the managed docs
/// (README/CHANGELOG, with the full SVG/depgraph assets), fills the in-place
/// `.nornir/*.md` markers, builds the book PDF (under `docs-export`), and
/// `git add`s every artifact that changed. Running it *before* the `docs_fresh`
/// check guarantees a release always ships fresh docs and the subsequent check
/// passes (any remaining drift is a real bug, not just staleness).
///
/// Wire it where the other gates run; it is opt-in per repo via the same
/// `[repo.<name>.gates].docs_fresh` flag (rendering is the active half of the
/// freshness contract). The caller supplies a fully-built [`docs::Ctx`] (it owns
/// warehouse access — gates must not open the warehouse themselves).
///
/// Best-effort `git add`: a path that can't be staged (e.g. not a git repo) is
/// reported but does not fail the release — the `docs_fresh` check that follows
/// is the hard assertion.
pub fn render_and_stage_docs(
    layout: &crate::docs::RepoLayout,
    ctx: &crate::docs::Ctx,
) -> Result<RenderStageReport> {
    let mut report = RenderStageReport::default();
    let repo_root = layout.repo_root.clone();

    // What this repo asks `render` to emit (`.nornir/docs.toml`; default markdown).
    let cfg = crate::docs::DocsRenderCfg::load(layout)?;

    let mut changed: Vec<std::path::PathBuf> = Vec::new();

    if cfg.wants_markdown() {
        // Managed docs (README/CHANGELOG) → repo root, with full assets.
        for r in crate::docs::render_all(layout, ctx)? {
            if r.changed {
                changed.push(r.output.clone());
            }
        }
        // In-place marker fills for the non-managed `.nornir/*.md` sources.
        for r in crate::docs::render_sources_in_place(layout, ctx)? {
            if r.changed {
                changed.push(r.path.clone());
            }
        }
    }

    // The generated SVG/depgraph assets are tracked; stage the whole assets dir
    // so a freshly (re)rendered chart/depgraph rides along with the commit.
    let assets = layout.nornir_dir().join("assets");
    if assets.exists() {
        changed.push(assets);
    }

    // Whole-documentation book PDF (authoritative, heavy — release-only).
    #[cfg(feature = "docs-export")]
    if cfg.wants_pdf() {
        let format = crate::docs::DocFormat::parse("pdf")?;
        let (bytes, _sources) = crate::docs::build_book(&repo_root, ctx, format)?;
        let out = layout.export_path("book", format.extension());
        if let Some(parent) = out.parent() {
            std::fs::create_dir_all(parent)?;
        }
        let prev = std::fs::read(&out).ok();
        if prev.as_deref() != Some(bytes.as_slice()) {
            std::fs::write(&out, &bytes)
                .with_context(|| format!("write {}", out.display()))?;
        }
        changed.push(out);
        report.book_built = true;
    }
    #[cfg(not(feature = "docs-export"))]
    let _ = &repo_root;

    // Stage everything that changed (best-effort).
    for path in changed {
        if !path.exists() {
            continue;
        }
        let staged = std::process::Command::new("git")
            .arg("-C")
            .arg(&repo_root)
            .arg("add")
            .arg("--")
            .arg(&path)
            .status()
            .map(|s| s.success())
            .unwrap_or(false);
        if staged {
            let rel = path.strip_prefix(&repo_root).unwrap_or(&path).to_path_buf();
            report.staged.push(rel);
        }
    }
    Ok(report)
}

#[cfg(test)]
mod render_stage_tests {
    use super::*;
    use tempfile::TempDir;

    fn git_init(root: &Path) {
        let ok = std::process::Command::new("git")
            .arg("-C")
            .arg(root)
            .arg("init")
            .status()
            .map(|s| s.success())
            .unwrap_or(false);
        assert!(ok, "git init failed (is git installed?)");
    }

    fn staged_files(root: &Path) -> Vec<String> {
        let out = std::process::Command::new("git")
            .arg("-C")
            .arg(root)
            .args(["diff", "--cached", "--name-only"])
            .output()
            .unwrap();
        String::from_utf8_lossy(&out.stdout)
            .lines()
            .map(|s| s.to_string())
            .collect()
    }

    /// render_and_stage_docs RENDERS the managed README from its `.nornir/`
    /// source, leaves NO drift (the `docs_fresh` check passes after), AND
    /// `git add`s the regenerated artifact. Inject a known source body; assert
    /// the rendered output carries it + the GENERATED header + is staged.
    #[test]
    fn renders_stages_and_leaves_no_drift() {
        let t = TempDir::new().unwrap();
        let root = t.path();
        git_init(root);

        let layout = crate::docs::RepoLayout::new(root);
        std::fs::create_dir_all(layout.nornir_dir()).unwrap();
        // Inject a known source with a unique sentinel.
        let sentinel = "AUTOTRIGGER-RENDER-SENTINEL-42";
        std::fs::write(
            layout.source_of("README.md"),
            format!("# Title\n\n{sentinel}\n"),
        )
        .unwrap();

        let ctx = crate::docs::Ctx::new(root, root, None);

        // Precondition: the artifact is stale (absent) ⇒ the check would FAIL.
        assert!(
            crate::docs::render_check_all(&layout, &ctx).is_err(),
            "before render, docs_fresh check must fail on the missing artifact"
        );

        // Render + stage.
        let report = render_and_stage_docs(&layout, &ctx).unwrap();

        // The README was rendered with the injected sentinel + the header.
        let rendered = std::fs::read_to_string(layout.output_of("README.md")).unwrap();
        assert!(rendered.contains(sentinel), "rendered README must carry the injected body");
        assert!(
            rendered.starts_with(crate::docs::layout::GENERATED_HEADER_PREFIX),
            "rendered README must carry the GENERATED header"
        );

        // It was reported as staged AND is actually in the git index.
        assert!(
            report.staged.iter().any(|p| p.ends_with("README.md")),
            "README.md should be reported staged; got {:?}",
            report.staged
        );
        assert!(
            staged_files(root).iter().any(|f| f == "README.md"),
            "README.md must be in the git index"
        );

        // Postcondition: NO drift — the docs_fresh check now passes.
        crate::docs::render_check_all(&layout, &ctx)
            .expect("after render+stage, docs_fresh check must pass (no drift)");
    }
}

#[cfg(test)]
mod cargo_pipeline_tests {
    use super::*;

    #[test]
    fn coverage_gate_passes_green_fails_on_gap_or_stale() {
        use nornir_testmatrix::coverage::{Allowlist, AllowEntry, GateReport};
        use nornir_testmatrix::discover::{cli_commands, Surface};
        use std::collections::BTreeSet;

        let mut surface = Surface::new();
        surface.extend(cli_commands(["a", "b"])); // 2 NA nodes
        let all: BTreeSet<String> =
            ["cli_command:a@na", "cli_command:b@na"].iter().map(|s| s.to_string()).collect();

        // All covered + clean allowlist → green → Ok.
        let green = GateReport::compute("r", "ws", &surface, &all, &Allowlist::new());
        assert!(coverage_gate(&green).is_ok());

        // One uncovered, un-allowlisted → gap → Err.
        let covered_one: BTreeSet<String> = ["cli_command:a@na".to_string()].into_iter().collect();
        let red = GateReport::compute("r", "ws", &surface, &covered_one, &Allowlist::new());
        let err = coverage_gate(&red).unwrap_err().to_string();
        assert!(err.contains("uncovered"), "{err}");
        assert!(err.contains("b"), "names the missing surface: {err}");

        // Stale allowlist entry (all covered, but an excuse lingers) → Err.
        let stale_al = Allowlist {
            entries: vec![AllowEntry { key: "cli_command:a@na".into(), reason: "old".into() }],
        };
        let stale = GateReport::compute("r", "ws", &surface, &all, &stale_al);
        let err2 = coverage_gate(&stale).unwrap_err().to_string();
        assert!(err2.contains("stale"), "{err2}");
    }

    #[test]
    fn coverage_gate_outcome_ok_when_green_red_with_gap_data_when_failing() {
        use nornir_testmatrix::coverage::{Allowlist, AllowEntry, GateReport};
        use nornir_testmatrix::discover::{cli_commands, Surface};
        use std::collections::BTreeSet;

        let mut surface = Surface::new();
        surface.extend(cli_commands(["a", "b"]));
        let all: BTreeSet<String> =
            ["cli_command:a@na", "cli_command:b@na"].iter().map(|s| s.to_string()).collect();

        // GREEN gate → ok=true, sannr, real counts in data.
        let green = GateReport::compute("r", "ws", &surface, &all, &Allowlist::new());
        let og = coverage_gate_outcome("nornir", &green);
        assert!(og.ok, "a passing gate is ok");
        assert!(og.is_sannr(), "a passing gate carries real verdict data");
        assert_eq!(og.command, "release gate coverage");
        assert_eq!(og.data["passed"], serde_json::json!(true));
        assert_eq!(og.data["missing_count"], serde_json::json!(0));
        assert_eq!(og.data["total"], serde_json::json!(2));

        // FAILING gate (one uncovered) → ok=false (RED), BUT the missing surface is in data.
        let covered_one: BTreeSet<String> = ["cli_command:a@na".to_string()].into_iter().collect();
        let red = GateReport::compute("r", "ws", &surface, &covered_one, &Allowlist::new());
        let orr = coverage_gate_outcome("nornir", &red);
        assert!(!orr.ok, "a failing gate is ok:false (the correct red verdict)");
        assert!(!orr.is_sannr(), "a red gate is a red surface");
        assert_eq!(orr.data["passed"], serde_json::json!(false));
        assert_eq!(orr.data["missing_count"], serde_json::json!(1));
        assert_eq!(orr.data["missing"], serde_json::json!(["b"]));
        assert!(orr.human.contains("RED"));

        // Stale allowlist entry → also a failing gate, named in data.
        let stale_al = Allowlist {
            entries: vec![AllowEntry { key: "cli_command:a@na".into(), reason: "old".into() }],
        };
        let stale = GateReport::compute("r", "ws", &surface, &all, &stale_al);
        let os = coverage_gate_outcome("nornir", &stale);
        assert!(!os.ok);
        assert_eq!(os.data["stale_count"], serde_json::json!(1));
        assert_eq!(os.data["stale"], serde_json::json!(["cli_command:a@na"]));
    }

    #[test]
    fn gate_all_outcome_ok_when_all_pass_red_with_failure_data() {
        // All gates passed → ok=true, sannr, the passed names in data.
        let passed = vec!["no_path_patches".to_string(), "nexus_floor".to_string()];
        let o = gate_all_outcome("nornir", &passed, &[]);
        assert!(o.ok, "no failed gates ⇒ ok");
        assert!(o.is_sannr(), "a green sweep carries the passed-gate list");
        assert_eq!(o.command, "release gate-all");
        assert_eq!(o.data["passed_count"], serde_json::json!(2));
        assert_eq!(o.data["failed_count"], serde_json::json!(0));
        assert_eq!(o.data["all_pass"], serde_json::json!(true));
        assert!(o.human.contains("2 gate(s) passed"));

        // One gate failed → ok=false (RED), with the failed gate + its error in data.
        let failed = vec![("docs_fresh".to_string(), "README drifted".to_string())];
        let r = gate_all_outcome("nornir", &["nexus_floor".to_string()], &failed);
        assert!(!r.ok, "any failed gate ⇒ ok:false");
        assert!(!r.is_sannr(), "a red sweep is a red surface");
        assert_eq!(r.data["failed_count"], serde_json::json!(1));
        assert_eq!(r.data["failed"][0]["name"], serde_json::json!("docs_fresh"));
        assert_eq!(r.data["failed"][0]["error"], serde_json::json!("README drifted"));
        assert!(r.human.contains("✗ docs_fresh: README drifted"));
        assert!(r.human.contains("1 gate(s) failed"));
    }

    #[test]
    fn tests_gate_passes_green_fails_on_red_and_names_regression() {
        use crate::warehouse::test_results::{status, TestResultRow};

        // No run at all → RED (a release must have exercised its tests).
        let err = tests_gate(&[]).unwrap_err().to_string();
        assert!(err.contains("no test run"), "{err}");

        // An all-green newest run → Ok.
        let green = vec![
            TestResultRow::unit("g1", "r", "r", "a::ok", status::PASS, 1.0, 100, ""),
            TestResultRow::unit("g1", "r", "r", "a::also", status::PASS, 1.0, 100, ""),
        ];
        tests_gate(&green).unwrap();

        // Newest run is RED → Err naming the failing case.
        let red = vec![
            TestResultRow::unit("g1", "r", "r", "a::ok", status::PASS, 1.0, 100, ""),
            TestResultRow::unit("r2", "r", "r", "a::ok", status::PASS, 1.0, 200, ""),
            TestResultRow::unit("r2", "r", "r", "a::broke", status::FAIL, 1.0, 200, "boom"),
        ];
        let err = tests_gate(&red).unwrap_err().to_string();
        assert!(err.contains("RED"), "{err}");
        assert!(err.contains("a::broke"), "names the failing case: {err}");

        // A REGRESSION: a::ok was green in the last green run (g1), now fails in
        // the newest run (r3) → Err must call out the regression explicitly.
        let regressed = vec![
            TestResultRow::unit("g1", "r", "r", "a::ok", status::PASS, 1.0, 100, ""),
            TestResultRow::unit("r3", "r", "r", "a::ok", status::FAIL, 1.0, 300, "now broken"),
        ];
        let err = tests_gate(&regressed).unwrap_err().to_string();
        assert!(err.contains("REGRESSION"), "flags the regression: {err}");
        assert!(err.contains("a::ok"), "names the regressed test: {err}");

        // A stalled (hung) newest case is also RED.
        let stalled = vec![
            TestResultRow::unit("s1", "r", "r", "a::hang", status::STALLED, 9e4, 400, "no output 120s"),
        ];
        assert!(tests_gate(&stalled).is_err(), "a stalled run is red");
    }

    #[test]
    fn path_dep_audit_flags_missing_version() {
        let dir = tempfile::tempdir().unwrap();
        std::fs::write(dir.path().join("Cargo.toml"), r#"
[package]
name = "x"
version = "0.1.0"
edition = "2021"

[dependencies]
sibling-a = { path = "../a" }
sibling-b = { path = "../b", version = "0.2" }
"#).unwrap();
        let findings = path_dep_audit(dir.path()).unwrap();
        assert_eq!(findings.len(), 2);
        let bad = findings.iter().find(|f| f.dep_name == "sibling-a").unwrap();
        assert!(!bad.ok());
        let good = findings.iter().find(|f| f.dep_name == "sibling-b").unwrap();
        assert!(good.ok());
        assert_eq!(good.version_req.as_deref(), Some("0.2"));
    }

    #[test]
    fn crate_metadata_check_flags_missing_fields() {
        let dir = tempfile::tempdir().unwrap();
        std::fs::write(dir.path().join("Cargo.toml"), r#"
[package]
name = "y"
version = "0.1.0"
edition = "2021"
license = "MIT"
"#).unwrap();
        let checks = crate_metadata_check(dir.path()).unwrap();
        assert_eq!(checks.len(), 1);
        let c = &checks[0];
        assert!(c.has_license);
        assert!(!c.has_repository);
        assert!(!c.has_description);
        assert!(!c.ok());
    }
}

#[cfg(test)]
mod regression_tests {
    use super::*;
    use crate::bench::{BenchResult, BenchRun};

    fn run(machine: &str, ts: &str, mbs: f64) -> BenchRun {
        let mut r = BenchResult { name: "codec".into(), metrics: Default::default() };
        r.metrics.insert("throughput_mbs".into(), serde_json::Value::from(mbs));
        BenchRun {
            date: ts[..10].to_string(),
            timestamp: Some(ts.to_string()),
            version: "0.1.0".into(),
            machine: machine.into(),
            cores: 1,
            results: vec![r],
            tests: Vec::new(),
        }
    }

    #[test]
    fn no_baseline_for_machine_passes() {
        // First-ever run for a machine: nothing to regress against.
        let candidate = run("ci", "2026-01-02T00:00:00+00:00", 100.0);
        let history = vec![run("other-box", "2026-01-01T00:00:00+00:00", 999.0)];
        assert!(no_regression_against(&candidate, &history, 10.0).is_ok());
    }

    #[test]
    fn improvement_passes() {
        let candidate = run("ci", "2026-01-02T00:00:00+00:00", 120.0);
        let history = vec![run("ci", "2026-01-01T00:00:00+00:00", 100.0)];
        assert!(no_regression_against(&candidate, &history, 10.0).is_ok());
    }

    #[test]
    fn drop_within_threshold_passes() {
        // 5% drop, threshold 10% → ok.
        let candidate = run("ci", "2026-01-02T00:00:00+00:00", 95.0);
        let history = vec![run("ci", "2026-01-01T00:00:00+00:00", 100.0)];
        assert!(no_regression_against(&candidate, &history, 10.0).is_ok());
    }

    #[test]
    fn drop_beyond_threshold_rejected() {
        // 20% drop, threshold 10% → regression.
        let candidate = run("ci", "2026-01-02T00:00:00+00:00", 80.0);
        let history = vec![run("ci", "2026-01-01T00:00:00+00:00", 100.0)];
        let err = no_regression_against(&candidate, &history, 10.0).unwrap_err();
        assert!(err.to_string().contains("regression"), "got: {err}");
    }

    #[test]
    fn baseline_is_newest_by_timestamp_not_slice_order() {
        // History deliberately NOT in chronological order. The newest
        // (by timestamp) baseline is 100 mbs; candidate 90 is a 10% drop,
        // which is NOT > 10% threshold → ok. If the picker wrongly used
        // the LAST slice element (the 50-mbs older run), 90 would look
        // like an 80% *improvement* and also pass — so to truly exercise
        // ordering we set the OLDER run much higher.
        let candidate = run("ci", "2026-03-01T00:00:00+00:00", 90.0);
        let history = vec![
            run("ci", "2026-02-01T00:00:00+00:00", 100.0), // newest → baseline
            run("ci", "2026-01-01T00:00:00+00:00", 1000.0), // oldest, last in slice
        ];
        // Against newest(100): 10% drop, threshold 10% → ok.
        assert!(no_regression_against(&candidate, &history, 10.0).is_ok());
        // Against the (wrong) last-in-slice 1000: 91% drop → would error.
        // So passing here proves we picked the newest by timestamp.
    }

    #[test]
    fn baseline_picks_newest_even_when_older_run_is_last_in_slice_and_regressed() {
        // Newest baseline = 100; candidate 50 = 50% drop → must reject,
        // regardless of an older, slower run appearing later in the slice.
        let candidate = run("ci", "2026-03-01T00:00:00+00:00", 50.0);
        let history = vec![
            run("ci", "2026-02-01T00:00:00+00:00", 100.0),
            run("ci", "2026-01-01T00:00:00+00:00", 40.0),
        ];
        assert!(no_regression_against(&candidate, &history, 10.0).is_err());
    }
}

#[cfg(test)]
mod nexus_floor_tests {
    use super::*;
    use crate::bench::{BenchResult, BenchRun};

    /// One bench result carrying an arbitrary set of `key=value` f64 metrics.
    fn result(name: &str, kv: &[(&str, f64)]) -> BenchResult {
        let mut r = BenchResult { name: name.into(), metrics: Default::default() };
        for (k, v) in kv {
            r.metrics.insert((*k).to_string(), serde_json::Value::from(*v));
        }
        r
    }

    fn run_with(results: Vec<BenchResult>) -> BenchRun {
        BenchRun {
            date: "2026-01-01".into(),
            timestamp: Some("2026-01-01T00:00:00+00:00".into()),
            version: "0.1.0".into(),
            machine: "ci".into(),
            cores: 1,
            results,
            tests: Vec::new(),
        }
    }

    #[test]
    fn holger_above_nexus_passes() {
        // holger_ops_sec (5000) ≥ nexus_ops_sec (1000) → floor held.
        let run = run_with(vec![result(
            "decode",
            &[("holger_ops_sec", 5000.0), ("nexus_ops_sec", 1000.0)],
        )]);
        assert!(nexus_floor(&run).is_ok());
    }

    #[test]
    fn holger_equal_to_nexus_passes() {
        // Boundary: equal throughput is NOT below the floor (`h < n` is strict).
        let run = run_with(vec![result(
            "decode",
            &[("holger_ops_sec", 1000.0), ("nexus_ops_sec", 1000.0)],
        )]);
        assert!(nexus_floor(&run).is_ok());
    }

    #[test]
    fn holger_below_nexus_rejected() {
        // holger (900) < nexus (1000) → release-blocking floor breach.
        let run = run_with(vec![result(
            "decode",
            &[("holger_ops_sec", 900.0), ("nexus_ops_sec", 1000.0)],
        )]);
        let err = nexus_floor(&run).unwrap_err().to_string();
        assert!(err.contains("nexus floor"), "got: {err}");
        assert!(err.contains("decode"), "error should name the result: {err}");
    }

    #[test]
    fn one_result_below_floor_fails_the_whole_run() {
        // First result is fine; second breaches → the gate must reject the run.
        let run = run_with(vec![
            result("warm", &[("holger_ops_sec", 5000.0), ("nexus_ops_sec", 1000.0)]),
            result("cold", &[("holger_ops_sec", 50.0), ("nexus_ops_sec", 1000.0)]),
        ]);
        let err = nexus_floor(&run).unwrap_err().to_string();
        assert!(err.contains("cold"), "should blame the breaching result: {err}");
    }

    #[test]
    fn results_missing_either_key_are_skipped() {
        // A znippy-shaped run (compress_mbs / decompress_mbs, no holger/nexus
        // keys) carries neither floor metric → the gate has nothing to check
        // and passes rather than erroring on the absent keys.
        let run = run_with(vec![
            result("compress", &[("compress_mbs", 800.0)]),
            result("only_holger", &[("holger_ops_sec", 10.0)]),
            result("only_nexus", &[("nexus_ops_sec", 9999.0)]),
        ]);
        assert!(nexus_floor(&run).is_ok());
    }
}

#[cfg(test)]
mod roundtrip_tests {
    use super::*;
    use std::cell::RefCell;

    #[test]
    fn all_kinds_succeed_passes() {
        // Every kind's closure returns Ok → the gate passes and runs each once.
        let seen = RefCell::new(Vec::new());
        let res = integration_roundtrip(&["blob", "symbol"], |k| {
            seen.borrow_mut().push(k.to_string());
            Ok(())
        });
        assert!(res.is_ok());
        assert_eq!(seen.into_inner(), vec!["blob", "symbol"]);
    }

    #[test]
    fn empty_kind_list_passes_vacuously() {
        // No configured kinds ⇒ nothing to round-trip ⇒ Ok.
        let res = integration_roundtrip(&[], |_| -> Result<()> {
            panic!("closure must not run for an empty kind list")
        });
        assert!(res.is_ok());
    }

    #[test]
    fn first_failure_aborts_and_is_contextualised() {
        // The closure fails on the second kind; the gate must propagate the
        // error, tag it with the failing kind, and NOT invoke later kinds.
        let seen = RefCell::new(Vec::new());
        let res = integration_roundtrip(&["blob", "symbol", "edge"], |k| {
            seen.borrow_mut().push(k.to_string());
            if k == "symbol" {
                anyhow::bail!("store rejected the artifact")
            }
            Ok(())
        });
        let err = res.unwrap_err();
        let chain = format!("{err:#}");
        assert!(chain.contains("roundtrip failed for symbol"), "got: {chain}");
        assert!(chain.contains("store rejected the artifact"), "got: {chain}");
        // "edge" must never have been attempted after the failure.
        assert_eq!(seen.into_inner(), vec!["blob", "symbol"]);
    }
}