use std::fmt;
#[derive(Debug, Clone, PartialEq)]
pub enum ValidationError {
PathTraversal,
InvalidDockerName(String),
InvalidDigest(String),
InvalidReference(String),
EmptyInput,
TooLong { max: usize, actual: usize },
ForbiddenCharacter(char),
}
impl fmt::Display for ValidationError {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::PathTraversal => write!(f, "Path traversal detected"),
Self::InvalidDockerName(reason) => write!(f, "Invalid Docker name: {}", reason),
Self::InvalidDigest(reason) => write!(f, "Invalid digest: {}", reason),
Self::InvalidReference(reason) => write!(f, "Invalid reference: {}", reason),
Self::EmptyInput => write!(f, "Input cannot be empty"),
Self::TooLong { max, actual } => {
write!(f, "Input exceeds maximum length ({} > {})", actual, max)
}
Self::ForbiddenCharacter(c) => write!(f, "Forbidden character: {:?}", c),
}
}
}
impl std::error::Error for ValidationError {}
const MAX_KEY_LENGTH: usize = 1024;
const MAX_DOCKER_NAME_LENGTH: usize = 256;
const MAX_REFERENCE_LENGTH: usize = 128;
pub fn validate_storage_key(key: &str) -> Result<(), ValidationError> {
if key.is_empty() {
return Err(ValidationError::EmptyInput);
}
if key.len() > MAX_KEY_LENGTH {
return Err(ValidationError::TooLong {
max: MAX_KEY_LENGTH,
actual: key.len(),
});
}
if key.contains('\0') {
return Err(ValidationError::ForbiddenCharacter('\0'));
}
if key.starts_with('/') || key.starts_with('\\') {
return Err(ValidationError::PathTraversal);
}
if key.contains("..") {
return Err(ValidationError::PathTraversal);
}
if key.contains('\\') {
return Err(ValidationError::PathTraversal);
}
for segment in key.split('/') {
if segment.is_empty() && !key.is_empty() {
continue;
}
if segment == "." || segment == ".." {
return Err(ValidationError::PathTraversal);
}
}
Ok(())
}
pub fn validate_docker_name(name: &str) -> Result<(), ValidationError> {
if name.is_empty() {
return Err(ValidationError::EmptyInput);
}
if name.len() > MAX_DOCKER_NAME_LENGTH {
return Err(ValidationError::TooLong {
max: MAX_DOCKER_NAME_LENGTH,
actual: name.len(),
});
}
if name.contains("..") {
return Err(ValidationError::PathTraversal);
}
for c in name.chars() {
if !matches!(c, 'a'..='z' | '0'..='9' | '_' | '.' | '-' | '/') {
if c.is_ascii_uppercase() {
return Err(ValidationError::InvalidDockerName(
"must be lowercase".to_string(),
));
}
return Err(ValidationError::ForbiddenCharacter(c));
}
}
if name.starts_with('/') || name.starts_with('.') || name.starts_with('-') {
return Err(ValidationError::InvalidDockerName(
"cannot start with separator or special character".to_string(),
));
}
if name.ends_with('/') {
return Err(ValidationError::InvalidDockerName(
"cannot end with /".to_string(),
));
}
if name.contains("//") || name.contains("--") || name.contains("__") {
return Err(ValidationError::InvalidDockerName(
"consecutive separators not allowed".to_string(),
));
}
for segment in name.split('/') {
if segment.is_empty() {
return Err(ValidationError::InvalidDockerName(
"empty path segment".to_string(),
));
}
let first = segment.chars().next().unwrap();
if !first.is_ascii_alphanumeric() {
return Err(ValidationError::InvalidDockerName(
"segment must start with alphanumeric".to_string(),
));
}
}
Ok(())
}
pub fn validate_digest(digest: &str) -> Result<(), ValidationError> {
if digest.is_empty() {
return Err(ValidationError::EmptyInput);
}
if digest.contains("..") || digest.contains('/') {
return Err(ValidationError::PathTraversal);
}
let parts: Vec<&str> = digest.splitn(2, ':').collect();
if parts.len() != 2 {
return Err(ValidationError::InvalidDigest(
"missing algorithm prefix (expected algo:hash)".to_string(),
));
}
let (algo, hash) = (parts[0], parts[1]);
match algo {
"sha256" => {
if hash.len() != 64 {
return Err(ValidationError::InvalidDigest(format!(
"sha256 hash must be 64 characters, got {}",
hash.len()
)));
}
}
"sha512" => {
if hash.len() != 128 {
return Err(ValidationError::InvalidDigest(format!(
"sha512 hash must be 128 characters, got {}",
hash.len()
)));
}
}
_ => {
return Err(ValidationError::InvalidDigest(format!(
"unsupported algorithm: {} (use sha256 or sha512)",
algo
)));
}
}
for c in hash.chars() {
if !matches!(c, '0'..='9' | 'a'..='f') {
if c.is_ascii_uppercase() {
return Err(ValidationError::InvalidDigest(
"hash must be lowercase hex".to_string(),
));
}
return Err(ValidationError::InvalidDigest(format!(
"invalid character in hash: {:?}",
c
)));
}
}
Ok(())
}
pub fn validate_docker_reference(reference: &str) -> Result<(), ValidationError> {
if reference.is_empty() {
return Err(ValidationError::EmptyInput);
}
if reference.len() > MAX_REFERENCE_LENGTH {
return Err(ValidationError::TooLong {
max: MAX_REFERENCE_LENGTH,
actual: reference.len(),
});
}
if reference.contains("..") || reference.contains('/') {
return Err(ValidationError::PathTraversal);
}
if reference.starts_with("sha256:") || reference.starts_with("sha512:") {
return validate_digest(reference);
}
let first = reference.chars().next().unwrap();
if !first.is_ascii_alphanumeric() {
return Err(ValidationError::InvalidReference(
"tag must start with alphanumeric".to_string(),
));
}
for c in reference.chars() {
if !matches!(c, 'a'..='z' | 'A'..='Z' | '0'..='9' | '.' | '_' | '-') {
return Err(ValidationError::ForbiddenCharacter(c));
}
}
Ok(())
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_storage_key_valid() {
assert!(validate_storage_key("docker/nginx/blobs/sha256:abc").is_ok());
assert!(validate_storage_key("maven/org/apache/commons").is_ok());
assert!(validate_storage_key("simple").is_ok());
}
#[test]
fn test_storage_key_path_traversal() {
assert!(matches!(
validate_storage_key("../etc/passwd"),
Err(ValidationError::PathTraversal)
));
assert!(matches!(
validate_storage_key("foo/../bar"),
Err(ValidationError::PathTraversal)
));
assert!(matches!(
validate_storage_key("foo/.."),
Err(ValidationError::PathTraversal)
));
}
#[test]
fn test_storage_key_absolute_path() {
assert!(matches!(
validate_storage_key("/etc/passwd"),
Err(ValidationError::PathTraversal)
));
assert!(matches!(
validate_storage_key("\\windows\\system32"),
Err(ValidationError::PathTraversal)
));
}
#[test]
fn test_storage_key_null_byte() {
assert!(matches!(
validate_storage_key("foo\0bar"),
Err(ValidationError::ForbiddenCharacter('\0'))
));
}
#[test]
fn test_storage_key_empty() {
assert!(matches!(
validate_storage_key(""),
Err(ValidationError::EmptyInput)
));
}
#[test]
fn test_storage_key_too_long() {
let long_key = "a".repeat(1025);
assert!(matches!(
validate_storage_key(&long_key),
Err(ValidationError::TooLong { .. })
));
}
#[test]
fn test_docker_name_valid() {
assert!(validate_docker_name("nginx").is_ok());
assert!(validate_docker_name("library/nginx").is_ok());
assert!(validate_docker_name("my-org/my-image").is_ok());
assert!(validate_docker_name("my_image").is_ok());
assert!(validate_docker_name("image.name").is_ok());
assert!(validate_docker_name("a/b/c/d").is_ok());
}
#[test]
fn test_docker_name_uppercase() {
assert!(matches!(
validate_docker_name("NGINX"),
Err(ValidationError::InvalidDockerName(_))
));
assert!(matches!(
validate_docker_name("MyImage"),
Err(ValidationError::InvalidDockerName(_))
));
}
#[test]
fn test_docker_name_path_traversal() {
assert!(matches!(
validate_docker_name("../escape"),
Err(ValidationError::PathTraversal)
));
assert!(matches!(
validate_docker_name("foo/../bar"),
Err(ValidationError::PathTraversal)
));
}
#[test]
fn test_docker_name_invalid_start() {
assert!(validate_docker_name("/nginx").is_err());
assert!(validate_docker_name(".nginx").is_err());
assert!(validate_docker_name("-nginx").is_err());
}
#[test]
fn test_docker_name_consecutive_separators() {
assert!(validate_docker_name("foo//bar").is_err());
assert!(validate_docker_name("foo--bar").is_err());
assert!(validate_docker_name("foo__bar").is_err());
}
#[test]
fn test_digest_valid_sha256() {
let valid = format!("sha256:{}", "a".repeat(64));
assert!(validate_digest(&valid).is_ok());
}
#[test]
fn test_digest_valid_sha512() {
let valid = format!("sha512:{}", "a".repeat(128));
assert!(validate_digest(&valid).is_ok());
}
#[test]
fn test_digest_wrong_length() {
assert!(validate_digest("sha256:abc").is_err());
assert!(validate_digest(&format!("sha256:{}", "a".repeat(63))).is_err());
assert!(validate_digest(&format!("sha256:{}", "a".repeat(65))).is_err());
}
#[test]
fn test_digest_uppercase() {
let upper = format!("sha256:{}", "A".repeat(64));
assert!(matches!(
validate_digest(&upper),
Err(ValidationError::InvalidDigest(_))
));
}
#[test]
fn test_digest_unsupported_algorithm() {
assert!(matches!(
validate_digest("md5:abc"),
Err(ValidationError::InvalidDigest(_))
));
}
#[test]
fn test_digest_missing_prefix() {
assert!(matches!(
validate_digest("abcdef123456"),
Err(ValidationError::InvalidDigest(_))
));
}
#[test]
fn test_reference_valid_tag() {
assert!(validate_docker_reference("latest").is_ok());
assert!(validate_docker_reference("v1.0.0").is_ok());
assert!(validate_docker_reference("1.0").is_ok());
assert!(validate_docker_reference("my-tag_v2").is_ok());
}
#[test]
fn test_reference_valid_digest() {
let digest = format!("sha256:{}", "a".repeat(64));
assert!(validate_docker_reference(&digest).is_ok());
}
#[test]
fn test_reference_path_traversal() {
assert!(matches!(
validate_docker_reference("../escape"),
Err(ValidationError::PathTraversal)
));
}
#[test]
fn test_reference_invalid_start() {
assert!(validate_docker_reference(".hidden").is_err());
assert!(validate_docker_reference("-dash").is_err());
}
}