1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
// SPDX-License-Identifier: BUSL-1.1
//! Per-engine undo entry application logic.
//!
//! Each `apply_undo_*` method handles one engine family's undo entries.
//! All methods return `Err((entry_index, detail))` on fatal failure so the
//! caller can escalate to a typed `RollbackFailed` response.
use tracing::error;
use crate::data::executor::core_loop::CoreLoop;
use super::UndoEntry;
impl CoreLoop {
// ── Vector ───────────────────────────────────────────────────────────────
pub(super) fn apply_undo_vector(
&mut self,
_tid: u64,
entry_index: usize,
entry: UndoEntry,
) -> Result<(), (usize, String)> {
match entry {
UndoEntry::InsertVector {
index_key,
vector_id,
collection,
field,
doc_id,
} => match self.vector_collections.get_mut(&index_key) {
Some(index) => {
index.delete(vector_id);
// Reverse the forward insert's `vector_doc_map` write —
// without this a rolled-back insert leaves a stale
// doc→vector_id mapping behind (unbounded leak), mirroring
// `apply_undo_spatial`'s `spatial_doc_map.remove`. Empty
// `doc_id` marks the direct primary-vector write path
// (`PhysicalPlan::Vector`), which never populates
// `vector_doc_map` — skip the mutation for that path.
if !doc_id.is_empty() {
self.vector_doc_map.remove(&(
index_key.0,
index_key.1,
collection,
field,
doc_id,
));
}
Ok(())
}
None => {
let detail = format!(
"vector index {:?} not found during undo of vector insert {}",
index_key, vector_id
);
error!(
core = self.core_id,
entry_index,
error = %detail,
"transaction undo: vector index missing; shard state unknown"
);
Err((entry_index, detail))
}
},
UndoEntry::DeleteVector {
index_key,
vector_id,
collection,
field,
doc_id,
} => match self.vector_collections.get_mut(&index_key) {
Some(index) => {
index.undelete(vector_id);
// Restore the `vector_doc_map` entry the forward delete
// removed — without this a rolled-back delete leaves the
// doc→vector reverse lookup missing, so a later delete of
// the same document can never find (and soft-delete) its
// vector: a permanent orphan. Mirrors
// `apply_undo_spatial`'s `spatial_doc_map.insert`. Empty
// `doc_id` marks the direct primary-vector write path,
// which never populates `vector_doc_map` — skip it there.
if !doc_id.is_empty() {
self.vector_doc_map.insert(
(index_key.0, index_key.1, collection, field, doc_id),
vector_id,
);
}
Ok(())
}
None => {
let detail = format!(
"vector index {:?} not found during undo of vector delete {}",
index_key, vector_id
);
error!(
core = self.core_id,
entry_index,
error = %detail,
"transaction undo: vector index missing; shard state unknown"
);
Err((entry_index, detail))
}
},
_ => Err((
entry_index,
"apply_undo_vector called with non-vector entry".to_string(),
)),
}
}
// ── Graph ────────────────────────────────────────────────────────────────
#[cfg(test)]
pub(super) fn apply_undo_edge(
&mut self,
did: u64,
tid: u64,
entry_index: usize,
entry: UndoEntry,
) -> Result<(), (usize, String)> {
self.apply_undo_edge_with_stats(did, tid, entry_index, entry, true)
}
pub(super) fn apply_undo_edge_with_stats(
&mut self,
did: u64,
tid: u64,
entry_index: usize,
entry: UndoEntry,
account_stats: bool,
) -> Result<(), (usize, String)> {
use crate::engine::graph::edge_store::EdgeRef;
let database = nodedb_types::DatabaseId::new(did);
match entry {
UndoEntry::PutEdge {
collection,
src_id,
label,
dst_id,
old_properties,
} => {
let tenant = nodedb_types::TenantId::new(tid);
let ord = self.hlc.next_ordinal();
let edge_ref =
EdgeRef::new(database, tenant, &collection, &src_id, &label, &dst_id);
if let Some(old_props) = old_properties {
let valid_from_ms = nodedb_types::ordinal_to_ms(ord);
self.edge_store
.put_edge_versioned_with_stats(
edge_ref,
&old_props,
ord,
valid_from_ms,
i64::MAX,
account_stats,
)
.map_err(|e| {
let detail = format!(
"edge restore {collection} {src_id}-[{label}]->{dst_id}: {e}"
);
error!(
core = self.core_id, entry_index,
error = %detail,
"transaction undo: edge restore failed; shard state unknown"
);
(entry_index, detail)
})?;
let weight =
crate::engine::graph::csr::extract_weight_from_properties(&old_props);
let partition = self.csr_partition_mut(did, tid);
partition.remove_edge_in_collection(&src_id, &label, &dst_id, &collection);
let csr_res = if weight != 1.0 {
partition.add_edge_weighted_in_collection(
&src_id,
&label,
&dst_id,
&collection,
weight,
)
} else {
partition.add_edge_in_collection(&src_id, &label, &dst_id, &collection)
};
csr_res.map_err(|e| {
let detail =
format!("CSR restore {collection} {src_id}-[{label}]->{dst_id}: {e}");
error!(
core = self.core_id, entry_index,
error = %detail,
"transaction undo: CSR restore failed after edge_store restore; \
shard state unknown"
);
(entry_index, detail)
})?;
} else {
self.edge_store
.soft_delete_edge_with_stats(edge_ref, ord, account_stats)
.map_err(|e| {
let detail = format!(
"edge tombstone {collection} {src_id}-[{label}]->{dst_id}: {e}"
);
error!(
core = self.core_id, entry_index,
error = %detail,
"transaction undo: edge tombstone failed; shard state unknown"
);
(entry_index, detail)
})?;
self.csr_partition_mut(did, tid).remove_edge_in_collection(
&src_id,
&label,
&dst_id,
&collection,
);
}
Ok(())
}
UndoEntry::DeleteEdge {
collection,
src_id,
label,
dst_id,
old_properties,
} => {
let tenant = nodedb_types::TenantId::new(tid);
let ord = self.hlc.next_ordinal();
let valid_from_ms = nodedb_types::ordinal_to_ms(ord);
self.edge_store
.put_edge_versioned_with_stats(
EdgeRef::new(database, tenant, &collection, &src_id, &label, &dst_id),
&old_properties,
ord,
valid_from_ms,
i64::MAX,
account_stats,
)
.map_err(|e| {
let detail = format!(
"edge re-insert {collection} {src_id}-[{label}]->{dst_id}: {e}"
);
error!(
core = self.core_id, entry_index,
error = %detail,
"transaction undo: edge re-insert failed; shard state unknown"
);
(entry_index, detail)
})?;
let weight =
crate::engine::graph::csr::extract_weight_from_properties(&old_properties);
let partition = self.csr_partition_mut(did, tid);
let csr_res = if weight != 1.0 {
partition.add_edge_weighted_in_collection(
&src_id,
&label,
&dst_id,
&collection,
weight,
)
} else {
partition.add_edge_in_collection(&src_id, &label, &dst_id, &collection)
};
csr_res.map_err(|e| {
let detail = format!("CSR re-insert {src_id}-[{label}]->{dst_id}: {e}");
error!(
core = self.core_id, entry_index,
error = %detail,
"transaction undo: CSR re-insert failed after edge_store restore; \
shard state unknown"
);
(entry_index, detail)
})
}
_ => Err((
entry_index,
"apply_undo_edge called with non-edge entry".to_string(),
)),
}
}
// ── Columnar ─────────────────────────────────────────────────────────────
pub(super) fn apply_undo_columnar(
&mut self,
entry_index: usize,
entry: UndoEntry,
) -> Result<(), (usize, String)> {
match entry {
UndoEntry::ColumnarInsert {
collection_key,
row_count_before,
inserted_pks,
displaced,
} => {
match self.columnar_engines.get_mut(&collection_key) {
Some(engine) => {
engine.rollback_memtable_inserts(
row_count_before,
&inserted_pks,
&displaced,
);
Ok(())
}
None => {
// Engine absent: no in-memory state to roll back.
// This is safe — if the engine was never created, no rows were inserted.
Ok(())
}
}
}
UndoEntry::ColumnarUpdate {
collection_key,
row_count_before,
inserted_pks,
displaced,
restored,
} => {
if let Some(engine) = self.columnar_engines.get_mut(&collection_key) {
// 1. Remove the appended replacement rows (mirrors ColumnarInsert).
engine.rollback_memtable_inserts(row_count_before, &inserted_pks, &displaced);
// 2. Restore the tombstoned originals.
engine.restore_deleted_rows(&restored);
}
// Engine absent: no in-memory state to roll back.
Ok(())
}
UndoEntry::ColumnarDelete {
collection_key,
restored,
} => {
if let Some(engine) = self.columnar_engines.get_mut(&collection_key) {
engine.restore_deleted_rows(&restored);
}
// Engine absent: no in-memory state to roll back.
Ok(())
}
_ => Err((
entry_index,
"apply_undo_columnar called with non-columnar entry".to_string(),
)),
}
}
// ── Timeseries ───────────────────────────────────────────────────────────
pub(super) fn apply_undo_timeseries(
&mut self,
entry_index: usize,
entry: UndoEntry,
) -> Result<(), (usize, String)> {
match entry {
UndoEntry::TimeseriesIngest {
collection_key,
row_count_before,
} => {
if let Some(mt) = self.columnar_memtables.get_mut(&collection_key) {
mt.truncate_to(row_count_before);
}
// If memtable is absent, no rows were ingested — nothing to undo.
Ok(())
}
_ => Err((
entry_index,
"apply_undo_timeseries called with non-timeseries entry".to_string(),
)),
}
}
}