nodedb 0.4.0

Local-first, real-time, edge-to-cloud hybrid database for multi-modal workloads
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
// SPDX-License-Identifier: BUSL-1.1

//! Handshake + fork detection.

use std::collections::HashMap;
use std::sync::Arc;
use std::time::Instant;

use tracing::{info, warn};

use crate::control::security::jwt::JwtValidator;
use crate::control::state::SharedState;

use super::super::dlq::DeviceMetadata;
use super::super::wire::*;
use super::state::SyncSession;

/// Decision returned by the durable fencing logic before building the ack.
enum FencingDecision {
    /// Accept with the given producer_id and accepted_epoch.
    Accept {
        producer_id: u64,
        accepted_epoch: u64,
    },
    /// Reject: stale epoch from a cloned / forked device. PERMANENT — the
    /// client's epoch is behind the durable record; it must regenerate its
    /// LiteId. Surfaced to the client as `fork_detected = true`.
    Reject,
    /// Reject: a transient server-side error (registry I/O, Raft propose
    /// failure / leader mid-election). NOT a fork — the client should simply
    /// retry the handshake. Surfaced as `success = false, fork_detected = false`
    /// so the client never wipes its state over a momentary server hiccup.
    RejectTransient,
}

impl SyncSession {
    /// Process a handshake message: validate JWT, store client clock, detect forks.
    ///
    /// `shared` is threaded in so the durable `SyncProducerRegistry` can be consulted
    /// when the session is a Lite client.  When `shared` is `None` (non-Lite client
    /// or unit-test path without SharedState) the handshake proceeds with no fencing
    /// (`producer_id = 0`).
    ///
    /// Returns a HandshakeAck frame to send back to the client.
    pub fn handle_handshake(
        &mut self,
        msg: &HandshakeMsg,
        jwt_validator: &JwtValidator,
        current_server_clock: HashMap<String, u64>,
        shared: Option<&Arc<SharedState>>,
    ) -> Option<SyncFrame> {
        self.last_activity = Instant::now();

        // Wire format compatibility check: reject incompatible clients early.
        // Version 0 (missing field) falls through to check_wire_compatibility
        // and is rejected cleanly as "too old".
        if let Err(e) = crate::version::check_wire_compatibility(msg.wire_version) {
            warn!(
                session = %self.session_id,
                client_wire_version = msg.wire_version,
                error = %e,
                "sync handshake rejected: incompatible wire version"
            );
            let ack = HandshakeAckMsg {
                success: false,
                session_id: self.session_id.clone(),
                server_clock: current_server_clock,
                error: Some(format!("incompatible wire version: {e}")),
                fork_detected: false,
                server_wire_version: crate::version::WIRE_FORMAT_VERSION,
                producer_id: 0,
                accepted_epoch: 0,
            };
            return SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack);
        }

        // Trust mode: an empty token resolves to the configured durable
        // principal. Never fabricate an identity that cannot own catalog data.
        if msg.jwt_token.is_empty() {
            let Some(identity) = shared.and_then(|state| {
                crate::control::server::session_auth::configured_trust_identity(state)
            }) else {
                let ack = HandshakeAckMsg {
                    success: false,
                    session_id: self.session_id.clone(),
                    server_clock: current_server_clock,
                    error: Some("configured trust identity is unavailable".into()),
                    fork_detected: false,
                    server_wire_version: crate::version::WIRE_FORMAT_VERSION,
                    producer_id: 0,
                    accepted_epoch: 0,
                };
                return SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack);
            };
            self.tenant_id = Some(identity.tenant_id);
            self.username = Some(identity.username.clone());
            self.identity = Some(identity);
            self.authenticated = true;
            self.client_clock = msg.vector_clock.clone();
            self.subscribed_shapes = msg.subscribed_shapes.clone();
            self.server_clock = current_server_clock.clone();
            self.last_seen_lsn = msg
                .vector_clock
                .values()
                .flat_map(|m| m.values().copied())
                .max()
                .unwrap_or(0);
            self.device_metadata = DeviceMetadata {
                client_version: msg.client_version.clone(),
                remote_addr: String::new(),
                peer_id: 0,
            };

            let tenant_id = self.tenant_id.map(|t| t.as_u64()).unwrap_or(0);
            match self.durable_fencing_decision(msg, shared, tenant_id) {
                Some(FencingDecision::Reject) => {
                    return self.fork_reject_frame(
                        &current_server_clock,
                        "FORK_DETECTED: stale epoch — regenerate LiteId and reconnect",
                    );
                }
                Some(FencingDecision::RejectTransient) => {
                    return self.transient_reject_frame(
                        &current_server_clock,
                        "SYNC_UNAVAILABLE: transient server error — retry the handshake",
                    );
                }
                Some(FencingDecision::Accept {
                    producer_id,
                    accepted_epoch,
                }) => {
                    self.producer_id = producer_id;
                    self.accepted_epoch = accepted_epoch;
                }
                None => {}
            }

            info!(session = %self.session_id, "sync handshake OK (trust mode)");

            let ack = HandshakeAckMsg {
                success: true,
                session_id: self.session_id.clone(),
                server_clock: current_server_clock,
                error: None,
                fork_detected: false,
                server_wire_version: crate::version::WIRE_FORMAT_VERSION,
                producer_id: self.producer_id,
                accepted_epoch: self.accepted_epoch,
            };
            return SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack);
        }

        // Validate JWT.
        match jwt_validator.validate(&msg.jwt_token) {
            Ok(identity) => {
                self.tenant_id = Some(identity.tenant_id);
                self.username = Some(identity.username.clone());
                self.identity = Some(identity.clone());
                self.authenticated = true;
                self.client_clock = msg.vector_clock.clone();
                self.subscribed_shapes = msg.subscribed_shapes.clone();
                self.server_clock = current_server_clock.clone();
                self.last_seen_lsn = msg
                    .vector_clock
                    .values()
                    .flat_map(|m| m.values().copied())
                    .max()
                    .unwrap_or(0);
                self.device_metadata = DeviceMetadata {
                    client_version: msg.client_version.clone(),
                    remote_addr: String::new(),
                    peer_id: 0,
                };

                let tenant_id = identity.tenant_id.as_u64();
                match self.durable_fencing_decision(msg, shared, tenant_id) {
                    Some(FencingDecision::Reject) => {
                        return self.fork_reject_frame(
                            &current_server_clock,
                            "FORK_DETECTED: stale epoch — regenerate LiteId and reconnect",
                        );
                    }
                    Some(FencingDecision::RejectTransient) => {
                        return self.transient_reject_frame(
                            &current_server_clock,
                            "SYNC_UNAVAILABLE: transient server error — retry the handshake",
                        );
                    }
                    Some(FencingDecision::Accept {
                        producer_id,
                        accepted_epoch,
                    }) => {
                        self.producer_id = producer_id;
                        self.accepted_epoch = accepted_epoch;
                    }
                    None => {}
                }

                info!(
                    session = %self.session_id,
                    user = %identity.username,
                    tenant = identity.tenant_id.as_u64(),
                    shapes = self.subscribed_shapes.len(),
                    "sync handshake OK"
                );

                let ack = HandshakeAckMsg {
                    success: true,
                    session_id: self.session_id.clone(),
                    server_clock: current_server_clock,
                    error: None,
                    fork_detected: false,
                    server_wire_version: crate::version::WIRE_FORMAT_VERSION,
                    producer_id: self.producer_id,
                    accepted_epoch: self.accepted_epoch,
                };
                SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack)
            }
            Err(e) => {
                warn!(
                    session = %self.session_id,
                    error = %e,
                    "sync handshake FAILED"
                );
                let ack = HandshakeAckMsg {
                    success: false,
                    session_id: self.session_id.clone(),
                    server_clock: HashMap::new(),
                    error: Some(e.to_string()),
                    fork_detected: false,
                    server_wire_version: crate::version::WIRE_FORMAT_VERSION,
                    producer_id: 0,
                    accepted_epoch: 0,
                };
                SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack)
            }
        }
    }

    /// Build a failed HandshakeAck rejection frame: `success=false`, the
    /// supplied `message` in the `error` field, and the given `fork_detected`
    /// flag. Shared by [`Self::fork_reject_frame`] and
    /// [`Self::transient_reject_frame`] so the envelope stays identical.
    fn build_reject_frame(
        &self,
        server_clock: &HashMap<String, u64>,
        message: &str,
        fork_detected: bool,
    ) -> Option<SyncFrame> {
        let ack = HandshakeAckMsg {
            success: false,
            session_id: self.session_id.clone(),
            server_clock: server_clock.clone(),
            error: Some(message.into()),
            fork_detected,
            server_wire_version: crate::version::WIRE_FORMAT_VERSION,
            producer_id: 0,
            accepted_epoch: 0,
        };
        SyncFrame::try_encode(SyncMessageType::HandshakeAck, &ack)
    }

    /// Build a fork-detected rejection frame (`fork_detected=true`): the client
    /// treats the session as a permanent fork and wipes its local state.
    fn fork_reject_frame(
        &self,
        server_clock: &HashMap<String, u64>,
        message: &str,
    ) -> Option<SyncFrame> {
        warn!(
            session = %self.session_id,
            "FORK DETECTED: {message}"
        );
        self.build_reject_frame(server_clock, message, true)
    }

    /// Build a failed-but-retryable handshake ack for a transient server-side
    /// error (registry I/O, Raft propose failure / leader mid-election).
    ///
    /// Distinct from [`Self::fork_reject_frame`]: `fork_detected = false`, so
    /// the client retries the handshake rather than treating the session as a
    /// permanent fork and wiping its local state.
    fn transient_reject_frame(
        &self,
        server_clock: &HashMap<String, u64>,
        message: &str,
    ) -> Option<SyncFrame> {
        warn!(
            session = %self.session_id,
            "sync handshake transient error (retryable): {message}"
        );
        self.build_reject_frame(server_clock, message, false)
    }

    /// Attempt to make a durable fencing decision via `SyncProducerRegistry`.
    ///
    /// Returns `Some(FencingDecision)` when the msg is a Lite handshake
    /// (`!lite_id.is_empty() && epoch > 0`) and a registry is available via
    /// `shared`.  Returns `None` when:
    ///
    /// * The msg is not a Lite handshake (non-Lite / legacy client).
    /// * No `SharedState` is present (unit-test path) — handshake proceeds
    ///   with no fencing.
    /// * `shared` has no `producer_registry` — handshake proceeds with no fencing.
    ///
    /// On registry operation errors the decision is `Reject` (fail-closed) rather
    /// than silently accepting.
    fn durable_fencing_decision(
        &self,
        msg: &HandshakeMsg,
        shared: Option<&Arc<SharedState>>,
        tenant_id: u64,
    ) -> Option<FencingDecision> {
        if msg.lite_id.is_empty() || msg.epoch == 0 {
            return None;
        }

        let registry = shared.and_then(|s| s.producer_registry.as_deref());

        match registry {
            Some(reg) => {
                // `shared` is always `Some` when `registry` is `Some` (the
                // registry was obtained via `shared.and_then(...)`); the `?`
                // is just to recover the handle.
                let shared_ref = shared?;

                let now_ms = std::time::SystemTime::now()
                    .duration_since(std::time::UNIX_EPOCH)
                    .unwrap_or_default()
                    .as_millis() as i64;

                match reg.get(&msg.lite_id) {
                    Err(e) => {
                        warn!(
                            session = %self.session_id,
                            lite_id = %msg.lite_id,
                            error = %e,
                            "sync handshake: registry.get failed; rejecting as retryable"
                        );
                        Some(FencingDecision::RejectTransient)
                    }
                    Ok(None) => {
                        // First time we see this lite_id: register and accept.
                        // The local write keeps single-node correct; the Raft
                        // propose replicates the producer_id+epoch to all
                        // followers so state survives leader failover.
                        match reg.register(&msg.lite_id, tenant_id, msg.epoch, now_ms) {
                            Ok(registration) => {
                                if let Err(e) =
                                    crate::control::metadata_proposer::propose_sync_producer_register(
                                        shared_ref.as_ref(),
                                        &msg.lite_id,
                                        registration.producer_id,
                                        tenant_id,
                                        registration.current_epoch,
                                        now_ms,
                                    )
                                {
                                    warn!(
                                        session = %self.session_id,
                                        lite_id = %msg.lite_id,
                                        error = %e,
                                        "sync handshake: propose_sync_producer_register failed; \
                                         rejecting as retryable"
                                    );
                                    return Some(FencingDecision::RejectTransient);
                                }
                                Some(FencingDecision::Accept {
                                    producer_id: registration.producer_id,
                                    accepted_epoch: registration.current_epoch,
                                })
                            }
                            Err(e) => {
                                warn!(
                                    session = %self.session_id,
                                    lite_id = %msg.lite_id,
                                    error = %e,
                                    "sync handshake: registry.register failed; rejecting as retryable"
                                );
                                Some(FencingDecision::RejectTransient)
                            }
                        }
                    }
                    Ok(Some(existing)) => {
                        if msg.epoch > existing.current_epoch {
                            // Epoch advanced: fence the old epoch and accept the new one.
                            // The local write keeps single-node correct; the Raft
                            // propose replicates the epoch advance cluster-wide.
                            match reg.fence(&msg.lite_id, msg.epoch) {
                                Ok(()) => {
                                    if let Err(e) =
                                        crate::control::metadata_proposer::propose_sync_producer_fence(
                                            shared_ref.as_ref(),
                                            &msg.lite_id,
                                            msg.epoch,
                                        )
                                    {
                                        warn!(
                                            session = %self.session_id,
                                            lite_id = %msg.lite_id,
                                            error = %e,
                                            "sync handshake: propose_sync_producer_fence failed; \
                                             rejecting as retryable"
                                        );
                                        return Some(FencingDecision::RejectTransient);
                                    }
                                    Some(FencingDecision::Accept {
                                        producer_id: existing.producer_id,
                                        accepted_epoch: msg.epoch,
                                    })
                                }
                                Err(e) => {
                                    warn!(
                                        session = %self.session_id,
                                        lite_id = %msg.lite_id,
                                        error = %e,
                                        "sync handshake: registry.fence failed; rejecting as retryable"
                                    );
                                    Some(FencingDecision::RejectTransient)
                                }
                            }
                        } else if msg.epoch == existing.current_epoch {
                            // Same epoch: idempotent re-connect (at-least-once redelivery).
                            // No state change — no propose needed.
                            Some(FencingDecision::Accept {
                                producer_id: existing.producer_id,
                                accepted_epoch: existing.current_epoch,
                            })
                        } else {
                            // msg.epoch < existing.current_epoch: stale/forked device.
                            // No state change — no propose needed.
                            warn!(
                                session = %self.session_id,
                                lite_id = %msg.lite_id,
                                client_epoch = msg.epoch,
                                current_epoch = existing.current_epoch,
                                "FORK DETECTED: client epoch is behind persisted epoch"
                            );
                            Some(FencingDecision::Reject)
                        }
                    }
                }
            }
            // No registry available: no fencing decision — handshake proceeds.
            None => None,
        }
    }
}

#[cfg(test)]
mod tests {
    use std::collections::HashMap;
    use std::sync::Arc;

    use nodedb_types::sync::wire::{HandshakeAckMsg, HandshakeMsg};

    use crate::bridge::dispatch::Dispatcher;
    use crate::control::security::catalog::SystemCatalog;
    use crate::control::security::jwt::{JwtConfig, JwtValidator};
    use crate::control::server::sync::session::state::SyncSession;
    use crate::control::state::SharedState;
    use crate::control::sync_producer::registry::SyncProducerRegistry;
    use crate::wal::WalManager;

    fn make_handshake(wire_version: u16) -> HandshakeMsg {
        HandshakeMsg {
            jwt_token: String::new(),
            vector_clock: HashMap::new(),
            subscribed_shapes: Vec::new(),
            client_version: "test".into(),
            lite_id: String::new(),
            epoch: 0,
            wire_version,
        }
    }

    fn open_registry(dir: &std::path::Path) -> SyncProducerRegistry {
        let catalog = Arc::new(SystemCatalog::open(&dir.join("system.redb")).unwrap());
        SyncProducerRegistry::open(catalog).unwrap()
    }

    fn trust_state() -> (Arc<SharedState>, tempfile::TempDir) {
        let dir = tempfile::tempdir().expect("tempdir");
        let wal = Arc::new(
            WalManager::open_for_testing(&dir.path().join("sync-trust.wal")).expect("open WAL"),
        );
        let (dispatcher, _data_sides) = Dispatcher::new(1, 64);
        let state = SharedState::new(dispatcher, wal).expect("shared state");
        state
            .credentials
            .bootstrap_trust_superuser("nodedb")
            .expect("bootstrap trust superuser");
        (state, dir)
    }

    #[tokio::test]
    async fn empty_token_uses_configured_durable_trust_identity() {
        let (state, _dir) = trust_state();
        let mut session = SyncSession::new("test-session".into());
        let validator = JwtValidator::new(JwtConfig::default());
        let msg = make_handshake(crate::version::WIRE_FORMAT_VERSION);

        let frame = session
            .handle_handshake(&msg, &validator, HashMap::new(), Some(&state))
            .expect("handshake response");
        let ack: HandshakeAckMsg = frame.decode_body().expect("decode handshake ack");

        assert!(ack.success, "configured trust handshake should succeed");
        let identity = session.identity.expect("durable trust identity");
        assert_eq!(identity.username, "nodedb");
        assert_ne!(identity.user_id, 0);
        assert!(identity.is_superuser);
    }

    #[test]
    fn empty_token_without_configured_identity_fails_closed() {
        let mut session = SyncSession::new("test-session".into());
        let validator = JwtValidator::new(JwtConfig::default());
        let msg = make_handshake(crate::version::WIRE_FORMAT_VERSION);

        let frame = session
            .handle_handshake(&msg, &validator, HashMap::new(), None)
            .expect("handshake response");
        let ack: HandshakeAckMsg = frame.decode_body().expect("decode handshake ack");

        assert!(!ack.success);
        assert!(!session.authenticated);
        assert!(session.identity.is_none());
    }

    #[test]
    fn handshake_rejects_wire_version_zero() {
        let mut session = SyncSession::new("test-session".into());
        let validator = JwtValidator::new(JwtConfig::default());
        let msg = make_handshake(0);

        let frame = session
            .handle_handshake(&msg, &validator, HashMap::new(), None)
            .expect("should return a frame");

        let ack: HandshakeAckMsg = frame.decode_body().expect("should decode HandshakeAckMsg");
        assert!(
            !ack.success,
            "wire_version=0 must be rejected, got success=true"
        );
        let error = ack.error.expect("error message must be present");
        assert!(
            error.contains("wire version") || error.contains("incompatible"),
            "error message should mention wire version, got: {error}"
        );
    }

    /// Uses the registry directly (not via SharedState) to exercise
    /// `durable_fencing_decision` in isolation.
    #[test]
    fn registry_new_lite_id_assigns_producer_id() {
        let dir = tempfile::tempdir().unwrap();
        let reg = open_registry(dir.path());

        // Simulate what durable_fencing_decision does for a new lite_id.
        let r = reg.register("device-a", 1, 10, 0).unwrap();
        assert!(r.producer_id > 0);
        assert_eq!(r.current_epoch, 10);
    }

    #[test]
    fn registry_same_epoch_idempotent() {
        let dir = tempfile::tempdir().unwrap();
        let reg = open_registry(dir.path());

        let first = reg.register("device-b", 1, 5, 0).unwrap();
        let loaded = reg.get("device-b").unwrap().unwrap();
        assert_eq!(loaded.producer_id, first.producer_id);
        assert_eq!(loaded.current_epoch, 5);
    }

    #[test]
    fn registry_higher_epoch_fences() {
        let dir = tempfile::tempdir().unwrap();
        let reg = open_registry(dir.path());

        let first = reg.register("device-c", 1, 3, 0).unwrap();
        reg.fence("device-c", 7).unwrap();
        let loaded = reg.get("device-c").unwrap().unwrap();
        assert_eq!(loaded.producer_id, first.producer_id);
        assert_eq!(loaded.current_epoch, 7);
    }

    #[test]
    fn registry_lower_epoch_is_stale() {
        let dir = tempfile::tempdir().unwrap();
        let reg = open_registry(dir.path());

        reg.register("device-d", 1, 9, 0).unwrap();
        let loaded = reg.get("device-d").unwrap().unwrap();
        // A client presenting epoch < current_epoch (9) must be rejected.
        assert!(
            3 < loaded.current_epoch,
            "epoch 3 is stale vs {}",
            loaded.current_epoch
        );
    }
}