1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
// SPDX-License-Identifier: BUSL-1.1
//! KV Get, Put, Delete, Truncate handlers.
use nodedb_types::Surrogate;
use tracing::debug;
use crate::bridge::envelope::{ErrorCode, Response};
use crate::data::executor::core_loop::CoreLoop;
use crate::data::executor::response_codec;
use crate::data::executor::task::ExecutionTask;
use crate::engine::kv::current_ms;
/// Parameters for `INSERT ... ON CONFLICT (key) DO UPDATE SET ...` on KV.
pub(in crate::data::executor) struct KvInsertOnConflictUpdateParams<'a> {
pub tid: u64,
pub collection: &'a str,
pub key: &'a [u8],
pub value: &'a [u8],
pub ttl_ms: u64,
pub updates: &'a [(String, crate::bridge::physical_plan::UpdateValue)],
pub surrogate: Surrogate,
}
impl CoreLoop {
pub(in crate::data::executor) fn execute_kv_get(
&self,
task: &ExecutionTask,
tid: u64,
collection: &str,
key: &[u8],
rls_filters: &[u8],
surrogate_ceiling: Option<u32>,
) -> Response {
debug!(core = self.core_id, %collection, "kv get");
let now_ms = current_ms();
let fetched = match surrogate_ceiling {
Some(ceiling) => {
// Clone-delegated read: drop the row when its binding was
// allocated AFTER the clone's AS-OF surrogate ceiling.
// `Surrogate::ZERO` means the entry was created via an
// internal RMW path that did not bind an identity; treat
// it as pre-clone (visible) — internal rows do not
// originate from user post-clone writes.
self.kv_engine
.get_with_surrogate(tid, collection, key, now_ms)
.and_then(|(value, surrogate)| {
let s = surrogate.as_u32();
if s != 0 && s > ceiling {
None
} else {
Some(value)
}
})
}
None => self.kv_engine.get(tid, collection, key, now_ms),
};
match fetched {
Some(value) => {
// RLS post-fetch: evaluate filters against KV value.
if !crate::data::executor::handlers::rls_eval::rls_check_msgpack_bytes(
rls_filters,
&value,
) {
return self.response_with_payload(task, Vec::new());
}
if let Some(ref m) = self.metrics {
m.record_kv_get();
}
// Value is already standard msgpack — pass through directly.
self.response_with_payload(task, value)
}
None => self.response_with_payload(task, Vec::new()),
}
}
#[allow(clippy::too_many_arguments)]
pub(in crate::data::executor) fn execute_kv_put(
&mut self,
task: &ExecutionTask,
tid: u64,
collection: &str,
key: &[u8],
value: &[u8],
ttl_ms: u64,
surrogate: Surrogate,
) -> Response {
debug!(core = self.core_id, %collection, "kv put");
// Memory budget check: reject new PUTs when over budget.
if self.kv_engine.is_over_budget() {
return self.response_error(
task,
ErrorCode::Internal {
detail: "KV memory budget exceeded, retry later".into(),
},
);
}
let now_ms: u64 = self
.epoch_system_ms
.map(|ms| ms as u64)
.unwrap_or_else(current_ms);
let old = self
.kv_engine
.put(tid, collection, key, value, ttl_ms, now_ms, surrogate);
if let Some(ref m) = self.metrics {
m.record_kv_put();
}
// RESP SET / UPSERT semantics: if `old` is present the write
// replaced an existing row and the Event Plane must see an Update
// event with both sides populated. Otherwise it was a fresh
// Insert.
let key_str = String::from_utf8_lossy(key);
let (op, old_slice): (_, Option<&[u8]>) = match old.as_deref() {
Some(o) => (crate::event::WriteOp::Update, Some(o)),
None => (crate::event::WriteOp::Insert, None),
};
self.emit_write_event(task, collection, op, &key_str, Some(value), old_slice);
self.response_ok(task)
}
/// SQL `INSERT` semantics: write only if key doesn't already exist.
/// Duplicate raises `unique_violation` (SQLSTATE 23505). Distinct from
/// `execute_kv_put` which is RESP-SET / UPSERT upsert semantics.
///
/// Existence probe is linearizable with the subsequent put: KV shards
/// are pinned to one Data Plane core (vshard routing), and the core
/// loop runs ops serially — no other writer can slip between the
/// probe and the put on the same key.
#[allow(clippy::too_many_arguments)]
pub(in crate::data::executor) fn execute_kv_insert(
&mut self,
task: &ExecutionTask,
tid: u64,
collection: &str,
key: &[u8],
value: &[u8],
ttl_ms: u64,
surrogate: Surrogate,
) -> Response {
debug!(core = self.core_id, %collection, "kv insert");
if self.kv_engine.is_over_budget() {
return self.response_error(
task,
ErrorCode::Internal {
detail: "KV memory budget exceeded, retry later".into(),
},
);
}
let now_ms = current_ms();
if self.kv_engine.get(tid, collection, key, now_ms).is_some() {
let key_str = String::from_utf8_lossy(key);
return self.response_error(
task,
crate::Error::RejectedConstraint {
collection: collection.to_string(),
constraint: "unique".to_string(),
detail: format!(
"duplicate key value '{key_str}' violates primary-key \
uniqueness on '{collection}'"
),
},
);
}
self.kv_engine
.put(tid, collection, key, value, ttl_ms, now_ms, surrogate);
if let Some(ref m) = self.metrics {
m.record_kv_put();
}
let key_str = String::from_utf8_lossy(key);
self.emit_write_event(
task,
collection,
crate::event::WriteOp::Insert,
&key_str,
Some(value),
None,
);
self.response_ok(task)
}
/// SQL `INSERT ... ON CONFLICT DO NOTHING` semantics: write if absent,
/// silent no-op on duplicate. No error on conflict.
#[allow(clippy::too_many_arguments)]
pub(in crate::data::executor) fn execute_kv_insert_if_absent(
&mut self,
task: &ExecutionTask,
tid: u64,
collection: &str,
key: &[u8],
value: &[u8],
ttl_ms: u64,
surrogate: Surrogate,
) -> Response {
debug!(core = self.core_id, %collection, "kv insert-if-absent");
if self.kv_engine.is_over_budget() {
return self.response_error(
task,
ErrorCode::Internal {
detail: "KV memory budget exceeded, retry later".into(),
},
);
}
let now_ms = current_ms();
if self.kv_engine.get(tid, collection, key, now_ms).is_some() {
// Silent skip — matches the strict/schemaless `if_absent` path.
return self.response_ok(task);
}
self.kv_engine
.put(tid, collection, key, value, ttl_ms, now_ms, surrogate);
if let Some(ref m) = self.metrics {
m.record_kv_put();
}
let key_str = String::from_utf8_lossy(key);
self.emit_write_event(
task,
collection,
crate::event::WriteOp::Insert,
&key_str,
Some(value),
None,
);
self.response_ok(task)
}
/// SQL `INSERT ... ON CONFLICT (key) DO UPDATE SET ...` semantics.
/// Read-modify-write: if the key is absent, plain put; if present,
/// decode the stored value, apply the updates (with `EXCLUDED`
/// resolving to the would-be-inserted row), and write the merged
/// result back.
#[allow(clippy::too_many_arguments)]
pub(in crate::data::executor) fn execute_kv_insert_on_conflict_update(
&mut self,
task: &ExecutionTask,
params: KvInsertOnConflictUpdateParams<'_>,
) -> Response {
let KvInsertOnConflictUpdateParams {
tid,
collection,
key,
value,
ttl_ms,
updates,
surrogate,
} = params;
debug!(core = self.core_id, %collection, "kv insert-on-conflict-update");
if self.kv_engine.is_over_budget() {
return self.response_error(
task,
ErrorCode::Internal {
detail: "KV memory budget exceeded, retry later".into(),
},
);
}
let now_ms = current_ms();
let existing_bytes = self.kv_engine.get(tid, collection, key, now_ms);
let stored_bytes: Vec<u8> = match &existing_bytes {
None => value.to_vec(),
Some(existing_raw) => {
let existing_val = match nodedb_types::value_from_msgpack(existing_raw) {
Ok(v) => v,
Err(_) => {
return self.response_error(
task,
ErrorCode::Internal {
detail: "failed to decode existing KV value for ON CONFLICT \
DO UPDATE"
.into(),
},
);
}
};
let excluded_val = match nodedb_types::value_from_msgpack(value) {
Ok(v) => v,
Err(_) => {
return self.response_error(
task,
ErrorCode::Internal {
detail: "failed to decode incoming KV value for ON CONFLICT \
DO UPDATE"
.into(),
},
);
}
};
let merged = super::super::upsert::apply_on_conflict_updates(
existing_val,
&excluded_val,
updates,
);
match nodedb_types::value_to_msgpack(&merged) {
Ok(b) => b,
Err(_) => {
return self.response_error(
task,
ErrorCode::Internal {
detail: "failed to encode merged KV value".into(),
},
);
}
}
}
};
self.kv_engine.put(
tid,
collection,
key,
&stored_bytes,
ttl_ms,
now_ms,
surrogate,
);
if let Some(ref m) = self.metrics {
m.record_kv_put();
}
// `ON CONFLICT DO UPDATE` onto an existing row is an Update from
// every downstream consumer's perspective; a fresh key with no
// prior value is an Insert. The pre-write `existing_bytes` probe
// above is the source of truth.
let key_str = String::from_utf8_lossy(key);
let (op, old_slice): (_, Option<&[u8]>) = match existing_bytes.as_deref() {
Some(o) => (crate::event::WriteOp::Update, Some(o)),
None => (crate::event::WriteOp::Insert, None),
};
self.emit_write_event(
task,
collection,
op,
&key_str,
Some(&stored_bytes),
old_slice,
);
self.response_ok(task)
}
pub(in crate::data::executor) fn execute_kv_delete(
&mut self,
task: &ExecutionTask,
tid: u64,
collection: &str,
keys: &[Vec<u8>],
) -> Response {
debug!(core = self.core_id, %collection, count = keys.len(), "kv delete");
let now_ms = current_ms();
let count = self.kv_engine.delete(tid, collection, keys, now_ms);
if let Some(ref m) = self.metrics {
m.record_kv_delete();
}
// Emit delete events to Event Plane (one per deleted key).
if count > 0 {
for key in keys {
let key_str = String::from_utf8_lossy(key);
self.emit_write_event(
task,
collection,
crate::event::WriteOp::Delete,
&key_str,
None,
None,
);
}
}
match response_codec::encode_count("deleted", count) {
Ok(payload) => self.response_with_payload(task, payload),
Err(e) => self.response_error(
task,
ErrorCode::Internal {
detail: e.to_string(),
},
),
}
}
pub(in crate::data::executor) fn execute_kv_truncate(
&mut self,
task: &ExecutionTask,
tid: u64,
collection: &str,
) -> Response {
debug!(core = self.core_id, %collection, "kv truncate");
let count = self.kv_engine.truncate(tid, collection);
match response_codec::encode_count("deleted", count) {
Ok(payload) => self.response_with_payload(task, payload),
Err(e) => self.response_error(
task,
ErrorCode::Internal {
detail: e.to_string(),
},
),
}
}
}