nms-graph 0.2.0

In-memory galactic model with spatial index and routing for No Man's Sky Copilot
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
//! The GalaxyModel -- central in-memory representation of the player's galaxy.

use std::collections::HashMap;

use petgraph::Undirected;
use petgraph::stable_graph::{NodeIndex, StableGraph};
use rstar::RTree;

use nms_core::address::GalacticAddress;
use nms_core::biome::Biome;
use nms_core::delta::SaveDelta;
use nms_core::player::{PlayerBase, PlayerState};
use nms_core::system::{Planet, System};
use nms_save::model::SaveRoot;

use crate::extract::extract_systems;
use crate::spatial::{SystemId, SystemPoint};

/// Key for looking up a specific planet: (system, planet index).
pub type PlanetKey = (SystemId, u8);

/// The in-memory galactic model.
///
/// Three parallel data structures kept in sync:
/// 1. petgraph -- topology (pathfinding, routing)
/// 2. R-tree -- spatial (nearest-neighbor, radius queries)
/// 3. HashMaps -- associative (name, biome, address lookups)
#[derive(Debug)]
pub struct GalaxyModel {
    /// Graph topology: nodes are systems, edge weights are distance in ly.
    pub graph: StableGraph<SystemId, f64, Undirected>,

    /// Per-galaxy 3D spatial indexes of system positions.
    pub spatial: HashMap<u8, RTree<SystemPoint>>,

    /// Currently active galaxy for spatial queries.
    pub active_galaxy: u8,

    /// System data by ID.
    pub systems: HashMap<SystemId, System>,

    /// Planet data by (SystemId, planet_index).
    pub planets: HashMap<PlanetKey, Planet>,

    /// Base lookup by name (lowercase).
    pub bases: HashMap<String, PlayerBase>,

    /// Biome -> list of planets with that biome.
    pub biome_index: HashMap<Biome, Vec<PlanetKey>>,

    /// System name -> SystemId (lowercase, only for named systems).
    pub name_index: HashMap<String, SystemId>,

    /// Packed address (planet bits zeroed) -> SystemId.
    pub address_to_id: HashMap<u64, SystemId>,

    /// SystemId -> petgraph NodeIndex.
    pub node_map: HashMap<SystemId, NodeIndex>,

    /// Current player state (position, currencies).
    pub player_state: Option<PlayerState>,
}

impl Default for GalaxyModel {
    fn default() -> Self {
        Self::new()
    }
}

impl GalaxyModel {
    /// Create an empty `GalaxyModel`.
    pub fn new() -> Self {
        Self {
            graph: StableGraph::default(),
            spatial: HashMap::new(),
            active_galaxy: 0,
            systems: HashMap::new(),
            planets: HashMap::new(),
            bases: HashMap::new(),
            biome_index: HashMap::new(),
            name_index: HashMap::new(),
            address_to_id: HashMap::new(),
            node_map: HashMap::new(),
            player_state: None,
        }
    }

    /// Build a `GalaxyModel` from a parsed save file.
    pub fn from_save(save: &SaveRoot) -> Self {
        let extracted = extract_systems(save);

        let mut graph: StableGraph<SystemId, f64, Undirected> = StableGraph::default();
        let mut galaxy_points: HashMap<u8, Vec<SystemPoint>> = HashMap::new();
        let mut systems = HashMap::with_capacity(extracted.len());
        let mut planets = HashMap::new();
        let mut biome_index: HashMap<Biome, Vec<PlanetKey>> = HashMap::new();
        let mut name_index = HashMap::new();
        let mut address_to_id = HashMap::new();
        let mut node_map = HashMap::new();

        for (sys_id, system) in extracted {
            // Add to petgraph
            let node_idx = graph.add_node(sys_id);
            node_map.insert(sys_id, node_idx);

            // Add to per-galaxy spatial point collector
            let point = SystemPoint::from_address(&system.address);
            let galaxy = system.address.reality_index;
            galaxy_points.entry(galaxy).or_default().push(point);

            // Add to address lookup
            address_to_id.insert(sys_id.0, sys_id);

            // Add to name index
            if let Some(ref name) = system.name {
                name_index.insert(name.to_lowercase(), sys_id);
            }

            // Extract planets into flat index
            for planet in &system.planets {
                let key = (sys_id, planet.index);
                if let Some(biome) = planet.biome {
                    biome_index.entry(biome).or_default().push(key);
                }
                planets.insert(key, planet.clone());
            }

            systems.insert(sys_id, system);
        }

        // Build per-galaxy R-trees from collected points
        let spatial: HashMap<u8, RTree<SystemPoint>> = galaxy_points
            .into_iter()
            .map(|(galaxy, points)| (galaxy, RTree::bulk_load(points)))
            .collect();

        // Extract player state and determine active galaxy
        let player_state = Some(save.to_core_player_state());
        let active_galaxy = save.active_player_state().universe_address.reality_index;

        // Extract bases
        let ps = save.active_player_state();
        let mut bases = HashMap::new();
        for base in &ps.persistent_player_bases {
            let core_base = base.to_core_base();
            if !core_base.name.is_empty() {
                bases.insert(core_base.name.to_lowercase(), core_base);
            }
        }

        let mut model = Self {
            graph,
            spatial,
            active_galaxy,
            systems,
            planets,
            bases,
            biome_index,
            name_index,
            address_to_id,
            node_map,
            player_state,
        };

        model.build_edges(crate::edges::EdgeStrategy::default());
        model
    }

    /// Number of systems in the model.
    pub fn system_count(&self) -> usize {
        self.systems.len()
    }

    /// Number of planets in the model.
    pub fn planet_count(&self) -> usize {
        self.planets.len()
    }

    /// Number of bases in the model.
    pub fn base_count(&self) -> usize {
        self.bases.len()
    }

    /// Look up a system by its ID.
    pub fn system(&self, id: &SystemId) -> Option<&System> {
        self.systems.get(id)
    }

    /// Look up a system by name (case-insensitive).
    pub fn system_by_name(&self, name: &str) -> Option<(&SystemId, &System)> {
        self.name_index
            .get(&name.to_lowercase())
            .and_then(|id| self.systems.get(id).map(|s| (id, s)))
    }

    /// Look up a base by name (case-insensitive).
    pub fn base(&self, name: &str) -> Option<&PlayerBase> {
        self.bases.get(&name.to_lowercase())
    }

    /// Get the player's current position, if available.
    pub fn player_position(&self) -> Option<&GalacticAddress> {
        self.player_state.as_ref().map(|ps| &ps.current_address)
    }

    /// Get the spatial index for the active galaxy.
    pub fn active_spatial(&self) -> Option<&RTree<SystemPoint>> {
        self.spatial.get(&self.active_galaxy)
    }

    /// Get the spatial index for a specific galaxy.
    pub fn spatial_for(&self, galaxy: u8) -> Option<&RTree<SystemPoint>> {
        self.spatial.get(&galaxy)
    }

    /// Switch the active galaxy.
    pub fn set_active_galaxy(&mut self, galaxy: u8) {
        self.active_galaxy = galaxy;
    }

    /// List galaxies that have at least one discovered system.
    pub fn discovered_galaxies(&self) -> Vec<u8> {
        let mut galaxies: Vec<u8> = self.spatial.keys().copied().collect();
        galaxies.sort();
        galaxies
    }

    /// Rebuild all per-galaxy R-trees from the systems HashMap.
    pub fn rebuild_spatial(&mut self) {
        let mut galaxy_points: HashMap<u8, Vec<SystemPoint>> = HashMap::new();
        for system in self.systems.values() {
            let point = SystemPoint::from_address(&system.address);
            let galaxy = system.address.reality_index;
            galaxy_points.entry(galaxy).or_default().push(point);
        }
        self.spatial = galaxy_points
            .into_iter()
            .map(|(galaxy, points)| (galaxy, RTree::bulk_load(points)))
            .collect();
    }

    /// Total number of points across all per-galaxy spatial indexes.
    pub fn spatial_size(&self) -> usize {
        self.spatial.values().map(|t| t.size()).sum()
    }

    /// Get all planets with a given biome.
    pub fn planets_by_biome(&self, biome: Biome) -> Vec<&Planet> {
        self.biome_index
            .get(&biome)
            .map(|keys| keys.iter().filter_map(|k| self.planets.get(k)).collect())
            .unwrap_or_default()
    }

    /// Insert a new system into all indexes.
    pub fn insert_system(&mut self, system: System) {
        let sys_id = SystemId::from_address(&system.address);

        if self.systems.contains_key(&sys_id) {
            return; // Already exists
        }

        let node_idx = self.graph.add_node(sys_id);
        self.node_map.insert(sys_id, node_idx);

        let point = SystemPoint::from_address(&system.address);
        let galaxy = system.address.reality_index;
        self.spatial.entry(galaxy).or_default().insert(point);

        self.address_to_id.insert(sys_id.0, sys_id);

        if let Some(ref name) = system.name {
            self.name_index.insert(name.to_lowercase(), sys_id);
        }

        for planet in &system.planets {
            let key = (sys_id, planet.index);
            if let Some(biome) = planet.biome {
                self.biome_index.entry(biome).or_default().push(key);
            }
            self.planets.insert(key, planet.clone());
        }

        self.systems.insert(sys_id, system);
    }

    /// Ensure the player's current system exists in the model.
    ///
    /// If the player's system has no discovery record, this inserts a
    /// placeholder system at the player's address so that distance queries
    /// correctly return 0.0 for in-system results.
    pub fn ensure_player_system(&mut self) {
        if let Some(ref ps) = self.player_state {
            let player_addr = ps.current_address;
            let player_sys_id = SystemId::from_address(&player_addr);
            if !self.systems.contains_key(&player_sys_id) {
                let sentinel = System::new(player_addr, None, None, None, vec![]);
                self.insert_system(sentinel);
            }
        }
    }

    /// Insert a base into the model.
    pub fn insert_base(&mut self, base: PlayerBase) {
        if !base.name.is_empty() {
            self.bases.insert(base.name.to_lowercase(), base);
        }
    }

    /// Apply a delta from the file watcher to update the model incrementally.
    ///
    /// Inserts new systems and planets, updates player position, and
    /// adds/updates bases. Does NOT rebuild graph edges -- call
    /// `build_edges()` afterward if needed for routing.
    pub fn apply_delta(&mut self, delta: &SaveDelta) {
        // 1. Insert new systems (with their planets)
        for system in &delta.new_systems {
            self.insert_system(system.clone());
        }

        // 2. Insert new planets into existing systems
        for (sys_id, planet) in &delta.new_planets {
            let key = (*sys_id, planet.index);
            if !self.planets.contains_key(&key) {
                if let Some(biome) = planet.biome {
                    self.biome_index.entry(biome).or_default().push(key);
                }
                self.planets.insert(key, planet.clone());

                // Also add to the system's planet list
                if let Some(system) = self.systems.get_mut(sys_id)
                    && !system.planets.iter().any(|p| p.index == planet.index)
                {
                    system.planets.push(planet.clone());
                }
            }
        }

        // 3. Update player position
        if let Some(ref moved) = delta.player_moved
            && let Some(ref mut ps) = self.player_state
        {
            ps.current_address = moved.to;
        }

        // 4. Insert new bases
        for base in &delta.new_bases {
            self.insert_base(base.clone());
        }

        // 5. Update modified bases (insert_base overwrites by name)
        for base in &delta.modified_bases {
            self.insert_base(base.clone());
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// Helper: build a minimal SaveRoot JSON and parse it.
    fn minimal_save() -> SaveRoot {
        let json = r#"{
            "Version": 4720,
            "Platform": "Mac|Final",
            "ActiveContext": "Main",
            "CommonStateData": {"SaveName": "Test", "TotalPlayTime": 100},
            "BaseContext": {
                "GameMode": 1,
                "PlayerStateData": {
                    "UniverseAddress": {"RealityIndex": 0, "GalacticAddress": {"VoxelX": 100, "VoxelY": 50, "VoxelZ": -200, "SolarSystemIndex": 42, "PlanetIndex": 0}},
                    "Units": 1000000, "Nanites": 5000, "Specials": 200,
                    "PersistentPlayerBases": [
                        {
                            "BaseVersion": 8, "GalacticAddress": "0x050003AB8C07",
                            "Position": [0.0, 0.0, 0.0], "Forward": [1.0, 0.0, 0.0],
                            "LastUpdateTimestamp": 1700000000, "Objects": [], "RID": "",
                            "Owner": {"LID": "", "UID": "123", "USN": "Test", "PTK": "ST", "TS": 0},
                            "Name": "Home Base",
                            "BaseType": {"PersistentBaseTypes": "HomePlanetBase"},
                            "LastEditedById": "", "LastEditedByUsername": ""
                        }
                    ]
                }
            },
            "ExpeditionContext": {
                "GameMode": 6,
                "PlayerStateData": {
                    "UniverseAddress": {"RealityIndex": 0, "GalacticAddress": {"VoxelX": 0, "VoxelY": 0, "VoxelZ": 0, "SolarSystemIndex": 0, "PlanetIndex": 0}},
                    "Units": 0, "Nanites": 0, "Specials": 0,
                    "PersistentPlayerBases": []
                }
            },
            "DiscoveryManagerData": {
                "DiscoveryData-v1": {
                    "ReserveStore": 100, "ReserveManaged": 100,
                    "Store": {
                        "Record": [
                            {"DD": {"UA": "0x002A32F38064", "DT": "SolarSystem", "VP": ["0xAAAA"]}, "DM": {}, "OWS": {"LID": "", "UID": "1", "USN": "Explorer", "PTK": "ST", "TS": 1700000000}, "FL": {"U": 1}},
                            {"DD": {"UA": "0x050003AB8C07", "DT": "SolarSystem", "VP": ["0xABCD"]}, "DM": {}, "OWS": {"LID": "", "UID": "1", "USN": "Explorer", "PTK": "ST", "TS": 1700000000}, "FL": {"U": 1}},
                            {"DD": {"UA": "0x150003AB8C07", "DT": "Planet", "VP": ["0xDEAD", 0]}, "DM": {}, "OWS": {"LID": "", "UID": "1", "USN": "Explorer", "PTK": "ST", "TS": 1700000000}, "FL": {"U": 1}},
                            {"DD": {"UA": "0x0A0002001234", "DT": "SolarSystem", "VP": ["0x1234"]}, "DM": {}, "OWS": {"LID": "", "UID": "1", "USN": "Explorer", "PTK": "ST", "TS": 1700000000}, "FL": {"U": 1}}
                        ]
                    }
                }
            }
        }"#;
        nms_save::parse_save(json.as_bytes()).unwrap()
    }

    #[test]
    fn test_from_save_basic_counts() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        // 3 systems: player's system discovery + 2 others
        assert_eq!(model.system_count(), 3);
        assert_eq!(model.planet_count(), 1);
        assert_eq!(model.base_count(), 1);
    }

    #[test]
    fn test_from_save_base_lookup() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        let base = model.base("Home Base").unwrap();
        assert_eq!(base.name, "Home Base");
    }

    #[test]
    fn test_from_save_base_lookup_case_insensitive() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        assert!(model.base("home base").is_some());
        assert!(model.base("HOME BASE").is_some());
    }

    #[test]
    fn test_from_save_player_position() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        let pos = model.player_position().unwrap();
        assert_eq!(pos.voxel_x(), 100);
        assert_eq!(pos.voxel_y(), 50);
        assert_eq!(pos.voxel_z(), -200);
    }

    #[test]
    fn test_from_save_spatial_index_populated() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        // 2 from discovery + 1 sentinel
        assert_eq!(model.spatial_size(), 3);
    }

    #[test]
    fn test_from_save_graph_nodes() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        // 2 from discovery + 1 sentinel
        assert_eq!(model.graph.node_count(), 3);
    }

    #[test]
    fn test_from_save_biome_index() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        let lush = model.planets_by_biome(Biome::Lush);
        assert_eq!(lush.len(), 1);
    }

    #[test]
    fn test_from_save_biome_index_empty() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        let toxic = model.planets_by_biome(Biome::Toxic);
        assert!(toxic.is_empty());
    }

    #[test]
    fn test_insert_system_adds_to_all_indexes() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let count_before = model.system_count();

        let addr = GalacticAddress::new(500, 10, -300, 0x999, 0, 0);
        let system = System::new(
            addr,
            Some("New System".to_string()),
            None,
            None,
            vec![Planet::new(0, Some(Biome::Lava), None, false, None, None)],
        );
        model.insert_system(system);

        assert_eq!(model.system_count(), count_before + 1);
        assert!(model.system_by_name("New System").is_some());
        assert_eq!(model.spatial_size(), count_before + 1);
        assert_eq!(model.graph.node_count(), count_before + 1);
        assert_eq!(model.planets_by_biome(Biome::Lava).len(), 1);
    }

    #[test]
    fn test_insert_duplicate_system_is_noop() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let count_before = model.system_count();

        // Insert a system with the same address as an existing one
        let existing_id = *model.systems.keys().next().unwrap();
        let existing = model.systems.get(&existing_id).unwrap().clone();
        model.insert_system(existing);

        assert_eq!(model.system_count(), count_before);
    }

    #[test]
    fn test_system_not_found_returns_none() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        assert!(model.system(&SystemId(0xDEADBEEF)).is_none());
    }

    #[test]
    fn test_system_by_name_not_found() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        assert!(model.system_by_name("No Such System").is_none());
    }

    #[test]
    fn test_base_not_found() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        assert!(model.base("No Such Base").is_none());
    }

    #[test]
    fn test_from_save_address_to_id() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        // Every system should have an address_to_id entry
        for &sys_id in model.systems.keys() {
            assert!(model.address_to_id.contains_key(&sys_id.0));
        }
    }

    #[test]
    fn test_from_save_node_map() {
        let save = minimal_save();
        let model = GalaxyModel::from_save(&save);
        // Every system should have a node_map entry
        for &sys_id in model.systems.keys() {
            assert!(model.node_map.contains_key(&sys_id));
        }
    }

    #[test]
    fn test_apply_delta_empty_is_noop() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let sys_count = model.system_count();
        let planet_count = model.planet_count();
        let base_count = model.base_count();

        model.apply_delta(&nms_core::delta::SaveDelta::empty());

        assert_eq!(model.system_count(), sys_count);
        assert_eq!(model.planet_count(), planet_count);
        assert_eq!(model.base_count(), base_count);
    }

    #[test]
    fn test_apply_delta_new_system() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let count_before = model.system_count();

        let delta = nms_core::delta::SaveDelta {
            new_systems: vec![System::new(
                GalacticAddress::new(500, 10, -300, 0x999, 0, 0),
                Some("Delta System".into()),
                None,
                None,
                vec![Planet::new(0, Some(Biome::Lava), None, false, None, None)],
            )],
            ..nms_core::delta::SaveDelta::empty()
        };

        model.apply_delta(&delta);
        assert_eq!(model.system_count(), count_before + 1);
        assert!(model.system_by_name("Delta System").is_some());
    }

    #[test]
    fn test_apply_delta_player_moved() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let old_pos = *model.player_position().unwrap();
        let new_addr = GalacticAddress::new(999, 0, 0, 1, 0, 0);

        let delta = nms_core::delta::SaveDelta {
            player_moved: Some(nms_core::delta::PlayerMoved {
                from: old_pos,
                to: new_addr,
            }),
            ..nms_core::delta::SaveDelta::empty()
        };

        model.apply_delta(&delta);
        assert_eq!(model.player_position().unwrap().voxel_x(), 999);
    }

    #[test]
    fn test_apply_delta_new_base() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let base_count_before = model.base_count();

        let addr = GalacticAddress::new(100, 50, -200, 42, 0, 0);
        let base = nms_core::player::PlayerBase::new(
            "Delta Base".into(),
            nms_core::player::BaseType::HomePlanetBase,
            addr,
            [0.0, 0.0, 0.0],
            None,
        );

        let delta = nms_core::delta::SaveDelta {
            new_bases: vec![base],
            ..nms_core::delta::SaveDelta::empty()
        };

        model.apply_delta(&delta);
        assert_eq!(model.base_count(), base_count_before + 1);
        assert!(model.base("Delta Base").is_some());
    }

    #[test]
    fn test_apply_delta_new_planet_to_existing_system() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let planet_count_before = model.planet_count();

        let sys_id = *model.systems.keys().next().unwrap();
        let planet = Planet::new(7, Some(Biome::Frozen), None, false, None, None);

        let delta = nms_core::delta::SaveDelta {
            new_planets: vec![(sys_id, planet)],
            ..nms_core::delta::SaveDelta::empty()
        };

        model.apply_delta(&delta);
        assert_eq!(model.planet_count(), planet_count_before + 1);
        assert_eq!(model.planets_by_biome(Biome::Frozen).len(), 1);
    }

    #[test]
    fn test_insert_system_unnamed() {
        let save = minimal_save();
        let mut model = GalaxyModel::from_save(&save);
        let name_count_before = model.name_index.len();

        let addr = GalacticAddress::new(600, 20, -400, 0xAAA, 0, 0);
        let system = System::new(addr, None, None, None, vec![]);
        model.insert_system(system);

        // No new name index entry for unnamed system
        assert_eq!(model.name_index.len(), name_count_before);
    }

    // -- Multi-galaxy spatial tests (milestone 7.4) --

    #[test]
    fn test_active_galaxy_defaults_to_zero() {
        let model = GalaxyModel::new();
        assert_eq!(model.active_galaxy, 0);
    }

    #[test]
    fn test_set_active_galaxy() {
        let mut model = GalaxyModel::new();
        model.set_active_galaxy(9);
        assert_eq!(model.active_galaxy, 9);
    }

    #[test]
    fn test_active_spatial_empty_model_returns_none() {
        let model = GalaxyModel::new();
        assert!(model.active_spatial().is_none());
    }

    #[test]
    fn test_spatial_for_unknown_galaxy_returns_none() {
        let model = GalaxyModel::new();
        assert!(model.spatial_for(42).is_none());
    }

    #[test]
    fn test_discovered_galaxies_empty() {
        let model = GalaxyModel::new();
        assert!(model.discovered_galaxies().is_empty());
    }

    #[test]
    fn test_insert_system_separate_galaxies() {
        let mut model = GalaxyModel::new();

        // Euclid (galaxy 0)
        let addr0 = GalacticAddress::new(10, 0, 0, 0x100, 0, 0);
        let sys0 = System::new(addr0, Some("Euclid Sys".into()), None, None, vec![]);
        model.insert_system(sys0);

        // Eissentam (galaxy 9)
        let addr9 = GalacticAddress::new(20, 0, 0, 0x200, 0, 9);
        let sys9 = System::new(addr9, Some("Eissentam Sys".into()), None, None, vec![]);
        model.insert_system(sys9);

        assert_eq!(model.system_count(), 2);
        assert_eq!(model.spatial_size(), 2);

        // Galaxy 0 has 1 point
        let tree0 = model.spatial_for(0).unwrap();
        assert_eq!(tree0.size(), 1);

        // Galaxy 9 has 1 point
        let tree9 = model.spatial_for(9).unwrap();
        assert_eq!(tree9.size(), 1);

        // No galaxy 5
        assert!(model.spatial_for(5).is_none());
    }

    #[test]
    fn test_discovered_galaxies_sorted() {
        let mut model = GalaxyModel::new();

        let addr9 = GalacticAddress::new(0, 0, 0, 0x100, 0, 9);
        model.insert_system(System::new(addr9, None, None, None, vec![]));

        let addr0 = GalacticAddress::new(0, 0, 0, 0x200, 0, 0);
        model.insert_system(System::new(addr0, None, None, None, vec![]));

        let addr2 = GalacticAddress::new(0, 0, 0, 0x300, 0, 2);
        model.insert_system(System::new(addr2, None, None, None, vec![]));

        let galaxies = model.discovered_galaxies();
        assert_eq!(galaxies, vec![0, 2, 9]);
    }

    #[test]
    fn test_rebuild_spatial() {
        let mut model = GalaxyModel::new();

        let addr0 = GalacticAddress::new(10, 0, 0, 0x100, 0, 0);
        model.insert_system(System::new(addr0, None, None, None, vec![]));

        let addr9 = GalacticAddress::new(20, 0, 0, 0x200, 0, 9);
        model.insert_system(System::new(addr9, None, None, None, vec![]));

        // Clear spatial and rebuild
        model.spatial.clear();
        assert_eq!(model.spatial_size(), 0);

        model.rebuild_spatial();
        assert_eq!(model.spatial_size(), 2);
        assert_eq!(model.spatial_for(0).unwrap().size(), 1);
        assert_eq!(model.spatial_for(9).unwrap().size(), 1);
    }

    #[test]
    fn test_active_spatial_returns_correct_tree() {
        let mut model = GalaxyModel::new();

        let addr0 = GalacticAddress::new(10, 0, 0, 0x100, 0, 0);
        model.insert_system(System::new(addr0, Some("E1".into()), None, None, vec![]));

        let addr9 = GalacticAddress::new(20, 0, 0, 0x200, 0, 9);
        model.insert_system(System::new(addr9, Some("E2".into()), None, None, vec![]));

        // Default active galaxy is 0
        assert_eq!(model.active_spatial().unwrap().size(), 1);

        model.set_active_galaxy(9);
        assert_eq!(model.active_spatial().unwrap().size(), 1);

        model.set_active_galaxy(42);
        assert!(model.active_spatial().is_none());
    }

    #[test]
    fn test_player_system_distance_zero() {
        // Player is at (100, 50, -200, SSI=42); multi_system_save has a
        // matching SolarSystem discovery record at UA 0x002A32F38064.
        let json = std::fs::read_to_string("../../data/test/multi_system_save.json").unwrap();
        let save = nms_save::parse_save(json.as_bytes()).unwrap();
        let model = GalaxyModel::from_save(&save);

        let player_pos = model.player_position().unwrap();
        assert_eq!(player_pos.voxel_x(), 100);
        assert_eq!(player_pos.voxel_y(), 50);
        assert_eq!(player_pos.voxel_z(), -200);
        assert_eq!(player_pos.solar_system_index(), 42);

        // The nearest system should be the player's own system at distance 0.
        let nearest = model.nearest_systems(player_pos, 1);
        assert!(
            !nearest.is_empty(),
            "Expected at least one system near player"
        );
        let (_, distance) = &nearest[0];
        assert_eq!(
            *distance, 0.0,
            "Player's own system should be at distance 0.0, got {distance}"
        );
    }

    #[test]
    fn test_ensure_player_system_inserts_sentinel() {
        // Build a model where the player's system has no discovery record.
        let json = r#"{
            "Version": 4720, "Platform": "Mac|Final", "ActiveContext": "Main",
            "CommonStateData": {"SaveName": "Test", "TotalPlayTime": 100},
            "BaseContext": {"GameMode": 1, "PlayerStateData": {"UniverseAddress": {"RealityIndex": 0, "GalacticAddress": {"VoxelX": 999, "VoxelY": 10, "VoxelZ": -500, "SolarSystemIndex": 77, "PlanetIndex": 0}}, "Units": 0, "Nanites": 0, "Specials": 0, "PersistentPlayerBases": []}},
            "ExpeditionContext": {"GameMode": 6, "PlayerStateData": {"UniverseAddress": {"RealityIndex": 0, "GalacticAddress": {"VoxelX": 0, "VoxelY": 0, "VoxelZ": 0, "SolarSystemIndex": 0, "PlanetIndex": 0}}, "Units": 0, "Nanites": 0, "Specials": 0, "PersistentPlayerBases": []}},
            "DiscoveryManagerData": {"DiscoveryData-v1": {"ReserveStore": 0, "ReserveManaged": 0, "Store": {"Record": []}}}
        }"#;
        let save = nms_save::parse_save(json.as_bytes()).unwrap();
        let mut model = GalaxyModel::from_save(&save);

        let player_pos = *model.player_position().unwrap();
        let player_sys_id = SystemId::from_address(&player_pos);
        assert!(model.system(&player_sys_id).is_none());

        model.ensure_player_system();
        assert!(model.system(&player_sys_id).is_some());

        let nearest = model.nearest_systems(&player_pos, 1);
        assert!(!nearest.is_empty());
        assert_eq!(nearest[0].1, 0.0);
    }
}