nmbrs-runtime 0.3.0

Workload execution runtime for nmbrs
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
// Copyright 2024-2026 Jonathan Shook
// SPDX-License-Identifier: Apache-2.0

//! Typed binding scope model for Polydat Kernel compilation.
//!
//! A `BindingScope` is the structured intermediate representation
//! that replaces raw string manipulation for scope composition.
//! Every binding carries its provenance (`BindingOrigin`), its
//! modifier, and its definition text. Scope rules are checked
//! against this typed structure, and a single deduplicated GK
//! source string is emitted at the end.

use std::collections::{HashMap, HashSet};

use crate::scope_synth::{
    collect_leaf_placeholders, value_to_param_string, workload_param_type_name,
};
use nmbrs_workload::model::{BindingsDef, ParsedOp};
use polydat::kernel::interp::collect_string_interp_refs;

/// Where a binding was declared — its provenance in the scope chain.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum BindingOrigin {
    /// Declared at a YAML level outside the op (today only block
    /// sugar, since SRD-13f Push D retired the workload/phase
    /// parser-merge into ops). Reaches the op via
    /// `inline_block_sugar_into_op` during YAML parsing.
    Inherited,
    /// Declared at phase level (the phase has its own `bindings:` block).
    Phase,
    /// Declared at op level (op-specific augmentation).
    Op(String),
    /// Injected as a `for_each` iteration variable.
    IterationVar,
    /// Generated as an `extern` from the outer scope manifest.
    AutoExtern,
    /// Injected from workload param expansion.
    ParamExpansion,
    /// Generated from inline expression extraction (`{{expr}}`).
    InlineExpr,
}

impl std::fmt::Display for BindingOrigin {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Inherited => write!(f, "inherited"),
            Self::Phase => write!(f, "phase"),
            Self::Op(name) => write!(f, "op '{name}'"),
            Self::IterationVar => write!(f, "iteration variable"),
            Self::AutoExtern => write!(f, "auto-extern"),
            Self::ParamExpansion => write!(f, "param expansion"),
            Self::InlineExpr => write!(f, "inline expression"),
        }
    }
}

/// The modifier on a binding declaration. Mirrors the
/// `BindingModifier` flag set in polydat' Polydat AST plus
/// the binding-kind keywords (`init`, `cursor`) that
/// nmbrs-runtime's text-level scope assembly cares about.
///
/// Wire-coloring modifiers (`final`, `shared`, `volatile`)
/// could in principle combine, but the scope assembly path
/// historically only needs to know "is this final?" /
/// "is this shared?" for shadow checks; combinations get
/// reduced here to the most-distinctive single tag. The full
/// flag set is preserved in the eventual Polydat AST when the
/// scope-emitted source compiles.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum ScopeModifier {
    None,
    Init,
    Shared,
    Final,
    Volatile,
    Cursor,
}

/// A single binding declaration with provenance.
#[derive(Debug, Clone)]
pub struct ScopedBinding {
    /// The binding name (LHS of `:=`).
    pub name: String,
    /// The full declaration line as Polydat source text.
    /// For regular bindings: `"name := expr"`
    /// For init: `"const name := \"value\""`
    /// For externs: `"extern name: Type"`
    pub line: String,
    /// Where this binding came from.
    pub origin: BindingOrigin,
    /// Modifier on the declaration.
    pub modifier: ScopeModifier,
}

/// A typed extern declaration.
#[derive(Debug, Clone)]
pub struct ExternDecl {
    pub name: String,
    pub type_name: String,
}

/// Typed scope for a phase's Polydat Kernel compilation.
///
/// Built by the executor from structured inputs, validated for
/// scope rules, then emitted as a single Polydat source string.
pub struct BindingScope {
    /// The coordinate declaration (e.g., `"input cycle: u64"`).
    coordinates: Option<String>,
    /// All bindings in insertion order.
    bindings: Vec<ScopedBinding>,
    /// Extern declarations.
    externs: Vec<ExternDecl>,
    /// Names referenced by op templates (for DCE).
    required_outputs: Vec<String>,
    /// Extra required outputs from config expressions.
    config_refs: Vec<String>,
}

impl Default for BindingScope {
    fn default() -> Self {
        Self::new()
    }
}

impl BindingScope {
    /// Create an empty scope.
    pub fn new() -> Self {
        Self {
            coordinates: None,
            bindings: Vec::new(),
            externs: Vec::new(),
            required_outputs: Vec::new(),
            config_refs: Vec::new(),
        }
    }

    /// Ingest bindings from a `BindingsDef::PolydatSource`, classifying each
    /// line by the given origin. Extracts coordinates and handles all
    /// Polydat declaration forms (init, shared, final, cursor, extern, plain).
    ///
    /// A "line" here is a *logical* line: physical newlines inside
    /// unbalanced `()`/`[]`/`{}` or inside a string literal are
    /// absorbed into the current binding. This is what lets multi-line
    /// expressions like
    ///
    /// ```polydat
    /// rate_adjust := control_set("rate",
    ///                            to_f64(control_u64("rate")) * 1.05)
    /// ```
    ///
    /// survive the later split-on-`\n` in [`Self::emit`]: we rejoin
    /// them onto one physical line so the downstream parser sees a
    /// complete expression.
    pub fn ingest_polydat_source(&mut self, source: &str, origin: BindingOrigin) {
        for line in logical_lines(source) {
            let trimmed = line.trim();
            if trimmed.is_empty() || trimmed.starts_with("//") || trimmed.starts_with('#') {
                continue;
            }

            // `input` declarations: `input <name>[: <type>]` (bare) or
            // `input (<name>[: <type>], ...)` (tuple). Stored verbatim
            // on the scope's `coordinates` slot — the synthesizer
            // re-emits this line into the per-scope Polydat source so the
            // compiler can pick up the declared inputs.
            if trimmed.starts_with("input ") {
                self.coordinates = Some(trimmed.to_string());
                continue;
            }

            // Cursor declarations use `=` not `:=`:
            //   cursor row = range(0, vector_count("example"))
            //   const prebuffer := dataset_prebuffer("example")
            // These are Polydat statements that the compiler handles directly.
            // Pass them through as bindings so they survive emission.
            if (trimmed.starts_with("cursor ") || trimmed.starts_with("init "))
                && let Some(eq_pos) = trimmed.find('=')
            {
                // Check it's `=` not `:=`
                let before_eq = &trimmed[..eq_pos];
                if !before_eq.ends_with(':') {
                    // cursor/init with bare `=` — pass through as-is
                    let lhs = before_eq.trim();
                    let (modifier, name) = parse_modifier_and_name(lhs);
                    self.bindings.push(ScopedBinding {
                        name: name.to_string(),
                        line: trimmed.to_string(),
                        origin: origin.clone(),
                        modifier,
                    });
                    continue;
                }
            }

            if let Some(pos) = trimmed.find(":=") {
                let lhs = trimmed[..pos].trim();

                // Extern declarations
                if lhs.starts_with("extern") {
                    // Already handled via add_extern; skip inline externs
                    // from inherited sources
                    continue;
                }

                // Determine modifier and extract bare name
                let (modifier, name) = parse_modifier_and_name(lhs);

                self.bindings.push(ScopedBinding {
                    name: name.to_string(),
                    line: trimmed.to_string(),
                    origin: origin.clone(),
                    modifier,
                });
            } else if trimmed.starts_with("extern ") {
                // `extern name: Type` (no `:=`)
                if let Some(colon_pos) = trimmed.find(':') {
                    let name = trimmed["extern ".len()..colon_pos].trim();
                    let type_name = trimmed[colon_pos + 1..].trim();
                    self.externs.push(ExternDecl {
                        name: name.to_string(),
                        type_name: type_name.to_string(),
                    });
                }
            }
            // Lines that don't match any pattern are silently skipped.
            // Comments and blank lines are already filtered above.
        }
    }

    /// Add an iteration variable from `for_each`.
    ///
    /// Iteration variables are declared as `extern` ports rather
    /// than init-time bindings (SRD 18b §"Iteration variables as
    /// scope outputs"). The runtime sets the extern's value
    /// before the leaf kernel executes, so we no longer
    /// text-substitute literal values into the Polydat source. The
    /// type is inferred from the current iteration's value:
    /// numeric strings get `u64`/`f64`, anything else is `String`.
    pub fn add_iteration_var(&mut self, name: &str, value: &str) {
        let type_name = if value.parse::<u64>().is_ok() {
            "u64"
        } else if value.parse::<f64>().is_ok() {
            "f64"
        } else {
            "String"
        };
        self.externs.push(ExternDecl {
            name: name.to_string(),
            type_name: type_name.to_string(),
        });
    }

    /// Add an auto-extern declaration from the outer scope manifest.
    pub fn add_extern(&mut self, name: &str, type_name: &str) {
        self.externs.push(ExternDecl {
            name: name.to_string(),
            type_name: type_name.to_string(),
        });
    }

    /// Add a workload param binding as a `final` (compile-time
    /// constant) binding so the compiler folds the literal value
    /// and the assembler treats references as const args rather
    /// than wire inputs. The `const` modifier matches the M3.6
    /// contract: workload params are immutable for the run, so
    /// downstream nodes consume them as constants.
    ///
    /// String values are emitted as quoted Polydat string literals
    /// with embedded `"` and `\` escaped, so JSON-shaped param
    /// values (`{"a": 1}`, `{'class': 'SimpleStrategy'}`,
    /// arbitrary nested quotes) round-trip through GK
    /// compilation unchanged. Numeric and boolean values are
    /// emitted as bare literals.
    pub fn add_param_binding(&mut self, name: &str, value: &str) {
        // Param-binding emission used by scope synth when
        // cascading workload-root values into descendant
        // scopes. Values arrive already-typed (raw workload-
        // param text OR `value_to_param_string` output from a
        // parent kernel constant). Workload-root semantics
        // apply: bare strings lower to polydat string literals
        // (legacy), NOT references. The `set:` block parser
        // in nmbrs-workload uses a DIFFERENT classifier that
        // does treat bare identifiers as references — that's
        // the entry point where the operator IS in a scope
        // context with visible wires to reference.
        let trimmed = value.trim();
        // A bare numeric/bool literal, or an already-quoted polydat
        // string / array literal, passes through verbatim; anything else
        // is wrapped as a quoted polydat string. (Both pass-through cases
        // yield the same text, so they share one arm.)
        let literal = if trimmed.parse::<u64>().is_ok()
            || trimmed.parse::<f64>().is_ok()
            || trimmed == "true"
            || trimmed == "false"
            || is_polydat_quoted_string(trimmed)
            || is_polydat_array_literal(trimmed)
        {
            trimmed.to_string()
        } else {
            let escaped = value.replace('\\', "\\\\").replace('"', "\\\"");
            format!("\"{escaped}\"")
        };
        self.bindings.push(ScopedBinding {
            name: name.to_string(),
            line: format!("const {name} := {literal}"),
            origin: BindingOrigin::ParamExpansion,
            modifier: ScopeModifier::Final,
        });
    }

    /// Add an inline expression binding.
    pub fn add_inline_expr(&mut self, name: &str, expr: &str) {
        self.bindings.push(ScopedBinding {
            name: name.to_string(),
            line: format!("{name} := {expr}"),
            origin: BindingOrigin::InlineExpr,
            modifier: ScopeModifier::None,
        });
    }

    /// Register a name referenced by an op template (for DCE).
    pub fn add_required_output(&mut self, name: &str) {
        if !self.required_outputs.contains(&name.to_string()) {
            self.required_outputs.push(name.to_string());
        }
    }

    /// Register a config expression reference (for DCE).
    pub fn add_config_ref(&mut self, name: &str) {
        if !self.config_refs.contains(&name.to_string()) {
            self.config_refs.push(name.to_string());
        }
    }

    /// All names defined in this scope (all origins).
    pub fn defined_names(&self) -> HashSet<String> {
        self.bindings.iter().map(|b| b.name.clone()).collect()
    }

    /// All extern names in this scope.
    pub fn extern_names(&self) -> HashSet<String> {
        self.externs.iter().map(|e| e.name.clone()).collect()
    }

    /// The combined required outputs (template refs + config refs).
    pub fn required_outputs(&self) -> Vec<String> {
        let mut all = self.required_outputs.clone();
        for name in &self.config_refs {
            if !all.contains(name) {
                all.push(name.clone());
            }
        }
        all
    }

    /// Validate scope rules. Returns `Ok(())` if valid, or a
    /// descriptive error explaining the violation and its provenance.
    pub fn validate(&self) -> Result<(), String> {
        // Build a map of name → first binding for each origin tier.
        // The tier order determines precedence: earlier tiers own the name.
        let mut owned: HashMap<String, &ScopedBinding> = HashMap::new();

        for binding in &self.bindings {
            if let Some(prior) = owned.get(&binding.name) {
                // Same name appears twice. Check if this is allowed.
                match (&prior.origin, &binding.origin) {
                    // Inherited + Inherited: duplicate from multiple ops
                    // sharing the same workload bindings. Allowed if
                    // definitions are identical.
                    (BindingOrigin::Inherited, BindingOrigin::Inherited) => {
                        if prior.line != binding.line {
                            return Err(format!(
                                "binding '{}' has conflicting inherited definitions:\n  \
                                 first:  {}\n  second: {}",
                                binding.name, prior.line, binding.line
                            ));
                        }
                        // Duplicate with same definition — will be deduplicated at emit
                    }

                    // Phase + Phase: same check as inherited
                    (BindingOrigin::Phase, BindingOrigin::Phase) => {
                        if prior.line != binding.line {
                            return Err(format!(
                                "binding '{}' has conflicting phase-level definitions:\n  \
                                 first:  {}\n  second: {}",
                                binding.name, prior.line, binding.line
                            ));
                        }
                    }

                    // Op overriding Inherited/Phase/IterationVar with a
                    // DIFFERENT definition: real shadow, error.
                    (
                        BindingOrigin::Inherited
                        | BindingOrigin::Phase
                        | BindingOrigin::IterationVar,
                        BindingOrigin::Op(op_name),
                    ) => {
                        if prior.line != binding.line {
                            return Err(format!(
                                "op '{}' binding '{}' shadows a name from {} origin \
                                 with a different definition.\n  \
                                 scope: {}\n  op:    {}\n\
                                 Ops augment the scope DAG but cannot override it. \
                                 Use a separate phase for different bindings.",
                                op_name, binding.name, prior.origin, prior.line, binding.line
                            ));
                        }
                        // Same definition from inheritance — dedup at emit
                    }

                    // Op redefining an op binding from a DIFFERENT op
                    (BindingOrigin::Op(prior_op), BindingOrigin::Op(this_op)) => {
                        if prior_op != this_op {
                            return Err(format!(
                                "op '{}' binding '{}' is already defined by op '{}'. \
                                 Each ride-along binding name must be unique across \
                                 all ops in the scope.",
                                this_op, binding.name, prior_op
                            ));
                        }
                        // Same op, same name — shouldn't happen, but tolerate if same def
                    }

                    // IterationVar replacing Inherited/Phase: iteration
                    // variables are injected before inherited bindings
                    // in the emission order, so Polydat sees them first.
                    // This is intentional — for_each vars override params.
                    (
                        BindingOrigin::IterationVar,
                        BindingOrigin::Inherited | BindingOrigin::Phase,
                    )
                    | (
                        BindingOrigin::Inherited | BindingOrigin::Phase,
                        BindingOrigin::IterationVar,
                    ) => {
                        // Allowed: iteration vars intentionally override inherited names
                    }

                    // ParamExpansion: these are only added when the name
                    // is NOT already defined. The caller checks. But if
                    // somehow a duplicate appears, same-def is fine.
                    (_, BindingOrigin::ParamExpansion) | (BindingOrigin::ParamExpansion, _) => {
                        // Param expansion is additive; caller skips existing names
                    }

                    // InlineExpr: synthetic names (__expr_N), shouldn't collide
                    (_, BindingOrigin::InlineExpr) | (BindingOrigin::InlineExpr, _) => {
                        // Synthetic names from inline expressions
                    }

                    // AutoExtern: these go to the extern list, not bindings.
                    // Shouldn't appear here, but tolerate.
                    (_, BindingOrigin::AutoExtern) | (BindingOrigin::AutoExtern, _) => {}

                    // Inherited + Op(same def): already covered above.
                    // Any other combination: flag it.
                    _ => {
                        if prior.line != binding.line {
                            return Err(format!(
                                "binding '{}' conflicts: {} origin ({}) vs {} origin ({})",
                                binding.name,
                                prior.origin,
                                prior.line,
                                binding.origin,
                                binding.line
                            ));
                        }
                    }
                }
            } else {
                owned.insert(binding.name.clone(), binding);
            }
        }

        // Check final shadowing: no binding can redefine a name that
        // appears as Final in the extern list or prior bindings.
        let final_names: HashSet<String> = self
            .bindings
            .iter()
            .filter(|b| b.modifier == ScopeModifier::Final)
            .map(|b| b.name.clone())
            .collect();

        for binding in &self.bindings {
            if final_names.contains(&binding.name)
                && binding.modifier != ScopeModifier::Final
                && binding.origin != BindingOrigin::Inherited
            {
                return Err(format!(
                    "cannot shadow 'final' binding '{}' from outer scope",
                    binding.name
                ));
            }
        }

        Ok(())
    }

    /// Emit the validated scope as a single Polydat source string.
    ///
    /// Entries are ordered:
    /// 1. Coordinates declaration
    /// 2. Extern declarations
    /// 3. Init declarations (iteration variables)
    /// 4. Inherited/Phase bindings (deduplicated by name)
    /// 5. ParamExpansion bindings
    /// 6. InlineExpr bindings
    /// 7. Op-level bindings (new names only)
    ///
    /// Each name is emitted exactly once. The first occurrence wins;
    /// subsequent duplicates with the same definition are suppressed.
    pub fn emit(&self) -> String {
        let mut lines: Vec<String> = Vec::new();
        let mut emitted_names: HashSet<String> = HashSet::new();

        // 1. Coordinates — emit only when an ingested source
        // declared them. The Polydat compiler auto-infers coordinates
        // from `cycle` references in non-strict mode, so a
        // workload-level scope built purely from injected
        // workload params (no op-supplied Polydat source, no `cycle`
        // references) compiles fine without a synthetic line.
        if let Some(ref coords) = self.coordinates {
            lines.push(coords.clone());
            // Populate `emitted_names` from the declared coordinate
            // names so the externs pass (and downstream binding
            // emission) doesn't re-introduce a same-named declaration
            // that would collide with the input slot. The coord line
            // is the canonical `input` declaration in either
            // surface form:
            //   input <name>[: <type>]               (bare)
            //   input (<name>[: <type>], ...)        (tuple)
            scan_input_decl_names(coords.trim(), &mut emitted_names);
        }

        // 2. Externs
        for ext in &self.externs {
            if !emitted_names.contains(&ext.name) {
                lines.push(format!("extern {}: {}", ext.name, ext.type_name));
                emitted_names.insert(ext.name.clone());
            }
        }

        // 3-7. Bindings in origin order
        let origin_order: &[fn(&BindingOrigin) -> bool] = &[
            |o| matches!(o, BindingOrigin::IterationVar),
            |o| matches!(o, BindingOrigin::Inherited),
            |o| matches!(o, BindingOrigin::Phase),
            |o| matches!(o, BindingOrigin::ParamExpansion),
            |o| matches!(o, BindingOrigin::InlineExpr),
            |o| matches!(o, BindingOrigin::Op(_)),
        ];

        for predicate in origin_order {
            for binding in &self.bindings {
                if predicate(&binding.origin) && !emitted_names.contains(&binding.name) {
                    lines.push(binding.line.clone());
                    emitted_names.insert(binding.name.clone());
                }
            }
        }

        lines.join("\n")
    }
}

/// Parse the modifier prefix and bare name from a Polydat LHS.
///
/// `"shared foo"` → `(Shared, "foo")`
/// `"init bar"` → `(Init, "bar")`
/// `"cursor baz"` → `(Cursor, "baz")`
/// `"final qux"` → `(Final, "qux")`
/// `"plain"` → `(None, "plain")`
/// Split `source` into logical lines, treating newlines inside
/// unbalanced `()`, `[]`, `{}` or string literals as continuations.
///
/// A logical line ends at the first physical newline that sits at
/// bracket-depth 0 and outside any string. Each returned String has
/// its interior newlines collapsed to single spaces so the downstream
/// Polydat parser sees one-expression-per-line, which is all it supports.
fn logical_lines(source: &str) -> Vec<String> {
    // Polydat grammar uses ONLY `"`-delimited string literals (see
    // `polydat/src/dsl/lexer.rs`). Apostrophes (`'`) carry
    // no special meaning at the lexical level — they appear
    // verbatim in comments ("the workload's bindings") and
    // inside double-quoted strings, never as a string delimiter
    // themselves. Treating `'` as a delimiter here would let a
    // stray apostrophe in a comment swallow the entire rest of
    // the source as a single unterminated "string" run, which
    // then collapses every subsequent binding into one logical
    // line that the per-line parser sees as a giant comment
    // and silently drops.
    //
    // Comments (`#`-to-EOL and `//`-to-EOL) are NOT skipped at
    // this level — physical newlines inside them terminate the
    // logical line uniformly, and the per-line `ingest_polydat_source`
    // pass skips any `#`/`//`-leading line via `trimmed.starts_with`.
    // What matters at this level is that bracket/string state
    // doesn't get confused by content inside comments.
    let mut out: Vec<String> = Vec::new();
    let mut buf = String::new();
    let mut depth: i32 = 0;
    let mut in_str = false;
    let mut in_line_comment = false;
    let mut chars = source.chars().peekable();
    while let Some(ch) = chars.next() {
        if in_line_comment {
            buf.push(ch);
            if ch == '\n' {
                in_line_comment = false;
                // Comments live at depth 0 by definition (they're
                // line-oriented); the newline always terminates
                // the logical line.
                if !buf.is_empty() {
                    out.push(std::mem::take(&mut buf));
                }
            }
            continue;
        }
        if in_str {
            buf.push(ch);
            if ch == '\\' {
                if let Some(nx) = chars.next() {
                    buf.push(nx);
                }
            } else if ch == '"' {
                in_str = false;
            }
            continue;
        }
        match ch {
            '"' => {
                in_str = true;
                buf.push(ch);
            }
            '#' => {
                // `#`-to-EOL comment — stop tracking bracket
                // depth and string state inside it so a stray
                // apostrophe or `(` in the comment doesn't
                // imbalance later real-code parsing.
                in_line_comment = true;
                buf.push(ch);
            }
            '/' if matches!(chars.peek(), Some('/')) => {
                // `//`-to-EOL comment, same treatment as `#`.
                in_line_comment = true;
                buf.push(ch);
            }
            '(' | '[' | '{' => {
                depth += 1;
                buf.push(ch);
            }
            ')' | ']' | '}' => {
                if depth > 0 {
                    depth -= 1;
                }
                buf.push(ch);
            }
            '\n' => {
                if depth > 0 {
                    buf.push(' ');
                } else {
                    out.push(std::mem::take(&mut buf));
                }
            }
            _ => buf.push(ch),
        }
    }
    if !buf.is_empty() {
        out.push(buf);
    }
    out
}

/// Format a `Value` as a natural-form string suitable for
/// passing to [`BindingScope::add_param_binding`]. `add_param_binding`
/// recognises u64/f64-shaped strings, the literals `true` / `false`,
/// and quotes everything else.
///
/// Returns `None` for value types that can't be represented as a
/// Polydat source literal (`Bytes`, `Json`, `Ext`, `Handle`, vectors,
/// `None`). The synthesizer falls back to extern cascade in
/// those cases, since promoted-final inlining only works when
/// the value can round-trip through source.
/// Parse an `input` declaration line and insert each declared
/// slot name into `out`. Accepts both surface forms:
///
/// - `input cycle: u64`       — bare single (with or without type)
/// - `input (a: u64, b: f64)` — tuple form
///
/// The leading `input ` keyword may be present or absent — the
/// scanner tolerates a coord line stored without the keyword (older
/// emit paths) by falling back to treating the body as the slot
/// list. Empty / unparseable input is a no-op.
pub(crate) fn scan_input_decl_names(line: &str, out: &mut HashSet<String>) {
    let body = line.trim().strip_prefix("input ").unwrap_or(line.trim());
    let body = body.trim();
    if let Some(inner) = body.strip_prefix('(').and_then(|s| s.strip_suffix(')')) {
        for part in inner.split(',') {
            let name = part.trim().split(':').next().unwrap_or("").trim();
            if !name.is_empty() {
                out.insert(name.to_string());
            }
        }
        return;
    }
    let name = body.split(':').next().unwrap_or("").trim();
    if !name.is_empty() {
        out.insert(name.to_string());
    }
}

/// Render an `input` declaration line for one or more slot names,
/// matching the two surface forms produced by the parser:
///
/// - one name           → `input <name>: u64\n`
/// - multiple names     → `input (<a>: u64, <b>: u64, ...)\n`
///
/// All slots default to `u64` here — the runtime emits these for
/// propagated parent inputs, which are already u64-typed today.
/// A future port-type-aware pass can plumb the parent's declared
/// type through if/when non-u64 inputs become common.
fn format_input_decl_line(names: &[String]) -> String {
    match names {
        [] => String::new(),
        [single] => format!("input {single}: u64\n"),
        many => {
            let typed: Vec<String> = many.iter().map(|n| format!("{n}: u64")).collect();
            format!("input ({})\n", typed.join(", "))
        }
    }
}

fn parse_modifier_and_name(lhs: &str) -> (ScopeModifier, &str) {
    // Strip every recognised modifier prefix before classifying;
    // multi-modifier forms like `volatile final` or `final shared`
    // only see a single ScopeModifier tag at the scope-assembly
    // level (the most-distinctive one wins), but the bare name
    // still gets extracted correctly. The eventual Polydat compile
    // sees the full source line with all keywords intact.
    let mut rest = lhs;
    let mut tag = ScopeModifier::None;
    loop {
        let prev = rest;
        if let Some(r) = rest.strip_prefix("shared ") {
            rest = r.trim();
            // `final` / `init` / `cursor` are more distinctive
            // than `shared` for shadow / kind checks; only set
            // tag if we don't already have a stronger one.
            if matches!(tag, ScopeModifier::None | ScopeModifier::Volatile) {
                tag = ScopeModifier::Shared;
            }
        } else if let Some(r) = rest.strip_prefix("const ") {
            // `const` is the current spelling of the Final tier
            // (init/final retired) — same tag as legacy `final`.
            rest = r.trim();
            tag = ScopeModifier::Final;
        } else if let Some(r) = rest.strip_prefix("final ") {
            rest = r.trim();
            tag = ScopeModifier::Final;
        } else if let Some(r) = rest.strip_prefix("volatile ") {
            rest = r.trim();
            if matches!(tag, ScopeModifier::None) {
                tag = ScopeModifier::Volatile;
            }
        } else if let Some(r) = rest.strip_prefix("init ") {
            rest = r.trim();
            tag = ScopeModifier::Init;
            break; // init is a kind-keyword; no modifiers come after it.
        } else if let Some(r) = rest.strip_prefix("cursor ") {
            rest = r.trim();
            tag = ScopeModifier::Cursor;
            break;
        }
        if rest == prev {
            break;
        }
    }
    (tag, rest)
}

// Build a `BindingScope` from phase ops and execution context.
//
// This is the main entry point that replaces the string mutation
// pipeline in the executor. It:
// 1. Classifies each op's bindings by origin (Inherited vs Op)
// 2. Adds iteration variables
// 3. Generates auto-externs from the outer manifest
// 4. Expands workload params
// 5. Extracts inline expressions
// 6. Collects required outputs from op templates
// =========================================================================
// For-each / comprehension scope kernel synthesis (M3.2)
// =========================================================================
//
// The for_each / for_combinations / for_each_union synthesizer
// lives in `polydat::iteration::comprehension::synthesis::synthesize_for_each_scope`.
// Callers in this crate go directly to that entry point; this
// module retains only the do-loop synthesizer below, since
// do_while / do_until aren't comprehensions.

/// Build the per-scope Polydat Kernel for a `do_while` / `do_until`
/// node (SRD 18b). Same composition contract as for_each
/// (every name visible at this scope resolves through standard
/// Polydat API on the synthesized kernel) — the difference is the
/// "scope output" is a `counter: u64` rather than tuple
/// iteration variables, and there's no value list to pre-eval.
///
/// Source shape:
///
/// ```text
///   extern <inherited_name>: <type>      # one per name
///                                        # referenced in
///                                        # `condition` text
///                                        # that exists in
///                                        # the parent
///                                        # manifest or
///                                        # workload params
///   final <inherited_param> := <literal> # workload-param
///                                        # injection (M3.3
///                                        # bridge until M3.6)
///   extern <counter>: u64                # only when counter
///                                        # is `Some`
/// ```
///
/// Per iteration the runtime sets `counter` (if present) via
/// `kernel.state().set_input` and evaluates the condition
/// expression against the kernel via `interpolate_via_kernel` +
/// `eval_const_expr`. Children inherit `counter` (and any
/// inherited names) through standard `materialize_wiring_from_outer`.
/// Synthesize the Polydat scope kernel for a phase that carries its own
/// `bindings:` block.
///
/// The phase scope owns this kernel as part of its closure lifetime
/// (per the Polydat builder/walk/instancing protocol): a phase whose YAML
/// declared `bindings: |` produces matter that the parent kernel's
/// builds a child scope from (`ScopeKernel::build_under`). Op-template
/// scopes that descend from this phase find these bindings as
/// outputs of their parent kernel and `extern` them through the
/// standard manifest cascade.
///
/// Phases without bindings AND without `for_each:` produce no install
/// spec — their scope-tree node carries an empty `cached_kernel` and
/// the parent walker resolves through to the nearest ancestor with a
/// kernel. The closure invariant ("every scope has a kernel
/// reference") still holds; the reference is just the parent's,
/// matter-gated as the Polydat APIs prescribe.
///
/// Source emitted (in order):
///
/// ```text
///   final <workload_param> := <literal>     # cascaded params
///   extern <ancestor_output>: <type>        # cascaded outputs/inputs
///   <phase_bindings_body>                   # phase-declared bindings
/// ```
///
/// The phase's bindings body is appended verbatim so the Polydat compiler
/// classifies them per the same rules as op-level bindings (init /
/// shared / final detection, type inference). Iteration coordinate
/// (`cycle`) cascades from the parent — we never re-declare it here.
/// Compose a phase scope's bindings source with SRD-75
/// phase-poll augmentation and/or phase-level `metrics:`
/// augmentation when applicable. Returns the existing
/// `BindingsDef` unchanged when the phase has neither `poll:`
/// nor `metrics:`; otherwise produces a
/// `BindingsDef::PolydatSource` that, for the poll case:
///
/// - **Prepends** `shared <name>: u64 := 0` for each
///   capture name declared by the phase's ops. The
///   shared-cell modifier means TraversingDispenser
///   writes via `ctx.wires.write` propagate to the
///   phase scope kernel (SRD-13c §"Implementation:
///   SharedCell-backed input slots" §4 "Write
///   through"); same cell is observable to other ops'
///   `if:` reads in the same iteration AND to the
///   `__poll_until` predicate evaluated on the phase
///   kernel.
/// - **Appends** the original `phase.bindings` body
///   verbatim (the author's bindings shadow synthesized
///   captures by ident if any name collides — same
///   shadowing rule as anywhere else in GK; we err out
///   in that case for clarity).
/// - **Appends** `__poll_until := <until>` as a regular
///   cycle binding (dynamic lifecycle per SRD-11 §"Two
///   Evaluation Lifecycles" — re-evaluates per pull as
///   capture cells update).
///
/// For the metrics case it appends an `extern phase_start: u64
/// = 0` origin wire (set by the executor at the completion-time
/// pull) and one `volatile __metric_<name> := <value>` per
/// declared phase metric. `volatile` on the `__metric_<name>`
/// binding excludes it from const-fold identity; a value that
/// reads a clock should declare that read as its own `volatile`
/// phase binding (e.g. `volatile now_ms := current_epoch_millis()`,
/// metric `value: now_ms - phase_start`) so the non-deterministic
/// node is acknowledged directly and the kernel compiles under
/// `--strict`. The executor pulls each `__metric_<name>` once at
/// phase completion and records it on the phase component.
///
/// Type inference is intentionally narrow in the
/// initial ship: every capture lands as `u64` (the
/// shape the canonical synchronizer-pattern workload
/// uses — `:count` reductions and numeric Jolokia
/// attribute reads). Non-numeric captures aren't
/// supported in the phase-poll predicate; the
/// workload author falls back to a different pattern.
/// SRD-75 §"Open questions: Capture-type inference
/// granularity" tracks the refinement.
pub fn synthesize_phase_scope_bindings(
    phase: &nmbrs_workload::model::WorkloadPhase,
) -> Result<nmbrs_workload::model::BindingsDef, String> {
    use nmbrs_workload::model::BindingsDef;
    let has_poll = phase.poll.is_some();
    let has_metrics = !phase.metrics.is_empty();
    // SRD-86 — an `optimize.objective` that is an inline expression (not a bare
    // wire reference) is lowered to a synthesized `__objective` binding below.
    let has_objective_expr = phase
        .optimize
        .as_ref()
        .is_some_and(|o| !objective_is_bare_wire(&o.objective));
    // No phase-scope augmentation needed — pass the author's bindings
    // through unchanged so a metrics/poll-free phase keeps its original
    // (possibly empty) `BindingsDef`. Stop conditions do NOT augment the
    // matter (they are scope-bound `ScopedPredicate`s built against the phase
    // kernel), so they don't force synthesis here.
    if !has_poll && !has_metrics && !has_objective_expr {
        return Ok(phase.bindings.clone());
    }

    // Walk every op in the phase, collect declared
    // capture names. The capture set is the union across
    // ops in the phase (the synchronizer pattern's
    // common case: one read-op captures all the state,
    // a second trigger-op only reads via `if:`). Only
    // relevant to the poll augmentation; empty otherwise.
    let mut capture_names: Vec<String> = Vec::new();
    let mut seen: HashSet<String> = HashSet::new();
    if has_poll {
        for op in &phase.ops {
            for cap in &op.captures {
                if seen.insert(cap.as_name.clone()) {
                    capture_names.push(cap.as_name.clone());
                }
            }
        }
    }

    // Compose the augmented source.
    let mut source = String::new();
    if has_poll {
        source.push_str(
            "# SRD-75 phase-poll augmentation — synthesized.\n\
             # Captures land here as shared cells; ops write through via\n\
             # `ctx.wires.write` on their op-template kernel's import\n\
             # slots (Rule 1 shared import → cell attached at spawn).\n",
        );
        for name in &capture_names {
            // Polydat's `shared X := <literal>` form infers the type
            // from the RHS literal (per SRD-13c
            // §"Implementation: SharedCell-backed input slots"
            // — `shared X := 0` lands as u64 via literal-fold).
            // Captures default to u64 with init 0; numeric
            // predicates compare cleanly, and TraversingDispenser's
            // json_to_value coerces the response value into the
            // matching Value variant.
            source.push_str(&format!("shared {name} := 0\n"));
        }
    }

    let original_body: String = match &phase.bindings {
        BindingsDef::PolydatSource(s) => s.clone(),
        BindingsDef::Map(m) => {
            let mut out = String::new();
            for (n, e) in m {
                out.push_str(&format!("{n} := {e}\n"));
            }
            out
        }
    };
    if !original_body.trim().is_empty() {
        // Detect collisions between author-declared
        // bindings and synthesized captures. A collision
        // is most likely a workload bug (the author
        // didn't realize the name was being synthesized
        // by phase-poll); fail loudly per SRD-30 unknown-
        // field hygiene rather than silently letting one
        // win.
        let locally_declared = scan_locally_declared_idents(&original_body);
        for name in &capture_names {
            if locally_declared.contains(name) {
                return Err(format!(
                    "phase-poll synthesis: capture name '{name}' is also \
                     declared by the phase's `bindings:` block — pick one. \
                     SRD-75 synthesizes captures as `shared <name>: u64`; \
                     re-declaring the same name in bindings is a collision."
                ));
            }
        }
        source.push_str(&original_body);
        if !source.ends_with('\n') {
            source.push('\n');
        }
    }

    if has_poll {
        // The predicate is a regular cycle binding (NOT
        // `const` — its upstream depends on per-cycle
        // capture writes, so it must re-evaluate per pull).
        let poll = phase.poll.as_ref().expect("has_poll");
        source.push_str(&format!("__poll_until := {}\n", poll.until));
    }

    if has_metrics {
        // Phase-level `metrics:` — emit one `volatile
        // __metric_<name> := <value>` per declared metric, plus the
        // executor-injected `phase_start` origin wire. `volatile`
        // acknowledges the nondeterminism of clock-reading values
        // like `phase_elapsed(phase_start)` so the phase kernel
        // compiles in strict mode (and excludes them from const-fold
        // identity); for a deterministic value it is harmless. The
        // executor pulls each `__metric_<name>` once at phase
        // completion — see `executor::emit_phase_metrics`.
        // `phase_start` binds the runtime's phase-scoped clock node rather
        // than an extern the executor has to remember to fill. As an extern it
        // was set ONLY on the completion-time metric pull, on a fresh subscope
        // — so anything reading it while the phase was still running (an op,
        // most obviously) saw the declared default of 0 and silently computed
        // against the epoch. The node reads the phase origin the executor
        // scopes in `run_phase`, so the value is correct from the phase's
        // first op onward, and `volatile` keeps it out of const-fold identity.
        source.push_str(
            "# Phase-level metrics — synthesized.\n\
             # `phase_start` is the epoch millis at which THIS phase started,\n\
             # read from the runtime's phase-scoped clock.\n\
             volatile phase_start := phase_start_millis()\n",
        );
        let mut entries: Vec<_> = phase.metrics.iter().collect();
        entries.sort_by(|a, b| a.0.cmp(b.0));
        for (name, spec) in entries {
            let binding = synthesize_metric_binding_name(name);
            source.push_str(&format!(
                "volatile {binding} := {expr}\n",
                expr = spec.value
            ));
            // See the op-template path: a coordinate is compiled matter, not a
            // runtime string. `volatile` for the same reason the value is —
            // a coordinate read from a capture or a clock must not be folded
            // into one phase's value.
            for (dim, expr) in &spec.cell {
                let cell_binding = synthesize_cell_binding_name(name, dim);
                source.push_str(&format!("volatile {cell_binding} := {expr}\n"));
            }
        }
    }

    if has_objective_expr {
        // SRD-86 — lower an inline `optimize.objective` expression to one wire
        // the optimizer reads (`__objective`), so an author can write the
        // objective inline instead of pre-declaring a `bindings:` entry.
        // Emitted LAST so it can reference any author binding or synthesized
        // `__metric_<name>` above it. `volatile` lets a metricsql/clock-reading
        // objective compile under `--strict` and is harmless for a
        // deterministic expression; the settle-vs-one-shot routing keys off
        // program-wide reader-node presence, not this flag, so a deterministic
        // inline objective still takes the one-shot path.
        let objective = &phase
            .optimize
            .as_ref()
            .expect("has_objective_expr")
            .objective;
        source.push_str(&format!(
            "# SRD-86 inline objective — synthesized.\n\
             volatile {OBJECTIVE_WIRE} := {objective}\n",
        ));
    }

    // SRD-83 stop conditions are NOT synthesized into the phase matter.
    // Each predicate is compiled as a scope-bound `ScopedPredicate`
    // (`stop_conditions::compile_stop_condition`) against the *built*
    // phase kernel and evaluated per trigger — authored phase bindings
    // and evaluated stop predicates stay orthogonal concerns.

    Ok(BindingsDef::PolydatSource(source))
}

/// Synthesize a phase-scope kernel.
///
/// Pushes the phase's own `bindings:` body verbatim, then drives
/// the shared cascade walker to declare every parent-visible
/// name the body references plus the standard workload-param +
/// parent-output + parent-input cascade.
// reason: cohesive scope-kernel constructor — each argument is a distinct
// piece of the scope's compile context (bindings, parent kernel, params,
// cascade inputs); a parameter struct would only relocate the same fields.
#[allow(clippy::too_many_arguments)]
pub fn build_phase_scope_kernel(
    bindings: &nmbrs_workload::model::BindingsDef,
    parent_manifest: &[crate::runner::ManifestEntry],
    parent_kernel: &crate::scope_kernel::ScopeKernel,
    workload_params: &HashMap<String, String>,
    polydat_lib_paths: Vec<std::path::PathBuf>,
    workload_dir: Option<&std::path::Path>,
    strict: bool,
    context: &str,
) -> Result<crate::scope_kernel::ScopeKernel, String> {
    use nmbrs_workload::model::BindingsDef;

    let body_text: String = match bindings {
        BindingsDef::PolydatSource(s) => s.clone(),
        BindingsDef::Map(m) => {
            let mut out = String::new();
            for (name, expr) in m {
                out.push_str(&format!("{name} := {expr}\n"));
            }
            out
        }
    };

    let mut source = String::new();
    let mut emitted: HashSet<String> = HashSet::new();
    let mut inherited_names: Vec<String> = Vec::new();

    // Discover the names the phase body references and the
    // names it locally declares (which shadow parent-output
    // cascade per SRD-13f).
    let body_locally_declared = scan_locally_declared_idents(&body_text);
    let mut referenced: HashSet<String> = HashSet::new();
    collect_string_interp_refs(&body_text, &mut referenced);
    for ident in scan_idents_in_polydat_source(&body_text) {
        if !body_locally_declared.contains(&ident) {
            referenced.insert(ident);
        }
    }

    // Drive the shared cascade walker. The phase body's
    // locally-declared idents go into both pre_emitted (so the
    // walker doesn't re-cascade them) and shadow_names (so the
    // workload-param + parent-output passes also skip them).
    crate::scope_synth::cascade_parent_into_source(
        crate::scope_synth::CascadeInputs {
            parent_kernel,
            workload_params,
            parent_manifest,
            referenced: &referenced,
            pre_emitted: &body_locally_declared,
            shadow_names: &body_locally_declared,
            // Phase opts out: the body may already declare
            // referenced names as `input` / `extern` and a
            // step-3 emission would collide. Phase relies on
            // step 5 (parent-output cascade) and step 6
            // (parent-input cascade) to bring in what the body
            // doesn't declare locally.
            include_referenced_cascade: false,
        },
        crate::scope_synth::CascadeOutputs {
            source: &mut source,
            emitted: &mut emitted,
            inherited_names: &mut inherited_names,
        },
    );

    // Append the phase's own bindings body verbatim. The GK
    // compiler classifies each statement (init / shared / final)
    // per the standard rules.
    if !source.ends_with('\n') && !source.is_empty() {
        source.push('\n');
    }
    source.push_str(&body_text);
    if !source.ends_with('\n') {
        source.push('\n');
    }

    let compile_options = polydat::kernel::subcontext::CompileOptions {
        workload_dir: workload_dir.map(|p| p.to_path_buf()),
        polydat_lib_paths,
        strict,
        required_outputs: Vec::new(),
        context_label: Some(context.to_string()),
        cursor_limit: None,
        ..Default::default()
    };

    if std::env::var("NMBRS_DEBUG_SCOPE_SYNTH")
        .map(|v| v == "1")
        .unwrap_or(false)
    {
        eprintln!(
            "=== SCOPE SYNTH [{context}] inherited={inherited_names:?} ===\n{source}\n=== END ==="
        );
    }
    crate::scope_kernel::ScopeKernel::synthesize_under(
        parent_kernel,
        crate::scope_kernel::SourceMatter::source(context, source, compile_options)
            .inherited(inherited_names),
    )
    .map_err(|e| format!("{context}: phase scope synthesis: {e}"))
}

// reason: cohesive scope-kernel constructor — each argument is a distinct
// piece of the do-loop's compile context (counter, condition, parent kernel,
// params, cascade inputs); a parameter struct would only relocate the fields.
#[allow(clippy::too_many_arguments)]
pub fn build_do_loop_scope_kernel(
    counter: Option<&str>,
    condition: &str,
    parent_manifest: &[crate::runner::ManifestEntry],
    parent_kernel: &crate::scope_kernel::ScopeKernel,
    workload_params: &HashMap<String, String>,
    polydat_lib_paths: Vec<std::path::PathBuf>,
    workload_dir: Option<&std::path::Path>,
    strict: bool,
    context: &str,
) -> Result<crate::scope_kernel::ScopeKernel, String> {
    // Scope-specific contribution: declare the counter extern
    // (if a counter is in play). The counter is the do-loop's
    // only own-iter wire; pre-emit it so the shared cascade
    // walker doesn't try to type-cascade it from the parent
    // (which doesn't know about it).
    let mut source = String::new();
    let mut emitted: HashSet<String> = HashSet::new();
    let mut inherited_names: Vec<String> = Vec::new();

    if let Some(c) = counter {
        source.push_str(&format!("extern {c}: u64\n"));
        emitted.insert(c.to_string());
    }

    // Drive the shared cascade walker. `referenced` is the set
    // of `{name}` placeholders the condition expression
    // mentions; pre_emitted is the counter (if any).
    let referenced = collect_leaf_placeholders(&[condition.to_string()]);
    let pre_emitted: HashSet<String> = counter.iter().map(|c| c.to_string()).collect();
    let shadow_names: HashSet<String> = pre_emitted.clone();
    crate::scope_synth::cascade_parent_into_source(
        crate::scope_synth::CascadeInputs {
            parent_kernel,
            workload_params,
            parent_manifest,
            referenced: &referenced,
            pre_emitted: &pre_emitted,
            shadow_names: &shadow_names,
            // do-loop opts in: the condition expression is
            // narrowly-scoped Polydat source that references
            // names which need extern declarations to be
            // resolvable. Step 3 emits those externs against
            // parent_manifest's types.
            include_referenced_cascade: true,
        },
        crate::scope_synth::CascadeOutputs {
            source: &mut source,
            emitted: &mut emitted,
            inherited_names: &mut inherited_names,
        },
    );

    if source.is_empty() {
        source.push_str("const __empty := 0\n");
    }

    // The same compile options every synthesized scope takes: the
    // workload's library paths and directory, so the condition can call
    // library modules and name workload-relative files, and strict mode.
    let compile_options = polydat::kernel::subcontext::CompileOptions {
        workload_dir: workload_dir.map(|p| p.to_path_buf()),
        polydat_lib_paths,
        strict,
        required_outputs: Vec::new(),
        context_label: Some(context.to_string()),
        cursor_limit: None,
        ..Default::default()
    };
    crate::scope_kernel::ScopeKernel::synthesize_under(
        parent_kernel,
        crate::scope_kernel::SourceMatter::source(context, source, compile_options)
            .inherited(inherited_names),
    )
    .map_err(|e| format!("{context}: do-loop scope synthesis: {e}"))
}

/// Token-shaped identifier scan over Polydat source. Returns every
/// alphanumeric/underscore-shaped token that isn't a keyword
/// or numeric literal. Used by
/// [`build_op_template_scope_kernel`] to discover names the
/// op's bindings body references; the Polydat compiler does the
/// authoritative parse downstream — this scan is just a
/// best-effort first pass for the cross-scope contract check.
pub(crate) fn scan_idents_in_polydat_source(src: &str) -> HashSet<String> {
    const KEYWORDS: &[&str] = &[
        "input", "extern", "const", "final", "init", "shared", "volatile", "cursor", "pragma",
        "true", "false", "as", "in", "for",
        // Block-form conditional selection: `if <cond> { a } else { b }`. This is a
        // TEXTUAL scan, so it cannot tell a keyword from a wire name by position —
        // before these were listed, a binding using the block form reported `if` and
        // `else` as unresolved wire references. The call form `if(cond, a, b)` was
        // unaffected and so did not surface this.
        "if", "else",
    ];
    let mut out = HashSet::new();
    let mut chars = src.chars().peekable();
    let mut current = String::new();
    let mut in_string = false;
    let mut in_line_comment = false;
    let mut in_block_comment = false;
    // Suppress the next ident — set when we just saw a `:` outside
    // strings/comments. Lets us skip the type token in declarations
    // like `extern x: u64`, `input cycle: u64`, `input (a: u64, b: f64)`,
    // and module signatures `foo(p: u64) -> (q: f64)`. A type name
    // (`u64`/`f64`/`Str`/etc.) is not a wire reference.
    let mut suppress_next_ident = false;
    while let Some(c) = chars.next() {
        if in_line_comment {
            if c == '\n' {
                in_line_comment = false;
            }
            continue;
        }
        if in_block_comment {
            if c == '*' && chars.peek() == Some(&'/') {
                chars.next();
                in_block_comment = false;
            }
            continue;
        }
        if in_string {
            if c == '\\' {
                chars.next();
                continue;
            }
            if c == '"' {
                in_string = false;
            }
            continue;
        }
        if c == '"' {
            in_string = true;
            continue;
        }
        // `#` to end-of-line — YAML-style hash comment, matching the
        // Polydat lexer (`dsl/lexer.rs` "Skip hash comments"). Without
        // this, comment words inside a `bindings: |` block leak in as
        // phantom wire references.
        if c == '#' {
            in_line_comment = true;
            continue;
        }
        if c == '/' {
            if chars.peek() == Some(&'/') {
                chars.next();
                in_line_comment = true;
                continue;
            }
            if chars.peek() == Some(&'*') {
                chars.next();
                in_block_comment = true;
                continue;
            }
        }
        if c.is_alphanumeric() || c == '_' {
            current.push(c);
        } else if !current.is_empty() {
            // Token boundary — is `current` an ident?
            let is_ident = !current
                .chars()
                .next()
                .map(|c| c.is_ascii_digit())
                .unwrap_or(true)
                && !KEYWORDS.contains(&current.as_str());
            if is_ident && !suppress_next_ident {
                out.insert(current.clone());
            }
            current.clear();
            suppress_next_ident = false;
        }
        // Track `:` separately so the next ident is treated as a
        // type annotation. Excludes `:=` (the binding operator) by
        // peeking ahead.
        if c == ':' && chars.peek() != Some(&'=') {
            suppress_next_ident = true;
        }
    }
    if !current.is_empty()
        && !current
            .chars()
            .next()
            .map(|c| c.is_ascii_digit())
            .unwrap_or(true)
        && !KEYWORDS.contains(&current.as_str())
        && !suppress_next_ident
    {
        out.insert(current);
    }
    out
}

/// Names declared on the LHS of `:=` (or `=` for init bindings)
/// in Polydat source. Locally-declared names shadow parent-scope
/// references per SRD-13c §"Shadowing", so the cross-scope
/// contract check skips them.
pub(crate) fn scan_locally_declared_idents(src: &str) -> HashSet<String> {
    let mut out = HashSet::new();
    for line in src.lines() {
        let line = line.trim();
        // Skip blanks + line comments. `#` (YAML-style) and `//` are
        // both Polydat line-comment forms (`dsl/lexer.rs`); neither
        // declares a binding.
        if line.is_empty() || line.starts_with("//") || line.starts_with('#') {
            continue;
        }
        // Drop modifier prefixes (`final const x := …`,
        // `shared y := …`) so the LHS ident is always the
        // last word before `:=` or `=`.
        let prefixes = [
            "shared const ",
            "const ",
            "init ",
            "shared ",
            "final ",
            "volatile ",
            "extern ",
        ];
        let mut rest = line;
        loop {
            let mut stripped = false;
            for p in &prefixes {
                if let Some(r) = rest.strip_prefix(p) {
                    rest = r.trim_start();
                    stripped = true;
                    break;
                }
            }
            if !stripped {
                break;
            }
        }
        // Find `:=` or `=` (but not `==`).
        let assign_idx = rest.find(":=").or_else(|| {
            rest.find('=')
                .filter(|&i| rest.as_bytes().get(i + 1) != Some(&b'='))
        });
        let Some(idx) = assign_idx else { continue };
        let lhs = rest[..idx].trim();
        // `extern name: type` — the lhs is "name: type"; strip the type.
        let name = lhs.split(':').next().unwrap_or(lhs).trim();
        if !name.is_empty() && name.chars().all(|c| c.is_alphanumeric() || c == '_') {
            out.insert(name.to_string());
        }
    }
    out
}

// SRD-13c `ParentRefKind` classification and the
// `classify_parent_ref` helper were retired by SRD-13f. The
// snapshot-vs-shared contract they enforced is superseded by
// uniform construction-time wiring + per-cycle refresh on
// non-shared parent outputs (SRD-13f §"Materialization gradient").

/// SRD-13d Phase 9 — synthesize a per-op-template kernel for a
/// materialised op-template scope.
///
/// Mirrors [`build_do_loop_scope_kernel`] but uses the op's
/// `bindings:` block (which already carries metric `:=` injections
/// per SRD-40b §1) as the body. The resulting kernel:
///
/// 1. Emits an `extern <name>: <type>` for every parent-visible
///    name the op explicitly references — and only those, so
///    the op-template kernel stays narrow.
/// 2. Validates each reference against the SRD-13c cross-scope
///    visibility contract: `Input`, `SharedOutput`, or
///    `ConstantOutput` are accepted; `DynamicOutput` errors at
///    workload-init time with a clear message pointing at the
///    `shared` modifier path.
/// 3. Emits the op's own bindings.
/// 4. Builds the scope under the parent kernel and propagates
///    inherited inputs. The scope keeps its module, from which each
///    fiber instantiates its per-op kernel with the module's
///    `result:` write-throughs ([`crate::fiber_engine`]).
// reason: cohesive scope-kernel constructor — each argument is a distinct
// piece of the op-template's compile context (op, parent kernel, params,
// cascade inputs); a parameter struct would only relocate the same fields.
#[allow(clippy::too_many_arguments)]
pub fn build_op_template_scope_kernel(
    op: &nmbrs_workload::model::ParsedOp,
    parent_manifest: &[crate::runner::ManifestEntry],
    parent_kernel: &crate::scope_kernel::ScopeKernel,
    workload_params: &HashMap<String, String>,
    polydat_lib_paths: Vec<std::path::PathBuf>,
    workload_dir: Option<&std::path::Path>,
    strict: bool,
    kernel_opt: polydat::kernel::KernelOptLevel,
    context: &str,
) -> Result<crate::scope_kernel::ScopeKernel, String> {
    use nmbrs_workload::model::BindingsDef;

    let manifest_by_name: HashMap<&str, &crate::runner::ManifestEntry> = parent_manifest
        .iter()
        .map(|e| (e.name.as_str(), e))
        .collect();

    let mut source = String::new();
    let mut emitted: HashSet<String> = HashSet::new();
    let mut inherited_names: Vec<String> = Vec::new();

    // SRD-13f: every parent-visible wire the op template
    // references — whether in body, condition, delay, metric
    // values, op fields (`stmt`, `uri`, `body`, etc.), or
    // string-interpolation arguments inside the body — gets
    // wired into the local op-template kernel at construction.
    // Local reads on the op-template kernel then resolve every
    // such name through the local read API, with construction-
    // time wiring guaranteeing the read invariant (inner reads
    // return the value that outer would return — see SRD-13f
    // §"The read invariant"). The wires layer takes one kernel
    // handle and never composes chains externally.
    let body_text: String = match &op.bindings {
        BindingsDef::PolydatSource(s) => s.clone(),
        BindingsDef::Map(m) => {
            let mut out = String::new();
            for (name, expr) in m {
                out.push_str(&format!("{name} := {expr}\n"));
            }
            out
        }
    };

    // SRD-13f Push D: declare the parent's coordinate inputs
    // (typically just `cycle`) on this op-template kernel.
    // Pre-Push-D, the workload-level `input <name>: <type>` line
    // was merged into op.bindings and arrived via body_text, so
    // the kernel always had a Coordinate slot. After Push D
    // body_text no longer carries it, so we emit the declaration
    // explicitly — without it the op-template kernel has no
    // input slot for cycle and the runtime's per-cycle
    // `set_inputs` writes go nowhere.
    let body_has_inputs_decl = body_text
        .lines()
        .any(|line| line.trim_start().starts_with("input "));
    if !body_has_inputs_decl {
        let parent_coord_names: Vec<String> = parent_kernel
            .program()
            .input_names()
            .into_iter()
            .take(parent_kernel.program().coord_count())
            .collect();
        if !parent_coord_names.is_empty() {
            source.push_str(&format_input_decl_line(&parent_coord_names));
            for name in &parent_coord_names {
                emitted.insert(name.clone());
            }
        }
    }
    // SRD-109 Part 3 — `results:` interface wires are dispenser-
    // delivered projections (`result:` path entries evaluated by
    // the result wrapper); declare each as an explicit extern at
    // its interface type so the per-cycle `ctx.wires.write` lands
    // on a correctly-typed slot. Emitted before the cascade scan
    // so a relevancy/metric reference to the same name doesn't
    // try to pull it from the parent.
    if let Some(iface) = op.abstract_interface.as_ref() {
        for (rname, kw) in &iface.results {
            if polydat::ast::PortType::from_keyword(kw).is_none() {
                return Err(format!(
                    "{context}: interface results wire '{rname}' declares \
                     unknown type '{kw}'"
                ));
            }
            if !emitted.contains(rname) {
                source.push_str(&format!("extern {rname}: {kw}\n"));
                emitted.insert(rname.clone());
            }
        }
    }

    let body_idents = scan_idents_in_polydat_source(&body_text);
    let body_locally_declared = scan_locally_declared_idents(&body_text);
    let mut referenced: Vec<String> = Vec::new();
    // Op field references — `stmt`, `uri`, `body`, etc. carry
    // `{name}` placeholders the dispenser substitutes at cycle
    // time. Those wires must be reachable on the op-template
    // kernel so the dispenser's single-kernel-handle wires
    // surface resolves them through the local read API.
    for value in op.op.values() {
        if let Some(s) = value.as_str() {
            for n in nmbrs_workload::bindpoints::referenced_bindings(s) {
                if !body_locally_declared.contains(&n) && !referenced.iter().any(|r| r == &n) {
                    referenced.push(n);
                }
            }
        }
    }
    for ident in &body_idents {
        if body_locally_declared.contains(ident) {
            continue;
        }
        if !referenced.iter().any(|r| r == ident) {
            referenced.push(ident.clone());
        }
    }
    // String-interpolation references inside the body (e.g.
    // `dataset_prebuffer("{dataset}:{profile}")`). The Polydat compiler
    // desugars those into wires that need a matching extern;
    // without this scan, the cascade misses them and the compiler
    // defaults the auto-extern to u64, landing a Str value into a
    // u64 slot at bind-time and panicking via an inserted
    // `__u64_to_string` adapter.
    let mut interp_refs: HashSet<String> = HashSet::new();
    collect_string_interp_refs(&body_text, &mut interp_refs);
    for ident in interp_refs {
        if body_locally_declared.contains(&ident) {
            continue;
        }
        if !referenced.iter().any(|r| r == &ident) {
            referenced.push(ident);
        }
    }
    if let Some(ref s) = op.condition {
        let n = s.trim().trim_start_matches('{').trim_end_matches('}');
        if !n.is_empty() && !body_locally_declared.contains(n) && !referenced.iter().any(|r| r == n)
        {
            referenced.push(n.to_string());
        }
    }
    // Capture targets are a WRITE usage surface of this op: the
    // runtime lands each captured value on this kernel's input slot
    // via `ctx.wires.write` (see TraversingDispenser). The name must
    // therefore be declared here like any other referenced wire —
    // the standard cascade below emits the `extern` (with the
    // parent's port type) and the wiring machinery binds it to the
    // ancestral `shared` cell when one is in scope, making the
    // write visible across phases. Without the declaration a
    // capture-only op's write is a silent NoSlot drop, and any
    // later phase gating on the cell reads its initializer forever.
    for cap in &op.captures {
        let n = cap.as_name.as_str();
        if !n.is_empty() && !body_locally_declared.contains(n) && !referenced.iter().any(|r| r == n)
        {
            referenced.push(n.to_string());
        }
    }
    if let Some(ref delay_spec) = op.delay {
        for raw in delay_spec.names() {
            let n = raw.trim().trim_start_matches('{').trim_end_matches('}');
            if !n.is_empty()
                && !body_locally_declared.contains(n)
                && !referenced.iter().any(|r| r == n)
            {
                referenced.push(n.to_string());
            }
        }
    }
    for spec in op.metrics.values() {
        let trimmed = spec.value.trim();
        let bare = !trimmed.is_empty() && trimmed.chars().all(|c| c.is_alphanumeric() || c == '_');
        if bare
            && !body_locally_declared.contains(trimmed)
            && !referenced.iter().any(|r| r == trimmed)
        {
            referenced.push(trimmed.to_string());
        }
    }

    // Wire references inside the relevancy block. The validator
    // resolves `actual:`, `expected:`, `k:`, `r:` at wrap-time
    // through the dispenser's canonical kernel (parse_count_param
    // and the `expected_wire_name` path in `validation.rs`).
    // Strings that are bare identifiers OR `{name}` text-templates
    // name a wire that must be visible on this op-template kernel;
    // numeric / integer-literal values aren't wire references and
    // pass through.
    if let Some(rel) = op.params.get("relevancy").and_then(|v| v.as_object()) {
        for key in &["actual", "expected", "k", "r"] {
            let Some(val) = rel.get(*key).and_then(|v| v.as_str()) else {
                continue;
            };
            let trimmed = val
                .trim()
                .trim_start_matches('{')
                .trim_end_matches('}')
                .trim();
            if trimmed.is_empty() {
                continue;
            }
            // Skip numeric literals — `k: 10` is a constant, not a
            // wire ref.
            if trimmed.parse::<i64>().is_ok() {
                continue;
            }
            // Bare-identifier check matches the validator's
            // `is_bare_ident` rule.
            let bare = trimmed
                .chars()
                .next()
                .map(|c| c.is_ascii_alphabetic() || c == '_')
                .unwrap_or(false)
                && trimmed
                    .chars()
                    .all(|c| c.is_ascii_alphanumeric() || c == '_');
            if !bare {
                continue;
            }
            if !body_locally_declared.contains(trimmed) && !referenced.iter().any(|r| r == trimmed)
            {
                referenced.push(trimmed.to_string());
            }
        }
    }

    // SRD-66 result-bindings: every LHS name a result-binding
    // declares needs an input slot on this op-template kernel so
    // the Rule 2 write-through can wire to the parent's SHARED
    // cell. Without this, the cell-bound slot is never declared,
    // `add_result_bindings` falls back to PortType::U64 (the
    // "couldn't classify" default) for the export, and the write-
    // through stores into a U64-typed view of what's actually a
    // Bool/Str/etc. cell — surfaces downstream as a "non-bool
    // type" pick panic.
    //
    // String-shape fragments carry full Polydat source whose LHS we
    // extract via `scan_locally_declared_idents`. Map-shape
    // fragments give the name directly.
    if let Some(rb) = op.result.as_ref() {
        rb.walk_fragments(|frag| match frag {
            nmbrs_workload::model::ResultFragment::Source(s) => {
                for n in scan_locally_declared_idents(s) {
                    if !body_locally_declared.contains(&n) && !referenced.iter().any(|r| r == &n) {
                        referenced.push(n);
                    }
                }
            }
            nmbrs_workload::model::ResultFragment::Named { name, .. } => {
                let n = name.to_string();
                if !body_locally_declared.contains(&n) && !referenced.iter().any(|r| r == &n) {
                    referenced.push(n);
                }
            }
        });
    }

    // SRD-13f: parent-ref classification no longer gates
    // extern emission. The legacy "DynamicOutput without
    // shared" rejection assumed snapshot semantics for
    // non-shared cross-scope reads (SRD-13c §"Default:
    // Immutable Propagation"). SRD-13f reframes that rule:
    // the read invariant is uniform across all visible
    // parent outputs — inner reads return outer's current
    // value — and the construction-time wiring (cell
    // attachment for shared, per-cycle refresh for non-shared
    // pending the full cell mechanism in Push B.2) keeps the
    // invariant intact. No external pre-check needed.

    // Emit extern decls only for names the op references and
    // that the parent provides. Lazy cascade — keeps the
    // op-template kernel narrow and makes the contract check
    // above crisp.
    for name in &referenced {
        if emitted.contains(name) {
            continue;
        }
        if body_locally_declared.contains(name) {
            continue;
        }
        // Names that are *Coordinate* inputs in the parent (the
        // implicit `cycle` and friends) must stay Coordinate in
        // the inner kernel too, so `set_inputs` propagates them
        // per cycle. An explicit `extern` declaration would force
        // IterationExtern classification and break propagation —
        // skip the explicit emit and let the inner kernel's auto-
        // extern path re-classify as Coordinate.
        let is_parent_coord = parent_kernel
            .program()
            .find_input(name)
            .and_then(|idx| parent_kernel.program().input_kind(idx))
            .is_some_and(|k| matches!(k, polydat::kernel::InputKind::Coordinate));
        if is_parent_coord {
            // The cascade still needs to record this as an
            // inherited name so `mark_inherited_outputs` includes
            // it — the inner kernel will re-publish it as an
            // (auto-extern) input/output and materialize_wiring_from_outer
            // will value-copy at construction time.
            inherited_names.push(name.clone());
            continue;
        }
        // Workload-param check goes BEFORE manifest cascade: a
        // workload param ALSO appears in the parent's manifest
        // (cascaded as an auto-output of an `extern <name>: …`
        // line in the for_each scope synthesiser), but op-template
        // bodies need it as a `final` literal so `init <name> =
        // <expr-using-param>` folds at compile time. Routing
        // through the manifest path emits `extern`, leaves init
        // unfolded, and the runtime sees `Value::None` in the
        // input slot — exactly the surface the Phase-9 op-template
        // kernel was hitting on dataset_prebuffer / query_count.
        if let Some(value) = workload_params.get(name) {
            // Chain-aware: a `set:` / `bindings:` scope above
            // us may have shadowed the workload-param default.
            // This was the root cause of the CQL prepared-
            // statement regression where `{ann_opts}` got
            // emitted as a `?` bind point — the op-template
            // kernel's local `const rerank_mode := "default"`
            // masked the SetParam shadow, and the downstream
            // `const ann_opts := select_str(str_eq(
            // rerank_mode, "pinned"), …)` folded against the
            // wrong rerank_mode value.
            crate::scope_synth::emit_workload_param_chain_aware(
                name,
                value,
                parent_kernel,
                &mut source,
                &mut emitted,
                None,
            );
        } else if let Some(entry) = manifest_by_name.get(name.as_str()) {
            let type_name = entry.port_type.to_keyword();
            source.push_str(&format!("extern {name}: {type_name}\n"));
            emitted.insert(name.clone());
            inherited_names.push(name.clone());
        } else if let Some(parent_idx) = parent_kernel.program().find_input(name) {
            // Parent INPUT — for non-Coordinate inputs (iteration
            // vars, external-write ports) emit an explicit `extern` so the
            // inner kernel's input classification matches the
            // parent's, and materialize_wiring_from_outer can value-copy or
            // shared-cell-attach. For Coordinate inputs (e.g. the
            // implicit `cycle` coord), DON'T emit — let the GK
            // auto-extern path classify them as Coordinate too,
            // so per-cycle `set_inputs` propagates to the inner
            // kernel. An explicit `extern` would force
            // IterationExtern and break that propagation.
            let kind = parent_kernel.program().input_kind(parent_idx);
            if !matches!(kind, Some(polydat::kernel::InputKind::Coordinate)) {
                let port_type = parent_kernel
                    .program()
                    .input_port_type(name)
                    .ok_or_else(|| {
                        format!(
                            "scope synthesis: parent input '{name}' has no \
                         declared PortType (find_input returned index {parent_idx} \
                         but input_port_type returned None — kernel program shape \
                         broken)"
                        )
                    })
                    .expect("input index just resolved must have a port type");
                let type_name = port_type.to_keyword();
                source.push_str(&format!("extern {name}: {type_name}\n"));
                emitted.insert(name.clone());
                inherited_names.push(name.clone());
            }
        }
    }

    // SRD-13f Push A: workload params are root-level context
    // wires — they must appear on every scope's kernel program
    // as inlined constants (materialization gradient §"Inlined
    // constant"). The per-name loop above emits them as `final`
    // for body-referenced params; this cascade catches the rest
    // so every workload param lands on this op-template kernel
    // as a folded constant. The previous emission shape
    // (`extern X: type`) was wrong — it forced a runtime input
    // slot, which (a) prevented `const` bindings from folding
    // against the param's value at compile time and (b) routed
    // a compile-time-constant value through the runtime input
    // path. `final` is the correct materialization.
    for (name, value) in workload_params {
        // Chain-aware emission: honors any `set:` / `bindings:`
        // scope shadow above us. Without it, the op-template's
        // local `const NAME := <hashmap-default>` would mask
        // the shadow and break SRD-21's single-resolution-
        // surface invariant.
        crate::scope_synth::emit_workload_param_chain_aware(
            name,
            value,
            parent_kernel,
            &mut source,
            &mut emitted,
            None,
        );
    }
    if body_text.trim().is_empty() {
        // No own bindings — the kernel just re-exports parent.
        // The flatten-elision logic upstream should have caught
        // this, but defensively keep the kernel non-empty.
        if source.is_empty() {
            source.push_str("const __empty := 0\n");
        }
    } else {
        if !source.ends_with('\n') && !source.is_empty() {
            source.push('\n');
        }
        source.push_str(&body_text);
        if !source.ends_with('\n') {
            source.push('\n');
        }
    }

    // SRD-67 Phase 3 — route op-template scope synthesis through
    // the SubcontextBuilder bridge. The Phase-9 op-template
    // kernel needs the same `compile_polydat_with_libs` knobs the
    // legacy direct call took (lib paths, strict, source dir,
    // context label); those flow through `CompileOptions`. The
    // bridge applies `mark_inherited_outputs` and
    // `materialize_wiring_from_outer` against the live parent so per-cycle
    // values reach the inner kernel's input slots; the trailing
    // `polydat::kernel::propagate_inputs` keeps cascade-extern'd inputs
    // flowing through (until Rule 4 / Rule 5 absorb them).
    let compile_options = polydat::kernel::subcontext::CompileOptions {
        workload_dir: workload_dir.map(|p| p.to_path_buf()),
        polydat_lib_paths,
        strict,
        required_outputs: Vec::new(),
        context_label: Some(context.to_string()),
        cursor_limit: None,
        kernel_opt,
        ..Default::default()
    };

    // SRD-67 Phase 5 — fold the SRD-66 `result:` source through
    // `add_result_bindings`. The builder walks the source's free
    // identifiers, injects magic externs (`body` / `count` /
    // `ok`) it actually references, and registers each LHS as
    // an export. Rule 2 in finalize rewrites any LHS that
    // collides with a parent `shared` export into a write-
    // through; the kernel carries the bindings forward via
    // `set_write_throughs` so the per-cycle dispenser can
    // commit. Map-shape entries (already flattened to
    // `<name> := <source>` in the workload model) flow
    // through unchanged; path expressions surface as unbound-
    // identifier compile errors with the SRD-66 deferred-
    // structural-body-wire diagnostic.
    // SRD-66 result bindings + post-SRD-68 metric-value bindings.
    // Both routes feed the same closure-binding-economy walker
    // (`add_result_bindings`) which injects magic externs
    // (body/count/ok) for any of those names referenced from
    // either RHS. The walker then registers each LHS as a kernel
    // output the metrics wrapper / evaluator reads at cycle time
    // via `wires.get`.
    //
    // Metric-driven bindings use the `__metric_<name>` prefix so
    // they don't collide with user-declared output names and so
    // diagnostic output can filter them as internal. MetricsDispenser
    // reads the same `__metric_<name>` form at cycle time —
    // `synthesize_metric_binding_name` is the single source of
    // truth for the naming convention.
    let mut result_source: String = op
        .result
        .as_ref()
        .map(collect_result_bindings_source)
        .unwrap_or_default();
    if !op.metrics.is_empty() {
        // Stable ordering — matches `MetricsDispenser::wrap`'s
        // sort-by-name so synthesis order is reproducible.
        let mut entries: Vec<_> = op.metrics.iter().collect();
        entries.sort_by(|a, b| a.0.cmp(b.0));
        for (name, spec) in entries {
            let binding = synthesize_metric_binding_name(name);
            result_source.push_str(&format!("{binding} := {expr}\n", expr = spec.value));
            // Cell coordinates are reified the same way the value is: as
            // compiled kernel bindings walked by `add_result_bindings`, so a
            // coordinate expression gets its magic-extern slots and is
            // type-checked, rather than being a string assembled at runtime.
            // `BTreeMap` iteration keeps the emission order stable.
            for (dim, expr) in &spec.cell {
                let cell_binding = synthesize_cell_binding_name(name, dim);
                result_source.push_str(&format!("{cell_binding} := {expr}\n"));
            }
        }
    }
    // Poll predicate. `poll.until:` lowers to the SAME binding name the
    // phase-level poll uses (`condition::UNTIL_BINDING`), in the op's own
    // kernel — so the poll wrapper reads one wire and never asks which kind of
    // node it is running under. Ordinary scoping does the rest: an op's
    // predicate shadows its phase's, as any other wire would.
    if let Some(until) = template_poll_until(op) {
        result_source.push_str(&format!(
            "{} := {until}\n",
            crate::wrappers::condition::UNTIL_BINDING,
        ));
    }
    // While-wrapper predicate. Synthesised as `__while := <expr>`
    // so `add_result_bindings` walks the expression, injects
    // magic externs for any captured wires it references, and
    // registers `__while` as a kernel output the WhileWrapper
    // reads at cycle time via the canonical pull plan.
    if let Some(while_expr) = op.while_cond.as_ref() {
        result_source.push_str(&format!(
            "{} := {expr}\n",
            crate::wrappers::r#while::BINDING_NAME,
            expr = while_expr,
        ));
    }
    let result_source: Option<String> = Some(result_source).filter(|s| !s.trim().is_empty());

    if std::env::var("NMBRS_DEBUG_SCOPE_SYNTH")
        .map(|v| v == "1")
        .unwrap_or(false)
    {
        eprintln!(
            "=== OP SYNTH [{context}] inherited={inherited_names:?} parent_has_xval_input={:?} parent_manifest_has_xval={} ===\n{source}\n=== END ===",
            parent_kernel.program().find_input("xval"),
            manifest_by_name.contains_key("xval")
        );
    }
    // Built under the parent from source matter; the scope keeps the
    // finalized module, from which each fiber instantiates its per-op
    // kernel with the module's write-throughs. Strict mode refuses a
    // scope-init const that fell through to `None`
    // (composition_substrate.md L2.f).
    let synthesis_error = |e: String| format!("{context}: op-template scope synthesis: {e}");
    let mut matter = crate::scope_kernel::SourceMatter::source(context, source, compile_options)
        .inherited(inherited_names);
    if let Some(rb) = result_source {
        matter = matter.results(rb);
    }
    let kernel = crate::scope_kernel::ScopeKernel::synthesize_under(parent_kernel, matter)
        .map_err(synthesis_error)?;

    // SRD-108 Part B — the interface's TYPE PROOF, at the same
    // place every other wire is type-checked: pre-map synthesis,
    // against the compiled op-template program. Load-time binder
    // checks were the early named errors; this is enforcement.
    if let Some(iface) = op.abstract_interface.as_ref() {
        verify_op_interface(iface, kernel.program().as_ref(), context)?;
    }
    Ok(kernel)
}

/// SRD-108 Part B — verify a bound slot's interface against its
/// compiled op-template program:
///
/// - every `yields` name must exist on the program (a capture
///   extern slot or a declared output) with the declared type;
/// - every `needs` name the program declares as a slot must
///   carry the declared type (a need consumed only through
///   textual bind points declares no slot — the parent-chain
///   resolution type-checks those as usual).
///
/// Runs during pre-map synthesis — an interface violation fails
/// workload init, never a runtime critical section.
fn verify_op_interface(
    iface: &nmbrs_workload::model::OpInterface,
    program: &polydat::kernel::PolydatProgram,
    context: &str,
) -> Result<(), String> {
    let type_of = |name: &str| -> Option<polydat::ast::PortType> {
        program
            .input_port_type(name)
            .or_else(|| program.output_port_type(name))
    };
    // Yields: PRESENCE is the binder's load-time check (a capture
    // `as`-name); captures deliver through the wrapper stack's
    // wire writes, so a capture-only yield may hold no slot on
    // the op-template program itself. When a slot DOES
    // materialize (declared cast, binding reference), its type
    // must match the interface.
    for (name, declared) in &iface.yields {
        let Some(expected) = polydat::ast::PortType::from_keyword(declared) else {
            return Err(format!(
                "{context}: interface yield '{name}' declares unknown \
                 type '{declared}'"
            ));
        };
        if let Some(actual) = type_of(name)
            && actual != expected
        {
            return Err(format!(
                "{context}: interface yield '{name}' declares type \
                 {declared}, but the compiled op template carries \
                 {actual:?}"
            ));
        }
    }
    for (name, declared) in &iface.needs {
        let Some(expected) = polydat::ast::PortType::from_keyword(declared) else {
            return Err(format!(
                "{context}: interface need '{name}' declares unknown \
                 type '{declared}'"
            ));
        };
        if let Some(actual) = type_of(name)
            && actual != expected
        {
            return Err(format!(
                "{context}: interface need '{name}' declares type \
                 {declared}, but the compiled op template carries \
                 {actual:?}"
            ));
        }
    }
    // Results (SRD-109 Part 3): the projection wire's slot is
    // DECLARED from the interface type at op-template build (see
    // the result-binding declaration pass), so the check here is
    // keyword validity plus agreement when the slot materialized —
    // a mismatch means something else (a binding, a cast) claimed
    // the name at a different type.
    for (name, declared) in &iface.results {
        let Some(expected) = polydat::ast::PortType::from_keyword(declared) else {
            return Err(format!(
                "{context}: interface results wire '{name}' declares \
                 unknown type '{declared}'"
            ));
        };
        if let Some(actual) = type_of(name)
            && actual != expected
        {
            return Err(format!(
                "{context}: interface results wire '{name}' declares \
                 type {declared}, but the compiled op template carries \
                 {actual:?}"
            ));
        }
    }
    Ok(())
}

/// Internal binding name for a workload-declared metric's `value:`
/// expression. The metric's `value:` source is synthesised into the
/// op-template kernel as `<binding> := <expr>` so a single
/// closure-binding-economy walker handles slot allocation for
/// magic-extern references in both result-bindings AND
/// metric-value expressions. MetricsDispenser reads the same name
/// at cycle time via `ctx.wires.get` — the prefix keeps these
/// internal bindings from colliding with workload-declared output
/// names and lets diagnostic surfaces filter them out by prefix.
/// The `until:` expression from an op's `poll:` map, if it declared one.
///
/// Returns `None` for the row-count form (`mode` / `min_rows` / `max_rows`),
/// which stays supported — a workload that counts rows keeps working and a
/// workload that states a condition gets the condition.
fn template_poll_until(op: &nmbrs_workload::model::ParsedOp) -> Option<String> {
    op.params
        .get("poll")?
        .as_object()?
        .get("until")?
        .as_str()
        .map(|s| s.trim().to_string())
        .filter(|s| !s.is_empty())
}

pub fn synthesize_metric_binding_name(metric_name: &str) -> String {
    format!("__metric_{metric_name}")
}

/// The kernel wire a metric's cell COORDINATE is lowered to, per
/// (metric, dimension).
///
/// Keyed by metric as well as dimension because two metrics in one scope may
/// place into the same dimension by different expressions — `bytes_out` from
/// one captured column and `bytes_in` from another. A per-dimension name would
/// collide and one placement would silently win.
///
/// Same `__` convention as [`synthesize_metric_binding_name`]: it cannot
/// collide with an author-declared output, and diagnostics can filter it as
/// internal.
pub fn synthesize_cell_binding_name(metric_name: &str, dimension: &str) -> String {
    format!("__cell_{metric_name}__{dimension}")
}

/// The phase-kernel wire an **inline objective expression** is lowered to
/// (SRD-86). `optimize.objective` is either a bare wire reference (read
/// directly off the phase kernel) or an inline expression;
/// [`synthesize_phase_scope_bindings`] lowers the latter to
/// `volatile __objective := <expr>` so the optimizer reads exactly one wire
/// regardless of which form the author wrote. The `__` prefix keeps it from
/// colliding with author-declared outputs (same convention as
/// [`synthesize_metric_binding_name`]).
pub const OBJECTIVE_WIRE: &str = "__objective";

/// Whether an `optimize.objective` value is a **bare wire reference** — a
/// single identifier read directly off the phase kernel — versus an **inline
/// expression** (operators, calls, dots, whitespace) that must be synthesized.
/// A bare reference is left untouched (no synthesis, current behavior); an
/// expression is lowered to [`OBJECTIVE_WIRE`].
pub fn objective_is_bare_wire(objective: &str) -> bool {
    let s = objective.trim();
    !s.is_empty()
        && s.chars()
            .next()
            .is_some_and(|c| c.is_ascii_alphabetic() || c == '_')
        && s.chars().all(|c| c.is_ascii_alphanumeric() || c == '_')
}

/// The phase-kernel wire the optimizer reads for `objective`: the bare name
/// itself, or the synthesized [`OBJECTIVE_WIRE`] for an inline expression.
/// Pairs with [`synthesize_phase_scope_bindings`], which emits the
/// `__objective` binding for the expression case — the two agree by sharing
/// [`objective_is_bare_wire`].
pub fn objective_wire(objective: &str) -> &str {
    if objective_is_bare_wire(objective) {
        objective.trim()
    } else {
        OBJECTIVE_WIRE
    }
}

/// Flatten a [`nmbrs_workload::model::ResultSpec`] into a single
/// Polydat source string suitable for
/// [`polydat::kernel::subcontext::SubcontextBuilder::add_result_bindings`].
/// String-shape entries pass through verbatim; map-shape entries
/// emit `<name> := <source>` lines (the same projection the
/// SRD-66 schema specifies); list-shape entries recurse.
///
/// Path-expression and built-in short forms (`count` / `ok`) in
/// map-shape entries land as bare Polydat expressions — `count` and
/// `ok` resolve to the magic-extern wires
/// [`SubcontextBuilder::add_result_bindings`] injects, while
/// path expressions like `rows[0].field` produce an unbound-
/// identifier compile error. The latter surfaces SRD-66's
/// "path expressions deferred until structural-body wire lands"
/// diagnostic.
fn collect_result_bindings_source(spec: &nmbrs_workload::model::ResultSpec) -> String {
    let mut out = String::new();
    spec.walk_fragments(|frag| match frag {
        nmbrs_workload::model::ResultFragment::Source(src) => {
            out.push_str(src);
            if !src.ends_with('\n') {
                out.push('\n');
            }
        }
        nmbrs_workload::model::ResultFragment::Named { name, source } => {
            // Path expressions (`rows[*].key`, `result[0].id`) are
            // dispenser-evaluated (SRD-70) — they are not polydat
            // source and would fail the result-bindings compile.
            // Only `count` / `ok` (magic-extern references) and
            // polydat-call entries compile into the kernel.
            let s = source.trim();
            if s == "count" || s == "ok" || s.contains('(') {
                out.push_str(&format!("{name} := {source}\n"));
            }
        }
    });
    out
}

// reason: cohesive scope builder — each argument is a distinct compile input
// (ops, iteration vars, outer manifest, workload params, …); grouping them
// into a struct would only relocate the same fields without adding clarity.
#[allow(clippy::too_many_arguments)]
pub fn build_scope(
    ops: &[ParsedOp],
    iteration_vars: &HashMap<String, String>,
    outer_manifest: &[crate::runner::ManifestEntry],
    workload_params: &HashMap<String, String>,
    phases: &HashMap<String, nmbrs_workload::model::WorkloadPhase>,
    phase_cycles: Option<&str>,
    exclude: &[String],
    // SRD-13f §"Wire-reference classification" — the parent
    // scope's compiled kernel. The synthesizer reads its
    // retained AST (for case 3 local-inclusion walks) and its
    // folded constant state (for case 1 promoted-final
    // emission). `None` for the workload-root build (it IS the
    // root; no parent).
    parent_kernel: Option<&crate::scope_kernel::ScopeKernel>,
) -> Result<BindingScope, String> {
    let mut scope = BindingScope::new();

    // --- Step 1: Classify op bindings by origin ---
    //
    // The first op's PolydatSource is the "base" (inherited/phase-level).
    // Subsequent ops: if their PolydatSource matches the base exactly,
    // they're inherited duplicates. If different, they're op-level
    // augmentations carrying new bindings.
    let mut base_source: Option<String> = None;

    for op in ops {
        if let BindingsDef::PolydatSource(src) = &op.bindings {
            let src = src.trim();
            if src.is_empty() {
                continue;
            }

            match &base_source {
                None => {
                    // First op's source becomes the base — classified as Inherited
                    base_source = Some(src.to_string());
                    scope.ingest_polydat_source(src, BindingOrigin::Inherited);
                }
                Some(base) => {
                    if src == base.as_str() {
                        // Identical to base — inherited duplicate, skip.
                        // validate() and emit() handle dedup.
                    } else {
                        // Different from base — this op has its own bindings.
                        // Ingest the DIFFERENCE (lines not in base) as Op origin,
                        // and the shared lines as Inherited. Compare by
                        // *logical* lines so multi-line expressions
                        // (function calls broken over several physical
                        // lines) stay intact instead of being split at
                        // the paren and ingested piecewise.
                        let base_logical: Vec<String> = logical_lines(base)
                            .into_iter()
                            .map(|l| l.trim().to_string())
                            .filter(|l| !l.is_empty())
                            .collect();
                        for line in logical_lines(src) {
                            let trimmed = line.trim();
                            if trimmed.is_empty() {
                                continue;
                            }
                            if base_logical.iter().any(|b| b == trimmed) {
                                // This line is inherited — already ingested from base
                            } else {
                                // This line is op-specific
                                scope.ingest_polydat_source(
                                    trimmed,
                                    BindingOrigin::Op(op.name.clone()),
                                );
                            }
                        }
                    }
                }
            }
        }
    }

    // --- Step 2: Add iteration variables ---
    //
    // Iter vars (own + cascade-inherited) are part of the
    // **scope's contract** — they're names a phase or a child
    // scope is allowed to consume. Mark them required so the
    // compiler's DCE keeps the auto-passthrough output that
    // `extern <name>` produces. Without this, an iter var
    // referenced only from a deeper structure (e.g. a relevancy
    // `k:` field, or a downstream do-while condition) would be
    // pruned and pull-by-name would fail.
    for (var, val) in iteration_vars {
        scope.add_iteration_var(var, val);
        scope.add_required_output(var);
    }

    // --- Step 3: Generate auto-externs ---
    //
    // Names referenced in op templates but not defined in the scope
    // need extern declarations to wire to the outer kernel.
    let defined = scope.defined_names();
    let extern_names = scope.extern_names();

    // Collect all referenced names from op templates AND
    // binding source RHS. Names referenced in either need
    // extern declarations so the Polydat compile path can wire
    // them. Without scanning bindings, a phase whose binding
    // RHS uses `{outer_name}` (e.g. `dim := vector_dim(
    // "{dataset}:{profile}")`) wouldn't get extern declarations
    // for `dataset` and `profile`, leaving the Polydat string
    // interpolation desugar to fail at compile time.
    let mut referenced: HashSet<String> = HashSet::new();
    for op in ops {
        for value in op.op.values() {
            if let Some(s) = value.as_str() {
                for name in nmbrs_workload::bindpoints::referenced_bindings(s) {
                    referenced.insert(name);
                }
            }
        }
        if let Some(ref cond) = op.condition {
            let bare = cond
                .trim()
                .strip_prefix('{')
                .and_then(|s| s.strip_suffix('}'))
                .unwrap_or(cond.trim());
            referenced.insert(bare.to_string());
        }
        // `delay:` accepts the same shapes as `if:` — a bare
        // wire name (`delay: think_time`) or a `{...}` inline
        // expression. Both consume a binding and need to land
        // in `referenced` so the auto-extern + DCE-keepalive
        // passes provision them.
        if let Some(ref delay_spec) = op.delay {
            for raw in delay_spec.names() {
                let bare = raw
                    .trim()
                    .strip_prefix('{')
                    .and_then(|s| s.strip_suffix('}'))
                    .unwrap_or(raw.trim());
                referenced.insert(bare.to_string());
            }
        }
        // Bindings: scan Polydat source for `{name}` placeholders
        // that the Polydat string-interpolation desugar will treat
        // as wire references.
        if let BindingsDef::PolydatSource(src) = &op.bindings {
            collect_string_interp_refs(src, &mut referenced);
            // Also scan for bare identifiers used in binding
            // RHSs (e.g. `if(optimize_for == "LATENCY", …)`).
            // Without this, names like `optimize_for` flow
            // through to the Polydat compiler unresolved and get
            // auto-externed at the compiler's default type
            // (u64); `materialize_wiring_from_outer` then writes the
            // parent's Str value into the u64-typed slot, and
            // a `__u64_to_string` adapter inserted by type
            // dispatch panics at runtime on `as_u64()`. The
            // local-binding filter below mirrors the
            // build_op_template_scope_kernel cascade — names
            // declared by THIS scope's own bindings are
            // resolved locally, not externed.
            let body_locally_declared = scan_locally_declared_idents(src);
            for ident in scan_idents_in_polydat_source(src) {
                if !body_locally_declared.contains(&ident) {
                    referenced.insert(ident);
                }
            }
        }
        // Op params (`evaluations:`/`relevancy:`/`verify:`/...
        // hoisted by the workload parser) carry `{name}` bind-
        // point references too — `relevancy: { k: "{k}" }` is
        // a real consumer of the wire `k`, even though `k`
        // isn't on the op-template wire path. Without scanning
        // these, an iter var referenced *only* from param
        // config would fail to auto-extern from the parent
        // manifest, and runtime `pull(name)` calls for that
        // wire (e.g. `parse_count_param` on relevancy `k:`)
        // would panic with "unknown output variate".
        let mut param_refs: Vec<String> = Vec::new();
        crate::bindings::collect_param_bindings_into(&op.params, &[], &mut param_refs);
        for name in param_refs {
            referenced.insert(name);
        }
    }

    // Check for final shadowing violations
    for entry in outer_manifest {
        if entry.modifier == polydat::dsl::ast::BindingModifier::CONST
            && defined.contains(&entry.name)
        {
            return Err(format!(
                "cannot shadow 'final' binding '{}' from outer scope",
                entry.name
            ));
        }
    }

    // SRD-13f §"Wire-reference classification" — case 3 (local
    // matter inclusion). When the parent program is available
    // (AST mode), promote non-final referenced names from
    // cascade-via-extern (case 2) to inline-as-Inherited.
    //
    // Rules:
    // - `final` / `shared` outputs stay cascaded (case 2-like
    //   for now; promoted-final optimization is a follow-up).
    // - Cycle bindings / init bindings whose body lives in the
    //   parent's retained AST get pretty-printed and ingested as
    //   Inherited. Transitive dependencies (RHS Ident refs)
    //   walk the same rule via `local_inclusion_chain`.
    // - Names defined by `extern` ports in the parent stay
    //   cascaded.
    //
    // The auto-extern loop below then runs as-is and fills the
    // gap for names that didn't have an AST body to pull in.
    if let Some(parent_kernel_ref) = parent_kernel {
        let parent_prog = parent_kernel_ref.program();
        // Propagate the parent's coordinate input names into this
        // scope when it doesn't already have an `input ...: u64`
        // declaration of its own. Without this, an included
        // binding like `trip := testkit_throw_at(cycle, threshold, ...)`
        // references `cycle` but the auto-extern loop emits
        // `extern cycle: u64` (extern, not coord); set_inputs
        // propagation then skips it and per-cycle ticking dies.
        //
        // Coord names are just wire names the parent declared as
        // inputs; the child propagates them by declaring the
        // same `input ...: u64` line. Nothing special about any
        // specific name here.
        if scope.coordinates.is_none() {
            let coord_count = parent_prog.coord_count();
            if coord_count > 0 {
                let input_names = parent_prog.input_names();
                let coords: Vec<String> = input_names.into_iter().take(coord_count).collect();
                scope.coordinates = Some(format_input_decl_line(&coords).trim_end().to_string());
            }
        }

        // Names already accounted for: defined locally, declared
        // extern in subscope, or iter-vars. The inclusion-chain
        // walker uses this as its termination boundary so it
        // doesn't re-emit names the scope already satisfies.
        // (Coord input names like the one the workload author
        // declared via `input ...: u64` are not special — the
        // chain walker's `binding_ast_for` returns `None` for
        // coord inputs since they aren't binding statements, so
        // they self-terminate without explicit handling here.)
        let mut already_satisfied: HashSet<String> = HashSet::new();
        already_satisfied.extend(defined.iter().cloned());
        already_satisfied.extend(extern_names.iter().cloned());
        for var in iteration_vars.keys() {
            already_satisfied.insert(var.clone());
        }

        // Sort for determinism — HashSet iteration is randomised.
        // Clone names so the loop body can mutate `referenced`
        // (collecting transitive refs from included bindings).
        let mut refs_sorted: Vec<String> = referenced.iter().cloned().collect();
        refs_sorted.sort();
        for name in &refs_sorted {
            let name = name.as_str();
            if already_satisfied.contains(name) {
                continue;
            }
            let manifest_modifier = outer_manifest
                .iter()
                .find(|e| e.name == name)
                .map(|e| e.modifier);
            let is_workload_param = workload_params.contains_key(name);
            if let Some(m) = manifest_modifier {
                use polydat::dsl::ast::BindingModifier;
                if m == BindingModifier::SHARED {
                    // SHARED stays in the cascade path — cells
                    // synchronise across kernels at runtime via
                    // SharedCell, not via const inlining.
                    continue;
                }
                if m == BindingModifier::CONST {
                    // SRD-13f §"Materialization gradient" — inline
                    // as `const NAME := <literal>` only when the
                    // upstream value is **statically known**. Per
                    // SRD-11 §"Two Evaluation Lifecycles", the
                    // `const` modifier has two implementation
                    // paths: compile-fold (the producing node is
                    // replaced with a leaf const node, value is
                    // part of the compiled artifact and identical
                    // across every activation) vs. scope-init pull
                    // (when the binding's wire chain touches
                    // iteration externs, the producing node stays
                    // as the original computation node; the value
                    // is computed per scope activation and lives
                    // only for that activation per SRD-13c
                    // §"const").
                    //
                    // The cascaded source built here gets compiled
                    // and cached on the phase scope-tree node, so
                    // its lifetime is the workload run — longer
                    // than any single activation. Inlining a
                    // scope-init-pulled value would freeze the
                    // first activation's value into the cached
                    // program forever, breaking every subsequent
                    // iteration of an enclosing comprehension
                    // (the symptom: `const mode := sm` inside a
                    // `for_each sm in alpha, beta` reads `alpha`
                    // for both iters).
                    //
                    // SRD-11 §"Provenance-Based Invalidation"
                    // gives the discriminator at zero cost: a
                    // truly statically-known node has empty input
                    // provenance (it depends on no graph inputs);
                    // a passthrough or computation node has bits
                    // set for the input slots it reads. We inline
                    // only when provenance is empty; otherwise we
                    // fall through to the auto-extern cascade
                    // below so each activation re-pulls the value
                    // through the chain via
                    // `materialize_wiring_from_outer` Step 3.
                    let statically_known = parent_kernel_ref
                        .program()
                        .output_index(name)
                        .map(|out_idx| {
                            let (node_idx, _) =
                                parent_kernel_ref.program().resolve_output_by_index(out_idx);
                            parent_kernel_ref
                                .program()
                                .input_provenance_for(node_idx)
                                .is_none_or(|p| p.is_zero())
                        })
                        .unwrap_or(true);
                    if statically_known
                        && let Some(value) = parent_kernel_ref.lookup(name)
                        && let Some(natural) = value_to_param_string(&value)
                    {
                        scope.add_param_binding(name, &natural);
                        already_satisfied.insert(name.to_string());
                        continue;
                    }
                    continue;
                }
            }
            // SRD-21 §"Where workload-param values live in the
            // kernel chain" — workload params are stable for the
            // run but live in the params-kernel as folded
            // constants, not in the workload-root program itself.
            // `parent_kernel.lookup(name)` reads through the
            // chain-wired input slot value, so this promotion
            // gives us const-folded workload-param values inside
            // every descendant scope's program — same
            // effective semantics as the pre-SRD-21 design
            // without poisoning the workload-root with `final`
            // constants that would block scenario-tree
            // shadowing.
            if is_workload_param
                && let Some(value) = parent_kernel_ref.lookup(name)
                && let Some(natural) = value_to_param_string(&value)
            {
                scope.add_param_binding(name, &natural);
                already_satisfied.insert(name.to_string());
                continue;
            }
            // Pull the inclusion chain. If the name isn't in the
            // parent's AST (or it's a final/shared binding in
            // the AST), the chain is empty — the auto-extern
            // loop below handles those.
            let chain = parent_prog.local_inclusion_chain(name, &already_satisfied);
            if chain.is_empty() {
                continue;
            }
            // Pretty-print each Statement in topological order
            // and ingest as Inherited. Track bound names so the
            // chain walker and the auto-extern loop see them
            // satisfied locally. Walk each binding's RHS to
            // collect transitive refs into `referenced` — these
            // are the names the included binding's expression
            // mentions but doesn't define (e.g. parent `final`
            // values like `dataset`); the auto-extern loop below
            // then emits externs for them.
            for stmt in chain {
                let line = polydat::dsl::pprint::pp_statement(stmt);
                scope.ingest_polydat_source(&line, BindingOrigin::Inherited);
                let body = match stmt {
                    polydat::dsl::ast::Statement::Binding(b) => Some(&b.value),
                    _ => None,
                };
                if let Some(expr) = body {
                    polydat::dsl::collect_expr_references(expr, &mut referenced);
                }
                if let polydat::dsl::ast::Statement::Binding(b) = stmt {
                    for t in &b.targets {
                        already_satisfied.insert(t.clone());
                    }
                }
            }
        }
    }

    // Refresh `defined` set after AST-mode inclusion may have
    // added Inherited bindings. The auto-extern loop below uses
    // this updated set to skip names now satisfied locally.
    let defined = scope.defined_names();

    // Generate extern declarations for referenced-but-undefined names
    for entry in outer_manifest {
        let is_iter_var = iteration_vars.contains_key(&entry.name);
        if referenced.contains(&entry.name)
            && !defined.contains(&entry.name)
            && !extern_names.contains(&entry.name)
            && !is_iter_var
        {
            let type_name = entry.port_type.to_keyword();
            scope.add_extern(&entry.name, type_name);
        }
    }

    // SRD-13f §"Wire-reference classification" — case 4:
    // unresolved → synthesizer-level validation error. Fires
    // only on descendant scopes (parent_kernel is Some). The
    // workload-root build skips this check; the Polydat compiler's
    // auto-input-inference path handles unresolved refs there.
    //
    // A reference is resolved if any of: defined locally,
    // declared extern (in subscope or auto-extern'd from outer
    // manifest), an iteration variable, a workload param key,
    // a coord name on this scope, or in the outer manifest at
    // all. Anything else is a typo or missing upstream binding.
    if parent_kernel.is_some() {
        let defined_now = scope.defined_names();
        let extern_now = scope.extern_names();
        let mut satisfied: HashSet<String> = HashSet::new();
        satisfied.extend(defined_now);
        satisfied.extend(extern_now);
        for var in iteration_vars.keys() {
            satisfied.insert(var.clone());
        }
        for name in workload_params.keys() {
            satisfied.insert(name.clone());
        }
        for entry in outer_manifest {
            satisfied.insert(entry.name.clone());
        }
        // Coord names from this scope's `input ...: u64` line.
        if let Some(coords_line) = &scope.coordinates
            && let Some(rhs) = coords_line.split(":=").nth(1)
        {
            let inner = rhs.trim().trim_start_matches('(').trim_end_matches(')');
            for n in inner.split(',') {
                let n = n.trim();
                if !n.is_empty() {
                    satisfied.insert(n.to_string());
                }
            }
        }
        // `referenced` is built from a textual scan that catches
        // both wire refs and bare identifiers — including GK
        // function names like `mod`, `hash`, `range` that
        // appear in binding RHS as call heads. Filter those out
        // via the registry lookup; only true wire references
        // should surface as unresolved.
        let mut unresolved: Vec<&String> = referenced
            .iter()
            .filter(|n| !satisfied.contains(n.as_str()))
            // Dotted names follow the field-access wire
            // convention (`q.cursor.idx` reads the wire
            // `q__cursor__idx`) — check the flattened spelling
            // the same way kernel lookup does.
            .filter(|n| !n.contains('.') || !satisfied.contains(n.replace('.', "__").as_str()))
            .filter(|n| !n.starts_with("__"))
            .filter(|n| polydat::dsl::registry::lookup(n).is_none())
            .collect();
        unresolved.sort();
        if !unresolved.is_empty() {
            let names: Vec<&str> = unresolved.iter().map(|s| s.as_str()).collect();
            let mut visible: Vec<&str> = satisfied.iter().map(|s| s.as_str()).collect();
            visible.sort();
            return Err(format!(
                "unresolved wire reference(s) {names:?}: not declared locally, \
                 not in parent manifest, not a workload param. \
                 Visible names in this scope: {visible:?}"
            ));
        }
    }

    // --- Step 4: Workload param cascade as extern slots ---
    //
    // Workload params are not the workload-root's authority — the
    // params-kernel sits one level above this scope and owns the
    // `const NAME := <literal>` declarations. The workload-root
    // program declares each param as `extern NAME: T`, and the
    // materialize-wiring-from-outer step at kernel construction
    // time copies the value out of the params-kernel's output
    // into this scope's input slot. Lookup for a param at the
    // workload-root then resolves via the input slot rather than
    // an own-folded constant — which is precisely what makes a
    // SetParam scope-tree node inserted between params-kernel
    // and workload-root able to shadow the value: its own
    // `const NAME := <override>` becomes the closer
    // materialize-source. If we baked `const NAME := <literal>`
    // here at the workload-root, that local constant would mask
    // the input slot via the get_constant fast-path in
    // PolydatKernel::lookup, and no scope-tree-level shadow could
    // get through.
    //
    // Author-declared `final` in the workload's `bindings:`
    // block is unaffected — that source goes through
    // workload_level_polydat ingestion in build_workload_root_kernel
    // and keeps whatever modifier the author wrote. Only the
    // auto-cascade of the workload `params:` block changes
    // shape.
    //
    // Phase-level build_scope callers pass an empty
    // `workload_params`; their workload params arrive via the
    // parent-scope kernel's manifest auto-extern pass.
    //
    // SRD-13f Push D: sort by name so program build order is
    // deterministic across processes. HashMap iteration is
    // randomized per process (Rust default hasher).
    let defined = scope.defined_names(); // refresh after externs
    let mut params_sorted: Vec<(&String, &String)> = workload_params.iter().collect();
    params_sorted.sort_by(|a, b| a.0.cmp(b.0));
    for (name, value) in params_sorted {
        if defined.contains(name) {
            // Author already declared `name` in the workload's
            // own bindings block. Honor the author's declaration
            // (it carries whatever modifier they wrote) and skip
            // the auto-extern — declaring an extern with the
            // same name as a local binding would be a compile
            // error.
            continue;
        }
        let type_name = workload_param_type_name(value);
        scope.add_extern(name, type_name);
        // Mark as required so DCE keeps the auto-passthrough
        // output. Descendant scopes auto-extern the param via
        // the workload-root manifest; if the workload-root's
        // own program prunes the param away, that cascade
        // breaks.
        scope.add_required_output(name);
    }
    // Also check phase config values for param refs
    for phase in phases.values() {
        if let Some(ref c) = phase.cycles
            && c.starts_with('{')
            && c.ends_with('}')
        {
            let name = &c[1..c.len() - 1];
            if workload_params.contains_key(name) && !scope.defined_names().contains(name) {
                scope.add_param_binding(name, &workload_params[name]);
            }
        }
    }

    // --- Step 5: Inline expression extraction ---
    //
    // {{expr}} in op templates becomes __expr_N bindings.
    // (Note: the op template rewriting happens separately in the caller
    // since it mutates op fields, not the scope.)
    let mut inline_idx = 0usize;
    let mut expr_to_name: HashMap<String, String> = HashMap::new();
    let mut collect = |s: &str| {
        for bp in nmbrs_workload::bindpoints::extract_bind_points(s) {
            if let nmbrs_workload::bindpoints::BindPoint::InlineDefinition(ref expr) = bp
                && !expr_to_name.contains_key(expr)
            {
                let name = format!("__expr_{inline_idx}");
                inline_idx += 1;
                expr_to_name.insert(expr.clone(), name);
            }
        }
    };
    for op in ops {
        for value in op.op.values() {
            if let Some(s) = value.as_str() {
                collect(s);
            }
        }
        // Inline expressions in `if:` and `delay:` count too —
        // those get hoisted out of `op.op` by the parser into
        // dedicated fields on `ParsedOp`.
        if let Some(s) = &op.condition {
            collect(s);
        }
        if let Some(spec) = &op.delay {
            for name in spec.names() {
                collect(name);
            }
        }
    }
    for (expr, name) in &expr_to_name {
        scope.add_inline_expr(name, expr);
    }

    // --- Step 6: Collect required outputs ---
    for op in ops {
        for value in op.op.values() {
            if let Some(s) = value.as_str() {
                for name in nmbrs_workload::bindpoints::referenced_bindings(s) {
                    if !exclude.contains(&name) {
                        scope.add_required_output(&name);
                    }
                }
            }
        }
        // Required-output collection for `if:` and `delay:`.
        //
        // The condition / delay value may be one of:
        //   1. `{{expr}}` — inline expression. Step 5 above
        //      synthesised a `__expr_N := expr` binding; the
        //      required output is that synthesised name.
        //   2. `{name}` — a single-brace binding reference.
        //   3. A bare identifier — legacy "name a binding"
        //      form, no braces.
        // The previous strip-one-pair-of-braces logic only
        // handled forms 2 and 3; for `{{expr}}` it produced a
        // half-stripped string `{expr}` that didn't match any
        // binding and let DCE drop the synthesised
        // `__expr_N`. Walk through `extract_bind_points` so
        // every form resolves to the right output name.
        let mut collect_required = |s: &str| {
            let trimmed = s.trim();
            // Bracketed forms: `{{expr}}`, `{:=expr:=}`,
            // `{name}`, `{expr-with-operators}`.
            let bps = nmbrs_workload::bindpoints::extract_bind_points(trimmed);
            if !bps.is_empty() {
                for bp in bps {
                    match bp {
                        nmbrs_workload::bindpoints::BindPoint::InlineDefinition(expr) => {
                            if let Some(name) = expr_to_name.get(&expr)
                                && !exclude.contains(name)
                            {
                                scope.add_required_output(name);
                            }
                        }
                        nmbrs_workload::bindpoints::BindPoint::Reference { name, .. } => {
                            if !exclude.contains(&name) {
                                scope.add_required_output(&name);
                            }
                        }
                    }
                }
                return;
            }
            // Bare-identifier form (no braces) — legacy.
            if !trimmed.is_empty() && !exclude.contains(&trimmed.to_string()) {
                scope.add_required_output(trimmed);
            }
        };
        if let Some(ref cond) = op.condition {
            collect_required(cond);
        }
        if let Some(ref delay_spec) = op.delay {
            for name in delay_spec.names() {
                collect_required(name);
            }
        }
        // SRD-40b §6: synthetic-metric `value:` references must
        // survive DCE so the dispenser's Polydat pull plan can resolve
        // them. Bare-name values (the SRD-40b §1 canonical form)
        // refer to a wire produced somewhere in scope; non-bare
        // expressions are deferred to Phase 9 elsewhere — for the
        // bare-name case we mark the wire required.
        for spec in op.metrics.values() {
            let trimmed = spec.value.trim();
            let bare =
                !trimmed.is_empty() && trimmed.chars().all(|c| c.is_alphanumeric() || c == '_');
            if bare && !exclude.contains(&trimmed.to_string()) {
                scope.add_required_output(trimmed);
            }
        }
        // SRD-40b §5 result-as-GK: each `result:` wire reads a
        // path expression off the response body and exposes it as
        // a Polydat wire. The wire's *name* is what subsequent
        // wrappers (metrics, validation) pull against — mark each
        // declared result wire as required so the kernel exposes
        // an extern slot for it on the post-execute write path.
        // SRD-66: result-wire names are already declared as
        // wires through the op's `bindings:` block (when the
        // workload uses `extern X: T` for shared-cell writes)
        // or are independent of the op-template kernel (when
        // the wire is consumed only by the result dispenser's
        // capture map). Marking them as required outputs here
        // would double-declare the `__port_*` for any name
        // that's also an extern, so the kernel-synthesis-side
        // wiring is left to Push 2's full kernel-driven path
        // (the SRD-66 §"Compilation lifecycle" closure-binding
        // rule). This branch intentionally does nothing for now.
        let _ = op.result.as_ref();
        crate::bindings::collect_param_bindings_into(
            &op.params,
            exclude,
            &mut scope.required_outputs,
        );
    }

    // Config refs (from cycles={expr})
    if let Some(cycles_spec) = phase_cycles
        && cycles_spec.starts_with('{')
        && cycles_spec.ends_with('}')
    {
        let mut inner = cycles_spec[1..cycles_spec.len() - 1].to_string();
        for (v, val) in iteration_vars {
            inner = inner.replace(&format!("{{{v}}}"), val);
        }
        inner = crate::runner::expand_workload_params(&inner, workload_params);
        scope.add_config_ref(&inner);
    }

    Ok(scope)
}

/// Apply iteration-variable substitution to *op-template
/// strings only* — `raw:`, `prepared:`, `stmt:`, etc.
///
/// Iter vars flow into Polydat binding source as wires (declared as
/// externs by `BindingScope::add_iteration_var` and bound at
/// runtime via the standard input mechanism), so this helper
/// **does not** touch `op.bindings`. It only rewrites the
/// op-template field values, where `{var}` placeholders refer
/// to structural elements (table names, keyspace names,
/// optimize-for hints) that adapters need as literal text —
/// not as bind variables. CQL's `prepared:` form, for example,
/// converts every remaining `{name}` in the statement to a `?`
/// bind marker; iter vars in structural positions (`INSERT
/// INTO ks.{table} ...`) must be substituted away before that
/// conversion runs, since CQL doesn't permit `?` for table
/// names.
/// SRD-68 Push 5c — validate-only walk. Same semantic as
/// [`resolve_placeholders_via_kernel`] but DOES NOT mutate the op
/// strings. Walks every `{name}` placeholder in the ops' op fields
/// and op-level params, accumulating diagnostics for unresolved
/// references; returns `Result<(), String>` describing any
/// unresolved bindpoints.
///
/// Used at phase activation as the single workload-load-time
/// validation step. Adapters now do their own cycle-time
/// resolution (CQL: construction-time structural via
/// `canonical_kernel.lookup` + cycle-time per-cycle via
/// `WireSource::get`; non-CQL: cycle-time via
/// `synthesis::resolve_cached →
/// substitute_bind_points_with_state` against `main_kernel`).
/// Mutation of the workload model is no longer load-bearing —
/// only the diagnostic surface is.
///
/// `enclosing` are the programs of the scopes around the phase — the
/// current parent and every installed ancestor. A name one of them
/// BINDS (a per-cycle workload or scenario binding, not a folded
/// constant) resolves nowhere now, yet the phase scope pulls its
/// binding in as local matter (`local_inclusion_chain`, SRD-13f case
/// 3), so it is per-cycle here exactly like a phase-declared one.
pub fn validate_placeholders_via_kernel(
    ops: &[ParsedOp],
    kernel: &dyn polydat::Kernel,
    enclosing: &[&polydat::kernel::PolydatProgram],
) -> Result<(), String> {
    let mut per_cycle_names = collect_phase_binding_lhs_names(ops);
    let nothing_excluded = HashSet::new();
    for name in collect_op_placeholder_names(ops) {
        if !per_cycle_names.contains(&name)
            && enclosing.iter().any(|program| {
                !program
                    .local_inclusion_chain(&name, &nothing_excluded)
                    .is_empty()
            })
        {
            per_cycle_names.push(name);
        }
    }

    let mut errors: Vec<String> = Vec::new();
    let in_scope = || -> Vec<String> {
        let mut names: Vec<String> = kernel.output_names();
        for n in kernel.input_names() {
            if !names.contains(&n) {
                names.push(n);
            }
        }
        names.sort();
        names
    };
    for op in ops.iter() {
        let op_name = op.name.clone();
        for (key, value) in op.op.iter() {
            let path = format!("op '{op_name}' field '{key}'");
            // Clone-then-discard: `resolve_placeholders_in_json`
            // requires `&mut serde_json::Value` but we don't
            // care about its mutations — only the `errors` it
            // accumulates. The clone is shallow per JSON value
            // and runs once per field at workload-load time.
            let mut throwaway = value.clone();
            resolve_placeholders_in_json(
                &mut throwaway,
                kernel,
                &per_cycle_names,
                &path,
                &mut errors,
            );
        }
        for (key, value) in op.params.iter() {
            if key == "gutter" {
                continue; // runtime-resolved templates (see the mutable pass below)
            }
            let path = format!("op '{op_name}' param '{key}'");
            let mut throwaway = value.clone();
            resolve_placeholders_in_json(
                &mut throwaway,
                kernel,
                &per_cycle_names,
                &path,
                &mut errors,
            );
        }
    }

    if errors.is_empty() {
        return Ok(());
    }
    let in_scope_str = in_scope().join(", ");
    let mut out =
        String::from("placeholder resolution failed (single read path: Polydat Kernel lookup):\n");
    for e in &errors {
        out.push_str("  - ");
        out.push_str(e);
        out.push('\n');
    }
    out.push_str(&format!(
        "  in-scope names at this kernel: [{in_scope_str}]"
    ));
    Err(out)
}

/// SRD-68 Push 5c — resolve `{name}` placeholders in a single
/// op's `params` against `kernel`. Used by validation wrappers
/// at construction time to pre-resolve config like `relevancy.k`
/// = `"{k}"` against their dispenser's canonical kernel, so the
/// downstream spec parsers see a literal value (`10`) rather
/// than a surviving placeholder string.
///
/// Per-cycle binding LHS names pass through unchanged — the
/// wrapper resolves those via wires at cycle time (e.g.
/// `relevancy.expected = "{ground_truth}"` stays as-is so the
/// wrapper can register it on the fixture's pull plan and
/// read it per cycle).
///
/// Single-op variant of the legacy bulk-mutation pass; the
/// per-template granularity lets each wrapper resolve against
/// its own dispenser's canonical kernel rather than a shared
/// activity-layer parent.
pub fn resolve_placeholders_in_op_params(
    op: &mut ParsedOp,
    kernel: &dyn polydat::Kernel,
) -> Result<(), String> {
    let per_cycle_names = collect_phase_binding_lhs_names(std::slice::from_ref(op));

    let mut errors: Vec<String> = Vec::new();
    let in_scope = || -> Vec<String> {
        let mut names: Vec<String> = kernel.output_names();
        for n in kernel.input_names() {
            if !names.contains(&n) {
                names.push(n);
            }
        }
        names.sort();
        names
    };
    let op_name = op.name.clone();
    for (key, value) in op.params.iter_mut() {
        // `gutter:` templates resolve at RUNTIME — during-forms per op
        // completion on the fiber wires, `final:` at phase end with a
        // status-metric fallback (`{recall}`, `{latency_p50}`) that has
        // no kernel presence here. Unresolved names degrade to visible
        // literal text in the cell, so the strict pre-resolution pass
        // must not reject them.
        if key == "gutter" {
            continue;
        }
        let path = format!("op '{op_name}' param '{key}'");
        resolve_placeholders_in_json(value, kernel, &per_cycle_names, &path, &mut errors);
    }
    if errors.is_empty() {
        return Ok(());
    }
    let in_scope_str = in_scope().join(", ");
    let mut out = String::from("param-placeholder resolution failed:\n");
    for e in &errors {
        out.push_str("  - ");
        out.push_str(e);
        out.push('\n');
    }
    out.push_str(&format!(
        "  in-scope names at this kernel: [{in_scope_str}]"
    ));
    Err(out)
}

// SRD-68 Push 5 cleanup: the legacy
// `resolve_placeholders_via_kernel` (op-field text mutation) and
// `resolve_placeholders_in_params_only` (bulk op-params mutation)
// are both retired. The executor calls
// [`validate_placeholders_via_kernel`] (pure walker) at workload
// load to surface unresolved-bindpoint diagnostics; adapters
// resolve op-field placeholders themselves at construction (CQL
// prepared via `resolve_structural_and_mark_remaining`) or at
// cycle time (CQL raw via `substitute_via_wires`); validation
// wrappers resolve their own op.params at construction via
// [`resolve_placeholders_in_op_params`] against the dispenser's
// own canonical kernel. The workload model is no longer mutated
// — `OpDispenser::describe()` returns pristine yaml.

/// Scan `ops`' `bindings:` text for the LHS names that get
/// produced as per-cycle wires. The scan is intentionally
/// liberal (LHS can be `cursor q = …`, `init x = …`, `name :=
/// expr`, `extern n: type`, `const n := expr`, `shared n := expr`,
/// destructured `(a, b) := …`). Anything that survives the LHS
/// strip becomes a known name; the substitution path uses this
/// set to distinguish "per-cycle wire — leave for the dispenser"
/// from "typo or missing cascade — error."
/// Every `{name}` placeholder the ops' fields and params reference.
fn collect_op_placeholder_names(ops: &[ParsedOp]) -> Vec<String> {
    fn walk(value: &serde_json::Value, out: &mut Vec<String>) {
        match value {
            serde_json::Value::String(s) => {
                for name in nmbrs_workload::bindpoints::referenced_bindings(s) {
                    if !out.contains(&name) {
                        out.push(name);
                    }
                }
            }
            serde_json::Value::Array(items) => items.iter().for_each(|v| walk(v, out)),
            serde_json::Value::Object(map) => map.values().for_each(|v| walk(v, out)),
            _ => {}
        }
    }
    let mut out = Vec::new();
    for op in ops {
        op.op.values().for_each(|v| walk(v, &mut out));
        op.params.values().for_each(|v| walk(v, &mut out));
    }
    out
}

fn collect_phase_binding_lhs_names(ops: &[ParsedOp]) -> Vec<String> {
    let mut out: Vec<String> = Vec::new();
    for op in ops {
        if let BindingsDef::PolydatSource(src) = &op.bindings {
            for line in logical_lines(src) {
                let trimmed = line.trim();
                if trimmed.is_empty() || trimmed.starts_with('#') {
                    continue;
                }
                // `input` declarations declare per-cycle wire names
                // by definition — the runtime sets them per
                // iteration. Both surface forms are handled:
                //   input cycle: u64
                //   input (cycle: u64, q: f64)
                // Without this, `{cycle}` in op templates would
                // resolve at compile time against the kernel's
                // initial value (0) instead of being deferred to
                // per-iteration substitution.
                if let Some(rest) = trimmed.strip_prefix("input ") {
                    let rest = rest.trim();
                    if let Some(inner) = rest.strip_prefix('(').and_then(|s| s.strip_suffix(')')) {
                        for piece in inner.split(',') {
                            let n = piece.trim().split(':').next().unwrap_or("").trim();
                            if is_bare_ident(n) && !out.contains(&n.to_string()) {
                                out.push(n.to_string());
                            }
                        }
                    } else {
                        let n = rest.split(':').next().unwrap_or("").trim();
                        if is_bare_ident(n) && !out.contains(&n.to_string()) {
                            out.push(n.to_string());
                        }
                    }
                    continue;
                }
                let lhs_end = trimmed
                    .find(":=")
                    .or_else(|| trimmed.find('='))
                    .unwrap_or(trimmed.len());
                let mut lhs = &trimmed[..lhs_end];
                // Strip ALL leading wire-coloring modifiers in
                // any order. `volatile final` and `final shared`
                // both need their bare name extracted, and any
                // future modifier added to the SRD-10 set must
                // appear here too.
                loop {
                    let mut matched = false;
                    for prefix in [
                        "cursor ",
                        "init ",
                        "extern ",
                        "const ",
                        "final ",
                        "shared ",
                        "volatile ",
                        "private ",
                    ] {
                        if let Some(stripped) = lhs.strip_prefix(prefix) {
                            lhs = stripped.trim();
                            matched = true;
                            break;
                        }
                    }
                    if !matched {
                        break;
                    }
                }
                let lhs = lhs.trim();
                // Destructured tuple LHS: (a, b, c) := ...
                if let Some(inner) = lhs.strip_prefix('(').and_then(|s| s.strip_suffix(')')) {
                    for piece in inner.split(',') {
                        let n = piece.trim().trim_end_matches(':').trim();
                        if is_bare_ident(n) && !out.contains(&n.to_string()) {
                            out.push(n.to_string());
                        }
                    }
                    continue;
                }
                // Type-annotated single LHS: `name: type`.
                let bare = lhs.split(':').next().unwrap_or(lhs).trim();
                if is_bare_ident(bare) && !out.contains(&bare.to_string()) {
                    out.push(bare.to_string());
                }
            }
        }
    }
    out
}

fn is_bare_ident(s: &str) -> bool {
    let mut chars = s.chars();
    match chars.next() {
        Some(c) if c.is_ascii_alphabetic() || c == '_' => {}
        _ => return false,
    }
    chars.all(|c| c.is_ascii_alphanumeric() || c == '_')
}

/// True iff `s` is a polydat string literal — opens with `"`,
/// closes with `"`, and (conservatively) contains no
/// unescaped closing quote in the middle. This is the shape
/// `format_jval_as_polydat_literal` produces for YAML strings
/// (`"hello"`) so the param-binding classifier can pass it
/// through without re-quoting.
fn is_polydat_quoted_string(s: &str) -> bool {
    if s.len() < 2 {
        return false;
    }
    if !s.starts_with('"') || !s.ends_with('"') {
        return false;
    }
    // Walk the inner span; reject if we find an unescaped `"`
    // before the final character (which would mean the outer
    // quotes don't actually pair).
    let bytes = s.as_bytes();
    let mut i = 1;
    let last = bytes.len() - 1;
    while i < last {
        if bytes[i] == b'\\' {
            i += 2;
            continue;
        }
        if bytes[i] == b'"' {
            return false;
        }
        i += 1;
    }
    true
}

/// True iff `s` looks like a polydat array literal: `[` …
/// matched brackets … `]`. Conservative — we don't validate
/// the elements here; the polydat parser handles that when
/// the `const X := [...]` line compiles. The check just
/// distinguishes "this is already polydat array syntax" from
/// "this is a raw string that happens to contain brackets".
fn is_polydat_array_literal(s: &str) -> bool {
    if !s.starts_with('[') || !s.ends_with(']') {
        return false;
    }
    let mut depth: i32 = 0;
    let mut in_string = false;
    let mut escape = false;
    for c in s.chars() {
        if escape {
            escape = false;
            continue;
        }
        if in_string {
            if c == '\\' {
                escape = true;
            } else if c == '"' {
                in_string = false;
            }
            continue;
        }
        match c {
            '"' => in_string = true,
            '[' => depth += 1,
            ']' => {
                depth -= 1;
                if depth < 0 {
                    return false;
                }
            }
            _ => {}
        }
    }
    depth == 0
}

#[cfg(test)]
mod polydat_param_classifier_tests {
    use super::*;

    #[test]
    fn scan_idents_skips_hash_comments() {
        // `#` is a YAML-style line comment in Polydat (dsl/lexer.rs).
        // The ident scanner must skip it too, or comment words leak in
        // as phantom wire references (regression: finalize_index's
        // bindings comments).
        let src = "# Forwarding bindings: allow-list = bindings + params\n\
                   pct := mul(active, 2)  # trailing comment with words\n";
        let idents = scan_idents_in_polydat_source(src);
        assert!(
            idents.contains("active"),
            "real ident must be found: {idents:?}"
        );
        for word in [
            "Forwarding",
            "bindings",
            "allow",
            "list",
            "params",
            "trailing",
            "comment",
            "words",
        ] {
            assert!(
                !idents.contains(word),
                "comment word '{word}' must not be scanned as a wire ref: {idents:?}"
            );
        }
    }

    #[test]
    fn scan_idents_skips_block_conditional_keywords() {
        // Block-form conditional selection puts bare `if` / `else` in expression
        // position. This scanner is textual, so without the keyword entries they were
        // emitted as wire references and the phase failed with
        // `unresolved wire reference(s) ["else", "if"]` (regression: finalize_index's
        // seg_mib_mean binding).
        let src = "seg_mib_mean := if segments > 0 { total / max(segments, 1) } else { 0 }\n";
        let idents = scan_idents_in_polydat_source(src);
        assert!(
            idents.contains("segments"),
            "real wire must still be found: {idents:?}"
        );
        assert!(
            idents.contains("total"),
            "real wire must still be found: {idents:?}"
        );
        for kw in ["if", "else"] {
            assert!(
                !idents.contains(kw),
                "conditional keyword '{kw}' must not scan as a wire ref: {idents:?}"
            );
        }
    }

    #[test]
    fn scan_locally_declared_skips_hash_comment_lines() {
        let src = "# total = sum of parts\n\
                   shared sstables := 0\n";
        let decls = scan_locally_declared_idents(src);
        assert!(decls.contains("sstables"));
        // `# total = ...` has an `=`; it must not be parsed as a decl.
        assert!(
            !decls.contains("total"),
            "comment LHS must not declare: {decls:?}"
        );
    }

    #[test]
    fn bare_identifier_classifier_accepts_idents_and_rejects_other_shapes() {
        assert!(is_bare_ident("sm"));
        assert!(is_bare_ident("source_model"));
        assert!(is_bare_ident("k_values"));
        assert!(is_bare_ident("_underscore"));
        assert!(is_bare_ident("a1"));
        // Rejects strings that don't fit the ident grammar.
        assert!(!is_bare_ident(""));
        assert!(!is_bare_ident("1abc"), "ident can't start with digit");
        assert!(!is_bare_ident("foo bar"), "no spaces");
        assert!(!is_bare_ident("[a, b]"));
        assert!(!is_bare_ident("\"quoted\""));
        assert!(!is_bare_ident("foo+bar"));
        // Reserved-ish keywords stay valid as identifiers here;
        // the polydat parser is the authority on what's
        // reserved.
        assert!(is_bare_ident("true"));
        assert!(is_bare_ident("false"));
    }

    #[test]
    fn polydat_quoted_string_accepts_paired_quotes_only() {
        assert!(is_polydat_quoted_string("\"hello\""));
        assert!(is_polydat_quoted_string("\"\""));
        assert!(is_polydat_quoted_string("\"with \\\"escaped\\\" inner\""));
        // Rejects shapes that aren't paired-quote.
        assert!(!is_polydat_quoted_string("hello"));
        assert!(!is_polydat_quoted_string("\"open-only"));
        assert!(!is_polydat_quoted_string("close-only\""));
        assert!(!is_polydat_quoted_string(""));
        assert!(!is_polydat_quoted_string("\""));
    }

    #[test]
    fn polydat_array_literal_balances_brackets() {
        assert!(is_polydat_array_literal("[1, 2, 3]"));
        assert!(is_polydat_array_literal("[]"));
        assert!(
            is_polydat_array_literal("[[1, 2], [3, 4]]"),
            "nested arrays balance"
        );
        assert!(is_polydat_array_literal("[\"a\", \"b\"]"));
        // Strings containing `]` don't break the count.
        assert!(is_polydat_array_literal("[\"a]b\", \"c\"]"));
        // Rejects unbalanced shapes.
        assert!(!is_polydat_array_literal("[1, 2"));
        assert!(!is_polydat_array_literal("1, 2]"));
        // `[1][2]` passes the conservative shape check (depth
        // returns to zero) — polydat's parser rejects it
        // downstream as invalid syntax. The classifier is a
        // routing heuristic, not a validator.
    }
}

/// Recursively walk a JSON value and resolve every `{name}`
/// placeholder via [`KernelLookup`](polydat::kernel::interp::KernelLookup). Non-resolving names
/// that are in the per-cycle binding set stay as-is (the
/// dispenser will resolve them at execute time); anything else
/// gets pushed onto `errors`.
///
/// Object keys are *not* rewritten — keys are the closed-vocab
/// field name surface, distinct from the value-bearing
/// placeholders.
fn resolve_placeholders_in_json(
    value: &mut serde_json::Value,
    kernel: &dyn polydat::Kernel,
    per_cycle_names: &[String],
    field_path: &str,
    errors: &mut Vec<String>,
) {
    match value {
        serde_json::Value::String(s) => {
            match resolve_placeholders_in_string(s, kernel, per_cycle_names, field_path) {
                Ok(out) => *value = serde_json::Value::String(out),
                Err(es) => errors.extend(es),
            }
        }
        serde_json::Value::Array(arr) => {
            for (i, v) in arr.iter_mut().enumerate() {
                let p = format!("{field_path}[{i}]");
                resolve_placeholders_in_json(v, kernel, per_cycle_names, &p, errors);
            }
        }
        serde_json::Value::Object(map) => {
            for (k, v) in map.iter_mut() {
                let p = format!("{field_path}.{k}");
                resolve_placeholders_in_json(v, kernel, per_cycle_names, &p, errors);
            }
        }
        _ => {}
    }
}

/// Walk one string, replace each `{name}` placeholder with the
/// kernel's `lookup` result for `name`. Bare-ident-only — the
/// qualified `{bind:…}` / `{capture:…}` / `{input:…}` /
/// `{param:…}` shapes and the inline `{{expr}}` shape pass
/// through untouched (consumed downstream by the dispenser /
/// inline-expression desugar). Names that fall through to the
/// per-cycle binding set also pass through. Anything else is
/// returned as an error in the `Err` Vec, with the field path
/// for context.
fn resolve_placeholders_in_string(
    s: &str,
    kernel: &dyn polydat::Kernel,
    per_cycle_names: &[String],
    field_path: &str,
) -> Result<String, Vec<String>> {
    let bytes = s.as_bytes();
    let n = bytes.len();
    let mut out = String::with_capacity(n);
    let mut errors: Vec<String> = Vec::new();
    let mut i = 0;
    while i < n {
        // `\{` and `\}` are escapes — passthrough one char.
        if bytes[i] == b'\\' && i + 1 < n && (bytes[i + 1] == b'{' || bytes[i + 1] == b'}') {
            out.push(bytes[i] as char);
            out.push(bytes[i + 1] as char);
            i += 2;
            continue;
        }
        // `{{ ... }}` is an inline expression — passthrough.
        if i + 1 < n && bytes[i] == b'{' && bytes[i + 1] == b'{' {
            // Find the matching `}}`.
            let start = i;
            let mut j = i + 2;
            while j + 1 < n && !(bytes[j] == b'}' && bytes[j + 1] == b'}') {
                j += 1;
            }
            let end = (j + 2).min(n);
            out.push_str(&s[start..end]);
            i = end;
            continue;
        }
        if bytes[i] != b'{' {
            out.push(bytes[i] as char);
            i += 1;
            continue;
        }
        // Find the matching `}` for this `{`.
        let body_start = i + 1;
        let mut j = body_start;
        while j < n && bytes[j] != b'}' {
            j += 1;
        }
        if j >= n {
            // Unterminated `{` — treat as literal char and move on.
            out.push('{');
            i += 1;
            continue;
        }
        let body = &s[body_start..j];
        let after = j + 1;

        // Qualified references stay as-is for downstream.
        if body.contains(':') {
            out.push('{');
            out.push_str(body);
            out.push('}');
            i = after;
            continue;
        }

        // Empty body — leave as-is, validator catches.
        if body.is_empty() {
            out.push('{');
            out.push_str(body);
            out.push('}');
            i = after;
            continue;
        }

        // Not a bare identifier — pass through (could be a format spec).
        if !is_bare_ident(body) {
            out.push('{');
            out.push_str(body);
            out.push('}');
            i = after;
            continue;
        }

        // Names that are per-cycle (coordinates declared via
        // `input (cycle: u64, ...: u64)`, or LHS of phase bindings)
        // MUST be deferred to per-cycle resolution. Their value
        // varies per iteration; pre-resolving against the parent
        // kernel here would bake in iteration 0's value (0) and
        // every subsequent iteration would emit the same string.
        if per_cycle_names.iter().any(|n| n == body) {
            out.push('{');
            out.push_str(body);
            out.push('}');
            i = after;
            continue;
        }
        // Bare ident — try kernel lookup. Computed outputs
        // (node-backed) aren't found by `lookup` (it only reads
        // input slots + constants), but they ARE valid wires
        // visible at this scope — accept them by checking
        // `resolve_output`. Per-cycle resolution at dispenser
        // time handles the actual pull.
        match polydat::kernel::interp::Lookup::lookup(
            &polydat::kernel::interp::KernelLookup::new(kernel),
            body,
        ) {
            Some(v) => out.push_str(&v.to_display_string()),
            None if kernel.output_index(body).is_some() => {
                // Defer to per-cycle resolution. Emit the
                // placeholder unchanged.
                out.push('{');
                out.push_str(body);
                out.push('}');
            }
            None => {
                errors.push(format!(
                    "{field_path}: '{{{body}}}' did not resolve in scope and is \
                     not a per-cycle binding declared by this phase"
                ));
                // Still push the placeholder as-is so the rest of
                // the string remains parseable for further error
                // collection on the same field.
                out.push('{');
                out.push_str(body);
                out.push('}');
            }
        }
        i = after;
    }

    if errors.is_empty() {
        Ok(out)
    } else {
        Err(errors)
    }
}

/// Rewrite inline expressions (`{{expr}}`) in op template strings to
/// use named binding references (`{__expr_N}`).
///
/// Returns the expression-to-name map for the caller to know what
/// was rewritten.
pub fn rewrite_inline_exprs(ops: &mut [ParsedOp]) -> HashMap<String, String> {
    // SRD-13d: each op template is its own Polydat scope. Inline
    // `{{<expr>}}` rewrites are Polydat matter that belongs to the
    // op-template scope, not to the shared phase scope. So each
    // op gets its OWN expression-to-name mapping, with
    // op-locally unique synth names — no cross-op dedup. Two ops
    // with textually identical inline expressions
    // (`if: cql_dialect == 'vendor'` on both `indexes_present_vendor`
    // and `indexes_built_vendor`) now get distinct
    // `__expr_N`/`__expr_M` names. Without this, both ops
    // injected the same `__expr_1 := cql_dialect == 'vendor'`
    // line into their bindings; the phase-scope ingest then saw
    // two ops each declaring `__expr_1` and tripped the
    // ride-along-uniqueness check (SRD-13c §"Op overriding op
    // shadow").
    //
    // The global `inline_idx` counter still increments
    // monotonically so synth names are workload-wide unique;
    // the per-op MAP keeps within-op dedup (same expression in
    // multiple fields of one op — `if: x == 1` and
    // `metric: x == 1` — collapses to a single `__expr_N` for
    // that op).
    let mut inline_idx = 0usize;
    let mut per_op_expr_to_name: Vec<HashMap<String, String>> =
        (0..ops.len()).map(|_| HashMap::new()).collect();
    let collect_from = |s: &str, idx: &mut usize, op_map: &mut HashMap<String, String>| {
        for bp in nmbrs_workload::bindpoints::extract_bind_points(s) {
            if let nmbrs_workload::bindpoints::BindPoint::InlineDefinition(ref expr) = bp {
                op_map.entry(expr.clone()).or_insert_with(|| {
                    let n = format!("__expr_{idx}");
                    *idx += 1;
                    n
                });
            }
        }
    };
    for (op_index, op) in ops.iter().enumerate() {
        let op_map = &mut per_op_expr_to_name[op_index];
        for value in op.op.values() {
            if let Some(s) = value.as_str() {
                collect_from(s, &mut inline_idx, op_map);
            }
        }
        if let Some(s) = &op.condition {
            collect_from(s, &mut inline_idx, op_map);
        }
        if let Some(spec) = &op.delay {
            for name in spec.names() {
                collect_from(name, &mut inline_idx, op_map);
            }
        }
    }
    // For diagnostics + downstream: the legacy single
    // `expr_to_name` return value flattens the per-op maps.
    // Names are unique across ops because the inline_idx
    // counter is global, so the union is collision-free.
    let expr_to_name: HashMap<String, String> = per_op_expr_to_name
        .iter()
        .flat_map(|m| m.iter().map(|(k, v)| (k.clone(), v.clone())))
        .collect();

    // Inject the synthesised `__expr_N := expr` bindings into
    // the first op's Polydat bindings source so `build_scope`'s
    // normal ingestion pass picks them up. Without this the
    // op fields get rewritten to reference `{__expr_N}` but
    // no binding declaring `__expr_N` ever lands in the
    // scope, so compilation fails with "unresolved bind
    // point '{__expr_N}'". Callers used to discard the
    // returned `expr_to_name` mapping and trust some other
    // path to install the bindings — there isn't one. Doing
    // the injection here keeps `rewrite_inline_exprs`
    // self-contained: every output rewrite has a matching
    // binding emitted.
    // Inject + rewrite per op. Each op uses ONLY its own
    // expr_to_name mapping (per_op_expr_to_name[op_index]).
    // Synth lines land in that op's bindings; field rewrites
    // see only that op's expression names. SRD-13d: the
    // op-template scope owns its own Polydat matter, including
    // synth bindings from inline expressions.
    if expr_to_name.is_empty() {
        return expr_to_name;
    }
    use nmbrs_workload::model::BindingsDef;
    for (op_index, op) in ops.iter_mut().enumerate() {
        let op_map = &per_op_expr_to_name[op_index];
        if op_map.is_empty() {
            continue;
        }

        // Build synth lines for this op, deterministically
        // ordered by synth name.
        let mut entries: Vec<(&String, &String)> = op_map.iter().collect();
        entries.sort_by(|a, b| a.1.cmp(b.1));
        let mut synth_lines = String::new();
        for (expr, name) in &entries {
            synth_lines.push_str(&format!("\n{name} := {expr}"));
        }

        // Inject into op.bindings. Map → PolydatSource conversion
        // mirrors the existing scope-source assembly path.
        match &mut op.bindings {
            BindingsDef::PolydatSource(s) => {
                if s.trim().is_empty() {
                    *s = synth_lines.trim_start_matches('\n').to_string();
                } else {
                    s.push_str(&synth_lines);
                }
            }
            BindingsDef::Map(_) => {
                if let BindingsDef::Map(map) = &op.bindings {
                    let mut existing = String::new();
                    for (k, v) in map.iter() {
                        existing.push_str(&format!("{k} := {v}\n"));
                    }
                    op.bindings = BindingsDef::PolydatSource(format!("{existing}{synth_lines}"));
                }
            }
        }

        // Rewrite this op's fields using its own mapping only.
        let rewrite = |s: &str| -> String {
            let mut rewritten = s.to_string();
            for (expr, name) in op_map {
                rewritten = rewritten.replace(&format!("{{{{{expr}}}}}"), &format!("{{{name}}}"));
                rewritten = rewritten.replace(&format!("{{:={expr}:=}}"), &format!("{{{name}}}"));
                rewritten = rewritten.replace(&format!("{{:={expr}}}"), &format!("{{{name}}}"));
                rewritten = rewritten.replace(&format!("{{{expr}}}"), &format!("{{{name}}}"));
            }
            rewritten
        };
        for value in op.op.values_mut() {
            if let Some(s) = value.as_str() {
                *value = serde_json::Value::String(rewrite(s));
            }
        }
        if let Some(s) = &op.condition {
            op.condition = Some(rewrite(s));
        }
        if let Some(spec) = &op.delay {
            // Rewrite each binding name in place, preserving
            // the spec's enum shape (Before vs BeforeAfter).
            op.delay = Some(match spec {
                nmbrs_workload::model::DelaySpec::Before(name) => {
                    nmbrs_workload::model::DelaySpec::Before(rewrite(name))
                }
                nmbrs_workload::model::DelaySpec::BeforeAfter { before, after } => {
                    nmbrs_workload::model::DelaySpec::BeforeAfter {
                        before: before.as_deref().map(rewrite),
                        after: after.as_deref().map(rewrite),
                    }
                }
            });
        }
    }

    expr_to_name
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_polydat_op(name: &str, stmt: &str, bindings: &str) -> ParsedOp {
        let mut op = ParsedOp::simple(name, stmt);
        op.bindings = BindingsDef::PolydatSource(bindings.to_string());
        op
    }

    #[test]
    fn objective_bare_wire_vs_inline_expression() {
        // Bare identifiers are read directly off the phase kernel.
        assert!(objective_is_bare_wire("score"));
        assert!(objective_is_bare_wire("err_rate"));
        assert!(objective_is_bare_wire("_objective"));
        assert!(objective_is_bare_wire("  recall99  ")); // trimmed
        assert_eq!(objective_wire("score"), "score");
        assert_eq!(objective_wire("  recall99  "), "recall99");

        // Anything with operators / calls / dots / spaces is an inline
        // expression → synthesized to the `__objective` wire.
        assert!(!objective_is_bare_wire("0 - err_rate"));
        assert!(!objective_is_bare_wire("metricsql_scalar(\"x\")"));
        assert!(!objective_is_bare_wire("a - b"));
        assert!(!objective_is_bare_wire("q.cursor.depth"));
        assert!(!objective_is_bare_wire(""));
        assert_eq!(objective_wire("0 - err_rate"), OBJECTIVE_WIRE);
        assert_eq!(objective_wire("metricsql_scalar(\"x\")"), OBJECTIVE_WIRE);
    }

    #[test]
    fn inline_objective_synthesizes_volatile_objective_binding() {
        use nmbrs_workload::model::{BindingsDef, OptimizeBlock, WorkloadPhase};
        let phase = WorkloadPhase {
            for_each: Some("rate in 1000, 2000".to_string()),
            bindings: BindingsDef::PolydatSource("input cycle: u64\n".to_string()),
            optimize: Some(OptimizeBlock {
                method: "sweep".to_string(),
                objective: "0 - metricsql_scalar(\"sum(rate(errors_total[3s]))\")".to_string(),
                servo: vec!["rate".to_string()],
                max_evals: 10,
                seed: 0,
                params: Default::default(),
            }),
            ..Default::default()
        };
        let out = synthesize_phase_scope_bindings(&phase).expect("synthesis ok");
        let src = match out {
            BindingsDef::PolydatSource(s) => s,
            other => panic!("expected PolydatSource, got {other:?}"),
        };
        assert!(
            src.contains("volatile __objective := 0 - metricsql_scalar("),
            "inline objective must be lowered to a `__objective` binding:\n{src}"
        );

        // A bare-name objective is NOT synthesized — read directly.
        let mut bare = phase.clone();
        bare.optimize.as_mut().unwrap().objective = "score".to_string();
        let bare_out = synthesize_phase_scope_bindings(&bare).expect("synthesis ok");
        if let BindingsDef::PolydatSource(s) = bare_out {
            assert!(
                !s.contains("__objective"),
                "bare objective must not synthesize:\n{s}"
            );
        }
    }

    #[test]
    fn inherited_bindings_dedup_across_ops() {
        let bindings = "input cycle: u64\nprofiles := matching_profiles(\"example\", \"label\")";
        let ops = vec![
            make_polydat_op("op_a", "{profiles}", bindings),
            make_polydat_op("op_b", "{profiles}", bindings),
        ];
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &[],
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .unwrap();
        scope.validate().unwrap();
        let emitted = scope.emit();
        // 'profiles' should appear exactly once
        let count = emitted.matches("profiles :=").count();
        assert_eq!(
            count, 1,
            "expected exactly 1 'profiles :=' in emitted scope, got {count}:\n{emitted}"
        );
    }

    #[test]
    fn iteration_vars_dont_conflict_with_inherited() {
        let bindings = "input cycle: u64\nprofiles := matching_profiles(\"example\", \"label\")";
        let ops = vec![
            make_polydat_op("op_a", "{profiles} {table}", bindings),
            make_polydat_op("op_b", "{profiles} {table}", bindings),
        ];
        let mut iter_vars = HashMap::new();
        iter_vars.insert("table".to_string(), "vec_default".to_string());

        let scope = build_scope(
            &ops,
            &iter_vars,
            &[],
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .unwrap();
        scope.validate().unwrap();
        let emitted = scope.emit();
        // Iteration variables now declare as `extern <name>:
        // <Type>` so the runtime can populate them per iteration
        // without recompiling (SRD 18b §"Iteration variables as
        // scope outputs"). Type is inferred from the value;
        // "vec_default" doesn't parse numerically → String.
        assert!(
            emitted.contains("extern table: String"),
            "expected extern table declaration in:\n{emitted}"
        );
        assert!(
            emitted.contains("profiles :="),
            "expected profiles in:\n{emitted}"
        );
    }

    #[test]
    fn op_augmentation_adds_new_names() {
        let base = "input cycle: u64\nfoo := hash(cycle)";
        let augmented = "input cycle: u64\nfoo := hash(cycle)\nbar := mod(cycle, 100)";
        let ops = vec![
            make_polydat_op("op_a", "{foo}", base),
            make_polydat_op("op_b", "{foo} {bar}", augmented),
        ];
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &[],
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .unwrap();
        scope.validate().unwrap();
        let emitted = scope.emit();
        assert!(emitted.contains("foo := hash(cycle)"), "missing foo");
        assert!(emitted.contains("bar := mod(cycle, 100)"), "missing bar");
    }

    #[test]
    fn real_shadow_is_caught() {
        let base = "input cycle: u64\nfoo := hash(cycle)";
        let shadow = "input cycle: u64\nfoo := mod(cycle, 100)";
        let ops = vec![
            make_polydat_op("op_a", "{foo}", base),
            make_polydat_op("op_b", "{foo}", shadow),
        ];
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &[],
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .unwrap();
        let result = scope.validate();
        assert!(result.is_err(), "expected shadow error");
        let err = result.unwrap_err();
        assert!(
            err.contains("shadows"),
            "expected 'shadows' in error: {err}"
        );
        assert!(err.contains("op_b"), "expected op name in error: {err}");
    }

    #[test]
    fn original_bug_repro_no_false_shadow() {
        // The original bug: workload-level bindings with profiles,
        // inherited by a phase with for_each iteration vars.
        // Two ops share identical inherited bindings.
        // The init injection used to make them differ, causing false shadow.
        let bindings = "input cycle: u64\nprofiles := matching_profiles(\"example\", \"label\")";
        let ops = vec![
            make_polydat_op(
                "drop_metadata_index",
                "DROP INDEX {table}_meta_idx",
                bindings,
            ),
            make_polydat_op("drop_vector_index", "DROP INDEX {table}_idx", bindings),
            make_polydat_op("drop_table", "DROP TABLE {table}", bindings),
        ];
        let mut iter_vars = HashMap::new();
        iter_vars.insert("table".to_string(), "fknn_default".to_string());
        iter_vars.insert("spec".to_string(), "example:default".to_string());
        iter_vars.insert("optimize_for".to_string(), "RECALL".to_string());

        let scope = build_scope(
            &ops,
            &iter_vars,
            &[],
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .unwrap();
        // This was the bug: validate() used to fail with false shadow error
        scope.validate().unwrap();
        let emitted = scope.emit();
        // Iter vars now declare as extern (SRD 18b). The original
        // bug — false-shadow detection — is unchanged regardless
        // of how the iter var materialises.
        assert!(
            emitted.contains("extern table: String"),
            "missing extern table in:\n{emitted}"
        );
        assert!(emitted.contains("profiles :="), "missing profiles");
        // profiles should appear exactly once
        let count = emitted.matches("profiles :=").count();
        assert_eq!(count, 1, "profiles duplicated in:\n{emitted}");
    }

    // ── SRD-13d Phase 9 cross-scope contract check ──────────

    fn parent_kernel_with_load() -> crate::scope_kernel::ScopeKernel {
        // Parent has `cycle` input, a folded constant `dim`, a
        // shared output `budget`, and a dynamic output `load`
        // (cycle-dependent, no modifier). Each shape exercises
        // a different `ParentRefKind` arm.
        crate::bindings::compile_scope_kernel(
            "input cycle: u64\n\
             const dim := 128\n\
             shared budget := 100\n\
             load := add(cycle, 1)\n",
            &Default::default(),
        )
        .expect("compile parent")
    }

    fn op_with_body(name: &str, body: &str) -> ParsedOp {
        let mut op = ParsedOp::simple(name, "noop");
        op.bindings = BindingsDef::PolydatSource(body.into());
        op
    }

    #[test]
    fn op_template_referencing_cycle_input_is_accepted() {
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let op = op_with_body("step_op", "step := add(cycle, 1)\n");
        let result = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "test",
        );
        assert!(
            result.is_ok(),
            "cycle is a parent input — should be accepted. err: {:?}",
            result.err()
        );
    }

    /// Localises the metric-wiring defect: when an op-template kernel is
    /// materialised, does the synthesised `__metric_<name>` binding surface as
    /// an output on THAT kernel? The metrics wrapper reads it through
    /// `ctx.wires`, so if it is absent the wrapper reports
    /// "did not resolve through ctx.wires".
    #[test]
    fn op_template_kernel_exposes_synthesised_metric_bindings() {
        use nmbrs_workload::model::MetricSpec;
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let mut op = op_with_body("m_op", "measured := add(cycle, 1)\n");
        op.metrics.insert(
            "bytes_out".to_string(),
            MetricSpec {
                value: "measured".into(),
                family: None,
                kind: None,
                unit: None,
                format: None,
                cell: Default::default(),
            },
        );
        let kernel = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "test",
        )
        .expect("op-template kernel builds");
        let outs = kernel.program().output_names();
        assert!(
            outs.contains(&"__metric_bytes_out"),
            "the synthesised metric binding must be an output of the \
             op-template kernel; outputs: {outs:?}"
        );
    }

    #[test]
    fn op_template_referencing_constant_output_is_accepted() {
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        // `dim` is a `final` (folded) output — snapshot is final,
        // per-cycle changes are impossible by construction.
        let op = op_with_body("calc_op", "scaled := mul(dim, 2)\n");
        let result = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "test",
        );
        assert!(
            result.is_ok(),
            "final/folded output should be accepted. err: {:?}",
            result.err()
        );
    }

    #[test]
    fn op_template_referencing_shared_output_is_accepted() {
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        // `budget` is `shared` — SharedCell carries live updates.
        let op = op_with_body("budget_op", "remaining := add(budget, 1)\n");
        let result = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "test",
        );
        assert!(
            result.is_ok(),
            "shared output should be accepted. err: {:?}",
            result.err()
        );
    }

    #[test]
    fn op_template_referencing_dynamic_output_accepted_per_srd_13f() {
        // SRD-13f retires SRD-13c's "DynamicOutput without
        // shared" rejection. The read invariant is uniform —
        // inner reads of cross-scope wires return outer's
        // current value via construction-time wiring (cells
        // for shared, per-cycle refresh / planned cell
        // mechanism for non-shared). The op-template
        // synthesiser accepts the reference; the wiring keeps
        // the invariant intact at cycle time.
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let op = op_with_body("forecast_op", "forecast := mul(load, 2)\n");
        let kernel = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "test",
        )
        .expect("op-template kernel synth should accept dynamic parent ref");
        // The op-template kernel carries `load` as an extern
        // input — the construction-time wiring set up the slot;
        // per-cycle refresh keeps it current with outer.
        assert!(
            kernel.program().find_input("load").is_some(),
            "extern load slot should land on op-template kernel"
        );
        // And `forecast`, the op-local binding, is an output.
        assert!(
            kernel.program().output_names().contains(&"forecast"),
            "op-local binding should be an output"
        );
    }

    #[test]
    fn op_template_pvs_query_full_shape_with_workload_params() {
        // Closer to the actual full_cql_vector.yaml shape: the
        // op carries `prepared:` text with `{keyspace}.{table}`
        // / `{predicate}` / `{query_vector}` / `{limit}` interp
        // bind-points, plus a `metrics: overscan: {value:
        // overscan}` declaration. workload_params carries
        // dataset/profile/keyspace via `final` injection. The
        // op-template synthesiser must emit the latency_factor /
        // recall_factor / overscan bindings as outputs so the
        // metrics fixture's `register_pull("overscan")`
        // resolves.
        use nmbrs_workload::model::MetricSpec;
        let parent_src = r#"
extern k: u64
extern limit: u64
extern optimize_for: String
extern table: String
"#;
        let parent = crate::bindings::compile_scope_kernel(
            parent_src,
            &polydat::dsl::compile::CompileOptions {
                context: "parent".to_string(),
                ..Default::default()
            },
        )
        .expect("parent compile");
        let manifest: Vec<crate::runner::ManifestEntry> =
            polydat::kernel::extract_manifest(parent.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let body = "const prebuffered := dataset_prebuffer(\"{dataset}:{profile}\")\n\
            const query_counts := query_count(prebuffered)\n\
            cursor q = range(0, query_counts * 10)\n\
            query_vector := query_vector_at(prebuffered, q % query_counts)\n\
            predicate := predicate_value_at(prebuffered, q % query_counts)\n\
            ground_truth := filtered_neighbor_indices_at(prebuffered, q % query_counts)\n\
            latency_factor := 0.979 + 4.021 * pow(limit, -0.761)\n\
            recall_factor  := 0.509 + 9.491 * pow(limit, -0.402)\n\
            overscan := if(optimize_for == \"LATENCY\", latency_factor, recall_factor)\n";
        let mut op = op_with_body("select_ann", body);
        // Mirror op fields the YAML carries.
        op.op.insert(
            "prepared".into(),
            serde_json::json!(
                "SELECT key,value FROM {keyspace}.{table} \
             WHERE metadata = {predicate} \
             ORDER BY value ANN OF {query_vector} LIMIT {limit}"
            ),
        );
        op.metrics.insert(
            "overscan".into(),
            MetricSpec {
                value: "overscan".into(),
                family: None,
                kind: None,
                unit: None,
                format: None,
                cell: Default::default(),
            },
        );
        let mut workload_params = HashMap::new();
        workload_params.insert("dataset".into(), "example".into());
        workload_params.insert("profile".into(), "label_00".into());
        workload_params.insert("keyspace".into(), "baselines".into());
        let kernel = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &workload_params,
            vec![],
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "pvs_query.select_ann",
        )
        .expect("op-template kernel synth");
        let outs: Vec<String> = kernel
            .program()
            .output_names()
            .iter()
            .map(|s| s.to_string())
            .collect();
        for required in &["overscan", "latency_factor", "recall_factor"] {
            assert!(
                outs.iter().any(|o| o == required),
                "op-template kernel missing '{required}'; outputs: {outs:?}"
            );
        }
        // Workload params must be folded in as `final` constants
        // (not externs) so `init prebuffered =
        // dataset_prebuffer("{dataset}:{profile}")` folds at
        // compile time. If they cascade through as externs the
        // init binding stays unfolded, the per-fiber state never
        // gets the seeded Handle, and downstream nodes (like
        // `neighbor_indices_at(prebuffered, q)`) panic at runtime
        // with `expected Handle, got None/U64`.
        for param in &["dataset", "profile", "keyspace"] {
            // The param either folds out completely (no input
            // slot) or appears as a folded constant — both
            // are fine. What's NOT fine is showing up as an
            // input on the inner kernel.
            assert!(
                kernel.program().find_input(param).is_none(),
                "workload param '{param}' must NOT be an extern input \
                 on the op-template kernel — cascade should emit \
                 it as `final` so init bindings fold. Inputs: {:?}",
                kernel.program().input_names(),
            );
        }
    }

    #[test]
    fn op_template_with_pow_and_if_keeps_all_outputs() {
        // Mirror the shape of full_cql_vector.yaml's pvs_query
        // phase body (after parser merge): init+cursor+:= ladder
        // ending with `pow()` + `if()` bindings. The op-template
        // kernel must expose every `:=` binding as an output;
        // a missing `overscan` is what triggers the
        // `register_pull("overscan")` failure at MetricsDispenser
        // wrap time.
        let parent_src = r#"
extern k: u64
extern limit: u64
extern optimize_for: String
extern table: String
extern dataset: String
extern profile: String
extern keyspace: String
"#;
        let parent = crate::bindings::compile_scope_kernel(
            parent_src,
            &polydat::dsl::compile::CompileOptions {
                context: "parent".to_string(),
                ..Default::default()
            },
        )
        .expect("parent compile");
        let manifest: Vec<crate::runner::ManifestEntry> =
            polydat::kernel::extract_manifest(parent.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let body = "const prebuffered := dataset_prebuffer(\"dummy:default\")\n\
            const query_counts := query_count(prebuffered)\n\
            cursor q = range(0, query_counts * 10)\n\
            query_vector := query_vector_at(prebuffered, q % query_counts)\n\
            predicate := predicate_value_at(prebuffered, q % query_counts)\n\
            ground_truth := filtered_neighbor_indices_at(prebuffered, q % query_counts)\n\
            latency_factor := 0.979 + 4.021 * pow(limit, -0.761)\n\
            recall_factor  := 0.509 + 9.491 * pow(limit, -0.402)\n\
            overscan := if(optimize_for == \"LATENCY\", latency_factor, recall_factor)\n";
        let op = op_with_body("select_ann", body);
        let kernel = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "pvs_query.select_ann",
        )
        .expect("op-template kernel synth");
        let outs: Vec<String> = kernel
            .program()
            .output_names()
            .iter()
            .map(|s| s.to_string())
            .collect();
        for required in &[
            "query_vector",
            "predicate",
            "ground_truth",
            "latency_factor",
            "recall_factor",
            "overscan",
        ] {
            assert!(
                outs.iter().any(|o| o == required),
                "op-template kernel missing '{required}'; outputs: {outs:?}"
            );
        }
    }

    #[test]
    fn op_template_relevancy_k_r_bare_wire_names_cascade() {
        // Post-SRD-68 follow-up: `evaluations.relevancy.{k, r,
        // expected, actual}` accept bare wire-name forms. The
        // op-template synthesiser must include those names in its
        // cascaded-extern set so the dispenser's canonical kernel
        // can resolve them at wrap-time (where parse_count_param
        // calls wires.get(name)).
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let mut op = ParsedOp::simple("read", "noop");
        op.bindings = BindingsDef::PolydatSource("".into());
        op.params.insert(
            "relevancy".into(),
            serde_json::json!({
                "actual": "rows",
                "expected": "ground_truth",
                "k": "k_value",
                "r": "limit_value",
                "functions": ["recall"],
            }),
        );
        // Parent has `cycle` as the coord input. The relevancy
        // wire names (rows, ground_truth, k_value, limit_value)
        // aren't on the parent; the synthesiser should still add
        // them to the cascade-extern set so the op-template kernel
        // *declares* them (errors only fire at wrap-time when the
        // canonical kernel actually tries to resolve them).
        //
        // For this unit test we just confirm the synthesiser
        // doesn't error AND that the input/output names list
        // includes each relevancy wire name — meaning the
        // referenced-cascade walker picked them up. We pick names
        // the parent doesn't have so the auto-extern path fires
        // and the resulting kernel has them as inputs.
        let _ = manifest;
        // Use the public synthesis entry point to construct the
        // op-template kernel under a parent that *does* have the
        // referenced wires (so the cascade succeeds).
        let kernel_src = "\
            input cycle: u64\n\
            const rows := 10\n\
            const ground_truth := \"1,2,3\"\n\
            const k_value := 5\n\
            const limit_value := 100\n";
        let real_parent =
            crate::scope_kernel::ScopeKernel::compile(kernel_src).expect("parent compile");
        let real_manifest = polydat::kernel::extract_manifest(real_parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let kernel = build_op_template_scope_kernel(
            &op,
            &real_manifest,
            &real_parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "relevancy-cascade-test",
        )
        .expect("op-template kernel synth");

        // Each bare-name relevancy wire should resolve through the
        // op-template kernel's lookup — the same path validation.rs
        // takes at wrap-time via canonical_kernel().lookup(name).
        for name in &["rows", "ground_truth", "k_value", "limit_value"] {
            assert!(
                kernel.lookup(name).is_some(),
                "relevancy wire '{name}' should be visible on the \
                 op-template kernel (cascaded extern); kernel had \
                 outputs: {outs:?}",
                outs = kernel.program().output_names()
            );
        }
    }

    #[test]
    fn op_template_metric_value_count_allocates_magic_extern_slot() {
        // Post-SRD-68 follow-up: a metric `value:` expression is a
        // use site for any names it references. The op-template
        // kernel synthesiser appends `__metric_<name> := <value_expr>`
        // to the result-bindings source, so the closure-binding
        // economy's free-identifier walker sees `count` and injects
        // an `extern count: u64` slot — no throw-away result-binding
        // needed.
        //
        // Verifies: a workload with NO `result:` block but a
        // `metrics: rows_per_op: { value: count }` declaration ends
        // up with a `count` INPUT slot on the kernel.
        let parent = parent_kernel_with_load();
        let manifest = polydat::kernel::extract_manifest(parent.program())
            .into_iter()
            .map(|e| crate::runner::ManifestEntry {
                name: e.name,
                port_type: e.port_type,
                modifier: e.modifier,
            })
            .collect::<Vec<_>>();
        let mut op = ParsedOp::simple("read", "noop");
        op.bindings = BindingsDef::PolydatSource("".into());
        op.metrics.insert(
            "rows_per_op".into(),
            nmbrs_workload::model::MetricSpec {
                value: "count".into(),
                family: None,
                kind: Some(nmbrs_workload::model::MetricKind::Gauge),
                unit: None,
                format: None,
                cell: Default::default(),
            },
        );
        let kernel = build_op_template_scope_kernel(
            &op,
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            polydat::kernel::KernelOptLevel::Release,
            "metric-walker-test",
        )
        .expect("op-template kernel synth");
        let inputs = kernel.program().input_names();
        assert!(
            inputs.iter().any(|i| i == "count"),
            "metric `value: count` should force the `count` magic-extern \
             input slot to be allocated under Release opt level; \
             inputs were: {inputs:?}"
        );
        // And the synthesised binding shows up as an output the
        // MetricsDispenser will read at cycle time.
        let outs = kernel.program().output_names();
        let synth = synthesize_metric_binding_name("rows_per_op");
        assert!(
            outs.iter().any(|o| o == &synth),
            "synthesised `{synth}` binding should be a kernel output; \
             outputs were: {outs:?}"
        );
    }

    #[test]
    fn promoted_final_emits_inline_literal_for_str() {
        // SRD-13f case 1 — when a referenced name is `final`
        // upstream and a Str, the synthesizer emits
        // `const name := "value"` in the child's source rather
        // than auto-externing it.
        let parent = crate::scope_kernel::ScopeKernel::compile(
            "input cycle: u64\nconst dataset := \"example\"\n",
        )
        .expect("compile parent");
        let manifest: Vec<crate::runner::ManifestEntry> =
            polydat::kernel::extract_manifest(parent.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let ops = vec![make_polydat_op("step", "x={dataset}", "input cycle: u64")];
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &manifest,
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            Some(&parent),
        )
        .expect("build_scope");
        let emitted = scope.emit();
        assert!(
            emitted.contains("const dataset := \"example\""),
            "expected promoted-final emission, got:\n{emitted}"
        );
        assert!(
            !emitted.contains("extern dataset"),
            "expected no extern for promoted-final dataset, got:\n{emitted}"
        );
    }

    #[test]
    fn promoted_final_emits_inline_literal_for_u64() {
        let parent =
            crate::scope_kernel::ScopeKernel::compile("input cycle: u64\nconst count := 42\n")
                .expect("compile parent");
        let manifest: Vec<crate::runner::ManifestEntry> =
            polydat::kernel::extract_manifest(parent.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let ops = vec![make_polydat_op("step", "n={count}", "input cycle: u64")];
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &manifest,
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            Some(&parent),
        )
        .expect("build_scope");
        let emitted = scope.emit();
        assert!(
            emitted.contains("const count := 42"),
            "expected promoted-final u64 emission, got:\n{emitted}"
        );
    }

    #[test]
    fn unresolved_wire_reference_surfaces_validation_error() {
        // SRD-13f case 4 — a typo in a `{...}` placeholder (here
        // `{tirp}` instead of the declared `trip`) is rejected
        // at the synthesizer level with a structured error,
        // not via a downstream Polydat compiler error.
        let parent = crate::scope_kernel::ScopeKernel::compile(
            "input cycle: u64\nconst dataset := \"example\"\n",
        )
        .expect("compile parent");
        let manifest: Vec<crate::runner::ManifestEntry> =
            polydat::kernel::extract_manifest(parent.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let ops = vec![make_polydat_op("step", "x={tirp}", "input cycle: u64")];
        let err = match build_scope(
            &ops,
            &HashMap::new(),
            &manifest,
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            Some(&parent),
        ) {
            Ok(_) => panic!("expected unresolved-wire error, got Ok"),
            Err(e) => e,
        };
        assert!(err.contains("unresolved wire"), "wrong error: {err}");
        assert!(
            err.contains("tirp"),
            "error should mention the typoed name: {err}"
        );
        assert!(
            err.contains("Visible names"),
            "error should list visible names: {err}"
        );
    }

    #[test]
    fn ingest_preserves_bindings_when_comment_contains_apostrophe() {
        // Regression: Polydat grammar uses only `"`-delimited string
        // literals. `logical_lines` previously treated `'` as a
        // string delimiter too, which meant an unmatched
        // apostrophe in a `#` comment (e.g. "the workload's
        // bindings") put the splitter into a string state that
        // never closed. The entire rest of the source was
        // accreted into one logical "line" starting with `#`,
        // which then got dropped as a comment by the per-line
        // parser — silently discarding every binding that
        // followed.
        //
        // This was the actual root cause of the full_cql_vector
        // `await_index` failure: the workload's
        // `bindings:` block began with a multi-line comment
        // containing the apostrophe in "full_cql_vector's", so
        // the `shared has_X := false` declarations never made
        // it into the workload-root program. Descendant
        // synthesizers then couldn't cascade has_X as Bool
        // externs; the compile inferred has_X as Coordinate
        // U64 inputs from unbound references, and the
        // per-cycle `set_inputs(&[u64])` clobbered the
        // SharedCell with `Value::U64(cycle)`.
        let mut scope = BindingScope::new();
        let src_with_apostrophe_comment = "# full_cql_vector's bindings block\n\
                                           shared has_a := true\n\
                                           shared has_b := false\n";
        scope.ingest_polydat_source(src_with_apostrophe_comment, BindingOrigin::Inherited);
        let defined = scope.defined_names();
        assert!(
            defined.contains("has_a"),
            "comment with apostrophe must NOT consume subsequent bindings; \
             expected has_a in defined names, got {defined:?}"
        );
        assert!(
            defined.contains("has_b"),
            "expected has_b in defined names, got {defined:?}"
        );

        let emitted = scope.emit();
        assert!(
            emitted.contains("shared has_a := true"),
            "scope.emit() must include the shared bindings; got:\n{emitted}"
        );
        assert!(
            emitted.contains("shared has_b := false"),
            "scope.emit() must include the shared bindings; got:\n{emitted}"
        );
    }

    #[test]
    fn ingest_then_compile_preserves_shared_modifier() {
        // Mirrors the workload-root compile path in
        // `compile_bindings_with_libs_excluding`: workload-level
        // bindings (`shared has_X := false`) get ingested via
        // `scope.ingest_polydat_source(..., Inherited)` before emit.
        // The resulting source then compiles via the
        // standard pipeline.
        //
        // SRD-13c §"Shared Mutable": `shared X := <literal>`
        // compiles to an input slot + passthrough output marked
        // SHARED. The workload-root program's `shared_outputs()`
        // must include the SHARED-modifier outputs so
        // `seed_shared_cells` creates a `SharedCell` for each
        // and descendant kernels can cell-attach via
        // `materialize_wiring_from_outer`.
        let mut scope = BindingScope::new();
        let workload_polydat = "shared has_sai_column_indexes := false\n\
                          shared has_indexes := false\n";
        scope.ingest_polydat_source(workload_polydat, BindingOrigin::Inherited);
        let source = scope.emit();
        let kernel = crate::scope_kernel::ScopeKernel::compile(&source)
            .unwrap_or_else(|e| panic!("compile failed for source:\n{source}\nerror: {e}"));
        let shared = kernel.program().shared_outputs();
        assert!(
            shared.contains(&"has_sai_column_indexes"),
            "expected `has_sai_column_indexes` in shared_outputs after scope-ingest/emit/compile;\n\
             got shared_outputs={shared:?}\nemitted source:\n{source}",
        );
        assert!(
            shared.contains(&"has_indexes"),
            "expected `has_indexes` in shared_outputs after scope-ingest/emit/compile;\n\
             got shared_outputs={shared:?}\nemitted source:\n{source}",
        );
    }

    /// SRD-75 Push 2: `synthesize_phase_scope_bindings`
    /// returns the original bindings unchanged when
    /// `phase.poll` is `None`. The function is a no-op for
    /// non-poll phases; their synthesis path is unaffected.
    #[test]
    fn synthesize_phase_scope_bindings_passthrough_when_no_poll() {
        use nmbrs_workload::model::{BindingsDef, WorkloadPhase};
        let phase = WorkloadPhase {
            bindings: BindingsDef::PolydatSource("k := 5\n".into()),
            poll: None,
            ..Default::default()
        };
        let out = synthesize_phase_scope_bindings(&phase).expect("no-poll synthesis is a no-op");
        match out {
            BindingsDef::PolydatSource(s) => assert_eq!(
                s, "k := 5\n",
                "no-poll should return the original bindings unchanged"
            ),
            other => panic!("expected PolydatSource, got {other:?}"),
        }
    }

    /// A metric's `cell:` is reified as a compiled kernel binding beside its
    /// value — the whole point of the design. If this did not compile, a
    /// coordinate would have to be a runtime string, which is the
    /// unvalidatable shape the proposal exists to avoid.
    #[test]
    fn phase_metrics_reify_cell_coordinates_as_kernel_bindings() {
        use nmbrs_workload::model::{BindingsDef, MetricSpec, WorkloadPhase};
        let mut metrics = std::collections::HashMap::new();
        let mut cell = std::collections::BTreeMap::new();
        cell.insert("tier".to_string(), "tier_name".to_string());
        metrics.insert(
            "bytes_out".to_string(),
            MetricSpec {
                value: "history_bytes_out".into(),
                family: None,
                kind: None,
                unit: None,
                format: None,
                cell,
            },
        );
        let phase = WorkloadPhase {
            bindings: BindingsDef::PolydatSource(
                "extern tier_name: str = \"\"\n\
                 extern history_bytes_out: u64 = 0\n"
                    .into(),
            ),
            metrics,
            poll: None,
            ..Default::default()
        };
        let out = synthesize_phase_scope_bindings(&phase).expect("synthesis");
        let src = match out {
            BindingsDef::PolydatSource(s) => s,
            other => panic!("expected PolydatSource, got {other:?}"),
        };
        assert!(
            src.contains("volatile __cell_bytes_out__tier := tier_name"),
            "coordinate must be emitted as a volatile binding; got:\n{src}"
        );
        assert!(
            src.contains("volatile __metric_bytes_out := history_bytes_out"),
            "the value binding must still be emitted; got:\n{src}"
        );
    }

    /// Per (metric, dimension), not per dimension: two metrics placing into
    /// one dimension by different expressions must not collide on a wire name
    /// and silently let one placement win.
    #[test]
    fn two_metrics_in_one_dimension_get_distinct_coordinate_wires() {
        assert_eq!(
            synthesize_cell_binding_name("bytes_out", "tier"),
            "__cell_bytes_out__tier"
        );
        assert_ne!(
            synthesize_cell_binding_name("bytes_out", "tier"),
            synthesize_cell_binding_name("bytes_in", "tier")
        );
    }

    /// A phase with a `metrics:` block (and no poll) synthesises a
    /// `volatile phase_start := phase_start_millis()` origin binding plus one
    /// `volatile __metric_<name> := <value>` per metric. The phase's own
    /// bindings are appended verbatim.
    ///
    /// `phase_start` was an `extern … = 0` filled by the executor at the
    /// completion-time pull, which meant anything reading it while the phase
    /// ran got the default.
    #[test]
    fn synthesize_phase_scope_bindings_emits_metric_bindings() {
        use nmbrs_workload::model::{BindingsDef, MetricSpec, WorkloadPhase};
        let mut metrics = std::collections::HashMap::new();
        metrics.insert(
            "time_to_index".to_string(),
            MetricSpec {
                value: "current_epoch_millis() - phase_start".into(),
                family: None,
                kind: None,
                unit: None,
                format: None,
                cell: Default::default(),
            },
        );
        let phase = WorkloadPhase {
            bindings: BindingsDef::default(),
            metrics,
            poll: None,
            ..Default::default()
        };
        let out = synthesize_phase_scope_bindings(&phase).expect("metrics synthesis");
        let src = match out {
            BindingsDef::PolydatSource(s) => s,
            other => panic!("expected PolydatSource, got {other:?}"),
        };
        // Bound to the runtime's phase clock, NOT an extern: as an extern it
        // was filled only at the completion-time pull, so anything reading it
        // while the phase ran (an op) got the 0 default and computed against
        // the epoch.
        assert!(
            src.contains("volatile phase_start := phase_start_millis()"),
            "must bind phase_start to the phase-scoped clock; got:\n{src}"
        );
        assert!(
            !src.contains("extern phase_start"),
            "the fill-me-in extern must be gone; got:\n{src}"
        );
        assert!(
            src.contains("volatile __metric_time_to_index := current_epoch_millis() - phase_start"),
            "must emit the volatile metric binding; got:\n{src}"
        );
        // The emitted source must compile as a phase kernel body, with
        // `__metric_time_to_index` surfacing as an output.
        let kernel = crate::scope_kernel::ScopeKernel::compile(&src)
            .unwrap_or_else(|e| panic!("compile failed:\n{src}\nerror: {e}"));
        assert!(
            kernel
                .program()
                .output_names()
                .contains(&"__metric_time_to_index"),
            "metric binding must be a kernel output; outputs: {:?}",
            kernel.program().output_names()
        );
    }

    /// SRD-75 Push 2: when a phase has `poll:` and ops with
    /// declared captures, the synthesized source carries one
    /// `shared <name>: u64 := 0` declaration per capture
    /// followed by the predicate binding `__poll_until :=
    /// <until>`. The original phase bindings (if any) are
    /// appended verbatim between the captures and the
    /// predicate.
    #[test]
    fn synthesize_phase_scope_bindings_emits_shared_captures_and_predicate() {
        use nmbrs_workload::bindpoints::CapturePoint;
        use nmbrs_workload::model::{BindingsDef, ParsedOp, PhasePollSpec, WorkloadPhase};
        let mut op = ParsedOp::simple("read_state", "noop");
        op.captures = vec![
            CapturePoint {
                row_filter: None,
                source_name: "sstables".into(),
                as_name: "sstables".into(),
                cast_type: None,
                slurp: false,
                path: Some("/0/value".into()),
                count: false,
                agg: None,
            },
            CapturePoint {
                row_filter: None,
                source_name: "active_for_cf".into(),
                as_name: "active_for_cf".into(),
                cast_type: None,
                slurp: false,
                path: Some("/1/value".into()),
                count: true,
                agg: None,
            },
        ];
        let phase = WorkloadPhase {
            ops: vec![op],
            bindings: BindingsDef::PolydatSource("dummy := 1\n".into()),
            poll: Some(PhasePollSpec {
                until: "sstables == 1 && active_for_cf == 0".into(),
                ..Default::default()
            }),
            ..Default::default()
        };
        let out = synthesize_phase_scope_bindings(&phase).expect("poll synthesis should succeed");
        let src = match out {
            BindingsDef::PolydatSource(s) => s,
            other => panic!("expected PolydatSource, got {other:?}"),
        };
        assert!(
            src.contains("shared sstables := 0"),
            "missing shared declaration for sstables; source:\n{src}"
        );
        assert!(
            src.contains("shared active_for_cf := 0"),
            "missing shared declaration for active_for_cf; source:\n{src}"
        );
        assert!(
            src.contains("dummy := 1"),
            "original phase bindings should appear verbatim; source:\n{src}"
        );
        assert!(
            src.contains("__poll_until := sstables == 1 && active_for_cf == 0"),
            "missing __poll_until predicate binding; source:\n{src}"
        );
        // Order matters: captures first (so the predicate's
        // RHS references resolve through the local shared
        // declarations before the dynamic binding evaluates).
        let shared_pos = src
            .find("shared sstables")
            .expect("shared sstables present");
        let until_binding = crate::wrappers::condition::UNTIL_BINDING;
        let until_pos = src
            .find(until_binding)
            .expect("poll predicate binding present");
        assert!(
            shared_pos < until_pos,
            "shared captures must precede __poll_until in the synthesized source"
        );
    }

    /// SRD-75 Push 2: a capture name that collides with an
    /// author-declared phase binding is a workload bug —
    /// the synthesizer surfaces the collision rather than
    /// silently shadowing.
    #[test]
    fn synthesize_phase_scope_bindings_rejects_capture_name_collision() {
        use nmbrs_workload::bindpoints::CapturePoint;
        use nmbrs_workload::model::{BindingsDef, ParsedOp, PhasePollSpec, WorkloadPhase};
        let mut op = ParsedOp::simple("read_state", "noop");
        op.captures = vec![CapturePoint {
            row_filter: None,
            source_name: "sstables".into(),
            as_name: "sstables".into(),
            cast_type: None,
            slurp: false,
            path: Some("/0/value".into()),
            count: false,
            agg: None,
        }];
        // Phase author also declared `sstables := …` —
        // collision is the bug.
        let phase = WorkloadPhase {
            ops: vec![op],
            bindings: BindingsDef::PolydatSource("sstables := 7\n".into()),
            poll: Some(PhasePollSpec {
                until: "sstables == 1".into(),
                ..Default::default()
            }),
            ..Default::default()
        };
        let err =
            synthesize_phase_scope_bindings(&phase).expect_err("colliding capture name must error");
        assert!(
            err.contains("sstables") && err.contains("collision"),
            "expected error to name 'sstables' and 'collision'; got: {err}"
        );
    }

    #[test]
    fn build_phase_scope_kernel_with_mod_in_binding_over_partition_iter_var() {
        // Matches the production workload shape:
        //   for: "p in partitions(\"linear:3\")"
        //   phases.walk.bindings: n := mod_in(cycle, p)
        //
        // The phase compile must see `p` as Ext so mod_in's
        // second arg (Partition input) type-checks. Reproduces
        // the integration error "u64 ─▶ ext expects ext".
        let parent_kernel = crate::scope_synth::build_for_each_scope_kernel(
            &[("p".to_string(), "partitions(\"linear:3\")".to_string())],
            &[],
            &crate::scope_kernel::ScopeKernel::compile("\n").unwrap(),
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_for_each",
            None,
        )
        .expect("for-each scope synthesis");

        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "n := mod_in(cycle, p)\n".to_string(),
        );
        let phase_kernel = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &parent_kernel,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_phase",
        )
        .expect("phase kernel build with mod_in(cycle, p) binding");

        // Sanity: phase has p as Ext-typed input slot.
        assert_eq!(
            phase_kernel.program().input_port_type("p"),
            Some(polydat::ast::PortType::Ext),
            "phase kernel's `p` must be Ext-typed",
        );
        // Sanity: phase has `n` as an output (the mod_in result).
        assert!(
            phase_kernel.program().output_names().contains(&"n"),
            "phase kernel should expose `n` as an output"
        );
    }

    #[test]
    fn build_phase_scope_kernel_cascades_partition_iter_var_as_extern_ext() {
        // SRD-71: when a for-each scope iterates a PartitionList
        // and binds an iter-var `p`, descendant phases must see
        // `p` as `extern p: Ext` — NOT cast to String / u64 by
        // the cascade. The phase body's `over p` clause then
        // resolves `p` as a partition-typed wire.
        //
        // Reproduces the integration failure where the phase's
        // build_phase_scope_kernel cascade was emitting
        // `extern p: u64` (or Str fallback) because the
        // type-name lookup didn't handle PortType::Ext.
        let parent_kernel = crate::scope_synth::build_for_each_scope_kernel(
            &[("p".to_string(), "partitions(\"linear:3\")".to_string())],
            &[], // empty parent_manifest is fine; for_each scope only
            // cascades names it actually references.
            &crate::scope_kernel::ScopeKernel::compile("\n").unwrap(),
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_for_each",
            None,
        )
        .expect("for-each scope synthesis");

        // Sanity: the for-each scope's iter-var p is Ext-typed.
        assert_eq!(
            parent_kernel.program().input_port_type("p"),
            Some(polydat::ast::PortType::Ext),
            "for-each scope's iter-var `p` must declare as Ext",
        );

        // Now build a phase under it that references `p` in a
        // cursor's `over` clause.
        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "cursor row = range(0, 1000) over p\n".to_string(),
        );
        let phase_kernel = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &parent_kernel,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_phase",
        )
        .expect("phase kernel build");

        // The phase kernel must see `p` as Ext-typed.
        let port_type = phase_kernel.program().input_port_type("p");
        assert_eq!(
            port_type,
            Some(polydat::ast::PortType::Ext),
            "phase kernel's `p` slot must be Ext (preserved through cascade), got {port_type:?}"
        );
    }

    #[test]
    fn build_phase_scope_kernel_cascades_shared_bool_as_extern_bool() {
        // SRD-13d §1: "The kernel auto-externs every name it
        // doesn't declare locally; those externs resolve up
        // through the phase kernel and beyond per the standard
        // SRD-13c chain."
        //
        // SRD-66 §"Surface 2": a workload-root `shared X :=
        // <literal>` becomes a `SharedCell`-backed slot at the
        // root. Descendant phases declare `extern X: bool` (or
        // auto-extern emits it); bind_outer_scope cell-attaches
        // the slot.
        //
        // SRD-13c §"Shared Mutable" step 1: `shared X := <literal>`
        // produces an input slot Bool (kind=ExternalWrite) plus a
        // passthrough output Bool, modifier SHARED.
        //
        // This unit-test verifies the documented type-preservation
        // contract: a phase scope built via build_phase_scope_kernel
        // against a parent kernel carrying a SHARED Bool output
        // must produce a phase-scope kernel whose has_X input slot
        // is type Bool, NOT typed U64 / not classified Coordinate.
        // Without this property, the SharedCell that bind_outer_scope
        // attaches gets a slot whose declared type doesn't match
        // the cell's actual Value variant — downstream consumers
        // (e.g. pick) see the runtime variant and reject it.
        let parent = crate::scope_kernel::ScopeKernel::compile(
            "input cycle: u64\nshared has_sai_column_indexes := false\n\
             shared has_indexes := false\n",
        )
        .expect("parent compile");
        // The phase has its own bindings block (the await_index shape).
        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "target_index_table := pick(has_sai_column_indexes, has_indexes, \
             \"a\", \"b\")\n"
                .to_string(),
        );
        let phase_kernel = build_phase_scope_kernel(
            &phase_bindings,
            &[], // outer_manifest (would be populated in real runner, but builder doesn't strictly need it)
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_phase",
        )
        .expect("phase kernel build");

        // The phase kernel must have has_X as an input slot.
        let idx_sai = phase_kernel.program().find_input("has_sai_column_indexes");
        assert!(
            idx_sai.is_some(),
            "phase kernel must have `has_sai_column_indexes` input slot"
        );
        let idx = idx_sai.unwrap();

        // Type must be Bool (per SRD-13c §"Shared Mutable" step 1
        // + SRD-66 §"Reading from a downstream phase").
        let port_type = phase_kernel
            .program()
            .input_port_type("has_sai_column_indexes");
        assert_eq!(
            port_type,
            Some(polydat::ast::PortType::Bool),
            "phase kernel's has_sai_column_indexes slot must be Bool, got {port_type:?}"
        );

        // Kind must NOT be Coordinate — cascaded names are IterationExtern
        // (or ExternalWrite), not Coordinate. Coordinate would put the slot
        // in the set_inputs(&[u64]) propagation, breaking the cell-bound
        // contract per SRD-13c §"Shared Mutable" step 3.
        let kind = phase_kernel.program().input_kind(idx);
        assert_ne!(
            kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "phase kernel's has_sai_column_indexes slot must NOT be Coordinate; got {kind:?}"
        );
    }

    #[test]
    fn executor_build_scope_emits_extern_bool_for_cell_backed_shared_wire() {
        // Reproduces the executor's specific build_scope call
        // sequence for the consume phase:
        //
        //   1. Build the phase scope kernel via build_phase_scope_kernel
        //      (this is what the runner's install pass does).
        //   2. Call build_scope(ops, ..., parent_kernel=phase_scope)
        //      with phase_scope as classifier_kernel — this is
        //      what executor.rs:1429 does at run_phase time.
        //   3. compile_from_scope(scope, ...) — produces the
        //      iter_op_builder kernel that dryrun=wiring dumps.
        //
        // The integration test
        // `shared_bool_through_for_each_into_consumer_phase_bindings`
        // proves this whole sequence produces a kernel with has_X
        // as `coordinate` U64. This unit test reproduces it without
        // a subprocess so we can inspect every intermediate state.
        use polydat::kernel::extract_manifest;

        // ── workload root ──
        let root = crate::scope_kernel::ScopeKernel::compile(
            "shared has_a := true\n\
             shared has_b := false\n\
             selector := mod(cycle, 1)\n",
        )
        .expect("workload root compile");

        // ── for_each scope ──
        let for_each = crate::scope_synth::build_for_each_scope_kernel(
            &[("outer".to_string(), "p1,p2".to_string())],
            &extract_manifest(root.program()),
            &root,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_for_each",
            None,
        )
        .expect("for_each synth");

        // ── phase scope kernel (cached_kernel) ──
        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "chosen := pick(has_a, has_b, \"alpha\", \"beta\")\n".to_string(),
        );
        let phase_scope = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &for_each,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_phase",
        )
        .expect("phase scope synth");

        // ── executor's build_scope call ──
        let op = ParsedOp::simple("report", "consume chosen={chosen}");
        let ops = vec![op];
        let effective_manifest: Vec<crate::runner::ManifestEntry> =
            extract_manifest(phase_scope.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let scope = build_scope(
            &ops,
            &HashMap::new(),
            &effective_manifest,
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            Some(&phase_scope),
        )
        .expect("executor build_scope");

        // ── inspect what build_scope emits ──
        let emitted = scope.emit();

        // ── compile_from_scope equivalent — uses the SAME compile
        // path the executor takes (compile_polydat_interpreter_with_options with
        // the scope's required_outputs filter).
        let required = scope.required_outputs();
        let executor_kernel = polydat::dsl::compile::compile_polydat_interpreter_with_options(
            &emitted,
            &polydat::dsl::compile::CompileOptions {
                required_outputs: required.clone(),
                context: "test".to_string(),
                ..Default::default()
            },
            None,
        )
        .unwrap_or_else(|e| {
            panic!("compile failed: {e}\nemitted source:\n{emitted}\nrequired: {required:?}")
        });

        // The executor's kernel must have has_a as Bool (or absent
        // entirely if not referenced). It MUST NOT be Coordinate U64.
        if let Some(idx) = executor_kernel.program().find_input("has_a") {
            let typ = executor_kernel.program().input_port_type("has_a");
            assert_eq!(
                typ,
                Some(polydat::ast::PortType::Bool),
                "executor kernel's has_a slot must be Bool;\n\
                 got {typ:?}\n\
                 emitted source:\n{emitted}\n\
                 input names: {:?}\n\
                 coord_count: {}",
                executor_kernel.program().input_names(),
                executor_kernel.program().coord_count()
            );
            let kind = executor_kernel.program().input_kind(idx);
            assert_ne!(
                kind,
                Some(polydat::kernel::InputKind::Coordinate),
                "executor kernel's has_a slot must NOT be Coordinate;\n\
                 got {kind:?}\n\
                 emitted source:\n{emitted}\n\
                 input names: {:?}\n\
                 coord_count: {}",
                executor_kernel.program().input_names(),
                executor_kernel.program().coord_count()
            );
        }
    }

    #[test]
    fn full_chain_workload_to_executor_scope_preserves_shared_bool() {
        // Chains through every layer the failing integration test
        // touches, in-process, with the same shape that triggers
        // the failure:
        //
        //   1. params kernel (workload params as `const` bindings).
        //   2. workload-root kernel via the `compile_bindings_with_libs_excluding`-style
        //      flow: build_scope + scope.ingest_polydat_source + parent.build_subscope.
        //   3. for_each scope kernel (outer iter var).
        //   4. for_each scope kernel (inner with multi-iter clause).
        //   5. phase scope kernel via build_phase_scope_kernel (consume).
        //   6. executor's build_scope + compile_polydat_with_libs_and_limit.
        //
        // Verifies at the END that the consumer phase's executor-
        // compiled kernel has has_a as Bool/non-Coordinate.
        use nmbrs_workload::model::ParsedOp;
        use polydat::kernel::extract_manifest;

        // Step 1: params kernel.
        let mut workload_params: HashMap<String, String> = HashMap::new();
        workload_params.insert("dataset".to_string(), "example_dataset".to_string());
        workload_params.insert("prefix".to_string(), "px_".to_string());
        let mut sorted: Vec<&String> = workload_params.keys().collect();
        sorted.sort();
        let mut params_source = String::new();
        for k in sorted {
            params_source.push_str(&format!("const {k} := \"{}\"\n", workload_params[k]));
        }
        let params_kernel =
            crate::scope_kernel::ScopeKernel::compile(&params_source).expect("params compile");

        // Step 2: workload-root kernel.
        let mut scope = build_scope(
            &[] as &[ParsedOp],
            &HashMap::new(),
            &[],
            &workload_params,
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .expect("workload root build_scope");
        // KEY: the binding RHS uses string interpolation against
        // workload params. This is what triggers the chain
        // corruption — without it, the test passes; with it, the
        // integration test fails.
        let workload_level_polydat = "combo_label := str_concat(\"{dataset}\", \"{prefix}\")\n\
                                 shared has_a := true\n\
                                 shared has_b := false\n";
        scope.ingest_polydat_source(workload_level_polydat, BindingOrigin::Inherited);
        let root_source = scope.emit();
        let root = crate::scope_kernel::ScopeKernel::build_under(
            params_kernel.kernel(),
            crate::scope_kernel::SourceMatter::source(
                "test_root",
                root_source.clone(),
                polydat::kernel::subcontext::CompileOptions {
                    workload_dir: None,
                    polydat_lib_paths: Vec::new(),
                    strict: false,
                    required_outputs: scope.required_outputs(),
                    context_label: Some("test_root".to_string()),
                    cursor_limit: None,
                    ..Default::default()
                },
            ),
        )
        .expect("root build");

        // Sanity: has_a SHARED at root.
        let shared = root.program().shared_outputs();
        assert!(
            shared.contains(&"has_a"),
            "root should have has_a as SHARED output; got {shared:?}"
        );

        // Step 3: outer for_each scope.
        let outer_fe = crate::scope_synth::build_for_each_scope_kernel(
            &[("outer".to_string(), "p1,p2".to_string())],
            &extract_manifest(root.program()),
            &root,
            &workload_params,
            Vec::new(),
            None,
            false,
            "test_outer_fe",
            None,
        )
        .expect("outer for_each synth");

        // Step 4: inner for_each scope (dependent multi-iter).
        let inner_fe = crate::scope_synth::build_for_each_scope_kernel(
            &[
                ("inner".to_string(), "lo,hi".to_string()),
                ("label".to_string(), "tag_p1_lo,tag_p1_hi".to_string()),
            ],
            &extract_manifest(outer_fe.program()),
            &outer_fe,
            &workload_params,
            Vec::new(),
            None,
            false,
            "test_inner_fe",
            None,
        )
        .expect("inner for_each synth");

        // Step 5: phase scope kernel for consume.
        let phase_bindings = BindingsDef::PolydatSource(
            "chosen := pick(has_a, has_b, \"alpha\", \"beta\")\n".to_string(),
        );
        let phase_scope = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &inner_fe,
            &workload_params,
            Vec::new(),
            None,
            false,
            "test_consume_phase",
        )
        .expect("consume phase synth");

        // Step 6: executor's build_scope on the consume phase.
        let op = ParsedOp::simple("report", "spc/consume chosen={chosen}");
        let ops = vec![op];
        let effective_manifest: Vec<crate::runner::ManifestEntry> =
            extract_manifest(phase_scope.program())
                .into_iter()
                .map(|e| crate::runner::ManifestEntry {
                    name: e.name,
                    port_type: e.port_type,
                    modifier: e.modifier,
                })
                .collect();
        let exec_scope = build_scope(
            &ops,
            &HashMap::new(),
            &effective_manifest,
            &HashMap::new(),
            &HashMap::new(),
            None,
            &[],
            Some(&phase_scope),
        )
        .expect("executor build_scope");

        let exec_source = exec_scope.emit();
        let exec_kernel = polydat::dsl::compile::compile_polydat_interpreter_with_options(
            &exec_source,
            &polydat::dsl::compile::CompileOptions {
                required_outputs: exec_scope.required_outputs(),
                context: "test_executor".to_string(),
                ..Default::default()
            },
            None,
        )
        .unwrap_or_else(|e| panic!("exec compile failed: {e}\nexec source:\n{exec_source}"));

        // The final kernel — what the dryrun=wiring dumps — must
        // have has_a as Bool/non-Coordinate.
        if let Some(idx) = exec_kernel.program().find_input("has_a") {
            let typ = exec_kernel.program().input_port_type("has_a");
            assert_eq!(
                typ,
                Some(polydat::ast::PortType::Bool),
                "FINAL kernel has_a must be Bool, got {typ:?}\n\
                 exec source:\n{exec_source}\n\
                 exec input_names: {:?}\n\
                 exec coord_count: {}",
                exec_kernel.program().input_names(),
                exec_kernel.program().coord_count()
            );
            let kind = exec_kernel.program().input_kind(idx);
            assert_ne!(
                kind,
                Some(polydat::kernel::InputKind::Coordinate),
                "FINAL kernel has_a must NOT be Coordinate, got {kind:?}\n\
                 exec source:\n{exec_source}\n\
                 exec input_names: {:?}\n\
                 exec coord_count: {}",
                exec_kernel.program().input_names(),
                exec_kernel.program().coord_count()
            );
        }
    }

    #[test]
    fn workload_root_via_compile_bindings_preserves_shared_bool_type() {
        // Mirrors the runner's WORKLOAD-ROOT build flow:
        //   compile_bindings_with_libs_excluding(
        //     parent=params_kernel,
        //     ops=all_ops,
        //     workload_params=<non-empty>,
        //     workload_level_polydat=Some(<the bindings: block>),
        //   )
        //
        // The actual function takes a complex set of args; here
        // we replicate the essential moves to expose what differs
        // from a direct `compile_polydat_interpreter(source)` invocation.
        //
        // SRD-13c §"Shared Mutable" requires has_a to be ExternalWrite
        // kind, Bool type on the workload-root program. The
        // dryrun=wiring output of the failing integration test shows
        // the downstream phase has has_a as Coordinate U64, so
        // either the workload-root or a downstream synthesizer
        // emits the wrong source for it.
        use nmbrs_workload::model::ParsedOp;

        let mut workload_params: HashMap<String, String> = HashMap::new();
        workload_params.insert("dataset".to_string(), "example_dataset".to_string());
        workload_params.insert("prefix".to_string(), "px_".to_string());
        workload_params.insert("keyspace".to_string(), "ks1".to_string());
        workload_params.insert("inner_options".to_string(), "lo,hi".to_string());

        // Workload params reach the root via a sibling params
        // kernel. Construct one with each param as a final binding.
        let mut params_source = String::new();
        let mut sorted: Vec<&String> = workload_params.keys().collect();
        sorted.sort();
        for k in sorted {
            let v = &workload_params[k];
            params_source.push_str(&format!("const {k} := \"{v}\"\n"));
        }
        let params_kernel =
            crate::scope_kernel::ScopeKernel::compile(&params_source).expect("params compile");

        // The workload's `bindings:` block. The trigger.
        let workload_level_polydat = "selector := mod(cycle, 1)\n\
                                 shared has_a := true\n\
                                 shared has_b := false\n";

        // Build the workload-root scope as compile_bindings_with_libs_excluding does.
        let mut scope = build_scope(
            &[] as &[ParsedOp],
            &HashMap::new(),
            &[],
            &workload_params,
            &HashMap::new(),
            None,
            &[],
            None,
        )
        .expect("build_scope");
        scope.ingest_polydat_source(workload_level_polydat, BindingOrigin::Inherited);

        // The actual workload-root compile goes through
        // parent.build_subscope. Build the matter and finalize.
        let source = scope.emit();
        let opts = polydat::kernel::subcontext::CompileOptions {
            workload_dir: None,
            polydat_lib_paths: Vec::new(),
            strict: false,
            required_outputs: scope.required_outputs(),
            context_label: Some("test_workload_root".to_string()),
            cursor_limit: None,
            ..Default::default()
        };
        let root = crate::scope_kernel::ScopeKernel::build_under(
            params_kernel.kernel(),
            crate::scope_kernel::SourceMatter::source("test_workload_root", source.clone(), opts),
        )
        .expect("workload root build");

        // The workload-root program must have has_a:
        //   - present as an input slot,
        //   - typed Bool (SRD-13c §"Shared Mutable" step 1),
        //   - kind ExternalWrite (NOT Coordinate),
        //   - marked SHARED in output_modifier (so seed_shared_cells fires).
        let has_a_idx = root.program().find_input("has_a").unwrap_or_else(|| {
            panic!(
                "workload root missing has_a input;\n\
                 emitted scope source:\n{source}\n\
                 input names: {:?}",
                root.program().input_names()
            )
        });

        let typ = root.program().input_port_type("has_a");
        assert_eq!(
            typ,
            Some(polydat::ast::PortType::Bool),
            "workload root has_a must be Bool;\n\
             got {typ:?}\n\
             emitted source:\n{source}\n\
             input names: {:?}\n\
             coord_count: {}",
            root.program().input_names(),
            root.program().coord_count()
        );

        let kind = root.program().input_kind(has_a_idx);
        assert_ne!(
            kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "workload root has_a must NOT be Coordinate;\n\
             got {kind:?}\n\
             emitted source:\n{source}\n\
             input names: {:?}\n\
             coord_count: {}",
            root.program().input_names(),
            root.program().coord_count()
        );

        let modifier = root.program().output_modifier("has_a");
        assert_eq!(
            modifier,
            polydat::dsl::ast::BindingModifier::SHARED,
            "workload root has_a output must have SHARED modifier;\n\
             got {modifier:?}"
        );

        let shared = root.program().shared_outputs();
        assert!(
            shared.contains(&"has_a"),
            "workload root must have has_a in shared_outputs (so seed_shared_cells creates a cell);\n\
             got shared_outputs={shared:?}"
        );
    }

    #[test]
    fn shared_bool_survives_when_workload_root_also_has_cycle_binding() {
        // BISECTED INTEGRATION FAILURE: adding any non-shared
        // workload-level binding that references `cycle`
        // (e.g. `selector := mod(cycle, 1)`) alongside the
        // SHARED bool wires causes the consumer phase's phase
        // scope kernel to have has_X classified as Coordinate
        // input slots typed U64 instead of cascaded externs
        // typed Bool.
        //
        // Manifests at runtime as: per-cycle `set_inputs(&[u64])`
        // clobbers the shared cells with `Value::U64(cycle)`,
        // and `pick(has_X, …)` panics with "non-bool type U64".
        //
        // This unit test walks the same scope chain
        // programmatically and pins the contract at each hop:
        //   workload root (shared bool + cycle-referencing binding)
        //     → for_each scope (synthesize_for_each_scope)
        //       → phase scope (build_phase_scope_kernel)
        // Asserts has_a stays Bool + non-Coordinate kind at every
        // layer.
        use polydat::kernel::extract_manifest;

        // Step 1: workload root with shared bool AND a
        // non-shared cycle binding. The trigger.
        let root = crate::scope_kernel::ScopeKernel::compile(
            "shared has_a := true\n\
             shared has_b := false\n\
             selector := mod(cycle, 1)\n",
        )
        .expect("workload root compile");

        // Workload-root contract: has_a is Bool ExternalWrite slot
        // (SRD-13c §"Shared Mutable" step 1).
        let root_has_a_idx = root
            .program()
            .find_input("has_a")
            .expect("workload root has_a slot");
        let root_has_a_type = root.program().input_port_type("has_a");
        assert_eq!(
            root_has_a_type,
            Some(polydat::ast::PortType::Bool),
            "workload root has_a must be Bool"
        );
        let root_has_a_kind = root.program().input_kind(root_has_a_idx);
        assert_ne!(
            root_has_a_kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "workload root has_a must NOT be Coordinate; got {root_has_a_kind:?}"
        );

        // Step 2: for_each scope.
        let for_each = crate::scope_synth::build_for_each_scope_kernel(
            &[("outer".to_string(), "p1,p2".to_string())],
            &extract_manifest(root.program()),
            &root,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_for_each",
            None,
        )
        .expect("for_each synth");

        let fe_has_a_idx = for_each
            .program()
            .find_input("has_a")
            .expect("for_each has_a slot");
        let fe_has_a_type = for_each.program().input_port_type("has_a");
        assert_eq!(
            fe_has_a_type,
            Some(polydat::ast::PortType::Bool),
            "for_each has_a must be Bool, got {fe_has_a_type:?}"
        );
        let fe_has_a_kind = for_each.program().input_kind(fe_has_a_idx);
        assert_ne!(
            fe_has_a_kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "for_each has_a must NOT be Coordinate; got {fe_has_a_kind:?}"
        );

        // Step 3: phase scope with its own bindings via pick.
        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "chosen := pick(has_a, has_b, \"alpha\", \"beta\")\n".to_string(),
        );
        let phase = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &for_each,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_phase",
        )
        .expect("phase scope synth");

        let phase_has_a_idx = phase
            .program()
            .find_input("has_a")
            .expect("phase has_a slot");
        let phase_has_a_type = phase.program().input_port_type("has_a");
        assert_eq!(
            phase_has_a_type,
            Some(polydat::ast::PortType::Bool),
            "phase has_a must be Bool; got {phase_has_a_type:?}\n\
             phase input names: {:?}",
            phase.program().input_names()
        );
        let phase_has_a_kind = phase.program().input_kind(phase_has_a_idx);
        assert_ne!(
            phase_has_a_kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "phase has_a must NOT be Coordinate; got {phase_has_a_kind:?}\n\
             phase input names: {:?}\n\
             coord_count: {}",
            phase.program().input_names(),
            phase.program().coord_count()
        );
    }

    #[test]
    fn for_each_then_phase_preserves_shared_bool_through_chain() {
        // The full chain the workload exercises:
        //   workload root (shared has_X := false)
        //     → for_each scope (cascades has_X via synthesize_for_each_scope)
        //       → phase scope await_index (cascades has_X via build_phase_scope_kernel)
        //
        // SRD-13c §"Shared Mutable" + SRD-13d §1: at every cascade
        // hop, has_X stays Bool-typed and non-Coordinate.
        // bind_outer_scope then cell-attaches at each level so
        // the original SharedCell reaches the leaf.
        use polydat::kernel::extract_manifest;
        let root = crate::scope_kernel::ScopeKernel::compile(
            "input cycle: u64\nshared has_sai_column_indexes := false\n\
             shared has_indexes := false\n",
        )
        .expect("root compile");

        // for_each scope synthesised via the comprehension
        // synthesizer (the path runner.rs uses for ForComprehension
        // install specs). Iter vars are a placeholder so the
        // builder runs.
        let for_each_kernel = crate::scope_synth::build_for_each_scope_kernel(
            &[("dummy_var".to_string(), "1,2".to_string())],
            &extract_manifest(root.program()),
            &root,
            &HashMap::new(), // workload_params
            Vec::new(),      // polydat_lib_paths
            None,            // workload_dir
            false,           // strict
            "test_for_each",
            None, // phase_bindings
        )
        .expect("for_each kernel synth");

        // for_each's program must carry has_X as a Bool slot too.
        let fe_type = for_each_kernel
            .program()
            .input_port_type("has_sai_column_indexes");
        assert_eq!(
            fe_type,
            Some(polydat::ast::PortType::Bool),
            "for_each scope's has_sai_column_indexes must be Bool, got {fe_type:?}"
        );
        let fe_idx = for_each_kernel
            .program()
            .find_input("has_sai_column_indexes")
            .expect("for_each has has_sai_column_indexes input");
        let fe_kind = for_each_kernel.program().input_kind(fe_idx);
        assert_ne!(
            fe_kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "for_each scope's has_sai_column_indexes must NOT be Coordinate; got {fe_kind:?}"
        );

        // Now build await_index's phase scope under for_each
        // (the real scope-tree shape).
        let phase_bindings = nmbrs_workload::model::BindingsDef::PolydatSource(
            "target_index_table := pick(has_sai_column_indexes, has_indexes, \
             \"a\", \"b\")\n"
                .to_string(),
        );
        let phase_kernel = build_phase_scope_kernel(
            &phase_bindings,
            &[],
            &for_each_kernel,
            &HashMap::new(),
            Vec::new(),
            None,
            false,
            "test_await_index",
        )
        .expect("phase kernel synth");

        let phase_type = phase_kernel
            .program()
            .input_port_type("has_sai_column_indexes");
        assert_eq!(
            phase_type,
            Some(polydat::ast::PortType::Bool),
            "phase scope's has_sai_column_indexes must be Bool, got {phase_type:?}"
        );
        let phase_idx = phase_kernel
            .program()
            .find_input("has_sai_column_indexes")
            .expect("phase has has_sai_column_indexes input");
        let phase_kind = phase_kernel.program().input_kind(phase_idx);
        assert_ne!(
            phase_kind,
            Some(polydat::kernel::InputKind::Coordinate),
            "phase scope's has_sai_column_indexes must NOT be Coordinate; got {phase_kind:?}"
        );
    }
}

/// Strict mode reaches every synthesized scope, and each still compiles:
/// strict refuses a source with no `input` declaration, and a synthesized
/// scope's coordinates are its parent's, so they are declared for it.
#[cfg(test)]
mod strict_synthesis_tests {
    use super::*;

    fn parent() -> crate::scope_kernel::ScopeKernel {
        crate::scope_kernel::ScopeKernel::compile("input cycle: u64\nconst k_values := \"1, 10\"\n")
            .expect("parent scope")
    }

    #[test]
    fn a_phase_scope_compiles_under_strict() {
        let parent = parent();
        let manifest = crate::runner::extract_manifest(parent.program());
        let kernel = build_phase_scope_kernel(
            &nmbrs_workload::model::BindingsDef::PolydatSource("x := cycle + 1\n".into()),
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            true,
            "strict phase",
        )
        .expect("a phase scope compiles under strict");
        assert!(kernel.input_names().iter().any(|n| n == "cycle"));
    }

    #[test]
    fn a_do_loop_scope_compiles_under_strict() {
        let parent = parent();
        let manifest = crate::runner::extract_manifest(parent.program());
        build_do_loop_scope_kernel(
            Some("i"),
            "{i} < 3",
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            true,
            "strict do-loop",
        )
        .expect("a do-loop scope compiles under strict");
    }

    #[test]
    fn a_for_each_scope_compiles_under_strict() {
        let parent = parent();
        let manifest = crate::runner::extract_manifest(parent.program());
        crate::scope_synth::build_for_each_scope_kernel(
            &[("k".to_string(), "{k_values}".to_string())],
            &manifest,
            &parent,
            &HashMap::new(),
            Vec::new(),
            None,
            true,
            "strict for_each",
            None,
        )
        .expect("a for_each scope compiles under strict");
    }
}