nika-engine 0.38.0

Nika workflow engine — embeddable runtime, provider, DAG, and binding logic
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
//! Additional tests for PR3b tools: chart, provenance, import edge cases.

#[cfg(test)]
mod tests {
    use crate::media::CasStore;
    use crate::runtime::builtin::media::context::MediaToolContext;
    use crate::runtime::builtin::media::import::ImportOp;
    use crate::runtime::builtin::media::{MediaOp, MediaOpResult, MediaToolAdapter};
    use crate::runtime::builtin::BuiltinTool;
    use std::sync::Arc;

    async fn setup() -> (tempfile::TempDir, Arc<MediaToolContext>) {
        let dir = tempfile::tempdir().unwrap();
        let ctx = Arc::new(MediaToolContext::new(CasStore::new(dir.path())));
        (dir, ctx)
    }

    fn fixture_png(w: u32, h: u32, r: u8, g: u8, b: u8) -> Vec<u8> {
        use image::{ImageBuffer, Rgb};
        let img = ImageBuffer::from_pixel(w, h, Rgb([r, g, b]));
        let mut buf = Vec::new();
        let enc = image::codecs::png::PngEncoder::new(&mut buf);
        image::ImageEncoder::write_image(enc, img.as_raw(), w, h, image::ExtendedColorType::Rgb8)
            .unwrap();
        buf
    }

    fn fixture_jpeg(w: u32, h: u32, r: u8, g: u8, b: u8) -> Vec<u8> {
        use image::{ImageBuffer, Rgb};
        let img = ImageBuffer::from_pixel(w, h, Rgb([r, g, b]));
        let mut buf = std::io::Cursor::new(Vec::new());
        img.write_to(&mut buf, image::ImageFormat::Jpeg).unwrap();
        buf.into_inner()
    }

    // ═══════════════════════════════════════════════════════════════
    // IMPORT: MediaToolAdapter integration (tests the full call path)
    // ═══════════════════════════════════════════════════════════════

    #[tokio::test]
    async fn import_via_adapter_returns_json() {
        let (_dir, ctx) = setup().await;

        let png = fixture_png(20, 20, 128, 0, 255);
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &png).unwrap();

        let adapter = MediaToolAdapter::new(Arc::new(ImportOp), Arc::clone(&ctx));

        let json_str = adapter
            .call(serde_json::json!({"path": tmp.path().to_string_lossy()}).to_string())
            .await
            .unwrap();

        let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
        assert!(v["hash"].as_str().unwrap().starts_with("blake3:"));
        assert_eq!(v["mime_type"], "image/png");
        assert!(v["size_bytes"].as_u64().unwrap() > 0);
    }

    #[tokio::test]
    async fn import_via_adapter_invalid_json() {
        let (_dir, ctx) = setup().await;
        let adapter = MediaToolAdapter::new(Arc::new(ImportOp), Arc::clone(&ctx));

        let result = adapter.call("not valid json".to_string()).await;
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("NIKA-294"));
    }

    #[tokio::test]
    async fn import_adapter_name_and_schema() {
        let (_dir, ctx) = setup().await;
        let adapter = MediaToolAdapter::new(Arc::new(ImportOp), Arc::clone(&ctx));

        assert_eq!(adapter.name(), "import");
        assert!(adapter.description().contains("Import"));

        let schema = adapter.parameters_schema();
        let props = schema["properties"].as_object().unwrap();
        assert!(props.contains_key("path"));
        assert!(schema["required"]
            .as_array()
            .unwrap()
            .iter()
            .any(|v| v == "path"));
    }

    // ═══════════════════════════════════════════════════════════════
    // IMPORT: various edge cases
    // ═══════════════════════════════════════════════════════════════

    #[tokio::test]
    async fn import_single_byte_file() {
        let (_dir, ctx) = setup().await;
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), [0xFF]).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["size_bytes"], 1);
            // Single byte has no magic → octet-stream
            assert_eq!(v["mime_type"], "application/octet-stream");
        }
    }

    #[tokio::test]
    async fn import_four_bytes_file() {
        let (_dir, ctx) = setup().await;
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), [0x89, 0x50, 0x4E, 0x47]).unwrap(); // PNG magic but truncated

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["size_bytes"], 4);
            // Hash must be valid blake3 format
            let hash = v["hash"].as_str().unwrap();
            assert!(hash.starts_with("blake3:"), "hash must be blake3-prefixed");
            assert_eq!(
                hash.len(),
                71,
                "blake3:xxxx = 6 prefix + 64 hex + 1 colon = 71 chars"
            );
            // MIME should be detected (or fallback)
            let mime = v["mime_type"].as_str().unwrap();
            assert!(!mime.is_empty(), "mime_type should not be empty");
            // Must be readable from CAS
            let read_back = ctx.read_media(hash).await.unwrap();
            assert_eq!(read_back, &[0x89, 0x50, 0x4E, 0x47]);
        } else {
            panic!("expected Metadata result");
        }
    }

    #[tokio::test]
    async fn import_binary_data_no_magic() {
        let (_dir, ctx) = setup().await;
        let data: Vec<u8> = (0..100).map(|i| (i * 7 + 13) as u8).collect();
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &data).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["mime_type"], "application/octet-stream");
        }
    }

    #[tokio::test]
    async fn import_wasm_detected() {
        let (_dir, ctx) = setup().await;
        // WASM magic: \0asm
        let mut wasm = vec![0x00, 0x61, 0x73, 0x6D];
        wasm.extend_from_slice(&[1, 0, 0, 0]); // version 1
        wasm.extend_from_slice(&[0u8; 50]);

        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &wasm).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["mime_type"], "application/wasm");
        }
    }

    #[tokio::test]
    async fn import_tiff_detected() {
        let (_dir, ctx) = setup().await;
        // TIFF little-endian magic: II + 42
        let mut tiff = vec![0x49, 0x49, 0x2A, 0x00];
        tiff.extend_from_slice(&[0u8; 50]);

        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &tiff).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["mime_type"], "image/tiff");
        }
    }

    #[tokio::test]
    async fn import_bmp_detected() {
        let (_dir, ctx) = setup().await;
        // BMP magic: BM
        let mut bmp = vec![0x42, 0x4D];
        bmp.extend_from_slice(&100u32.to_le_bytes()); // file size
        bmp.extend_from_slice(&[0u8; 50]);

        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &bmp).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            assert_eq!(v["mime_type"], "image/bmp");
        }
    }

    #[tokio::test]
    async fn import_svg_as_octet_stream() {
        let (_dir, ctx) = setup().await;
        // SVG is text-based — no magic bytes
        let svg = b"<svg xmlns='http://www.w3.org/2000/svg'><rect/></svg>";
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), svg).unwrap();

        let result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Metadata(v) = result {
            // SVG has no magic bytes — infer won't detect it
            // It may detect as XML or fall back to octet-stream
            let mime = v["mime_type"].as_str().unwrap();
            assert!(
                mime == "application/octet-stream" || mime == "text/xml" || mime == "image/svg+xml",
                "SVG should be detected as xml or octet-stream, got: {mime}"
            );
        }
    }

    #[tokio::test]
    async fn import_multiple_different_files() {
        let (_dir, ctx) = setup().await;

        let formats = vec![
            ("png", fixture_png(10, 10, 255, 0, 0)),
            ("jpeg", fixture_jpeg(10, 10, 0, 255, 0)),
        ];

        let mut hashes = Vec::new();

        for (name, data) in &formats {
            let tmp = tempfile::NamedTempFile::new().unwrap();
            std::fs::write(tmp.path(), data).unwrap();

            let result = ImportOp
                .execute(
                    serde_json::json!({"path": tmp.path().to_string_lossy()}),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Metadata(v) = result {
                let hash = v["hash"].as_str().unwrap().to_string();
                hashes.push((name.to_string(), hash));
            }
        }

        // Different content should produce different hashes
        assert_ne!(
            hashes[0].1, hashes[1].1,
            "PNG and JPEG should have different hashes"
        );

        // All should be readable from CAS
        for (_, hash) in &hashes {
            let data = ctx.read_media(hash).await;
            assert!(data.is_ok(), "should be able to read back {hash}");
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // CHART: edge cases (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-chart")]
    mod chart_tests {
        use super::*;
        use crate::runtime::builtin::media::chart::ChartOp;

        #[tokio::test]
        async fn chart_single_value_series() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "bar",
                      "series": [{"name": "Single", "data": [42.0]}],
                      "labels": ["Only"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert_eq!(&data[..4], &[0x89, 0x50, 0x4E, 0x47]);
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_many_series() {
            let (_dir, ctx) = setup().await;
            let series: Vec<_> = (0..10).map(|i| {
        serde_json::json!({"name": format!("Series {i}"), "data": [i as f64, (i*2) as f64]})
      }).collect();

            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "bar",
                      "series": series,
                      "labels": ["A", "B"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_negative_values() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "line",
                      "series": [{"name": "Temp", "data": [-10.0, -5.0, 0.0, 5.0, 10.0]}],
                      "labels": ["Jan", "Feb", "Mar", "Apr", "May"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert_eq!(&data[..4], &[0x89, 0x50, 0x4E, 0x47]);
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_float_values() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "pie",
                      "series": [
                        {"name": "A", "data": [33.33]},
                        {"name": "B", "data": [66.67]}
                      ]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_zero_values() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "bar",
                      "series": [{"name": "Zero", "data": [0.0, 0.0, 0.0]}],
                      "labels": ["A", "B", "C"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_large_values() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "bar",
                      "series": [{"name": "Big", "data": [1000000.0, 5000000.0, 10000000.0]}],
                      "labels": ["Q1", "Q2", "Q3"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_via_adapter() {
            let (_dir, ctx) = setup().await;
            let adapter = MediaToolAdapter::new(Arc::new(ChartOp), Arc::clone(&ctx));

            let json_str = adapter
                .call(
                    serde_json::json!({
                      "type": "pie",
                      "series": [
                        {"name": "Yes", "data": [70.0]},
                        {"name": "No", "data": [30.0]}
                      ]
                    })
                    .to_string(),
                )
                .await
                .unwrap();

            let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
            assert!(v["hash"].as_str().unwrap().starts_with("blake3:"));
            assert_eq!(v["mime_type"], "image/png");
        }

        #[tokio::test]
        async fn chart_with_title() {
            let (_dir, ctx) = setup().await;
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "line",
                      "title": "Revenue Growth 2026",
                      "series": [{"name": "Revenue", "data": [100.0, 150.0, 200.0, 250.0]}],
                      "labels": ["Q1", "Q2", "Q3", "Q4"]
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { metadata, .. } = result {
                assert_eq!(metadata["chart_type"], "line");
            }
        }

        #[tokio::test]
        async fn chart_pie_many_slices() {
            let (_dir, ctx) = setup().await;
            let series: Vec<_> = (0..20)
                .map(
                    |i| serde_json::json!({"name": format!("Slice {i}"), "data": [(i + 1) as f64]}),
                )
                .collect();

            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "pie",
                      "series": series
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }

        #[tokio::test]
        async fn chart_empty_labels() {
            let (_dir, ctx) = setup().await;
            // Bar chart with no labels — should still work
            let result = ChartOp
                .execute(
                    serde_json::json!({
                      "type": "bar",
                      "series": [{"name": "X", "data": [1.0, 2.0]}],
                      "labels": []
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(!data.is_empty());
            } else {
                panic!("expected Binary result");
            }
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // PROVENANCE: edge cases (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-provenance")]
    mod provenance_tests {
        use super::*;
        use crate::runtime::builtin::media::provenance::ProvenanceOp;

        #[tokio::test]
        async fn provenance_ai_modified() {
            let (_dir, ctx) = setup().await;
            let jpeg = fixture_jpeg(50, 50, 0, 128, 255);
            let sr = ctx.cas.store(&jpeg).await.unwrap();

            let result = ProvenanceOp
                .execute(
                    serde_json::json!({
                      "hash": sr.hash,
                      "assertion": "ai.modified"
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { metadata, .. } = result {
                assert_eq!(metadata["assertion"], "ai.modified");
            }
        }

        #[tokio::test]
        async fn provenance_with_custom_title() {
            let (_dir, ctx) = setup().await;
            let png = fixture_png(30, 30, 255, 128, 0);
            let sr = ctx.cas.store(&png).await.unwrap();

            let result = ProvenanceOp
                .execute(
                    serde_json::json!({
                      "hash": sr.hash,
                      "assertion": "human.created",
                      "title": "My Custom Art Piece"
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { metadata, .. } = result {
                assert_eq!(metadata["title"], "My Custom Art Piece");
            }
        }

        #[tokio::test]
        async fn provenance_via_adapter() {
            let (_dir, ctx) = setup().await;
            let jpeg = fixture_jpeg(40, 40, 128, 128, 128);
            let sr = ctx.cas.store(&jpeg).await.unwrap();

            let adapter = MediaToolAdapter::new(Arc::new(ProvenanceOp), Arc::clone(&ctx));
            let json_str = adapter
                .call(
                    serde_json::json!({
                      "hash": sr.hash,
                      "assertion": "ai.generated"
                    })
                    .to_string(),
                )
                .await
                .unwrap();

            let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
            assert!(v["hash"].as_str().unwrap().starts_with("blake3:"));
            assert_eq!(v["metadata"]["signed"], true);
        }

        #[tokio::test]
        async fn provenance_signed_larger_than_original() {
            let (_dir, ctx) = setup().await;
            let png = fixture_png(100, 100, 0, 0, 255);
            let original_size = png.len();
            let sr = ctx.cas.store(&png).await.unwrap();

            let result = ProvenanceOp
                .execute(
                    serde_json::json!({
                      "hash": sr.hash,
                      "assertion": "ai.generated"
                    }),
                    &ctx,
                )
                .await
                .unwrap();

            if let MediaOpResult::Binary { data, .. } = result {
                assert!(
                    data.len() > original_size,
                    "signed image ({}) should be larger than original ({original_size})",
                    data.len()
                );
            }
        }

        #[tokio::test]
        async fn provenance_name_and_schema() {
            let op = ProvenanceOp;
            assert_eq!(op.name(), "provenance");
            assert!(op.description().contains("C2PA"));

            let schema = op.parameters_schema();
            let required = schema["required"].as_array().unwrap();
            assert!(required.iter().any(|v| v == "hash"));
            assert!(required.iter().any(|v| v == "assertion"));
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // IMPORT→PROVENANCE pipeline (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-provenance")]
    #[tokio::test]
    async fn pipeline_import_then_provenance() {
        use crate::runtime::builtin::media::provenance::ProvenanceOp;

        let (_dir, ctx) = setup().await;

        // Import a JPEG
        let jpeg = fixture_jpeg(80, 80, 255, 0, 128);
        let tmp = tempfile::NamedTempFile::new().unwrap();
        std::fs::write(tmp.path(), &jpeg).unwrap();

        let import_result = ImportOp
            .execute(
                serde_json::json!({"path": tmp.path().to_string_lossy()}),
                &ctx,
            )
            .await
            .unwrap();

        let hash = if let MediaOpResult::Metadata(v) = import_result {
            v["hash"].as_str().unwrap().to_string()
        } else {
            panic!("expected Metadata");
        };

        // Sign with provenance
        let prov_result = ProvenanceOp
            .execute(
                serde_json::json!({
                  "hash": hash,
                  "assertion": "ai.generated",
                  "title": "Workflow Output"
                }),
                &ctx,
            )
            .await
            .unwrap();

        if let MediaOpResult::Binary {
            data,
            mime_type,
            metadata,
            ..
        } = prov_result
        {
            assert_eq!(mime_type, "image/jpeg");
            assert!(data.len() > jpeg.len());
            assert_eq!(metadata["signed"], true);
            assert_eq!(metadata["assertion"], "ai.generated");
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // IMPORT→CHART pipeline (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-chart")]
    #[tokio::test]
    async fn chart_output_can_be_read_from_cas_via_adapter() {
        use crate::runtime::builtin::media::chart::ChartOp;

        let (_dir, ctx) = setup().await;

        let adapter = MediaToolAdapter::new(Arc::new(ChartOp), Arc::clone(&ctx));

        let json_str = adapter
            .call(
                serde_json::json!({
                  "type": "bar",
                  "series": [{"name": "Test", "data": [10.0, 20.0, 30.0]}],
                  "labels": ["A", "B", "C"]
                })
                .to_string(),
            )
            .await
            .unwrap();

        let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
        let hash = v["hash"].as_str().unwrap();

        // Read the chart PNG from CAS
        let png_data = ctx.read_media(hash).await.unwrap();
        assert_eq!(
            &png_data[..4],
            &[0x89, 0x50, 0x4E, 0x47],
            "stored data should be PNG"
        );
        assert!(png_data.len() > 100);
    }

    // ═══════════════════════════════════════════════════════════════
    // PHASH: adapter + cancellation (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-phash")]
    mod phash_tests {
        use super::*;
        use crate::runtime::builtin::media::compare::CompareOp;
        use crate::runtime::builtin::media::phash::PhashOp;

        fn fixture_png(w: u32, h: u32, r: u8, g: u8, b: u8) -> Vec<u8> {
            use image::{ImageBuffer, Rgb};
            let img = ImageBuffer::from_pixel(w, h, Rgb([r, g, b]));
            let mut buf = Vec::new();
            let enc = image::codecs::png::PngEncoder::new(&mut buf);
            image::ImageEncoder::write_image(
                enc,
                img.as_raw(),
                w,
                h,
                image::ExtendedColorType::Rgb8,
            )
            .unwrap();
            buf
        }

        #[tokio::test]
        async fn phash_via_adapter() {
            let (_dir, ctx) = setup().await;
            let png = fixture_png(50, 50, 255, 0, 0);
            let sr = ctx.cas.store(&png).await.unwrap();

            let adapter = MediaToolAdapter::new(Arc::new(PhashOp), Arc::clone(&ctx));
            let json_str = adapter
                .call(serde_json::json!({"hash": sr.hash}).to_string())
                .await
                .unwrap();

            let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
            assert!(v["phash"].is_string());
            assert_eq!(v["algorithm"], "dct");
        }

        #[tokio::test]
        async fn phash_cancelled_workflow() {
            let (_dir, ctx) = setup().await;
            ctx.cancel.cancel();
            let op = PhashOp;
            let result = op.execute(serde_json::json!({"hash": "x"}), &ctx).await;
            assert!(result.is_err());
            assert!(result.unwrap_err().to_string().contains("cancelled"));
        }

        #[tokio::test]
        async fn compare_via_adapter() {
            let (_dir, ctx) = setup().await;
            let png_a = fixture_png(50, 50, 255, 0, 0);
            let png_b = fixture_png(50, 50, 0, 0, 255);
            let sr_a = ctx.cas.store(&png_a).await.unwrap();
            let sr_b = ctx.cas.store(&png_b).await.unwrap();

            let adapter = MediaToolAdapter::new(Arc::new(CompareOp), Arc::clone(&ctx));
            let json_str = adapter
                .call(
                    serde_json::json!({
                      "hash_a": sr_a.hash,
                      "hash_b": sr_b.hash
                    })
                    .to_string(),
                )
                .await
                .unwrap();

            let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
            assert!(v["distance"].is_number());
            assert!(v["similarity_pct"].is_number());
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // PDF_EXTRACT: adapter + cancellation (feature-gated)
    // ═══════════════════════════════════════════════════════════════

    #[cfg(feature = "media-pdf")]
    mod pdf_tests {
        use super::*;
        use crate::runtime::builtin::media::pdf::PdfExtractOp;

        fn fixture_pdf() -> Vec<u8> {
            b"%PDF-1.0\n1 0 obj<</Type/Catalog/Pages 2 0 R>>endobj\n2 0 obj<</Type/Pages/Kids[3 0 R]/Count 1>>endobj\n3 0 obj<</Type/Page/MediaBox[0 0 612 792]/Parent 2 0 R/Resources<</Font<</F1 4 0 R>>>>/Contents 5 0 R>>endobj\n4 0 obj<</Type/Font/Subtype/Type1/BaseFont/Helvetica>>endobj\n5 0 obj<</Length 44>>stream\nBT /F1 12 Tf 100 700 Td (Hello Nika!) Tj ET\nendstream\nendobj\nxref\n0 6\n0000000000 65535 f \n0000000009 00000 n \n0000000058 00000 n \n0000000115 00000 n \n0000000266 00000 n \n0000000340 00000 n \ntrailer<</Size 6/Root 1 0 R>>\nstartxref\n434\n%%EOF".to_vec()
        }

        #[tokio::test]
        async fn pdf_extract_via_adapter() {
            let (_dir, ctx) = setup().await;
            let pdf = fixture_pdf();
            let sr = ctx.cas.store(&pdf).await.unwrap();

            let adapter = MediaToolAdapter::new(Arc::new(PdfExtractOp), Arc::clone(&ctx));
            let result = adapter
                .call(serde_json::json!({"hash": sr.hash}).to_string())
                .await;

            // pdf-extract may succeed or fail on minimal PDF — either acceptable
            match result {
                Ok(json_str) => {
                    let v: serde_json::Value = serde_json::from_str(&json_str).unwrap();
                    assert!(v["char_count"].is_number());
                }
                Err(e) => {
                    assert!(!e.to_string().contains("panicked"));
                }
            }
        }

        #[tokio::test]
        async fn pdf_extract_cancelled_workflow() {
            let (_dir, ctx) = setup().await;
            ctx.cancel.cancel();
            let op = PdfExtractOp;
            let result = op.execute(serde_json::json!({"hash": "x"}), &ctx).await;
            assert!(result.is_err());
            assert!(result.unwrap_err().to_string().contains("cancelled"));
        }

        #[tokio::test]
        async fn pipeline_import_then_pdf_extract() {
            let (_dir, ctx) = setup().await;

            // Import a PDF file
            let pdf = fixture_pdf();
            let tmp = tempfile::NamedTempFile::new().unwrap();
            std::fs::write(tmp.path(), &pdf).unwrap();

            let import_result = ImportOp
                .execute(
                    serde_json::json!({"path": tmp.path().to_string_lossy()}),
                    &ctx,
                )
                .await
                .unwrap();

            let hash = if let MediaOpResult::Metadata(v) = import_result {
                v["hash"].as_str().unwrap().to_string()
            } else {
                panic!("expected Metadata from import");
            };

            // Extract text from the imported PDF
            let pdf_result = PdfExtractOp
                .execute(serde_json::json!({"hash": hash}), &ctx)
                .await;

            // May succeed or fail on minimal PDF — not a panic
            match pdf_result {
                Ok(MediaOpResult::Metadata(v)) => {
                    assert!(v["char_count"].is_number());
                }
                Err(e) => {
                    assert!(!e.to_string().contains("panicked"));
                }
                _ => panic!("unexpected result type"),
            }
        }
    }

    // ═══════════════════════════════════════════════════════════════
    // create_media_tool_adapters: registration count with features
    // ═══════════════════════════════════════════════════════════════

    #[test]
    fn import_is_in_tool_list() {
        let dir = tempfile::tempdir().unwrap();
        let ctx = Arc::new(MediaToolContext::new(CasStore::new(dir.path())));
        let tools = crate::runtime::builtin::media::create_media_tool_adapters(ctx);

        let names: Vec<&str> = tools.iter().map(|t| t.name()).collect();
        assert!(
            names.contains(&"import"),
            "import should be in tool list: {:?}",
            names
        );

        // import should be first (before dimensions)
        assert_eq!(names[0], "import", "import should be first tool");
    }

    #[test]
    fn all_tool_names_unique() {
        let dir = tempfile::tempdir().unwrap();
        let ctx = Arc::new(MediaToolContext::new(CasStore::new(dir.path())));
        let tools = crate::runtime::builtin::media::create_media_tool_adapters(ctx);

        let names: Vec<&str> = tools.iter().map(|t| t.name()).collect();
        let mut sorted = names.clone();
        sorted.sort();
        sorted.dedup();
        assert_eq!(
            names.len(),
            sorted.len(),
            "tool names must be unique: {:?}",
            names
        );
    }

    #[test]
    fn all_tools_have_description() {
        let dir = tempfile::tempdir().unwrap();
        let ctx = Arc::new(MediaToolContext::new(CasStore::new(dir.path())));
        let tools = crate::runtime::builtin::media::create_media_tool_adapters(ctx);

        for tool in &tools {
            assert!(
                !tool.description().is_empty(),
                "tool '{}' should have a description",
                tool.name()
            );
        }
    }

    #[test]
    fn all_tools_have_valid_schema() {
        let dir = tempfile::tempdir().unwrap();
        let ctx = Arc::new(MediaToolContext::new(CasStore::new(dir.path())));
        let tools = crate::runtime::builtin::media::create_media_tool_adapters(ctx);

        for tool in &tools {
            let schema = tool.parameters_schema();
            assert!(
                schema.is_object(),
                "tool '{}' schema should be an object, got: {:?}",
                tool.name(),
                schema
            );
            assert_eq!(
                schema["type"],
                "object",
                "tool '{}' schema type should be 'object'",
                tool.name()
            );
        }
    }
}