nightporter 0.4.5

Handles your PRs while you're away: an agentic night shift for GitHub and GitLab
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
//! SQLite state shared by the daemon and any number of TUIs (WAL mode).

use crate::forge::{Event, RepoId, Target};
use anyhow::{Context, Result, bail};
use rusqlite::{Connection, OptionalExtension, params};
use serde::{Deserialize, Serialize};
use std::path::Path;

pub struct Db(pub Connection);

/// Where an event is in its life. Intake files it as `pending`, `inbox` or `dropped`; after that
/// the only moves are [`Disposition::can_become`]'s (a job finding an event on the PR itself,
/// [`Db::take_event`], takes it whatever it was):
///
/// ```text
/// inbox ──allow──▶ pending ──job──▶ taken ──requeue──▶ pending
///   │ ▲              │
/// ignore/deny  unignore   cap reached
///   ▼ │              ▼
/// dropped ◀──────────┘
/// ```
#[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum Disposition {
    /// Trusted; will be batched into a job.
    Pending,
    /// Untrusted author; waits in the inbox.
    Inbox,
    /// Taken by a job.
    Taken,
    /// Ignored (filtered, denied or dismissed). Kept for history.
    Dropped,
}

impl Disposition {
    pub fn can_become(self, to: Disposition) -> bool {
        use Disposition::{Dropped, Inbox, Pending, Taken};
        matches!((self, to), (Inbox, Pending | Dropped) | (Dropped, Inbox) | (Pending, Taken | Dropped) | (Taken, Pending))
    }
}

/// A job's lifecycle. [`JobStatus::can_become`] is the whole table; [`Db::transition`] and
/// [`Db::update_job`] refuse anything else, so a TUI and the daemon racing on one job can't
/// overwrite each other (the loser gets "changed state; reload").
///
/// ```text
///            ┌──────────▶ rejected ◀───────── (any waiting state)
///            │
/// queued ──▶ running ──┬──▶ done | failed
///   ▲                  ├──▶ awaiting_run_approval ──approve──▶ queued
///   │                  ├──▶ awaiting_approval ──approve──▶ approved ──▶ done | failed
///   │                  ├──▶ approved (auto, clean checks)
///   │                  └──▶ ready (suggest) ──approve──▶ done
///   └─ a daemon error before running ──▶ failed
///
/// any settled state ──dismiss──▶ dismissed ──restore──▶ the state it came from
/// ```
#[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum JobStatus {
    Queued,
    Running,
    /// Waiting for the user to approve push/post (draft or escalated).
    AwaitingApproval,
    /// Approved in the TUI; the daemon will push/post.
    Approved,
    /// `suggest` level: result ready for the user to copy.
    Ready,
    /// Needs the user's OK to run untrusted code (env setup / tests).
    AwaitingRunApproval,
    Done,
    Failed,
    Rejected,
    /// Put away without acting (nothing pushed or posted). Undo with restore.
    Dismissed,
}

impl JobStatus {
    pub fn as_str(self) -> &'static str {
        match self {
            JobStatus::Queued => "queued",
            JobStatus::Running => "running",
            JobStatus::AwaitingApproval => "awaiting_approval",
            JobStatus::Approved => "approved",
            JobStatus::Ready => "ready",
            JobStatus::AwaitingRunApproval => "awaiting_run_approval",
            JobStatus::Done => "done",
            JobStatus::Failed => "failed",
            JobStatus::Rejected => "rejected",
            JobStatus::Dismissed => "dismissed",
        }
    }
    pub fn parse(s: &str) -> Self {
        serde_json::from_value(serde_json::Value::String(s.into())).unwrap_or(JobStatus::Failed)
    }
    /// Human label for the TUI (never colour-only).
    pub fn label(self) -> &'static str {
        match self {
            JobStatus::Queued => "queued",
            JobStatus::Running => "running",
            JobStatus::AwaitingApproval => "NEEDS APPROVAL",
            JobStatus::Approved => "approved, pushing",
            JobStatus::Ready => "ready to copy",
            JobStatus::AwaitingRunApproval => "NEEDS RUN APPROVAL",
            JobStatus::Done => "done",
            JobStatus::Failed => "FAILED",
            JobStatus::Rejected => "rejected",
            JobStatus::Dismissed => "dismissed",
        }
    }
    pub const ALL: [JobStatus; 10] = [
        JobStatus::Queued,
        JobStatus::Running,
        JobStatus::AwaitingApproval,
        JobStatus::Approved,
        JobStatus::Ready,
        JobStatus::AwaitingRunApproval,
        JobStatus::Done,
        JobStatus::Failed,
        JobStatus::Rejected,
        JobStatus::Dismissed,
    ];
    /// Waiting for a decision from you.
    pub fn needs_user(self) -> bool {
        matches!(self, JobStatus::AwaitingApproval | JobStatus::AwaitingRunApproval | JobStatus::Ready)
    }
    /// The daemon owns it: queued, running or delivering. You can't change it (reject a queued one).
    pub fn is_active(self) -> bool {
        matches!(self, JobStatus::Queued | JobStatus::Running | JobStatus::Approved)
    }
    /// Blocks a new job on the same PR (one job per PR at a time). A `ready` suggestion doesn't:
    /// it never touches the PR.
    pub fn holds_pr(self) -> bool {
        (self.is_active() || self.needs_user()) && self != JobStatus::Ready
    }
    /// The whole transition table (see the diagram on [`JobStatus`]).
    pub fn can_become(self, to: JobStatus) -> bool {
        use JobStatus::{Approved, AwaitingApproval, AwaitingRunApproval, Dismissed, Done, Failed, Queued, Ready, Rejected, Running};
        match (self, to) {
            (Queued, Running | Rejected | Failed)
            | (Running, Done | Failed | AwaitingRunApproval | AwaitingApproval | Approved | Ready)
            | (AwaitingRunApproval, Queued)
            | (AwaitingApproval, Approved)
            | (Approved, Done | Failed)
            | (Ready, Done)
            | (AwaitingRunApproval | AwaitingApproval | Ready, Rejected) => true,
            (from, Dismissed) => !from.is_active() && from != Dismissed,
            (Dismissed, back) => !back.is_active() && back != Dismissed,
            _ => false,
        }
    }
    /// Reject: a queued job or one waiting for you. (A dismissed job only restores to `rejected`.)
    pub fn can_reject(self) -> bool {
        self == JobStatus::Queued || self.needs_user()
    }
    /// What you can do with a job in this state, as `nightporter <action> <id>` (and the TUI keys).
    pub fn actions(self) -> Vec<&'static str> {
        let mut a = Vec::new();
        if self.needs_user() {
            a.push("approve");
        }
        if self.can_reject() {
            a.push("reject");
        }
        if self.can_become(JobStatus::Dismissed) {
            a.push("dismiss");
        }
        if self == JobStatus::Dismissed {
            a.push("restore");
        }
        if !self.is_active() && !self.needs_user() {
            a.extend(["retry", "purge"]);
        }
        a
    }
    /// `'a','b'` of every status matching `f`, for SQL `IN (...)` (built from constants only).
    fn sql(f: impl Fn(JobStatus) -> bool) -> String {
        Self::ALL.into_iter().filter(|s| f(*s)).map(|s| format!("'{}'", s.as_str())).collect::<Vec<_>>().join(",")
    }
}

#[derive(Clone, Debug, Default, Serialize, Deserialize)]
pub struct CheckResult {
    pub name: String,
    pub ok: bool,
    /// Blocking checks can't be approved past; only escalations can.
    pub blocking: bool,
    pub detail: String,
}

#[derive(Clone, Debug)]
pub struct Job {
    pub id: i64,
    pub repo: RepoId,
    pub target: Target,
    pub number: u64,
    pub mode: String,
    pub level: String,
    pub status: JobStatus,
    pub attempt: u32,
    pub created_at: i64,
    pub updated_at: i64,
    pub branch: String,
    pub head_before: String,
    pub head_after: String,
    pub summary: String,
    pub diff: String,
    pub replies: Vec<crate::forge::Reply>,
    pub checks: Vec<CheckResult>,
    pub error: String,
    pub worktree: String,
    pub meta: JobMeta,
}

impl Job {
    /// Someone else's code you haven't approved running at this head: nothing of yours (agent
    /// commands, env hooks, a take-over) may run on it.
    pub fn unapproved_code(&self) -> bool {
        self.meta.untrusted_code && !(self.meta.run_approved && self.meta.run_approved_head == self.head_before)
    }
}

/// Extra per-job data needed to deliver after approval.
#[derive(Clone, Debug, Default, Serialize, Deserialize)]
pub struct JobMeta {
    #[serde(default)]
    pub push_url: String,
    #[serde(default)]
    pub push_ref: String,
    #[serde(default)]
    pub base: String,
    #[serde(default)]
    pub verb: Option<crate::forge::Verb>,
    #[serde(default)]
    pub clone: String,
    #[serde(default)]
    pub cost_usd: Option<f64>,
    #[serde(default)]
    pub run_approved: bool,
    /// The head SHA the run approval is for; any other head needs a new approval.
    #[serde(default)]
    pub run_approved_head: String,
    #[serde(default)]
    pub untrusted_code: bool,
    #[serde(default)]
    pub build_files: Vec<String>,
    #[serde(default)]
    pub pr_url: String,
    /// The PR/MR or issue title, for notifications.
    #[serde(default)]
    pub title: String,
    /// Indexes of replies already posted (delivery can be retried without double-posting).
    #[serde(default)]
    pub posted: Vec<usize>,
    /// The PR/MR author (reviews of your own PR can't approve or request changes).
    #[serde(default)]
    pub pr_author: String,
    /// A review job's first reply is posted as a review with this outcome (already checked
    /// against `review_verdicts`).
    #[serde(default)]
    pub review: Option<crate::forge::ReviewVerdict>,
    /// The status a dismissed job had, so restore can put it back.
    #[serde(default)]
    pub dismissed_from: Option<JobStatus>,
}

pub fn now() -> i64 {
    jiff::Timestamp::now().as_second()
}

impl Db {
    pub fn open(path: &Path) -> Result<Self> {
        if let Some(d) = path.parent() {
            std::fs::create_dir_all(d)?;
        }
        let c = Connection::open(path).with_context(|| format!("open {}", path.display()))?;
        Self::init(c)
    }

    #[cfg(test)]
    pub fn memory() -> Result<Self> {
        Self::init(Connection::open_in_memory()?)
    }

    fn init(c: Connection) -> Result<Self> {
        c.busy_timeout(std::time::Duration::from_secs(5))?;
        c.execute_batch(
            "PRAGMA journal_mode=WAL;
             PRAGMA synchronous=NORMAL;
             PRAGMA foreign_keys=ON;
             CREATE TABLE IF NOT EXISTS events(
               id TEXT PRIMARY KEY, repo TEXT NOT NULL, target TEXT NOT NULL, number INTEGER NOT NULL,
               author TEXT NOT NULL, disposition TEXT NOT NULL, reason TEXT NOT NULL DEFAULT '',
               job_id INTEGER, seen_at INTEGER NOT NULL, json TEXT NOT NULL);
             CREATE INDEX IF NOT EXISTS events_pending ON events(disposition, repo, number);
             CREATE TABLE IF NOT EXISTS jobs(
               id INTEGER PRIMARY KEY AUTOINCREMENT, repo TEXT NOT NULL, target TEXT NOT NULL,
               number INTEGER NOT NULL, mode TEXT NOT NULL, level TEXT NOT NULL, status TEXT NOT NULL,
               attempt INTEGER NOT NULL DEFAULT 1, created_at INTEGER NOT NULL, updated_at INTEGER NOT NULL,
               branch TEXT NOT NULL DEFAULT '', head_before TEXT NOT NULL DEFAULT '',
               head_after TEXT NOT NULL DEFAULT '', summary TEXT NOT NULL DEFAULT '',
               diff TEXT NOT NULL DEFAULT '', replies TEXT NOT NULL DEFAULT '[]',
               checks TEXT NOT NULL DEFAULT '[]', error TEXT NOT NULL DEFAULT '',
               worktree TEXT NOT NULL DEFAULT '', meta TEXT NOT NULL DEFAULT '{}');
             CREATE INDEX IF NOT EXISTS jobs_status ON jobs(status);
             CREATE INDEX IF NOT EXISTS jobs_pr ON jobs(repo, number);
             CREATE TABLE IF NOT EXISTS job_log(job_id INTEGER NOT NULL, ts INTEGER NOT NULL, line TEXT NOT NULL);
             CREATE INDEX IF NOT EXISTS job_log_job ON job_log(job_id);
             CREATE TABLE IF NOT EXISTS kv(k TEXT PRIMARY KEY, v TEXT NOT NULL);",
        )?;
        Ok(Db(c))
    }

    // ---- kv ----
    pub fn get(&self, k: &str) -> Result<Option<String>> {
        Ok(self.0.query_row("SELECT v FROM kv WHERE k=?1", [k], |r| r.get(0)).optional()?)
    }
    pub fn set(&self, k: &str, v: &str) -> Result<()> {
        self.0.execute("INSERT INTO kv(k,v) VALUES(?1,?2) ON CONFLICT(k) DO UPDATE SET v=excluded.v", [k, v])?;
        Ok(())
    }
    pub fn get_json<T: for<'de> Deserialize<'de> + Default>(&self, k: &str) -> Result<T> {
        Ok(self.get(k)?.and_then(|s| serde_json::from_str(&s).ok()).unwrap_or_default())
    }
    pub fn set_json<T: Serialize>(&self, k: &str, v: &T) -> Result<()> {
        self.set(k, &serde_json::to_string(v)?)
    }

    // ---- events ----
    /// Insert if new. Returns false when the event was already seen.
    /// How many events from `author` on `repo` are waiting in the inbox.
    pub fn inbox_count(&self, repo: &RepoId, author: &str) -> Result<usize> {
        let n: i64 = self.0.query_row(
            "SELECT COUNT(*) FROM events WHERE disposition = 'inbox' AND repo = ?1 AND author = ?2 COLLATE NOCASE",
            params![repo.key(), author],
            |r| r.get(0),
        )?;
        Ok(usize::try_from(n)?)
    }

    pub fn has_event(&self, id: &str) -> Result<bool> {
        Ok(self.0.query_row("SELECT 1 FROM events WHERE id = ?1", [id], |_| Ok(())).optional()?.is_some())
    }

    pub fn add_event(&self, e: &Event, d: Disposition, reason: &str) -> Result<bool> {
        let n = self.0.execute(
            "INSERT OR IGNORE INTO events(id,repo,target,number,author,disposition,reason,seen_at,json)
             VALUES(?1,?2,?3,?4,?5,?6,?7,?8,?9)",
            params![
                e.id,
                e.repo.key(),
                enum_str(&e.target),
                // Forge PR/issue numbers are far below 2^63; stored as-is and read back with cast_unsigned.
                e.number.cast_signed(),
                e.author,
                enum_str(&d),
                reason,
                now(),
                serde_json::to_string(e)?
            ],
        )?;
        Ok(n == 1)
    }

    /// Move one event `from` → `to`. `false`: it wasn't in `from` (someone else moved it).
    pub fn move_event(&self, id: &str, from: Disposition, to: Disposition, reason: &str) -> Result<bool> {
        anyhow::ensure!(from.can_become(to), "bug: an event can't go from {from:?} to {to:?}");
        Ok(self.0.execute(
            "UPDATE events SET disposition=?3, reason=?4 WHERE id=?1 AND disposition=?2",
            params![id, enum_str(&from), enum_str(&to), reason],
        )? == 1)
    }

    /// Re-classify every inbox event by `author` (after "allow always" / "deny").
    /// `repo`: only that repo's events (a per-repo decision must not release other repos').
    pub fn set_author_disposition(&self, author: &str, repo: Option<&RepoId>, d: Disposition, reason: &str) -> Result<usize> {
        anyhow::ensure!(Disposition::Inbox.can_become(d), "bug: an inbox event can't become {d:?}");
        Ok(self.0.execute(
            "UPDATE events SET disposition=?2, reason=?3 WHERE disposition='inbox' AND author=?1 COLLATE NOCASE
               AND (?4 IS NULL OR repo=?4)",
            params![author, enum_str(&d), reason, repo.map(RepoId::key)],
        )?)
    }

    pub fn events_with(&self, d: Disposition) -> Result<Vec<(Event, i64)>> {
        self.events_where(d, "ORDER BY seen_at")
    }

    /// Inbox events you ignored (not those dropped by filters or a deny), newest first.
    pub fn ignored_events(&self) -> Result<Vec<(Event, i64)>> {
        self.events_where(Disposition::Dropped, "AND reason='ignored' ORDER BY seen_at DESC")
    }

    /// `tail`: a fixed SQL suffix (conditions and order), never user input.
    fn events_where(&self, d: Disposition, tail: &str) -> Result<Vec<(Event, i64)>> {
        let mut st = self.0.prepare(&format!("SELECT json, seen_at FROM events WHERE disposition=?1 {tail}"))?;
        let rows = st.query_map([enum_str(&d)], |r| Ok((r.get::<_, String>(0)?, r.get::<_, i64>(1)?)))?;
        let mut out = Vec::new();
        for row in rows {
            let (json, seen) = row?;
            out.push((serde_json::from_str(&json)?, seen));
        }
        Ok(out)
    }

    /// Put a job's events back in the queue (e.g. the branch moved under us).
    /// A re-queued CI-fix doesn't count as a new attempt: give the attempt back.
    pub fn requeue_events(&self, job_id: i64) -> Result<usize> {
        let evs = self.job_events(job_id)?;
        if let Some(e) = evs.iter().find(|e| e.trigger == crate::forge::Trigger::CiFailure) {
            let n = self.ci_attempts(&e.repo, e.number)?;
            self.set_ci_attempts(&e.repo, e.number, n.saturating_sub(1))?;
        }
        Ok(self.0.execute("UPDATE events SET disposition='pending', job_id=NULL, seen_at=?2 WHERE job_id=?1", params![job_id, now()])?)
    }

    pub fn job_events(&self, job_id: i64) -> Result<Vec<Event>> {
        let mut st = self.0.prepare("SELECT json FROM events WHERE job_id=?1 ORDER BY seen_at")?;
        let rows = st.query_map([job_id], |r| r.get::<_, String>(0))?;
        rows.map(|j| Ok(serde_json::from_str(&j?)?)).collect()
    }

    /// Give a running job one more event, whatever happened to it before (never seen, dropped,
    /// still pending): the job found it on the PR itself.
    pub fn take_event(&self, job_id: i64, e: &Event) -> Result<()> {
        self.add_event(e, Disposition::Taken, "open review thread")?;
        self.0.execute("UPDATE events SET disposition='taken', job_id=?2 WHERE id=?1", params![e.id, job_id])?;
        Ok(())
    }

    // ---- jobs ----
    /// Create a job and atomically take the given pending events.
    pub fn create_job(&mut self, repo: &RepoId, target: Target, number: u64, mode: &str, level: &str, event_ids: &[String]) -> Result<i64> {
        let tx = self.0.transaction()?;
        let attempt: u32 = tx.query_row(
            &format!(
                "SELECT COUNT(*) FROM jobs WHERE repo=?1 AND number=?2 AND status IN ('{}','{}') AND created_at > ?3",
                JobStatus::Failed.as_str(),
                JobStatus::Done.as_str()
            ),
            params![repo.key(), number.cast_signed(), now() - 86400],
            |r| r.get(0),
        )?;
        tx.execute(
            "INSERT INTO jobs(repo,target,number,mode,level,status,attempt,created_at,updated_at)
             VALUES(?1,?2,?3,?4,?5,'queued',?6,?7,?7)",
            params![repo.key(), enum_str(&target), number.cast_signed(), mode, level, attempt + 1, now()],
        )?;
        let id = tx.last_insert_rowid();
        for e in event_ids {
            tx.execute("UPDATE events SET disposition='taken', job_id=?2 WHERE id=?1", params![e, id])?;
        }
        tx.commit()?;
        Ok(id)
    }

    pub fn set_meta(&self, id: i64, meta: &JobMeta) -> Result<()> {
        self.0.execute("UPDATE jobs SET meta=?2 WHERE id=?1", params![id, serde_json::to_string(meta)?])?;
        Ok(())
    }

    /// Force a status, skipping the transition table: for seeding tests only.
    #[cfg(test)]
    pub fn set_status(&self, id: i64, s: JobStatus) -> Result<()> {
        self.0.execute("UPDATE jobs SET status=?2, updated_at=?3 WHERE id=?1", params![id, s.as_str(), now()])?;
        Ok(())
    }

    /// Transition only if the job is currently in `from` (prevents TUI/daemon races).
    pub fn transition(&self, id: i64, from: JobStatus, to: JobStatus) -> Result<bool> {
        anyhow::ensure!(from.can_become(to), "bug: a job can't go from {} to {}", from.as_str(), to.as_str());
        Ok(self.0.execute(
            "UPDATE jobs SET status=?3, updated_at=?4 WHERE id=?1 AND status=?2",
            params![id, from.as_str(), to.as_str(), now()],
        )? == 1)
    }

    /// Save `j`. Its status must be the stored one or a legal move from it
    /// ([`JobStatus::can_become`]); otherwise nothing is written and this fails with "changed
    /// state; reload" (the job moved under you, e.g. the daemon started it).
    pub fn update_job(&self, j: &Job) -> Result<()> {
        let from = JobStatus::sql(|s| s == j.status || s.can_become(j.status));
        let n = self.0.execute(
            &format!(
                "UPDATE jobs SET status=?2, level=?3, branch=?4, head_before=?5, head_after=?6, summary=?7, diff=?8,
             replies=?9, checks=?10, error=?11, worktree=?12, updated_at=?13, meta=?14 WHERE id=?1 AND status IN ({from})"
            ),
            params![
                j.id,
                j.status.as_str(),
                j.level,
                j.branch,
                j.head_before,
                j.head_after,
                j.summary,
                j.diff,
                serde_json::to_string(&j.replies)?,
                serde_json::to_string(&j.checks)?,
                j.error,
                j.worktree,
                now(),
                serde_json::to_string(&j.meta)?
            ],
        )?;
        if n == 0 {
            let now = self.job(j.id)?.map_or("gone", |k| k.status.as_str());
            bail!("job {} changed state (it is {now} now, can't become {}); reload", j.id, j.status.as_str());
        }
        Ok(())
    }

    /// Seed a job in any state, skipping the transition table: for tests only.
    #[cfg(test)]
    pub fn seed_job(&self, j: &Job) -> Result<()> {
        self.set_status(j.id, j.status)?;
        self.update_job(j)
    }

    /// Delete a job, its log, and the events it took. Permanent.
    pub fn purge_job(&mut self, id: i64) -> Result<()> {
        let tx = self.0.transaction()?;
        tx.execute("DELETE FROM job_log WHERE job_id=?1", [id])?;
        tx.execute("DELETE FROM events WHERE job_id=?1", [id])?;
        tx.execute("DELETE FROM jobs WHERE id=?1", [id])?;
        tx.commit()?;
        Ok(())
    }

    /// Fail a job the daemon still owns. `false`: it had already settled (done, waiting for
    /// you, ...), which an error afterwards mustn't overwrite.
    pub fn fail(&self, id: i64, err: &str) -> Result<bool> {
        let from = JobStatus::sql(|s| s.can_become(JobStatus::Failed));
        Ok(self.0.execute(
            &format!("UPDATE jobs SET status='failed', error=?2, updated_at=?3 WHERE id=?1 AND status IN ({from})"),
            params![id, err, now()],
        )? == 1)
    }

    pub fn job(&self, id: i64) -> Result<Option<Job>> {
        Ok(self.0.query_row(&format!("{JOB_SELECT} WHERE id=?1"), [id], row_job).optional()?)
    }

    pub fn jobs_with(&self, s: JobStatus) -> Result<Vec<Job>> {
        let mut st = self.0.prepare(&format!("{JOB_LIST} WHERE status=?1 ORDER BY id"))?;
        let rows = st.query_map([s.as_str()], row_job)?;
        Ok(rows.collect::<Result<_, _>>()?)
    }

    pub fn recent_jobs(&self, limit: usize) -> Result<Vec<Job>> {
        let mut st = self.0.prepare(&format!("{JOB_LIST} ORDER BY id DESC LIMIT ?1"))?;
        let rows = st.query_map([i64::try_from(limit).unwrap_or(i64::MAX)], row_job)?;
        Ok(rows.collect::<Result<_, _>>()?)
    }

    /// The newest job on each PR/issue that a `/nightporter` command on the forge may act on:
    /// waiting for you, or updated since `since` (bounds the API calls per poll).
    pub fn command_jobs(&self, since: i64) -> Result<Vec<Job>> {
        let mut st = self.0.prepare(&format!(
            "{JOB_LIST} WHERE id IN (SELECT MAX(id) FROM jobs GROUP BY repo, target, number)
               AND (status IN ({}) OR updated_at >= ?1) ORDER BY id",
            JobStatus::sql(JobStatus::needs_user)
        ))?;
        let rows = st.query_map([since], row_job)?;
        Ok(rows.collect::<Result<_, _>>()?)
    }

    /// Any job on this PR that isn't finished (one job per PR at a time).
    pub fn pr_busy(&self, repo: &RepoId, number: u64) -> Result<bool> {
        Ok(self.0.query_row(
            &format!(
                "SELECT EXISTS(SELECT 1 FROM jobs WHERE repo=?1 AND number=?2 AND status IN ({}))",
                JobStatus::sql(JobStatus::holds_pr)
            ),
            params![repo.key(), number.cast_signed()],
            |r| r.get(0),
        )?)
    }

    pub fn jobs_since(&self, since: i64) -> Result<u32> {
        Ok(self.0.query_row("SELECT COUNT(*) FROM jobs WHERE created_at >= ?1", [since], |r| r.get(0))?)
    }

    /// Consecutive CI-fix attempts on a PR. Reset when CI goes green (see the sweep).
    pub fn ci_attempts(&self, repo: &RepoId, number: u64) -> Result<u32> {
        Ok(self.get(&format!("ci:{}#{number}", repo.key()))?.and_then(|v| v.parse().ok()).unwrap_or(0))
    }
    pub fn set_ci_attempts(&self, repo: &RepoId, number: u64, n: u32) -> Result<()> {
        self.set(&format!("ci:{}#{number}", repo.key()), &n.to_string())
    }

    /// Jobs started by a review bot's comments on a PR. Never reset: a cap per PR.
    pub fn bot_rounds(&self, repo: &RepoId, number: u64) -> Result<u32> {
        Ok(self.get(&format!("bot:{}#{number}", repo.key()))?.and_then(|v| v.parse().ok()).unwrap_or(0))
    }
    pub fn set_bot_rounds(&self, repo: &RepoId, number: u64, n: u32) -> Result<()> {
        self.set(&format!("bot:{}#{number}", repo.key()), &n.to_string())
    }

    pub fn log(&self, job: i64, line: &str) -> Result<()> {
        self.0.execute("INSERT INTO job_log(job_id,ts,line) VALUES(?1,?2,?3)", params![job, now(), line])?;
        Ok(())
    }

    pub fn job_log(&self, job: i64) -> Result<Vec<(i64, String)>> {
        let mut st = self.0.prepare("SELECT ts, line FROM job_log WHERE job_id=?1 ORDER BY rowid")?;
        let rows = st.query_map([job], |r| Ok((r.get(0)?, r.get(1)?)))?;
        Ok(rows.collect::<Result<_, _>>()?)
    }

    /// On daemon start: anything left `running` died with the previous daemon.
    /// Jobs left `running` died with the previous daemon: fail them and re-queue their events.
    /// (`approved` jobs are simply delivered again; delivery is idempotent.)
    pub fn recover(&self) -> Result<usize> {
        let ids: Vec<i64> =
            self.0.prepare("SELECT id FROM jobs WHERE status='running'")?.query_map([], |r| r.get(0))?.collect::<Result<_, _>>()?;
        for id in ids {
            self.requeue_events(id)?;
        }
        Ok(self.0.execute(
            "UPDATE jobs SET status='failed', error='daemon restarted while job was running; re-queued', updated_at=?1
             WHERE status='running'",
            [now()],
        )?)
    }

    pub fn prune(&self, retention_days: u32) -> Result<()> {
        let cutoff = now() - i64::from(retention_days) * 86400;
        self.0.execute("DELETE FROM job_log WHERE ts < ?1", [cutoff])?;
        let settled = JobStatus::sql(|s| !s.holds_pr());
        self.0.execute(&format!("DELETE FROM jobs WHERE updated_at < ?1 AND status IN ({settled})"), [cutoff])?;
        self.0.execute("DELETE FROM events WHERE seen_at < ?1 AND disposition IN ('taken','dropped','inbox')", [cutoff])?;
        Ok(())
    }
}

const JOB_SELECT: &str = "SELECT id, repo, target, number, mode, level, status, attempt, created_at, updated_at,
  branch, head_before, head_after, summary, diff, replies, checks, error, worktree, meta FROM jobs";
/// Same columns without the diff (can be megabytes). For lists only: never pass a job loaded
/// this way to `update_job`, it would clear the stored diff.
const JOB_LIST: &str = "SELECT id, repo, target, number, mode, level, status, attempt, created_at, updated_at,
  branch, head_before, head_after, summary, '' AS diff, replies, checks, error, worktree, meta FROM jobs";

fn row_job(r: &rusqlite::Row) -> rusqlite::Result<Job> {
    let repo: String = r.get(1)?;
    let target: String = r.get(2)?;
    Ok(Job {
        id: r.get(0)?,
        repo: RepoId::parse_key(&repo).ok_or(rusqlite::Error::InvalidQuery)?,
        target: if target == "issue" { Target::Issue } else { Target::Pr },
        // Written with cast_signed: the bit-exact inverse.
        number: r.get::<_, i64>(3)?.cast_unsigned(),
        mode: r.get(4)?,
        level: r.get(5)?,
        status: JobStatus::parse(&r.get::<_, String>(6)?),
        attempt: r.get(7)?,
        created_at: r.get(8)?,
        updated_at: r.get(9)?,
        branch: r.get(10)?,
        head_before: r.get(11)?,
        head_after: r.get(12)?,
        summary: r.get(13)?,
        diff: r.get(14)?,
        replies: serde_json::from_str(&r.get::<_, String>(15)?).unwrap_or_default(),
        checks: serde_json::from_str(&r.get::<_, String>(16)?).unwrap_or_default(),
        error: r.get(17)?,
        worktree: r.get(18)?,
        meta: serde_json::from_str(&r.get::<_, String>(19)?).unwrap_or_default(),
    })
}

/// Serialise a unit enum to its serde name.
pub fn enum_str<T: Serialize>(v: &T) -> String {
    serde_json::to_value(v).ok().and_then(|v| v.as_str().map(String::from)).unwrap_or_default()
}

#[cfg(test)]
pub(crate) mod tests {
    use super::*;
    use crate::forge::{ForgeKind, Role, Trigger};

    pub fn ev(id: &str, n: u64) -> Event {
        Event {
            id: id.into(),
            repo: RepoId::new(ForgeKind::GitHub, "github.com", "o/r"),
            target: Target::Pr,
            number: n,
            trigger: Trigger::ReviewComment,
            author: "alice".into(),
            author_id: 0,
            role: Role::Member,
            is_bot: false,
            body: "fix".into(),
            url: String::new(),
            thread: None,
            path: None,
            line: None,
            created_at: String::new(),
            verb: None,
        }
    }

    #[test]
    fn events_dedupe_and_jobs_take_them() {
        let mut db = Db::memory().unwrap();
        let e = ev("a", 1);
        assert!(db.add_event(&e, Disposition::Pending, "").unwrap());
        assert!(!db.add_event(&e, Disposition::Pending, "").unwrap());
        db.add_event(&ev("b", 1), Disposition::Inbox, "").unwrap();
        assert_eq!(db.events_with(Disposition::Pending).unwrap().len(), 1);
        let id = db.create_job(&e.repo, Target::Pr, 1, "my_prs", "draft", &["a".into()]).unwrap();
        assert!(db.pr_busy(&e.repo, 1).unwrap());
        assert_eq!(db.events_with(Disposition::Pending).unwrap().len(), 0);
        assert_eq!(db.job_events(id).unwrap(), vec![e.clone()]);
        let other = RepoId::new(ForgeKind::GitHub, "github.com", "x/y");
        assert_eq!(db.set_author_disposition("ALICE", Some(&other), Disposition::Pending, "allow").unwrap(), 0);
        assert_eq!(db.set_author_disposition("ALICE", Some(&e.repo), Disposition::Pending, "allow").unwrap(), 1);
    }

    #[test]
    fn transitions_are_guarded() {
        let mut db = Db::memory().unwrap();
        let r = RepoId::new(ForgeKind::GitHub, "github.com", "o/r");
        let id = db.create_job(&r, Target::Pr, 2, "my_prs", "draft", &[]).unwrap();
        assert!(!db.transition(id, JobStatus::AwaitingApproval, JobStatus::Approved).unwrap());
        db.set_status(id, JobStatus::AwaitingApproval).unwrap();
        assert!(db.transition(id, JobStatus::AwaitingApproval, JobStatus::Approved).unwrap());
        assert_eq!(db.job(id).unwrap().unwrap().status, JobStatus::Approved);
        for s in [JobStatus::AwaitingRunApproval, JobStatus::Ready, JobStatus::Rejected] {
            assert_eq!(JobStatus::parse(s.as_str()), s);
        }
    }

    #[test]
    fn lifecycle_table_is_sound() {
        use JobStatus::*;
        // Every state is reachable from `queued`, and every non-final one has a way out.
        let mut seen = vec![Queued];
        while let Some(s) = JobStatus::ALL.into_iter().find(|t| !seen.contains(t) && seen.iter().any(|f| f.can_become(*t))) {
            seen.push(s);
        }
        assert_eq!(
            seen.len(),
            JobStatus::ALL.len(),
            "unreachable: {:?}",
            JobStatus::ALL.iter().filter(|s| !seen.contains(s)).collect::<Vec<_>>()
        );
        for s in JobStatus::ALL {
            assert_eq!(JobStatus::parse(s.as_str()), s);
            assert!(!s.can_become(s), "{s:?} -> itself is a save, not a transition");
            assert!(JobStatus::ALL.iter().any(|t| s.can_become(*t)), "{s:?} is a dead end");
        }
        // You never take a job away from the daemon, and nothing skips your approval.
        for from in [Queued, Running, Approved] {
            assert!(!from.can_become(Dismissed));
        }
        assert!(!Running.can_become(Rejected));
        assert!(!AwaitingApproval.can_become(Done) && !AwaitingRunApproval.can_become(Running));
        assert_eq!(Ready.actions(), ["approve", "reject", "dismiss"]);
        assert_eq!(Running.actions(), Vec::<&str>::new());
        assert_eq!(Dismissed.actions(), ["restore", "retry", "purge"]);
    }

    #[test]
    fn saves_refuse_illegal_or_stale_moves() {
        let mut db = Db::memory().unwrap();
        let r = RepoId::new(ForgeKind::GitHub, "github.com", "o/r");
        let id = db.create_job(&r, Target::Pr, 4, "my_prs", "draft", &[]).unwrap();
        let tui_copy = db.job(id).unwrap().unwrap();
        assert!(db.transition(id, JobStatus::Queued, JobStatus::Running).unwrap(), "the daemon starts it");
        // A stale copy can't drag it back, and an illegal move is a bug, not a no-op.
        assert!(db.update_job(&tui_copy).unwrap_err().to_string().contains("changed state"));
        assert!(db.transition(id, JobStatus::Running, JobStatus::Queued).is_err());
        assert!(!db.transition(id, JobStatus::Queued, JobStatus::Rejected).unwrap());
        db.set_status(id, JobStatus::AwaitingApproval).unwrap();
        assert!(!db.fail(id, "late error").unwrap(), "an error after settling doesn't overwrite it");
        assert_eq!(db.job(id).unwrap().unwrap().status, JobStatus::AwaitingApproval);
        // Events: only from the state they're in.
        db.add_event(&ev("t", 4), Disposition::Pending, "").unwrap();
        db.create_job(&r, Target::Pr, 4, "my_prs", "draft", &["t".into()]).unwrap();
        assert!(!db.move_event("t", Disposition::Inbox, Disposition::Pending, "").unwrap(), "a taken event isn't in the inbox");
        assert!(db.move_event("t", Disposition::Taken, Disposition::Inbox, "").is_err());
    }

    #[test]
    fn recover_fails_running() {
        let mut db = Db::memory().unwrap();
        let r = RepoId::new(ForgeKind::GitHub, "github.com", "o/r");
        let id = db.create_job(&r, Target::Pr, 3, "my_prs", "draft", &[]).unwrap();
        db.set_status(id, JobStatus::Running).unwrap();
        assert_eq!(db.recover().unwrap(), 1);
        assert_eq!(db.job(id).unwrap().unwrap().status, JobStatus::Failed);
        // Its events are pending again.
        let mut db2 = Db::memory().unwrap();
        db2.add_event(&ev("x", 9), Disposition::Pending, "").unwrap();
        let j = db2.create_job(&r, Target::Pr, 9, "my_prs", "draft", &["x".into()]).unwrap();
        db2.set_status(j, JobStatus::Running).unwrap();
        db2.recover().unwrap();
        assert_eq!(db2.events_with(Disposition::Pending).unwrap().len(), 1);
    }
}