nexo-core 0.2.1

Agent runtime: event bus, sessions, plugin trait, heartbeat, A2A delegation.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
//! Admin RPC audit log writer.
//!
//! Records every admin call with `(microapp_id, method,
//! capability, args_hash, started_at, result, duration_ms)`.
//! Operator audit pipelines parse these rows for SaaS billing /
//! compliance.
//!
//! This module provides an in-memory writer behind a trait.
//! Production builds use [`InMemoryAuditWriter`]. Tests inject
//! their own implementations via [`AdminAuditWriter`]. The
//! SQLite-backed writer with a retention sweep lives in
//! `audit_sqlite`.

use std::sync::{Arc, Mutex};
use std::time::SystemTime;

use serde_json::Value;
use sha2::{Digest, Sha256};

// `AdminAuditRow`, `AdminAuditResult`, `AuditTailFilter`, and
// `AuditTailPage` live in `nexo-tool-meta` so the ts-types-codegen
// pipeline generates their TypeScript declarations. Re-exported here so
// existing consumers (`use nexo_core::agent::admin_rpc::audit::AdminAuditRow`)
// keep resolving without per-file edits.
pub use nexo_tool_meta::admin::audit::{
    AdminAuditResult, AdminAuditRow, AuditTailFilter, AuditTailPage,
};

/// Audit writer abstraction. Async to keep the SQLite-backed
/// implementation plug-compatible without changing this trait.
#[async_trait::async_trait]
pub trait AdminAuditWriter: Send + Sync + std::fmt::Debug {
    /// Append one row. Errors are logged but not propagated —
    /// audit failures must never block admin dispatch.
    async fn append(&self, row: AdminAuditRow);
}

/// Read-side trait for the
/// `nexo/admin/microapp_audit/tail` admin RPC. Separated from
/// [`AdminAuditWriter`] so the dispatcher can wire write + read
/// independently (matches the `transcript_reader` pattern).
/// `SqliteAuditWriter` implements both.
#[async_trait::async_trait]
pub trait AdminAuditReader: Send + Sync + std::fmt::Debug {
    /// Return one paginated page of audit rows matching `filter`.
    /// Newest-first order.
    async fn tail(&self, filter: &AuditTailFilter) -> anyhow::Result<AuditTailPage>;
}

/// In-memory writer used in tests + as the default production
/// writer when SQLite persistence is not configured.
#[derive(Debug, Default, Clone)]
pub struct InMemoryAuditWriter {
    rows: Arc<Mutex<Vec<AdminAuditRow>>>,
}

impl InMemoryAuditWriter {
    /// Build an empty writer.
    pub fn new() -> Self {
        Self::default()
    }

    /// Snapshot of recorded rows (test-only inspection).
    pub fn rows(&self) -> Vec<AdminAuditRow> {
        self.rows.lock().unwrap().clone()
    }

    /// Last row appended, if any.
    pub fn last(&self) -> Option<AdminAuditRow> {
        self.rows.lock().unwrap().last().cloned()
    }
}

#[async_trait::async_trait]
impl AdminAuditWriter for InMemoryAuditWriter {
    async fn append(&self, row: AdminAuditRow) {
        self.rows.lock().unwrap().push(row);
    }
}

/// Hash JSON params canonically (sorted keys) so repeated calls
/// with semantically-identical payloads produce identical
/// hashes. Operator audit pipelines use this to detect
/// duplicate-call abuse without storing the params themselves.
pub fn hash_params(params: &Value) -> String {
    let canonical = canonicalize(params);
    let serialized = serde_json::to_string(&canonical).unwrap_or_default();
    let digest = Sha256::digest(serialized.as_bytes());
    hex_encode(&digest)
}

/// Redact sensitive fields per-method BEFORE hashing for the
/// audit row. Without this, low-entropy values (e.g. operator
/// pasting `"test"`) could be brute-forced from the stored hash.
///
/// Called from the dispatcher before [`hash_params`].
///
/// `secrets/write` redacts `value`. Future methods that carry
/// secret-grade fields hook in here.
///
/// `credentials/register` redacts secret-grade
/// keys inside `payload` + `metadata` (token, password,
/// xoauth2_token, api_key, secret). The
/// [`ChannelCredentialPersister`] family routes structured
/// payloads through here, so the audit hash is invariant to the
/// secret material.
///
/// [`ChannelCredentialPersister`]: super::domains::credentials::ChannelCredentialPersister
pub fn redact_for_audit(method: &str, params: &Value) -> Value {
    if method == "nexo/admin/secrets/write" {
        if let Some(obj) = params.as_object() {
            let mut redacted = obj.clone();
            if redacted.contains_key("value") {
                redacted.insert("value".into(), Value::String("<redacted>".into()));
            }
            return Value::Object(redacted);
        }
    }
    if method == "nexo/admin/credentials/register" {
        if let Some(obj) = params.as_object() {
            let mut redacted = obj.clone();
            if let Some(payload) = redacted.get("payload").cloned() {
                redacted.insert("payload".into(), redact_secret_keys(&payload));
            }
            if let Some(metadata) = redacted.get("metadata").cloned() {
                redacted.insert("metadata".into(), redact_secret_keys(&metadata));
            }
            return Value::Object(redacted);
        }
    }
    // `llm_providers/upsert` carries
    // `api_key_secret_value` (write-through API key plaintext)
    // when the operator rotates a key from the SPA. Redact it
    // before audit so the cleartext never lands on disk; the
    // SecretsStore is the only place it persists.
    if method == "nexo/admin/llm_providers/upsert" {
        if let Some(obj) = params.as_object() {
            let mut redacted = obj.clone();
            if redacted.contains_key("api_key_secret_value") {
                redacted.insert(
                    "api_key_secret_value".into(),
                    Value::String("<redacted>".into()),
                );
            }
            // Schema-driven payload. Walk the
            // `fields` map with the same key-based redactor used
            // for credentials/register so secret-grade names
            // (api_key, setup_token, password, etc) get masked.
            // Non-secret fields (group_id, region, key_kind) stay
            // literal — useful for diagnostics. The dispatcher
            // already validated against the factory schema; this
            // is defense-in-depth for the audit trail.
            if let Some(fields) = redacted.get("fields").cloned() {
                redacted.insert("fields".into(), redact_secret_keys(&fields));
            }
            return Value::Object(redacted);
        }
    }
    params.clone()
}

/// Walk a JSON value and replace every occurrence of a known
/// secret-grade key (`token`, `password`, `xoauth2_token`,
/// `api_key`, `secret`) with `"<redacted>"`. Recurses into nested
/// objects and arrays so deeply-nested metadata (e.g.
/// `metadata.imap.password`) is covered defense-in-depth.
///
/// Recursion is bounded by serde_json's nesting limit (default
/// 128) — no separate guard needed.
fn redact_secret_keys(value: &Value) -> Value {
    const SECRET_KEYS: &[&str] = &[
        "token",
        "password",
        "xoauth2_token",
        "api_key",
        "secret",
        // Schema-driven LLM credentials.
        "setup_token",
        "access_token",
        "refresh_token",
        "oauth_bundle",
    ];
    match value {
        Value::Object(map) => {
            let mut out = serde_json::Map::with_capacity(map.len());
            for (k, v) in map {
                if SECRET_KEYS.iter().any(|s| s.eq_ignore_ascii_case(k)) {
                    out.insert(k.clone(), Value::String("<redacted>".into()));
                } else {
                    out.insert(k.clone(), redact_secret_keys(v));
                }
            }
            Value::Object(out)
        }
        Value::Array(arr) => Value::Array(arr.iter().map(redact_secret_keys).collect()),
        other => other.clone(),
    }
}

fn canonicalize(value: &Value) -> Value {
    match value {
        Value::Object(map) => {
            let mut sorted: Vec<(String, Value)> = map
                .iter()
                .map(|(k, v)| (k.clone(), canonicalize(v)))
                .collect();
            sorted.sort_by(|a, b| a.0.cmp(&b.0));
            Value::Object(sorted.into_iter().collect())
        }
        Value::Array(arr) => Value::Array(arr.iter().map(canonicalize).collect()),
        other => other.clone(),
    }
}

fn hex_encode(bytes: &[u8]) -> String {
    let mut s = String::with_capacity(bytes.len() * 2);
    for byte in bytes {
        s.push_str(&format!("{byte:02x}"));
    }
    s
}

/// Sniff `tenant_id` from JSON params for the
/// audit row. Tenant-scoped admin domains (agents/llm_providers/
/// skills/audit) pass this in the params object; non tenant-
/// scoped calls (echo, pairing, credentials) lack the field, so
/// the function returns `None` instead of stamping a fake value.
/// Returns `None` for non-string values (defensive — never panic
/// on malformed params).
pub fn extract_tenant_id(params: &Value) -> Option<String> {
    params
        .as_object()
        .and_then(|m| m.get("tenant_id"))
        .and_then(|v| v.as_str())
        .map(|s| s.to_string())
}

/// Helper used by the dispatcher to stamp `started_at_ms`.
pub fn now_epoch_ms() -> u64 {
    SystemTime::now()
        .duration_since(SystemTime::UNIX_EPOCH)
        .map(|d| d.as_millis() as u64)
        .unwrap_or(0)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn in_memory_writer_records_each_call() {
        let writer = InMemoryAuditWriter::new();
        let row = AdminAuditRow {
            microapp_id: "agent-creator".into(),
            method: "nexo/admin/agents/list".into(),
            capability: "agents_crud".into(),
            args_hash: "abc123".into(),
            started_at_ms: 1_700_000_000_000,
            result: AdminAuditResult::Ok,
            duration_ms: 5,
            tenant_id: None,
        };
        writer.append(row.clone()).await;
        assert_eq!(writer.rows().len(), 1);
        assert_eq!(writer.last().unwrap(), row);
    }

    #[tokio::test]
    async fn in_memory_writer_records_denial() {
        let writer = InMemoryAuditWriter::new();
        writer
            .append(AdminAuditRow {
                microapp_id: "agent-creator".into(),
                method: "nexo/admin/llm_providers/upsert".into(),
                capability: "llm_keys_crud".into(),
                args_hash: hash_params(&serde_json::json!({})),
                started_at_ms: now_epoch_ms(),
                result: AdminAuditResult::Denied,
                duration_ms: 0,
                tenant_id: None,
            })
            .await;
        let last = writer.last().unwrap();
        assert_eq!(last.result, AdminAuditResult::Denied);
        assert_eq!(last.capability, "llm_keys_crud");
    }

    #[test]
    fn hash_params_is_deterministic_with_key_order() {
        let a = serde_json::json!({ "z": 1, "a": 2 });
        let b = serde_json::json!({ "a": 2, "z": 1 });
        assert_eq!(hash_params(&a), hash_params(&b));
    }

    #[test]
    fn hash_params_differs_for_different_payloads() {
        let a = serde_json::json!({ "x": 1 });
        let b = serde_json::json!({ "x": 2 });
        assert_ne!(hash_params(&a), hash_params(&b));
    }

    #[test]
    fn audit_result_as_str_table() {
        assert_eq!(AdminAuditResult::Ok.as_str(), "ok");
        assert_eq!(AdminAuditResult::Error.as_str(), "error");
        assert_eq!(AdminAuditResult::Denied.as_str(), "denied");
    }

    /// `secrets/write` redacts the `value`
    /// field BEFORE hashing so low-entropy values can't be
    /// brute-forced from the stored hash.
    #[test]
    fn redact_for_audit_redacts_secrets_write_value() {
        let original = serde_json::json!({
            "name": "MINIMAX_API_KEY",
            "value": "sk-leak-this-not"
        });
        let redacted = redact_for_audit("nexo/admin/secrets/write", &original);
        assert_eq!(redacted["name"], "MINIMAX_API_KEY");
        assert_eq!(redacted["value"], "<redacted>");
        // Hashes diverge — proves the redaction takes effect
        // before hashing in the dispatcher.
        assert_ne!(hash_params(&original), hash_params(&redacted));
    }

    /// `llm_providers/upsert` redacts the
    /// write-through `api_key_secret_value` field so the cleartext
    /// only persists in the SecretsStore, never on the audit log.
    #[test]
    fn redact_for_audit_redacts_llm_upsert_secret_value() {
        let original = serde_json::json!({
            "id": "minimax-cliente-a",
            "base_url": "https://api.minimax.chat/v1",
            "factory_type": "minimax",
            "api_key_secret_value": "sk-leak-this-not"
        });
        let redacted = redact_for_audit("nexo/admin/llm_providers/upsert", &original);
        assert_eq!(redacted["id"], "minimax-cliente-a");
        assert_eq!(redacted["factory_type"], "minimax");
        assert_eq!(redacted["api_key_secret_value"], "<redacted>");
        assert_ne!(hash_params(&original), hash_params(&redacted));
    }

    /// Schema-driven `fields` payload masks
    /// secret-grade keys (api_key, setup_token) but keeps
    /// non-secret identifiers (group_id, region) literal so the
    /// audit log stays useful for diagnostics.
    #[test]
    fn redact_for_audit_redacts_llm_upsert_schema_fields() {
        let original = serde_json::json!({
            "id": "minimax-cliente-a",
            "base_url": "https://api.minimax.chat/v1",
            "factory_type": "minimax",
            "auth_mode": "api_key",
            "fields": {
                "api_key": "sk-leak-this-not",
                "group_id": "1234567890123",
                "region": "global",
                "setup_token": "sk-ant-oat01-leak-too",
            }
        });
        let redacted = redact_for_audit("nexo/admin/llm_providers/upsert", &original);
        let fields = &redacted["fields"];
        assert_eq!(fields["api_key"], "<redacted>");
        assert_eq!(fields["setup_token"], "<redacted>");
        // Non-secret identifiers stay literal.
        assert_eq!(fields["group_id"], "1234567890123");
        assert_eq!(fields["region"], "global");
        // Top-level metadata also preserved.
        assert_eq!(redacted["auth_mode"], "api_key");
        assert_eq!(redacted["factory_type"], "minimax");
    }

    /// OAuth bundle JSON pasted via
    /// `api_key_secret_value` would be caught by the existing
    /// `api_key_secret_value` rule, but defense-in-depth: confirm
    /// the new SECRET_KEYS additions also fire when an operator
    /// drops a bundle into the schema-driven payload.
    #[test]
    fn redact_for_audit_masks_oauth_bundle_keys_in_fields() {
        let original = serde_json::json!({
            "id": "anthropic-personal",
            "base_url": "https://api.anthropic.com/v1",
            "factory_type": "anthropic",
            "auth_mode": "oauth_bundle_import",
            "fields": {
                "oauth_bundle": "{\"access_token\":\"sk-...\",\"refresh_token\":\"r-...\"}",
            }
        });
        let redacted = redact_for_audit("nexo/admin/llm_providers/upsert", &original);
        assert_eq!(redacted["fields"]["oauth_bundle"], "<redacted>");
    }

    /// Confirm that the redactor leaves `api_key_secret_id` intact
    /// — that field references a secret BY NAME, not value, so
    /// it's safe to surface for diagnostics.
    #[test]
    fn redact_for_audit_keeps_llm_upsert_secret_id_visible() {
        let original = serde_json::json!({
            "id": "minimax-cliente-a",
            "base_url": "https://api.minimax.chat/v1",
            "api_key_secret_id": "LLM_MINIMAX_CLIENTE_A"
        });
        let redacted = redact_for_audit("nexo/admin/llm_providers/upsert", &original);
        assert_eq!(redacted["api_key_secret_id"], "LLM_MINIMAX_CLIENTE_A");
    }

    #[test]
    fn redact_for_audit_passthrough_for_other_methods() {
        let original = serde_json::json!({"agent_id": "ana"});
        let result = redact_for_audit("nexo/admin/agents/get", &original);
        assert_eq!(result, original);
    }

    /// `credentials/register` redacts the
    /// telegram bot token in `payload.token` so the audit hash
    /// doesn't fingerprint the secret.
    #[test]
    fn redact_for_audit_redacts_telegram_token() {
        let original = serde_json::json!({
            "channel": "telegram",
            "instance": "kate",
            "agent_ids": ["kate"],
            "payload": { "token": "bot12345:ABCDEF" }
        });
        let redacted = redact_for_audit("nexo/admin/credentials/register", &original);
        assert_eq!(redacted["channel"], "telegram");
        assert_eq!(redacted["payload"]["token"], "<redacted>");
        // Hash diverges from the unredacted form.
        assert_ne!(hash_params(&original), hash_params(&redacted));
    }

    /// Email password lives in `payload.password`; xoauth2 token
    /// lives in `payload.xoauth2_token`. Both must redact.
    #[test]
    fn redact_for_audit_redacts_email_password_and_xoauth2() {
        let with_pw = serde_json::json!({
            "channel": "email",
            "instance": "ops",
            "payload": { "address": "ops@example.com", "password": "p@ss" }
        });
        let r1 = redact_for_audit("nexo/admin/credentials/register", &with_pw);
        assert_eq!(r1["payload"]["password"], "<redacted>");
        assert_eq!(r1["payload"]["address"], "ops@example.com");

        let with_xoauth = serde_json::json!({
            "channel": "email",
            "instance": "ops",
            "payload": { "address": "ops@example.com", "xoauth2_token": "xo.AAA" }
        });
        let r2 = redact_for_audit("nexo/admin/credentials/register", &with_xoauth);
        assert_eq!(r2["payload"]["xoauth2_token"], "<redacted>");
    }

    /// Defense-in-depth: secret-grade keys nested inside
    /// `metadata.*` (operator could fat-finger a password into
    /// metadata) also redact.
    #[test]
    fn redact_for_audit_redacts_nested_metadata_secrets() {
        let original = serde_json::json!({
            "channel": "email",
            "payload": { "address": "ops@example.com" },
            "metadata": {
                "imap": { "host": "imap.example.com", "password": "leaked-here" },
                "api_key": "should-not-leak",
                "tls": "implicit_tls"
            }
        });
        let redacted = redact_for_audit("nexo/admin/credentials/register", &original);
        // Nested key inside metadata.imap.
        assert_eq!(redacted["metadata"]["imap"]["password"], "<redacted>");
        // Top-level metadata.api_key.
        assert_eq!(redacted["metadata"]["api_key"], "<redacted>");
        // Non-secret fields preserved.
        assert_eq!(redacted["metadata"]["imap"]["host"], "imap.example.com");
        assert_eq!(redacted["metadata"]["tls"], "implicit_tls");
    }

    /// Non-secret fields stay untouched — verifies the redactor
    /// is conservative (doesn't accidentally mask things like
    /// `address` or `host`).
    #[test]
    fn redact_for_audit_preserves_non_secret_fields() {
        let original = serde_json::json!({
            "channel": "email",
            "instance": "ops",
            "agent_ids": ["ana"],
            "payload": { "address": "ops@example.com" },
            "metadata": {
                "imap": { "host": "imap.example.com", "port": 993, "tls": "implicit_tls" }
            }
        });
        let redacted = redact_for_audit("nexo/admin/credentials/register", &original);
        assert_eq!(redacted["channel"], "email");
        assert_eq!(redacted["agent_ids"][0], "ana");
        assert_eq!(redacted["metadata"]["imap"]["host"], "imap.example.com");
        assert_eq!(redacted["metadata"]["imap"]["port"], 993);
    }

    #[test]
    fn extract_tenant_id_reads_string_field() {
        let p = serde_json::json!({ "tenant_id": "acme", "other": 1 });
        assert_eq!(extract_tenant_id(&p), Some("acme".into()));
    }

    #[test]
    fn extract_tenant_id_missing_field_yields_none() {
        let p = serde_json::json!({ "agent_id": "a1" });
        assert_eq!(extract_tenant_id(&p), None);
    }

    #[test]
    fn extract_tenant_id_non_string_yields_none() {
        let p = serde_json::json!({ "tenant_id": 42 });
        assert_eq!(extract_tenant_id(&p), None);
    }

    #[test]
    fn extract_tenant_id_non_object_yields_none() {
        let p = serde_json::json!(["a", "b"]);
        assert_eq!(extract_tenant_id(&p), None);
        let p = serde_json::json!("scalar");
        assert_eq!(extract_tenant_id(&p), None);
    }

    #[test]
    fn audit_row_serde_skips_none_tenant_id() {
        let row = AdminAuditRow {
            microapp_id: "a".into(),
            method: "nexo/admin/echo".into(),
            capability: "echo".into(),
            args_hash: "h".into(),
            started_at_ms: 1,
            result: AdminAuditResult::Ok,
            duration_ms: 1,
            tenant_id: None,
        };
        let json = serde_json::to_string(&row).unwrap();
        assert!(!json.contains("tenant_id"), "None tenant skips field");
    }

    #[test]
    fn audit_row_serde_emits_some_tenant_id() {
        let row = AdminAuditRow {
            microapp_id: "a".into(),
            method: "nexo/admin/echo".into(),
            capability: "echo".into(),
            args_hash: "h".into(),
            started_at_ms: 1,
            result: AdminAuditResult::Ok,
            duration_ms: 1,
            tenant_id: Some("acme".into()),
        };
        let json = serde_json::to_string(&row).unwrap();
        assert!(json.contains("\"tenant_id\":\"acme\""));
    }
}