newt-tui 0.8.0

Newt-Agent TUI surfaces (ratatui): code mode + pilot mode
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207

use super::*;

#[test]
fn edit_form_prefills_and_saves_through_injected_persist() {
    let mut s = panel();
    s.cycle(1); // → gpu-runner
    s.begin_edit();
    let Mode::Form(form) = &s.mode else {
        panic!("edit should open the form");
    };
    assert_eq!(form.editing.as_deref(), Some("gpu-runner"));
    assert_eq!(form.url, "http://gpu-runner:11434");
    assert_eq!(form.model, "qwen3:30b");
    // ↓↓↓ to the model field, clear it, type a new one.
    s.form_nav(1); // kind
    s.form_nav(1); // url
    s.form_nav(1); // model
    for _ in 0.."qwen3:30b".len() {
        s.form_backspace();
    }
    type_text(&mut s, "llama3.1:8b");
    let mut seen: Vec<BackendEdit> = Vec::new();
    let mut persist = |edit: &BackendEdit| {
        seen.push(edit.clone());
        BackendSaveResult::Saved {
            note: "saved backend 'gpu-runner' → /tmp/gpu-runner.toml".to_string(),
        }
    };
    assert!(s.submit_form(&mut persist));
    assert_eq!(seen.len(), 1);
    assert_eq!(seen[0].name, "gpu-runner");
    assert_eq!(seen[0].model.as_deref(), Some("llama3.1:8b"));
    assert!(seen[0].replace, "editing replaces the existing drop-in");
    // The chooser folded the save back in and recorded the change.
    assert_eq!(s.mode, Mode::Choose);
    assert_eq!(
        s.options[1].model.as_deref(),
        Some("llama3.1:8b"),
        "chooser reflects the edit"
    );
    assert_eq!(
        s.changes,
        vec!["saved backend 'gpu-runner' → /tmp/gpu-runner.toml"]
    );
}

#[test]
fn add_form_validates_before_any_io_runs() {
    let mut called = 0usize;
    let mut persist = |_: &BackendEdit| {
        called += 1;
        BackendSaveResult::Saved {
            note: String::new(),
        }
    };
    let cases: &[(&str, &str, &str)] = &[
        // (name, url, expected status fragment)
        ("", "http://x:1", "needs a name"),
        ("bad name", "http://x:1", "letters, digits"),
        ("dgx1", "http://x:1", "already exists"),
        ("fresh", "", "needs a url"),
        ("fresh", "host:11434", "http:// or https://"),
    ];
    for (name, url, want) in cases {
        let mut s = panel();
        s.begin_add();
        type_text(&mut s, name);
        s.form_nav(1); // kind
        s.form_nav(1); // url
        type_text(&mut s, url);
        assert!(!s.submit_form(&mut persist), "case {name:?} {url:?}");
        assert!(
            s.status.as_deref().unwrap_or("").contains(want),
            "case {name:?} {url:?} → {:?}",
            s.status
        );
        assert!(matches!(s.mode, Mode::Form(_)), "stays open to fix it");
    }
    // A whitespace-y api-key env is refused too.
    let mut s = panel();
    s.begin_add();
    type_text(&mut s, "fresh");
    s.form_nav(1);
    s.form_nav(1);
    type_text(&mut s, "http://x:1");
    s.form_nav(1); // model
    s.form_nav(1); // key env
    type_text(&mut s, "NOT AVAR");
    assert!(!s.submit_form(&mut persist));
    assert!(s.status.as_deref().unwrap().contains("bare variable name"));
    assert_eq!(called, 0, "validation failures never reach the disk");
}

#[test]
fn failed_persist_keeps_the_form_open_and_mutates_nothing() {
    // review-3 §1: a failed write keeps the panel open with a visible
    // status; options, changes, and the runtime stay untouched.
    let mut s = panel();
    let before = s.options.clone();
    s.begin_add();
    type_text(&mut s, "newbie");
    s.form_nav(1); // kind
    s.form_nav(1); // url
    type_text(&mut s, "http://newbie:8000");
    let mut persist = |_: &BackendEdit| BackendSaveResult::Failed("disk full".to_string());
    assert!(!s.submit_form(&mut persist));
    assert!(matches!(s.mode, Mode::Form(_)), "stays open for a retry");
    assert!(s.status.as_deref().unwrap().contains("disk full"));
    assert_eq!(s.options, before, "no phantom chooser entry");
    assert!(s.changes.is_empty(), "nothing recorded as changed");
    assert_eq!(close_outcome(false, &s), PanelClose::cancelled());
}

#[test]
fn add_saves_a_new_entry_before_the_kind_fallbacks() {
    let mut s = panel();
    s.begin_add();
    type_text(&mut s, "fresh");
    s.form_nav(1);
    s.form_nav(1);
    type_text(&mut s, "https://fresh.example");
    let mut persist = ok_persist();
    assert!(s.submit_form(&mut persist));
    assert_eq!(s.mode, Mode::Choose);
    assert_eq!(s.options[3].name, "fresh", "inserted after the named set");
    assert!(s.options[3].editable(), "a fresh drop-in is editable");
    assert!(matches!(
        s.options[4].selection,
        BackendSelection::Kind("ollama")
    ));
    assert_eq!(s.changes.len(), 1);
    // The active marker did not drift.
    assert!(s.pick_label().contains("dgx1") && s.pick_label().contains("(active)"));
}

#[test]
fn name_is_fixed_while_editing_but_free_while_adding() {
    let mut s = panel();
    s.begin_edit(); // dgx1
    type_text(&mut s, "x");
    let Mode::Form(form) = &s.mode else {
        panic!("form")
    };
    assert_eq!(form.name, "dgx1", "edit cannot rename");
    assert!(s.status.as_deref().unwrap().contains("fixed"));
    let mut a = panel();
    a.begin_add();
    type_text(&mut a, "brand-new");
    let Mode::Form(form) = &a.mode else {
        panic!("form")
    };
    assert_eq!(form.name, "brand-new");
}

/// §6: an edit that changed nothing performs NO I/O — the panel-open
/// prefill is never re-stamped over whatever the file says now.
#[test]
fn an_untouched_edit_writes_nothing() {
    let mut s = panel();
    let mut called = 0usize;
    let mut persist = |_: &BackendEdit| {
        called += 1;
        BackendSaveResult::Saved {
            note: String::new(),
        }
    };
    s.begin_edit();
    assert!(!s.submit_form(&mut persist));
    assert_eq!(called, 0, "no write for a no-op edit");
    assert_eq!(s.mode, Mode::Choose);
    assert!(s.status.as_deref().unwrap().contains("no changes"));
    assert!(s.changes.is_empty());
}

/// §6: a URL the operator never typed is neither validated nor written —
/// so an edit that only changes the model cannot fail on, or re-stamp, the
/// endpoint. Typing a bad one IS still refused.
#[test]
fn an_untouched_url_is_not_revalidated_but_a_typed_one_is() {
    let mut s = panel();
    s.cycle(1); // → gpu-runner
    s.begin_edit();
    s.form_nav(1);
    s.form_nav(1);
    s.form_nav(1); // model
    type_text(&mut s, "-instruct");
    let mut seen: Vec<BackendEdit> = Vec::new();
    {
        let mut persist = |edit: &BackendEdit| {
            seen.push(edit.clone());
            BackendSaveResult::Saved {
                note: "saved".to_string(),
            }
        };
        assert!(s.submit_form(&mut persist), "{:?}", s.status);
    }
    assert!(!seen[0].dirty.endpoint, "the untouched url is not written");
    let mut never = |_: &BackendEdit| BackendSaveResult::Saved {
        note: String::new(),
    };
    s.begin_edit();
    s.form_nav(1);
    s.form_nav(1); // url
    type_text(&mut s, " and rubbish");
    assert!(!s.submit_form(&mut never));
    assert!(s.status.as_deref().unwrap().contains("invalid url"));
}