newt-core 0.8.0

Newt-Agent core types, errors, and the NeMoCode-style tier router
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
use super::*;
use crate::agentic::http_loop_tests::DisplayReplay;
use crate::caveats::{Caveats, CountBound, Scope};
use crate::{BackendKind, MemMessage};
use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
use std::sync::Arc;
use wiremock::matchers::{method, path};
use wiremock::{Mock, MockServer, Request, Respond, ResponseTemplate};

const TASK: &str = "record the completed plan against this exact prompt";
const PLAN_ARGS: &str = r#"{"plan":[{"step":"capture prompt-rooted provenance","status":"completed"}],"target":{"path":"engine/nested/entry.code","scope":"all implementation files","evidence":"full inventory ranked this first","revision":"initial selection"}}"#;

fn messages(task: &str) -> Vec<MemMessage> {
    vec![MemMessage::system("you are a test"), MemMessage::user(task)]
}

fn ctx<'a>(
    server_uri: &'a str,
    messages: &'a [MemMessage],
    task: &'a str,
    workspace: &'a str,
    caveats: &'a Caveats,
) -> ChatCtx<'a> {
    ChatCtx {
        shell_dialect: crate::agentic::shell_dialect_sentence(false, false),
        command_budget: Default::default(),
        overflow_retry: Default::default(),
        run_allowance: None,
        verify_outcomes: false,
        round_cap_hit: None,
        smart_harness: None,
        rewrites_history: true,
        url: server_uri,
        model: "test-model",
        kind: BackendKind::Ollama,
        api_key: None,
        messages,
        task,
        workspace,
        default_command_cwd: None,
        worktree_session: None,
        color: false,
        markdown: false,
        tool_offload: false,
        spill_store: None,
        disclosure: None,
        compaction_store: None,
        scratchpad: false,
        scratchpad_store: None,
        code_search: None,
        where_is: None,
        nav: None,
        exposure: Default::default(),
        experience_store: None,
        step_ledger: None,
        caveats,
        persona_tools: None,
        cognition: None,
        chat_completions_capability: Default::default(),
        responses_capability: Default::default(),
        openai_api: Default::default(),
        output_allowance: None,
        attempt_ledger: None,
        reasoning_replay_scope: crate::model_card::ReasoningReplayScope::Never,
        emits_leading_reasoning: false,
        max_tool_rounds: 5,
        narration_nudge_cap: 0,
        action_nudges: false,
        prompt_disposition: PromptDisposition::Act,
        prompt_intake: None,
        workflow_grace_rounds: 0,
        tool_output_lines: 20,
        debug: false,
        trace: false,
        num_ctx: None,
        input_ceiling_pct: 80,
        low_budget_pct: 15,
        connect_timeout_secs: 5,
        inference_timeout_secs: 30,
        mid_loop_trim_threshold: 40,
        compaction_trigger_policy: crate::CompactionTriggerPolicy::HeadroomAware,
        mid_loop_trim_tokens: None,
        max_ok_input: None,
        build_check_cmd: None,
        safe_context: None,
        recover_cw_400: None,
        note_sink: None,
        note_nudge: None,
        recall_source: None,
        memory_source: None,
        summarizer: None,
        compress_state: None,
        tool_events: None,
        phantom_reaches: None,
        end_reason: None,
        solve_obs: None,
        permission_gate: None,
        on_round_usage: None,
        estimate_ratio: None,
        estimation: crate::tokens::TokenEstimation::default(),
        summary_input_cap_floor_chars: 8_192,
        exec_floor: None,
        write_ledger: None,
        attribution: None,
        cancel: None,
        live_tool_output: None,
        git_tool: None,
        crew_runner: None,
        operating_mode_control: None,
        plan_mode_control: None,
        plan_draft_sink: None,
        steering: None,
        completed_spill_renderer: None,
    }
}

fn sse_replay(text: &str) -> ResponseTemplate {
    let frame =
        serde_json::json!({"choices": [{"delta": {"content": text}, "finish_reason": "stop"}]});
    let body = format!("data: {frame}\n\ndata: [DONE]\n\n");
    ResponseTemplate::new(200).set_body_raw(body.into_bytes(), "text/event-stream")
}

fn body_json(req: &Request) -> serde_json::Value {
    serde_json::from_slice(&req.body).expect("provider request body is JSON")
}

fn chat_tools_include(body: &serde_json::Value, name: &str) -> bool {
    body["tools"].as_array().is_some_and(|tools| {
        tools
            .iter()
            .any(|tool| tool["function"]["name"].as_str() == Some(name))
    })
}

fn responses_tools_include(body: &serde_json::Value, name: &str) -> bool {
    body["tools"]
        .as_array()
        .is_some_and(|tools| tools.iter().any(|tool| tool["name"].as_str() == Some(name)))
}

fn ndjson(lines: &[serde_json::Value]) -> ResponseTemplate {
    let body = lines
        .iter()
        .map(|line| format!("{line}\n"))
        .collect::<String>();
    ResponseTemplate::new(200).set_body_raw(body.into_bytes(), "application/x-ndjson")
}

fn assert_one_plan_artifact(artifacts: &SessionArtifactStore, turn: &crate::TurnPromptContext) {
    let page = artifacts
        .list_for_root(turn.active_operator_prompt().root_prompt_id(), 0, 10)
        .expect("artifact root page");
    assert_eq!(page.total, 1, "one successful plan update, one artifact");
    let record = &page.records[0];
    let snapshot: PlanSnapshot = serde_json::from_str(record.body.as_deref().unwrap()).unwrap();
    let target = snapshot
        .target
        .expect("selected source retained in artifact");
    assert_eq!(target.selection.path, "engine/nested/entry.code");
    assert!(target.valid());
    assert_eq!(record.kind, "plan_revision");
    assert_eq!(record.prompt_id, turn.submitted_prompt().id());
    assert_eq!(
        record.root_prompt_id,
        turn.active_operator_prompt().root_prompt_id()
    );
    assert_eq!(record.locator.as_deref(), Some("plan"));
    assert!(
        record
            .body
            .as_deref()
            .is_some_and(|body| body.contains("capture prompt-rooted provenance")),
        "bounded normalized plan body is retained"
    );
}

struct OllamaPlanResponder {
    requests: Arc<AtomicUsize>,
    artifact_read_seen: Arc<AtomicBool>,
}

impl Respond for OllamaPlanResponder {
    fn respond(&self, req: &Request) -> ResponseTemplate {
        let body = body_json(req);
        self.artifact_read_seen
            .fetch_and(chat_tools_include(&body, "artifact_read"), Ordering::SeqCst);
        let round = self.requests.fetch_add(1, Ordering::SeqCst);
        if round > 0 {
            assert!(
                body.to_string().contains("[NEWT SELECTED SOURCE v1]"),
                "pin missing from request: {body}"
            );
            assert!(body.to_string().contains("engine/nested/entry.code"));
        }
        match round {
            0 => ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "message": {
                    "role": "assistant",
                    "content": "",
                    "tool_calls": [{
                        "function": {
                            "name": "update_plan",
                            "arguments": serde_json::from_str::<serde_json::Value>(PLAN_ARGS).unwrap()
                        }
                    }]
                },
                "prompt_eval_count": 20,
                "eval_count": 3
            })),
            1 => ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "message": {"role": "assistant", "content": "plan provenance captured"},
                "prompt_eval_count": 24,
                "eval_count": 4
            })),
            _ => ndjson(&[serde_json::json!({
                "message": {"role": "assistant", "content": "plan provenance captured"},
                "done": true,
                "prompt_eval_count": 24,
                "eval_count": 4
            })]),
        }
    }
}

#[tokio::test]
async fn ollama_advertises_artifact_read_and_records_plan_provenance() {
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    let artifact_read_seen = Arc::new(AtomicBool::new(true));
    Mock::given(method("POST"))
        .and(path("/api/chat"))
        .respond_with(OllamaPlanResponder {
            requests: requests.clone(),
            artifact_read_seen: artifact_read_seen.clone(),
        })
        .mount(&server)
        .await;

    let turn = crate::TurnPromptContext::ephemeral_operator("ollama-artifacts", TASK, TASK);
    let artifacts = SessionArtifactStore::new("ollama-artifacts").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.step_ledger = Some(&ledger);

    let (reply, _, _, _) = chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .expect("Ollama plan loop succeeds");

    assert_eq!(
        crate::agentic::model_explanation(&reply),
        "plan provenance captured"
    );
    // #2372: the accepted answer is not generated again for display.
    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert!(
        artifact_read_seen.load(Ordering::SeqCst),
        "artifact_read must ride every Ollama inference request"
    );
    assert_one_plan_artifact(&artifacts, &turn);
}

struct OpenAiPlanResponder {
    requests: Arc<AtomicUsize>,
    artifact_read_seen: Arc<AtomicBool>,
    replay: DisplayReplay,
}

impl Respond for OpenAiPlanResponder {
    fn respond(&self, req: &Request) -> ResponseTemplate {
        if self.replay.take(req) {
            return sse_replay("retry plan provenance captured");
        }
        let body = body_json(req);
        self.artifact_read_seen
            .fetch_and(chat_tools_include(&body, "artifact_read"), Ordering::SeqCst);
        let round = self.requests.fetch_add(1, Ordering::SeqCst);
        if round > 0 {
            assert!(
                body.to_string().contains("[NEWT SELECTED SOURCE v1]"),
                "pin missing from request: {body}"
            );
            assert!(body.to_string().contains("engine/nested/entry.code"));
        }
        if round == 0 {
            ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "choices": [{"message": {
                    "role": "assistant",
                    "content": null,
                    "tool_calls": [{
                        "id": "plan-call",
                        "type": "function",
                        "function": {"name": "update_plan", "arguments": PLAN_ARGS}
                    }]
                }}],
                "usage": {"prompt_tokens": 20, "completion_tokens": 3}
            }))
        } else {
            self.replay.arm(req);
            ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "choices": [{"message": {
                    "role": "assistant",
                    "content": "retry plan provenance captured"
                }}],
                "usage": {"prompt_tokens": 24, "completion_tokens": 4}
            }))
        }
    }
}

#[tokio::test]
async fn openai_chat_records_harness_retry_against_submitted_not_active_prompt() {
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    let artifact_read_seen = Arc::new(AtomicBool::new(true));
    Mock::given(method("POST"))
        .and(path("/v1/chat/completions"))
        .respond_with(OpenAiPlanResponder {
            requests: requests.clone(),
            artifact_read_seen: artifact_read_seen.clone(),
            replay: Default::default(),
        })
        .mount(&server)
        .await;

    let operator = crate::TurnPromptContext::ephemeral_operator("chat-artifacts", TASK, TASK);
    let retry = crate::TurnPromptContext::ephemeral_harness_retry(
        "chat-artifacts",
        "retry after provider timeout",
        "retry after provider timeout",
        &operator,
    )
    .unwrap();
    assert_ne!(
        retry.submitted_prompt().id(),
        retry.active_operator_prompt().id()
    );
    let artifacts = SessionArtifactStore::new("chat-artifacts").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);

    let (reply, _, _, _) = chat_complete_with_prompt_and_artifacts(
        c,
        Some(&retry),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .expect("OpenAI Chat plan loop succeeds");

    assert_eq!(
        crate::agentic::model_explanation(&reply),
        "retry plan provenance captured"
    );
    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert!(
        artifact_read_seen.load(Ordering::SeqCst),
        "artifact_read must ride every Chat Completions request"
    );
    assert_one_plan_artifact(&artifacts, &retry);
    let page = artifacts
        .list_for_root(retry.active_operator_prompt().root_prompt_id(), 0, 10)
        .unwrap();
    assert_ne!(
        page.records[0].prompt_id,
        retry.active_operator_prompt().id(),
        "retry work must not be silently reparented to operator authority"
    );
}

struct ResponsesPlanResponder {
    requests: Arc<AtomicUsize>,
    artifact_read_seen: Arc<AtomicBool>,
}

impl Respond for ResponsesPlanResponder {
    fn respond(&self, req: &Request) -> ResponseTemplate {
        let body = body_json(req);
        self.artifact_read_seen.fetch_and(
            responses_tools_include(&body, "artifact_read"),
            Ordering::SeqCst,
        );
        let round = self.requests.fetch_add(1, Ordering::SeqCst);
        if round > 0 {
            assert!(
                body.to_string().contains("[NEWT SELECTED SOURCE v1]"),
                "pin missing from request: {body}"
            );
            assert!(body.to_string().contains("engine/nested/entry.code"));
        }
        if round == 0 {
            ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "output": [{
                    "type": "function_call",
                    "call_id": "plan-call",
                    "name": "update_plan",
                    "arguments": PLAN_ARGS
                }],
                "usage": {"input_tokens": 20, "output_tokens": 3}
            }))
        } else {
            ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "output": [{
                    "type": "message",
                    "role": "assistant",
                    "content": [{"type": "output_text", "text": "Responses provenance captured"}]
                }],
                "usage": {"input_tokens": 24, "output_tokens": 4}
            }))
        }
    }
}

#[tokio::test]
async fn responses_advertises_artifact_read_and_records_plan_provenance() {
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    let artifact_read_seen = Arc::new(AtomicBool::new(true));
    Mock::given(method("POST"))
        .and(path("/v1/responses"))
        .respond_with(ResponsesPlanResponder {
            requests: requests.clone(),
            artifact_read_seen: artifact_read_seen.clone(),
        })
        .mount(&server)
        .await;

    let turn = crate::TurnPromptContext::ephemeral_operator("responses-artifacts", TASK, TASK);
    let artifacts = SessionArtifactStore::new("responses-artifacts").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);

    // Call the explicit sibling loop instead of mutating NEWT_OPENAI_API: a
    // process-global env flip would race unrelated OpenAI tests in this crate.
    let (reply, _, _, _) = openai_responses_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .expect("Responses plan loop succeeds");

    assert_eq!(
        crate::agentic::model_explanation(&reply),
        "Responses provenance captured"
    );
    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert!(
        artifact_read_seen.load(Ordering::SeqCst),
        "artifact_read must ride every Responses request"
    );
    assert_one_plan_artifact(&artifacts, &turn);
}

struct OpenAiScriptResponder {
    requests: Arc<AtomicUsize>,
    first_message: serde_json::Value,
    final_text: &'static str,
    replay: DisplayReplay,
}

impl Respond for OpenAiScriptResponder {
    fn respond(&self, req: &Request) -> ResponseTemplate {
        if self.replay.take(req) {
            return sse_replay(self.final_text);
        }
        let round = self.requests.fetch_add(1, Ordering::SeqCst);
        let message = if round == 0 {
            self.first_message.clone()
        } else {
            self.replay.arm(req);
            serde_json::json!({"role": "assistant", "content": self.final_text})
        };
        ResponseTemplate::new(200).set_body_json(serde_json::json!({
            "choices": [{"message": message}],
            "usage": {"prompt_tokens": 20, "completion_tokens": 3}
        }))
    }
}

#[tokio::test]
async fn successful_builtin_write_records_digest_only_file_change() {
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    const CONTENT: &str = "sensitive fixture bytes that must not enter the artifact";
    Mock::given(method("POST"))
        .and(path("/v1/chat/completions"))
        .respond_with(OpenAiScriptResponder {
            requests: requests.clone(),
            first_message: serde_json::json!({
                "role": "assistant",
                "content": null,
                "tool_calls": [{
                    "id": "write-call",
                    "type": "function",
                    "function": {
                        "name": "write_file",
                        "arguments": serde_json::json!({
                            "path": "derived.txt",
                            "content": CONTENT
                        }).to_string()
                    }
                }]
            }),
            final_text: "file provenance captured",
            replay: Default::default(),
        })
        .mount(&server)
        .await;

    let workspace = tempfile::TempDir::new().unwrap();
    let workspace_str = workspace.path().to_str().unwrap();
    let caveats = Caveats {
        fs_read: Scope::All,
        fs_write: Scope::only([workspace_str.to_string()]),
        exec: Scope::none(),
        net: Scope::none(),
        max_calls: CountBound::Unlimited,
        valid_for_generation: Scope::All,
    };
    let turn = crate::TurnPromptContext::ephemeral_operator(
        "write-artifacts",
        "write the fixture",
        "write the fixture",
    );
    let artifacts = SessionArtifactStore::new("write-artifacts").unwrap();
    let messages = messages("write the fixture");
    let uri = server.uri();
    let mut c = ctx(
        &uri,
        &messages,
        "write the fixture",
        workspace_str,
        &caveats,
    );
    c.kind = BackendKind::Openai;

    chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .expect("write loop succeeds");

    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert_eq!(
        std::fs::read_to_string(workspace.path().join("derived.txt")).unwrap(),
        CONTENT
    );
    let page = artifacts
        .list_for_root(turn.active_operator_prompt().root_prompt_id(), 0, 10)
        .unwrap();
    assert_eq!(page.total, 1);
    let record = &page.records[0];
    assert_eq!(record.kind, "file_change");
    assert_eq!(record.prompt_id, turn.submitted_prompt().id());
    assert_eq!(record.locator.as_deref(), Some("derived.txt"));
    assert_eq!(
        record.body, None,
        "file bytes never become an artifact body"
    );
    assert_eq!(record.metadata["digest_algorithm"], "blake3");
    assert_eq!(record.metadata["before"]["exists"], false);
    assert_eq!(record.metadata["after"]["exists"], true);
    assert_eq!(
        record.metadata["after"]["digest"],
        blake3::hash(CONTENT.as_bytes()).to_hex().to_string()
    );
    assert_eq!(record.metadata["after"]["bytes"], CONTENT.len() as u64);
    assert!(
        !record.metadata.to_string().contains(CONTENT),
        "metadata contains locators/digests, never file contents"
    );
}

#[tokio::test]
async fn invalid_plan_and_declined_write_record_no_artifacts() {
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    Mock::given(method("POST"))
        .and(path("/v1/chat/completions"))
        .respond_with(OpenAiScriptResponder {
            requests: requests.clone(),
            first_message: serde_json::json!({
                "role": "assistant",
                "content": null,
                "tool_calls": [
                    {
                        "id": "bad-plan",
                        "type": "function",
                        "function": {"name": "update_plan", "arguments": "{}"}
                    },
                    {
                        "id": "declined-write",
                        "type": "function",
                        "function": {
                            "name": "write_file",
                            "arguments": serde_json::json!({
                                "path": "declined.txt",
                                "content": "must not be written"
                            }).to_string()
                        }
                    }
                ]
            }),
            final_text: "nothing was recorded",
            replay: Default::default(),
        })
        .mount(&server)
        .await;

    let workspace = tempfile::TempDir::new().unwrap();
    let workspace_str = workspace.path().to_str().unwrap();
    // Unrestricted writes require an explicit gate answer. With no gate in
    // the headless context this call is deterministically declined.
    let caveats = Caveats::top();
    let turn = crate::TurnPromptContext::ephemeral_operator(
        "failed-artifacts",
        "try invalid work",
        "try invalid work",
    );
    let artifacts = SessionArtifactStore::new("failed-artifacts").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages("try invalid work");
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, "try invalid work", workspace_str, &caveats);
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);

    chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .expect("failed-tool loop still completes");

    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert!(!workspace.path().join("declined.txt").exists());
    assert!(
        ledger.snapshot().is_empty(),
        "invalid plan changed no state"
    );
    let page = artifacts
        .list_for_root(turn.active_operator_prompt().root_prompt_id(), 0, 10)
        .unwrap();
    assert_eq!(page.total, 0, "failed/declined work emits no provenance");
    assert!(page.records.is_empty());
}

/// The real dispatcher must deliver the mismatch to the model before its final
/// response, not merely annotate an already-published answer. A wrong-crate
/// ENOENT must retain the selected full path rather than redirecting the task.
#[tokio::test]
async fn selected_target_diff_warning_reaches_model_before_finalization() {
    use crate::agentic::tools::disable_ocap_tests::{env_lock, EnvVar};
    let _lock = env_lock().await;
    let empty = tempfile::NamedTempFile::new().unwrap();
    let _global = EnvVar::set("GIT_CONFIG_GLOBAL", empty.path().to_str().unwrap());
    let _system = EnvVar::set("GIT_CONFIG_NOSYSTEM", "1");
    let _count = EnvVar::set("GIT_CONFIG_COUNT", "0");
    let _parameters = EnvVar::set("GIT_CONFIG_PARAMETERS", "");

    let workspace = tempfile::tempdir().unwrap();
    for args in [
        vec!["init", "-q"],
        vec!["config", "user.name", "Fixture"],
        vec!["config", "user.email", "fixture@example.invalid"],
    ] {
        assert!(crate::agentic::tools::git_fixture::hermetic_git(
            workspace.path(),
            workspace.path()
        )
        .args(args)
        .output()
        .unwrap()
        .status
        .success());
    }
    std::fs::create_dir_all(workspace.path().join("engine/nested")).unwrap();
    std::fs::write(
        workspace.path().join("engine/nested/entry.code"),
        "selected source",
    )
    .unwrap();
    for args in [
        vec!["add", "."],
        vec!["-c", "commit.gpgsign=false", "commit", "-qm", "base"],
    ] {
        assert!(crate::agentic::tools::git_fixture::hermetic_git(
            workspace.path(),
            workspace.path()
        )
        .args(args)
        .output()
        .unwrap()
        .status
        .success());
    }
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    Mock::given(method("POST")).and(path("/v1/chat/completions"))
        .respond_with(OpenAiScriptResponder {
            requests: requests.clone(),
            first_message: serde_json::json!({"role":"assistant","content":null,
                "tool_calls":[
                    {"id":"pin", "type":"function","function":{"name":"update_plan","arguments":PLAN_ARGS}},
                    {"id":"wrong-crate","type":"function","function":{"name":"read_file",
                        "arguments":r#"{"path":"cli/nested/entry.code"}"#}},
                    {"id":"wrong-file","type":"function","function":{"name":"write_file",
                        "arguments":r#"{"path":"elsewhere.txt","content":"wrong target"}"#}}
                ]}),
            final_text: "The selected-source task is incomplete.",
            replay: Default::default(),
        }).mount(&server).await;
    let turn = crate::TurnPromptContext::ephemeral_operator("target-diff", TASK, TASK);
    let artifacts = SessionArtifactStore::new("target-diff").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let mut caveats = Caveats::top();
    caveats.fs_write = Scope::only([workspace.path().to_string_lossy().into_owned()]);
    let mut events = Vec::new();
    let uri = server.uri();
    let mut c = ctx(
        &uri,
        &messages,
        TASK,
        workspace.path().to_str().unwrap(),
        &caveats,
    );
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);
    c.tool_events = Some(&mut events);
    let (reply, _, _, _) = chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .unwrap();
    assert!(reply.starts_with("## Observed\n"), "{reply}");
    assert!(events
        .iter()
        .any(|event| event.tool == "read_file" && !event.ok));
    assert_eq!(
        ledger.snapshot().target.as_ref().unwrap().selection.path,
        "engine/nested/entry.code"
    );
    let captured = server.received_requests().await.unwrap();
    let body = body_json(&captured[1]);
    let pin = body["messages"]
        .as_array()
        .unwrap()
        .iter()
        .find(|m| {
            m["role"] == "user"
                && m["content"]
                    .as_str()
                    .is_some_and(|s| s.starts_with("[NEWT SELECTED SOURCE v1]"))
        })
        .expect("protected pin");
    assert!(
        pin["content"]
            .as_str()
            .unwrap()
            .contains("work landed outside the selected source"),
        "{pin}"
    );
    assert!(ledger.snapshot().target.unwrap().valid());
}

/// A recorded explicit revision preserves the predecessor, rather than
/// overwriting the selection's provenance as ordinary step progress changes.
#[tokio::test]
async fn selected_target_explicit_revision_keeps_both_plan_artifacts() {
    let server = MockServer::start().await;
    let mut revised: serde_json::Value = serde_json::from_str(PLAN_ARGS).unwrap();
    revised["target"]["path"] = serde_json::json!("other/nested/source.text");
    revised["target"]["revision"] =
        serde_json::json!("Operator narrowed scope; reran the inventory");
    let requests = Arc::new(AtomicUsize::new(0));
    Mock::given(method("POST")).and(path("/v1/chat/completions"))
        .respond_with(OpenAiScriptResponder {
            requests,
            first_message: serde_json::json!({"role":"assistant","content":null,"tool_calls":[
                {"id":"initial","type":"function","function":{"name":"update_plan","arguments":PLAN_ARGS}},
                {"id":"revision","type":"function","function":{"name":"update_plan","arguments":revised.to_string()}}
            ]}),
            final_text:"Selection revision recorded.", replay:Default::default(),
        }).mount(&server).await;
    let turn = crate::TurnPromptContext::ephemeral_operator("target-revision", TASK, TASK);
    let artifacts = SessionArtifactStore::new("target-revision").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);
    chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .unwrap();
    let page = artifacts
        .list_for_root(turn.active_operator_prompt().root_prompt_id(), 0, 10)
        .unwrap();
    assert_eq!(page.total, 2);
    let old: PlanSnapshot = serde_json::from_str(page.records[0].body.as_deref().unwrap()).unwrap();
    let new: PlanSnapshot = serde_json::from_str(page.records[1].body.as_deref().unwrap()).unwrap();
    assert_eq!(
        new.target.as_ref().unwrap().selection.previous,
        Some(old.target.as_ref().unwrap().id)
    );
    assert_eq!(ledger.snapshot().target, new.target);
    // Restoring a prior snapshot is an actual inverse; no history is deleted.
    ledger.restore(&old);
    assert_eq!(ledger.snapshot(), old);
    assert_eq!(
        artifacts
            .list_for_root(turn.active_operator_prompt().root_prompt_id(), 0, 10)
            .unwrap()
            .total,
        2
    );
}

#[tokio::test]
#[serial_test::serial(anthropic_loop_env)]
async fn selected_target_anthropic_pin_is_on_the_final_request() {
    let _guards = super::anthropic_loop_tests::test_env(false);
    let server = MockServer::start().await;
    let requests = Arc::new(AtomicUsize::new(0));
    let counter = requests.clone();
    Mock::given(method("POST"))
        .and(path("/v1/messages"))
        .respond_with(move |req: &Request| {
            let round = counter.fetch_add(1, Ordering::SeqCst);
            let content = if round == 0 {
                serde_json::json!([{"type":"tool_use","id":"pin","name":"update_plan",
                    "input":serde_json::from_str::<serde_json::Value>(PLAN_ARGS).unwrap()}])
            } else {
                assert!(body_json(req)
                    .to_string()
                    .contains("[NEWT SELECTED SOURCE v1]"));
                serde_json::json!([{"type":"text","text":"Selection recorded."}])
            };
            ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "model":"fixture","stop_reason":if round == 0 {"tool_use"} else {"end_turn"},
                "content":content,"usage":{"input_tokens":10,"output_tokens":3}
            }))
        })
        .mount(&server)
        .await;
    let turn = crate::TurnPromptContext::ephemeral_operator("anthropic-pin", TASK, TASK);
    let artifacts = SessionArtifactStore::new("anthropic-pin").unwrap();
    let ledger = SessionStepLedger::default();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.kind = BackendKind::Anthropic;
    c.step_ledger = Some(&ledger);
    let (reply, _, _, _) = chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        Some(&artifacts),
        Some(&artifacts),
        &mut NoMcp,
    )
    .await
    .unwrap();
    assert!(reply.starts_with("## Observed\n"), "{reply}");
    assert_eq!(requests.load(Ordering::SeqCst), 2);
    assert_one_plan_artifact(&artifacts, &turn);
}

struct RejectTargetArtifact;
impl PromptArtifactSink for RejectTargetArtifact {
    fn append_artifact(
        &self,
        _: crate::PromptId,
        _: crate::PromptId,
        _: crate::NewPromptArtifact,
    ) -> anyhow::Result<artifact_read::ArtifactReadRecord> {
        anyhow::bail!("fixture artifact append failure")
    }
}

/// A failed append cannot silently replace the selection seen by later turns.
#[tokio::test]
async fn selected_target_recording_failure_retains_previous_snapshot() {
    let server = MockServer::start().await;
    Mock::given(method("POST")).and(path("/v1/chat/completions"))
        .respond_with(OpenAiScriptResponder {
            requests: Arc::new(AtomicUsize::new(0)),
            first_message: serde_json::json!({"role":"assistant","content":null,"tool_calls":[
                {"id":"pin","type":"function","function":{"name":"update_plan","arguments":PLAN_ARGS}}
            ]}),
            final_text:"Target was not recorded.", replay:Default::default(),
        }).mount(&server).await;
    let turn = crate::TurnPromptContext::ephemeral_operator("target-rejected", TASK, TASK);
    let ledger = SessionStepLedger::default();
    ledger.set_plan(&["Keep the current task".into()]);
    let before = ledger.snapshot();
    let messages = messages(TASK);
    let caveats = Caveats::top();
    let uri = server.uri();
    let mut c = ctx(&uri, &messages, TASK, ".", &caveats);
    c.kind = BackendKind::Openai;
    c.step_ledger = Some(&ledger);
    chat_complete_with_prompt_and_artifacts(
        c,
        Some(&turn),
        None,
        None,
        Some(&RejectTargetArtifact),
        &mut NoMcp,
    )
    .await
    .unwrap();
    assert_eq!(ledger.snapshot(), before);
    let captured = server.received_requests().await.unwrap();
    assert!(body_json(&captured[1])
        .to_string()
        .contains("target revision was not recorded"));
}