netget-tool 0.3.4

Network protocol stubbing toolkit: ~280 protocol servers and clients whose responses come from an LLM, a script, a static rule or a person.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
//! PyPI (Python Package Index) server implementation
//!
//! Implements PEP 503 Simple Repository API for serving Python packages.

pub mod actions;

use std::collections::HashMap;
use std::convert::Infallible;
use std::net::SocketAddr;
use std::sync::Arc;

use bytes::Bytes;
use http_body_util::{BodyExt, Full};
use hyper::body::Incoming;
use hyper::server::conn::http1;
use hyper::service::service_fn;
use hyper::{Request, Response};
use hyper_util::rt::TokioIo;
use tokio::sync::mpsc;
use tracing::trace;

use crate::llm::action_helper::call_llm;
use crate::llm::ollama_client::OllamaClient;
use crate::llm::ActionResult;
use crate::logging::emit::Log;
use crate::protocol::Event;
use crate::server::accept_bounded::{
    accept_bounded, watch_idle, ConnectionActivity, ConnectionLimiter,
};
use crate::server::connection::ConnectionId;
use crate::server::PypiProtocol;
use crate::state::app_state::AppState;
use actions::PYPI_REQUEST_EVENT;

/// How long a peer that has produced nothing at all may hold this connection.
///
/// HTTP is client-speaks-first: the request line is the first thing on the wire and every
/// installer sends it inside its dial path, so a peer that has connected and sent no byte
/// has begun no request. Thirty seconds sits between nginx's `client_header_timeout` default of
/// 60s and Apache's `RequestReadTimeout header=20`, both of which bound the same thing.
///
/// Enforced with `TcpStream::peek` **before** hyper sees the socket. hyper owns every read once
/// `serve_connection` starts, and a deadline on its reads would be wrong here rather than merely
/// awkward: hyper keeps polling the connection for new frames while a request is being answered,
/// so such a deadline would fire in the middle of an LLM round-trip. `peek` waits for data
/// without consuming it, so the request line is still there for hyper afterwards.
const FIRST_BYTE_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30);

/// How long an established connection may sit **silent** between requests.
///
/// This bounds the silence and never a transfer. A request being answered holds
/// `ConnectionActivity` busy for the whole of it - the model round-trip included, and a `manual`
/// rule parking the event for a human at the dashboard (`src/state/intercepts.rs`, 300s by
/// default) - and `watch_idle` reports a busy connection as not idle at all, so the clock only
/// ever runs on a connection with nothing in flight.
///
/// Five minutes: twenty times pip's own socket timeout (`--timeout`, 15 seconds by default), so
/// a pip still waiting on us has long since given up before this fires, and four times nginx's
/// `keepalive_timeout` default of 75s. What is left inside the window is the gap while pip
/// resolves the next requirement or installs the wheel it just fetched - local work, on a
/// connection it may reuse afterwards. RFC 9112 requires every client to retry a request on a
/// persistent connection the server closed, and pip's urllib3 pool does exactly that.
const IDLE_BETWEEN_REQUESTS_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(300);

/// Concurrent connections this server admits.
///
/// Each admitted connection may hold one whole in-memory response body - a simple-index page or
/// a wheel - so the cap is what turns that per-connection bound into a total one. pip fetches
/// essentially serially, so 256 is far above any real installer and far below what socket
/// exhaustion needs.
const MAX_CONNECTIONS: usize = crate::server::accept_bounded::DEFAULT_MAX_CONNECTIONS;

/// What a peer over [`MAX_CONNECTIONS`] is told before the socket closes.
///
/// `503 Service Unavailable` with `Retry-After`, in PyPI's own vocabulary:
/// pip treats a 503 as retryable and backs off, and a human
/// with `curl` reads it directly.
/// Nothing of netget's is interpolated into it - the peer gets a category and the log gets the
/// reason, under `decision=fail_closed_connection_cap`.
const CONNECTION_CAP_REFUSAL: &[u8] = b"HTTP/1.1 503 Service Unavailable\r\n\
    Content-Length: 0\r\nRetry-After: 5\r\nConnection: close\r\n\r\n";

/// PyPI server that delegates package serving to LLM
pub struct PypiServer;

impl PypiServer {
    /// Spawn the PyPI server with integrated LLM actions
    pub async fn spawn_with_llm_actions(
        listen_addr: SocketAddr,
        llm_client: OllamaClient,
        app_state: Arc<AppState>,
        status_tx: mpsc::UnboundedSender<String>,
        server_id: crate::state::ServerId,
    ) -> anyhow::Result<SocketAddr> {
        let listener =
            crate::server::socket_helpers::create_reusable_tcp_listener(listen_addr).await?;
        let local_addr = listener.local_addr()?;
        Log::new(Some(&status_tx)).info(format!("PyPI server listening on {}", local_addr));

        let protocol = Arc::new(PypiProtocol::new());

        // Spawn server loop
        let task_registrar = app_state.clone();
        let limiter = ConnectionLimiter::new(MAX_CONNECTIONS);
        let accept_handle = tokio::spawn(async move {
            loop {
                match accept_bounded(
                    &listener,
                    &limiter,
                    CONNECTION_CAP_REFUSAL,
                    "PYPI",
                    Some(&status_tx),
                )
                .await
                {
                    Ok((stream, remote_addr, permit)) => {
                        let connection_id =
                            ConnectionId::new(app_state.get_next_unified_id().await);
                        let local_addr_conn = stream.local_addr().unwrap_or(local_addr);
                        Log::new(Some(&status_tx)).info(format!(
                            "Accepted PyPI connection {} from {}",
                            connection_id, remote_addr
                        ));

                        // Add connection to ServerInstance
                        use crate::state::server::{
                            ConnectionState as ServerConnectionState, ConnectionStatus,
                            ProtocolConnectionInfo,
                        };
                        let now = crate::utils::clock::Instant::now();
                        let conn_state = ServerConnectionState {
                            id: connection_id,
                            remote_addr,
                            local_addr: local_addr_conn,
                            bytes_sent: 0,
                            bytes_received: 0,
                            packets_sent: 0,
                            packets_received: 0,
                            last_activity: now,
                            status: ConnectionStatus::Active,
                            status_changed_at: now,
                            protocol_info: ProtocolConnectionInfo::empty(),
                        };
                        app_state
                            .add_connection_to_server(server_id, conn_state)
                            .await;
                        let _ = status_tx.send("__UPDATE_UI__".to_string());

                        let llm_client_clone = llm_client.clone();
                        let app_state_clone = app_state.clone();
                        let status_tx_clone = status_tx.clone();
                        let protocol_clone = protocol.clone();

                        // Spawn a task to handle this connection
                        // Tracked, not detached: stop_server must abort this task too.
                        let task_owner = app_state.clone();
                        task_owner
                            .spawn_server_task(server_id, async move {
                                // Held for the life of the connection, so the
                                // cap counts live clients, not accepts.
                                let _permit = permit;

                                // The first-byte bound, before hyper sees the
                                // socket. `peek` waits for data without
                                // consuming it, so the request line is still
                                // there for hyper afterwards, and it bounds
                                // exactly the case that needs bounding: a peer
                                // that connected and said nothing at all.
                                let spoke = matches!(
                                    tokio::time::timeout(
                                        FIRST_BYTE_READ_TIMEOUT,
                                        stream.peek(&mut [0u8; 1]),
                                    )
                                    .await,
                                    Ok(Ok(n)) if n > 0
                                );

                                if spoke {
                                    let io = TokioIo::new(stream);

                                    // Clone for service closure
                                    let status_for_service = status_tx_clone.clone();
                                    let app_state_for_service = app_state_clone.clone();

                                    // Whether this connection is answering
                                    // anything. The watchdog below reads it, so
                                    // only genuine silence - never work in
                                    // flight - can close a connection.
                                    let activity =
                                        Arc::new(ConnectionActivity::new());
                                    let activity_for_service = Arc::clone(&activity);
                                    // Create a service that handles requests with LLM
                                    let service = service_fn(move |req: Request<Incoming>| {
                                        let llm_clone = llm_client_clone.clone();
                                        let state_clone = app_state_for_service.clone();
                                        let status_clone = status_for_service.clone();
                                        let protocol_clone = protocol_clone.clone();
                                        // Busy for the whole of this request - the
                                        // model round-trip included, and a `manual`
                                        // rule parked for a human - so the idle
                                        // watchdog can never close the connection an
                                        // answer belongs to.
                                        let activity = Arc::clone(&activity_for_service);
                                        async move {
                                            let _busy = activity.busy();
                                            handle_pypi_request_with_llm_actions(
                                                req,
                                                connection_id,
                                                server_id,
                                                llm_clone,
                                                state_clone,
                                                status_clone,
                                                protocol_clone,
                                            )
                                            .await
                                        }
                                    });

                                    // Serve HTTP/1 on this connection
                                    let conn = http1::Builder::new().serve_connection(io, service);
                                    tokio::pin!(conn);
                                    tokio::select! {
                                        result = &mut conn => {
                                            if let Err(err) = result {
                                                Log::new(Some(&status_tx_clone))
                                                    .error(format!("Error serving PyPI connection: {:?}", err));
                                            }
                                        }
                                        // The idle bound, over `ConnectionActivity`
                                        // rather than over a read: hyper owns every
                                        // read once `serve_connection` starts, and
                                        // keeps polling for frames while a request is
                                        // being answered, so a deadline on those reads
                                        // would fire mid-answer. A connection with work
                                        // in flight is not idle at all.
                                        _ = watch_idle(
                                            Arc::clone(&activity),
                                            IDLE_BETWEEN_REQUESTS_TIMEOUT,
                                        ) => {
                                            Log::new(Some(&status_tx_clone)).debug(format!(
                                                "PyPI connection {} idle for {}s; closing",
                                                connection_id,
                                                IDLE_BETWEEN_REQUESTS_TIMEOUT.as_secs()
                                            ));
                                        }
                                    }
                                } else {
                                    Log::new(Some(&status_tx_clone)).debug(format!(
                                        "PyPI peer {} sent no request within {}s; closing \
                                         decision=fail_closed_first_byte_timeout",
                                        remote_addr,
                                        FIRST_BYTE_READ_TIMEOUT.as_secs()
                                    ));
                                }

                                // Mark connection as closed
                                app_state_clone
                                    .close_connection_on_server(server_id, connection_id)
                                    .await;
                                Log::new(Some(&status_tx_clone))
                                    .info(format!("PyPI connection {connection_id} closed"));
                                let _ = status_tx_clone.send("__UPDATE_UI__".to_string());
                            })
                            .await;
                    }
                    Err(e) => {
                        Log::new(Some(&status_tx))
                            .error(format!("Failed to accept PyPI connection: {}", e));
                        break;
                    }
                }
            }
        });

        // Register the accept loop so stop_server can abort it and release the port.
        task_registrar
            .register_server_task(server_id, accept_handle)
            .await;

        Ok(local_addr)
    }
}

/// Build the 502 sent when model or handler output cannot be turned into a
/// valid HTTP response (bad status code, malformed header name, no answer at all).
///
/// The peer gets a category, never a diagnosis: what exactly was wrong with the action
/// output is netget's own business and goes to the log only.
/// See `crate::utils::wire_failure`.
fn bad_gateway() -> Response<Full<Bytes>> {
    Response::builder()
        .status(502)
        .header("Content-Type", "text/plain; charset=utf-8")
        .body(Full::new(Bytes::from(
            crate::utils::WireFailure::Unavailable.prefixed_text(),
        )))
        .expect("502 response with a literal body is always valid")
}

/// The 413 for a request body over [`MAX_REQUEST_BODY_BYTES`].
///
/// Static text: the peer learns the fact and the limit, never why the read failed.
fn payload_too_large() -> Response<Full<Bytes>> {
    Response::builder()
        .status(413)
        .header("Content-Type", "text/plain; charset=utf-8")
        .body(Full::new(Bytes::from(format!(
            "Payload Too Large: request bodies are limited to {} bytes\n",
            crate::server::http_common::handler::MAX_REQUEST_BODY_BYTES
        ))))
        .expect("413 response with a literal body is always valid")
}

/// Build the reply for an LLM/backend failure.
///
/// The two categories get distinct HTTP codes on purpose: pip retries a 503 with
/// `Retry-After` and records a 500 as a hard failure, so collapsing them would make a
/// transient overload look permanent. The body is a static category string — the error
/// itself is logged, never written to the socket.
fn llm_failure_response(failure: crate::utils::WireFailure) -> Response<Full<Bytes>> {
    let mut builder = Response::builder()
        .header("Content-Type", "text/plain; charset=utf-8")
        .status(if failure.is_overloaded() { 503 } else { 500 });
    if failure.is_overloaded() {
        builder = builder.header("Retry-After", "5");
    }
    builder
        .body(Full::new(Bytes::from(failure.prefixed_text())))
        .expect("failure response with a literal body is always valid")
}

/// Approximate the bytes this request cost on the wire.
///
/// hyper hands us a parsed `Request`, so the original head is gone; this
/// reconstructs its size from the parts that survive. It is an estimate, and
/// deliberately so — the alternative is a `↓` counter frozen at 0, which reads as
/// "this peer sent nothing" rather than "we did not measure".
fn approximate_request_bytes(req: &Request<Incoming>) -> u64 {
    use hyper::body::Body;
    let head: usize = req.method().as_str().len()
        + req.uri().to_string().len()
        + 12 // " HTTP/1.1\r\n" plus the blank line terminating the head
        + req
            .headers()
            .iter()
            .map(|(name, value)| name.as_str().len() + value.len() + 4)
            .sum::<usize>();
    head as u64 + req.body().size_hint().lower()
}

/// Record one request/response exchange against the connection's counters, then
/// return the response unchanged.
///
/// `update_connection_stats` is what the dashboard rail's `↓ ↑` columns and the
/// connection-scoped task prompts read, and it is what keeps `last_activity`
/// moving. Without it a busy PyPI server draws every peer as idle having sent
/// and received nothing.
#[allow(clippy::too_many_arguments)]
async fn handle_pypi_request_with_llm_actions(
    req: Request<Incoming>,
    connection_id: ConnectionId,
    server_id: crate::state::ServerId,
    llm_client: OllamaClient,
    app_state: Arc<AppState>,
    status_tx: mpsc::UnboundedSender<String>,
    protocol: Arc<PypiProtocol>,
) -> Result<Response<Full<Bytes>>, Infallible> {
    let bytes_received = approximate_request_bytes(&req);
    let response = handle_pypi_request_with_llm_actions_inner(
        req,
        connection_id,
        server_id,
        llm_client,
        app_state.clone(),
        status_tx,
        protocol,
    )
    .await;

    let bytes_sent = response
        .as_ref()
        .ok()
        .and_then(|resp| {
            use hyper::body::Body;
            resp.body().size_hint().exact()
        })
        .unwrap_or(0);
    app_state
        .update_connection_stats(
            server_id,
            connection_id,
            Some(bytes_received),
            Some(bytes_sent),
            Some(1),
            Some(1),
        )
        .await;

    response
}

/// Handle a single PyPI request with integrated LLM actions
async fn handle_pypi_request_with_llm_actions_inner(
    req: Request<Incoming>,
    connection_id: ConnectionId,
    server_id: crate::state::ServerId,
    llm_client: OllamaClient,
    app_state: Arc<AppState>,
    status_tx: mpsc::UnboundedSender<String>,
    protocol: Arc<PypiProtocol>,
) -> Result<Response<Full<Bytes>>, Infallible> {
    // TRACE: Handler invoked (FileOnly)
    Log::new(Some(&status_tx)).trace(format!(
        "🔍 PyPI handler called for connection {}",
        connection_id
    ));

    // Extract request details first for logging
    let method = req.method().to_string();
    let uri = req.uri().to_string();
    let path = req.uri().path().to_string();

    // Extract headers
    let mut headers = HashMap::new();
    for (name, value) in req.headers() {
        if let Ok(value_str) = value.to_str() {
            headers.insert(name.to_string(), value_str.to_string());
        }
    }

    // Read the body, bounded. `Incoming` has no default limit, and this body is
    // buffered whole *and* interpolated into the LLM prompt below, so an
    // unauthenticated POST of arbitrary length would allocate twice over — the
    // unbounded-upload shape. `Limited` errors as soon as the cap is passed rather
    // than after buffering, so an oversized request costs at most the cap.
    let body_bytes = match http_body_util::Limited::new(
        req.into_body(),
        crate::server::http_common::handler::MAX_REQUEST_BODY_BYTES,
    )
    .collect()
    .await
    {
        Ok(collected) => collected.to_bytes(),
        Err(e) => {
            // Do NOT fall through to an empty body: a truncated request handed to the
            // model looks like a complete one, and the model would answer a request it
            // never saw. 413 is the honest reply, and it costs no LLM call.
            Log::new(Some(&status_tx)).warn(format!(
                "PyPI {} {} decision=refused_body_too_large (limit {} bytes) \u{2192} 413: {}",
                method,
                uri,
                crate::server::http_common::handler::MAX_REQUEST_BODY_BYTES,
                e
            ));
            return Ok(payload_too_large());
        }
    };

    // Determine request type based on path
    // PEP 503 project URLs end with '/', but pip and poetry both follow
    // redirects, so a client may also ask for /simple/<name> without one.
    let request_type = if path == "/" || path == "/simple" || path == "/simple/" {
        "list_packages"
    } else if path.starts_with("/simple/") {
        "list_files"
    } else if path.starts_with("/packages/") {
        "download_file"
    } else {
        "unknown"
    };

    // Extract package name if applicable
    let package_name = if request_type == "list_files" {
        path.trim_start_matches("/simple/")
            .trim_end_matches('/')
            .to_string()
    } else if request_type == "download_file" {
        path.trim_start_matches("/packages/")
            .split('/')
            .last()
            .unwrap_or("")
            .to_string()
    } else {
        String::new()
    };

    // DEBUG: Log request summary (FileOnly)
    Log::new(Some(&status_tx)).debug(format!(
        "PyPI request: {} {} [{}] ({} bytes) from {:?}",
        method,
        uri,
        request_type,
        body_bytes.len(),
        connection_id
    ));

    // TRACE: Log full request details
    trace!("PyPI request headers:");
    for (name, value) in &headers {
        trace!("  {}: {}", name, value);
    }

    // Create PyPI request event (FileOnly)
    Log::new(Some(&status_tx)).trace(format!(
        "🔍 Creating PyPI event: path={}, request_type={}",
        path, request_type
    ));

    let body_text = String::from_utf8_lossy(&body_bytes);
    let event = Event::new(
        &PYPI_REQUEST_EVENT,
        serde_json::json!({
            "method": method,
            "uri": uri,
            "path": path,
            "headers": headers,
            "body": body_text,
            "request_type": request_type,
            "package_name": package_name,
        }),
    );

    Log::new(Some(&status_tx)).trace("🔍 Calling LLM for PyPI request");

    // Call LLM to generate PyPI response
    match call_llm(
        &llm_client,
        &app_state,
        server_id,
        Some(connection_id),
        &event,
        protocol.as_ref(),
    )
    .await
    {
        Ok(execution_result) => {
            Log::new(Some(&status_tx)).debug(format!(
                "LLM PyPI response received, {} protocol results",
                execution_result.protocol_results.len()
            ));

            // Display messages
            for msg in execution_result.messages {
                let _ = status_tx.send(msg);
            }

            // Extract the PyPI response from the protocol results.
            //
            // There is deliberately no default here. This used to pre-set
            // `status_code = 200` with an empty body, so a model that answered with no
            // action at all — or a handler configured with `actions: []` — produced a
            // `200 OK` with zero bytes. To pip that reads as "the project exists and has
            // no distributions", i.e. silence became a successful answer. A no-answer is
            // a failure and must look like one on the wire.
            let mut status_code: Option<u16> = None;
            let mut response_headers = HashMap::new();
            let mut response_body: Vec<u8> = Vec::new();
            let mut body_set = false;
            let mut decode_failed = false;

            for protocol_result in execution_result.protocol_results {
                if let ActionResult::Output(output_data) = protocol_result {
                    // Parse the output as JSON containing PyPI response fields
                    if let Ok(json_value) =
                        serde_json::from_slice::<serde_json::Value>(&output_data)
                    {
                        if let Some(status) = json_value.get("status").and_then(|v| v.as_u64()) {
                            if (100..=599).contains(&status) {
                                status_code = Some(status as u16);
                            } else {
                                Log::new(Some(&status_tx)).error(format!(
                                    "PyPI response status {} is not a valid HTTP status code",
                                    status
                                ));
                                decode_failed = true;
                            }
                        }
                        if let Some(headers_obj) =
                            json_value.get("headers").and_then(|v| v.as_object())
                        {
                            for (k, v) in headers_obj {
                                if let Some(v_str) = v.as_str() {
                                    response_headers.insert(k.clone(), v_str.to_string());
                                }
                            }
                        }
                        // body_base64 is only ever set by the action executor,
                        // which has already validated the encoding.
                        if let Some(encoded) =
                            json_value.get("body_base64").and_then(|v| v.as_str())
                        {
                            use base64::Engine;
                            match base64::engine::general_purpose::STANDARD.decode(encoded) {
                                Ok(decoded) => {
                                    response_body = decoded;
                                    body_set = true;
                                }
                                Err(e) => {
                                    // Serving 0 bytes here would hand pip a truncated
                                    // distribution that fails its hash check much later,
                                    // far from the cause. Refuse instead.
                                    Log::new(Some(&status_tx)).error(format!(
                                        "PyPI response body_base64 is not valid base64: {}",
                                        e
                                    ));
                                    decode_failed = true;
                                }
                            }
                        } else if let Some(body) = json_value.get("body").and_then(|v| v.as_str()) {
                            response_body = body.as_bytes().to_vec();
                            body_set = true;
                        }
                    }
                }
            }

            if decode_failed {
                // The model/handler answered, but the answer cannot be put on the wire.
                Log::new(Some(&status_tx)).error(format!(
                    "PyPI {} {} decision=fail_closed_bad_action → 502",
                    method, uri
                ));
                return Ok(bad_gateway());
            }

            // `send_pypi_response` always yields a status plus exactly one of
            // `body`/`body_base64` (see `execute_send_pypi_response`), so both being
            // present is precisely "a PyPI response was produced".
            let Some(status_code) = status_code.filter(|_| body_set) else {
                // Distinct from an LLM error (below) and from a model that deliberately
                // answered 404: nothing usable came back at all.
                Log::new(Some(&status_tx)).warn(format!(
                    "PyPI {} {} decision=fail_closed_no_action \
                     (no send_pypi_response in the answer) → 502",
                    method, uri
                ));
                return Ok(bad_gateway());
            };

            Log::new(Some(&status_tx)).info(format!(
                "PyPI {} {} decision=model_response → {} ({} bytes)",
                method,
                uri,
                status_code,
                response_body.len()
            ));

            // Build the HTTP response. Status and header names come from model or
            // handler output, so an invalid one must not take the connection down.
            let mut response = Response::builder().status(status_code);

            // Add headers
            for (name, value) in response_headers {
                response = response.header(name, value);
            }

            match response.body(Full::new(Bytes::from(response_body))) {
                Ok(resp) => Ok(resp),
                Err(e) => {
                    Log::new(Some(&status_tx)).error(format!(
                        "PyPI {} {} decision=fail_closed_bad_action: invalid response ({}) → 502",
                        method, uri, e
                    ));
                    Ok(bad_gateway())
                }
            }
        }
        Err(e) => {
            // The backend failed. The peer gets a category and a code it can act on; the
            // error itself — backend URL, model name, anyhow chain — goes to the log only.
            let failure = crate::utils::WireFailure::classify(&e);
            let code = if failure.is_overloaded() { 503 } else { 500 };
            Log::new(Some(&status_tx)).warn(format!(
                "PyPI {} {} decision=fail_closed_llm_error → {} ({:?}): {}",
                method, uri, code, failure, e
            ));
            Ok(llm_failure_response(failure))
        }
    }
}