neteq 0.8.3

NetEQ-inspired adaptive jitter buffer for audio decoding
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
/*
 * Copyright 2025 Security Union LLC
 *
 * Licensed under either of
 *
 * * Apache License, Version 2.0
 *   (http://www.apache.org/licenses/LICENSE-2.0)
 * * MIT license
 *   (http://opensource.org/licenses/MIT)
 *
 * at your option.
 *
 * Unless you explicitly state otherwise, any contribution intentionally
 * submitted for inclusion in the work by you, as defined in the Apache-2.0
 * license, shall be dual licensed as above, without any additional terms or
 * conditions.
 */

use std::collections::VecDeque;
use web_time::{Duration, Instant};

use crate::{histogram::Histogram, Result};

/// Initial target delay when NetEQ starts operation.
///
/// This value provides a buffer against early underruns while the adaptive
/// delay manager learns the network characteristics:
/// - Too low: Risk of underruns before adaptation kicks in
/// - Too high: Unnecessary initial latency
///
/// Engineering rationale:
/// - 80ms accommodates typical network jitter (±40ms)
/// - Allows 4 packets of 20ms each in buffer initially
/// - WebRTC empirically validated this across diverse networks
/// - Provides safety margin during cold start before statistics stabilize
const K_START_DELAY_MS: u32 = 80;

const K_DELAY_BUCKETS: usize = 100;
const K_BUCKET_SIZE_MS: i32 = 20;

/// Configuration for the delay manager
#[derive(Debug, Clone)]
pub struct DelayConfig {
    /// Quantile for delay estimation (0.0 to 1.0)
    pub quantile: f64,
    /// Forget factor for exponential smoothing
    pub forget_factor: f64,
    /// Starting forget weight for rapid adaptation
    pub start_forget_weight: Option<f64>,
    /// Interval for resampling delay estimation
    pub resample_interval_ms: Option<u32>,
    /// Maximum history length in milliseconds
    pub max_history_ms: u32,
    /// Base minimum delay in milliseconds
    pub base_minimum_delay_ms: u32,
    // Maximum delay in milliseconds
    pub base_maximum_delay_ms: u32,
    // Contant additional delay in milliseconds
    pub additional_delay_ms: u32,
    /// Whether to use reorder optimizer
    pub use_reorder_optimizer: bool,
    /// Forget factor for reorder detection
    pub reorder_forget_factor: f64,
    /// Milliseconds per loss percent for reorder detection
    pub ms_per_loss_percent: u32,
}

impl Default for DelayConfig {
    fn default() -> Self {
        Self {
            quantile: 0.97,
            forget_factor: 0.9993,
            start_forget_weight: Some(2.0),
            resample_interval_ms: Some(500),
            max_history_ms: 2000,
            base_minimum_delay_ms: 0,
            base_maximum_delay_ms: 2000,
            additional_delay_ms: 0,
            use_reorder_optimizer: true,
            reorder_forget_factor: 0.9993,
            ms_per_loss_percent: 20,
        }
    }
}

/// Relative arrival delay tracker
#[derive(Debug)]
pub struct RelativeArrivalDelayTracker {
    config: DelayConfig,
    delay_history: VecDeque<PacketDelay>,
    newest_timestamp: Option<u32>,
    last_timestamp: Option<u32>,
    last_packet_time: Option<Instant>,
}

#[derive(Debug, Clone)]
struct PacketDelay {
    iat_delay_ms: i32,
    _timestamp: u32,
    arrival_time: Instant,
}

impl RelativeArrivalDelayTracker {
    pub fn new(config: DelayConfig) -> Self {
        Self {
            config,
            delay_history: VecDeque::new(),
            newest_timestamp: None,
            last_timestamp: None,
            last_packet_time: None,
        }
    }

    /// Update with a new packet arrival
    pub fn update(&mut self, timestamp: u32, sample_rate: u32, arrival_time: Instant) -> i32 {
        // Calculate expected time since last packet
        let expected_iat_ms = if let Some(last_timestamp) = self.last_timestamp {
            timestamp.saturating_sub(last_timestamp) * 1000 / sample_rate
        } else {
            0
        };

        // Calculate actual time since last packet
        let actual_iat_ms = if let Some(last_time) = self.last_packet_time {
            arrival_time.duration_since(last_time).as_millis() as i32
        } else {
            0
        };

        // Calculate jitter: positive means packet is late, negative means packet is early
        let iat_delay_ms = actual_iat_ms - expected_iat_ms as i32;

        self.last_packet_time = Some(arrival_time);

        // Update delay history
        self.update_delay_history(iat_delay_ms, timestamp, sample_rate);

        // Calculate relative packet arrival delay
        let relative_delay = self.calculate_relative_packet_arrival_delay();

        self.newest_timestamp = Some(timestamp);
        self.last_timestamp = Some(timestamp);

        relative_delay
    }

    /// Reset the tracker
    pub fn reset(&mut self) {
        self.delay_history.clear();
        self.newest_timestamp = None;
        self.last_timestamp = None;
        self.last_packet_time = None;
    }

    fn update_delay_history(&mut self, iat_delay_ms: i32, timestamp: u32, _sample_rate: u32) {
        let packet_delay = PacketDelay {
            iat_delay_ms,
            _timestamp: timestamp,
            arrival_time: Instant::now(),
        };

        self.delay_history.push_back(packet_delay);

        // Remove old entries based on max_history_ms
        let max_age = Duration::from_millis(self.config.max_history_ms as u64);
        let now = Instant::now();

        self.delay_history
            .retain(|delay| now.duration_since(delay.arrival_time) <= max_age);
    }

    /// Calculates the relative arrival delay of packets in the history.
    ///
    /// Returns the 97th percentile of positive jitter values in the recent history.
    /// Negative jitter (early arrivals) is clamped to 0 since we only care about
    /// buffering for late packets.
    pub fn calculate_relative_packet_arrival_delay(&self) -> i32 {
        if self.delay_history.is_empty() {
            return 0;
        }

        // Collect positive jitter values (late arrivals)
        let mut positive_delays: Vec<i32> = self
            .delay_history
            .iter()
            .map(|d| d.iat_delay_ms.max(0))
            .collect();

        if positive_delays.is_empty() {
            return 0;
        }

        positive_delays.sort_unstable();

        // Return 97th percentile
        let index = ((positive_delays.len() - 1) as f64 * self.config.quantile) as usize;
        positive_delays[index]
    }
}

/// Delay manager for adaptive jitter buffer control
#[derive(Debug)]
pub struct DelayManager {
    config: DelayConfig,
    arrival_delay_tracker: RelativeArrivalDelayTracker,
    target_level_ms: u32,
    minimum_delay_ms: u32,
    effective_minimum_delay_ms: u32,
    maximum_delay_ms: u32,
    effective_maximum_delay_ms: u32,
    resampled_relative_delay: i32,
    last_resample_time: Option<Instant>,
    histogram: Histogram,
}

impl DelayManager {
    /// Create a new delay manager
    pub fn new(config: DelayConfig) -> Self {
        let arrival_delay_tracker = RelativeArrivalDelayTracker::new(config.clone());

        Self {
            target_level_ms: K_START_DELAY_MS.max(config.base_minimum_delay_ms), // Start with 80ms or minimum delay
            minimum_delay_ms: 0,
            effective_minimum_delay_ms: config.base_minimum_delay_ms,
            maximum_delay_ms: 0,
            effective_maximum_delay_ms: config.base_maximum_delay_ms,
            resampled_relative_delay: 0,
            last_resample_time: None,
            arrival_delay_tracker,
            histogram: Histogram::new(
                K_DELAY_BUCKETS,
                config.forget_factor,
                config.start_forget_weight,
            ),
            config,
        }
    }

    /// Update the delay manager with a new packet
    pub fn update(&mut self, timestamp: u32, sample_rate: u32, reset: bool) -> Result<()> {
        if reset {
            self.reset();
        }

        let arrival_time = Instant::now();

        // Update arrival delay tracking
        let relative_delay =
            self.arrival_delay_tracker
                .update(timestamp, sample_rate, arrival_time);

        // When jitter is high, relative_delay fluctuates between high and near 0 values.
        // resampling helps by calculating the max over some time period.
        if let Some(resample_interval_ms) = self.config.resample_interval_ms {
            if let Some(last_resample_time) = self.last_resample_time {
                let elapsed_ms = arrival_time.duration_since(last_resample_time).as_millis() as u32;
                if elapsed_ms >= resample_interval_ms {
                    self.register_relative_delay(self.resampled_relative_delay);
                    self.resampled_relative_delay = 0;

                    // Round down to nearest multiples, so the interval doesn't drift.
                    let elapsed_multiples =
                        (elapsed_ms / resample_interval_ms) * resample_interval_ms;
                    self.last_resample_time = last_resample_time
                        .checked_add(Duration::from_millis(elapsed_multiples as u64))
                }
            } else {
                self.last_resample_time = Some(arrival_time);
            }

            self.resampled_relative_delay = self.resampled_relative_delay.max(relative_delay);
        } else {
            self.register_relative_delay(relative_delay);
        }

        self.update_target_delay();

        Ok(())
    }

    /// Reset the delay manager
    pub fn reset(&mut self) {
        self.arrival_delay_tracker.reset();
        self.target_level_ms = K_START_DELAY_MS.max(self.config.base_minimum_delay_ms);
        self.resampled_relative_delay = 0;
        self.last_resample_time = None;
        // Reset to 80ms like WebRTC
    }

    /// Get the current target delay in milliseconds
    pub fn target_delay_ms(&self) -> u32 {
        (self.target_level_ms + self.config.additional_delay_ms)
            .max(self.effective_minimum_delay_ms)
            .min(self.effective_maximum_delay_ms)
    }

    /// Set minimum delay constraint
    pub fn set_minimum_delay(&mut self, delay_ms: u32) -> u32 {
        self.minimum_delay_ms = delay_ms;
        self.update_effective_delay_bounds();
        self.effective_minimum_delay_ms
    }

    /// Set maximum delay constraint
    pub fn set_maximum_delay(&mut self, delay_ms: u32) -> u32 {
        self.maximum_delay_ms = delay_ms;
        self.update_effective_delay_bounds();
        self.effective_maximum_delay_ms
    }

    /// Set base minimum delay
    pub fn set_base_minimum_delay(&mut self, delay_ms: u32) {
        self.config.base_minimum_delay_ms = delay_ms;
        self.update_effective_delay_bounds();
    }

    /// Get base minimum delay
    pub fn get_base_minimum_delay(&self) -> u32 {
        self.config.base_minimum_delay_ms
    }

    /// Set base maximum delay
    pub fn set_base_maximum_delay(&mut self, delay_ms: u32) {
        self.config.base_maximum_delay_ms = delay_ms;
        self.update_effective_delay_bounds();
    }

    /// Get base maximum delay
    pub fn get_base_maximum_delay(&self) -> u32 {
        self.config.base_maximum_delay_ms
    }

    fn register_relative_delay(&mut self, relative_delay: i32) {
        let index = (relative_delay / K_BUCKET_SIZE_MS) as usize;
        if index < self.histogram.num_buckets() {
            // Maximum delay to register is 2000 ms.
            self.histogram.add(index);
        }
    }

    fn update_target_delay(&mut self) {
        let bucket_index = self.histogram.quantile(self.config.quantile);

        // Update target level based on filtered delay
        self.target_level_ms = (1 + bucket_index as u32) * K_BUCKET_SIZE_MS as u32;

        // Apply constraints
        self.target_level_ms = self
            .target_level_ms
            .max(self.effective_minimum_delay_ms)
            .min(self.effective_maximum_delay_ms);

        log::debug!(
            "Target delay updated: {}ms max {}ms min {}ms",
            self.target_level_ms,
            self.effective_minimum_delay_ms,
            self.effective_maximum_delay_ms
        );
    }

    fn update_effective_delay_bounds(&mut self) {
        // base maximum is based on the buffer size, so this is the strongest
        let upper_bound = self.config.base_maximum_delay_ms;
        let lower_bound = self.config.base_minimum_delay_ms.min(upper_bound);

        if self.minimum_delay_ms > 0 {
            self.effective_minimum_delay_ms =
                self.minimum_delay_ms.max(lower_bound).min(upper_bound);
        } else {
            self.effective_minimum_delay_ms = lower_bound;
        }

        if self.maximum_delay_ms > 0 {
            self.effective_maximum_delay_ms = self
                .maximum_delay_ms
                .max(self.effective_minimum_delay_ms)
                .min(upper_bound);
        } else {
            self.effective_maximum_delay_ms = upper_bound;
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::thread;

    #[test]
    fn test_delay_manager_creation() {
        let config = DelayConfig::default();
        let delay_manager = DelayManager::new(config);

        assert_eq!(delay_manager.target_delay_ms(), 80); // Now starts with kStartDelayMs
        assert_eq!(delay_manager.get_base_minimum_delay(), 0);
    }

    #[test]
    fn test_delay_manager_update() {
        let config = DelayConfig::default();
        let mut delay_manager = DelayManager::new(config);

        // Simulate packets arriving with some jitter
        let sample_rate = 16000;
        let mut timestamp = 0;

        for i in 0..10 {
            // Add some simulated jitter
            if i % 3 == 0 {
                thread::sleep(Duration::from_millis(5));
            }

            delay_manager.update(timestamp, sample_rate, false).unwrap();
            timestamp += 320; // 20ms at 16kHz
        }

        // Target delay should adapt to the jitter
        let target_delay = delay_manager.target_delay_ms();
        assert!(target_delay >= 20); // At least one packet duration
    }

    #[test]
    fn test_minimum_delay_constraints() {
        let config = DelayConfig {
            base_minimum_delay_ms: 20,
            base_maximum_delay_ms: 200,
            ..Default::default()
        };
        let mut delay_manager = DelayManager::new(config);

        assert_eq!(delay_manager.effective_minimum_delay_ms, 20);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 200);

        // Set minimum delay
        assert_eq!(delay_manager.set_minimum_delay(50), 50);
        assert_eq!(delay_manager.target_delay_ms(), 80); // max(80, 50) = 80
        assert_eq!(delay_manager.effective_minimum_delay_ms, 50);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 200);

        // Set maximum delay
        assert_eq!(delay_manager.set_maximum_delay(150), 150);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 50);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 150);

        // Set maximum below minimum
        assert_eq!(delay_manager.set_maximum_delay(40), 50);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 50);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 50);

        // Lower minumum
        assert_eq!(delay_manager.set_minimum_delay(30), 30);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 30);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 40);

        // Set minumum lower than base max
        assert_eq!(delay_manager.set_minimum_delay(300), 200);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 200);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 200);

        // Reset max
        assert_eq!(delay_manager.set_maximum_delay(0), 200);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 200);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 200);

        // Reset min
        assert_eq!(delay_manager.set_minimum_delay(0), 20);
        assert_eq!(delay_manager.effective_minimum_delay_ms, 20);
        assert_eq!(delay_manager.effective_maximum_delay_ms, 200);
    }

    #[test]
    fn test_delay_manager_reset() {
        let config = DelayConfig::default();
        let mut delay_manager = DelayManager::new(config);

        // Update with some packets
        delay_manager.update(0, 16000, false).unwrap();
        delay_manager.update(320, 16000, false).unwrap();

        // Reset and check state
        delay_manager.reset();
        assert_eq!(delay_manager.target_delay_ms(), 80); // Reset to kStartDelayMs
    }
}