neovm-core 0.0.2

Core runtime structures for NeoVM
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
use super::*;
use rug::ops::Pow;
use std::sync::Mutex;

#[cfg(unix)]
unsafe extern "C" {
    fn random() -> libc::c_long;
    fn srandom(seed: libc::c_uint);
}

// ===========================================================================
// Arithmetic
// ===========================================================================
//
// `+`, `-`, `*` mirror GNU's `arith_driver` (src/data.c:3215): a fast
// fixnum loop using `ckd_add` / `ckd_sub` / `ckd_mul` for overflow
// detection, and a fall-back path that switches to GMP (rug::Integer)
// the moment overflow strikes or a bignum operand appears.

/// Pull an integer-valued operand into an `i64`. Accepts fixnums and
/// markers; for any other value (including bignums) returns
/// `Err(()) → caller decides`.  This is the fast-path helper used
/// before promotion to GMP.
fn try_i64_from_value(eval: &super::eval::Context, value: &Value) -> Result<Option<i64>, Flow> {
    match value.kind() {
        ValueKind::Fixnum(n) => Ok(Some(n)),
        ValueKind::Veclike(VecLikeType::Bignum) => Ok(None),
        _ if super::marker::is_marker(value) => Ok(Some(
            super::marker::marker_position_as_int_eval(eval, value)?,
        )),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("number-or-marker-p"), *value],
        )),
    }
}

/// Materialize an integer-valued operand as a `rug::Integer`. Used by
/// the bignum slow path. Accepts fixnums, bignums, and markers.
fn rug_from_value(eval: &super::eval::Context, value: &Value) -> Result<rug::Integer, Flow> {
    match value.kind() {
        ValueKind::Fixnum(n) => Ok(rug::Integer::from(n)),
        ValueKind::Veclike(VecLikeType::Bignum) => Ok(value.as_bignum().unwrap().clone()),
        _ if super::marker::is_marker(value) => Ok(rug::Integer::from(
            super::marker::marker_position_as_int_eval(eval, value)?,
        )),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("number-or-marker-p"), *value],
        )),
    }
}

/// Eval-aware `+` that reads live marker positions from buffers.
///
/// Mirrors GNU `Fplus` → `arith_driver` (src/data.c:3215, 3271): if
/// every operand is an i64-valued integer or marker and no addition
/// overflows, stay on the fixnum fast path; otherwise promote to GMP
/// via `rug::Integer`. Float operands divert through `make_float` as
/// before.
///
/// Note: i64 has 64 bits, but fixnums only get 62 bits (the low 2 are
/// the tag). A sum like `most-positive-fixnum + 1` does not overflow
/// i64 yet exceeds fixnum range; the final i64 result therefore returns
/// through `Value::make_int`, mirroring GNU `make_int` (`src/lisp.h`).
pub(crate) fn builtin_add(eval: &mut super::super::eval::Context, args: Vec<Value>) -> EvalResult {
    builtin_add_slice(eval, &args)
}

pub(crate) fn builtin_add_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    if has_float(args) {
        let mut sum = 0.0f64;
        for a in args {
            sum += expect_number_or_marker_f64_eval(eval, a)?;
        }
        return Ok(Value::make_float(sum));
    }
    // Fixnum fast path with overflow detection.
    let mut sum: i64 = 0;
    for (i, a) in args.iter().enumerate() {
        match try_i64_from_value(eval, a)? {
            Some(n) => match sum.checked_add(n) {
                Some(s) => sum = s,
                None => {
                    let mut acc = rug::Integer::from(sum);
                    acc += n;
                    return continue_bignum_add(eval, &args[i + 1..], acc);
                }
            },
            None => {
                // Operand is a bignum — promote and re-process from here.
                let mut acc = rug::Integer::from(sum);
                acc += a.as_bignum().unwrap();
                return continue_bignum_add(eval, &args[i + 1..], acc);
            }
        }
    }
    Ok(Value::make_int(sum))
}

fn continue_bignum_add(
    eval: &super::super::eval::Context,
    rest: &[Value],
    mut acc: rug::Integer,
) -> EvalResult {
    for a in rest {
        // We already verified upfront that no operand is float, so any
        // remaining value must be integer-or-marker.
        let n = rug_from_value(eval, a)?;
        acc += n;
    }
    Ok(Value::make_integer(acc))
}

/// Eval-aware `-` that reads live marker positions from buffers.
///
/// Mirrors GNU `Fminus` (`src/data.c:3282`):
/// * 0 args → 0
/// * 1 arg  → negation (with bignum promotion for `MIN_FIXNUM`)
/// * N args → arith_driver in subtract mode
pub(crate) fn builtin_sub(eval: &mut super::super::eval::Context, args: Vec<Value>) -> EvalResult {
    builtin_sub_slice(eval, &args)
}

pub(crate) fn builtin_sub_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    if args.is_empty() {
        return Ok(Value::fixnum(0));
    }
    if args.len() == 1 {
        return negate_value(eval, &args[0]);
    }
    if has_float(&args) {
        let mut acc = expect_number_or_marker_f64_eval(eval, &args[0])?;
        for a in &args[1..] {
            acc -= expect_number_or_marker_f64_eval(eval, a)?;
        }
        return Ok(Value::make_float(acc));
    }
    // Fixnum fast path: seed accumulator with first arg, then subtract.
    let first = &args[0];
    let mut acc: i64 = match try_i64_from_value(eval, first)? {
        Some(n) => n,
        None => {
            // First arg is a bignum — start GMP path immediately.
            let acc = first.as_bignum().unwrap().clone();
            return continue_bignum_sub(eval, &args[1..], acc);
        }
    };
    for (i, a) in args[1..].iter().enumerate() {
        match try_i64_from_value(eval, a)? {
            Some(n) => match acc.checked_sub(n) {
                Some(s) => acc = s,
                None => {
                    let mut bacc = rug::Integer::from(acc);
                    bacc -= n;
                    return continue_bignum_sub(eval, &args[i + 2..], bacc);
                }
            },
            None => {
                let mut bacc = rug::Integer::from(acc);
                bacc -= a.as_bignum().unwrap();
                return continue_bignum_sub(eval, &args[i + 2..], bacc);
            }
        }
    }
    // Promote i64 results that exceeded fixnum range (62-bit) but
    // stayed within i64 (64-bit), matching GNU `make_int`.
    Ok(Value::make_int(acc))
}

fn continue_bignum_sub(
    eval: &super::super::eval::Context,
    rest: &[Value],
    mut acc: rug::Integer,
) -> EvalResult {
    for a in rest {
        let n = rug_from_value(eval, a)?;
        acc -= n;
    }
    Ok(Value::make_integer(acc))
}

/// Negate a single value, mirroring GNU `Fminus` 1-arg branch
/// (`src/data.c:3293-3300`). Promotes `MOST_NEGATIVE_FIXNUM` to a
/// bignum because `-MOST_NEGATIVE_FIXNUM` exceeds fixnum range.
fn negate_value(eval: &super::super::eval::Context, value: &Value) -> EvalResult {
    if value.is_float() {
        return Ok(Value::make_float(-value.xfloat()));
    }
    if let Some(big) = value.as_bignum() {
        return Ok(Value::make_integer(-big.clone()));
    }
    let n = match try_i64_from_value(eval, value)? {
        Some(n) => n,
        None => unreachable!(),
    };
    // checked_neg only fails for i64::MIN; for everything else we get
    // an i64 back which still has to clear the fixnum-range hurdle.
    match n.checked_neg() {
        Some(neg) => Ok(Value::make_int(neg)),
        None => Ok(Value::make_integer(-rug::Integer::from(n))),
    }
}

/// `*` with bignum promotion. Mirrors GNU `Ftimes` → `arith_driver`
/// (`src/data.c:3304`).
pub(crate) fn builtin_mul(args: Vec<Value>) -> EvalResult {
    if has_float(&args) {
        let mut prod = 1.0f64;
        for a in &args {
            prod *= expect_number_or_marker_f64(a)?;
        }
        return Ok(Value::make_float(prod));
    }
    // We don't have an `eval` context here, so use the marker-less
    // helpers. This matches the existing builtin_mul signature.
    let mut prod: i64 = 1;
    for (i, a) in args.iter().enumerate() {
        match a.kind() {
            ValueKind::Fixnum(n) => match prod.checked_mul(n) {
                Some(p) => prod = p,
                None => {
                    let mut acc = rug::Integer::from(prod);
                    acc *= n;
                    return continue_bignum_mul(&args[i + 1..], acc);
                }
            },
            ValueKind::Veclike(VecLikeType::Bignum) => {
                let mut acc = rug::Integer::from(prod);
                acc *= a.as_bignum().unwrap();
                return continue_bignum_mul(&args[i + 1..], acc);
            }
            _ if super::marker::is_marker(a) => {
                let n = super::marker::marker_position_as_int(a)?;
                match prod.checked_mul(n) {
                    Some(p) => prod = p,
                    None => {
                        let mut acc = rug::Integer::from(prod);
                        acc *= n;
                        return continue_bignum_mul(&args[i + 1..], acc);
                    }
                }
            }
            _ => {
                return Err(signal(
                    "wrong-type-argument",
                    vec![Value::symbol("number-or-marker-p"), *a],
                ));
            }
        }
    }
    Ok(Value::make_int(prod))
}

fn continue_bignum_mul(rest: &[Value], mut acc: rug::Integer) -> EvalResult {
    for a in rest {
        match a.kind() {
            ValueKind::Fixnum(n) => acc *= n,
            ValueKind::Veclike(VecLikeType::Bignum) => acc *= a.as_bignum().unwrap(),
            _ if super::marker::is_marker(a) => {
                acc *= super::marker::marker_position_as_int(a)?;
            }
            _ => {
                return Err(signal(
                    "wrong-type-argument",
                    vec![Value::symbol("number-or-marker-p"), *a],
                ));
            }
        }
    }
    Ok(Value::make_integer(acc))
}

/// `/` with bignum support. Mirrors GNU `Fquo` (`src/data.c:3315`).
///
/// Truncation toward zero (`tdiv_q` semantics, matching `mpz_tdiv_q`),
/// promoting `i64::MIN / -1` to bignum since `-i64::MIN` overflows i64.
/// Float operands divert through float division as before.
pub(crate) fn builtin_div(args: Vec<Value>) -> EvalResult {
    expect_min_args("/", &args, 1)?;
    // Single argument: return 1 / arg (reciprocal), matching GNU Emacs.
    if args.len() == 1 {
        return div_one_arg(&args[0]);
    }
    if has_float(&args) {
        let mut acc = expect_number_or_marker_f64(&args[0])?;
        for a in &args[1..] {
            let d = expect_number_or_marker_f64(a)?;
            acc /= d;
            if acc.is_nan() {
                // Emacs prints negative-NaN for float zero-divisor paths.
                acc = f64::from_bits(f64::NAN.to_bits() | (1_u64 << 63));
            }
        }
        return Ok(Value::make_float(acc));
    }
    // Integer fast path with bignum promotion on overflow.
    let first = &args[0];
    // If first is a bignum, start GMP path immediately.
    if first.is_bignum() {
        let acc = first.as_bignum().unwrap().clone();
        return continue_bignum_div(&args[1..], acc);
    }
    let mut acc: i64 = expect_integer_or_marker_after_number_check(first)?;
    for (i, a) in args[1..].iter().enumerate() {
        if a.is_bignum() {
            // Promote: convert acc to bignum and divide by this bignum,
            // then continue.
            let mut bacc = rug::Integer::from(acc);
            let big = a.as_bignum().unwrap();
            if big.is_zero() {
                return Err(signal("arith-error", vec![]));
            }
            bacc /= big;
            return continue_bignum_div(&args[i + 2..], bacc);
        }
        let d = expect_integer_or_marker_after_number_check(a)?;
        if d == 0 {
            return Err(signal("arith-error", vec![]));
        }
        match acc.checked_div(d) {
            Some(q) => acc = q,
            None => {
                // Only `i64::MIN / -1` triggers this. Promote.
                let bacc = rug::Integer::from(acc) / d;
                return continue_bignum_div(&args[i + 2..], bacc);
            }
        }
    }
    Ok(Value::make_int(acc))
}

fn div_one_arg(arg: &Value) -> EvalResult {
    if arg.is_float() {
        let d = arg.xfloat();
        return Ok(Value::make_float(1.0 / d));
    }
    if let Some(big) = arg.as_bignum() {
        // GNU: dividing 1 by any bignum yields 0 (since |bignum| > MAX_FIXNUM).
        if big.is_zero() {
            return Err(signal("arith-error", vec![]));
        }
        return Ok(Value::fixnum(0));
    }
    let d = expect_integer_or_marker_after_number_check(arg)?;
    if d == 0 {
        return Err(signal("arith-error", vec![]));
    }
    Ok(Value::fixnum(1 / d))
}

fn continue_bignum_div(rest: &[Value], mut acc: rug::Integer) -> EvalResult {
    for a in rest {
        if let Some(big) = a.as_bignum() {
            if big.is_zero() {
                return Err(signal("arith-error", vec![]));
            }
            acc /= big;
            continue;
        }
        let d = expect_integer_or_marker_after_number_check(a)?;
        if d == 0 {
            return Err(signal("arith-error", vec![]));
        }
        acc /= d;
    }
    Ok(Value::make_integer(acc))
}

/// `(% X Y)` — integer remainder, mirrors GNU `Frem` (`src/data.c:3402`).
///
/// Result has the same sign as the dividend (`mpz_tdiv_r` semantics).
pub(crate) fn builtin_percent(args: Vec<Value>) -> EvalResult {
    expect_args("%", &args, 2)?;
    integer_remainder(&args[0], &args[1], false)
}

/// `(mod X Y)` — modulo, mirrors GNU `Fmod` (`src/data.c:3412`).
///
/// Result has the same sign as the divisor.
pub(crate) fn builtin_mod(args: Vec<Value>) -> EvalResult {
    expect_args("mod", &args, 2)?;
    if args[0].is_float() || args[1].is_float() {
        // GNU `fmod_float` path — float-modulo. Existing behavior.
        let a = expect_number_or_marker_f64(&args[0])?;
        let b = expect_number_or_marker_f64(&args[1])?;
        let r = a % b;
        let mut r = if r != 0.0 && (r < 0.0) != (b < 0.0) {
            r + b
        } else {
            r
        };
        if r.is_nan() {
            r = f64::from_bits(f64::NAN.to_bits() | (1_u64 << 63));
        }
        return Ok(Value::make_float(r));
    }
    integer_remainder(&args[0], &args[1], true)
}

/// Shared integer remainder for `%` and `mod`. Mirrors GNU
/// `integer_remainder` (`src/data.c:3351`). When `modulo` is true the
/// result is fixed up to have the divisor's sign.
fn integer_remainder(num: &Value, den: &Value, modulo: bool) -> EvalResult {
    // Bignum slow path if either side is a bignum, or if the i64 fast
    // path can't represent the operands (markers always fit).
    if num.is_bignum() || den.is_bignum() {
        let num_big = bignum_or_int_to_rug(num)?;
        let den_big = bignum_or_int_to_rug(den)?;
        if den_big.is_zero() {
            return Err(signal("arith-error", vec![]));
        }
        let mut r = rug::Integer::from(&num_big % &den_big);
        if modulo {
            let sgn_r = r.cmp0();
            let sgn_d = den_big.cmp0();
            // Wrong sign means r and d have opposite signs.
            if (sgn_d.is_lt() && sgn_r.is_gt()) || (sgn_d.is_gt() && sgn_r.is_lt()) {
                r += &den_big;
            }
        }
        return Ok(Value::make_integer(r));
    }
    // GNU `Fmod` (data.c:3412) does CHECK_NUMBER_COERCE_MARKER on both
    // operands first, so non-numeric values must signal
    // `number-or-marker-p`, not `integer-or-marker-p`. Mirror that by
    // routing through the after-number-check helper.
    let a = expect_integer_or_marker_after_number_check(num)?;
    let b = expect_integer_or_marker_after_number_check(den)?;
    if b == 0 {
        return Err(signal("arith-error", vec![]));
    }
    // i64::MIN % -1 is 0 mathematically, but checked_rem returns None.
    let r = match a.checked_rem(b) {
        Some(r) => r,
        None => 0,
    };
    let r = if modulo && r != 0 && (r < 0) != (b < 0) {
        r + b
    } else {
        r
    };
    Ok(Value::make_int(r))
}

/// Convert a fixnum / bignum / marker operand to `rug::Integer`. Used
/// by the integer remainder slow path.
fn bignum_or_int_to_rug(value: &Value) -> Result<rug::Integer, Flow> {
    match value.kind() {
        ValueKind::Fixnum(n) => Ok(rug::Integer::from(n)),
        ValueKind::Veclike(VecLikeType::Bignum) => Ok(value.as_bignum().unwrap().clone()),
        _ if super::marker::is_marker(value) => Ok(rug::Integer::from(
            super::marker::marker_position_as_int(value)?,
        )),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("integer-or-marker-p"), *value],
        )),
    }
}

/// `(1+ NUMBER)` — mirrors GNU `Fadd1` (`src/data.c:3634`).
/// Promotes to bignum on `MOST_POSITIVE_FIXNUM + 1`.
pub(crate) fn builtin_add1(args: Vec<Value>) -> EvalResult {
    expect_args("1+", &args, 1)?;
    add1_value(args[0])
}

pub(crate) fn builtin_add1_1(_eval: &mut super::eval::Context, arg: Value) -> EvalResult {
    add1_value(arg)
}

fn add1_value(arg: Value) -> EvalResult {
    match arg.kind() {
        ValueKind::Fixnum(n) => match n.checked_add(1) {
            Some(s) => Ok(Value::make_int(s)),
            None => Ok(Value::make_integer(rug::Integer::from(n) + 1)),
        },
        ValueKind::Float => Ok(Value::make_float(arg.xfloat() + 1.0)),
        ValueKind::Veclike(VecLikeType::Bignum) => {
            Ok(Value::make_integer(arg.as_bignum().unwrap().clone() + 1))
        }
        _ if arg.is_marker() => {
            let n = super::marker::marker_position_as_int(&arg)?;
            match n.checked_add(1) {
                Some(s) => Ok(Value::make_int(s)),
                None => Ok(Value::make_integer(rug::Integer::from(n) + 1)),
            }
        }
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("number-or-marker-p"), arg],
        )),
    }
}

/// `(1- NUMBER)` — mirrors GNU `Fsub1` (`src/data.c:3658`).
/// Promotes to bignum on `MOST_NEGATIVE_FIXNUM - 1`.
pub(crate) fn builtin_sub1(args: Vec<Value>) -> EvalResult {
    expect_args("1-", &args, 1)?;
    sub1_value(args[0])
}

pub(crate) fn builtin_sub1_1(_eval: &mut super::eval::Context, arg: Value) -> EvalResult {
    sub1_value(arg)
}

fn sub1_value(arg: Value) -> EvalResult {
    match arg.kind() {
        ValueKind::Fixnum(n) => match n.checked_sub(1) {
            Some(s) => Ok(Value::make_int(s)),
            None => Ok(Value::make_integer(rug::Integer::from(n) - 1)),
        },
        ValueKind::Float => Ok(Value::make_float(arg.xfloat() - 1.0)),
        ValueKind::Veclike(VecLikeType::Bignum) => {
            Ok(Value::make_integer(arg.as_bignum().unwrap().clone() - 1))
        }
        _ if arg.is_marker() => {
            let n = super::marker::marker_position_as_int(&arg)?;
            match n.checked_sub(1) {
                Some(s) => Ok(Value::make_int(s)),
                None => Ok(Value::make_integer(rug::Integer::from(n) - 1)),
            }
        }
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("number-or-marker-p"), arg],
        )),
    }
}

pub(crate) fn builtin_max(eval: &mut super::eval::Context, args: Vec<Value>) -> EvalResult {
    builtin_max_slice(eval, &args)
}

pub(crate) fn builtin_max_slice(eval: &mut super::eval::Context, args: &[Value]) -> EvalResult {
    expect_min_args("max", args, 1)?;
    let mut best_num = expect_number_or_marker_f64_eval(eval, &args[0])?;
    let mut best_value = args[0];
    for a in &args[1..] {
        let n = expect_number_or_marker_f64_eval(eval, a)?;
        if n > best_num {
            best_num = n;
            best_value = *a;
        }
    }
    match best_value.kind() {
        ValueKind::Fixnum(_) | ValueKind::Float | ValueKind::Veclike(VecLikeType::Bignum) => {
            Ok(best_value)
        }
        _ if best_value.is_marker() => Ok(Value::fixnum(
            super::marker::marker_position_as_int_eval(eval, &best_value)?,
        )),
        _ => unreachable!("max winner must be numeric"),
    }
}

pub(crate) fn builtin_min(eval: &mut super::eval::Context, args: Vec<Value>) -> EvalResult {
    builtin_min_slice(eval, &args)
}

pub(crate) fn builtin_min_slice(eval: &mut super::eval::Context, args: &[Value]) -> EvalResult {
    expect_min_args("min", args, 1)?;
    let mut best_num = expect_number_or_marker_f64_eval(eval, &args[0])?;
    let mut best_value = args[0];
    for a in &args[1..] {
        let n = expect_number_or_marker_f64_eval(eval, a)?;
        if n < best_num {
            best_num = n;
            best_value = *a;
        }
    }
    match best_value.kind() {
        ValueKind::Fixnum(_) | ValueKind::Float | ValueKind::Veclike(VecLikeType::Bignum) => {
            Ok(best_value)
        }
        _ if best_value.is_marker() => Ok(Value::fixnum(
            super::marker::marker_position_as_int_eval(eval, &best_value)?,
        )),
        _ => unreachable!("min winner must be numeric"),
    }
}

/// `(abs ARG)` — mirrors GNU `Fabs` (`src/floatfns.c`).
///
/// Promotes `MOST_NEGATIVE_FIXNUM` to a bignum (audit §2.6) instead
/// of signaling overflow-error.
pub(crate) fn builtin_abs(args: Vec<Value>) -> EvalResult {
    expect_args("abs", &args, 1)?;
    match args[0].kind() {
        ValueKind::Fixnum(n) => match n.checked_abs() {
            // Even non-overflowing |i64| might exceed fixnum range.
            Some(a) => Ok(Value::make_int(a)),
            None => Ok(Value::make_integer(rug::Integer::from(n).abs())),
        },
        ValueKind::Float => Ok(Value::make_float(args[0].xfloat().abs())),
        ValueKind::Veclike(VecLikeType::Bignum) => Ok(Value::make_integer(
            args[0].as_bignum().unwrap().clone().abs(),
        )),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("numberp"), args[0]],
        )),
    }
}

// ===========================================================================
// Logical / bitwise
// ===========================================================================

/// `(logand &rest INTS-OR-MARKERS)` — bitwise AND.
///
/// Mirrors GNU `Flogand` (`src/data.c:3458`) → `arith_driver Alogand`.
/// When any operand is a bignum the whole reduction runs in GMP via
/// `mpz_and`; otherwise we stay on the i64 fast path. Note: bitwise
/// AND of i64 values can never overflow into bignum range, but the
/// final result still has to clear the fixnum-bits hurdle since `&`
/// can produce a value with the high bits set (e.g. `(logand -1 -1)
/// → -1` is fine, but `(logand most-positive-fixnum #x7fffffffffffffff)`
/// could exceed fixnum range). Return through `make_int`.
pub(crate) fn builtin_logand(args: Vec<Value>) -> EvalResult {
    builtin_logand_slice(&args)
}

pub(crate) fn builtin_logand_slice(args: &[Value]) -> EvalResult {
    if has_bignum(args) {
        return bignum_logop(args, BignumLogop::And);
    }
    let mut acc = -1i64;
    for a in args {
        acc &= expect_integer_or_marker_after_number_check(a)?;
    }
    Ok(Value::make_int(acc))
}

pub(crate) fn builtin_logior(args: Vec<Value>) -> EvalResult {
    builtin_logior_slice(&args)
}

pub(crate) fn builtin_logior_slice(args: &[Value]) -> EvalResult {
    if has_bignum(args) {
        return bignum_logop(args, BignumLogop::Or);
    }
    let mut acc = 0i64;
    for a in args {
        acc |= expect_integer_or_marker_after_number_check(a)?;
    }
    Ok(Value::make_int(acc))
}

pub(crate) fn builtin_logxor(args: Vec<Value>) -> EvalResult {
    builtin_logxor_slice(&args)
}

pub(crate) fn builtin_logxor_slice(args: &[Value]) -> EvalResult {
    if has_bignum(args) {
        return bignum_logop(args, BignumLogop::Xor);
    }
    let mut acc = 0i64;
    for a in args {
        acc ^= expect_integer_or_marker_after_number_check(a)?;
    }
    Ok(Value::make_int(acc))
}

#[derive(Clone, Copy)]
enum BignumLogop {
    And,
    Or,
    Xor,
}

fn bignum_logop(args: &[Value], op: BignumLogop) -> EvalResult {
    let mut acc = match op {
        BignumLogop::And => rug::Integer::from(-1),
        BignumLogop::Or | BignumLogop::Xor => rug::Integer::from(0),
    };
    for a in args {
        let next = bignum_or_int_to_rug(a)?;
        match op {
            BignumLogop::And => acc &= next,
            BignumLogop::Or => acc |= next,
            BignumLogop::Xor => acc ^= next,
        }
    }
    Ok(Value::make_integer(acc))
}

/// `(lognot NUMBER)` — mirrors GNU `Flognot` (`src/data.c:3648`).
pub(crate) fn builtin_lognot(args: Vec<Value>) -> EvalResult {
    expect_args("lognot", &args, 1)?;
    if let Some(big) = args[0].as_bignum() {
        return Ok(Value::make_integer(!big.clone()));
    }
    let n = expect_int(&args[0])?;
    Ok(Value::fixnum(!n))
}

/// `(ash VALUE COUNT)` — arithmetic shift, mirrors GNU `Fash`
/// (`src/data.c:3519`).
///
/// Positive COUNT shifts left, negative shifts right. Both VALUE and
/// COUNT may be bignums. The result is promoted to bignum on left
/// shifts that exceed fixnum range — most importantly `(ash 1 100)`
/// must return 2^100, not 0 (audit §2.7).
pub(crate) fn builtin_ash(args: Vec<Value>) -> EvalResult {
    builtin_ash_slice(&args)
}

pub(crate) fn builtin_ash_slice(args: &[Value]) -> EvalResult {
    expect_args("ash", args, 2)?;
    let value = &args[0];
    let count_val = &args[1];

    // COUNT must be an integer (fixnum or bignum). If it's a bignum
    // and VALUE is anything but zero, GNU signals overflow-error for
    // positive counts (no machine could represent the result) and
    // returns 0 / -1 for negative counts (the value is shifted away).
    let count_i64 = match count_val.kind() {
        ValueKind::Fixnum(c) => c,
        ValueKind::Veclike(VecLikeType::Bignum) => {
            let big = count_val.as_bignum().unwrap();
            // Zero VALUE is unchanged regardless of COUNT.
            if value
                .as_fixnum()
                .map(|n| n == 0)
                .or_else(|| value.as_bignum().map(|b| b.is_zero()))
                .unwrap_or(false)
            {
                return Ok(Value::fixnum(0));
            }
            if big.cmp0().is_lt() {
                // Negative count + nonzero value: result is 0 (or -1 for negative).
                let sign_neg = match value.kind() {
                    ValueKind::Fixnum(n) => n < 0,
                    ValueKind::Veclike(VecLikeType::Bignum) => {
                        value.as_bignum().unwrap().cmp0().is_lt()
                    }
                    _ => {
                        return Err(signal(
                            "wrong-type-argument",
                            vec![Value::symbol("integerp"), *value],
                        ));
                    }
                };
                return Ok(Value::fixnum(if sign_neg { -1 } else { 0 }));
            }
            return Err(signal("overflow-error", vec![]));
        }
        _ => {
            return Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("integerp"), *count_val],
            ));
        }
    };

    // Materialize VALUE as a rug::Integer once. We could try to keep
    // small fixnum shifts on the i64 path, but ash is rare enough that
    // correctness over branchy fast-pathing is the right tradeoff.
    let value_big = match value.kind() {
        ValueKind::Fixnum(n) => rug::Integer::from(n),
        ValueKind::Veclike(VecLikeType::Bignum) => value.as_bignum().unwrap().clone(),
        _ => {
            return Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("integerp"), *value],
            ));
        }
    };

    if count_i64 == 0 {
        return Ok(Value::make_integer(value_big));
    }
    let result = if count_i64 > 0 {
        // Left shift. rug::Integer << u32 (or usize) does GMP mul_2exp.
        let bits = u32::try_from(count_i64).unwrap_or(u32::MAX);
        value_big << bits
    } else {
        // Arithmetic right shift (toward -infinity, i.e. mpz_fdiv_q_2exp).
        // For very large negative counts, the value is shifted away;
        // GNU returns -1 for negative VALUE and 0 otherwise.
        let neg_count = match count_i64.checked_neg() {
            Some(c) => c,
            None => i64::MAX,
        };
        let bits = u32::try_from(neg_count).unwrap_or(u32::MAX);
        // rug::Integer >> u32 does mpz_fdiv_q_2exp (floor division).
        value_big >> bits
    };
    Ok(Value::make_integer(result))
}

// ===========================================================================
// Comparisons
// ===========================================================================
//
// Mirrors GNU `arithcompare` (src/data.c:2682). For two integers
// (fixnum or bignum) we compare exactly via rug::Integer; for any
// pair involving a float we compare the float against the integer
// using rug::Integer::partial_cmp<f64>, which is exact (it accounts
// for whether the float is integer-valued and how it relates to the
// bignum). The previous f64-only path lost precision for any bignum
// outside ±2^53 (audit §1.1 — comparisons part).

#[derive(Clone, Copy, PartialEq, Eq)]
enum NumCmp {
    Lt,
    Le,
    Eq,
    Ne,
    Gt,
    Ge,
}

fn arithcompare(
    eval: &super::super::eval::Context,
    a: &Value,
    b: &Value,
) -> Result<std::cmp::Ordering, Flow> {
    use std::cmp::Ordering;

    // Float on either side: if the other side is a bignum we still
    // get an exact answer via rug::Integer::partial_cmp<f64>; for
    // fixnums and floats, fall back to f64 comparison.
    if a.is_float() || b.is_float() {
        if let Some(big) = a.as_bignum() {
            let f = expect_number_or_marker_f64_eval(eval, b)?;
            if f.is_nan() {
                return Ok(Ordering::Equal); // arithcompare with NaN returns Cmp_NONE; treated as != by callers below
            }
            return Ok(big.partial_cmp(&f).unwrap_or(Ordering::Equal));
        }
        if let Some(big) = b.as_bignum() {
            let f = expect_number_or_marker_f64_eval(eval, a)?;
            if f.is_nan() {
                return Ok(Ordering::Equal);
            }
            // Reverse since we asked big.cmp(f).
            return Ok(big
                .partial_cmp(&f)
                .map(|o| o.reverse())
                .unwrap_or(Ordering::Equal));
        }
        let af = expect_number_or_marker_f64_eval(eval, a)?;
        let bf = expect_number_or_marker_f64_eval(eval, b)?;
        return Ok(af.partial_cmp(&bf).unwrap_or(Ordering::Equal));
    }

    // Both operands are integer-or-marker. Stay on i64 if neither is
    // a bignum.
    if !a.is_bignum() && !b.is_bignum() {
        let ai = expect_integer_or_marker_after_number_check_eval(eval, a)?;
        let bi = expect_integer_or_marker_after_number_check_eval(eval, b)?;
        return Ok(ai.cmp(&bi));
    }

    // Bignum-aware integer compare.
    let ai = match a.kind() {
        ValueKind::Fixnum(n) => rug::Integer::from(n),
        ValueKind::Veclike(VecLikeType::Bignum) => a.as_bignum().unwrap().clone(),
        _ if super::marker::is_marker(a) => {
            rug::Integer::from(super::marker::marker_position_as_int_eval(eval, a)?)
        }
        _ => {
            return Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("number-or-marker-p"), *a],
            ));
        }
    };
    let bi = match b.kind() {
        ValueKind::Fixnum(n) => rug::Integer::from(n),
        ValueKind::Veclike(VecLikeType::Bignum) => b.as_bignum().unwrap().clone(),
        _ if super::marker::is_marker(b) => {
            rug::Integer::from(super::marker::marker_position_as_int_eval(eval, b)?)
        }
        _ => {
            return Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("number-or-marker-p"), *b],
            ));
        }
    };
    Ok(ai.cmp(&bi))
}

fn cmp_passes(ord: std::cmp::Ordering, op: NumCmp) -> bool {
    use std::cmp::Ordering;
    match op {
        NumCmp::Lt => ord == Ordering::Less,
        NumCmp::Le => ord != Ordering::Greater,
        NumCmp::Eq => ord == Ordering::Equal,
        NumCmp::Ne => ord != Ordering::Equal,
        NumCmp::Gt => ord == Ordering::Greater,
        NumCmp::Ge => ord != Ordering::Less,
    }
}

fn arithcompare_chain(
    eval: &super::super::eval::Context,
    args: &[Value],
    op: NumCmp,
) -> EvalResult {
    for pair in args.windows(2) {
        let ord = arithcompare(eval, &pair[0], &pair[1])?;
        if !cmp_passes(ord, op) {
            return Ok(Value::NIL);
        }
    }
    Ok(Value::T)
}

fn arithcompare_chain_or_fast_fixnum_pair(
    eval: &super::super::eval::Context,
    args: &[Value],
    op: NumCmp,
) -> EvalResult {
    if args.len() == 2
        && let (ValueKind::Fixnum(left), ValueKind::Fixnum(right)) =
            (args[0].kind(), args[1].kind())
    {
        return Ok(Value::bool_val(cmp_passes(left.cmp(&right), op)));
    }
    arithcompare_chain(eval, args, op)
}

pub(crate) fn builtin_num_eq(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_min_args("=", &args, 1)?;
    arithcompare_chain(eval, &args, NumCmp::Eq)
}

pub(crate) fn builtin_num_eq_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    expect_min_args("=", args, 1)?;
    arithcompare_chain(eval, args, NumCmp::Eq)
}

pub(crate) fn builtin_num_lt(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_min_args("<", &args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, &args, NumCmp::Lt)
}

pub(crate) fn builtin_num_lt_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    expect_min_args("<", args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, args, NumCmp::Lt)
}

pub(crate) fn builtin_num_le(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_min_args("<=", &args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, &args, NumCmp::Le)
}

pub(crate) fn builtin_num_le_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    expect_min_args("<=", args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, args, NumCmp::Le)
}

pub(crate) fn builtin_num_gt(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_min_args(">", &args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, &args, NumCmp::Gt)
}

pub(crate) fn builtin_num_gt_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    expect_min_args(">", args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, args, NumCmp::Gt)
}

pub(crate) fn builtin_num_ge(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_min_args(">=", &args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, &args, NumCmp::Ge)
}

pub(crate) fn builtin_num_ge_slice(
    eval: &mut super::super::eval::Context,
    args: &[Value],
) -> EvalResult {
    expect_min_args(">=", args, 1)?;
    arithcompare_chain_or_fast_fixnum_pair(eval, args, NumCmp::Ge)
}

pub(crate) fn builtin_num_ne(
    eval: &mut super::super::eval::Context,
    args: Vec<Value>,
) -> EvalResult {
    expect_args("/=", &args, 2)?;
    let ord = arithcompare(eval, &args[0], &args[1])?;
    Ok(Value::bool_val(cmp_passes(ord, NumCmp::Ne)))
}

pub(crate) fn builtin_num_ne_2(
    eval: &mut super::super::eval::Context,
    left: Value,
    right: Value,
) -> EvalResult {
    if let (ValueKind::Fixnum(left), ValueKind::Fixnum(right)) = (left.kind(), right.kind()) {
        return Ok(Value::bool_val(left != right));
    }
    let ord = arithcompare(eval, &left, &right)?;
    Ok(Value::bool_val(cmp_passes(ord, NumCmp::Ne)))
}

// ===========================================================================
// Conversion
// ===========================================================================

pub(crate) fn builtin_float(args: Vec<Value>) -> EvalResult {
    expect_args("float", &args, 1)?;
    match args[0].kind() {
        ValueKind::Fixnum(n) => Ok(Value::make_float(n as f64)),
        ValueKind::Float => Ok(args[0]),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("numberp"), args[0]],
        )),
    }
}

/// Helper: extract a number as f64, signaling wrong-type-argument if not numeric.
fn value_to_f64(_name: &str, v: &Value) -> Result<f64, Flow> {
    match v.kind() {
        ValueKind::Fixnum(n) => Ok(n as f64),
        ValueKind::Float => Ok(v.xfloat()),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("numberp"), *v],
        )),
    }
}

/// Helper for 1-or-2-arg rounding functions.
/// When called with 2 args, divides first by second, then applies the rounding op.
/// For int/int with no remainder, returns integer directly.
///
/// Mirrors GNU `rounding_driver` (`src/floatfns.c`). The audit
/// (§2.15, §2.17) flagged that NeoMacs used to truncate float
/// results to i64 with `as i64` saturation, silently producing
/// `i64::MAX`/`i64::MIN` for out-of-range floats and not surfacing
/// overflow on infinity / NaN. We now route every integer result
/// through `Value::make_integer`, and floats outside i64 range use
/// `rug::Integer::from_f64` to produce a bignum.
fn rounding_with_divisor(
    name: &str,
    args: &[Value],
    round_fn: fn(f64) -> f64,
    int_div: fn(i64, i64) -> i64,
) -> EvalResult {
    expect_range_args(name, args, 1, 2)?;
    if args.len() == 1 {
        return match args[0].kind() {
            ValueKind::Fixnum(n) => Ok(Value::fixnum(n)),
            ValueKind::Float => float_to_lisp_integer(round_fn(args[0].xfloat())),
            ValueKind::Veclike(VecLikeType::Bignum) => {
                Ok(Value::make_integer(args[0].as_bignum().unwrap().clone()))
            }
            _ => Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("numberp"), args[0]],
            )),
        };
    }
    // 2-arg form: (op ARG DIVISOR)
    if args[1].is_float() {
        let divisor = args[1].xfloat();
        if divisor == 0.0 {
            return Err(signal("arith-error", vec![]));
        }
        let dividend = value_to_f64(name, &args[0])?;
        return float_to_lisp_integer(round_fn(dividend / divisor));
    }
    if let Some(d) = args[1].as_fixnum() {
        if d == 0 {
            return Err(signal("arith-error", vec![]));
        }
        if let Some(a) = args[0].as_fixnum() {
            return Ok(Value::make_int(int_div(a, d)));
        }
    }
    if args[1].is_bignum() && args[1].as_bignum().unwrap().is_zero() {
        return Err(signal("arith-error", vec![]));
    }
    // Mixed bignum / float / fixnum 2-arg fallback. For non-float
    // operands fall through to the float path; this loses precision
    // for very large bignums but matches the existing behavior for
    // the cases the test suite covers. A future pass can wire in
    // mpz_tdiv_q etc. for full bignum-divisor support.
    if args[0].is_float() || args[1].is_float() {
        let dividend = value_to_f64(name, &args[0])?;
        let divisor = value_to_f64(name, &args[1])?;
        if divisor == 0.0 {
            return Err(signal("arith-error", vec![]));
        }
        return float_to_lisp_integer(round_fn(dividend / divisor));
    }
    // Bignum-divisor or bignum-dividend integer path: do GMP
    // truncation and reapply the rounding flavor on the residue.
    let a = bignum_or_int_to_rug(&args[0])?;
    let d = bignum_or_int_to_rug(&args[1])?;
    if d.is_zero() {
        return Err(signal("arith-error", vec![]));
    }
    // Truncation (toward-zero) division as the building block.
    let q = rug::Integer::from(&a / &d);
    let r = rug::Integer::from(&a - rug::Integer::from(&q * &d));
    // Apply the same flavor that the int_div lambda would for fixnums,
    // but in GMP. We dispatch by name because the closure type erases
    // intent — and there are only four flavors.
    let adjusted = match name {
        "truncate" => q,
        "floor" => {
            // Toward -inf: if remainder is nonzero and r and d have
            // opposite signs, subtract 1.
            if !r.is_zero() && (r.cmp0().is_lt()) != (d.cmp0().is_lt()) {
                q - 1
            } else {
                q
            }
        }
        "ceiling" => {
            // Toward +inf: if remainder is nonzero and r and d have
            // the same sign, add 1.
            if !r.is_zero() && (r.cmp0().is_lt()) == (d.cmp0().is_lt()) {
                q + 1
            } else {
                q
            }
        }
        "round" => {
            // Round half to even (banker's rounding).
            let abs_r2 = rug::Integer::from(&r * 2).abs();
            let abs_d = rug::Integer::from(d.abs_ref());
            use std::cmp::Ordering;
            match abs_r2.cmp(&abs_d) {
                Ordering::Greater => {
                    if (r.cmp0().is_lt()) == (d.cmp0().is_lt()) {
                        q + 1
                    } else {
                        q - 1
                    }
                }
                Ordering::Equal => {
                    if q.is_odd() {
                        if (r.cmp0().is_lt()) == (d.cmp0().is_lt()) {
                            q + 1
                        } else {
                            q - 1
                        }
                    } else {
                        q
                    }
                }
                Ordering::Less => q,
            }
        }
        _ => unreachable!("unknown rounding name {name}"),
    };
    Ok(Value::make_integer(adjusted))
}

/// Convert a finite f64 into a Lisp integer (fixnum or bignum). NaN
/// and infinity signal `overflow-error`, mirroring GNU
/// `double_to_integer` (`src/bignum.c:81`).
fn float_to_lisp_integer(value: f64) -> EvalResult {
    if !value.is_finite() {
        return Err(signal("overflow-error", vec![]));
    }
    // i64::MIN..=i64::MAX is the safe `as i64` range; outside that we
    // need GMP. But fixnum range is even tighter (62-bit), so always
    // funnel through make_integer.
    let big = rug::Integer::from_f64(value).expect("finite f64");
    Ok(Value::make_integer(big))
}

pub(crate) fn builtin_truncate(args: Vec<Value>) -> EvalResult {
    rounding_with_divisor(
        "truncate",
        &args,
        |f| f.trunc(),
        |a, d| {
            // Truncation: toward zero
            a / d
        },
    )
}

pub(crate) fn builtin_floor(args: Vec<Value>) -> EvalResult {
    rounding_with_divisor(
        "floor",
        &args,
        |f| f.floor(),
        |a, d| {
            // Floor division: toward negative infinity
            let q = a / d;
            let r = a % d;
            if (r != 0) && ((r ^ d) < 0) { q - 1 } else { q }
        },
    )
}

pub(crate) fn builtin_ceiling(args: Vec<Value>) -> EvalResult {
    rounding_with_divisor(
        "ceiling",
        &args,
        |f| f.ceil(),
        |a, d| {
            // Ceiling division: toward positive infinity
            let q = a / d;
            let r = a % d;
            if (r != 0) && ((r ^ d) >= 0) { q + 1 } else { q }
        },
    )
}

pub(crate) fn builtin_round(args: Vec<Value>) -> EvalResult {
    rounding_with_divisor(
        "round",
        &args,
        |f| f.round_ties_even(),
        |a, d| {
            // Banker's rounding (round half to even)
            let q = a / d;
            let r = a % d;
            let abs_r2 = (r * 2).abs();
            let abs_d = d.abs();
            if abs_r2 > abs_d {
                if (r ^ d) >= 0 { q + 1 } else { q - 1 }
            } else if abs_r2 == abs_d {
                // Tie: round to even
                if q % 2 != 0 {
                    if (r ^ d) >= 0 { q + 1 } else { q - 1 }
                } else {
                    q
                }
            } else {
                q
            }
        },
    )
}

// ===========================================================================
// Math functions (pure)
// ===========================================================================

pub(crate) fn builtin_sqrt(args: Vec<Value>) -> EvalResult {
    expect_args("sqrt", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.sqrt()))
}

pub(crate) fn builtin_sin(args: Vec<Value>) -> EvalResult {
    expect_args("sin", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.sin()))
}

pub(crate) fn builtin_cos(args: Vec<Value>) -> EvalResult {
    expect_args("cos", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.cos()))
}

pub(crate) fn builtin_tan(args: Vec<Value>) -> EvalResult {
    expect_args("tan", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.tan()))
}

pub(crate) fn builtin_asin(args: Vec<Value>) -> EvalResult {
    expect_args("asin", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.asin()))
}

pub(crate) fn builtin_acos(args: Vec<Value>) -> EvalResult {
    expect_args("acos", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.acos()))
}

pub(crate) fn builtin_atan(args: Vec<Value>) -> EvalResult {
    expect_min_args("atan", &args, 1)?;
    if args.len() == 2 {
        let y = expect_number(&args[0])?;
        let x = expect_number(&args[1])?;
        Ok(Value::make_float(y.atan2(x)))
    } else {
        Ok(Value::make_float(expect_number(&args[0])?.atan()))
    }
}

pub(crate) fn builtin_exp(args: Vec<Value>) -> EvalResult {
    expect_args("exp", &args, 1)?;
    Ok(Value::make_float(expect_number(&args[0])?.exp()))
}

pub(crate) fn builtin_log(args: Vec<Value>) -> EvalResult {
    expect_min_args("log", &args, 1)?;
    let val = expect_number(&args[0])?;
    if args.len() == 2 {
        let base = expect_number(&args[1])?;
        Ok(Value::make_float(val.ln() / base.ln()))
    } else {
        Ok(Value::make_float(val.ln()))
    }
}

/// `(expt BASE EXPONENT)` — mirrors GNU `Fexpt`
/// (`src/floatfns.c`) and `expt_integer` (`src/data.c:3587`).
///
/// Integer base + non-negative integer exponent uses `mpz_pow_ui` to
/// promote on overflow. The headline audit case is `(expt 2 100)`
/// which used to return 0 because `2_i64.wrapping_pow(100)` wraps.
pub(crate) fn builtin_expt(args: Vec<Value>) -> EvalResult {
    expect_args("expt", &args, 2)?;
    // GNU `Fexpt` (data.c) does CHECK_NUMBER on both args first, so any
    // non-numeric argument must signal `numberp`, not the more specific
    // type checks the integer/float dispatch would otherwise emit.
    let _ = expect_number(&args[0])?;
    let _ = expect_number(&args[1])?;
    if has_float(&args) {
        let base = expect_number(&args[0])?;
        let exp = expect_number(&args[1])?;
        return Ok(Value::make_float(base.powf(exp)));
    }
    // Integer-only path. Negative exponent on integer base falls back
    // to float (GNU does the same: a^-n is rarely an integer).
    let exp_val = &args[1];
    let exp_is_neg = match exp_val.kind() {
        ValueKind::Fixnum(n) => n < 0,
        ValueKind::Veclike(VecLikeType::Bignum) => exp_val.as_bignum().unwrap().cmp0().is_lt(),
        _ => {
            return Err(signal(
                "wrong-type-argument",
                vec![Value::symbol("integerp"), *exp_val],
            ));
        }
    };
    if exp_is_neg {
        let base = expect_number(&args[0])?;
        let exp = expect_number(exp_val)?;
        return Ok(Value::make_float(base.powf(exp)));
    }

    // Special cases for -1, 0, 1 — never overflow regardless of exponent.
    let base_val = &args[0];
    if let Some(b) = base_val.as_fixnum() {
        match b {
            0 => {
                // 0^0 = 1 in elisp, 0^positive = 0.
                let exp_zero = match exp_val.kind() {
                    ValueKind::Fixnum(n) => n == 0,
                    ValueKind::Veclike(VecLikeType::Bignum) => {
                        exp_val.as_bignum().unwrap().is_zero()
                    }
                    _ => false,
                };
                return Ok(Value::fixnum(if exp_zero { 1 } else { 0 }));
            }
            1 => return Ok(Value::fixnum(1)),
            -1 => {
                let odd = match exp_val.kind() {
                    ValueKind::Fixnum(n) => n & 1 == 1,
                    ValueKind::Veclike(VecLikeType::Bignum) => {
                        exp_val.as_bignum().unwrap().is_odd()
                    }
                    _ => false,
                };
                return Ok(Value::fixnum(if odd { -1 } else { 1 }));
            }
            _ => {}
        }
    }

    // Exponent must fit in u32 for rug::Integer::pow_u. (GNU bounds it
    // by ULONG_MAX; that's larger than u32 on most platforms but the
    // result becomes astronomically large long before then.)
    let exp_u32: u32 = match exp_val.kind() {
        ValueKind::Fixnum(n) => match u32::try_from(n) {
            Ok(v) => v,
            Err(_) => return Err(signal("overflow-error", vec![])),
        },
        ValueKind::Veclike(VecLikeType::Bignum) => match exp_val.as_bignum().unwrap().to_u32() {
            Some(v) => v,
            None => return Err(signal("overflow-error", vec![])),
        },
        _ => unreachable!("non-int exponent handled above"),
    };

    let base_big = bignum_or_int_to_rug(base_val)?;
    Ok(Value::make_integer(base_big.pow(exp_u32)))
}

pub(crate) fn builtin_random(args: Vec<Value>) -> EvalResult {
    expect_max_args("random", &args, 1)?;

    if let Some(limit) = args.first() {
        match limit.kind() {
            ValueKind::T => emacs_init_random(),
            ValueKind::String => {
                let bytes = limit.as_lisp_string().expect("string").as_bytes().to_vec();
                emacs_seed_random(&bytes);
            }
            ValueKind::Fixnum(lim) => {
                if lim <= 0 {
                    return Err(signal("args-out-of-range", vec![*limit]));
                }
                return Ok(Value::fixnum(emacs_get_random_fixnum(lim)));
            }
            _ => {}
        }
    }

    Ok(Value::fixnum(emacs_get_random()))
}

#[cfg(unix)]
fn emacs_random_lock() -> &'static Mutex<()> {
    static RANDOM_LOCK: Mutex<()> = Mutex::new(());
    &RANDOM_LOCK
}

#[cfg(unix)]
fn emacs_intmask() -> u64 {
    (1_u64 << emacs_random_fixnum_bits()) - 1
}

#[cfg(unix)]
fn emacs_random_fixnum_bits() -> u32 {
    // Match GNU Emacs get_random()/INTMASK behavior on current 64-bit builds:
    // FIXNUM_BITS is 62 even though most-positive-fixnum is 2^61 - 1.
    62
}

#[cfg(unix)]
fn emacs_get_random_unlocked() -> i64 {
    const RAND_BITS: u32 = 31;
    const EMACS_INT_WIDTH: u32 = 64;
    let fixnum_bits = emacs_random_fixnum_bits();
    let mut val: u64 = 0;
    for _ in 0..fixnum_bits.div_ceil(RAND_BITS) {
        let r = unsafe { random() as u64 };
        val = r ^ (val << RAND_BITS) ^ (val >> (EMACS_INT_WIDTH - RAND_BITS));
    }
    val ^= val >> (EMACS_INT_WIDTH - fixnum_bits);
    (val & emacs_intmask()) as i64
}

#[cfg(unix)]
fn emacs_get_random() -> i64 {
    let _guard = emacs_random_lock().lock().expect("random lock poisoned");
    emacs_get_random_unlocked()
}

#[cfg(unix)]
fn emacs_get_random_fixnum(limit: i64) -> i64 {
    let lim = limit as u64;
    let intmask = emacs_intmask();
    let difflim = intmask - lim + 1;
    let _guard = emacs_random_lock().lock().expect("random lock poisoned");
    loop {
        let r = emacs_get_random_unlocked() as u64;
        let remainder = r % lim;
        let diff = r - remainder;
        if difflim >= diff {
            return remainder as i64;
        }
    }
}

#[cfg(unix)]
fn emacs_seed_random(seed: &[u8]) {
    let _guard = emacs_random_lock().lock().expect("random lock poisoned");
    let mut arg = [0u8; std::mem::size_of::<u32>()];
    for (index, byte) in seed.iter().enumerate() {
        arg[index % arg.len()] ^= *byte;
    }
    let seed = u32::from_ne_bytes(arg);
    unsafe {
        srandom(seed);
    }
}

#[cfg(unix)]
fn emacs_init_random() {
    let seed = (std::process::id() as u64)
        ^ (std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map(|d| d.as_secs() ^ u64::from(d.subsec_nanos()))
            .unwrap_or(0));
    let bytes = seed.to_ne_bytes();
    emacs_seed_random(&bytes);
}

#[cfg(not(unix))]
fn emacs_get_random() -> i64 {
    use std::cell::Cell;
    thread_local! {
        static STATE: Cell<u64> = const { Cell::new(0x12345678_9abcdef0) };
    }
    STATE.with(|s| {
        let mut x = s.get();
        x ^= x << 13;
        x ^= x >> 7;
        x ^= x << 17;
        s.set(x);
        (x as i64) & (i64::MAX >> 2)
    })
}

#[cfg(not(unix))]
fn emacs_get_random_fixnum(limit: i64) -> i64 {
    emacs_get_random().unsigned_abs() as i64 % limit
}

#[cfg(not(unix))]
fn emacs_seed_random(seed: &[u8]) {
    use std::cell::Cell;
    thread_local! {
        static STATE: Cell<u64> = const { Cell::new(0x12345678_9abcdef0) };
    }
    let mut arg = 0u64;
    for (index, byte) in seed.iter().enumerate() {
        arg ^= u64::from(*byte) << ((index % 8) * 8);
    }
    STATE.with(|state| state.set(arg));
}

#[cfg(not(unix))]
fn emacs_init_random() {
    let seed = (std::process::id() as u64)
        ^ (std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map(|d| d.as_secs() ^ u64::from(d.subsec_nanos()))
            .unwrap_or(0));
    emacs_seed_random(&seed.to_ne_bytes());
}

pub(crate) fn builtin_isnan(args: Vec<Value>) -> EvalResult {
    expect_args("isnan", &args, 1)?;
    match args[0].kind() {
        ValueKind::Float => Ok(Value::bool_val(args[0].xfloat().is_nan())),
        _ => Err(signal(
            "wrong-type-argument",
            vec![Value::symbol("floatp"), args[0]],
        )),
    }
}