neo-devpack-solidity 0.22.0

Production-focused Solidity-to-NeoVM compilation system
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136

fn compute_transitive_hazard_map(functions: &[Function]) -> HashMap<String, Hazards> {
    let mut direct = HashMap::new();
    for function in functions {
        direct.insert(function.name.clone(), direct_hazards(function));
    }

    let graph = build_call_graph(functions);
    let mut memo = HashMap::new();
    let mut visiting = HashSet::new();

    for name in direct.keys() {
        compute_transitive_hazards(name, &direct, &graph, &mut memo, &mut visiting);
    }

    memo
}

fn validate_safe_methods(
    metadata: &ContractMetadata,
    hazards: &HashMap<String, Hazards>,
) -> Vec<IrDiagnostic> {
    let mut errors = Vec::new();

    for method in &metadata.methods {
        if method.state_mutability != crate::solidity::StateMutability::View {
            continue;
        }

        let hazards = hazards
            .get(&method.neo_name)
            .copied()
            .unwrap_or_default();

        if !hazards.safe_violation() {
            continue;
        }

        if hazards.writes_state {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared view/pure but writes contract storage".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.notifies {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared view/pure but emits events/notifications".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.unsafe_contract_call {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared view/pure but performs non-readonly contract calls".to_string(),
                suggestion: None,
                code: None,
            });
        }
    }

    errors
}

fn validate_pure_methods(
    metadata: &ContractMetadata,
    hazards: &HashMap<String, Hazards>,
) -> Vec<IrDiagnostic> {
    let mut errors = Vec::new();

    for method in &metadata.methods {
        if method.state_mutability != crate::solidity::StateMutability::Pure {
            continue;
        }

        let hazards = hazards
            .get(&method.neo_name)
            .copied()
            .unwrap_or_default();

        if !hazards.pure_violation() {
            continue;
        }

        if hazards.writes_state {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared pure but writes contract storage".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.notifies {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared pure but emits events/notifications".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.reads_state {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared pure but reads contract storage".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.reads_environment {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared pure but reads the execution environment".to_string(),
                suggestion: None,
                code: None,
            });
        }

        if hazards.unsafe_contract_call {
            errors.push(IrDiagnostic {
                function_name: method.neo_name.clone(),
                message: "declared pure but performs non-readonly contract calls".to_string(),
                suggestion: None,
                code: None,
            });
        }
    }

    errors
}