ndatafusion 0.1.1

Extensions and support for linear algebra in DataFusion
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
use std::sync::Arc;

use datafusion::arrow::array::types::ArrowPrimitiveType;
use datafusion::arrow::array::{ArrayRef, FixedSizeListArray, PrimitiveArray, StructArray};
use datafusion::arrow::datatypes::{DataType, Field, FieldRef};
#[cfg(test)]
use datafusion::common::config::ConfigOptions;
use datafusion::common::{DataFusionError, Result, ScalarValue};
#[cfg(test)]
use datafusion::logical_expr::ScalarUDF;
use datafusion::logical_expr::{ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs};
use nabled::arrow::ArrowInteropError;
use ndarray::{Array2, ArrayD, ArrayView2, ArrayView3, ArrayViewD, Ix3, IxDyn};
use ndarrow::NdarrowElement;
use num_complex::Complex64;

use crate::error::{array_argument_required, exec_error, scalar_argument_required};

pub(crate) fn nullable_or(fields: &[FieldRef]) -> bool {
    fields.iter().any(|field| field.is_nullable())
}

pub(crate) fn expect_array_arg<'a>(
    args: &'a ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<&'a ArrayRef> {
    let index = position - 1;
    match &args.args[index] {
        ColumnarValue::Array(array) => Ok(array),
        ColumnarValue::Scalar(_) => Err(array_argument_required(function_name, position)),
    }
}

pub(crate) fn expect_fixed_size_list_arg<'a>(
    args: &'a ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<&'a FixedSizeListArray> {
    let array = expect_array_arg(args, position, function_name)?;
    array.as_any().downcast_ref::<FixedSizeListArray>().ok_or_else(|| {
        exec_error(
            function_name,
            format!(
                "argument {position} expected FixedSizeListArray storage, found {}",
                array.data_type()
            ),
        )
    })
}

pub(crate) fn expect_struct_arg<'a>(
    args: &'a ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<&'a StructArray> {
    let array = expect_array_arg(args, position, function_name)?;
    array.as_any().downcast_ref::<StructArray>().ok_or_else(|| {
        exec_error(
            function_name,
            format!(
                "argument {position} expected StructArray storage, found {}",
                array.data_type()
            ),
        )
    })
}

pub(crate) fn expect_bool_scalar_arg(
    args: &ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<bool> {
    let index = position - 1;
    match &args.args[index] {
        ColumnarValue::Scalar(ScalarValue::Boolean(Some(value))) => Ok(*value),
        ColumnarValue::Scalar(ScalarValue::Boolean(None) | ScalarValue::Null) => {
            Err(scalar_argument_required(function_name, position))
        }
        ColumnarValue::Scalar(value) => Err(exec_error(
            function_name,
            format!("argument {position} expected Boolean scalar, found {value:?}"),
        )),
        ColumnarValue::Array(_) => {
            Err(exec_error(function_name, format!("argument {position} must be a scalar Boolean")))
        }
    }
}

fn scalar_usize(value: &ScalarValue, function_name: &str, position: usize) -> Result<usize> {
    match value {
        ScalarValue::Int64(Some(value)) => usize::try_from(*value).map_err(|_| {
            exec_error(
                function_name,
                format!("argument {position} must be a non-negative integer, found {value}"),
            )
        }),
        ScalarValue::Int32(Some(value)) => usize::try_from(*value).map_err(|_| {
            exec_error(
                function_name,
                format!("argument {position} must be a non-negative integer, found {value}"),
            )
        }),
        ScalarValue::UInt64(Some(value)) => usize::try_from(*value).map_err(|_| {
            exec_error(
                function_name,
                format!("argument {position} exceeds usize limits, found {value}"),
            )
        }),
        ScalarValue::UInt32(Some(value)) => usize::try_from(*value).map_err(|_| {
            exec_error(
                function_name,
                format!("argument {position} exceeds usize limits, found {value}"),
            )
        }),
        ScalarValue::Int64(None)
        | ScalarValue::Int32(None)
        | ScalarValue::UInt64(None)
        | ScalarValue::UInt32(None)
        | ScalarValue::Null => Err(scalar_argument_required(function_name, position)),
        value => Err(exec_error(
            function_name,
            format!("argument {position} must be an integer scalar, found {value:?}"),
        )),
    }
}

fn scalar_usize_list(
    value: &ScalarValue,
    function_name: &str,
    position: usize,
) -> Result<Vec<usize>> {
    let list_values: ArrayRef = match value {
        ScalarValue::List(array) => array.value(0),
        ScalarValue::LargeList(array) => array.value(0),
        ScalarValue::Null => return Err(scalar_argument_required(function_name, position)),
        value => {
            return Err(exec_error(
                function_name,
                format!("argument {position} must be a list of integer scalars, found {value:?}"),
            ));
        }
    };
    macro_rules! parse_primitive_list {
        ($array_type:ty) => {{
            let values = list_values.as_any().downcast_ref::<$array_type>().ok_or_else(|| {
                exec_error(
                    function_name,
                    format!("argument {position} must be a list of integer scalars"),
                )
            })?;
            values
                .iter()
                .map(|value| match value {
                    Some(value) => usize::try_from(value).map_err(|_| {
                        exec_error(
                            function_name,
                            format!(
                                "argument {position} must contain non-negative integer values, \
                                 found {value}"
                            ),
                        )
                    }),
                    None => Err(scalar_argument_required(function_name, position)),
                })
                .collect()
        }};
    }
    match list_values.data_type() {
        DataType::Int8 => parse_primitive_list!(datafusion::arrow::array::Int8Array),
        DataType::Int16 => parse_primitive_list!(datafusion::arrow::array::Int16Array),
        DataType::Int32 => parse_primitive_list!(datafusion::arrow::array::Int32Array),
        DataType::Int64 => parse_primitive_list!(datafusion::arrow::array::Int64Array),
        DataType::UInt8 => parse_primitive_list!(datafusion::arrow::array::UInt8Array),
        DataType::UInt16 => parse_primitive_list!(datafusion::arrow::array::UInt16Array),
        DataType::UInt32 => parse_primitive_list!(datafusion::arrow::array::UInt32Array),
        DataType::UInt64 => parse_primitive_list!(datafusion::arrow::array::UInt64Array),
        actual => Err(exec_error(
            function_name,
            format!("argument {position} must be a list of integer scalars, found list<{actual}>"),
        )),
    }
}

pub(crate) fn expect_usize_scalar_arg(
    args: &ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<usize> {
    match &args.args[position - 1] {
        ColumnarValue::Scalar(value) => scalar_usize(value, function_name, position),
        ColumnarValue::Array(_) => {
            Err(exec_error(function_name, format!("argument {position} must be an integer scalar")))
        }
    }
}

pub(crate) fn expect_usize_list_scalar_arg(
    args: &ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<Vec<usize>> {
    match &args.args[position - 1] {
        ColumnarValue::Scalar(value) => scalar_usize_list(value, function_name, position),
        ColumnarValue::Array(_) => Err(exec_error(
            function_name,
            format!("argument {position} must be a list of integer scalars"),
        )),
    }
}

pub(crate) fn expect_usize_scalar_argument(
    args: &ReturnFieldArgs<'_>,
    position: usize,
    function_name: &str,
) -> Result<usize> {
    match args.scalar_arguments.get(position - 1).copied().flatten() {
        Some(value) => scalar_usize(value, function_name, position),
        None => Err(scalar_argument_required(function_name, position)),
    }
}

pub(crate) fn expect_usize_list_scalar_argument(
    args: &ReturnFieldArgs<'_>,
    position: usize,
    function_name: &str,
) -> Result<Vec<usize>> {
    match args.scalar_arguments.get(position - 1).copied().flatten() {
        Some(value) => scalar_usize_list(value, function_name, position),
        None => Err(scalar_argument_required(function_name, position)),
    }
}

fn scalar_real(value: &ScalarValue, function_name: &str, position: usize) -> Result<f64> {
    match value {
        ScalarValue::Float64(Some(value)) => Ok(*value),
        ScalarValue::Float32(Some(value)) => Ok(f64::from(*value)),
        ScalarValue::Int64(Some(value)) => value.to_string().parse::<f64>().map_err(|error| {
            exec_error(
                function_name,
                format!("argument {position} could not be represented as f64: {error}"),
            )
        }),
        ScalarValue::Int32(Some(value)) => Ok(f64::from(*value)),
        ScalarValue::UInt64(Some(value)) => value.to_string().parse::<f64>().map_err(|error| {
            exec_error(
                function_name,
                format!("argument {position} could not be represented as f64: {error}"),
            )
        }),
        ScalarValue::UInt32(Some(value)) => Ok(f64::from(*value)),
        ScalarValue::Float64(None)
        | ScalarValue::Float32(None)
        | ScalarValue::Int64(None)
        | ScalarValue::Int32(None)
        | ScalarValue::UInt64(None)
        | ScalarValue::UInt32(None)
        | ScalarValue::Null => Err(scalar_argument_required(function_name, position)),
        value => Err(exec_error(
            function_name,
            format!("argument {position} must be a numeric scalar, found {value:?}"),
        )),
    }
}

pub(crate) fn expect_real_scalar_arg(
    args: &ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<f64> {
    match &args.args[position - 1] {
        ColumnarValue::Scalar(value) => scalar_real(value, function_name, position),
        ColumnarValue::Array(_) => {
            Err(exec_error(function_name, format!("argument {position} must be a numeric scalar")))
        }
    }
}

pub(crate) fn expect_real_scalar_argument(
    args: &ReturnFieldArgs<'_>,
    position: usize,
    function_name: &str,
) -> Result<f64> {
    match args.scalar_arguments.get(position - 1).copied().flatten() {
        Some(value) => scalar_real(value, function_name, position),
        None => Err(scalar_argument_required(function_name, position)),
    }
}

pub(crate) fn expect_bool_scalar_argument(
    args: &ReturnFieldArgs<'_>,
    position: usize,
    function_name: &str,
) -> Result<bool> {
    let index = position - 1;
    match args.scalar_arguments.get(index).copied().flatten() {
        Some(ScalarValue::Boolean(Some(value))) => Ok(*value),
        Some(ScalarValue::Boolean(None) | ScalarValue::Null) | None => {
            Err(scalar_argument_required(function_name, position))
        }
        Some(value) => Err(exec_error(
            function_name,
            format!("argument {position} expected Boolean scalar, found {value:?}"),
        )),
    }
}

fn scalar_string(value: &ScalarValue, function_name: &str, position: usize) -> Result<String> {
    match value {
        ScalarValue::Utf8(Some(value)) | ScalarValue::LargeUtf8(Some(value)) => Ok(value.clone()),
        ScalarValue::Utf8(None) | ScalarValue::LargeUtf8(None) | ScalarValue::Null => {
            Err(scalar_argument_required(function_name, position))
        }
        value => Err(exec_error(
            function_name,
            format!("argument {position} must be a string scalar, found {value:?}"),
        )),
    }
}

pub(crate) fn expect_string_scalar_arg(
    args: &ScalarFunctionArgs,
    position: usize,
    function_name: &str,
) -> Result<String> {
    match &args.args[position - 1] {
        ColumnarValue::Scalar(value) => scalar_string(value, function_name, position),
        ColumnarValue::Array(_) => {
            Err(exec_error(function_name, format!("argument {position} must be a string scalar")))
        }
    }
}

pub(crate) fn expect_string_scalar_argument(
    args: &ReturnFieldArgs<'_>,
    position: usize,
    function_name: &str,
) -> Result<String> {
    match args.scalar_arguments.get(position - 1).copied().flatten() {
        Some(value) => scalar_string(value, function_name, position),
        None => Err(scalar_argument_required(function_name, position)),
    }
}

pub(crate) fn fixed_size_list_view2<'a, T>(
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayView2<'a, T::Native>>
where
    T: ArrowPrimitiveType,
    T::Native: NdarrowElement,
{
    ndarrow::fixed_size_list_as_array2::<T>(array).map_err(|error| exec_error(function_name, error))
}

pub(crate) fn fixed_shape_tensor_viewd<'a, T>(
    field: &'a FieldRef,
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayViewD<'a, T::Native>>
where
    T: ArrowPrimitiveType,
    T::Native: NdarrowElement,
{
    ndarrow::fixed_shape_tensor_as_array_viewd::<T>(field.as_ref(), array)
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn fixed_shape_tensor_view3<'a, T>(
    field: &'a FieldRef,
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayView3<'a, T::Native>>
where
    T: ArrowPrimitiveType,
    T::Native: NdarrowElement,
{
    fixed_shape_tensor_viewd::<T>(field, array, function_name)?
        .into_dimensionality::<Ix3>()
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn complex_fixed_shape_tensor_viewd<'a>(
    field: &'a FieldRef,
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayViewD<'a, Complex64>> {
    ndarrow::complex64_fixed_shape_tensor_as_array_viewd(field.as_ref(), array)
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn complex_fixed_shape_tensor_view3<'a>(
    field: &'a FieldRef,
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayView3<'a, Complex64>> {
    complex_fixed_shape_tensor_viewd(field, array, function_name)?
        .into_dimensionality::<Ix3>()
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn complex_fixed_size_list_view2<'a>(
    array: &'a FixedSizeListArray,
    function_name: &str,
) -> Result<ArrayView2<'a, Complex64>> {
    ndarrow::complex64_as_array_view2(array).map_err(|error| exec_error(function_name, error))
}

pub(crate) fn complex_fixed_size_list_array_from_flat_rows(
    function_name: &str,
    row_count: usize,
    row_width: usize,
    values: Vec<Complex64>,
) -> Result<FixedSizeListArray> {
    let expected_len = row_count
        .checked_mul(row_width)
        .ok_or_else(|| exec_error(function_name, "row count overflow"))?;
    if values.len() != expected_len {
        return Err(exec_error(
            function_name,
            format!(
                "expected {expected_len} complex values for ({row_count}, {row_width}) rows, \
                 found {}",
                values.len()
            ),
        ));
    }
    let output = Array2::from_shape_vec((row_count, row_width), values)
        .map_err(|error| exec_error(function_name, error))?;
    ndarrow::array2_complex64_to_fixed_size_list(output)
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn complex_fixed_shape_tensor_array_from_flat_rows(
    function_name: &str,
    batch: usize,
    shape: &[usize],
    values: Vec<Complex64>,
) -> Result<(Field, FixedSizeListArray)> {
    let mut full_shape = Vec::with_capacity(shape.len() + 1);
    full_shape.push(batch);
    full_shape.extend_from_slice(shape);
    let output = ArrayD::from_shape_vec(IxDyn(&full_shape), values)
        .map_err(|error| exec_error(function_name, error))?;
    ndarrow::arrayd_complex64_to_fixed_shape_tensor(function_name, output)
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn fixed_shape_tensor_array_from_flat_rows<T>(
    function_name: &str,
    batch: usize,
    shape: &[usize],
    values: Vec<T::Native>,
) -> Result<(Field, FixedSizeListArray)>
where
    T: ArrowPrimitiveType,
    T::Native: NdarrowElement,
{
    let mut full_shape = Vec::with_capacity(shape.len() + 1);
    full_shape.push(batch);
    full_shape.extend_from_slice(shape);
    let output = ArrayD::from_shape_vec(IxDyn(&full_shape), values)
        .map_err(|error| exec_error(function_name, error))?;
    ndarrow::arrayd_to_fixed_shape_tensor(function_name, output)
        .map_err(|error| exec_error(function_name, error))
}

pub(crate) fn primitive_array_from_values<T>(values: Vec<T::Native>) -> PrimitiveArray<T>
where
    T: ArrowPrimitiveType,
{
    PrimitiveArray::<T>::from_iter_values(values)
}

pub(crate) fn fixed_size_list_array_from_flat_rows<T>(
    function_name: &str,
    row_count: usize,
    row_width: usize,
    values: &[T::Native],
) -> Result<FixedSizeListArray>
where
    T: ArrowPrimitiveType,
    T::Native: Copy,
{
    let expected_len = row_count
        .checked_mul(row_width)
        .ok_or_else(|| exec_error(function_name, "row count overflow"))?;
    if values.len() != expected_len {
        return Err(exec_error(
            function_name,
            format!(
                "expected {expected_len} values for ({row_count}, {row_width}) rows, found {}",
                values.len()
            ),
        ));
    }
    let row_width = i32::try_from(row_width)
        .map_err(|_| exec_error(function_name, "row width exceeds Arrow i32 limits"))?;
    let values = PrimitiveArray::<T>::from_iter_values(values.iter().copied());
    Ok(FixedSizeListArray::new(
        Arc::new(Field::new("item", T::DATA_TYPE, false)),
        row_width,
        Arc::new(values),
        None,
    ))
}

pub(crate) fn map_arrow_error(function_name: &str, error: ArrowInteropError) -> DataFusionError {
    exec_error(function_name, error)
}

#[cfg(test)]
pub(crate) fn invoke_udf(
    udf: &Arc<ScalarUDF>,
    args: Vec<ColumnarValue>,
    arg_fields: Vec<FieldRef>,
    scalar_arguments: &[Option<ScalarValue>],
    number_rows: usize,
) -> Result<(FieldRef, ColumnarValue)> {
    let scalar_refs =
        scalar_arguments.iter().map(Option::as_ref).collect::<Vec<Option<&ScalarValue>>>();
    let return_field = udf.return_field_from_args(ReturnFieldArgs {
        arg_fields:       &arg_fields,
        scalar_arguments: &scalar_refs,
    })?;
    let output = udf.invoke_with_args(ScalarFunctionArgs {
        args,
        arg_fields,
        number_rows,
        return_field: Arc::clone(&return_field),
        config_options: Arc::new(ConfigOptions::new()),
    })?;
    Ok((return_field, output))
}

#[cfg(test)]
mod tests {
    use datafusion::arrow::array::types::{Float32Type, Int32Type, UInt64Type};
    use datafusion::arrow::array::{
        FixedSizeListArray, Float32Array, Int64Array, LargeListArray, ListArray,
    };
    use datafusion::arrow::datatypes::{DataType, Field};
    use ndarray::Array2;
    use num_complex::Complex64;

    use super::*;

    fn dummy_field(name: &str) -> FieldRef { Arc::new(Field::new(name, DataType::Float32, false)) }

    #[test]
    fn expect_array_and_storage_helpers_validate_inputs() {
        let fixed = FixedSizeListArray::from_iter_primitive::<Float32Type, _, _>(
            vec![Some(vec![Some(1.0_f32), Some(2.0)])],
            2,
        );
        let array = Float32Array::from(vec![1.0_f32, 2.0]);
        let args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(fixed.clone()))],
            arg_fields:     vec![dummy_field("vector")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        assert!(expect_array_arg(&args, 1, "vector_l2_norm").is_ok());
        assert!(expect_fixed_size_list_arg(&args, 1, "vector_l2_norm").is_ok());

        let scalar_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::Float32(Some(1.0)))],
            arg_fields:     vec![dummy_field("vector")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let scalar_error =
            expect_array_arg(&scalar_args, 1, "vector_l2_norm").expect_err("scalar should fail");
        assert!(scalar_error.to_string().contains("argument 1 must be an array column"));

        let wrong_storage_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(array))],
            arg_fields:     vec![dummy_field("vector")],
            number_rows:    2,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let fixed_error = expect_fixed_size_list_arg(&wrong_storage_args, 1, "vector_l2_norm")
            .expect_err("plain array should fail");
        assert!(fixed_error.to_string().contains("expected FixedSizeListArray storage"));

        let struct_error =
            expect_struct_arg(&args, 1, "sparse_matvec").expect_err("fixed-size list should fail");
        assert!(struct_error.to_string().contains("expected StructArray storage"));
    }

    #[test]
    fn bool_scalar_helpers_validate_null_type_and_array_cases() {
        let bool_value = ScalarValue::Boolean(Some(true));
        let wrong_value = ScalarValue::Int64(Some(1));
        let arg_fields = vec![dummy_field("flag")];
        let scalar_refs = vec![Some(&bool_value)];
        let return_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &scalar_refs };
        assert!(
            expect_bool_scalar_argument(&return_args, 1, "linear_regression")
                .expect("boolean scalar")
        );

        let null_refs = vec![Some(&ScalarValue::Null)];
        let null_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &null_refs };
        let null_error = expect_bool_scalar_argument(&null_args, 1, "linear_regression")
            .expect_err("null boolean should fail");
        assert!(null_error.to_string().contains("argument 1 must be a non-null scalar"));

        let wrong_refs = vec![Some(&wrong_value)];
        let wrong_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &wrong_refs };
        let wrong_error = expect_bool_scalar_argument(&wrong_args, 1, "linear_regression")
            .expect_err("int scalar should fail");
        assert!(wrong_error.to_string().contains("expected Boolean scalar"));

        let exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::Boolean(Some(false)))],
            arg_fields:     vec![dummy_field("flag")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        assert!(
            !expect_bool_scalar_arg(&exec_args, 1, "linear_regression").expect("boolean scalar")
        );

        let wrong_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::Int64(Some(1)))],
            arg_fields:     vec![dummy_field("flag")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let wrong_exec_error = expect_bool_scalar_arg(&wrong_exec_args, 1, "linear_regression")
            .expect_err("int scalar should fail");
        assert!(wrong_exec_error.to_string().contains("expected Boolean scalar"));

        let array_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(Int64Array::from(vec![1_i64])))],
            arg_fields:     vec![dummy_field("flag")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let array_error = expect_bool_scalar_arg(&array_exec_args, 1, "linear_regression")
            .expect_err("array should fail");
        assert!(array_error.to_string().contains("must be a scalar Boolean"));
    }

    #[test]
    fn integer_scalar_helpers_validate_type_range_and_array_cases() {
        let value = ScalarValue::Int64(Some(3));
        let arg_fields = vec![dummy_field("count")];
        let scalar_refs = vec![Some(&value)];
        let return_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &scalar_refs };
        assert_eq!(
            expect_usize_scalar_argument(&return_args, 1, "matrix_exp").expect("integer scalar"),
            3
        );

        let negative_refs = vec![Some(&ScalarValue::Int64(Some(-1)))];
        let negative_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &negative_refs };
        let negative_error = expect_usize_scalar_argument(&negative_args, 1, "matrix_exp")
            .expect_err("negative integer should fail");
        assert!(negative_error.to_string().contains("must be a non-negative integer"));

        let wrong_refs = vec![Some(&ScalarValue::Float64(Some(1.0)))];
        let wrong_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &wrong_refs };
        let wrong_error = expect_usize_scalar_argument(&wrong_args, 1, "matrix_exp")
            .expect_err("float should fail");
        assert!(wrong_error.to_string().contains("must be an integer scalar"));

        let exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::UInt32(Some(4)))],
            arg_fields:     vec![dummy_field("count")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        assert_eq!(expect_usize_scalar_arg(&exec_args, 1, "matrix_exp").expect("u32 scalar"), 4);

        let array_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(Int64Array::from(vec![1_i64])))],
            arg_fields:     vec![dummy_field("count")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let array_error = expect_usize_scalar_arg(&array_exec_args, 1, "matrix_exp")
            .expect_err("array should fail");
        assert!(array_error.to_string().contains("must be an integer scalar"));
    }

    #[test]
    fn real_scalar_helpers_validate_type_null_and_array_cases() {
        let value = ScalarValue::Float32(Some(1.5));
        let arg_fields = vec![dummy_field("power")];
        let scalar_refs = vec![Some(&value)];
        let return_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &scalar_refs };
        let parsed =
            expect_real_scalar_argument(&return_args, 1, "matrix_power").expect("float scalar");
        assert!((parsed - 1.5_f64).abs() < f64::EPSILON);

        let int_value = ScalarValue::Int64(Some(2));
        let int_refs = vec![Some(&int_value)];
        let int_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &int_refs };
        let parsed_int =
            expect_real_scalar_argument(&int_args, 1, "matrix_power").expect("int scalar");
        assert!((parsed_int - 2.0_f64).abs() < f64::EPSILON);

        let wrong_refs = vec![Some(&ScalarValue::Boolean(Some(true)))];
        let wrong_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &wrong_refs };
        let wrong_error = expect_real_scalar_argument(&wrong_args, 1, "matrix_power")
            .expect_err("bool should fail");
        assert!(wrong_error.to_string().contains("must be a numeric scalar"));

        let exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::Float64(Some(0.5)))],
            arg_fields:     vec![dummy_field("power")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let parsed_exec =
            expect_real_scalar_arg(&exec_args, 1, "matrix_power").expect("float64 scalar");
        assert!((parsed_exec - 0.5_f64).abs() < f64::EPSILON);

        let array_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(Float32Array::from(vec![1.0_f32])))],
            arg_fields:     vec![dummy_field("power")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let array_error = expect_real_scalar_arg(&array_exec_args, 1, "matrix_power")
            .expect_err("array should fail");
        assert!(array_error.to_string().contains("must be a numeric scalar"));
    }

    #[test]
    fn tensor_view_and_flat_row_helpers_validate_shapes() {
        let batch =
            Array2::from_shape_vec((1, 4), vec![1.0_f32, 2.0, 3.0, 4.0]).expect("rank-2 batch");
        let (field, tensor) =
            ndarrow::arrayd_to_fixed_shape_tensor("tensor", batch.into_dyn()).expect("tensor");
        let field = Arc::new(field);

        let rank_error = fixed_shape_tensor_view3::<Float32Type>(&field, &tensor, "tensor")
            .expect_err("rank-2 tensor batch should fail view3 conversion");
        assert!(rank_error.to_string().contains("tensor"));

        let mismatch =
            fixed_size_list_array_from_flat_rows::<Float32Type>("vector_normalize", 2, 2, &[
                1.0_f32, 2.0, 3.0,
            ])
            .expect_err("row mismatch should fail");
        assert!(mismatch.to_string().contains("expected 4 values"));

        let fixed =
            fixed_size_list_array_from_flat_rows::<Float32Type>("vector_normalize", 2, 2, &[
                1.0_f32, 2.0, 3.0, 4.0,
            ])
            .expect("fixed-size list");
        assert_eq!(fixed.value_length(), 2);
        assert_eq!(fixed.values().data_type(), &DataType::Float32);
    }

    #[test]
    fn usize_list_helpers_cover_scalar_and_error_paths() {
        let list_scalar =
            ScalarValue::List(Arc::new(ListArray::from_iter_primitive::<Int32Type, _, _>(vec![
                Some(vec![Some(0_i32), Some(2_i32), Some(4_i32)]),
            ])));
        let arg_fields = vec![dummy_field("axes")];
        let scalar_refs = vec![Some(&list_scalar)];
        let return_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &scalar_refs };
        assert_eq!(
            expect_usize_list_scalar_argument(&return_args, 1, "tensor_permute_axes")
                .expect("usize list argument"),
            vec![0, 2, 4]
        );

        let exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(list_scalar.clone())],
            arg_fields:     vec![dummy_field("axes")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        assert_eq!(
            expect_usize_list_scalar_arg(&exec_args, 1, "tensor_permute_axes")
                .expect("usize list arg"),
            vec![0, 2, 4]
        );

        let large_list_scalar = ScalarValue::LargeList(Arc::new(
            LargeListArray::from_iter_primitive::<Int32Type, _, _>(vec![Some(vec![
                Some(5_i32),
                Some(6_i32),
            ])]),
        ));
        let large_refs = vec![Some(&large_list_scalar)];
        let large_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &large_refs };
        assert_eq!(
            expect_usize_list_scalar_argument(&large_args, 1, "tensor_permute_axes")
                .expect("large usize list"),
            vec![5, 6]
        );

        let unsigned_list_scalar =
            ScalarValue::List(Arc::new(ListArray::from_iter_primitive::<UInt64Type, _, _>(vec![
                Some(vec![Some(1_u64), Some(3_u64)]),
            ])));
        let unsigned_refs = vec![Some(&unsigned_list_scalar)];
        let unsigned_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &unsigned_refs };
        assert_eq!(
            expect_usize_list_scalar_argument(&unsigned_args, 1, "tensor_contract_axes")
                .expect("u64 list argument"),
            vec![1, 3]
        );

        let wrong_list_scalar =
            ScalarValue::List(Arc::new(ListArray::from_iter_primitive::<Float32Type, _, _>(vec![
                Some(vec![Some(1.0_f32), Some(2.0_f32)]),
            ])));
        let wrong_refs = vec![Some(&wrong_list_scalar)];
        let wrong_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &wrong_refs };
        let wrong_list_error =
            expect_usize_list_scalar_argument(&wrong_args, 1, "tensor_permute_axes")
                .expect_err("float list should fail");
        assert!(wrong_list_error.to_string().contains("list of integer scalars"));

        let null_refs = vec![Some(&ScalarValue::Null)];
        let null_args =
            ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &null_refs };
        let null_list_error =
            expect_usize_list_scalar_argument(&null_args, 1, "tensor_permute_axes")
                .expect_err("null list should fail");
        assert!(null_list_error.to_string().contains("must be a non-null scalar"));

        let missing_args = ReturnFieldArgs { arg_fields: &arg_fields, scalar_arguments: &[] };
        let missing_error =
            expect_usize_list_scalar_argument(&missing_args, 1, "tensor_permute_axes")
                .expect_err("missing list should fail");
        assert!(missing_error.to_string().contains("must be a non-null scalar"));

        let array_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(Int64Array::from(vec![1_i64])))],
            arg_fields:     vec![dummy_field("axes")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let array_error = expect_usize_list_scalar_arg(&array_exec_args, 1, "tensor_permute_axes")
            .expect_err("array list arg should fail");
        assert!(array_error.to_string().contains("must be a list of integer scalars"));
    }

    #[test]
    fn string_scalar_helpers_cover_scalar_and_error_paths() {
        let string_value = ScalarValue::Utf8(Some("softmax".to_owned()));
        let string_fields = vec![dummy_field("name")];
        let string_refs = vec![Some(&string_value)];
        let string_return_args =
            ReturnFieldArgs { arg_fields: &string_fields, scalar_arguments: &string_refs };
        assert_eq!(
            expect_string_scalar_argument(&string_return_args, 1, "jacobian")
                .expect("string scalar argument"),
            "softmax"
        );

        let string_exec_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::LargeUtf8(Some(
                "sigmoid".to_owned(),
            )))],
            arg_fields:     vec![dummy_field("name")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        assert_eq!(
            expect_string_scalar_arg(&string_exec_args, 1, "gradient")
                .expect("string scalar exec arg"),
            "sigmoid"
        );

        let wrong_string_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Scalar(ScalarValue::Boolean(Some(true)))],
            arg_fields:     vec![dummy_field("name")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let wrong_string_error = expect_string_scalar_arg(&wrong_string_args, 1, "jacobian")
            .expect_err("boolean should fail string parsing");
        assert!(wrong_string_error.to_string().contains("must be a string scalar"));

        let null_refs = vec![Some(&ScalarValue::Null)];
        let null_args =
            ReturnFieldArgs { arg_fields: &string_fields, scalar_arguments: &null_refs };
        let null_error = expect_string_scalar_argument(&null_args, 1, "jacobian")
            .expect_err("null string should fail");
        assert!(null_error.to_string().contains("must be a non-null scalar"));

        let array_string_args = ScalarFunctionArgs {
            args:           vec![ColumnarValue::Array(Arc::new(Float32Array::from(vec![1.0_f32])))],
            arg_fields:     vec![dummy_field("name")],
            number_rows:    1,
            return_field:   dummy_field("return"),
            config_options: Arc::new(ConfigOptions::new()),
        };
        let array_error = expect_string_scalar_arg(&array_string_args, 1, "jacobian")
            .expect_err("array string should fail");
        assert!(array_error.to_string().contains("must be a string scalar"));
    }

    #[test]
    fn complex_storage_helpers_cover_flat_rows_and_tensor_views() {
        let wrong_complex =
            complex_fixed_size_list_array_from_flat_rows("vector_dot_hermitian", 2, 2, vec![
                Complex64::new(1.0, 0.0),
            ])
            .expect_err("wrong complex row width should fail");
        assert!(wrong_complex.to_string().contains("expected 4 complex values"));

        let complex_vectors =
            complex_fixed_size_list_array_from_flat_rows("vector_dot_hermitian", 2, 2, vec![
                Complex64::new(1.0, 0.0),
                Complex64::new(0.0, 1.0),
                Complex64::new(2.0, -1.0),
                Complex64::new(-3.0, 0.5),
            ])
            .expect("complex vector rows");
        let complex_view = complex_fixed_size_list_view2(&complex_vectors, "vector_dot_hermitian")
            .expect("complex view");
        assert_eq!(complex_view.shape(), &[2, 2]);

        let (complex_tensor_field, complex_tensor) =
            complex_fixed_shape_tensor_array_from_flat_rows(
                "tensor_normalize_last_axis_complex",
                1,
                &[2, 2],
                vec![
                    Complex64::new(1.0, 0.0),
                    Complex64::new(0.0, 1.0),
                    Complex64::new(2.0, -1.0),
                    Complex64::new(-3.0, 0.5),
                ],
            )
            .expect("complex tensor");
        let complex_tensor_field = Arc::new(complex_tensor_field);
        let complex_tensor_view = complex_fixed_shape_tensor_view3(
            &complex_tensor_field,
            &complex_tensor,
            "tensor_normalize_last_axis_complex",
        )
        .expect("complex tensor view");
        assert_eq!(complex_tensor_view.shape(), &[1, 2, 2]);
    }
}