1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
//! Matching engine: the core algorithm for executing trades.
//!
//! The matching engine implements price-time priority:
//! 1. Better prices match first (higher bids, lower asks)
//! 2. At the same price, earlier orders match first (FIFO)
//! 3. Trades execute at the resting order's price (price improvement for aggressor)
use crate::{Order, OrderBook, Price, Quantity, Side, Trade};
/// Self-trade prevention (STP) policy applied when the incoming and
/// resting orders share the same [`OrderOwner`](crate::order::OrderOwner).
///
/// STP is only consulted when BOTH sides set a non-`None` owner AND the
/// owners compare equal. If either side is `None`, matching proceeds
/// normally regardless of policy.
///
/// References: CME Rule 536 (self-match prevention); NASDAQ OUCH 4.x STP spec.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Default)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub enum StpPolicy {
/// No self-trade prevention: same-owner orders cross like any other.
/// This is the default to preserve pre-STP behaviour.
#[default]
Off,
/// Cancel the incoming order's remainder; leave resting intact.
CancelNewest,
/// Cancel the resting order; incoming order re-attempts the match
/// against the next available counter-order.
CancelOldest,
/// Cancel whichever order has the smaller remaining quantity and
/// leave the larger order untouched. No trade is generated. If both
/// have equal remaining, the resting order is cancelled and the
/// incoming order continues matching against the next resting order.
DecrementAndCancel,
}
/// Result of matching an incoming order against the book.
#[derive(Clone, Debug, Default)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct MatchResult {
/// Trades that occurred during matching
pub trades: Vec<Trade>,
/// Quantity that could not be filled
pub remaining_quantity: Quantity,
/// True if self-trade prevention cancelled (part of) the incoming
/// order. When true, callers must treat any remainder as cancelled
/// regardless of TIF: a GTC remainder must NOT rest on the book.
pub stp_cancelled: bool,
}
impl MatchResult {
/// Returns the total quantity filled.
pub fn filled_quantity(&self) -> Quantity {
self.trades.iter().map(|t| t.quantity).sum()
}
/// Returns true if the order was fully filled.
pub fn is_fully_filled(&self) -> bool {
self.remaining_quantity == 0
}
/// Returns true if no trades occurred.
pub fn is_empty(&self) -> bool {
self.trades.is_empty()
}
}
impl OrderBook {
/// Check if an incoming order's price crosses with a resting price.
///
/// - Buy crosses if buy_price >= ask_price
/// - Sell crosses if sell_price <= bid_price
#[inline]
fn prices_cross(incoming_side: Side, incoming_price: Price, resting_price: Price) -> bool {
match incoming_side {
Side::Buy => incoming_price >= resting_price,
Side::Sell => incoming_price <= resting_price,
}
}
/// Match an incoming order against the book.
///
/// Equivalent to [`Self::match_order_with_policy`] with
/// [`StpPolicy::Off`]; same-owner orders will cross.
///
/// This is the core matching algorithm:
/// 1. Find the best price on the opposite side
/// 2. If prices cross, fill against resting orders (FIFO)
/// 3. Continue until no more crosses or order is filled
/// 4. Return trades and remaining quantity
///
/// **Important**: This method modifies both the incoming order and
/// resting orders in the book. The incoming order is NOT added to
/// the book — the caller decides whether to add it based on TIF.
pub fn match_order(&mut self, incoming: &mut Order) -> MatchResult {
self.match_order_with_policy(incoming, StpPolicy::Off)
}
/// Match an incoming order against the book under a self-trade
/// prevention policy. See [`StpPolicy`] for the per-policy semantics
/// and [`Self::match_order`] for the core algorithm.
pub fn match_order_with_policy(
&mut self,
incoming: &mut Order,
policy: StpPolicy,
) -> MatchResult {
let mut result = MatchResult {
trades: Vec::new(),
remaining_quantity: incoming.remaining_quantity,
stp_cancelled: false,
};
// Match until no more crosses or order is filled
while incoming.remaining_quantity > 0 {
// Get the best price on the opposite side
let opposite = self.opposite_side(incoming.side);
let best_price = match opposite.best_price() {
Some(p) => p,
None => break, // No liquidity
};
// Check if prices cross
if !Self::prices_cross(incoming.side, incoming.price, best_price) {
break; // No match at this price
}
// Match against orders at the best price level
self.match_at_price(incoming, best_price, policy, &mut result);
// If STP cancelled the incoming order, stop matching entirely.
if result.stp_cancelled {
break;
}
}
result.remaining_quantity = incoming.remaining_quantity;
result
}
/// Match an incoming order against all orders at a specific price level.
fn match_at_price(
&mut self,
incoming: &mut Order,
price: Price,
policy: StpPolicy,
result: &mut MatchResult,
) {
// Process orders at this price level until exhausted or incoming filled
while incoming.remaining_quantity > 0 {
// Get the front order at this price (skips tombstones)
let opposite = self.opposite_side_mut(incoming.side);
let resting_id = match opposite.get_level_mut(price).and_then(|l| l.front()) {
Some(id) => id,
_ => break, // Level exhausted or only tombstones left
};
// Get the resting order's remaining quantity and owner
let (resting_remaining, resting_owner) = match self.get_order(resting_id) {
Some(o) => (o.remaining_quantity, o.owner),
None => {
// Orphaned order ID in level — shouldn't happen, but handle gracefully
self.opposite_side_mut(incoming.side)
.get_level_mut(price)
.map(|l| l.pop_front(0));
continue;
}
};
// Self-trade prevention: only kicks in when both sides set a
// non-None owner AND they compare equal AND policy != Off.
let stp_conflict = matches!(
(incoming.owner, resting_owner),
(Some(i), Some(r)) if i == r && policy != StpPolicy::Off
);
if stp_conflict {
match policy {
StpPolicy::Off => unreachable!(),
StpPolicy::CancelNewest => {
// Cancel incoming remainder; leave resting intact.
incoming.stp_decrement(incoming.remaining_quantity);
result.stp_cancelled = true;
return;
}
StpPolicy::CancelOldest => {
// Cancel resting; incoming continues matching.
self.cancel_order(resting_id);
continue;
}
StpPolicy::DecrementAndCancel => {
if incoming.remaining_quantity < resting_remaining {
// Smaller = incoming: cancel incoming, leave resting.
incoming.stp_decrement(incoming.remaining_quantity);
result.stp_cancelled = true;
return;
} else {
// Smaller (or equal) = resting: cancel resting, continue.
self.cancel_order(resting_id);
continue;
}
}
}
}
// Calculate fill quantity
let fill_qty = incoming.remaining_quantity.min(resting_remaining);
// Create the trade
let trade = Trade::new(
self.next_trade_id(),
price, // Trade at resting order's price
fill_qty,
incoming.id,
resting_id,
incoming.side,
self.next_timestamp(),
);
result.trades.push(trade);
// Update the incoming order
incoming.fill(fill_qty);
// Update the resting order
let resting_fully_filled = {
let resting = self
.get_order_mut(resting_id)
.expect("invariant: resting order exists in book");
resting.fill(fill_qty);
resting.remaining_quantity == 0
};
// Update the price level
let opposite = self.opposite_side_mut(incoming.side);
if resting_fully_filled {
// Remove the fully filled order from the level
if let Some(level) = opposite.get_level_mut(price) {
level.pop_front(fill_qty);
if level.is_empty() {
opposite.remove_level(price);
}
}
} else {
// Just decrease the level's quantity
if let Some(level) = opposite.get_level_mut(price) {
level.decrease_quantity(fill_qty);
}
}
}
}
/// Calculate how much quantity is available at prices that would cross.
///
/// This is used for FOK (fill-or-kill) feasibility checks.
pub fn available_to_fill(&self, side: Side, price: Price) -> Quantity {
self.opposite_side(side).quantity_at_or_better(price)
}
/// Check if an order can be fully filled (for FOK orders).
pub fn can_fully_fill(&self, side: Side, price: Price, quantity: Quantity) -> bool {
self.available_to_fill(side, price) >= quantity
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::{OrderId, OrderStatus, TimeInForce};
/// Helper to create a book with some resting orders
fn book_with_asks(asks: &[(i64, u64)]) -> OrderBook {
let mut book = OrderBook::new();
for &(price, qty) in asks {
let order = book.create_order(Side::Sell, Price(price), qty, TimeInForce::GTC);
book.add_order(order);
}
book
}
fn book_with_bids(bids: &[(i64, u64)]) -> OrderBook {
let mut book = OrderBook::new();
for &(price, qty) in bids {
let order = book.create_order(Side::Buy, Price(price), qty, TimeInForce::GTC);
book.add_order(order);
}
book
}
// === No match scenarios ===
#[test]
fn no_match_empty_book() {
let mut book = OrderBook::new();
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert!(result.is_empty());
assert_eq!(result.remaining_quantity, 100);
assert!(!result.is_fully_filled());
}
#[test]
fn no_match_prices_dont_cross() {
let mut book = book_with_asks(&[(101_00, 100)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert!(result.is_empty());
assert_eq!(result.remaining_quantity, 100);
// Ask still on book
assert_eq!(book.best_ask(), Some(Price(101_00)));
}
// === Full fill scenarios ===
#[test]
fn full_fill_exact_quantity() {
let mut book = book_with_asks(&[(100_00, 100)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert_eq!(result.trades.len(), 1);
assert_eq!(result.filled_quantity(), 100);
assert!(result.is_fully_filled());
// Regression for I3: without this negative assertion, the
// mutation `MatchResult::is_empty -> true` survived. Every
// pre-I3 test that inspected `is_empty` only asserted the
// positive case (empty book → empty result).
assert!(!result.is_empty());
// Verify trade details
let trade = &result.trades[0];
assert_eq!(trade.price, Price(100_00));
assert_eq!(trade.quantity, 100);
assert_eq!(trade.aggressor_side, Side::Buy);
// Book should be empty on ask side
assert_eq!(book.best_ask(), None);
// Resting order should be filled
let resting = book.get_order(OrderId(1)).unwrap();
assert_eq!(resting.status, OrderStatus::Filled);
}
#[test]
fn full_fill_incoming_smaller() {
let mut book = book_with_asks(&[(100_00, 200)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert_eq!(result.trades.len(), 1);
assert!(result.is_fully_filled());
// Resting order partially filled, still on book
assert_eq!(book.best_ask(), Some(Price(100_00)));
let resting = book.get_order(OrderId(1)).unwrap();
assert_eq!(resting.remaining_quantity, 100);
assert_eq!(resting.status, OrderStatus::PartiallyFilled);
}
// === Partial fill scenarios ===
#[test]
fn partial_fill_incoming_larger() {
let mut book = book_with_asks(&[(100_00, 50)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert_eq!(result.trades.len(), 1);
assert_eq!(result.filled_quantity(), 50);
assert_eq!(result.remaining_quantity, 50);
assert!(!result.is_fully_filled());
// Resting order fully consumed
assert_eq!(book.best_ask(), None);
}
// === Multi-order matching (FIFO) ===
#[test]
fn fifo_same_price() {
// Three asks at same price
let mut book = book_with_asks(&[(100_00, 30), (100_00, 40), (100_00, 50)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
// Should fill against first two orders completely, third partially
assert_eq!(result.trades.len(), 3);
assert_eq!(result.trades[0].quantity, 30); // First order
assert_eq!(result.trades[1].quantity, 40); // Second order
assert_eq!(result.trades[2].quantity, 30); // Third order (partial)
assert!(result.is_fully_filled());
// First two orders filled, third partially filled
assert_eq!(
book.get_order(OrderId(1)).unwrap().status,
OrderStatus::Filled
);
assert_eq!(
book.get_order(OrderId(2)).unwrap().status,
OrderStatus::Filled
);
assert_eq!(
book.get_order(OrderId(3)).unwrap().status,
OrderStatus::PartiallyFilled
);
assert_eq!(book.get_order(OrderId(3)).unwrap().remaining_quantity, 20);
}
// === Multi-level matching (price priority) ===
#[test]
fn price_priority_buy_sweeps_asks() {
// Asks at different prices
let mut book = book_with_asks(&[(100_00, 50), (101_00, 50), (102_00, 50)]);
// Buy at 102 should sweep through all prices
let mut order = book.create_order(Side::Buy, Price(102_00), 120, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert_eq!(result.trades.len(), 3);
// Fills at best prices first (lowest asks)
assert_eq!(result.trades[0].price, Price(100_00));
assert_eq!(result.trades[0].quantity, 50);
assert_eq!(result.trades[1].price, Price(101_00));
assert_eq!(result.trades[1].quantity, 50);
assert_eq!(result.trades[2].price, Price(102_00));
assert_eq!(result.trades[2].quantity, 20);
assert!(result.is_fully_filled());
// Only 30 left at 102
assert_eq!(book.best_ask(), Some(Price(102_00)));
assert_eq!(book.asks().total_quantity(), 30);
}
#[test]
fn price_priority_sell_sweeps_bids() {
// Bids at different prices
let mut book = book_with_bids(&[(100_00, 50), (99_00, 50), (98_00, 50)]);
// Sell at 98 should sweep through all prices
let mut order = book.create_order(Side::Sell, Price(98_00), 120, TimeInForce::GTC);
let result = book.match_order(&mut order);
assert_eq!(result.trades.len(), 3);
// Fills at best prices first (highest bids)
assert_eq!(result.trades[0].price, Price(100_00));
assert_eq!(result.trades[1].price, Price(99_00));
assert_eq!(result.trades[2].price, Price(98_00));
assert!(result.is_fully_filled());
}
// === Price improvement ===
#[test]
fn price_improvement_for_buyer() {
// Ask at 100, buyer willing to pay 105
let mut book = book_with_asks(&[(100_00, 100)]);
let mut order = book.create_order(Side::Buy, Price(105_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
// Trade executes at 100 (resting price), not 105 (incoming limit)
assert_eq!(result.trades[0].price, Price(100_00));
}
#[test]
fn price_improvement_for_seller() {
// Bid at 105, seller willing to accept 100
let mut book = book_with_bids(&[(105_00, 100)]);
let mut order = book.create_order(Side::Sell, Price(100_00), 100, TimeInForce::GTC);
let result = book.match_order(&mut order);
// Trade executes at 105 (resting price), not 100 (incoming limit)
assert_eq!(result.trades[0].price, Price(105_00));
}
// === Order state after matching ===
#[test]
fn incoming_order_state_after_full_fill() {
let mut book = book_with_asks(&[(100_00, 100)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
book.match_order(&mut order);
assert_eq!(order.remaining_quantity, 0);
assert_eq!(order.filled_quantity, 100);
assert_eq!(order.status, OrderStatus::Filled);
}
#[test]
fn incoming_order_state_after_partial_fill() {
let mut book = book_with_asks(&[(100_00, 30)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 100, TimeInForce::GTC);
book.match_order(&mut order);
assert_eq!(order.remaining_quantity, 70);
assert_eq!(order.filled_quantity, 30);
assert_eq!(order.status, OrderStatus::PartiallyFilled);
}
// === FOK feasibility checks ===
#[test]
fn available_to_fill() {
let book = book_with_asks(&[(100_00, 50), (101_00, 75), (102_00, 100)]);
// Buy at 100: only 50 available
assert_eq!(book.available_to_fill(Side::Buy, Price(100_00)), 50);
// Buy at 101: 50 + 75 = 125 available
assert_eq!(book.available_to_fill(Side::Buy, Price(101_00)), 125);
// Buy at 102: all 225 available
assert_eq!(book.available_to_fill(Side::Buy, Price(102_00)), 225);
}
#[test]
fn can_fully_fill() {
let book = book_with_asks(&[(100_00, 100)]);
assert!(book.can_fully_fill(Side::Buy, Price(100_00), 50));
assert!(book.can_fully_fill(Side::Buy, Price(100_00), 100));
assert!(!book.can_fully_fill(Side::Buy, Price(100_00), 101));
assert!(!book.can_fully_fill(Side::Buy, Price(99_00), 50)); // Price doesn't cross
}
// === Edge cases ===
#[test]
fn match_clears_multiple_levels() {
let mut book = book_with_asks(&[(100_00, 10), (101_00, 10)]);
let mut order = book.create_order(Side::Buy, Price(101_00), 20, TimeInForce::GTC);
book.match_order(&mut order);
// Both levels should be cleared
assert_eq!(book.asks().level_count(), 0);
assert_eq!(book.best_ask(), None);
}
#[test]
fn trade_ids_are_sequential() {
let mut book = book_with_asks(&[(100_00, 30), (100_00, 30), (100_00, 30)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 90, TimeInForce::GTC);
let result = book.match_order(&mut order);
// Trade IDs should be sequential
assert_eq!(result.trades[0].id.0, 1);
assert_eq!(result.trades[1].id.0, 2);
assert_eq!(result.trades[2].id.0, 3);
}
#[test]
fn timestamps_are_sequential() {
let mut book = book_with_asks(&[(100_00, 30), (100_00, 30)]);
let mut order = book.create_order(Side::Buy, Price(100_00), 60, TimeInForce::GTC);
let result = book.match_order(&mut order);
// Timestamps should be sequential (after order creation timestamps)
assert!(result.trades[0].timestamp < result.trades[1].timestamp);
}
}