mx 0.1.215

A Swiss army knife for Claude Code and multi-agent toolkits
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246

//! Integration tests for `mx kv set` argument binding (Issue #386).
//!
//! `trailing_var_arg` on `KvCommands::Set` captured trailing flag-like tokens
//! as positional values, silently corrupting the store (`set k world --json`
//! stored the literal `--json` and dropped `world`, exit 0). These tests pin
//! the post-fix behavior: declared flags bind anywhere on the line, two-token
//! scalar values fail loudly, and `--` remains the escape hatch for literal
//! hyphen-leading values. Harness mirrors `tests/triggers_cli.rs` (built
//! binary against an isolated MX_HOME); no lock needed since `mx kv` touches
//! only flat files under MX_HOME.

use std::process::Command;
use tempfile::TempDir;

mod common;

const MX: &str = env!("CARGO_BIN_EXE_mx");

const SCHEMA: &str = r#"
[keys.note]
type = "string"

[keys.warmth]
type = "counter"

[keys.tensor]
type = "state"
fields = ["temperature", "entropy"]
"#;

/// Fresh isolated MX_HOME with a seeded kv schema for agent `test`.
fn setup() -> TempDir {
    let dir = TempDir::new().unwrap();
    let schema_dir = dir.path().join("kv").join("schema");
    std::fs::create_dir_all(&schema_dir).unwrap();
    std::fs::write(schema_dir.join("test.toml"), SCHEMA).unwrap();
    dir
}

fn mx(dir: &TempDir, args: &[&str]) -> std::process::Output {
    let mut cmd = Command::new(MX);
    common::isolate(&mut cmd, dir.path());
    cmd.args(args)
        .env("MX_CURRENT_AGENT", "test")
        .env_remove("MX_KV_SCHEMA")
        .env_remove("MX_KV_DATA")
        .output()
        .expect("failed to run mx")
}

fn get(dir: &TempDir, key: &str) -> String {
    let out = mx(dir, &["kv", "get", key]);
    assert!(
        out.status.success(),
        "get {} failed: {}",
        key,
        String::from_utf8_lossy(&out.stderr)
    );
    String::from_utf8_lossy(&out.stdout).trim().to_string()
}

fn set_ok(dir: &TempDir, args: &[&str]) {
    let mut full = vec!["kv", "set"];
    full.extend_from_slice(args);
    let out = mx(dir, &full);
    assert!(
        out.status.success(),
        "set {:?} failed: {}",
        args,
        String::from_utf8_lossy(&out.stderr)
    );
}

// -- trailing --json --

#[test]
fn trailing_bare_json_flag_errors_string_key() {
    let dir = setup();
    set_ok(&dir, &["note", "hello"]);

    // Bare trailing --json binds to the declared flag and is missing its value.
    let out = mx(&dir, &["kv", "set", "note", "world", "--json"]);
    assert!(!out.status.success());
    assert_eq!(get(&dir, "note"), "hello", "store must be unchanged");
}

#[test]
fn json_flag_with_positionals_hits_combined_guard() {
    let dir = setup();
    set_ok(&dir, &["note", "hello"]);

    let out = mx(
        &dir,
        &["kv", "set", "note", "world", "--json", "{\"a\":\"b\"}"],
    );
    assert!(!out.status.success());
    let stderr = String::from_utf8_lossy(&out.stderr);
    assert!(
        stderr.contains("cannot be combined"),
        "expected combined guard, got: {}",
        stderr
    );
    assert_eq!(get(&dir, "note"), "hello", "store must be unchanged");
}

#[test]
fn trailing_json_flag_errors_counter_key() {
    let dir = setup();
    set_ok(&dir, &["warmth", "3"]);

    let out = mx(&dir, &["kv", "set", "warmth", "5", "--json"]);
    assert!(!out.status.success());
    assert_eq!(get(&dir, "warmth"), "3", "store must be unchanged");
}

#[test]
fn trailing_json_flag_errors_state_key() {
    let dir = setup();
    set_ok(&dir, &["tensor", "temperature=0.5"]);

    let out = mx(&dir, &["kv", "set", "tensor", "entropy", "--json"]);
    assert!(!out.status.success());
    let val = get(&dir, "tensor");
    assert!(val.contains("\"temperature\": \"0.5\""));
    assert!(!val.contains("--json"), "flag must not leak into the store");
}

// -- trailing -v (global verbose) --

#[test]
fn trailing_verbose_flag_binds_globally_string_key() {
    let dir = setup();

    // Pre-fix this stored the literal "-v" and dropped "world".
    let out = mx(&dir, &["kv", "set", "note", "world", "-v"]);
    assert!(
        out.status.success(),
        "set failed: {}",
        String::from_utf8_lossy(&out.stderr)
    );
    assert_eq!(get(&dir, "note"), "world");
}

#[test]
fn trailing_verbose_flag_binds_globally_counter_key() {
    let dir = setup();

    let out = mx(&dir, &["kv", "set", "warmth", "5", "-v"]);
    assert!(
        out.status.success(),
        "set failed: {}",
        String::from_utf8_lossy(&out.stderr)
    );
    assert_eq!(get(&dir, "warmth"), "5");
}

#[test]
fn trailing_verbose_flag_binds_globally_state_key() {
    let dir = setup();

    let out = mx(&dir, &["kv", "set", "tensor", "temperature", "0.7", "-v"]);
    assert!(
        out.status.success(),
        "set failed: {}",
        String::from_utf8_lossy(&out.stderr)
    );
    assert!(get(&dir, "tensor").contains("\"temperature\": \"0.7\""));
}

// -- silent first-token drop --

#[test]
fn unquoted_two_word_string_value_errors() {
    let dir = setup();
    set_ok(&dir, &["note", "hello"]);

    // Pre-fix this stored "words" and silently dropped "two".
    let out = mx(&dir, &["kv", "set", "note", "two", "words"]);
    assert!(!out.status.success());
    let stderr = String::from_utf8_lossy(&out.stderr);
    assert!(
        stderr.contains("quote the value"),
        "error must name the problem, got: {}",
        stderr
    );
    assert_eq!(get(&dir, "note"), "hello", "store must be unchanged");
}

#[test]
fn counter_two_positionals_error() {
    let dir = setup();
    set_ok(&dir, &["warmth", "3"]);

    // Pre-fix this stored 5 and silently dropped 1.
    let out = mx(&dir, &["kv", "set", "warmth", "1", "5"]);
    assert!(!out.status.success());
    let stderr = String::from_utf8_lossy(&out.stderr);
    assert!(
        stderr.contains("is counter"),
        "error must name the type, got: {}",
        stderr
    );
    assert_eq!(get(&dir, "warmth"), "3", "store must be unchanged");
}

// -- escape hatch and legit flag-after-value usage --

#[test]
fn double_dash_stores_literal_flag_token() {
    let dir = setup();

    set_ok(&dir, &["note", "--", "--json"]);
    assert_eq!(get(&dir, "note"), "--json");
}

#[test]
fn memory_flag_after_value_works_on_state_key() {
    let dir = setup();

    // Pre-fix: --memory was swallowed into args → exit 4.
    set_ok(
        &dir,
        &["tensor", "temperature", "0.7", "--memory", "kn-abc123"],
    );
    assert!(get(&dir, "tensor").contains("\"temperature\": \"0.7\""));

    let data = std::fs::read_to_string(dir.path().join("kv").join("data").join("test.json"))
        .expect("data file written");
    assert!(
        data.contains("kn-abc123"),
        "memory pointer must be persisted: {}",
        data
    );
}

// -- batch key=value form (#324) unaffected --

#[test]
fn batch_key_value_form_unaffected() {
    let dir = setup();

    set_ok(&dir, &["tensor", "temperature=0.5", "entropy=0.2"]);
    let val = get(&dir, "tensor");
    assert!(val.contains("\"temperature\": \"0.5\""));
    assert!(val.contains("\"entropy\": \"0.2\""));
}