musefs-db 1.0.0

SQLite store and schema for musefs (tracks, tags, content-addressed art).
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
use crate::error::{check_field_len, check_tag_count};
use crate::limits::{MAX_TAG_KEY_LEN, MAX_TAG_VALUE_LEN};
use crate::models::{BinaryTag, BinaryTagRow, Tag};
use crate::{Db, ReadWrite, Result};
use rusqlite::params;

/// Reject an over-cap text-tag row from its `length(key)`/`length(value)`
/// columns *before* the strings are materialized. Routes through the shared
/// `check_field_len`, so the allocation-free guarantee is the same one its
/// unit test pins (spec N13).
fn check_tag_lengths(key_len: i64, value_len: i64) -> Result<()> {
    check_field_len("tags", "key", key_len, MAX_TAG_KEY_LEN)?;
    check_field_len("tags", "value", value_len, MAX_TAG_VALUE_LEN)?;
    Ok(())
}

impl<M> Db<M> {
    pub fn get_tags(&self, track_id: i64) -> Result<Vec<Tag>> {
        let mut stmt = self.conn.prepare(
            "SELECT length(key), length(value), key, value, ordinal FROM tags \
             WHERE track_id = ?1 AND value_blob IS NULL ORDER BY key, ordinal",
        )?;
        let mut rows = stmt.query(params![track_id])?;
        let mut out = Vec::new();
        while let Some(r) = rows.next()? {
            check_tag_lengths(r.get(0)?, r.get(1)?)?;
            out.push(Tag {
                key: r.get(2)?,
                value: r.get(3)?,
                ordinal: r.get(4)?,
            });
            check_tag_count(track_id, out.len())?;
        }
        Ok(out)
    }

    pub fn tags_for_tracks(
        &self,
        track_ids: &[i64],
    ) -> Result<std::collections::HashMap<i64, Vec<Tag>>> {
        const CHUNK: usize = 900;
        let mut out: std::collections::HashMap<i64, Vec<Tag>> = std::collections::HashMap::new();
        for chunk in track_ids.chunks(CHUNK) {
            let placeholders = vec!["?"; chunk.len()].join(",");
            let sql = format!(
                "SELECT track_id, length(key), length(value), key, value, ordinal FROM tags \
                 WHERE track_id IN ({placeholders}) AND value_blob IS NULL \
                 ORDER BY track_id, key, ordinal"
            );
            let mut stmt = self.conn.prepare(&sql)?;
            let params = rusqlite::params_from_iter(chunk.iter());
            let mut rows = stmt.query(params)?;
            while let Some(r) = rows.next()? {
                let track_id: i64 = r.get(0)?;
                check_tag_lengths(r.get(1)?, r.get(2)?)?;
                let entry = out.entry(track_id).or_default();
                entry.push(Tag {
                    key: r.get(3)?,
                    value: r.get(4)?,
                    ordinal: r.get(5)?,
                });
                check_tag_count(track_id, entry.len())?;
            }
        }
        Ok(out)
    }

    pub fn tags_grouped(&self) -> Result<std::collections::HashMap<i64, Vec<Tag>>> {
        let mut stmt = self.conn.prepare(
            "SELECT track_id, length(key), length(value), key, value, ordinal FROM tags \
             WHERE value_blob IS NULL ORDER BY track_id, key, ordinal",
        )?;
        let mut rows = stmt.query([])?;
        let mut out: std::collections::HashMap<i64, Vec<Tag>> = std::collections::HashMap::new();
        while let Some(r) = rows.next()? {
            let track_id: i64 = r.get(0)?;
            check_tag_lengths(r.get(1)?, r.get(2)?)?;
            let entry = out.entry(track_id).or_default();
            entry.push(Tag {
                key: r.get(3)?,
                value: r.get(4)?,
                ordinal: r.get(5)?,
            });
            check_tag_count(track_id, entry.len())?;
        }
        Ok(out)
    }

    pub fn tags_grouped_for_keys(
        &self,
        keys: &[&str],
    ) -> Result<std::collections::HashMap<i64, Vec<Tag>>> {
        const CHUNK: usize = 900;
        let mut out: std::collections::HashMap<i64, Vec<Tag>> = std::collections::HashMap::new();
        for chunk in keys.chunks(CHUNK) {
            let lowered: Vec<String> = chunk.iter().map(|k| k.to_ascii_lowercase()).collect();
            let placeholders = vec!["?"; lowered.len()].join(",");
            let sql = format!(
                "SELECT track_id, length(key), length(value), key, value, ordinal FROM tags \
                 WHERE value_blob IS NULL AND lower(key) IN ({placeholders}) \
                 ORDER BY track_id, key, ordinal"
            );
            let mut stmt = self.conn.prepare(&sql)?;
            let params = rusqlite::params_from_iter(lowered.iter());
            let mut rows = stmt.query(params)?;
            while let Some(r) = rows.next()? {
                let track_id: i64 = r.get(0)?;
                check_tag_lengths(r.get(1)?, r.get(2)?)?;
                let entry = out.entry(track_id).or_default();
                entry.push(Tag {
                    key: r.get(3)?,
                    value: r.get(4)?,
                    ordinal: r.get(5)?,
                });
                check_tag_count(track_id, entry.len())?;
            }
        }
        Ok(out)
    }

    /// Binary tag rows for a track: streaming handle (rowid), key, and payload
    /// length. Ordered by (key, ordinal) to match the layout builder's emission
    /// order. The blob bytes stream at read time; only `key` (materialized here)
    /// is length-guarded, plus the per-track row count.
    pub fn get_binary_tags(&self, track_id: i64) -> Result<Vec<BinaryTagRow>> {
        let mut stmt = self.conn.prepare(
            "SELECT length(key), rowid, key, length(value_blob) FROM tags \
             WHERE track_id = ?1 AND value_blob IS NOT NULL ORDER BY key, ordinal",
        )?;
        let mut rows = stmt.query(params![track_id])?;
        let mut out = Vec::new();
        while let Some(r) = rows.next()? {
            check_field_len("tags", "key", r.get(0)?, MAX_TAG_KEY_LEN)?;
            out.push(BinaryTagRow {
                rowid: r.get(1)?,
                key: r.get(2)?,
                byte_len: r.get(3)?,
            });
            check_tag_count(track_id, out.len())?;
        }
        Ok(out)
    }

    /// Stream binary-tag bytes at `offset` directly into `buf` via incremental blob
    /// I/O — no intermediate allocation (#70). A short read means the row changed
    /// underneath the resolved layout; `read_at_exact` surfaces it as an error rather
    /// than zero-filling. (`payload_id` is the `tags` rowid; see the spec's
    /// "payload_id validity invariant".)
    pub fn read_binary_tag_chunk_into(
        &self,
        payload_id: i64,
        offset: u64,
        buf: &mut [u8],
    ) -> Result<()> {
        let blob = self
            .conn
            .blob_open("main", "tags", "value_blob", payload_id, true)?;
        blob.read_at_exact(buf, crate::convert::usize_from(offset))?;
        Ok(())
    }

    /// Allocating convenience form of `read_binary_tag_chunk_into` (non-hot-path
    /// callers).
    pub fn read_binary_tag_chunk(
        &self,
        payload_id: i64,
        offset: u64,
        len: usize,
    ) -> Result<Vec<u8>> {
        let mut buf = vec![0u8; len];
        self.read_binary_tag_chunk_into(payload_id, offset, &mut buf)?;
        Ok(buf)
    }
}

impl Db<ReadWrite> {
    pub fn replace_tags(&self, track_id: i64, tags: &[Tag]) -> Result<()> {
        let tx = self.conn.unchecked_transaction()?;
        tx.execute(
            "DELETE FROM tags WHERE track_id = ?1 AND value_blob IS NULL",
            params![track_id],
        )?;
        {
            let mut stmt = tx.prepare(
                "INSERT INTO tags (track_id, key, value, ordinal) VALUES (?1, ?2, ?3, ?4)",
            )?;
            for t in tags {
                stmt.execute(params![track_id, t.key, t.value, t.ordinal])?;
            }
        }
        tx.commit()?;
        Ok(())
    }

    /// Replace the track's binary tag rows (value_blob IS NOT NULL); text rows
    /// (managed by `replace_tags`) are untouched. Binary rows store '' in `value`.
    pub fn set_binary_tags(&self, track_id: i64, tags: &[BinaryTag]) -> Result<()> {
        let tx = self.conn.unchecked_transaction()?;
        tx.execute(
            "DELETE FROM tags WHERE track_id = ?1 AND value_blob IS NOT NULL",
            params![track_id],
        )?;
        {
            let mut stmt = tx.prepare(
                "INSERT INTO tags (track_id, key, value, value_blob, ordinal) \
                 VALUES (?1, ?2, '', ?3, ?4)",
            )?;
            for t in tags {
                stmt.execute(params![track_id, t.key, t.payload, t.ordinal])?;
            }
        }
        tx.commit()?;
        Ok(())
    }
}

#[cfg(test)]
mod tags_for_tracks_tests {
    use super::*;
    use crate::{Format, NewTrack, Tag};

    fn open_mem() -> Db {
        Db::open_in_memory().unwrap()
    }
    fn new_track(path: &str) -> NewTrack {
        NewTrack {
            backing_path: path.into(),
            format: Format::Flac,
            audio_offset: 0,
            audio_length: 1,
            backing_size: 1,
            backing_mtime_ns: 0,
            backing_ctime_ns: 0,
        }
    }

    #[test]
    fn tags_for_tracks_returns_only_requested_ordered_by_key_ordinal() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        let b = db.upsert_track(&new_track("/b.flac")).unwrap();
        let c = db.upsert_track(&new_track("/c.flac")).unwrap();
        db.replace_tags(
            a,
            &[
                Tag::new("ARTIST", "second", 1),
                Tag::new("ARTIST", "first", 0),
            ],
        )
        .unwrap();
        db.replace_tags(b, &[Tag::new("ARTIST", "bee", 0)]).unwrap();
        db.replace_tags(c, &[Tag::new("ARTIST", "cee", 0)]).unwrap();

        let got = db.tags_for_tracks(&[a, b]).unwrap();
        assert_eq!(got.len(), 2, "c was not requested");
        assert!(!got.contains_key(&c));
        let a_tags = &got[&a];
        assert_eq!(a_tags[0].value, "first");
        assert_eq!(a_tags[1].value, "second");
    }

    #[test]
    fn tags_for_tracks_chunks_beyond_sqlite_variable_limit() {
        let db = open_mem();
        let mut ids = Vec::new();
        for i in 0..1500 {
            let id = db.upsert_track(&new_track(&format!("/t{i}.flac"))).unwrap();
            db.replace_tags(id, &[Tag::new("TITLE", &format!("t{i}"), 0)])
                .unwrap();
            ids.push(id);
        }
        let got = db.tags_for_tracks(&ids).unwrap();
        assert_eq!(got.len(), 1500, "all chunks fetched");
    }

    #[test]
    fn tags_for_tracks_empty_input_is_empty_map() {
        let db = open_mem();
        assert!(db.tags_for_tracks(&[]).unwrap().is_empty());
    }

    #[test]
    fn text_queries_exclude_binary_rows() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.replace_tags(a, &[Tag::new("artist", "Alice", 0)])
            .unwrap();
        db.conn
            .execute(
                "INSERT INTO tags (track_id, key, value, value_blob, ordinal) \
                 VALUES (?1, 'PRIV', '', X'DEADBEEF', 0)",
                rusqlite::params![a],
            )
            .unwrap();

        let got = db.get_tags(a).unwrap();
        assert_eq!(got, vec![Tag::new("artist", "Alice", 0)]);
        let grouped = db.tags_grouped().unwrap();
        assert_eq!(grouped[&a], vec![Tag::new("artist", "Alice", 0)]);
        let for_tracks = db.tags_for_tracks(&[a]).unwrap();
        assert_eq!(for_tracks[&a], vec![Tag::new("artist", "Alice", 0)]);
    }

    #[test]
    fn binary_tags_round_trip_and_are_independent_of_text() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.replace_tags(a, &[Tag::new("artist", "Alice", 0)])
            .unwrap();
        db.set_binary_tags(
            a,
            &[
                crate::BinaryTag {
                    key: "PRIV".into(),
                    payload: vec![1, 2, 3],
                    ordinal: 0,
                },
                crate::BinaryTag {
                    key: "PRIV".into(),
                    payload: vec![9, 9],
                    ordinal: 1,
                },
                crate::BinaryTag {
                    key: "GEOB".into(),
                    payload: vec![7],
                    ordinal: 0,
                },
            ],
        )
        .unwrap();

        assert_eq!(
            db.get_tags(a).unwrap(),
            vec![Tag::new("artist", "Alice", 0)]
        );

        let rows = db.get_binary_tags(a).unwrap();
        assert_eq!(rows.len(), 3);
        assert_eq!(rows[0].key, "GEOB");
        assert_eq!(rows[0].byte_len, 1);
        assert_eq!(rows[1].key, "PRIV");
        assert_eq!(rows[1].byte_len, 3);
        assert_eq!(rows[2].byte_len, 2);

        let full = db.read_binary_tag_chunk(rows[1].rowid, 0, 3).unwrap();
        assert_eq!(full, vec![1, 2, 3]);
        let mid = db.read_binary_tag_chunk(rows[1].rowid, 1, 2).unwrap();
        assert_eq!(mid, vec![2, 3]);

        db.set_binary_tags(a, &[]).unwrap();
        assert!(db.get_binary_tags(a).unwrap().is_empty());
        assert_eq!(
            db.get_tags(a).unwrap(),
            vec![Tag::new("artist", "Alice", 0)]
        );
    }

    #[test]
    fn tags_grouped_for_keys_filters_case_insensitively() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.replace_tags(
            a,
            &[
                Tag::new("ARTIST", "Pix", 0),
                Tag::new("Title", "Song", 0),
                Tag::new("LYRICS", "la la", 0),
            ],
        )
        .unwrap();
        let got = db.tags_grouped_for_keys(&["artist", "title"]).unwrap();
        let tags = &got[&a];
        assert!(tags.iter().any(|t| t.value == "Pix"), "ARTIST matched");
        assert!(tags.iter().any(|t| t.value == "Song"), "Title matched");
        assert!(!tags.iter().any(|t| t.value == "la la"), "LYRICS excluded");
    }

    #[test]
    fn get_tags_rejects_oversize_value() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.conn
            .execute_batch("PRAGMA ignore_check_constraints=ON")
            .unwrap();
        let big = "v".repeat(262_145);
        db.conn
            .execute(
                "INSERT INTO tags (track_id, key, value, ordinal) VALUES (?1, 'k', ?2, 0)",
                rusqlite::params![a, big],
            )
            .unwrap();
        let err = db.get_tags(a).unwrap_err();
        assert!(
            matches!(err, crate::DbError::FieldTooLarge { field: "value", .. }),
            "{err:?}"
        );
    }

    #[test]
    fn get_tags_accepts_value_at_cap() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        let at = "v".repeat(262_144);
        db.conn
            .execute(
                "INSERT INTO tags (track_id, key, value, ordinal) VALUES (?1, 'k', ?2, 0)",
                rusqlite::params![a, at],
            )
            .unwrap();
        assert_eq!(db.get_tags(a).unwrap()[0].value.len(), 262_144);
    }

    #[test]
    fn get_binary_tags_rejects_oversize_key() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.conn
            .execute_batch("PRAGMA ignore_check_constraints=ON")
            .unwrap();
        let key = "k".repeat(257);
        db.conn
            .execute(
                "INSERT INTO tags (track_id, key, value, value_blob, ordinal) VALUES (?1, ?2, '', X'00', 0)",
                rusqlite::params![a, key],
            )
            .unwrap();
        let err = db.get_binary_tags(a).unwrap_err();
        assert!(
            matches!(
                err,
                crate::DbError::FieldTooLarge {
                    table: "tags",
                    field: "key",
                    ..
                }
            ),
            "{err:?}"
        );
    }

    #[test]
    fn per_track_count_cap_text_and_binary() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        // 4097 text rows -> TooManyValues on get_tags.
        {
            let tx = db.conn.unchecked_transaction().unwrap();
            let mut stmt = tx
                .prepare(
                    "INSERT INTO tags (track_id, key, value, ordinal) VALUES (?1, 'k', 'v', ?2)",
                )
                .unwrap();
            for i in 0..4097 {
                stmt.execute(rusqlite::params![a, i]).unwrap();
            }
            drop(stmt);
            tx.commit().unwrap();
        }
        let err = db.get_tags(a).unwrap_err();
        assert!(
            matches!(err, crate::DbError::TooManyValues { .. }),
            "{err:?}"
        );
    }

    #[test]
    fn bulk_reader_rejects_one_oversized_track_in_batch() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        let b = db.upsert_track(&new_track("/b.flac")).unwrap();
        db.replace_tags(b, &[Tag::new("ok", "fine", 0)]).unwrap();
        db.conn
            .execute_batch("PRAGMA ignore_check_constraints=ON")
            .unwrap();
        let big = "v".repeat(262_145);
        db.conn
            .execute(
                "INSERT INTO tags (track_id, key, value, ordinal) VALUES (?1, 'k', ?2, 0)",
                rusqlite::params![a, big],
            )
            .unwrap();
        let err = db.tags_for_tracks(&[a, b]).unwrap_err();
        assert!(
            matches!(err, crate::DbError::FieldTooLarge { field: "value", .. }),
            "{err:?}"
        );
    }

    #[test]
    fn tags_grouped_for_keys_empty_keys_is_empty_map() {
        let db = open_mem();
        let a = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.replace_tags(a, &[Tag::new("ARTIST", "Pix", 0)]).unwrap();
        let got = db.tags_grouped_for_keys(&[]).unwrap();
        assert!(got.is_empty());
    }

    #[test]
    fn replace_tags_rejects_floor_violating_keys() {
        let db = open_mem();
        let t = db.upsert_track(&new_track("/a.flac")).unwrap();
        // A row violating the floor aborts the whole row-by-row transactional insert.
        assert!(db.replace_tags(t, &[Tag::new("", "v", 0)]).is_err());
        assert!(db.replace_tags(t, &[Tag::new("\u{7}", "v", 0)]).is_err());
        // '=' passes the DB floor (only the Vorbis path bars it).
        db.replace_tags(t, &[Tag::new("a=b", "c", 0)]).unwrap();
        let got = db.get_tags(t).unwrap();
        assert_eq!(got.len(), 1);
        assert_eq!(got[0].key, "a=b");
    }

    #[test]
    fn replace_tags_rolls_back_a_mixed_valid_invalid_batch() {
        let db = open_mem();
        let t = db.upsert_track(&new_track("/a.flac")).unwrap();
        db.replace_tags(t, &[Tag::new("artist", "Alice", 0)])
            .unwrap();
        // replace_tags DELETEs the existing text rows before re-inserting; a CHECK
        // violation later in the batch must roll the whole transaction back —
        // including the DELETE — so the original rows survive rather than the batch
        // half-applying.
        assert!(
            db.replace_tags(t, &[Tag::new("title", "ok", 0), Tag::new("", "bad", 0)])
                .is_err()
        );
        let got = db.get_tags(t).unwrap();
        assert_eq!(got.len(), 1);
        assert_eq!(got[0].key, "artist");
        assert_eq!(got[0].value, "Alice");
    }
}