multi-llm 1.0.0

Unified multi-provider LLM client with support for OpenAI, Anthropic, Ollama, and LMStudio
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
// Integration Tests for Token Management System
//
// SYSTEMS UNDER TEST: TokenCounter implementations (OpenAITokenCounter, AnthropicTokenCounter)
//
// BUSINESS RESPONSIBILITY:
//   - Provides accurate token counting using tiktoken for different LLM providers
//   - Validates token limits before sending requests to prevent API errors
//   - Truncates text to fit within context windows while preserving meaning
//   - Manages provider-specific tokenization differences and context limits
//   - Enables pre-request validation and context management for optimal LLM performance
//
// TEST COVERAGE:
//   - Token counting accuracy for different text types (ASCII, Unicode, repeated)
//   - Message token counting with proper formatting overhead calculation
//   - Token limit validation with different context window sizes
//   - Text truncation with preservation of token boundaries
//   - Provider-specific tokenizer selection and model context limits
//   - Factory pattern for creating appropriate counters per provider
//   - Error handling for tokenizer initialization failures

// Integration tests need to import from the crate
use multi_llm::error::LlmError;
use multi_llm::{AnthropicTokenCounter, OpenAITokenCounter};

/// Helper function to create concrete OpenAI token counter for testing
fn create_concrete_openai_counter() -> OpenAITokenCounter {
    OpenAITokenCounter::new("gpt-4").unwrap()
}

/// Helper function to create concrete Anthropic token counter for testing
fn create_concrete_anthropic_counter() -> AnthropicTokenCounter {
    AnthropicTokenCounter::new("claude-3-5-sonnet").unwrap()
}

/// Helper function to create test messages for validation
fn create_test_messages() -> Vec<serde_json::Value> {
    vec![
        serde_json::json!({
            "role": "user",
            "content": "What is the capital of France?"
        }),
        serde_json::json!({
            "role": "assistant",
            "content": "The capital of France is Paris."
        }),
    ]
}

#[cfg(test)]
mod openai_token_counter_tests {
    use super::*;
    use multi_llm::TokenCounter;

    #[test]
    fn test_token_counting_accuracy_for_simple_text() {
        // Test verifies OpenAI token counter provides accurate counts for basic text
        // Ensures tiktoken integration works correctly for common use cases

        // Arrange
        let counter = create_concrete_openai_counter();
        let simple_text = "The quick brown fox jumps over the lazy dog";

        // Act
        let token_count = counter.count_tokens(simple_text).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Simple text should have positive token count"
        );
        assert!(
            token_count < 20,
            "Simple sentence should have reasonable token count"
        );
        assert_eq!(
            token_count, 9,
            "Expected tiktoken count for this specific text"
        );
    }

    #[test]
    fn test_token_counting_with_unicode_characters() {
        // Test verifies proper handling of international characters and emojis
        // Ensures tokenizer correctly handles multi-byte Unicode sequences

        // Arrange
        let counter = create_concrete_openai_counter();
        let unicode_text = "Hello 世界 🌍 नमस्ते مرحبا";

        // Act
        let token_count = counter.count_tokens(unicode_text).unwrap();

        // Assert
        assert!(
            token_count > 5,
            "Unicode text should require multiple tokens"
        );
        assert!(token_count < 50, "Should not over-tokenize Unicode text");
    }

    #[test]
    fn test_message_token_counting_includes_formatting_overhead() {
        // Test verifies message token counting includes OpenAI chat formatting
        // Ensures proper accounting for role markers and conversation structure

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = create_test_messages();

        // Act
        let message_tokens = counter.count_message_tokens(&messages).unwrap();
        let content_only_tokens = counter
            .count_tokens("What is the capital of France?The capital of France is Paris.")
            .unwrap();

        // Assert
        assert!(
            message_tokens > content_only_tokens,
            "Message format should add overhead tokens"
        );
        assert!(
            message_tokens > 15,
            "Should include formatting tokens for roles and structure"
        );
    }

    #[test]
    fn test_context_window_limits_for_different_models() {
        // Test verifies different GPT models have correct context window sizes
        // Ensures model-specific limits are properly configured

        // Arrange & Act
        let gpt4_counter = OpenAITokenCounter::new("gpt-4").unwrap();
        let gpt4_turbo_counter = OpenAITokenCounter::new("gpt-4-turbo").unwrap();
        let gpt35_counter = OpenAITokenCounter::new("gpt-3.5-turbo").unwrap();
        let o1_counter = OpenAITokenCounter::new("o1-preview").unwrap();

        // Assert
        assert_eq!(
            gpt4_counter.max_context_tokens(),
            8192,
            "GPT-4 should have 8k context"
        );
        assert_eq!(
            gpt4_turbo_counter.max_context_tokens(),
            128000,
            "GPT-4 Turbo should have 128k context"
        );
        assert_eq!(
            gpt35_counter.max_context_tokens(),
            4096,
            "GPT-3.5 should have 4k context"
        );
        assert_eq!(
            o1_counter.max_context_tokens(),
            200000,
            "o1 models should have 200k context"
        );
    }

    #[test]
    fn test_token_limit_validation_prevents_oversized_requests() {
        // Test verifies token limit validation catches requests that would exceed context
        // Ensures pre-request validation prevents API errors and wasted requests

        // Arrange
        let counter = OpenAITokenCounter::for_lm_studio(50).unwrap(); // Very small limit for testing
        let short_text = "Hello world";
        let long_text = "This is a very long text that should definitely exceed our small token limit for testing purposes. ".repeat(10);

        // Act & Assert
        assert!(
            counter.validate_token_limit(short_text).is_ok(),
            "Short text should pass validation"
        );
        assert!(
            counter.validate_token_limit(&long_text).is_err(),
            "Long text should fail validation"
        );

        // Verify error type
        let error = counter.validate_token_limit(&long_text).unwrap_err();
        match error {
            LlmError::TokenLimitExceeded { .. } => {} // Expected
            _ => panic!("Should return TokenLimitExceeded error"),
        }
    }

    #[test]
    fn test_text_truncation_preserves_token_boundaries() {
        // Test verifies text truncation maintains valid token boundaries
        // Ensures truncated text remains coherent and doesn't break mid-token

        // Arrange
        let counter = create_concrete_openai_counter();
        let long_text = "The quick brown fox jumps over the lazy dog. ".repeat(20);
        let max_tokens = 50u32;

        // Act
        let truncated = counter.truncate_to_limit(&long_text, max_tokens).unwrap();
        let truncated_tokens = counter.count_tokens(&truncated).unwrap();

        // Assert
        assert!(
            truncated_tokens <= max_tokens,
            "Truncated text should fit within limit"
        );
        assert!(
            truncated.len() < long_text.len(),
            "Truncated text should be shorter"
        );
        assert!(!truncated.is_empty(), "Should not truncate to empty string");
        assert!(
            !truncated.ends_with(""),
            "Should not break Unicode sequences"
        );
    }

    #[test]
    fn test_lm_studio_counter_creation_with_custom_limits() {
        // Test verifies LM Studio counter supports custom context window sizes
        // Ensures flexibility for local models with different capabilities

        // Arrange & Act
        let counter = OpenAITokenCounter::for_lm_studio(16384).unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            16384,
            "Should use custom context limit"
        );
        assert!(
            counter.count_tokens("test").unwrap() > 0,
            "Should count tokens normally"
        );
    }

    #[test]
    fn test_unknown_model_defaults_to_cl100k_base_with_4k_context() {
        // Test verifies unknown model names fall back to safe defaults
        // Ensures graceful handling of new/unknown models without crashing

        // Arrange & Act
        let counter = OpenAITokenCounter::new("unknown-model-xyz").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            4096,
            "Unknown models should use conservative 4k limit"
        );
        assert!(
            counter.count_tokens("test text").unwrap() > 0,
            "Should still count tokens with default tokenizer"
        );
    }

    #[test]
    fn test_gpt4_turbo_uses_128k_context() {
        // Test verifies GPT-4 Turbo models get correct 128k context limit
        // Ensures model variant detection works for turbo versions

        // Arrange & Act
        let counter = OpenAITokenCounter::new("gpt-4-turbo").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            128000,
            "GPT-4 Turbo should have 128k context"
        );
    }

    #[test]
    fn test_gpt4_32k_uses_correct_context() {
        // Test verifies GPT-4 32k variant gets correct context limit
        // Ensures model variant detection works for 32k versions

        // Arrange & Act
        let counter = OpenAITokenCounter::new("gpt-4-32k").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            32768,
            "GPT-4 32k should have 32k context"
        );
    }

    #[test]
    fn test_gpt35_16k_uses_correct_context() {
        // Test verifies GPT-3.5 16k variant gets correct context limit
        // Ensures model variant detection works for 16k versions

        // Arrange & Act
        let counter = OpenAITokenCounter::new("gpt-3.5-turbo-16k").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            16384,
            "GPT-3.5 16k should have 16k context"
        );
    }

    #[test]
    fn test_o1_model_uses_o200k_tokenizer() {
        // Test verifies o1 models use the correct o200k tokenizer
        // Ensures newer OpenAI models get appropriate tokenizer

        // Arrange & Act
        let counter = OpenAITokenCounter::new("o1-preview").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            200000,
            "o1 models should have 200k context"
        );
        assert!(
            counter.count_tokens("test").unwrap() > 0,
            "Should count tokens with o200k tokenizer"
        );
    }

    #[test]
    fn test_message_token_counting_with_tool_calls() {
        // Test verifies tool call arguments are properly counted in message tokens
        // Ensures function calling overhead is accurately tracked

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages_with_tools = vec![serde_json::json!({
            "role": "assistant",
            "content": "",
            "tool_calls": [{
                "function": {
                    "name": "get_weather",
                    "arguments": "{\"location\": \"San Francisco\", \"unit\": \"celsius\"}"
                }
            }]
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages_with_tools).unwrap();

        // Assert
        assert!(
            token_count > 15,
            "Tool calls should add significant token overhead"
        );
    }

    #[test]
    fn test_message_token_counting_with_empty_tool_calls() {
        // Test verifies empty tool_calls array is handled correctly
        // Ensures defensive handling of malformed messages

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = vec![serde_json::json!({
            "role": "assistant",
            "content": "Response",
            "tool_calls": []
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should count message tokens even with empty tool_calls"
        );
    }

    #[test]
    fn test_message_token_counting_with_missing_role() {
        // Test verifies messages without role field default to 'user'
        // Ensures defensive handling of incomplete message structures

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = vec![serde_json::json!({
            "content": "Message without role"
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should handle messages with missing role field"
        );
    }

    #[test]
    fn test_message_token_counting_with_missing_content() {
        // Test verifies messages without content field are handled correctly
        // Ensures defensive handling of tool-only messages

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = vec![serde_json::json!({
            "role": "assistant"
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should count formatting tokens even without content"
        );
    }

    #[test]
    fn test_empty_message_array_token_counting() {
        // Test verifies empty message arrays are handled gracefully
        // Ensures defensive handling of edge cases

        // Arrange
        let counter = create_concrete_openai_counter();
        let empty_messages: Vec<serde_json::Value> = vec![];

        // Act
        let token_count = counter.count_message_tokens(&empty_messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should include base conversation formatting even for empty messages"
        );
    }

    #[test]
    fn test_truncate_already_short_text_returns_unchanged() {
        // Test verifies truncation is no-op for text already within limits
        // Ensures unnecessary processing is avoided

        // Arrange
        let counter = create_concrete_openai_counter();
        let short_text = "Short message";
        let max_tokens = 1000;

        // Act
        let truncated = counter.truncate_to_limit(short_text, max_tokens).unwrap();

        // Assert
        assert_eq!(truncated, short_text, "Short text should remain unchanged");
    }

    #[test]
    fn test_repeated_text_token_counting() {
        // Test verifies repeated patterns are tokenized consistently
        // Ensures tokenizer handles repetitive content correctly

        // Arrange
        let counter = create_concrete_openai_counter();
        let repeated_text = "repeat ".repeat(10);

        // Act
        let token_count = counter.count_tokens(&repeated_text).unwrap();

        // Assert
        assert!(
            token_count > 9,
            "Repeated words should have at least one token each"
        );
        assert!(
            token_count < 50,
            "Should not over-tokenize repeated patterns"
        );
    }

    #[test]
    fn test_message_with_multiple_tool_calls() {
        // Test verifies multiple tool calls are properly counted
        // Ensures complex function calling scenarios are handled

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = vec![serde_json::json!({
            "role": "assistant",
            "content": "",
            "tool_calls": [
                {
                    "function": {
                        "name": "get_weather",
                        "arguments": "{\"location\": \"San Francisco\"}"
                    }
                },
                {
                    "function": {
                        "name": "get_time",
                        "arguments": "{\"timezone\": \"PST\"}"
                    }
                }
            ]
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 20,
            "Multiple tool calls should add significant overhead"
        );
    }

    #[test]
    fn test_message_with_non_array_tool_calls() {
        // Test verifies defensive handling when tool_calls is not an array
        // Ensures robustness against malformed message structures

        // Arrange
        let counter = create_concrete_openai_counter();
        let messages = vec![serde_json::json!({
            "role": "assistant",
            "content": "Response",
            "tool_calls": "not_an_array"
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should handle non-array tool_calls gracefully"
        );
    }

    #[test]
    fn test_very_long_message_array() {
        // Test verifies handling of conversations with many messages
        // Ensures performance with large message histories

        // Arrange
        let counter = create_concrete_openai_counter();
        let mut messages = Vec::new();
        for i in 0..50 {
            messages.push(serde_json::json!({
                "role": if i % 2 == 0 { "user" } else { "assistant" },
                "content": format!("Message {}", i)
            }));
        }

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 100,
            "Long conversation should have significant token count"
        );
    }
}

#[cfg(test)]
mod anthropic_token_counter_tests {
    use super::*;
    use multi_llm::TokenCounter;

    #[test]
    fn test_anthropic_token_counting_with_approximation_factor() {
        // Test verifies Anthropic counter applies appropriate approximation for Claude tokenization
        // Ensures reasonable estimation when Claude-specific tokenizer is not available

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let test_text = "Explain quantum computing in simple terms";

        // Act
        let token_count = counter.count_tokens(test_text).unwrap();

        // Assert
        assert!(token_count > 0, "Should return positive token count");
        // Anthropic counter applies 1.1x multiplier, so should be slightly higher than raw tiktoken
        assert!(token_count >= 7, "Should account for approximation factor");
    }

    #[test]
    fn test_claude_model_context_limits() {
        // Test verifies Claude models have correct context window configurations
        // Ensures model-specific limits match Anthropic's specifications

        // Arrange & Act
        let claude35_counter = AnthropicTokenCounter::new("claude-3-5-sonnet").unwrap();
        let claude3_counter = AnthropicTokenCounter::new("claude-3-opus").unwrap();
        let claude2_counter = AnthropicTokenCounter::new("claude-2").unwrap();

        // Assert
        assert_eq!(
            claude35_counter.max_context_tokens(),
            200000,
            "Claude-3.5 should have 200k context"
        );
        assert_eq!(
            claude3_counter.max_context_tokens(),
            200000,
            "Claude-3 should have 200k context"
        );
        assert_eq!(
            claude2_counter.max_context_tokens(),
            100000,
            "Claude-2 should have 100k context"
        );
    }

    #[test]
    fn test_anthropic_message_token_counting() {
        // Test verifies Anthropic message formatting overhead is correctly calculated
        // Ensures proper token accounting for Claude's conversation format

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let messages = create_test_messages();

        // Act
        let message_tokens = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            message_tokens > 15,
            "Should include message formatting overhead"
        );
        assert!(
            message_tokens < 100,
            "Should not over-estimate simple messages"
        );
    }

    #[test]
    fn test_unknown_anthropic_model_defaults_to_100k_context() {
        // Test verifies unknown Anthropic model names fall back to safe defaults
        // Ensures graceful handling of new Claude models without crashing

        // Arrange & Act
        let counter = AnthropicTokenCounter::new("claude-unknown-version").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            100000,
            "Unknown Claude models should use conservative 100k limit"
        );
        assert!(
            counter.count_tokens("test text").unwrap() > 0,
            "Should still count tokens with default configuration"
        );
    }

    #[test]
    fn test_anthropic_text_truncation_with_approximation() {
        // Test verifies text truncation accounts for Anthropic's approximation factor
        // Ensures truncated text fits within actual Claude token limits

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let long_text = "Claude is an AI assistant created by Anthropic. ".repeat(30);
        let max_tokens = 100u32;

        // Act
        let truncated = counter.truncate_to_limit(&long_text, max_tokens).unwrap();
        let truncated_tokens = counter.count_tokens(&truncated).unwrap();

        // Assert
        assert!(
            truncated_tokens <= max_tokens,
            "Should respect token limit after approximation"
        );
        assert!(
            truncated.len() < long_text.len(),
            "Should actually truncate text"
        );
    }

    #[test]
    fn test_anthropic_validation_accepts_text_within_limit() {
        // Test verifies Anthropic validation passes for reasonable text
        // Ensures normal requests aren't incorrectly rejected

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let reasonable_text = "This is a normal conversation message.";

        // Act
        let result = counter.validate_token_limit(reasonable_text);

        // Assert
        assert!(result.is_ok(), "Normal text should pass validation");
    }

    #[test]
    fn test_anthropic_validation_rejects_oversized_text() {
        // Test verifies Anthropic validation catches text exceeding limits
        // Ensures API errors are prevented before requests

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let massive_text = "word ".repeat(500000); // Way over 200k tokens

        // Act
        let result = counter.validate_token_limit(&massive_text);

        // Assert
        assert!(result.is_err(), "Massive text should fail validation");
    }

    #[test]
    fn test_anthropic_truncate_already_short_text() {
        // Test verifies truncation is no-op for short text
        // Ensures efficiency for common cases

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let short_text = "Brief message";

        // Act
        let truncated = counter.truncate_to_limit(short_text, 1000).unwrap();

        // Assert
        assert_eq!(truncated, short_text, "Short text should remain unchanged");
    }

    #[test]
    fn test_anthropic_message_with_empty_content() {
        // Test verifies empty message content is handled
        // Ensures defensive handling of edge cases

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let messages = vec![serde_json::json!({
            "role": "user",
            "content": ""
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 0,
            "Should count formatting tokens for empty content"
        );
    }

    #[test]
    fn test_anthropic_message_with_missing_content_field() {
        // Test verifies missing content field is handled gracefully
        // Ensures defensive handling of incomplete messages

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let messages = vec![serde_json::json!({
            "role": "assistant"
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(token_count > 0, "Should handle missing content field");
    }

    #[test]
    fn test_anthropic_empty_message_array() {
        // Test verifies empty message array is handled
        // Ensures defensive programming for edge cases

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let empty_messages: Vec<serde_json::Value> = vec![];

        // Act
        let token_count = counter.count_message_tokens(&empty_messages).unwrap();

        // Assert
        assert_eq!(
            token_count, 0,
            "Empty message array should have zero tokens"
        );
    }

    #[test]
    fn test_anthropic_multiple_messages_conversation() {
        // Test verifies multi-turn conversation token counting
        // Ensures proper handling of back-and-forth dialogue

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let messages = vec![
            serde_json::json!({"role": "user", "content": "Hello"}),
            serde_json::json!({"role": "assistant", "content": "Hi there!"}),
            serde_json::json!({"role": "user", "content": "How are you?"}),
            serde_json::json!({"role": "assistant", "content": "I'm doing well, thanks!"}),
        ];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 10,
            "Multi-turn conversation should have significant tokens"
        );
    }

    #[test]
    fn test_anthropic_very_long_content() {
        // Test verifies handling of messages with very long content
        // Ensures no issues with large text blocks

        // Arrange
        let counter = create_concrete_anthropic_counter();
        let long_content = "word ".repeat(1000);
        let messages = vec![serde_json::json!({
            "role": "user",
            "content": long_content
        })];

        // Act
        let token_count = counter.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(
            token_count > 1000,
            "Very long content should have high token count"
        );
    }
}

#[cfg(test)]
mod token_counter_factory_tests {
    use super::*;
    use multi_llm::TokenCounterFactory;

    #[test]
    fn test_factory_creates_correct_counter_types() {
        // Test verifies factory creates appropriate counter types for each provider
        // Ensures proper provider-specific tokenizer selection

        // Arrange & Act
        let openai_counter = TokenCounterFactory::create_counter("openai", "gpt-4").unwrap();
        let anthropic_counter =
            TokenCounterFactory::create_counter("anthropic", "claude-3-5-sonnet").unwrap();
        let lmstudio_counter =
            TokenCounterFactory::create_counter("lmstudio", "local-model").unwrap();

        // Assert
        assert_eq!(
            openai_counter.max_context_tokens(),
            8192,
            "OpenAI counter should have correct limits"
        );
        assert_eq!(
            anthropic_counter.max_context_tokens(),
            200000,
            "Anthropic counter should have correct limits"
        );
        assert_eq!(
            lmstudio_counter.max_context_tokens(),
            4096,
            "LM Studio should use default limit"
        );
    }

    #[test]
    fn test_factory_handles_unsupported_providers() {
        // Test verifies factory returns appropriate errors for unknown providers
        // Ensures clear error messaging for configuration issues

        // Arrange & Act
        let result = TokenCounterFactory::create_counter("unsupported-provider", "some-model");

        // Assert
        assert!(result.is_err(), "Should fail for unsupported provider");
        match result.unwrap_err() {
            LlmError::UnsupportedProvider { provider } => {
                assert_eq!(provider, "unsupported-provider");
            }
            _ => panic!("Should return UnsupportedProvider error"),
        }
    }

    #[test]
    fn test_factory_creates_counters_with_custom_limits() {
        // Test verifies factory supports custom context window sizes
        // Ensures flexibility for models with non-standard context limits

        // Arrange & Act
        let custom_counter =
            TokenCounterFactory::create_counter_with_limit("openai", "gpt-4", 32000).unwrap();

        // Assert
        assert_eq!(
            custom_counter.max_context_tokens(),
            32000,
            "Should use custom limit"
        );
        assert!(
            custom_counter.count_tokens("test").unwrap() > 0,
            "Should function normally"
        );
    }

    #[test]
    fn test_factory_creates_ollama_counter() {
        // Test verifies factory creates counters for Ollama provider
        // Ensures Ollama is properly supported in factory

        // Arrange & Act
        let counter = TokenCounterFactory::create_counter("ollama", "llama2").unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            4096,
            "Ollama should default to 4k context"
        );
    }

    #[test]
    fn test_factory_with_custom_limits_for_anthropic() {
        // Test verifies custom limits work for Anthropic models
        // Ensures flexibility for non-standard model configurations

        // Arrange & Act
        let counter =
            TokenCounterFactory::create_counter_with_limit("anthropic", "claude-3-5-sonnet", 50000)
                .unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            50000,
            "Should use custom limit"
        );
    }

    #[test]
    fn test_factory_with_custom_limits_for_ollama() {
        // Test verifies custom limits work for Ollama models
        // Ensures local model flexibility

        // Arrange & Act
        let counter =
            TokenCounterFactory::create_counter_with_limit("ollama", "mixtral", 32000).unwrap();

        // Assert
        assert_eq!(
            counter.max_context_tokens(),
            32000,
            "Ollama should accept custom limits"
        );
    }

    #[test]
    fn test_factory_case_insensitive_provider_names() {
        // Test verifies factory handles case variations in provider names
        // Ensures user-friendly configuration

        // Arrange & Act
        let uppercase = TokenCounterFactory::create_counter("OPENAI", "gpt-4");
        let lowercase = TokenCounterFactory::create_counter("openai", "gpt-4");
        let mixed = TokenCounterFactory::create_counter("OpenAI", "gpt-4");

        // Assert
        assert!(uppercase.is_ok(), "Should handle uppercase provider names");
        assert!(lowercase.is_ok(), "Should handle lowercase provider names");
        assert!(mixed.is_ok(), "Should handle mixed case provider names");
    }

    #[test]
    fn test_factory_preserves_model_specific_behavior() {
        // Test verifies factory-created counters retain model-specific characteristics
        // Ensures different models within same provider have correct configurations

        // Arrange & Act
        let gpt4_counter = TokenCounterFactory::create_counter("openai", "gpt-4").unwrap();
        let gpt4_turbo_counter =
            TokenCounterFactory::create_counter("openai", "gpt-4-turbo").unwrap();

        // Assert
        assert_eq!(
            gpt4_counter.max_context_tokens(),
            8192,
            "GPT-4 should have 8k limit"
        );
        assert_eq!(
            gpt4_turbo_counter.max_context_tokens(),
            128000,
            "GPT-4 Turbo should have 128k limit"
        );
    }
}

#[cfg(test)]
mod token_management_integration_tests {
    use super::*;
    use multi_llm::TokenCounter;

    #[test]
    fn test_comprehensive_workflow_from_text_to_validation() {
        // Test verifies complete token management workflow for production usage
        // Ensures all components work together correctly for real-world scenarios

        // Arrange
        let counter = create_concrete_openai_counter();
        let user_input = "Please write a detailed explanation of machine learning algorithms, including supervised and unsupervised learning approaches.";

        // Act - Complete token management workflow
        let token_count = counter.count_tokens(user_input).unwrap();
        let validation_result = counter.validate_token_limit(user_input);
        let truncated = counter.truncate_to_limit(user_input, 10).unwrap(); // Use smaller limit to ensure truncation
        let truncated_count = counter.count_tokens(&truncated).unwrap();

        // Assert
        assert!(
            token_count > 15,
            "Complex request should have substantial token count"
        );
        assert!(
            validation_result.is_ok(),
            "Request should pass validation for GPT-4"
        );
        assert!(truncated_count <= 10, "Truncated text should respect limit");
        assert!(!truncated.is_empty(), "Should not truncate to empty");
        assert!(
            truncated.len() < user_input.len(),
            "Should actually truncate"
        );
    }

    #[test]
    fn test_cross_provider_token_counting_consistency() {
        // Test verifies token counting is reasonably consistent across providers
        // Ensures similar inputs produce comparable token estimates

        // Arrange
        let openai_counter = create_concrete_openai_counter();
        let anthropic_counter = create_concrete_anthropic_counter();
        let test_text = "Compare and contrast renewable energy sources";

        // Act
        let openai_tokens = openai_counter.count_tokens(test_text).unwrap();
        let anthropic_tokens = anthropic_counter.count_tokens(test_text).unwrap();

        // Assert
        assert!(
            openai_tokens > 0 && anthropic_tokens > 0,
            "Both should return positive counts"
        );
        // Anthropic includes approximation factor, so should be slightly higher
        assert!(
            anthropic_tokens >= openai_tokens,
            "Anthropic should account for approximation"
        );
        let difference_ratio = anthropic_tokens as f32 / openai_tokens as f32;
        assert!(
            difference_ratio <= 1.5,
            "Approximation should not be excessive"
        );
    }

    #[test]
    fn test_debug_implementation_for_counters() {
        // Test verifies Debug trait is implemented for token counters
        // Ensures counters can be logged and debugged

        // Arrange
        let openai = create_concrete_openai_counter();
        let anthropic = create_concrete_anthropic_counter();

        // Act
        let openai_debug = format!("{:?}", openai);
        let anthropic_debug = format!("{:?}", anthropic);

        // Assert
        assert!(
            openai_debug.contains("OpenAITokenCounter"),
            "Debug should show type"
        );
        assert!(
            anthropic_debug.contains("AnthropicTokenCounter"),
            "Debug should show type"
        );
    }

    #[test]
    fn test_mixed_content_and_empty_messages() {
        // Test verifies handling of conversation with some empty messages
        // Ensures robustness with varied message content

        // Arrange
        let openai = create_concrete_openai_counter();
        let messages = vec![
            serde_json::json!({"role": "user", "content": "Hello"}),
            serde_json::json!({"role": "assistant", "content": ""}),
            serde_json::json!({"role": "user", "content": "Are you there?"}),
        ];

        // Act
        let token_count = openai.count_message_tokens(&messages).unwrap();

        // Assert
        assert!(token_count > 5, "Should count non-empty messages");
    }
}