multi-key 1.1.1

Multikey self-describing cryptographic key data
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
// SPDX-License-Identifier: Apache-2.0
//! XMSS-SHA2_10/16/20_256 stateful hash-based signature multikey view; RFC 8391.
#![allow(dead_code)]
//!
//! XMSS is stateful: every signature consumes a one-time leaf `index` that must
//! never be reused. [`SignView::sign`] embeds the consumed index in the returned
//! [`Multisig`] as [`multi_sig::AttrId::SigIndex`], so the index travels with
//! the signature (e.g. into a provenance log, where monotonicity is enforced).
//!
//! NOTE: this view signs at whatever index the stored secret key currently holds;
//! it does NOT persist the advanced secret key. The authoritative advance-and-
//! persist is owned by the keystore (`bs-keystore`), which calls [`sign_advance`]
//! to obtain both the signature and the advanced secret key in one step.

use crate::{
    AttrId, AttrView, Builder, ConvView, DataView, Error, FingerprintView, Multikey, SignView,
    VerifyView,
    error::{AttributesError, ConversionsError, SignError, VerifyError},
    views::Views,
};
use multi_codec::Codec;
use multi_hash::{Multihash, mh};
use multi_sig::{Views as _, ms};
use zeroize::Zeroizing;

// ---- Inlined bs-xmss wrapper logic ----

mod xmss_wrapper {
    use super::Zeroizing;
    use xmss::{
        DetachedSignature, KeyPair, SigningKey, VerifyingKey, XmssParameter, XmssSha2_10_256,
        XmssSha2_16_256, XmssSha2_20_256,
    };

    const XMSS_OID_LEN: usize = 4;
    const XMSS_INDEX_LEN: usize = 4;

    pub struct XmssSignature {
        pub signature: Vec<u8>,
        pub index: u32,
        pub advanced_secret_key: Zeroizing<Vec<u8>>,
    }

    pub fn current_index(secret_key_bytes: &[u8]) -> Result<u32, String> {
        let end = XMSS_OID_LEN + XMSS_INDEX_LEN;
        if secret_key_bytes.len() < end {
            return Err("xmss secret key too short for index".to_string());
        }
        let mut idx = [0u8; XMSS_INDEX_LEN];
        idx.copy_from_slice(&secret_key_bytes[XMSS_OID_LEN..end]);
        Ok(u32::from_be_bytes(idx))
    }

    fn keypair<P: XmssParameter>() -> Result<(Vec<u8>, Zeroizing<Vec<u8>>), String> {
        let mut kp = KeyPair::<P>::generate(&mut rand::rng()).map_err(|e| e.to_string())?;
        let pk = kp.verifying_key().as_ref().to_vec();
        let sk = Zeroizing::new(kp.signing_key().as_ref().to_vec());
        Ok((pk, sk))
    }

    fn sign<P: XmssParameter>(
        secret_key_bytes: &[u8],
        msg: &[u8],
    ) -> Result<XmssSignature, String> {
        let index = current_index(secret_key_bytes)?;
        let mut sk = SigningKey::<P>::try_from(secret_key_bytes).map_err(|e| e.to_string())?;
        let sig = sk.sign_detached(msg).map_err(|e| e.to_string())?;
        Ok(XmssSignature {
            signature: sig.as_ref().to_vec(),
            index,
            advanced_secret_key: Zeroizing::new(sk.as_ref().to_vec()),
        })
    }

    fn verify<P: XmssParameter>(
        public_key_bytes: &[u8],
        signature_bytes: &[u8],
        msg: &[u8],
    ) -> Result<(), String> {
        let vk = VerifyingKey::<P>::try_from(public_key_bytes).map_err(|e| e.to_string())?;
        let sig = DetachedSignature::<P>::try_from(signature_bytes).map_err(|e| e.to_string())?;
        vk.verify_detached(&sig, msg).map_err(|e| e.to_string())
    }

    fn public_from_private<P: XmssParameter>(secret_key_bytes: &[u8]) -> Result<Vec<u8>, String> {
        let sk = SigningKey::<P>::try_from(secret_key_bytes).map_err(|e| e.to_string())?;
        Ok(VerifyingKey::<P>::from(&sk).as_ref().to_vec())
    }

    macro_rules! param_api {
        ($param:ty, $kp:ident, $sign:ident, $verify:ident, $pfp:ident) => {
            pub fn $kp() -> Result<(Vec<u8>, Zeroizing<Vec<u8>>), String> {
                keypair::<$param>()
            }
            pub fn $sign(s: &[u8], m: &[u8]) -> Result<XmssSignature, String> {
                sign::<$param>(s, m)
            }
            pub fn $verify(p: &[u8], s: &[u8], m: &[u8]) -> Result<(), String> {
                verify::<$param>(p, s, m)
            }
            pub fn $pfp(s: &[u8]) -> Result<Vec<u8>, String> {
                public_from_private::<$param>(s)
            }
        };
    }

    param_api!(
        XmssSha2_10_256,
        keypair_10,
        sign_10,
        verify_10,
        public_from_private_10
    );
    param_api!(
        XmssSha2_16_256,
        keypair_16,
        sign_16,
        verify_16,
        public_from_private_16
    );
    param_api!(
        XmssSha2_20_256,
        keypair_20,
        sign_20,
        verify_20,
        public_from_private_20
    );
}

fn is_xmss_priv(codec: Codec) -> bool {
    matches!(
        codec,
        Codec::XmssSha210256Priv | Codec::XmssSha216256Priv | Codec::XmssSha220256Priv
    )
}

fn is_xmss_pub(codec: Codec) -> bool {
    matches!(
        codec,
        Codec::XmssSha210256Pub | Codec::XmssSha216256Pub | Codec::XmssSha220256Pub
    )
}

fn public_codec(codec: Codec) -> Result<Codec, Error> {
    match codec {
        Codec::XmssSha210256Priv => Ok(Codec::XmssSha210256Pub),
        Codec::XmssSha216256Priv => Ok(Codec::XmssSha216256Pub),
        Codec::XmssSha220256Priv => Ok(Codec::XmssSha220256Pub),
        _ => Err(ConversionsError::SecretKeyFailure("not an XMSS private key".into()).into()),
    }
}

fn msig_codec(codec: Codec) -> Result<Codec, Error> {
    match codec {
        Codec::XmssSha210256Priv => Ok(Codec::XmssSha210256Msig),
        Codec::XmssSha216256Priv => Ok(Codec::XmssSha216256Msig),
        Codec::XmssSha220256Priv => Ok(Codec::XmssSha220256Msig),
        _ => Err(SignError::NotSigningKey.into()),
    }
}

fn public_from_private(codec: Codec, secret_bytes: &[u8]) -> Result<Vec<u8>, Error> {
    match codec {
        Codec::XmssSha210256Priv => xmss_wrapper::public_from_private_10(secret_bytes),
        Codec::XmssSha216256Priv => xmss_wrapper::public_from_private_16(secret_bytes),
        Codec::XmssSha220256Priv => xmss_wrapper::public_from_private_20(secret_bytes),
        _ => {
            return Err(
                ConversionsError::SecretKeyFailure("not an XMSS private key".into()).into(),
            );
        }
    }
    .map_err(|e| ConversionsError::SecretKeyFailure(e).into())
}

fn keypair(codec: Codec) -> Result<(Vec<u8>, Zeroizing<Vec<u8>>), Error> {
    match codec {
        Codec::XmssSha210256Priv => xmss_wrapper::keypair_10(),
        Codec::XmssSha216256Priv => xmss_wrapper::keypair_16(),
        Codec::XmssSha220256Priv => xmss_wrapper::keypair_20(),
        _ => {
            return Err(
                ConversionsError::SecretKeyFailure("not an XMSS private key".into()).into(),
            );
        }
    }
    .map_err(|e| ConversionsError::SecretKeyFailure(e).into())
}

fn sign_bytes(
    codec: Codec,
    secret_bytes: &[u8],
    msg: &[u8],
) -> Result<xmss_wrapper::XmssSignature, Error> {
    match codec {
        Codec::XmssSha210256Priv => xmss_wrapper::sign_10(secret_bytes, msg),
        Codec::XmssSha216256Priv => xmss_wrapper::sign_16(secret_bytes, msg),
        Codec::XmssSha220256Priv => xmss_wrapper::sign_20(secret_bytes, msg),
        _ => return Err(SignError::NotSigningKey.into()),
    }
    .map_err(|e| SignError::SigningFailed(e).into())
}

fn verify_bytes(codec: Codec, pub_bytes: &[u8], sig_bytes: &[u8], msg: &[u8]) -> Result<(), Error> {
    match codec {
        Codec::XmssSha210256Pub => xmss_wrapper::verify_10(pub_bytes, sig_bytes, msg),
        Codec::XmssSha216256Pub => xmss_wrapper::verify_16(pub_bytes, sig_bytes, msg),
        Codec::XmssSha220256Pub => xmss_wrapper::verify_20(pub_bytes, sig_bytes, msg),
        _ => return Err(VerifyError::BadSignature("not an XMSS public key".into()).into()),
    }
    .map_err(|e| VerifyError::BadSignature(e).into())
}

/// Build a [`Multisig`](multi_sig::Multisig) from a computed XMSS signature,
/// embedding the consumed leaf index as [`AttrId::SigIndex`](multi_sig::AttrId::SigIndex).
fn build_multisig(
    priv_codec: Codec,
    sig: &xmss_wrapper::XmssSignature,
    msg: &[u8],
    combined: bool,
) -> Result<multi_sig::Multisig, Error> {
    let mut ms = ms::Builder::new(msig_codec(priv_codec)?)
        .with_signature_bytes(&sig.signature)
        .with_sig_index(sig.index);
    if combined {
        ms = ms.with_message_bytes(&msg);
    }
    Ok(ms.try_build()?)
}

/// Sign `msg`, returning the [`Multisig`](multi_sig::Multisig) AND the advanced
/// secret key bytes. The caller (keystore) MUST persist the advanced key so the
/// consumed leaf index is never reused.
///
/// Returns an error if the multikey is not an XMSS secret key.
pub fn sign_advance(
    mk: &Multikey,
    msg: &[u8],
    combined: bool,
) -> Result<(multi_sig::Multisig, Zeroizing<Vec<u8>>), Error> {
    let attr = mk.attr_view()?;
    if !attr.is_secret_key() || !is_xmss_priv(mk.codec) {
        return Err(SignError::NotSigningKey.into());
    }
    let secret_bytes = {
        let kd = mk.data_view()?;
        kd.secret_bytes()?
    };
    let sig = sign_bytes(mk.codec, secret_bytes.as_slice(), msg)?;
    let ms = build_multisig(mk.codec, &sig, msg, combined)?;
    Ok((ms, sig.advanced_secret_key.clone()))
}

pub(crate) struct View<'a> {
    mk: &'a Multikey,
}

impl<'a> TryFrom<&'a Multikey> for View<'a> {
    type Error = Error;

    fn try_from(mk: &'a Multikey) -> Result<Self, Self::Error> {
        Ok(Self { mk })
    }
}

impl<'a> AttrView for View<'a> {
    fn is_encrypted(&self) -> bool {
        false
    }
    fn is_secret_key(&self) -> bool {
        is_xmss_priv(self.mk.codec)
    }
    fn is_public_key(&self) -> bool {
        is_xmss_pub(self.mk.codec)
    }
    fn is_secret_key_share(&self) -> bool {
        false
    }
}

impl<'a> DataView for View<'a> {
    fn key_bytes(&self) -> Result<Zeroizing<Vec<u8>>, Error> {
        let key = self
            .mk
            .attributes
            .get(&AttrId::KeyData)
            .ok_or(AttributesError::MissingKey)?;
        Ok(key.clone())
    }
    fn secret_bytes(&self) -> Result<Zeroizing<Vec<u8>>, Error> {
        if !self.is_secret_key() {
            return Err(AttributesError::NotSecretKey(self.mk.codec).into());
        }
        self.key_bytes()
    }
}

impl<'a> ConvView for View<'a> {
    fn to_public_key(&self) -> Result<Multikey, Error> {
        let secret_bytes = {
            let kd = self.mk.data_view()?;
            kd.secret_bytes()?
        };
        let pub_bytes = public_from_private(self.mk.codec, secret_bytes.as_slice())?;
        Builder::new(public_codec(self.mk.codec)?)
            .with_comment(&self.mk.comment)
            .with_key_bytes(&pub_bytes)
            .try_build()
    }

    fn to_ssh_public_key(&self) -> Result<ssh_key::PublicKey, Error> {
        Err(
            ConversionsError::UnsupportedAlgorithm("XMSS not supported in SSH key format".into())
                .into(),
        )
    }
    fn to_ssh_private_key(&self) -> Result<ssh_key::PrivateKey, Error> {
        Err(
            ConversionsError::UnsupportedAlgorithm("XMSS not supported in SSH key format".into())
                .into(),
        )
    }
}

impl<'a> FingerprintView for View<'a> {
    fn fingerprint(&self, codec: Codec) -> Result<Multihash, Error> {
        let pub_bytes = if self.is_secret_key() {
            let pk = self.to_public_key()?;
            let dv = pk.data_view()?;
            dv.key_bytes()?
        } else {
            self.key_bytes()?
        };
        Ok(mh::Builder::new_from_bytes(codec, pub_bytes.as_slice())?.try_build()?)
    }
}

impl<'a> SignView for View<'a> {
    fn sign(
        &self,
        msg: &[u8],
        combined: bool,
        _scheme: Option<u8>,
    ) -> Result<multi_sig::Multisig, Error> {
        let attr = self.mk.attr_view()?;
        if !attr.is_secret_key() {
            return Err(SignError::NotSigningKey.into());
        }
        let secret_bytes = {
            let kd = self.mk.data_view()?;
            kd.secret_bytes()?
        };
        let sig = sign_bytes(self.mk.codec, secret_bytes.as_slice(), msg)?;
        build_multisig(self.mk.codec, &sig, msg, combined)
    }
}

impl<'a> VerifyView for View<'a> {
    fn verify(&self, sig: &multi_sig::Multisig, msg: Option<&[u8]>) -> Result<(), Error> {
        let msg_bytes = if let Some(m) = msg {
            m
        } else if !sig.message.is_empty() {
            sig.message.as_slice()
        } else {
            return Err(VerifyError::MissingMessage.into());
        };

        let attr = self.mk.attr_view()?;
        let pubmk = if attr.is_secret_key() {
            let kc = self.mk.conv_view()?;
            kc.to_public_key()?
        } else {
            self.mk.clone()
        };

        let key_bytes = {
            let kd = pubmk.data_view()?;
            kd.key_bytes()?
        };
        let sv = sig.data_view()?;
        let sig_bytes = sv.sig_bytes()?;

        verify_bytes(pubmk.codec, key_bytes.as_slice(), &sig_bytes, msg_bytes)
    }
}

pub(crate) fn generate_private_key(codec: Codec) -> Result<Zeroizing<Vec<u8>>, Error> {
    let (_pk, sk) = keypair(codec)?;
    Ok(sk)
}

#[cfg(test)]
mod tests {
    #[cfg(feature = "slow-tests")]
    use super::*;
    #[cfg(feature = "slow-tests")]
    use crate::Builder;

    #[cfg(feature = "slow-tests")]
    #[test]
    fn test_xmss_sign_verify_and_index() {
        // Only h=10 is exercised: h=16/20 keygen builds a 2^h Merkle tree (minutes).
        let mut rng = rand::rng();
        let sk = Builder::new_from_random_bytes(Codec::XmssSha210256Priv, &mut rng)
            .unwrap()
            .try_build()
            .unwrap();
        let pk = sk.conv_view().unwrap().to_public_key().unwrap();

        let msg = b"provenance entry bytes";
        let ms = sk.sign_view().unwrap().sign(msg, false, None).unwrap();
        // the consumed leaf index (0) travels with the signature
        assert_eq!(ms.sig_index(), Some(0));

        // verify with the public key and with the secret key's derived public key
        pk.verify_view().unwrap().verify(&ms, Some(msg)).unwrap();
        sk.verify_view().unwrap().verify(&ms, Some(msg)).unwrap();

        // wrong message must fail
        assert!(
            pk.verify_view()
                .unwrap()
                .verify(&ms, Some(b"tampered"))
                .is_err()
        );
    }

    #[cfg(feature = "slow-tests")]
    #[test]
    fn test_xmss_sign_advance_persists_index() {
        let mut rng = rand::rng();
        let sk = Builder::new_from_random_bytes(Codec::XmssSha210256Priv, &mut rng)
            .unwrap()
            .try_build()
            .unwrap();

        let (ms0, advanced) = sign_advance(&sk, b"first", false).unwrap();
        assert_eq!(ms0.sig_index(), Some(0));
        // advanced secret key now points at index 1
        assert_eq!(xmss_wrapper::current_index(&advanced).unwrap(), 1);
    }
}