1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
use std::collections::{HashMap, HashSet};
use anyhow::anyhow;
use log::{debug, error};
use mt_net::{ActionPlan, COMPARE_NODE_NAME, Rules};
use crate::{
NetworkShipAddress, ShipName,
net::{Packet, PacketKind, WindAt},
};
#[derive(Clone, Debug)]
pub struct ClientInfo {
pub id: ShipName,
pub network: NetworkShipAddress,
pub queue: tokio::sync::broadcast::Sender<String>,
pub sender: tokio::sync::mpsc::Sender<Packet>,
}
pub struct CoordinatorImpl {
pub sea: crate::net::Sea,
pub rat_qs: std::sync::Arc<tokio::sync::RwLock<HashMap<String, ClientInfo>>>,
pub new_rat_note: tokio::sync::broadcast::Sender<String>,
pub new_client_notify: tokio::sync::broadcast::Sender<String>,
/// (ship_name, var_name) pairs that registered as BE subscribers
pub be_subscriptions: std::sync::Arc<std::sync::RwLock<HashSet<(String, String)>>>,
/// Variable names that have at least one best-effort publisher
pub be_publisher_vars: std::sync::Arc<std::sync::RwLock<HashSet<String>>>,
}
#[async_trait::async_trait]
impl crate::Coordinator for CoordinatorImpl {
/// Get a channel that only returns the variable from this rat
async fn rat_action_request_queue(
&self,
ship: String,
) -> anyhow::Result<tokio::sync::broadcast::Receiver<String>> {
debug!("trying to get request queue");
// Subscribe BEFORE checking the map to avoid race condition
// where client is added between check and subscribe
let mut notify = self.new_client_notify.subscribe();
loop {
if let Some(client_info) = self.rat_qs.read().await.get(&ship) {
return Ok(client_info.queue.subscribe());
}
// Wait for a new client notification
loop {
match notify.recv().await {
Ok(name) if name == ship => break,
Ok(_) => continue,
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {
// Re-check the map in case we missed notifications
break;
}
Err(_) => return Err(anyhow!("Client notification channel closed")),
}
}
}
}
async fn blow_wind(&self, ship: String, data: Vec<crate::WindData>) -> anyhow::Result<()> {
// Subscribe BEFORE checking the map to avoid race condition
let mut notify = self.new_client_notify.subscribe();
loop {
if let Some(client_info) = self.rat_qs.read().await.get(&ship) {
let paket = Packet {
header: crate::net::Header::default(),
data: PacketKind::Wind(
data.into_iter()
.map(|wd| WindAt {
data: wd,
at_var: None,
})
.collect::<Vec<_>>(),
),
};
return client_info
.sender
.send(paket)
.await
.map_err(|e| anyhow!("Error while sending wind: {e}"));
}
// Wait for client to connect
loop {
match notify.recv().await {
Ok(name) if name == ship => break,
Ok(_) => continue,
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {
// Re-check the map in case we missed notifications
break;
}
Err(_) => return Err(anyhow!("Client notification channel closed")),
}
}
}
}
async fn push_routes_for_var(&self, variable: &str, rules: &Rules) -> anyhow::Result<()> {
let ships = rules.all_ships_for_var(variable);
// Pre-compute all ship→actions before any .await so we don't hold a lock across awaits.
let ship_actions: Vec<(String, Vec<ActionPlan>)> = ships
.into_iter()
.map(|ship| {
let actions = crate::get_strategies(rules, &ship, variable.to_string(), None);
(ship, actions)
})
.collect();
for (ship, actions) in ship_actions {
if ship == COMPARE_NODE_NAME {
continue; // #minot gets its Catch route via VariableTaskRequest → SendRatAction
}
for action_plan in actions {
match self.convert_action(&action_plan, variable).await {
Ok(action) => {
let packet = Packet {
header: crate::net::Header::default(),
data: PacketKind::RatAction {
variable: variable.to_string(),
action,
lock_until_ack: false,
},
};
// Best-effort: skip if ship not connected
if let Some(ci) = self.rat_qs.read().await.get(&ship).cloned() {
let _ = ci.sender.send(packet).await;
}
}
Err(e) => {
debug!(
"push_routes_for_var: cannot convert action for {}: {}",
ship, e
);
}
}
}
}
Ok(())
}
async fn rat_action_send(
&self,
ship: String,
variable: String,
action: ActionPlan,
lock_until_ack: bool,
best_effort: bool,
) -> anyhow::Result<()> {
if best_effort {
// Try-once: send if connected, silently skip if not
if let Some(ci) = self.rat_qs.read().await.get(&ship).cloned() {
let action = self.convert_action(&action, &variable).await?;
let paket = Packet {
header: crate::net::Header::default(),
data: PacketKind::RatAction {
variable,
action,
lock_until_ack,
},
};
let _ = ci.sender.send(paket).await;
}
return Ok(());
}
// Subscribe BEFORE checking the map to avoid race condition
let mut notify = self.new_client_notify.subscribe();
loop {
let client_info = {
let client_guard = self.rat_qs.read().await;
client_guard.get(&ship).cloned()
};
if let Some(client_info) = client_info {
let action = self.convert_action(&action, &variable).await?;
let paket = Packet {
header: crate::net::Header::default(),
data: PacketKind::RatAction {
variable,
action,
lock_until_ack,
},
};
return client_info
.sender
.send(paket)
.await
.map_err(|e| anyhow!("Error while sending rat action: {e}"));
}
// Wait for client to connect
loop {
match notify.recv().await {
Ok(name) if name == ship => break,
Ok(_) => continue,
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {
// Re-check the map in case we missed notifications
break;
}
Err(_) => return Err(anyhow!("Client notification channel closed")),
}
}
}
}
}
impl CoordinatorImpl {
pub async fn rat_send(&self, ship: String, kind: PacketKind) -> anyhow::Result<()> {
// Subscribe BEFORE checking the map to avoid race condition
let mut notify = self.new_client_notify.subscribe();
loop {
if let Some(client_info) = self.rat_qs.read().await.get(&ship) {
let paket = Packet {
header: crate::net::Header::default(),
data: kind,
};
return client_info
.sender
.send(paket)
.await
.map_err(|e| anyhow!("Error while sending: {e}"));
}
// Wait for client to connect
loop {
match notify.recv().await {
Ok(name) if name == ship => break,
Ok(_) => continue,
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {
// Re-check the map in case we missed notifications
break;
}
Err(_) => return Err(anyhow!("Client notification channel closed")),
}
}
}
}
/// Wait until all given clients are connected (deterministic, no timing)
pub async fn ensure_clients_connected(
rats: std::sync::Arc<tokio::sync::RwLock<HashMap<String, ClientInfo>>>,
clients: HashSet<String>,
notify: tokio::sync::broadcast::Sender<String>,
) {
let mut remaining: HashSet<String> = clients
.into_iter()
.filter(|c| c != COMPARE_NODE_NAME)
.collect();
// First check what's already connected
{
let rat = rats.read().await;
remaining.retain(|client| !rat.contains_key(client));
}
if remaining.is_empty() {
return;
}
// Wait for remaining clients
let mut sub = notify.subscribe();
while !remaining.is_empty() {
match sub.recv().await {
Ok(name) => {
remaining.remove(&name);
}
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => {
// Re-check current state
let rat = rats.read().await;
remaining.retain(|client| !rat.contains_key(client));
}
Err(_) => {
// Channel closed - check if all connected
let rat = rats.read().await;
remaining.retain(|client| !rat.contains_key(client));
if remaining.is_empty() {
return;
}
log::warn!(
"Client notification channel closed with {} clients remaining",
remaining.len()
);
return;
}
}
}
}
/// Wait until the given ship appears in `rat_qs`.
/// Returns immediately if already present.
pub async fn wait_for_client(&self, ship: &str) {
// Subscribe BEFORE checking the map to avoid the race where the ship
// is inserted between our map-check and the subscribe.
let mut notify = self.new_client_notify.subscribe();
loop {
if self.rat_qs.read().await.contains_key(ship) {
return;
}
loop {
match notify.recv().await {
Ok(name) if name == ship => return,
Ok(_) => continue,
Err(tokio::sync::broadcast::error::RecvError::Lagged(_)) => break,
Err(_) => return,
}
}
}
}
async fn convert_action(
&self,
human_action: &ActionPlan,
variable: &str,
) -> anyhow::Result<crate::Action> {
let action = match human_action {
ActionPlan::Sail => crate::Action::Sail,
ActionPlan::Shoot { target, id } => {
let mut targets = Vec::with_capacity(target.len());
for client_name in target.iter() {
let rat = self.rat_qs.read().await;
let client_info = rat
.get(client_name)
.ok_or_else(|| anyhow!("Unknown client: {}", client_name))?;
let mut addr = client_info.network.clone();
// Override with per-subscription BE mode if registered
if self
.be_subscriptions
.read()
.unwrap()
.contains(&(client_name.clone(), variable.to_string()))
{
addr.node_mode = crate::net::Qos::BestEffort;
}
targets.push(addr);
}
crate::Action::Shoot {
target: targets,
id: *id,
}
}
ActionPlan::Catch { source, id } => {
let rat = self.rat_qs.read().await;
let client_info = rat.get(source).ok_or_else(|| anyhow!("Unknown client."))?;
crate::Action::Catch {
source: client_info.network.clone(),
id: *id,
}
}
};
Ok(action)
}
pub async fn new(
external_ip: Option<[u8; 4]>,
clients_wait_for_ack: std::sync::Arc<std::sync::RwLock<bool>>,
) -> Self {
let sea = crate::net::Sea::init(external_ip, clients_wait_for_ack).await;
let rat_queues = std::sync::Arc::new(tokio::sync::RwLock::new(HashMap::new()));
let (new_rat_note, _) = tokio::sync::broadcast::channel::<String>(128);
let (new_client_notify, _) = tokio::sync::broadcast::channel::<String>(128);
let mut incoming_clients = sea.network_clients_chan.subscribe();
let inner_client_rat_queues = rat_queues.clone();
let notify_tx = new_client_notify.clone();
tokio::spawn(async move {
let inner_client_loop_rat_queues = inner_client_rat_queues.clone();
loop {
match incoming_clients.recv().await {
Err(tokio::sync::broadcast::error::RecvError::Lagged(n)) => {
log::warn!("Coordinator missed {} client events due to channel lag", n);
continue;
}
Err(e) => {
error!("Coordinator missed clients: {e}");
}
Ok(client) => {
let (rat_queue_tx, _) = tokio::sync::broadcast::channel(256);
let client_info = ClientInfo {
id: client.ship,
queue: rat_queue_tx,
sender: client.send,
network: client.addr_from_coord,
};
let name = match client.name {
crate::ShipKind::Rat(name) => name,
crate::ShipKind::Wind(name) => name,
};
{
inner_client_loop_rat_queues
.write()
.await
.insert(name.clone(), client_info);
}
// Notify waiters that a new client connected
let _ = notify_tx.send(name.clone());
debug!("Client {} connected", name);
}
}
}
});
Self {
sea,
rat_qs: rat_queues,
new_rat_note,
new_client_notify,
be_subscriptions: std::sync::Arc::new(std::sync::RwLock::new(HashSet::new())),
be_publisher_vars: std::sync::Arc::new(std::sync::RwLock::new(HashSet::new())),
}
}
}