mpl-lang 0.4.0

Axioms Metrics Processing Language
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203

use super::detect_hints;
use crate::wasm::diagnostics::Severity;

// ── filter keyword hint ─────────────────────────────────────────

#[test]
fn filter_hint() {
    let query = "ds:metric | filter tag == \"x\"";
    let items = detect_hints(query);
    assert_eq!(items.len(), 1);
    assert!(matches!(items[0].severity, Severity::Hint));
    assert_eq!(items[0].actions.len(), 1);
    assert_eq!(items[0].actions[0].insert, "where");
    assert_eq!(&query[items[0].span.from..items[0].span.to], "filter");
}

#[test]
fn where_no_hint() {
    let query = "ds:metric | where tag == \"x\"";
    let items = detect_hints(query);
    assert!(items.is_empty(), "should not suggest for `where`");
}

#[test]
fn filter_hint_multiple() {
    let query = "ds:metric | filter a == \"1\" | filter b == \"2\"";
    let items = detect_hints(query);
    assert_eq!(items.len(), 2, "should detect both `filter` keywords");
}

#[test]
fn filter_hint_mixed_where_and_filter() {
    let query = "ds:metric | where a == \"1\" | filter b == \"2\"";
    let items = detect_hints(query);
    assert_eq!(items.len(), 1, "should only flag the `filter` keyword");
    assert_eq!(&query[items[0].span.from..items[0].span.to], "filter");
}

/// `filter` inside an `ifdef` body is still the deprecated alias and must
/// produce the same hint as anywhere else. Locks in the canonical-form
/// invariant: the ifdef body always reads as `where`, never `filter`.
#[test]
fn filter_hint_inside_ifdef_body() {
    let query = "param $f: Option<string>;\nds:metric | ifdef($f) { filter tag == $f }";
    let items = detect_hints(query);
    let filter_hints: Vec<_> = items
        .iter()
        .filter(|i| i.message.contains("filter"))
        .collect();
    assert_eq!(filter_hints.len(), 1, "filter inside ifdef should hint");
    assert_eq!(filter_hints[0].actions[0].insert, "where");
    assert_eq!(
        &query[filter_hints[0].span.from..filter_hints[0].span.to],
        "filter"
    );
}

// ── unnecessary escape lint ──────────────────────────────────────

#[test]
fn unnecessary_escape_plain_tag() {
    let query = "ds:metric | filter `tag` == \"x\"";
    let items = detect_hints(query);
    let escape_hints: Vec<_> = items
        .iter()
        .filter(|i| i.message.contains("backtick"))
        .collect();
    assert_eq!(escape_hints.len(), 1);
    assert!(matches!(escape_hints[0].severity, Severity::Hint));
    assert_eq!(escape_hints[0].actions.len(), 1);
    assert_eq!(escape_hints[0].actions[0].insert, "tag");
    assert_eq!(
        &query[escape_hints[0].span.from..escape_hints[0].span.to],
        "`tag`"
    );
}

#[test]
fn no_unnecessary_escape_for_hyphenated() {
    let query = "ds:metric | filter `my-tag` == \"x\"";
    let items = detect_hints(query);
    assert!(
        !items.iter().any(|i| i.message.contains("backtick")),
        "hyphenated ident needs escaping"
    );
}

#[test]
fn no_unnecessary_escape_for_leading_digit() {
    let query = "ds:metric | filter `0abc` == \"x\"";
    let items = detect_hints(query);
    assert!(
        !items.iter().any(|i| i.message.contains("backtick")),
        "leading-digit ident needs escaping"
    );
}

#[test]
fn no_unnecessary_escape_for_dotted() {
    let query = "ds:metric | filter `my_tag.name` == \"x\"";
    let items = detect_hints(query);
    assert!(
        !items.iter().any(|i| i.message.contains("backtick")),
        "dotted ident needs escaping"
    );
}

#[test]
fn unnecessary_escape_multiple() {
    let query = "ds:metric | filter `a` == \"1\" and `b` == \"2\"";
    let items = detect_hints(query);
    let escape_hints: Vec<_> = items
        .iter()
        .filter(|i| i.message.contains("backtick"))
        .collect();
    assert_eq!(escape_hints.len(), 2, "should flag both escaped idents");
}

// ── lowercase duration hint ──────────────────────────────────────

#[test]
fn lowercase_duration_warns() {
    let query = "param $t: duration;\nds:metric | align to $t over 5m using sum";
    let items = detect_hints(query);
    let duration_hints: Vec<_> = items
        .iter()
        .filter(|i| i.message.contains("Duration"))
        .collect();
    assert_eq!(duration_hints.len(), 1);
    assert!(matches!(duration_hints[0].severity, Severity::Warning));
    assert_eq!(duration_hints[0].actions.len(), 1);
    assert_eq!(duration_hints[0].actions[0].insert, "Duration");
    assert_eq!(
        &query[duration_hints[0].span.from..duration_hints[0].span.to],
        "duration"
    );
}

#[test]
fn uppercase_duration_no_hint() {
    let query = "param $t: Duration;\nds:metric | align to $t over 5m using sum";
    let items = detect_hints(query);
    assert!(
        !items.iter().any(|i| i.message.contains("Duration")),
        "uppercase Duration should not produce a lint"
    );
}

#[test]
fn lowercase_duration_fix_span_correct() {
    // Verify the action span covers exactly the `duration` token.
    let query = "param $t: duration;\nds:metric | align to $t over 5m using sum";
    let items = detect_hints(query);
    let hint = items
        .iter()
        .find(|i| i.message.contains("Duration"))
        .expect("expected a Duration hint");
    let action = &hint.actions[0];
    // The action span should replace the exact token.
    assert_eq!(&query[action.span.from..action.span.to], "duration");
    assert_eq!(action.insert, "Duration");
}

#[test]
fn multiple_lowercase_duration_params() {
    let query =
        "param $t: duration;\nparam $u: duration;\n$dataset:metric | align to $t over $u using sum";
    let items = detect_hints(query);
    let duration_hints: Vec<_> = items
        .iter()
        .filter(|i| i.message.contains("Duration"))
        .collect();
    assert_eq!(duration_hints.len(), 2, "should warn for each occurrence");
}

// ── dataset given, no metric ─────────────────────────────────────

#[test]
fn no_hints_dataset_colon_no_metric() {
    assert!(detect_hints("ds:").is_empty());
}

#[test]
fn no_hints_dataset_no_colon() {
    assert!(detect_hints("ds").is_empty());
}

#[test]
fn no_hints_dataset_no_metric_with_filter() {
    // `filter` keyword would normally produce a hint, but parse fails
    // so no hints are emitted
    assert!(detect_hints("ds: | filter tag == \"x\"").is_empty());
}

#[test]
fn no_hints_dataset_no_colon_with_filter() {
    assert!(detect_hints("ds | filter tag == \"x\"").is_empty());
}

#[test]
fn no_hints_backtick_dataset_no_metric_with_where() {
    assert!(detect_hints("`my-dataset`: | where tag == \"x\"").is_empty());
}