mp3rgain 3.6.1

Lossless MP3 volume adjustment - a modern mp3gain replacement written in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
use anyhow::Result;
use colored::*;
use mp3rgain::replaygain::AnalysisMode;
use mp3rgain::{Channel, TagLayout};
use std::path::PathBuf;

use super::options::{Options, OutputFormat, StoredTagMode};
use super::usage::{print_usage, print_version};

fn parse_thread_count(value: &str, flag: &str) -> Result<usize> {
    value
        .parse()
        .map_err(|_| anyhow::anyhow!("invalid {} value: {}", flag, value))
}

pub fn parse_args(args: &[String]) -> Result<Options> {
    let mut opts = Options::default();
    let mut i = 0;

    while i < args.len() {
        let arg = &args[i];

        if arg == "--dry-run" {
            opts.dry_run = true;
            i += 1;
            continue;
        }

        if arg == "--skip-errors" {
            opts.skip_errors = true;
            i += 1;
            continue;
        }

        if arg == "--per-directory" {
            opts.per_directory = true;
            i += 1;
            continue;
        }

        if arg == "--rg2" {
            if opts.analysis_mode == AnalysisMode::R128 {
                anyhow::bail!("--rg2 and --r128 are mutually exclusive");
            }
            opts.analysis_mode = AnalysisMode::Rg2;
            i += 1;
            continue;
        }

        if arg == "--r128" {
            if opts.analysis_mode == AnalysisMode::Rg2 {
                anyhow::bail!("--rg2 and --r128 are mutually exclusive");
            }
            opts.analysis_mode = AnalysisMode::R128;
            i += 1;
            continue;
        }

        if arg == "--true-peak" {
            opts.true_peak = true;
            i += 1;
            continue;
        }

        if arg == "--tags-only" {
            opts.tags_only = true;
            i += 1;
            continue;
        }

        if arg == "--help" {
            print_usage();
            std::process::exit(0);
        }

        if arg == "--version" {
            print_version();
            std::process::exit(0);
        }

        if arg == "--threads" {
            i += 1;
            if i >= args.len() {
                anyhow::bail!("--threads requires an argument");
            }
            opts.threads = Some(parse_thread_count(&args[i], "--threads")?);
            i += 1;
            continue;
        }

        if let Some(rest) = arg.strip_prefix("--threads=") {
            opts.threads = Some(parse_thread_count(rest, "--threads")?);
            i += 1;
            continue;
        }

        if arg.starts_with('-') && arg.len() > 1 && !arg.starts_with("--") {
            let flag = &arg[1..];

            match flag {
                "g" => {
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-g requires an argument");
                    }
                    opts.gain_steps = Some(
                        args[i]
                            .parse()
                            .map_err(|_| anyhow::anyhow!("invalid gain value: {}", args[i]))?,
                    );
                }
                "d" => {
                    // mp3gain compatible: -d modifies the suggested dB gain
                    // (adjusts target level relative to 89 dB reference)
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-d requires an argument");
                    }
                    opts.gain_modifier_db = args[i]
                        .parse()
                        .map_err(|_| anyhow::anyhow!("invalid dB value: {}", args[i]))?;
                }
                "m" => {
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-m requires an argument");
                    }
                    opts.gain_modifier = args[i]
                        .parse()
                        .map_err(|_| anyhow::anyhow!("invalid modifier value: {}", args[i]))?;
                }
                "s" => {
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-s requires an argument");
                    }
                    match args[i].as_str() {
                        "c" => opts.stored_tag_mode = StoredTagMode::Check,
                        "d" => opts.stored_tag_mode = StoredTagMode::Delete,
                        "s" => opts.stored_tag_mode = StoredTagMode::Skip,
                        // mp3gain compatibility: recalculation is mp3rgain's
                        // default, so "force recalculation" only matters as an
                        // override of -s R. Accepted with a notice (#253).
                        "r" => opts.force_recalc = true,
                        // Reuse stored tags, rescan only when missing (#298).
                        "R" => opts.use_stored_tags = true,
                        "i" => opts.tag_layout = TagLayout::Id3v2,
                        "a" => opts.tag_layout = TagLayout::Ape,
                        other => {
                            anyhow::bail!("unknown -s mode '{}', use c/d/s/r/R/i/a", other);
                        }
                    }
                }
                "o" => {
                    // mp3gain compatibility: -o without argument means TSV output
                    // Check if next arg is a valid format specifier
                    let next_is_format = if i + 1 < args.len() {
                        matches!(
                            args[i + 1].to_lowercase().as_str(),
                            "json" | "text" | "tsv" | "db"
                        )
                    } else {
                        false
                    };

                    if next_is_format {
                        i += 1;
                        match args[i].to_lowercase().as_str() {
                            "json" => opts.output_format = OutputFormat::Json,
                            "text" => opts.output_format = OutputFormat::Text,
                            "tsv" | "db" => opts.output_format = OutputFormat::Tsv,
                            _ => unreachable!(),
                        }
                    } else {
                        // mp3gain compatible: -o alone means TSV
                        opts.output_format = OutputFormat::Tsv;
                    }
                }
                "l" => {
                    // -l <channel> <gain> : apply gain to specific channel
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-l requires two arguments: <channel> <gain>");
                    }
                    let channel_arg: usize = args[i].parse().map_err(|_| {
                        anyhow::anyhow!(
                            "invalid channel number: {} (use 0 for left, 1 for right)",
                            args[i]
                        )
                    })?;
                    let channel = Channel::from_index(channel_arg).ok_or_else(|| {
                        anyhow::anyhow!(
                            "invalid channel: {} (use 0 for left, 1 for right)",
                            channel_arg
                        )
                    })?;

                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-l requires two arguments: <channel> <gain>");
                    }
                    let gain: i32 = args[i]
                        .parse()
                        .map_err(|_| anyhow::anyhow!("invalid gain value: {}", args[i]))?;

                    opts.channel_gain = Some((channel, gain));
                }
                "i" => {
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-i requires an argument");
                    }
                    opts.track_index = Some(
                        args[i]
                            .parse()
                            .map_err(|_| anyhow::anyhow!("invalid track index: {}", args[i]))?,
                    );
                }
                "j" => {
                    i += 1;
                    if i >= args.len() {
                        anyhow::bail!("-j requires an argument");
                    }
                    opts.threads = Some(parse_thread_count(&args[i], "-j")?);
                }
                "v" => {
                    print_version();
                    std::process::exit(0);
                }
                "h" => {
                    print_usage();
                    std::process::exit(0);
                }
                // Boolean short flags, single (-q) or combined (-qp, -kc).
                // One table for both forms so the two can't drift apart.
                _ if flag.chars().all(|c| "pqckuranRewxtf".contains(c)) => {
                    for c in flag.chars() {
                        match c {
                            'p' => opts.preserve_timestamp = true,
                            'q' => opts.quiet = true,
                            'c' => opts.ignore_clipping = true,
                            'k' => opts.prevent_clipping = true,
                            'u' => opts.undo = true,
                            'r' => opts.track_gain = true,
                            'a' => opts.album_gain = true,
                            'n' => opts.dry_run = true,
                            'R' => opts.recursive = true,
                            'e' => opts.skip_album = true,
                            'w' => opts.wrap_gain = true,
                            'x' => opts.max_amplitude_only = true,
                            't' => opts.use_temp_file = true,
                            'f' => opts.assume_mpeg2 = true,
                            _ => {}
                        }
                    }
                }
                // Handle -g with attached value (e.g., -g2)
                _ if flag.starts_with('g') => {
                    let val = &flag[1..];
                    opts.gain_steps = Some(
                        val.parse()
                            .map_err(|_| anyhow::anyhow!("invalid gain value: {}", val))?,
                    );
                }
                // Handle -d with attached value (e.g., -d4.5)
                _ if flag.starts_with('d') => {
                    let val = &flag[1..];
                    opts.gain_modifier_db = val
                        .parse()
                        .map_err(|_| anyhow::anyhow!("invalid dB value: {}", val))?;
                }
                // Handle -m with attached value (e.g., -m2)
                _ if flag.starts_with('m') => {
                    let val = &flag[1..];
                    opts.gain_modifier = val
                        .parse()
                        .map_err(|_| anyhow::anyhow!("invalid modifier value: {}", val))?;
                }
                // Handle -i with attached value (e.g., -i1)
                _ if flag.starts_with('i') => {
                    let val = &flag[1..];
                    opts.track_index = Some(
                        val.parse()
                            .map_err(|_| anyhow::anyhow!("invalid track index: {}", val))?,
                    );
                }
                // Handle -j with attached value (e.g., -j4)
                _ if flag.starts_with('j') => {
                    let val = &flag[1..];
                    opts.threads = Some(parse_thread_count(val, "-j")?);
                }
                _ => {
                    eprintln!("{}: unknown option: -{}", "warning".yellow().bold(), flag);
                }
            }
        } else if arg.starts_with("--") {
            // Silently dropping an unknown long option is dangerous
            // (a typo like --dryrun would modify files), so reject it.
            anyhow::bail!("unknown option: {}", arg);
        } else {
            // It's a file
            opts.files.push(PathBuf::from(arg));
        }

        i += 1;
    }

    // RG1's peak is mp3gain's MAX_AMPLITUDE semantics and must stay
    // bit-compatible, so true peak is only defined for the BS.1770 modes
    // (issue #292). Checked after the loop so flag order doesn't matter.
    if opts.true_peak && opts.analysis_mode == AnalysisMode::Rg1 {
        anyhow::bail!("--true-peak requires --rg2 or --r128");
    }

    // --per-directory only changes how -a groups files (issue #324).
    if opts.per_directory && !(opts.album_gain && !opts.skip_album) {
        anyhow::bail!("--per-directory requires -a");
    }

    // --tags-only (issue #308) writes ReplayGain metadata and nothing else, so
    // it needs an analysis to write and must not be paired with a flag that
    // would modify the audio or suppress the tag write. Rejected rather than
    // silently ignored: a user who asked for both meant one of them, and
    // guessing wrong here rewrites their files.
    if opts.tags_only {
        if !(opts.track_gain || opts.album_gain || opts.skip_album) {
            anyhow::bail!("--tags-only requires -r, -a or -e (there is no analysis to write)");
        }
        let conflict = if opts.gain_steps.is_some() {
            Some("-g")
        } else if opts.channel_gain.is_some() {
            Some("-l")
        } else if opts.undo {
            Some("-u")
        } else if opts.wrap_gain {
            Some("-w")
        } else if opts.max_amplitude_only {
            Some("-x")
        } else {
            match opts.stored_tag_mode {
                StoredTagMode::Check => Some("-s c"),
                StoredTagMode::Delete => Some("-s d"),
                StoredTagMode::Skip => Some("-s s"),
                StoredTagMode::None => None,
            }
        };
        if let Some(flag) = conflict {
            anyhow::bail!("--tags-only cannot be combined with {}", flag);
        }
    }

    // cmd.exe and PowerShell do not expand `*.mp3` for native programs.
    #[cfg(windows)]
    {
        opts.files = super::wildcard::expand(std::mem::take(&mut opts.files));
    }

    Ok(opts)
}

pub fn expand_files_recursive(paths: &[PathBuf]) -> Result<Vec<PathBuf>> {
    let mut result = mp3rgain::expand_audio_paths(paths)?;
    result.sort();
    // Overlapping roots (e.g. `-R music music/album`) yield duplicates,
    // which would apply gain twice to the same file.
    result.dedup();
    Ok(result)
}

#[cfg(test)]
mod tests {
    use super::*;
    use mp3rgain::Channel;

    fn args(parts: &[&str]) -> Vec<String> {
        parts.iter().map(|s| s.to_string()).collect()
    }

    #[test]
    fn tags_only_requires_an_analysis_flag() {
        // Issue #308: --tags-only writes what an analysis produced, so on its
        // own there is nothing to write.
        assert!(parse_args(&args(&["--tags-only", "a.mp3"])).is_err());
        for flag in ["-r", "-a", "-e"] {
            let opts = parse_args(&args(&["--tags-only", flag, "a.mp3"])).unwrap();
            assert!(opts.tags_only, "{} should enable tags-only", flag);
        }
    }

    #[test]
    fn tags_only_rejects_flags_that_would_modify_audio() {
        // Rejected rather than silently ignored: guessing which half of the
        // request the user meant would rewrite their files.
        for conflicting in [
            vec!["-r", "-g", "2"],
            vec!["-r", "-l", "0", "2"],
            vec!["-r", "-u"],
            vec!["-r", "-w"],
            vec!["-r", "-x"],
            vec!["-r", "-s", "s"],
            vec!["-r", "-s", "d"],
            vec!["-r", "-s", "c"],
        ] {
            let mut argv = vec!["--tags-only"];
            argv.extend_from_slice(&conflicting);
            argv.push("a.mp3");
            assert!(
                parse_args(&args(&argv)).is_err(),
                "--tags-only {:?} should be rejected",
                conflicting
            );
        }
    }

    #[test]
    fn tags_only_accepts_tag_layout_and_analysis_flags() {
        for compatible in [
            vec!["-s", "a"],
            vec!["-s", "i"],
            vec!["-s", "R"],
            vec!["--rg2"],
            vec!["-k"],
            vec!["-d", "2"],
            vec!["-m", "1"],
            vec!["-p"],
            vec!["-n"],
        ] {
            let mut argv = vec!["--tags-only", "-r"];
            argv.extend_from_slice(&compatible);
            argv.push("a.mp3");
            assert!(
                parse_args(&args(&argv)).is_ok(),
                "--tags-only {:?} should be accepted",
                compatible
            );
        }
    }

    #[test]
    fn tags_only_target_offset_is_not_step_quantized() {
        // The apply path has to land on a whole 1.5 dB step, so -d 0.4 rounds
        // away; a tag holds a float, so it must survive (issue #308).
        let applied = parse_args(&args(&["-r", "-d", "0.4", "a.mp3"])).unwrap();
        assert_eq!(applied.target_offset_db(), 0.0);

        let tagged = parse_args(&args(&["-r", "--tags-only", "-d", "0.4", "a.mp3"])).unwrap();
        assert!((tagged.target_offset_db() - 0.4).abs() < f64::EPSILON);

        // -m still contributes whole steps, converted to dB.
        let steps = parse_args(&args(&["-r", "--tags-only", "-m", "2", "a.mp3"])).unwrap();
        assert!((steps.target_offset_db() - mp3rgain::steps_to_db(2)).abs() < f64::EPSILON);
    }

    #[test]
    fn defaults_are_empty() {
        let opts = parse_args(&[]).unwrap();
        assert!(opts.files.is_empty());
        assert_eq!(opts.gain_steps, None);
        assert_eq!(opts.gain_modifier, 0);
        assert_eq!(opts.gain_modifier_db, 0.0);
        assert!(!opts.track_gain);
        assert!(!opts.album_gain);
        assert!(!opts.dry_run);
        assert!(!opts.quiet);
    }

    #[test]
    fn collects_positional_files() {
        let opts = parse_args(&args(&["a.mp3", "b.mp3", "c.mp3"])).unwrap();
        assert_eq!(opts.files.len(), 3);
        assert_eq!(opts.files[0].to_str(), Some("a.mp3"));
        assert_eq!(opts.files[2].to_str(), Some("c.mp3"));
    }

    #[test]
    fn g_flag_with_separate_value() {
        let opts = parse_args(&args(&["-g", "2", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_steps, Some(2));
        assert_eq!(opts.files.len(), 1);
    }

    #[test]
    fn g_flag_with_attached_value() {
        let opts = parse_args(&args(&["-g2", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_steps, Some(2));
    }

    #[test]
    fn g_flag_negative() {
        let opts = parse_args(&args(&["-g", "-3", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_steps, Some(-3));
    }

    #[test]
    fn d_flag_db_modifier() {
        let opts = parse_args(&args(&["-d", "4.5", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_db, 4.5);
    }

    #[test]
    fn d_flag_attached_value() {
        let opts = parse_args(&args(&["-d4.5", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_db, 4.5);
    }

    #[test]
    fn m_flag_modifier_steps() {
        let opts = parse_args(&args(&["-m", "2", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier, 2);
    }

    #[test]
    fn gain_modifier_steps_combines_d_and_m() {
        // -d alone: 3.0 dB rounds to +2 steps (1.5 dB per step)
        let opts = parse_args(&args(&["-d", "3.0", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), 2);

        // -m alone: untouched
        let opts = parse_args(&args(&["-m", "3", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), 3);

        // -d + -m: sum
        let opts = parse_args(&args(&["-d", "3.0", "-m", "1", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), 3);

        // Negative -d
        let opts = parse_args(&args(&["-d", "-3.0", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), -2);

        // Sub-step -d (0.5 dB < 0.75 dB threshold) rounds to zero
        let opts = parse_args(&args(&["-d", "0.5", "song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), 0);

        // No modifiers
        let opts = parse_args(&args(&["song.mp3"])).unwrap();
        assert_eq!(opts.gain_modifier_steps(), 0);
    }

    #[test]
    fn boolean_flags_individual() {
        let opts = parse_args(&args(&[
            "-r", "-p", "-q", "-k", "-c", "-w", "-t", "-R", "-n",
        ]))
        .unwrap();
        assert!(opts.track_gain);
        assert!(opts.preserve_timestamp);
        assert!(opts.quiet);
        assert!(opts.prevent_clipping);
        assert!(opts.ignore_clipping);
        assert!(opts.wrap_gain);
        assert!(opts.use_temp_file);
        assert!(opts.recursive);
        assert!(opts.dry_run);
    }

    #[test]
    fn combined_short_flags() {
        let opts = parse_args(&args(&["-qp", "song.mp3"])).unwrap();
        assert!(opts.quiet);
        assert!(opts.preserve_timestamp);

        let opts = parse_args(&args(&["-kc", "song.mp3"])).unwrap();
        assert!(opts.prevent_clipping);
        assert!(opts.ignore_clipping);

        let opts = parse_args(&args(&["-rn", "song.mp3"])).unwrap();
        assert!(opts.track_gain);
        assert!(opts.dry_run);
    }

    #[test]
    fn dry_run_long_flag() {
        let opts = parse_args(&args(&["--dry-run", "song.mp3"])).unwrap();
        assert!(opts.dry_run);
    }

    #[test]
    fn track_and_album_flags() {
        let opts = parse_args(&args(&["-r", "song.mp3"])).unwrap();
        assert!(opts.track_gain);
        assert!(!opts.album_gain);

        let opts = parse_args(&args(&["-a", "*.mp3"])).unwrap();
        assert!(opts.album_gain);
        assert!(!opts.track_gain);

        let opts = parse_args(&args(&["-e", "song.mp3"])).unwrap();
        assert!(opts.skip_album);
    }

    #[test]
    fn undo_flag() {
        let opts = parse_args(&args(&["-u", "song.mp3"])).unwrap();
        assert!(opts.undo);
    }

    #[test]
    fn max_amplitude_flag() {
        let opts = parse_args(&args(&["-x", "song.mp3"])).unwrap();
        assert!(opts.max_amplitude_only);
    }

    #[test]
    fn s_modes() {
        assert_eq!(
            parse_args(&args(&["-s", "c"])).unwrap().stored_tag_mode,
            StoredTagMode::Check
        );
        assert_eq!(
            parse_args(&args(&["-s", "d"])).unwrap().stored_tag_mode,
            StoredTagMode::Delete
        );
        assert_eq!(
            parse_args(&args(&["-s", "s"])).unwrap().stored_tag_mode,
            StoredTagMode::Skip
        );
        // -s r is a compatibility no-op flag, not a mode (#253)
        let opts = parse_args(&args(&["-s", "r"])).unwrap();
        assert!(opts.force_recalc);
        assert_eq!(opts.stored_tag_mode, StoredTagMode::None);
        // -s R reuses stored tags, orthogonal to the mode enum (#298)
        let opts = parse_args(&args(&["-s", "R", "-a"])).unwrap();
        assert!(opts.use_stored_tags);
        assert!(opts.stored_tags_usable());
        assert_eq!(opts.stored_tag_mode, StoredTagMode::None);
        // -s r, -d/-m, and the BS.1770 modes all disable tag reuse
        let opts = parse_args(&args(&["-s", "R", "-s", "r"])).unwrap();
        assert!(!opts.stored_tags_usable());
        let opts = parse_args(&args(&["-s", "R", "-d", "3.0"])).unwrap();
        assert!(!opts.stored_tags_usable());
        let opts = parse_args(&args(&["-s", "R", "--rg2"])).unwrap();
        assert!(!opts.stored_tags_usable());
        // -s i / -s a toggle the tag format; last one wins
        let opts = parse_args(&args(&["-s", "i"])).unwrap();
        assert_eq!(opts.tag_layout, TagLayout::Id3v2);
        let opts = parse_args(&args(&["-s", "i", "-s", "a"])).unwrap();
        assert_eq!(opts.tag_layout, TagLayout::Ape);
        assert_eq!(opts.stored_tag_mode, StoredTagMode::None);
    }

    #[test]
    fn output_formats() {
        assert_eq!(
            parse_args(&args(&["-o", "json", "song.mp3"]))
                .unwrap()
                .output_format,
            OutputFormat::Json
        );
        assert_eq!(
            parse_args(&args(&["-o", "text", "song.mp3"]))
                .unwrap()
                .output_format,
            OutputFormat::Text
        );
        assert_eq!(
            parse_args(&args(&["-o", "tsv", "song.mp3"]))
                .unwrap()
                .output_format,
            OutputFormat::Tsv
        );
        assert_eq!(
            parse_args(&args(&["-o", "db", "song.mp3"]))
                .unwrap()
                .output_format,
            OutputFormat::Tsv
        );
    }

    #[test]
    fn output_format_case_insensitive() {
        assert_eq!(
            parse_args(&args(&["-o", "JSON", "song.mp3"]))
                .unwrap()
                .output_format,
            OutputFormat::Json
        );
    }

    #[test]
    fn o_alone_means_tsv_mp3gain_compat() {
        // -o alone (no format arg or trailing only files) defaults to TSV
        let opts = parse_args(&args(&["-o", "song.mp3"])).unwrap();
        assert_eq!(opts.output_format, OutputFormat::Tsv);
        assert_eq!(opts.files.len(), 1);
    }

    #[test]
    fn channel_gain_left() {
        let opts = parse_args(&args(&["-l", "0", "3", "song.mp3"])).unwrap();
        assert_eq!(opts.channel_gain, Some((Channel::Left, 3)));
    }

    #[test]
    fn channel_gain_right_negative() {
        let opts = parse_args(&args(&["-l", "1", "-2", "song.mp3"])).unwrap();
        assert_eq!(opts.channel_gain, Some((Channel::Right, -2)));
    }

    #[test]
    fn track_index_separate() {
        let opts = parse_args(&args(&["-i", "1", "song.m4a"])).unwrap();
        assert_eq!(opts.track_index, Some(1));
    }

    #[test]
    fn track_index_attached() {
        let opts = parse_args(&args(&["-i1", "song.m4a"])).unwrap();
        assert_eq!(opts.track_index, Some(1));
    }

    #[test]
    fn assume_mpeg2_flag() {
        let opts = parse_args(&args(&["-f", "song.mp3"])).unwrap();
        assert!(opts.assume_mpeg2);
    }

    #[test]
    fn j_flag_separate_value() {
        let opts = parse_args(&args(&["-j", "4", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(4));
    }

    #[test]
    fn j_flag_attached_value() {
        let opts = parse_args(&args(&["-j8", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(8));
    }

    #[test]
    fn j_flag_zero_means_auto() {
        let opts = parse_args(&args(&["-j", "0", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(0));
    }

    #[test]
    fn j_flag_one_serial() {
        let opts = parse_args(&args(&["-j", "1", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(1));
    }

    #[test]
    fn threads_long_flag() {
        let opts = parse_args(&args(&["--threads", "2", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(2));
    }

    #[test]
    fn threads_long_flag_equals() {
        let opts = parse_args(&args(&["--threads=6", "song.mp3"])).unwrap();
        assert_eq!(opts.threads, Some(6));
    }

    #[test]
    fn invalid_j_returns_error() {
        let result = parse_args(&args(&["-j", "abc"]));
        assert!(result.is_err());
        let result = parse_args(&args(&["-jabc"]));
        assert!(result.is_err());
    }

    #[test]
    fn invalid_gain_returns_error() {
        let result = parse_args(&args(&["-g", "abc"]));
        assert!(result.is_err());
    }

    #[test]
    fn invalid_db_returns_error() {
        let result = parse_args(&args(&["-d", "xyz"]));
        assert!(result.is_err());
    }

    #[test]
    fn invalid_attached_gain_returns_error() {
        let result = parse_args(&args(&["-gabc"]));
        assert!(result.is_err());
    }

    #[test]
    fn analysis_mode_flags() {
        // Default stays RG1 (mp3gain compatible)
        let opts = parse_args(&args(&["-r", "song.mp3"])).unwrap();
        assert_eq!(opts.analysis_mode, AnalysisMode::Rg1);

        let opts = parse_args(&args(&["--rg2", "-r", "song.mp3"])).unwrap();
        assert_eq!(opts.analysis_mode, AnalysisMode::Rg2);
        assert!(opts.track_gain);

        let opts = parse_args(&args(&["-a", "--r128", "song.mp3"])).unwrap();
        assert_eq!(opts.analysis_mode, AnalysisMode::R128);
        assert!(opts.album_gain);

        // Repeating the same flag is fine
        let opts = parse_args(&args(&["--rg2", "--rg2", "song.mp3"])).unwrap();
        assert_eq!(opts.analysis_mode, AnalysisMode::Rg2);
    }

    #[test]
    fn rg2_and_r128_are_mutually_exclusive() {
        assert!(parse_args(&args(&["--rg2", "--r128", "song.mp3"])).is_err());
        assert!(parse_args(&args(&["--r128", "--rg2", "song.mp3"])).is_err());
    }

    #[test]
    fn true_peak_flag() {
        let opts = parse_args(&args(&["-r", "--rg2", "--true-peak", "song.mp3"])).unwrap();
        assert!(opts.true_peak);
        assert_eq!(opts.analysis_mode, AnalysisMode::Rg2);

        // Order-independent: --true-peak may precede the mode flag.
        let opts = parse_args(&args(&["--true-peak", "--r128", "song.mp3"])).unwrap();
        assert!(opts.true_peak);

        let opts = parse_args(&args(&["--rg2", "song.mp3"])).unwrap();
        assert!(!opts.true_peak);
    }

    #[test]
    fn true_peak_requires_bs1770_mode() {
        assert!(parse_args(&args(&["--true-peak", "song.mp3"])).is_err());
        assert!(parse_args(&args(&["-r", "--true-peak", "song.mp3"])).is_err());
    }

    #[test]
    fn skip_errors_long_flag() {
        let opts = parse_args(&args(&["--skip-errors", "song.mp3"])).unwrap();
        assert!(opts.skip_errors);
        assert_eq!(opts.files.len(), 1);

        let opts = parse_args(&args(&["song.mp3"])).unwrap();
        assert!(!opts.skip_errors);
    }

    #[test]
    fn flags_and_files_interleaved() {
        let opts = parse_args(&args(&["-g", "2", "a.mp3", "-p", "b.mp3"])).unwrap();
        assert_eq!(opts.gain_steps, Some(2));
        assert!(opts.preserve_timestamp);
        assert_eq!(opts.files.len(), 2);
    }

    /// A flag missing its argument is an error like an invalid value, not a
    /// `process::exit` from inside the parser.
    #[test]
    fn missing_argument_is_an_error() {
        for argv in [
            vec!["-g"],
            vec!["-d"],
            vec!["-m"],
            vec!["-s"],
            vec!["-i"],
            vec!["-j"],
            vec!["--threads"],
            vec!["-l"],
            vec!["-l", "0"],
            vec!["-s", "z"],
        ] {
            let err = match parse_args(&args(&argv)) {
                Err(e) => e.to_string(),
                Ok(_) => panic!("{argv:?} should be rejected"),
            };
            assert!(
                err.contains("requires") || err.contains("unknown -s mode"),
                "{argv:?}: {err}"
            );
        }
    }
}