1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
//! What:
//! Disposable fixtures and bounded process helpers for binary-level controls.
//! Why:
//! Every control runs the built executable through a `git`-named link on a
//! fixture PATH,
//! with no real home or global Git configuration,
//! and a hard time
//! bound so a forwarding loop fails the test instead of hanging it.
//!
//! In TS you'd write (pseudocode):
//! ```ts
//! // const fixture = await mkdtemp(...); await symlink(wrapper, join(fixture, 'bin/git'));
//! ```
/// Native string,
/// path and process types used by the helpers.
use std::ffi::{OsStr, OsString};
use std::io::Write;
use std::os::unix::process::ExitStatusExt;
use std::path::{Path, PathBuf};
use std::process::{Child, Command, Output, Stdio};
/// The native executable Cargo built for this test run.
pub const WRAPPER: &str = env!("CARGO_BIN_EXE_cli-git-native");
/// The real Git 2.56.0 executable installed in the verification image.
pub const REAL_GIT: &str = "/usr/bin/git";
/// This test process's own executable, for the helper processes a control starts from the test binary.
/// A test starts the test binary, never the wrapper: the ban on `std::env::current_exe` (`clippy.toml`) is about the
/// wrapper starting itself, so this is the one place the lint is excused for tests.
#[allow(clippy::disallowed_methods, reason = "identifies the running test binary so a control can start a helper copy of it; the wrapper is never started this way")]
pub fn this_test_binary() -> std::io::Result<PathBuf> {
return std::env::current_exe();
}
/// Seconds after which a wrapped command is killed;
/// real commands here finish in milliseconds.
/// The bound is short so a mutant that loops fails every affected control quickly.
pub const TIME_BOUND_SECONDS: &str = "5";
/// The signal that ends `timeout --signal=KILL` itself when the bound was hit:
/// it kills
/// the command,
/// then re-raises the same signal on itself.
pub const TIMED_OUT_SIGNAL: i32 = 9;
/// What one finished process showed its caller.
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct Observed {
/// Exit code,
/// absent when a signal ended the process.
pub code: Option<i32>,
/// Exact standard output bytes.
pub stdout: Vec<u8>,
/// Exact standard error bytes.
pub stderr: Vec<u8>,
}
/// One disposable directory with a `bin/git` link to the wrapper.
pub struct Fixture {
/// Canonical fixture root.
pub root: PathBuf,
/// The wrapper path every link and hard link in this fixture points at:
/// a hard link of the built executable, so no control may write to it.
pub wrapper: PathBuf,
/// The commit service of this fixture, started by the first wrapped command when `CLI_GIT_TEST_SERVICE` is set.
pub service: std::sync::Mutex<Option<FixtureService>>,
}
/// Environment variable that gives every fixture its own commit service and the runtime directory the wrapper looks for it
/// in, so a wrapped commit takes the route a person's commit takes. The commit path has no other writer, so a control that
/// commits needs it; set once, it applies to every control of the run.
pub const SERVICE_VARIABLE: &str = "CLI_GIT_TEST_SERVICE";
/// A commit service started for one fixture, stopped with it.
pub struct FixtureService {
child: Child,
/// The runtime directory the wrapper finds the service's socket in.
pub runtime: PathBuf,
}
impl Drop for FixtureService {
fn drop(&mut self) {
let _killed = self.child.kill();
let _waited = self.child.wait();
let _removed = std::fs::remove_dir_all(&self.runtime);
}
}
/// The resident service program Cargo built for this test run.
const SERVICE_PROGRAM: &str = env!("CARGO_BIN_EXE_cli-git-service");
/// Numbers the runtime directories of one test process.
static RUNTIME_COUNTER: std::sync::atomic::AtomicUsize = std::sync::atomic::AtomicUsize::new(0);
/// What:
/// Starts the commit service of a fixture: listening at the socket path the wrapper looks for under a short runtime
/// directory, with the journal in the fixture, and killed by the kernel if the test process dies.
/// Why:
/// A socket path holds about a hundred bytes, which the fixture tree's depth does not allow, so the runtime directory is
/// in the short agent scratch directory under the home. The parent-death signal means a control that panics or is killed
/// leaves no service behind.
pub fn start_fixture_service(fixture: &Fixture) -> FixtureService {
use std::os::unix::process::CommandExt;
let home: PathBuf = PathBuf::from(std::env::var_os("HOME").expect("a home directory for the service's runtime directory"));
let number: usize = RUNTIME_COUNTER.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
let runtime: PathBuf = home.join("temp/agent").join(format!("rt-{}-{number}", std::process::id()));
let socket: PathBuf = runtime.join("cli-git/service.sock");
std::fs::create_dir_all(socket.parent().expect("socket directory")).expect("runtime directory");
let mut command: Command = Command::new(SERVICE_PROGRAM);
command
.args(["--journal"])
.arg(fixture.root.join("journal"))
.arg("--path")
.arg(&socket)
.env_clear()
.env("PATH", "/usr/bin:/bin")
.env("HOME", fixture.root.join("home"))
.env("GIT_CONFIG_NOSYSTEM", "1")
.env("GIT_CONFIG_GLOBAL", "/nonexistent-global-config")
.stdin(Stdio::null())
.stdout(Stdio::null())
.stderr(Stdio::inherit());
// SAFETY: the closure runs in the child between fork and exec and calls only `prctl`, which is async-signal-safe.
unsafe {
command.pre_exec(|| {
libc::prctl(libc::PR_SET_PDEATHSIG, libc::SIGKILL);
return Ok(());
});
}
let child: Child = command.spawn().expect("the fixture's commit service starts");
let service: FixtureService = FixtureService { child, runtime };
let began: std::time::Instant = std::time::Instant::now();
while std::os::unix::net::UnixStream::connect(&socket).is_err() {
assert!(began.elapsed() < std::time::Duration::from_secs(60), "the fixture's commit service never listened");
std::thread::sleep(std::time::Duration::from_millis(5));
}
return service;
}
/// The runtime directory of the fixture's service, started on first use; nothing unless the run asked for services.
fn service_runtime(fixture: &Fixture) -> Option<PathBuf> {
if std::env::var_os(SERVICE_VARIABLE).is_none_or(|value| { return value.is_empty(); }) {
return None;
}
let mut service = fixture.service.lock().expect("the fixture's service lock");
if service.is_none() {
*service = Some(start_fixture_service(fixture));
}
return service.as_ref().map(|started| { return started.runtime.clone(); });
}
/// A pipe whose two ends are closed on `exec`: `[read end, write end]`.
/// Linux makes both ends close-on-exec in the one `pipe2` call;
/// macOS has no `pipe2`, so there the flag is set on each end right after `pipe`.
#[cfg(target_os = "linux")]
pub fn close_on_exec_pipe() -> [libc::c_int; 2] {
let mut ends: [libc::c_int; 2] = [0, 0];
// SAFETY: `pipe2` fills the two integers it is given.
let made: libc::c_int = unsafe { libc::pipe2(ends.as_mut_ptr(), libc::O_CLOEXEC) };
assert_eq!(made, 0, "pipe2 failed: {}", std::io::Error::last_os_error());
return ends;
}
/// A pipe whose two ends are closed on `exec`: `[read end, write end]`.
/// Linux makes both ends close-on-exec in the one `pipe2` call;
/// macOS has no `pipe2`, so there the flag is set on each end right after `pipe`.
#[cfg(all(unix, not(target_os = "linux")))]
pub fn close_on_exec_pipe() -> [libc::c_int; 2] {
let mut ends: [libc::c_int; 2] = [0, 0];
// SAFETY: `pipe` fills the two integers it is given.
let made: libc::c_int = unsafe { libc::pipe(ends.as_mut_ptr()) };
assert_eq!(made, 0, "pipe failed: {}", std::io::Error::last_os_error());
for end in ends {
// SAFETY: `end` was just created here; `fcntl` with `F_SETFD` only changes that descriptor's flags.
let flagged: libc::c_int = unsafe { libc::fcntl(end, libc::F_SETFD, libc::FD_CLOEXEC) };
assert_eq!(flagged, 0, "fcntl failed: {}", std::io::Error::last_os_error());
}
return ends;
}
/// The path of the slave side of the pseudo-terminal whose master is `descriptor`.
/// Linux has `ptsname_r`;
/// macOS has none, and `TIOCPTYGNAME` returns the name into the caller's buffer just as safely.
#[cfg(target_os = "linux")]
pub fn pseudo_terminal_slave_name(descriptor: libc::c_int) -> std::ffi::CString {
let mut buffer: [libc::c_char; 256] = [0; 256];
// SAFETY: `ptsname_r` writes at most the buffer's length.
let named: libc::c_int = unsafe { libc::ptsname_r(descriptor, buffer.as_mut_ptr(), buffer.len()) };
assert_eq!(named, 0, "the slave has a name");
// SAFETY: the call above wrote a NUL-terminated name into `buffer`.
return unsafe { std::ffi::CStr::from_ptr(buffer.as_ptr()) }.to_owned();
}
/// The path of the slave side of the pseudo-terminal whose master is `descriptor`.
/// Linux has `ptsname_r`;
/// macOS has none, and `TIOCPTYGNAME` returns the name into the caller's buffer just as safely.
#[cfg(all(unix, not(target_os = "linux")))]
pub fn pseudo_terminal_slave_name(descriptor: libc::c_int) -> std::ffi::CString {
let mut buffer: [libc::c_char; 128] = [0; 128];
// SAFETY: `TIOCPTYGNAME` writes a NUL-terminated name of at most 128 bytes into the buffer it is given.
let named: libc::c_int = unsafe { libc::ioctl(descriptor, libc::TIOCPTYGNAME as libc::c_ulong, buffer.as_mut_ptr()) };
assert_eq!(named, 0, "the slave has a name");
// SAFETY: the call above wrote a NUL-terminated name into `buffer`.
return unsafe { std::ffi::CStr::from_ptr(buffer.as_ptr()) }.to_owned();
}
/// Environment variable that keeps every fixture on disk after its test ends, for looking at a failure.
pub const KEEP_FIXTURES_VARIABLE: &str = "CLI_GIT_KEEP_FIXTURES";
/// Environment variable that moves the fixture root, for example onto a tmpfs for speed.
pub const FIXTURE_ROOT_VARIABLE: &str = "CLI_GIT_TEST_ROOT";
/// The directory fixtures are created in.
/// Cargo's per-target scratch directory, never `/tmp`: a shared tmpfs with a per-user quota fills up
/// when failing tests leave fixtures behind (issue 1809), and then every command of every session fails.
pub fn fixture_root() -> PathBuf {
let root: PathBuf = std::env::var_os(FIXTURE_ROOT_VARIABLE)
.map_or_else(|| { return PathBuf::from(env!("CARGO_TARGET_TMPDIR")); }, PathBuf::from);
std::fs::create_dir_all(&root).expect("fixture root");
return root;
}
/// What:
/// Remove a fixture tree unless the person asked to keep it, trying again for up to five seconds.
/// Why:
/// A landed commit may leave a maintenance child finishing for a moment, and removing a directory that still gains
/// entries fails; a tree already gone is the explicit `remove` having run first, not a failure.
pub fn settle_fixture(root: &Path, keep: bool) {
if keep {
return;
}
for _ in 0..50 {
match std::fs::remove_dir_all(root) {
Ok(()) => return,
Err(error) if error.kind() == std::io::ErrorKind::NotFound => return,
Err(_) => std::thread::sleep(std::time::Duration::from_millis(100)),
}
}
}
/// A fixture goes away however its test ends: a panic unwinds through this too.
impl Drop for Fixture {
fn drop(&mut self) {
// The service goes first: it writes into the fixture.
let _stopped = self.service.lock().map(|mut service| { return service.take(); });
settle_fixture(self.root.as_path(), std::env::var_os(KEEP_FIXTURES_VARIABLE).is_some());
}
}
/// What:
/// Read the fixture's wrapper once per test process, so its pages are in the page cache before any bounded command
/// starts it, and the wait for a slow disk happens here and not under the 5-second bound.
/// Why:
/// Every fixture's wrapper is a hard link of the built executable, so all fixtures of all test processes share one
/// set of cached pages. Starting an executable that is not cached reads most of the file in its first fault (a 22 MB
/// debug build read 16 MiB; `doc/troubleshooting/native-binary-tests-hit-the-shared-bound-under-host-load.md`).
fn warm_wrapper(linked: &Path) {
/// Set once the executable has been read by this process.
static WARMED: std::sync::OnceLock<()> = std::sync::OnceLock::new();
WARMED.get_or_init(|| {
use std::io::Read;
let mut file: std::fs::File = std::fs::File::open(linked).expect("open the fixture wrapper");
let mut chunk: Vec<u8> = vec![0; 1 << 20];
while file.read(chunk.as_mut_slice()).expect("read the built wrapper") > 0 {}
});
}
/// What:
/// Give a fixture its wrapper path: a hard link of the built executable; when the link fails because the fixture is on
/// another filesystem (`EXDEV`), a hard link of the one stored copy of the build in `store_root`; and a data copy
/// only where neither link works.
/// Why:
/// The wrapper never reads its own path except to recognise itself by file identity and to find hook entries by
/// the name it was started under (`real_git_candidate::same_file`, `main.rs`), and no control writes to it, so a
/// private copy bought nothing but 22 MB of writes per fixture and a cold first start of a new inode per test.
/// The fallback follows the link's own failure and not a comparison of device numbers, which bind mounts defeat.
/// 169 fixtures that each copied wrote about 3.7 GB (169 times 21.9 MB) in one wave
/// (`doc/troubleshooting/native-binary-tests-hit-the-shared-bound-under-host-load.md`).
fn link_built_wrapper(built: &Path, to: &Path, store_root: &Path) {
if let Err(error) = std::fs::hard_link(built, to) {
let stored: std::io::Result<()> = if error.raw_os_error() == Some(libc::EXDEV) {
super::wrapper_store::link_stored(built, store_root, to, &mut |_| {})
} else {
Err(error)
};
if let Err(reason) = stored {
eprintln!("fixture wrapper: no hard link of {} at {} ({reason}); copying it instead", built.display(), to.display());
copy_executable(built, to);
}
}
// After the link, not before: on overlay storage a hard link of an image-layer file copies the file up to a
// new inode, whose pages are the ones every fixture then shares and the ones a start needs.
warm_wrapper(to);
}
/// Create a fixture in the fixture root:
/// `<root>/wrapper/cli-git-native` (hard link of the built executable) and `<root>/bin/git` (symbolic link to it).
pub fn fixture(name: &str) -> Fixture {
return fixture_in(fixture_root().as_path(), name);
}
/// Create a fixture in `directory`, which may be on another filesystem than the build; see `fixture`.
pub fn fixture_in(directory: &Path, name: &str) -> Fixture {
std::fs::create_dir_all(directory).expect("fixture directory root");
let created: PathBuf = directory.join(format!("native-binary-{}-{name}", std::process::id()));
if created.exists() {
std::fs::remove_dir_all(&created).expect("remove stale fixture");
}
std::fs::create_dir(&created).expect("fresh fixture");
let root: PathBuf = std::fs::canonicalize(&created).expect("canonical fixture");
for subdirectory in ["wrapper", "bin", "home"] {
std::fs::create_dir(root.join(subdirectory)).expect("fixture directory");
}
let wrapper: PathBuf = root.join("wrapper/cli-git-native");
link_built_wrapper(Path::new(WRAPPER), wrapper.as_path(), directory);
std::os::unix::fs::symlink(&wrapper, root.join("bin/git")).expect("git-named link");
return Fixture { root, wrapper, service: std::sync::Mutex::new(None) };
}
/// Remove only the fixture directory a control created.
pub fn remove(fixture: &Fixture) {
std::fs::remove_dir_all(&fixture.root).expect("remove only the fixture");
}
/// Apply the hermetic environment every wrapped and direct run shares.
fn hermetic(command: &mut Command, fixture: &Fixture, path: &OsStr) {
command
.env_clear()
.env("PATH", path)
.env("HOME", fixture.root.join("home"))
.env("GIT_CONFIG_NOSYSTEM", "1")
.env("GIT_CONFIG_GLOBAL", "/nonexistent-global-config")
.env("GIT_AUTHOR_NAME", "Fixture")
.env("GIT_AUTHOR_EMAIL", "fixture@example.invalid")
.env("GIT_COMMITTER_NAME", "Fixture")
.env("GIT_COMMITTER_EMAIL", "fixture@example.invalid")
.current_dir(&fixture.root);
// A developer who sets the wrapper's verbose switch for a run gets its debug log in every wrapped command's
// output; no run sets it otherwise, so the environment stays hermetic.
if let Some(verbose) = std::env::var_os("MONOCHROMATIC_VERBOSE") {
command.env("MONOCHROMATIC_VERBOSE", verbose);
}
}
/// The PATH most controls use:
/// the wrapper's link directory ahead of real Git.
pub fn wrapper_first_path(fixture: &Fixture) -> OsString {
let mut path: OsString = fixture.root.join("bin").into_os_string();
path.push(":/usr/bin:/bin");
return path;
}
/// A command for `program` (a wrapper path) under the given PATH,
/// killed after `seconds`.
pub fn bounded_for(fixture: &Fixture, program: &Path, path: &OsStr, seconds: &str) -> Command {
let mut command: Command = Command::new("/usr/bin/timeout");
command.arg("--signal=KILL").arg(seconds).arg(program);
hermetic(&mut command, fixture, path);
if let Some(runtime) = service_runtime(fixture) {
command.env("XDG_RUNTIME_DIR", runtime);
}
return command;
}
/// A time-bounded command for `program` (a wrapper path) under the given PATH.
pub fn bounded(fixture: &Fixture, program: &Path, path: &OsStr) -> Command {
return bounded_for(fixture, program, path, TIME_BOUND_SECONDS);
}
/// What:
/// Put a `man` in the fixture's `bin` directory that prints one marker line naming the page and exits 0.
/// Why:
/// Git renders `--help` by running `man`, which starts `preconv`, `tbl`, `nroff`, `col`, `groff`, `troff` and
/// `grotty` (11 process starts in all, 18 ms warm and 0.7 s cold on the development host, 3.2 s once under load),
/// none of it the wrapper's work. Git looks `man` up on the command's `PATH`, whose first entry is this directory,
/// so the wrapper still receives and forwards the real `--help` and Git still takes its manual-page path.
pub fn stub_manual_viewer(fixture: &Fixture) {
executable(
fixture.root.join("bin/man").as_path(),
b"#!/bin/sh\necho \"manual page requested: $*\"\n",
);
}
/// Expose real Git at `<root>/real/git`,
/// a location that is not a conventional one.
/// Conventional locations are promoted to the front of the candidate list,
/// which would
/// hide whether earlier PATH entries were examined and skipped.
pub fn link_real_git(fixture: &Fixture) {
std::fs::create_dir(fixture.root.join("real")).expect("real directory");
std::os::unix::fs::symlink(REAL_GIT, fixture.root.join("real/git")).expect("real Git link");
}
/// A time-bounded command for the fixture's `bin/git` link with the wrapper first on PATH.
pub fn wrapped(fixture: &Fixture) -> Command {
return bounded(
fixture,
fixture.root.join("bin/git").as_path(),
wrapper_first_path(fixture).as_os_str(),
);
}
/// The same invocation sent straight to real Git,
/// as the comparison oracle.
pub fn direct(fixture: &Fixture) -> Command {
let mut command: Command = Command::new(REAL_GIT);
hermetic(&mut command, fixture, OsStr::new("/usr/bin:/bin"));
return command;
}
/// What:
/// Make the in-process object readers decline the repository, with a replace ref on two blobs nothing uses.
/// Why:
/// The controls with a stand-in `git-lfs` check what the wrapper does around the program it starts (order, status,
/// explanation, deadlines). The wrapper starts the program only when it finds a pointer in the pushed commits or when
/// the readers decline and `git-lfs` has to scan; these repositories hold no pointer, so they take the second path,
/// which is the fallback the readers' declines lead to in production.
pub fn decline_in_process_lfs_scan(fixture: &Fixture, repo: &Path) {
let mut hashes: Vec<String> = Vec::new();
for (name, text) in [("replace-from.txt", "from\n"), ("replace-to.txt", "to\n")] {
let file: PathBuf = fixture.root.join(name);
std::fs::write(&file, text).expect("blob source");
let output = direct(fixture).current_dir(repo).args(["hash-object", "-w"]).arg(&file).output().expect("hash-object starts");
assert!(output.status.success(), "{}", String::from_utf8_lossy(output.stderr.as_slice()));
hashes.push(String::from_utf8_lossy(output.stdout.as_slice()).trim().to_owned());
}
let replaced = direct(fixture).current_dir(repo).args(["replace", hashes[0].as_str(), hashes[1].as_str()]).output().expect("replace starts");
assert!(replaced.status.success(), "{}", String::from_utf8_lossy(replaced.stderr.as_slice()));
}
/// The bytes without their additive `"hint"` fields.
/// Most binary tests pin the incumbent's event shape, which has no hint;
/// the hint text is checked by tests that use `observe_raw`.
pub fn without_hint_fields(bytes: &[u8]) -> Vec<u8> {
let marker: &[u8] = b",\"hint\":\"";
let mut kept: Vec<u8> = Vec::with_capacity(bytes.len());
let mut index: usize = 0;
while index < bytes.len() {
if bytes[index..].starts_with(marker) {
index += marker.len();
while index < bytes.len() && bytes[index] != b'"' {
index += if bytes[index] == b'\\' { 2 } else { 1 };
}
index += 1;
} else {
kept.push(bytes[index]);
index += 1;
}
}
return kept;
}
/// How every wait notice of the wrapper begins (`wait_progress.rs`, `live_lock.rs`, `replay_reservation.rs`).
pub const WAIT_NOTICE_PREFIX: &[u8] = b"cli-git: still waiting for ";
/// What:
/// The bytes without the lines that are wait notices.
/// Why:
/// A step that outlasts its notice grace (5 seconds for a query, 10 for a bulk step) prints a notice on standard
/// error however healthy it is, and a loaded host stretches any step past that. A control that compares the
/// wrapper's diagnostics with native Git's words means the words, not that the host was fast, so it compares what
/// is left. Only a line that starts with the notice prefix goes; every other line stays, and a control that
/// asserts a notice reads the raw bytes.
pub fn without_wait_notices(bytes: &[u8]) -> Vec<u8> {
return bytes
.split_inclusive(|byte| { return *byte == b'\n'; })
.filter(|line| { return !line.starts_with(WAIT_NOTICE_PREFIX); })
.flatten()
.copied()
.collect();
}
/// Run a command to completion and observe it without its hint fields,
/// feeding `input` to its standard input.
pub fn observe(command: &mut Command, input: &[u8]) -> Observed {
let raw: Observed = observe_raw(command, input);
return Observed {
code: raw.code,
stdout: without_hint_fields(raw.stdout.as_slice()),
stderr: without_hint_fields(raw.stderr.as_slice()),
};
}
/// What a command run under the shared bound asks the wrapper to do, read the way the wrapper reads it.
enum SharedBoundMisuse {
/// A commit the wrapper lands through its transaction.
CommitTransaction,
/// A `--help` that makes Git render a manual page through `man` and the groff programs.
ManualPage,
}
/// What:
/// Whether `command` runs under the shared bound (`timeout --signal=KILL 5 <program> <arguments>`) with
/// arguments that need a longer bound or a stub instead; absent for any other command.
/// Why:
/// The shared bound is for single Git commands. A landed commit starts 40 Git processes and makes 36
/// sync calls (`binary_budget_tests.rs`), against one process for direct Git, and a manual page starts 9 more
/// (`man`, `preconv`, `tbl`, `nroff`, `col`, `groff`, `troff`, `grotty`), so under host load either one can pass
/// the bound while the policy it is there to test works. This check does not depend on timing, so a misuse fails
/// on every host, loaded or quiet, instead of once a day on a busy one.
fn shared_bound_misuse(command: &Command) -> Option<SharedBoundMisuse> {
let arguments: Vec<OsString> = command.get_args().map(OsStr::to_os_string).collect();
let [signal, bound, program, wrapped @ ..] = arguments.as_slice() else {
return None;
};
if signal != "--signal=KILL" || bound != TIME_BOUND_SECONDS {
return None;
}
let stripped = git_policy_cli::wrapper_invocation::strip_wrapper_controls(wrapped);
if stripped.layout.outcome != git_policy_cli::global_arguments::GlobalOutcome::Command {
return None;
}
let region: &[OsString] = git_policy_cli::wrapper_invocation::command_region(&stripped);
let word: &[u8] = git_policy_cli::wrapper_invocation::command_word(&stripped);
if word == b"commit"
&& git_policy_cli::command_commit::parse_commit_region(region, &[]).is_ok_and(|facts| { return !facts.dry_run; })
{
return Some(SharedBoundMisuse::CommitTransaction);
}
let has_manual_stub: bool = Path::new(program)
.parent()
.is_some_and(|directory| { return directory.join("man").exists(); });
let asks_for_help: bool = region
.iter()
.take_while(|token| { return *token != "--"; })
.any(|token| { return token == "--help"; });
if word != b"cli-git" && asks_for_help && !has_manual_stub {
return Some(SharedBoundMisuse::ManualPage);
}
return None;
}
/// Run a command to completion with every byte of its output kept,
/// feeding `input` to its standard input.
/// # Panics
/// When the command is a commit transaction or a manual page under the shared bound; see `shared_bound_misuse`.
pub fn observe_raw(command: &mut Command, input: &[u8]) -> Observed {
match shared_bound_misuse(command) {
Some(SharedBoundMisuse::CommitTransaction) => panic!(
"a commit under the shared {TIME_BOUND_SECONDS}-second bound: it starts 40 Git processes and makes 36 \
sync calls, so run it with `run_commit` (the {}-second bound of binary_commit_tests.rs)",
super::commit::COMMIT_BOUND_SECONDS
),
Some(SharedBoundMisuse::ManualPage) => panic!(
"a `--help` under the shared {TIME_BOUND_SECONDS}-second bound renders a manual page through man and groff \
(9 process starts); put an executable `man` stub in the fixture's bin directory first (`stub_manual_viewer`)"
),
None => {}
}
let mut child = command
.stdin(Stdio::piped())
.stdout(Stdio::piped())
.stderr(Stdio::piped())
.spawn()
.expect("process starts");
// A child that exits without reading its input closes the pipe; that is not a test failure.
let _ = child.stdin.take().expect("piped stdin").write_all(input);
let output: Output = child.wait_with_output().expect("process finishes");
assert_ne!(
output.status.signal(),
Some(TIMED_OUT_SIGNAL),
// Built only on failure: a bound hit under host load must name the command that stalled.
"the command hit the {TIME_BOUND_SECONDS}-second bound: {:?} in {:?}",
command.get_args().collect::<Vec<&OsStr>>(),
command.get_current_dir()
);
return Observed {
code: output.status.code(),
stdout: output.stdout,
stderr: output.stderr,
};
}
/// An editor that records that it started and then waits for a minute, so a commit that opens it sits inside native
/// `git commit` until a signal arrives. Hooks are unsupported, so controls that need the commit to stand still use this.
pub fn stalling_editor(fixture: &Fixture, started: &Path) -> PathBuf {
let path: PathBuf = fixture.root.join("stalling-editor");
executable(path.as_path(), format!("#!/bin/sh\ntouch '{}'\nsleep 60\n", started.display()).as_bytes());
return path;
}
/// Run real Git directly inside a fixture and require success.
pub fn git<S: AsRef<OsStr>>(fixture: &Fixture, directory: &Path, arguments: &[S]) -> Output {
let output: Output = direct(fixture)
.current_dir(directory)
.args(arguments)
.output()
.expect("native Git fixture command");
assert!(
output.status.success(),
"git failed: {}",
String::from_utf8_lossy(&output.stderr)
);
return output;
}
/// Create a repository with one empty commit on `main`,
/// using real Git directly.
pub fn repository(fixture: &Fixture, name: &OsStr) -> PathBuf {
let root: PathBuf = fixture.root.join(name);
std::fs::create_dir(&root).expect("repository directory");
git(
fixture,
root.as_path(),
&["init", "--quiet", "--initial-branch=main"],
);
git(
fixture,
root.as_path(),
&["commit", "--quiet", "--allow-empty", "--message=initial"],
);
return root;
}
/// Run a wrapped command in a directory,
/// with empty standard input,
/// and return what the caller saw.
pub fn run_wrapped(fixture: &Fixture, directory: &Path, arguments: &[&str]) -> Observed {
return observe(wrapped(fixture).current_dir(directory).args(arguments), b"");
}
/// Run real Git directly in a directory,
/// with empty standard input,
/// and return what the caller saw.
pub fn run_direct(fixture: &Fixture, directory: &Path, arguments: &[&str]) -> Observed {
return observe(direct(fixture).current_dir(directory).args(arguments), b"");
}
/// Real Git's porcelain status of a repository,
/// untracked files included,
/// as text.
pub fn porcelain(fixture: &Fixture, repo: &Path) -> String {
let output: Output = git(
fixture,
repo,
&["status", "--porcelain=v1", "--untracked-files=all"],
);
return String::from_utf8_lossy(&output.stdout).into_owned();
}
/// What a caller sees when a command stops with exit status 2 and this text on standard error.
pub fn stopped_with(stderr: &str) -> Observed {
return Observed {
code: Some(2),
stdout: Vec::<u8>::new(),
stderr: stderr.as_bytes().to_vec(),
};
}
/// What a caller sees when a command succeeds without printing anything.
pub fn silent_success() -> Observed {
return Observed {
code: Some(0),
stdout: Vec::<u8>::new(),
stderr: Vec::<u8>::new(),
};
}
/// Standard error of an observed command as text.
pub fn stderr_of(observed: &Observed) -> String {
return String::from_utf8_lossy(&observed.stderr).into_owned();
}
/// The one writer of executable fixture files, shared with the unit tests.
#[path = "fixture_executable.rs"]
mod fixture_executable;
pub use fixture_executable::executable;
/// What:
/// Copy an executable through a child `cp` process,
/// keeping its mode.
/// Why:
/// A copy made by this process would be open for writing here,
/// with the same
/// "Text file busy" window as `executable` describes.
/// Fixtures reach the wrapper through a hard link (`fixture`), so this is for controls that need a second file with
/// the wrapper's bytes and a different identity.
/// The copy is a real data copy (`--reflink=never`): on btrfs, which also backs overlay storage, the default
/// `cp` clones the extents, and the clone has no pages in the page cache, so the first start of the copy reads
/// most of the executable from disk inside the 5-second bound (a 22 MB debug build read 16 MiB in 4 major faults;
/// `doc/troubleshooting/native-binary-tests-hit-the-shared-bound-under-host-load.md`). A data copy leaves the pages
/// it wrote in the cache, and a slow read of the original happens here, outside any bound.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// spawnSync('cp', ['--reflink=never', '--', from, to]);
/// ```
pub fn copy_executable(from: &Path, to: &Path) {
let copied: bool = Command::new("cp")
.arg("--reflink=never")
.arg("--")
.arg(from)
.arg(to)
.status()
.expect("start fixture copy")
.success();
assert!(copied, "fixture copy failed: {from:?} to {to:?}");
}
/// The transaction ID registry fixtures use.
pub const TRANSACTION_ID: &str = "0b6c2c1e-6f5b-4d0e-9a55-3f5d8e2f6a10";
/// What:
/// Publish a transaction in a repository's registry,
/// owned by this test process with its
/// real birth identity (live) or with an identity no process has (dead).
/// Why:
/// The wrapper decides liveness from the record,
/// so this process stands in for an owner.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await publishTransactionDirectory({ root, transactionId, owner: await createTransactionOwnerRecord(...) });
/// ```
pub fn registered_transaction(repo: &Path, live: bool) -> PathBuf {
let registry: PathBuf = repo.join(".git/cli-git-transactions");
git_policy_cli::transaction_registry::ensure_transaction_root(registry.as_path())
.expect("registry");
let mut owner: git_policy_cli::transaction_owner::TransactionOwner =
git_policy_cli::transaction_owner::current_transaction_owner(
TRANSACTION_ID,
"2026-10-06T00:00:00.000Z",
)
.expect("owner");
if !live {
owner.owner_identity = String::from("linux:1");
}
git_policy_cli::transaction_registry::publish_transaction_directory(
registry.as_path(),
TRANSACTION_ID,
git_policy_cli::transaction_owner::encode_transaction_owner(&owner).as_bytes(),
)
.expect("published");
return registry;
}
/// What:
/// A sleeping process that stands in for a live wrapper or Git process,
/// killed and reaped when dropped.
/// Why:
/// A control of "a live process holds this" needs a real process number that exists,
/// and a failed assertion must not leave the sleeper running.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await using sleeper = spawnSleeper({ cwd, stdin });
/// ```
pub struct Sleeper(Child);
/// Starting a sleeper.
impl Sleeper {
/// What:
/// Start `sleep` with a working directory and, optionally, a file as its standard input (an open descriptor).
/// Why:
/// The working directory and the open descriptor are the two ways a scan sees a process use a path.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// spawn('sleep', ['120'], { cwd, stdio: [openSync(file), 'ignore', 'ignore'] })
/// ```
pub fn start(directory: &Path, held: Option<&Path>) -> Sleeper {
let mut command: Command = Command::new("sleep");
command.arg("120").current_dir(directory).stdout(Stdio::null()).stderr(Stdio::null());
match held {
Some(file) => command.stdin(std::fs::File::open(file).expect("the file to hold open")),
None => command.stdin(Stdio::null()),
};
return Sleeper(command.spawn().expect("the sleeper starts"));
}
/// The process number.
pub fn pid(&self) -> i64 {
return i64::from(self.0.id());
}
}
/// Stopping a sleeper.
impl Drop for Sleeper {
/// Kill and reap the process.
fn drop(&mut self) {
let _ = self.0.kill();
let _ = self.0.wait();
}
}