1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
//! What:
//! The wrapper's side of a commit through the resident service: connect, wait honestly while the operating system
//! starts the service, send the request, show the queue position, survive a service that dies mid-request, and turn
//! every failure into the plain text of `service_messages.rs`.
//! Why:
//! A failure the system can resolve is resolved here without the user: a service that is starting is waited for, one
//! that crashed is reconnected to with the same request identity, one that was started from another release of the
//! wrapper (older or newer, found by the release its welcome names) is asked to retire and is reached again once the
//! manager has started the current one. Only what cannot be resolved ends the command.
//!
//! In TS you'd write (pseudocode):
//! ```ts
//! const result = await submit(config, request, stderr); // landed, or prepare again, or a ClientFailure
//! ```
use super::commit_timing::{ReachTrace, SubmitTrace};
use super::service_messages::{ClientFailure, Platform, STARTING_NOTICE, UPDATING_NOTICE, position_notice};
use super::service_protocol::{
ClientMessage, CommitRequest, FailureCode, LandedCapture, PROTOCOL_VERSION, RELEASE, ServiceMessage, decode_service, encode_client, encode_retire,
};
use super::service_review_key::ReviewKey;
use super::service_server::Bind;
use std::io::{BufRead, BufReader, Write};
use std::os::unix::net::UnixStream;
use std::time::{Duration, Instant};
/// How long the client waits for the operating system to start the service.
pub const START_WAIT: Duration = Duration::from_secs(10);
/// How long a start takes before the client says it is starting the service.
pub const START_NOTICE_GRACE: Duration = Duration::from_secs(1);
/// How long a commit waits in the queue before the client gives up and says so.
pub const COMMIT_WAIT: Duration = Duration::from_secs(10 * 60);
/// How many times a request is sent again after the connection broke before the client says it cannot be sure.
pub const RECONNECTS: usize = 5;
/// The pause between connection tries while the service starts.
const CONNECT_PAUSE: Duration = Duration::from_millis(25);
/// What the client may rely on the operating system to do.
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub enum Activation {
/// The manager owns the socket and starts the service on demand.
Managed,
/// This platform cannot start the service on demand.
Unsupported(Platform),
}
/// What the client needs to reach the service.
#[derive(Clone, Debug)]
pub struct ClientConfig {
/// Where the service listens.
pub address: Bind,
/// What the operating system can do about a service that is not running.
pub activation: Activation,
/// Longest wait for a start.
pub start_wait: Duration,
/// Longest wait in the queue.
pub commit_wait: Duration,
}
/// What a request came to.
#[derive(Clone, Debug, Eq, PartialEq)]
pub enum Submitted {
/// The commit is on the branch.
Landed { commit: String, already: bool },
/// A named path changed on the branch: prepare again from this base and submit again with the same identity.
/// `landed` tells when the bytes of the commits the service landed since were captured, for the ones it knows.
PrepareAgain { base: String, landed: Vec<LandedCapture> },
/// The branch is no longer at the base of a commit that cannot be moved to another tip (an amend, or a commit Git built).
/// The caller decides whether to build it again on the new tip or to stop.
Moved,
}
fn connect(address: &Bind) -> std::io::Result<UnixStream> {
return match address {
#[cfg(target_os = "linux")]
Bind::Abstract(name) => {
use std::os::linux::net::SocketAddrExt;
UnixStream::connect_addr(&std::os::unix::net::SocketAddr::from_abstract_name(name.as_bytes())?)
}
#[cfg(not(target_os = "linux"))]
Bind::Abstract(_) => Err(std::io::Error::other("abstract sockets need Linux")),
Bind::Path(path) => UnixStream::connect(path),
Bind::Inherited => Err(std::io::Error::other("a client does not inherit the socket")),
};
}
fn read_message(reader: &mut BufReader<UnixStream>) -> Option<ServiceMessage> {
let mut line: String = String::new();
return match reader.read_line(&mut line) {
Ok(read) if read > 0 => decode_service(line.trim_end_matches('\n')).ok(),
_ => None,
};
}
/// What:
/// Connects, waiting for a start the operating system performs, and returns the stream with the service's version.
/// Why:
/// The wait is bounded and honest: one notice after the grace, then silence until the bound.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// const { stream, version } = await reach(config, notices)
/// ```
fn reach(
config: &ClientConfig,
notices: &mut dyn Write,
announced: &mut bool,
trace: &mut ReachTrace,
) -> Result<(BufReader<UnixStream>, u32, Option<String>), ClientFailure> {
let started: Instant = Instant::now();
let mut refused_here: bool = false;
loop {
trace.tries += 1;
match connect(&config.address) {
Ok(stream) => {
let _timeout = stream.set_read_timeout(Some(config.start_wait));
let mut reader: BufReader<UnixStream> = BufReader::new(stream);
if let Some(ServiceMessage::Welcome { version, release }) = read_message(&mut reader) {
let _widened = reader.get_ref().set_read_timeout(Some(config.commit_wait));
trace.saw_release(release.as_deref());
if refused_here {
trace.start_waited += started.elapsed();
}
return Ok((reader, version, release));
}
// Connected, but nothing greeted: the service is still starting or is going away.
trace.refused += 1;
refused_here = true;
}
Err(_) => match config.activation {
Activation::Unsupported(platform) => return Err(ClientFailure::NoActivation(platform)),
Activation::Managed => {
trace.refused += 1;
refused_here = true;
}
},
}
if started.elapsed() >= config.start_wait {
return Err(ClientFailure::DidNotStart);
}
if !*announced && started.elapsed() >= START_NOTICE_GRACE {
*announced = true;
let _written = writeln!(notices, "{STARTING_NOTICE}");
}
std::thread::sleep(CONNECT_PAUSE);
}
}
/// What:
/// Reaches a service that speaks this wrapper's protocol and was started from this wrapper's release, asking any other to
/// retire first.
/// Why:
/// The manager keeps its socket across an upgrade or a downgrade, so a service from the other release may answer: one
/// whose program was since removed, or one that behaves as the other release did. It is asked to finish its batch and
/// exit, and the next connection makes the manager start the program the rewritten unit names. The asking is bounded by
/// the start wait from the first ask (the same wait the manager's start gets), because the retiring service still accepts connections until it has exited, and
/// each connection it accepts in that time is asked again. A service of a newer protocol cannot be asked (it refuses a
/// message it cannot read as its own), so that ends the command.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// const reader = await reachCurrent(config, notices, announced)
/// ```
fn reach_current(config: &ClientConfig, notices: &mut dyn Write, announced: &mut bool, trace: &mut ReachTrace) -> Result<BufReader<UnixStream>, ClientFailure> {
let began: Instant = Instant::now();
let reached = reach_current_untimed(config, notices, announced, trace);
trace.elapsed += began.elapsed();
return reached;
}
/// `reach_current` without the clock around it.
fn reach_current_untimed(config: &ClientConfig, notices: &mut dyn Write, announced: &mut bool, trace: &mut ReachTrace) -> Result<BufReader<UnixStream>, ClientFailure> {
let mut give_up_at: Option<Instant> = None;
loop {
let (mut reader, version, release) = reach(config, notices, announced, trace)?;
if version == PROTOCOL_VERSION && release.as_deref() == Some(RELEASE) {
trace.answered_by = release;
return Ok(reader);
}
if version > PROTOCOL_VERSION {
return Err(ClientFailure::NoCommonVersion);
}
let deadline: Instant = *give_up_at.get_or_insert_with(|| {
let _written = writeln!(notices, "{UPDATING_NOTICE}");
return Instant::now() + config.start_wait;
});
if Instant::now() >= deadline {
return Err(ClientFailure::OtherRelease);
}
// Written in the version the service announced: a service of an earlier release reads a retire in no other.
let mut retire: String = encode_retire(version);
retire.push('\n');
let _sent = reader.get_mut().write_all(retire.as_bytes());
trace.retires_sent += 1;
std::thread::sleep(CONNECT_PAUSE * 4);
}
}
/// The user-facing failure for a code the service gave.
pub fn failure_for(code: FailureCode, request: &CommitRequest) -> ClientFailure {
let repository: String = request.repository.display().to_string();
return match code {
FailureCode::RepositoryFull => ClientFailure::RepositoryFull(repository),
FailureCode::RepositoryReadOnly => ClientFailure::RepositoryReadOnly(repository),
FailureCode::IndexInUse => ClientFailure::IndexInUse(String::from("Another program")),
FailureCode::Rejected => ClientFailure::Refused,
FailureCode::BranchKeepsChanging => ClientFailure::BranchKeepsChanging {
branch: request.reference.trim_start_matches("refs/heads/").to_string(),
times: super::service_land::LANDING_ATTEMPTS,
},
FailureCode::BranchMoved => ClientFailure::BranchMoved { branch: request.reference.trim_start_matches("refs/heads/").to_string() },
FailureCode::Unavailable => ClientFailure::Unavailable,
};
}
/// What:
/// Sends a commit request and waits until it is answered.
/// Why:
/// The same identity goes with every send, so a service that landed the commit and died before answering reports it
/// as already landed, and nothing lands twice.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await submit(config, request, notices)
/// ```
pub fn submit(config: &ClientConfig, request: &CommitRequest, notices: &mut dyn Write) -> Result<Submitted, ClientFailure> {
return submit_traced(config, request, notices, &mut SubmitTrace::default());
}
/// What:
/// `submit`,
/// leaving in `trace` how the service was reached and how long the answer took.
/// Why:
/// The wrapper's timing record states the tries,
/// the retires and the releases of the reach,
/// the queue positions the service
/// reported and the time between the request being written and the answer;
/// the trace is filled as the send proceeds,
/// so a
/// send that fails still reports what it did.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await submitTraced(config, request, notices, trace)
/// ```
pub fn submit_traced(config: &ClientConfig, request: &CommitRequest, notices: &mut dyn Write, trace: &mut SubmitTrace) -> Result<Submitted, ClientFailure> {
let began: Instant = Instant::now();
let answered = submit_loop(config, request, notices, trace);
trace.total += began.elapsed();
return answered;
}
/// The sends and the waits of `submit_traced`.
fn submit_loop(config: &ClientConfig, request: &CommitRequest, notices: &mut dyn Write, trace: &mut SubmitTrace) -> Result<Submitted, ClientFailure> {
let line: String = encode_client(&ClientMessage::Commit(Box::new(request.clone())));
let waiting_since: Instant = Instant::now();
let mut announced: bool = false;
let mut breaks: usize = 0;
let mut last_position: Option<usize> = None;
let mut holder: Option<String> = None;
loop {
if waiting_since.elapsed() >= config.commit_wait {
return Err(ClientFailure::WaitedTooLong { minutes: config.commit_wait.as_secs() / 60 });
}
let mut reader: BufReader<UnixStream> = reach_current(config, notices, &mut announced, &mut trace.reach)?;
let mut payload: String = line.clone();
payload.push('\n');
if reader.get_mut().write_all(payload.as_bytes()).is_err() {
breaks += 1;
trace.reconnects += 1;
if breaks > RECONNECTS {
return Err(ClientFailure::MayNotHaveLanded);
}
continue;
}
trace.sends += 1;
let written_at: Instant = Instant::now();
let answered: Option<Result<Submitted, ClientFailure>> = loop {
match read_message(&mut reader) {
Some(ServiceMessage::Position { number, of }) => {
if last_position != Some(number) {
last_position = Some(number);
trace.positions.push(number);
let _written = writeln!(notices, "{}", position_notice(number, of));
}
}
Some(ServiceMessage::Landed { commit, already, .. }) => break Some(Ok(Submitted::Landed { commit, already })),
Some(ServiceMessage::RetryPrepare { base, landed, .. }) => break Some(Ok(Submitted::PrepareAgain { base, landed })),
Some(ServiceMessage::Failed { code: FailureCode::BranchMoved, .. }) => break Some(Ok(Submitted::Moved)),
Some(ServiceMessage::Failed { code: FailureCode::IndexInUse, .. }) => {
break Some(Err(ClientFailure::IndexInUse(holder.take().unwrap_or_else(|| { return String::from("Another program"); }))));
}
Some(ServiceMessage::Failed { code, .. }) => break Some(Err(failure_for(code, request))),
Some(ServiceMessage::Waiting { text }) => {
trace.waiting_notices += 1;
let _written = write!(notices, "{text}");
}
Some(ServiceMessage::Holder { who }) => holder = Some(who),
Some(ServiceMessage::Welcome { .. }) => {}
None => break None,
}
};
trace.answer_wait += written_at.elapsed();
if let Some(done) = answered {
return done;
}
// The connection broke before an answer: the service died or was replaced. Send the same request again.
breaks += 1;
if breaks > RECONNECTS {
return Err(ClientFailure::MayNotHaveLanded);
}
std::thread::sleep(CONNECT_PAUSE * u32::try_from(breaks).unwrap_or(1));
}
}
/// What:
/// Asks the service listening at `socket` to finish its batch and exit, when one answers; nothing else is waited for.
/// Why:
/// The single service of the earlier releases is replaced by one service per worktree. It is asked politely first, in the
/// protocol version it announced, so that a batch it is landing is finished; the manager then stops its units. A socket
/// nobody listens on, or a service that does not greet, is no one to ask.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await askToRetire(socket)
/// ```
pub fn ask_to_retire(socket: &std::path::Path) {
let Ok(stream) = UnixStream::connect(socket) else { return };
let _timeout = stream.set_read_timeout(Some(START_WAIT));
let mut reader: BufReader<UnixStream> = BufReader::new(stream);
let Some(ServiceMessage::Welcome { version, .. }) = read_message(&mut reader) else { return };
let mut retire: String = encode_retire(version);
retire.push('\n');
let _sent = reader.get_mut().write_all(retire.as_bytes());
}
/// A scratch directory handed to the service: the service removes it when this value is dropped, and when the process that
/// holds it dies by any means, because the connection is the only thing that says the directory is still wanted.
pub struct ScratchWatch {
/// The open connection. Close-on-exec, so no program the wrapper starts keeps it open after the wrapper is gone.
_connection: UnixStream,
}
/// What:
/// Hands the commit's scratch directory to the service, which removes it when the connection closes.
/// Why:
/// A client killed without warning cannot remove what it made, and no one can tell afterwards whether it is gone or
/// stopped: the open connection is the signal, without a process id and without a lock. The announcement is written at once
/// and the greeting is not waited for, so a service that is frozen or still starting takes it when it reads, and a client
/// killed meanwhile still loses its directory. A service that is not running takes nothing, and a service of another release
/// refuses a message it does not know and closes nothing of the client's; in both the client removes the directory itself
/// when it ends, as it always has.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// const watch = watchScratch(config, gitDir, path) // undefined when nothing listens
/// ```
pub fn watch_scratch(config: &ClientConfig, git_dir: &std::path::Path, path: &std::path::Path) -> Option<ScratchWatch> {
let mut connection: UnixStream = connect(&config.address).ok()?;
let mut line: String = encode_client(&ClientMessage::Scratch { git_dir: git_dir.to_path_buf(), path: path.to_path_buf() });
line.push('\n');
connection.write_all(line.as_bytes()).ok()?;
return Some(ScratchWatch { _connection: connection });
}
/// What:
/// Tells the service that work items were written for a repository, starting it through the operating system when it
/// is not running, and returns once the service has taken the message.
/// Why:
/// The wrapper never starts the service or runs the work itself; the message is the only thing the service needs to
/// look at the repository's work directory. The connection closes when the service has read the line, which is the
/// confirmation that it will act.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await wake(config, gitDir, reviewKey)
/// ```
pub fn wake(config: &ClientConfig, git_dir: &std::path::Path, review_key: Option<&ReviewKey>, notices: &mut dyn Write) -> Result<(), ClientFailure> {
let mut line: String = encode_client(&ClientMessage::Work { git_dir: git_dir.to_path_buf(), review_key: review_key.cloned() });
line.push('\n');
let mut announced: bool = false;
let mut reader: BufReader<UnixStream> = reach_current(config, notices, &mut announced, &mut ReachTrace::default())?;
if reader.get_mut().write_all(line.as_bytes()).is_err() {
return Err(ClientFailure::Unavailable);
}
// The service closes the connection after it has read the line.
while read_message(&mut reader).is_some() {}
return Ok(());
}
/// The client's bounds and how it reads the service's lines.
#[cfg(test)]
#[path = "service_client_tests.rs"]
mod tests;