1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
//! What:
//! Waiting for a foreign `index.lock` under the classification rules:
//! a proven-alive owner
//! is waited for up to this process's wait limit (`CLI_GIT_LOCK_WAIT_SECONDS`, 30 minutes by default),
//! a dead or evidence-free owner is retried on Git's backoff
//! schedule until the unproven budget runs out.
//! Why:
//! An index writer must not run beside a landing,
//! and a lock nobody can prove alive must
//! not block forever.
//! Nothing here deletes a lock;
//! the caller decides what the failure means
//! (`src/index-lock/index-lock-wait.ts`).
//!
//! In TS you'd write (pseudocode):
//! ```ts
//! await waitForIndexLock({ realIndexPath, timeoutMs, consequence, attempt });
//! ```
/// The backstop every wait on a live process is bounded by.
use super::live_lock::{LIVE_WAIT_VARIABLE, live_wait_limit};
/// Foreign-lock evidence and its verdicts.
use super::index_lock_evidence::{
Evidence, Verdict, classify_index_lock, describe_index_lock_evidence, proven_holder_line,
};
/// Git's `BACKOFF_MAX_MULTIPLIER`:
/// the backoff stops growing here.
pub const BACKOFF_MAX_MULTIPLIER: u64 = 1_000;
/// Git's jitter floor in thousandths of the backoff.
const JITTER_FLOOR_PERMILLE: u64 = 750;
/// Git's jitter span in thousandths of the backoff.
const JITTER_SPAN_PERMILLE: u64 = 500;
/// Thousandths per whole.
const PERMILLE: u64 = 1_000;
/// Longest single poll while a PID file proves the owner alive,
/// so its release is noticed promptly.
pub const PROVEN_BY_PID_FILE_POLL_CAP_MS: u64 = 100;
/// Longest single poll while only an open descriptor proves the owner alive;
/// each poll repeats the
/// open-holder scan,
/// so it polls less often.
pub const PROVEN_BY_DESCRIPTOR_POLL_CAP_MS: u64 = 500;
/// What:
/// Git's backoff position:
/// `step` is Git's `n`,
/// `multiplier` the wait base in milliseconds.
/// Why:
/// `BackoffState` in the incumbent.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// type BackoffState = { step: number; multiplier: number };
/// ```
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub struct BackoffState {
/// Git's `n`.
pub step: u64,
/// Git's `multiplier`,
/// the current backoff in milliseconds.
pub multiplier: u64,
}
/// Backoff before the first wait.
pub const INITIAL_BACKOFF: BackoffState = BackoffState {
step: 1,
multiplier: 1,
};
/// What:
/// One jittered wait from Git's formula `(750 + rand() % 500) * backoff / 1000`,
/// rounded down.
/// Why:
/// Jitter spreads retrying processes apart;
/// `random` is a value in `[0, 1)`.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// Math.floor(((750 + Math.floor(random * 500)) * state.multiplier) / 1000);
/// ```
pub fn jittered_wait(state: BackoffState, random: f64) -> u64 {
let span: u64 = (random * (JITTER_SPAN_PERMILLE as f64)).floor() as u64;
return (JITTER_FLOOR_PERMILLE + span) * state.multiplier / PERMILLE;
}
/// What:
/// The next backoff:
/// `multiplier += 2n + 1`,
/// capped at `BACKOFF_MAX_MULTIPLIER`.
/// Why:
/// Adding `2n + 1` makes the multiplier the square of the step,
/// which is Git's schedule.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// nextBackoff({ step: 1, multiplier: 1 }); // { step: 2, multiplier: 4 }
/// ```
pub fn next_backoff(state: BackoffState) -> BackoffState {
let multiplier: u64 = state.multiplier + 2 * state.step + 1;
if multiplier > BACKOFF_MAX_MULTIPLIER {
return BackoffState {
step: state.step,
multiplier: BACKOFF_MAX_MULTIPLIER,
};
}
return BackoffState {
step: state.step + 1,
multiplier,
};
}
/// What:
/// What one attempt found,
/// or why the wait ended without a result.
/// Why:
/// The caller reports the owner and the consequence;
/// the attempt itself is the lock check.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// type IndexLockWaitError = { kind: 'unproven-owner'; evidence; verdict; timeoutMs; consequence } | { kind: 'read'; reason };
/// ```
#[derive(Clone, Debug, PartialEq)]
pub enum WaitFailure {
/// A dead or unproven owner outlasted the unproven budget.
UnprovenOwner {
/// Last attempt's evidence.
evidence: Box<Evidence>,
/// Last verdict,
/// which is never proven alive.
verdict: Verdict,
/// Budget that ran out,
/// in milliseconds.
timeout_ms: u64,
/// What cli-git therefore did not do.
consequence: String,
},
/// A proven-alive owner kept the lock until the wait limit ran out.
LiveHolderTimedOut {
/// The lock that stayed in place.
lock_path: std::path::PathBuf,
/// The owner's process ID.
pid: i64,
/// The owner's command name when readable.
command: Option<String>,
/// Milliseconds spent waiting for a proven-alive owner.
waited_ms: u64,
/// The limit that ran out,
/// in milliseconds.
limit_ms: u64,
/// What cli-git therefore did not do.
consequence: String,
},
/// The lock or its evidence could not be read.
Read(String),
}
/// What:
/// The side effects of a wait,
/// injected so tests can drive a fake clock and fake holders.
/// Why:
/// The host implementation reads `/proc`,
/// sleeps and writes standard error;
/// tests script each step.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// type IndexLockWaitEffects = { gather; sleep; random; report; now };
/// ```
pub trait WaitEffects {
/// Whether the lock currently exists (the attempt).
fn lock_present(&mut self) -> Result<bool, String>;
/// This attempt's evidence,
/// or nothing when the lock was released meanwhile.
fn gather(&mut self) -> Result<Option<Evidence>, String>;
/// Sleeps for `ms` milliseconds.
fn sleep(&mut self, ms: u64);
/// A uniform value in `[0, 1)`.
fn random(&mut self) -> f64;
/// The current time in milliseconds.
fn now_ms(&mut self) -> f64;
/// Writes one line of diagnostics to standard error.
fn report(&mut self, line: &str);
}
/// What:
/// The per-wait loop state:
/// backoff,
/// time spent unproven,
/// and whether the holder line was written.
/// Why:
/// `state` in `waitForIndexLock`.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// const state = { backoff: INITIAL_BACKOFF, unprovenMs: 0, reported: false };
/// ```
#[derive(Clone, Copy, Debug)]
struct LoopState {
/// Backoff position.
backoff: BackoffState,
/// Milliseconds spent without a proven owner.
unproven_ms: f64,
/// Milliseconds spent waiting for a proven-alive owner.
live_ms: f64,
/// Whether the holder line was written.
reported: bool,
}
/// What:
/// Wait until the lock is gone,
/// or fail once a dead or unproven owner outlasts `timeout_ms`
/// or a live owner outlasts this process's wait limit.
/// Why:
/// A live holder gets one diagnostic and the process's wait limit;
/// other holders get the budget,
/// which includes the evidence gathering because a `/proc` scan is not free.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await waitForIndexLock({ realIndexPath, timeoutMs, consequence, attempt, effects });
/// ```
pub fn wait_for_index_lock(
effects: &mut dyn WaitEffects,
timeout_ms: u64,
consequence: &str,
) -> Result<(), WaitFailure> {
let limit_ms: u64 = u64::try_from(live_wait_limit().as_millis()).unwrap_or(u64::MAX);
return wait_for_index_lock_within(effects, timeout_ms, limit_ms, consequence);
}
/// What:
/// The wait with an explicit limit on the time spent behind a proven-alive owner.
/// Why:
/// The default wait and the tests share one loop; only the limit differs.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// await waitForIndexLock({ realIndexPath, timeoutMs, liveLimitMs, consequence, attempt, effects });
/// ```
pub fn wait_for_index_lock_within(
effects: &mut dyn WaitEffects,
timeout_ms: u64,
live_limit_ms: u64,
consequence: &str,
) -> Result<(), WaitFailure> {
// `mut` lets each iteration advance the loop state.
let mut state: LoopState = LoopState {
backoff: INITIAL_BACKOFF,
unproven_ms: 0.0,
live_ms: 0.0,
reported: false,
};
loop {
let iteration_started: f64 = effects.now_ms();
let present: bool = match effects.lock_present() {
Ok(found) => found,
Err(reason) => return Err(WaitFailure::Read(reason)),
};
if !present {
return Ok(());
}
let evidence: Evidence = match effects.gather() {
Ok(Some(found)) => found,
// The lock went away between the attempt and the evidence read.
Ok(None) => continue,
Err(reason) => return Err(WaitFailure::Read(reason)),
};
let verdict: Verdict = classify_index_lock(&evidence);
let random: f64 = effects.random();
let backoff_ms: u64 = jittered_wait(state.backoff, random);
state.backoff = next_backoff(state.backoff);
if let Verdict::ProvenAlive {
pid,
by_descriptor,
command,
} = &verdict
{
if !state.reported {
let line: String = proven_holder_line(
*pid,
*by_descriptor,
command.as_deref(),
evidence.lock_path.as_path(),
);
effects.report(line.as_str());
state.reported = true;
}
let cap: u64 = if *by_descriptor {
PROVEN_BY_DESCRIPTOR_POLL_CAP_MS
} else {
PROVEN_BY_PID_FILE_POLL_CAP_MS
};
effects.sleep(backoff_ms.min(cap));
state.live_ms += effects.now_ms() - iteration_started;
if state.live_ms >= live_limit_ms as f64 {
return Err(WaitFailure::LiveHolderTimedOut {
lock_path: evidence.lock_path.clone(),
pid: *pid,
command: command.clone(),
waited_ms: state.live_ms as u64,
limit_ms: live_limit_ms,
consequence: String::from(consequence),
});
}
continue;
}
state.unproven_ms += effects.now_ms() - iteration_started;
if state.unproven_ms >= timeout_ms as f64 {
return Err(WaitFailure::UnprovenOwner {
evidence: Box::new(evidence),
verdict,
timeout_ms,
consequence: String::from(consequence),
});
}
let sleep_started: f64 = effects.now_ms();
effects.sleep(backoff_ms);
state.unproven_ms += effects.now_ms() - sleep_started;
}
}
/// What:
/// The diagnostic text of an unproven-owner failure.
/// Why:
/// The person needs the lock path,
/// the owner state,
/// the budget,
/// what was not done,
/// and the evidence.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// new IndexLockUnprovenOwnerError({ evidence, verdict, timeoutMs, consequence }).message
/// ```
pub fn unproven_owner_message(
evidence: &Evidence,
verdict: &Verdict,
timeout_ms: u64,
consequence: &str,
) -> String {
let owner: String = match verdict {
Verdict::Dead(pid) => format!("whose owner PID {pid} no longer runs"),
_ => String::from("whose owner cli-git could not prove alive"),
};
return format!(
"Another process left {}, {owner}; after {timeout_ms} ms (indexLock.unprovenOwnerTimeoutMs) the lock was still there. cli-git left the lock in place and {consequence}. Evidence: {}. Remove the lock only after confirming no Git process is using this repository.",
evidence.lock_path.display(),
describe_index_lock_evidence(evidence),
);
}
/// What:
/// The diagnostic text of a live-owner timeout.
/// Why:
/// The person needs the lock path, the owner to look at, the limit and its setting,
/// and what was not done.
///
/// In TS you'd write (pseudocode):
/// ```ts
/// new IndexLockLiveOwnerTimeoutError({ lockPath, pid, command, waitedMs, limitMs, consequence }).message
/// ```
pub fn live_holder_timeout_message(
lock_path: &std::path::Path,
pid: i64,
command: Option<&str>,
waited_ms: u64,
consequence: &str,
) -> String {
let owner: String = match command {
Some(name) => format!("PID {pid} ({name})"),
None => format!("PID {pid}"),
};
return format!(
"Gave up after waiting {} seconds for {owner}, which still holds {}; {LIVE_WAIT_VARIABLE} sets how long cli-git waits. cli-git left the lock in place and {consequence}. Look at that process, or raise the limit.",
waited_ms / 1_000,
lock_path.display(),
);
}
/// Wait controls stay out of the release executable.
#[cfg(test)]
#[path = "index_lock_wait_tests.rs"]
mod tests;