molgfx-render 0.3.3

The render graph, passes and the engine that drives a frame.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
use super::{Engine, EngineConfig};
use crate::testing::MockDevice;
use molframe::engine::core as frame;
use molgfx_core::{
    ChunkData, ChunkFootprint, ChunkId, ChunkPayload, DatasetId, HostWorkingSet, ResidencyBudget,
    ResidencyClass, ResidencyDetail, ResidencyKey, ResidencyOutput, ResidencyPhase,
    ResidencyRequest, ResidencyTicket,
};

const CIF: &str = "\
data_chunk
loop_
_atom_site.group_PDB
_atom_site.id
_atom_site.type_symbol
_atom_site.label_atom_id
_atom_site.label_alt_id
_atom_site.label_comp_id
_atom_site.label_asym_id
_atom_site.label_entity_id
_atom_site.label_seq_id
_atom_site.Cartn_x
_atom_site.Cartn_y
_atom_site.Cartn_z
_atom_site.occupancy
_atom_site.B_iso_or_equiv
_atom_site.auth_seq_id
_atom_site.auth_asym_id
_atom_site.pdbx_PDB_model_num
ATOM 1 C CA . GLY A 1 1 1.0 2.0 3.0 1.0 10.0 1 A 1
ATOM 2 N N  . GLY A 1 1 4.0 5.0 6.0 1.0 10.0 1 A 1
";

#[derive(Clone)]
pub(super) struct Fixture {
    pub(super) data: ChunkData,
    pub(super) pointer: usize,
    pub(super) bytes: Vec<u8>,
    pub(super) request: ResidencyRequest,
}

pub(super) fn engine() -> Engine<MockDevice> {
    engine_with_derived_budget(super::DerivedCacheBudget::default())
}

pub(super) fn engine_with_derived_budget(
    derived_cache: super::DerivedCacheBudget,
) -> Engine<MockDevice> {
    let mut config = EngineConfig {
        derived_cache,
        ..EngineConfig::default()
    };
    config.residency.page_size = 256;
    config.residency.page_count = 32;
    config.residency.uploads.capacity_bytes = 4096;
    config.residency.uploads.epoch_budget_bytes = 4096;
    config.residency.uploads.in_flight_budget_bytes = 4096;
    config.residency.uploads.ticket_capacity = 16;
    config.residency.uploads.alignment = 16;
    config.residency.machine_capacity = 16;
    match Engine::new(&config, None) {
        Ok(value) => value,
        Err(error) => panic!("mock engine must initialize: {error}"),
    }
}

fn backpressured_engine() -> Engine<MockDevice> {
    let mut config = EngineConfig::default();
    config.residency.page_size = 256;
    config.residency.page_count = 8;
    config.residency.uploads.capacity_bytes = 2048;
    config.residency.uploads.epoch_budget_bytes = 2048;
    config.residency.uploads.in_flight_budget_bytes = 2048;
    config.residency.uploads.ticket_capacity = 1;
    config.residency.uploads.alignment = 16;
    config.residency.machine_capacity = 4;
    match Engine::new(&config, None) {
        Ok(value) => value,
        Err(error) => panic!("backpressured engine must initialize: {error}"),
    }
}

#[test]
fn paged_gpu_storage_and_staging_are_committed_only_when_used() {
    let mut engine = engine();
    assert_eq!(
        engine
            .chunk_residency_metrics()
            .uploads
            .host_allocation_events,
        0
    );
    assert_paged_buffers_absent(&engine);

    let scene = molgfx_core::Scene::new();
    if let Err(error) = engine.render(&scene, &super::tests::camera()) {
        panic!("empty frame must render without paged storage: {error}");
    }
    assert_paged_buffers_absent(&engine);

    let mut output = ResidencyOutput::default();
    let (ticket, _, _) = request_and_deliver(&mut engine, fixture(901, 903, 1), &mut output);
    upload(&mut engine, ticket, &mut output);
    assert_eq!(
        engine
            .chunk_residency_metrics()
            .uploads
            .host_allocation_events,
        2
    );
    assert!(buffer_exists(&engine, "resident structure chunks"));
    assert!(buffer_exists(&engine, "resident structure chunk clusters"));
    // Paged chunks read the canonical coordinate backing; the second display
    // buffer exists only while a trajectory window does.
    assert!(!buffer_exists(&engine, "resident display coordinates"));
    assert!(!buffer_exists(&engine, "resident trajectory frames"));
    assert!(!buffer_exists(&engine, "resident provider bonds"));
    assert!(!buffer_exists(&engine, "paged visible rows"));
    assert!(!buffer_exists(&engine, "paged visible bonds"));
}

fn assert_paged_buffers_absent(engine: &Engine<MockDevice>) {
    for label in [
        "resident structure chunks",
        "resident trajectory frames",
        "resident structure chunk clusters",
        "resident provider bonds",
        "paged visible rows",
        "paged visible bonds",
    ] {
        assert!(!buffer_exists(engine, label), "{label} must remain lazy");
    }
}

fn buffer_exists(engine: &Engine<MockDevice>, label: &'static str) -> bool {
    engine
        .device
        .log
        .buffers
        .lock()
        .is_ok_and(|buffers| buffers.iter().any(|(_, value, _)| *value == label))
}

pub(super) fn fixture(dataset: u64, chunk: u64, priority: i32) -> Fixture {
    let structure = match molframe::read_bytes(
        CIF.as_bytes().to_vec(),
        Some("chunk.cif"),
        &molframe::ReadOptions::new(),
    ) {
        Ok((value, _)) => value,
        Err(error) => panic!("fixture must parse: {error:?}"),
    };
    let provider = match frame::StructureChunkProvider::new(
        frame::DatasetId::new(dataset),
        frame::ChunkId::new(chunk),
        structure.into_engine(),
    ) {
        Ok(value) => value,
        Err(error) => panic!("provider must initialize: {error}"),
    };
    let source = match provider.chunk(frame::ChunkId::new(chunk)) {
        Ok(value) => value,
        Err(error) => panic!("provider chunk must exist: {error}"),
    };
    let pointer = source.positions().as_ptr() as usize;
    let bytes = bytemuck::cast_slice(source.positions()).to_vec();
    let byte_len = bytes.len() as u64;
    let footprint = ChunkFootprint::new(byte_len, byte_len, byte_len, 256);
    let bridge = molgfx_core::ProviderDatasetBridge::new(provider.dataset());
    let data = match bridge.structure_chunk(source, footprint) {
        Ok(value) => value,
        Err(error) => panic!("bridge must retain provider storage: {error}"),
    };
    Fixture {
        data,
        pointer,
        bytes,
        request: ResidencyRequest {
            key: ResidencyKey {
                dataset: DatasetId::new(dataset),
                chunk: ChunkId::new(chunk),
                detail: ResidencyDetail::Atom,
            },
            footprint,
            class: ResidencyClass::Hot,
            priority,
        },
    }
}

pub(super) fn frame_fixture(dataset: u64, chunk: u64, priority: i32, offset: f32) -> Fixture {
    let source_text = CIF
        .replace("1.0 2.0 3.0", &format!("{} 2.0 3.0", 1.0 + offset))
        .replace("4.0 5.0 6.0", &format!("{} 5.0 6.0", 4.0 + offset));
    let structure = match molframe::read_bytes(
        source_text.into_bytes(),
        Some("frame.cif"),
        &molframe::ReadOptions::new(),
    ) {
        Ok((value, _)) => value,
        Err(error) => panic!("frame fixture must parse: {error:?}"),
    };
    let provider = match frame::FrameChunkProvider::new(
        frame::DatasetId::new(dataset),
        frame::ChunkId::new(chunk),
        structure.into_engine(),
        molframe::ModelIndex::new(0),
    ) {
        Ok(value) => value,
        Err(error) => panic!("frame provider must initialize: {error}"),
    };
    let source = match provider.chunk(frame::ChunkId::new(chunk)) {
        Ok(value) => value,
        Err(error) => panic!("frame chunk must exist: {error}"),
    };
    let pointer = source.positions().as_ptr() as usize;
    let bytes = bytemuck::cast_slice(source.positions()).to_vec();
    let byte_len = bytes.len() as u64;
    let footprint = ChunkFootprint::new(byte_len, byte_len, byte_len, 256);
    let bridge = molgfx_core::ProviderDatasetBridge::new(provider.dataset());
    let data = match bridge.frame_chunk(source, footprint) {
        Ok(value) => value,
        Err(error) => panic!("frame bridge must retain provider storage: {error}"),
    };
    Fixture {
        data,
        pointer,
        bytes,
        request: ResidencyRequest {
            key: ResidencyKey {
                dataset: DatasetId::new(dataset),
                chunk: ChunkId::new(chunk),
                detail: ResidencyDetail::Atom,
            },
            footprint,
            class: ResidencyClass::Hot,
            priority,
        },
    }
}

pub(super) fn request_and_deliver(
    engine: &mut Engine<MockDevice>,
    fixture: Fixture,
    output: &mut ResidencyOutput,
) -> (ResidencyTicket, usize, Vec<u8>) {
    let ticket = match engine.request_chunk_into(fixture.request, output) {
        Ok(value) => value,
        Err(error) => panic!("request must fit: {error}"),
    };
    if let Err(error) = engine.deliver_chunk_into(ticket, fixture.data, output) {
        panic!("delivery must fit: {error}");
    }
    (ticket, fixture.pointer, fixture.bytes)
}

fn retained_pointer(host: &HostWorkingSet, ticket: ResidencyTicket) -> usize {
    let Some(data) = host.payload(ticket.key) else {
        panic!("host payload must remain retained")
    };
    let ChunkPayload::ProviderStructure(structure) = data.payload() else {
        panic!("provider structure payload expected")
    };
    structure.positions().as_ptr() as usize
}

pub(super) fn upload(
    engine: &mut Engine<MockDevice>,
    ticket: ResidencyTicket,
    output: &mut ResidencyOutput,
) {
    if let Err(error) = engine.upload_chunk_into(ticket, output) {
        panic!("upload must be accepted: {error}");
    }
}

pub(super) fn complete(engine: &mut Engine<MockDevice>, output: &mut ResidencyOutput) {
    engine.device.complete_submissions();
    if let Err(error) = engine.poll_chunk_uploads_into(output) {
        panic!("completion must be accepted: {error}");
    }
}

#[test]
fn provider_storage_is_retained_and_exact_bytes_become_resident_only_after_signal() {
    let mut engine = engine();
    let mut output = ResidencyOutput::default();
    let source = fixture(u64::from(u32::MAX) + 17, u64::from(u32::MAX) + 31, 1);
    let (ticket, pointer, expected) = request_and_deliver(&mut engine, source, &mut output);
    assert_eq!(retained_pointer(engine.host_working_set(), ticket), pointer);

    upload(&mut engine, ticket, &mut output);
    assert_eq!(
        engine
            .host_working_set()
            .residency()
            .snapshot(ticket.key)
            .phase,
        ResidencyPhase::Uploading
    );
    if let Err(error) = engine.poll_chunk_uploads_into(&mut output) {
        panic!("unresolved poll must remain valid: {error}");
    }
    // The fence came from the upload's own epoch flush, so only the backend
    // signal is still outstanding.
    assert!(engine.resident_structure_chunk(ticket).is_none());

    complete(&mut engine, &mut output);
    let Some(resident) = engine.resident_structure_chunk(ticket) else {
        panic!("completed upload must be resident")
    };
    assert_eq!(resident.local_rows, 2);
    assert_eq!(resident.byte_len, expected.len() as u64);
    assert_eq!(retained_pointer(engine.host_working_set(), ticket), pointer);
    let payloads = match engine.device.log.write_payloads.lock() {
        Ok(value) => value,
        Err(error) => panic!("write log must be available: {error}"),
    };
    // The chunk's staged range opens with the provider's own coordinate bytes
    // and continues with its derived radii in the same reservation.
    let staged = payloads
        .iter()
        .map(Vec::as_slice)
        .find(|bytes| bytes.starts_with(&expected));
    let Some(staged) = staged else {
        panic!("one staged payload must begin with the exact borrowed coordinates")
    };
    assert_eq!(
        &staged[..expected.len()],
        expected.as_slice(),
        "the staged range opens with the provider's exact coordinates"
    );
    let radii = bytemuck::cast_slice::<f32, u8>(&[1.70_f32, 1.55_f32]);
    assert_eq!(
        &staged[expected.len()..expected.len() + radii.len()],
        radii,
        "derived radii follow the coordinates in the same range"
    );
}

#[test]
fn two_global_chunks_use_distinct_local_ranges_and_stale_work_never_resides() {
    let mut engine = engine();
    let mut output = ResidencyOutput::default();
    let (first, _, _) = request_and_deliver(&mut engine, fixture(7, 11, 1), &mut output);
    let (second, _, _) = request_and_deliver(&mut engine, fixture(7, 12, 2), &mut output);
    upload(&mut engine, first, &mut output);
    upload(&mut engine, second, &mut output);
    complete(&mut engine, &mut output);
    let first_range = engine
        .resident_structure_chunk(first)
        .map(|value| value.byte_offset);
    let second_range = engine
        .resident_structure_chunk(second)
        .map(|value| value.byte_offset);
    assert!(first_range.is_some());
    assert!(second_range.is_some());
    assert_ne!(first_range, second_range);

    let stale_fixture = fixture(9, 21, 1);
    let (stale, _, _) = request_and_deliver(&mut engine, stale_fixture, &mut output);
    upload(&mut engine, stale, &mut output);
    let replacement = fixture(9, 21, 3);
    let (current, _, _) = request_and_deliver(&mut engine, replacement, &mut output);
    upload(&mut engine, current, &mut output);
    complete(&mut engine, &mut output);
    assert!(engine.resident_structure_chunk(stale).is_none());
    assert!(engine.resident_structure_chunk(current).is_some());
}

#[test]
fn cancellation_pressure_and_device_loss_release_physical_pages() {
    let mut engine = engine();
    let mut output = ResidencyOutput::default();
    let (cancelled, _, _) = request_and_deliver(&mut engine, fixture(31, 41, 0), &mut output);
    upload(&mut engine, cancelled, &mut output);
    if let Err(error) = engine.cancel_chunk_into(cancelled, &mut output) {
        panic!("current upload must cancel: {error}");
    }
    complete(&mut engine, &mut output);
    assert!(engine.resident_structure_chunk(cancelled).is_none());

    let (lower, _, _) = request_and_deliver(&mut engine, fixture(31, 42, 0), &mut output);
    let (higher, higher_pointer, _) =
        request_and_deliver(&mut engine, fixture(31, 43, 10), &mut output);
    upload(&mut engine, lower, &mut output);
    upload(&mut engine, higher, &mut output);
    complete(&mut engine, &mut output);
    let constrained = ResidencyBudget {
        cpu: 4096,
        staging: 4096,
        gpu_hot: 256,
        gpu_warm: 0,
        in_flight: 4096,
    };
    if let Err(error) = engine.set_chunk_budget_into(constrained, &mut output) {
        panic!("pressure reconciliation must succeed: {error}");
    }
    assert!(engine.resident_structure_chunk(lower).is_none());
    assert!(engine.resident_structure_chunk(higher).is_some());
    assert_eq!(engine.chunk_residency_metrics().arena.resident_bytes, 256);

    let report = match engine.chunk_device_lost_into(&mut output) {
        Ok(value) => value,
        Err(error) => panic!("device loss must preserve host data: {error}"),
    };
    assert_eq!(report.invalidated, 1);
    assert!(engine.resident_structure_chunk(higher).is_none());
    assert_eq!(engine.chunk_residency_metrics().arena.resident_bytes, 0);
    assert_eq!(
        retained_pointer(engine.host_working_set(), higher),
        higher_pointer
    );
    assert_eq!(
        engine
            .host_working_set()
            .residency()
            .snapshot(higher.key)
            .phase,
        ResidencyPhase::ReadyCpu
    );
}

#[test]
fn upload_backpressure_preserves_cpu_payload_for_retry() {
    let mut engine = backpressured_engine();
    let mut output = ResidencyOutput::default();
    let (first, _, _) = request_and_deliver(&mut engine, fixture(71, 81, 1), &mut output);
    let (second, pointer, _) = request_and_deliver(&mut engine, fixture(71, 82, 1), &mut output);
    upload(&mut engine, first, &mut output);
    let rejected = engine.upload_chunk_into(second, &mut output);
    assert!(matches!(
        rejected,
        Err(super::ChunkResidencyError::Upload(
            molgfx_gpu::UploadBackpressure::TicketCapacity
        ))
    ));
    assert_eq!(
        engine
            .host_working_set()
            .residency()
            .snapshot(second.key)
            .phase,
        ResidencyPhase::ReadyCpu
    );
    assert_eq!(retained_pointer(engine.host_working_set(), second), pointer);

    complete(&mut engine, &mut output);
    upload(&mut engine, second, &mut output);
    complete(&mut engine, &mut output);
    assert!(engine.resident_structure_chunk(second).is_some());
}