molcrafts-molpack 0.1.0

Faithful Rust port of Packmol molecular packing (split off from molrs)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
//! Handler trait and built-in handlers for packing progress callbacks.

use molrs::types::F;
use std::io::BufWriter;
use std::path::PathBuf;
use std::time::Instant;

use crate::context::PackContext;
use crate::frame::compute_mol_ids;
use crate::numerics::objective_small_floor;

// ── Info structs ─────────────────────────────────────────────────────────────

/// Information about the current packing phase.
#[derive(Debug, Clone, Copy)]
pub struct PhaseInfo {
    /// 0-based phase index.
    pub phase: usize,
    /// Total number of phases (ntype + 1).
    pub total_phases: usize,
    /// If `Some(itype)`, this is a per-type compaction phase.
    /// If `None`, this is the final all-types phase.
    pub molecule_type: Option<usize>,
}

/// Summary report emitted at the end of each packing phase.
///
/// Passed to [`Handler::on_phase_end`]. Fields mirror the counters
/// reported by `ProgressHandler::on_phase_start`; when no summary is
/// needed (e.g. early termination), callers may omit the handler hook.
#[derive(Debug, Clone, Copy, Default)]
pub struct PhaseReport {
    /// Number of outer iterations actually run in this phase.
    pub iterations: usize,
    /// Final `fdist` (max inter-molecular overlap) at phase exit.
    pub fdist: F,
    /// Final `frest` (max restraint violation) at phase exit.
    pub frest: F,
    /// Whether the phase converged under `precision`.
    pub converged: bool,
}

/// Screen-log detail level for LAMMPS-style packer output.
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Default)]
pub enum MolpackLogLevel {
    /// Print nothing.
    #[default]
    Quiet,
    /// Print system setup, phase summaries, and final summary.
    Summary,
    /// Print per-step thermo-style progress lines.
    Progress,
    /// Print the same progress lines plus extra diagnostic columns.
    Verbose,
}

impl MolpackLogLevel {
    #[inline]
    pub const fn is_enabled(self) -> bool {
        !matches!(self, Self::Quiet)
    }
}

/// Per-iteration progress snapshot.
#[derive(Debug, Clone)]
pub struct StepInfo {
    /// 0-based loop iteration within the current phase.
    pub loop_idx: usize,
    /// Maximum loops for this phase.
    pub max_loops: usize,
    /// Current phase info.
    pub phase: PhaseInfo,
    /// Max inter-molecular overlap violation (0.0 = no overlap).
    pub fdist: F,
    /// Max constraint violation (0.0 = all constraints satisfied).
    pub frest: F,
    /// Improvement from last iteration, as percentage (positive = improving).
    pub improvement_pct: F,
    /// Current radius scaling factor (starts at discale, decays to 1.0).
    pub radscale: F,
    /// Convergence precision target.
    pub precision: F,
    /// Relaxer acceptance rates: `(type_index, acceptance_rate)`.
    pub relaxer_acceptance: Vec<(usize, F)>,
}

// ── Trait ─────────────────────────────────────────────────────────────────────

/// Callback interface called by [`crate::packer::Molpack`] during packing.
pub trait Handler: Send {
    /// Called immediately at the start of [`pack`][crate::packer::Molpack::pack],
    /// before any computation. Use this for immediate user feedback.
    fn on_start(&mut self, _ntotat: usize, _ntotmol: usize) {}

    /// Called once after initialization completes, with valid `xcart` positions.
    /// Use this to write the initial conformation (e.g. [`XYZHandler`]).
    fn on_initialized(&mut self, _sys: &PackContext) {}

    /// Called after each outer optimization loop iteration.
    fn on_step(&mut self, info: &StepInfo, sys: &PackContext);

    /// Called at the start of each packing phase (per-type and all-types).
    /// Allows stateful handlers to reset between phases.
    fn on_phase_start(&mut self, _info: &PhaseInfo) {}

    /// Called once after the packing loop finishes (convergence or max loops).
    fn on_finish(&mut self, _sys: &PackContext) {}

    /// Return `true` to request early termination of the packing loop.
    fn should_stop(&self) -> bool {
        false
    }

    // ── v2 additions (spec §6.6) — default no-op, backward compatible ──

    /// Called after each inner GENCAN iteration (more granular than [`on_step`]).
    ///
    /// Default: no-op. Implement when you need per-inner-iteration feedback
    /// (e.g. plotting objective evolution, adaptive stop criteria).
    ///
    /// - `iter` — 0-based inner iteration counter within the current outer step
    /// - `f` — current objective value (pair + restraint)
    /// - `sys` — read-only view of the packing context
    ///
    /// [`on_step`]: Handler::on_step
    fn on_inner_iter(&mut self, _iter: u32, _f: F, _sys: &PackContext) {}

    /// Called at the end of each packing phase, with a summary report.
    ///
    /// Default: no-op. Paired with [`on_phase_start`] for symmetric
    /// setup / teardown hooks.
    ///
    /// [`on_phase_start`]: Handler::on_phase_start
    fn on_phase_end(&mut self, _info: &PhaseInfo, _report: &PhaseReport) {}
}

// ── NullHandler ───────────────────────────────────────────────────────────────

/// A no-op handler.
pub struct NullHandler;

impl Handler for NullHandler {
    fn on_step(&mut self, _info: &StepInfo, _sys: &PackContext) {}
}

// ── XYZHandler ────────────────────────────────────────────────────────────────

/// Writes packing snapshots as a multi-frame XYZ trajectory.
///
/// Writes a frame on every `every`-th step (starting from step 0).
/// No automatic initial or final writes.
pub struct XYZHandler {
    path: PathBuf,
    /// Write every `n` steps (must be >= 1).
    every: usize,
    file: Option<BufWriter<std::fs::File>>,
    /// Precomputed global molecule ID per atom (constant across all frames).
    mol_ids: Vec<usize>,
}

impl XYZHandler {
    /// Create a new XYZ trajectory handler.
    ///
    /// `every` controls writing frequency: a frame is written on every step
    /// where `loop_idx % every == 0` (step 0 is always included).
    /// `every` must be >= 1.
    pub fn new(path: impl Into<PathBuf>, every: usize) -> Self {
        assert!(every >= 1, "every must be >= 1");
        Self {
            path: path.into(),
            every,
            file: None,
            mol_ids: Vec::new(),
        }
    }

    fn open(&mut self) {
        if self.file.is_some() {
            return;
        }
        match std::fs::OpenOptions::new()
            .write(true)
            .create(true)
            .truncate(true)
            .open(&self.path)
        {
            Ok(f) => self.file = Some(BufWriter::new(f)),
            Err(e) => log::warn!("XYZHandler: cannot open {}: {e}", self.path.display()),
        }
    }

    fn write_frame(&mut self, comment: &str, sys: &PackContext) {
        self.open();
        let Some(ref mut w) = self.file else { return };
        use std::io::Write;
        let nat = sys.xcart.len();
        let _ = writeln!(w, "{nat}");
        let _ = writeln!(w, "Properties=species:S:1:pos:R:3:mol:I:1  {comment}");
        for (icart, pos) in sys.xcart.iter().enumerate() {
            let elem = sys
                .elements
                .get(icart)
                .and_then(|e| *e)
                .map(|e| e.symbol())
                .unwrap_or("X");
            let mol_id = self.mol_ids.get(icart).copied().unwrap_or(0);
            let _ = writeln!(
                w,
                "{elem}  {:.6}  {:.6}  {:.6}  {mol_id}",
                pos[0], pos[1], pos[2]
            );
        }
        let _ = w.flush();
    }
}

impl Handler for XYZHandler {
    fn on_initialized(&mut self, sys: &PackContext) {
        self.mol_ids = compute_mol_ids(sys);
    }

    fn on_step(&mut self, info: &StepInfo, sys: &PackContext) {
        if info.loop_idx.is_multiple_of(self.every) {
            self.write_frame(&format!("step {}", info.loop_idx), sys);
        }
    }
}

// ── ProgressHandler ───────────────────────────────────────────────────────────

/// Prints human-readable progress lines to `stderr`.
///
/// Added as a default handler by [`crate::packer::Molpack::new`].
pub struct ProgressHandler {
    start: Option<Instant>,
}

impl ProgressHandler {
    pub fn new() -> Self {
        Self { start: None }
    }
}

impl Default for ProgressHandler {
    fn default() -> Self {
        Self::new()
    }
}

impl Handler for ProgressHandler {
    fn on_start(&mut self, ntotat: usize, ntotmol: usize) {
        self.start = Some(Instant::now());
        eprintln!("Packing {ntotmol} molecules ({ntotat} atoms)...");
    }

    fn on_initialized(&mut self, sys: &PackContext) {
        let elapsed = self.start.map(|t| t.elapsed().as_secs_f64()).unwrap_or(0.0);
        eprintln!(
            "  Initializing... done ({:.1}s)  overlap: {:.4e}  constraints: {:.4e}",
            elapsed, sys.fdist, sys.frest
        );
    }

    fn on_phase_start(&mut self, info: &PhaseInfo) {
        let desc = match info.molecule_type {
            Some(itype) => format!("Compacting type {itype}"),
            None => "Optimizing all types together".to_string(),
        };
        eprintln!("  Phase [{}/{}] {desc}", info.phase + 1, info.total_phases,);
    }

    fn on_step(&mut self, info: &StepInfo, _sys: &PackContext) {
        let elapsed = self.start.map(|t| t.elapsed().as_secs_f64()).unwrap_or(0.0);
        eprintln!(
            "    Step [{}/{}]  overlap: {:.2e}  constraints: {:.2e}  improved {:.1}%  ({:.1}s)",
            info.loop_idx + 1,
            info.max_loops,
            info.fdist,
            info.frest,
            info.improvement_pct,
            elapsed,
        );
    }

    fn on_finish(&mut self, sys: &PackContext) {
        let elapsed = self.start.map(|t| t.elapsed().as_secs_f64()).unwrap_or(0.0);
        if sys.fdist < 0.01 && sys.frest < 0.01 {
            eprintln!(
                "  Converged in {:.1}s — overlap: {:.2e}  constraints: {:.2e}",
                elapsed, sys.fdist, sys.frest,
            );
        } else {
            eprintln!(
                "  Did not converge ({:.1}s) — overlap: {:.2e}  constraints: {:.2e}",
                elapsed, sys.fdist, sys.frest,
            );
        }
    }
}

// ── LammpsLogHandler ─────────────────────────────────────────────────────────

/// LAMMPS-style screen log for packing runs.
///
/// Most users should enable this through
/// [`Molpack::with_lammps_output`][crate::packer::Molpack::with_lammps_output]
/// or [`Molpack::with_log_level`][crate::packer::Molpack::with_log_level]
/// instead of attaching the handler manually.
pub struct LammpsLogHandler {
    level: MolpackLogLevel,
    every: usize,
    tolerance: F,
    precision: F,
    seed: u64,
    max_loops: usize,
    ntypes: usize,
    periodic_box: Option<([F; 3], [F; 3], [bool; 3])>,
    start: Option<Instant>,
    phase_start: Option<Instant>,
}

impl LammpsLogHandler {
    #[allow(clippy::too_many_arguments)]
    pub fn new(
        level: MolpackLogLevel,
        every: usize,
        tolerance: F,
        precision: F,
        seed: u64,
        max_loops: usize,
        ntypes: usize,
        periodic_box: Option<([F; 3], [F; 3], [bool; 3])>,
    ) -> Self {
        Self {
            level,
            every: every.max(1),
            tolerance,
            precision,
            seed,
            max_loops,
            ntypes,
            periodic_box,
            start: None,
            phase_start: None,
        }
    }

    fn elapsed(&self) -> F {
        self.start.map(|t| t.elapsed().as_secs_f64()).unwrap_or(0.0)
    }

    fn phase_elapsed(&self) -> F {
        self.phase_start
            .map(|t| t.elapsed().as_secs_f64())
            .unwrap_or(0.0)
    }
}

impl Handler for LammpsLogHandler {
    fn on_start(&mut self, ntotat: usize, ntotmol: usize) {
        if !self.level.is_enabled() {
            return;
        }

        let now = Instant::now();
        self.start = Some(now);
        self.phase_start = Some(now);

        eprintln!("Molpack screen log");
        eprintln!("System information:");
        eprintln!("  molecule types = {}", self.ntypes);
        eprintln!("  molecules      = {ntotmol}");
        eprintln!("  atoms          = {ntotat}");
        eprintln!("Settings:");
        eprintln!("  tolerance      = {:.6} A", self.tolerance);
        eprintln!("  precision      = {:.6}", self.precision);
        eprintln!("  seed           = {}", self.seed);
        eprintln!("  nloop          = {}", self.max_loops);
        match self.periodic_box {
            Some((min, max, flags)) => eprintln!(
                "  pbc            = [{:.6}, {:.6}, {:.6}] -> [{:.6}, {:.6}, {:.6}]  flags={:?}",
                min[0], min[1], min[2], max[0], max[1], max[2], flags
            ),
            None => eprintln!("  pbc            = off"),
        }
    }

    fn on_initialized(&mut self, sys: &PackContext) {
        if !self.level.is_enabled() {
            return;
        }
        eprintln!(
            "Initialization: time={:.3}s overlap={:.4e} restraints={:.4e}",
            self.elapsed(),
            sys.fdist,
            sys.frest
        );
    }

    fn on_phase_start(&mut self, info: &PhaseInfo) {
        if !self.level.is_enabled() {
            return;
        }
        self.phase_start = Some(Instant::now());
        let desc = match info.molecule_type {
            Some(itype) => format!("type {itype} compaction"),
            None => "all-type optimization".to_string(),
        };
        eprintln!("Phase {}/{}: {desc}", info.phase + 1, info.total_phases);
        if self.level >= MolpackLogLevel::Progress {
            if self.level >= MolpackLogLevel::Verbose {
                eprintln!(
                    "{:>8} {:>14} {:>14} {:>10} {:>10} {:>10}",
                    "Step", "Overlap", "Restraint", "Improve%", "RadScale", "Time"
                );
            } else {
                eprintln!(
                    "{:>8} {:>14} {:>14} {:>10} {:>10}",
                    "Step", "Overlap", "Restraint", "Improve%", "Time"
                );
            }
        }
    }

    fn on_step(&mut self, info: &StepInfo, _sys: &PackContext) {
        if self.level < MolpackLogLevel::Progress || !info.loop_idx.is_multiple_of(self.every) {
            return;
        }
        if self.level >= MolpackLogLevel::Verbose {
            eprintln!(
                "{:>8} {:>14.6e} {:>14.6e} {:>10.3} {:>10.4} {:>10.3}",
                info.loop_idx + 1,
                info.fdist,
                info.frest,
                info.improvement_pct,
                info.radscale,
                self.elapsed(),
            );
        } else {
            eprintln!(
                "{:>8} {:>14.6e} {:>14.6e} {:>10.3} {:>10.3}",
                info.loop_idx + 1,
                info.fdist,
                info.frest,
                info.improvement_pct,
                self.elapsed(),
            );
        }
    }

    fn on_phase_end(&mut self, info: &PhaseInfo, report: &PhaseReport) {
        if !self.level.is_enabled() {
            return;
        }
        eprintln!(
            "Phase {}/{} summary: steps={} converged={} overlap={:.6e} restraints={:.6e} time={:.3}s",
            info.phase + 1,
            info.total_phases,
            report.iterations,
            report.converged,
            report.fdist,
            report.frest,
            self.phase_elapsed(),
        );
    }

    fn on_finish(&mut self, sys: &PackContext) {
        if !self.level.is_enabled() {
            return;
        }
        let converged = sys.fdist < self.precision && sys.frest < self.precision;
        eprintln!(
            "Final summary: converged={} overlap={:.6e} restraints={:.6e} elapsed={:.3}s",
            converged,
            sys.fdist,
            sys.frest,
            self.elapsed(),
        );
    }
}

// ── EarlyStopHandler ──────────────────────────────────────────────────────────

/// Requests early termination when improvement stalls.
///
/// Tracks `fdist + frest` total violation. After `warmup` iterations, if the
/// relative improvement drops below `threshold` for `patience` consecutive
/// steps, sets the stop flag.
///
/// Added as a default handler by [`crate::packer::Molpack::new`].
pub struct EarlyStopHandler {
    /// Relative improvement threshold.
    pub threshold: F,
    /// Iterations to skip before tracking. Default: `5`.
    pub warmup: usize,
    /// Consecutive stall iterations before stopping. Default: `3`.
    pub patience: usize,
    prev_violation: F,
    stall_count: usize,
    stop: bool,
}

impl EarlyStopHandler {
    pub fn new(threshold: F) -> Self {
        Self {
            threshold,
            warmup: 5,
            patience: 3,
            prev_violation: F::INFINITY,
            stall_count: 0,
            stop: false,
        }
    }

    pub fn with_warmup(mut self, warmup: usize) -> Self {
        self.warmup = warmup;
        self
    }

    pub fn with_patience(mut self, patience: usize) -> Self {
        self.patience = patience.max(1);
        self
    }
}

impl Default for EarlyStopHandler {
    /// Default is intentionally conservative (effectively disabled),
    /// so Packmol-sized examples are not stopped before convergence.
    fn default() -> Self {
        Self::new(F::NEG_INFINITY)
    }
}

impl Handler for EarlyStopHandler {
    fn on_initialized(&mut self, _sys: &PackContext) {
        self.prev_violation = F::INFINITY;
        self.stall_count = 0;
        self.stop = false;
    }

    fn on_phase_start(&mut self, _info: &PhaseInfo) {
        self.prev_violation = F::INFINITY;
        self.stall_count = 0;
        self.stop = false;
    }

    fn on_step(&mut self, info: &StepInfo, _sys: &PackContext) {
        let v = info.fdist + info.frest;
        if info.loop_idx <= self.warmup {
            self.prev_violation = v;
            return;
        }
        let rel_change = if self.prev_violation > 0.0 {
            (self.prev_violation - v) / self.prev_violation
        } else if v < objective_small_floor() {
            1.0 // already converged
        } else {
            F::INFINITY
        };

        if rel_change < self.threshold {
            self.stall_count += 1;
            if self.stall_count >= self.patience {
                log::debug!(
                    "EarlyStop: stalled for {} iters (rel_change={:.2e})",
                    self.stall_count,
                    rel_change
                );
                self.stop = true;
            }
        } else {
            self.stall_count = 0;
        }
        self.prev_violation = v;
    }

    fn should_stop(&self) -> bool {
        self.stop
    }
}