mobius 0.15.7

A small, modular Rust framework for building coding agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
//! Streaming tool execution tests.

use super::*;
use crate::ProviderError;
use crate::backend::model::{ToolCall, ToolDefinition};
use crate::middleware::tools::{ExecutionMode, Tool, ToolContext, ToolExposure, Tools};
use crate::protocol::ModelEvent;

#[derive(Clone, Copy)]
enum Terminal {
    Complete,
    Changed,
    Error,
    Hold,
}

struct StreamingModel {
    calls: AtomicUsize,
    release: Arc<Notify>,
    terminal: Terminal,
    tool_finished: Arc<Notify>,
    tool_started: Arc<Notify>,
    wait_for_tool_start: bool,
}

struct StreamingTool {
    calls: Arc<AtomicUsize>,
    finished: Arc<AtomicBool>,
    release: Option<Arc<Notify>>,
    observed: Arc<Notify>,
    started: Arc<Notify>,
    tool_finished: Arc<Notify>,
}

#[derive(Default)]
struct StreamingHooks {
    post_calls: AtomicUsize,
    pre_calls: AtomicUsize,
}

struct PreHookEffects {
    executed: Arc<Notify>,
    calls: AtomicUsize,
}

struct PreHookModel {
    calls: AtomicUsize,
    release: Arc<Notify>,
}

struct ParallelStreamingModel {
    calls: AtomicUsize,
    started: Arc<Notify>,
    started_count: Arc<AtomicUsize>,
}

struct ParallelStreamingTool {
    calls: Arc<AtomicUsize>,
    started: Arc<Notify>,
    started_count: Arc<AtomicUsize>,
}

struct BarrierStreamingModel {
    barrier: Arc<BarrierState>,
    calls: AtomicUsize,
}

struct BarrierStreamingTool {
    barrier: Arc<BarrierState>,
    name: &'static str,
}

struct BarrierState {
    a_started: Notify,
    b_started: Notify,
    c_started: Notify,
    c_prepared: Notify,
    release_a: Notify,
    release_b: Notify,
    release_stream: Notify,
    order: Mutex<Vec<String>>,
}

impl Middleware for BarrierState {
    fn name(&self) -> &'static str {
        "streaming_barrier_state"
    }

    fn pre_tool_use<'a>(
        &'a self,
        context: &'a mut PreToolUseContext<'_>,
    ) -> BoxFuture<'a, Result<()>> {
        Box::pin(async move {
            if context.call().name == "parallel_c" {
                self.c_prepared.notify_one();
            }
            Ok(())
        })
    }
}

impl Model for ParallelStreamingModel {
    fn respond<'a>(
        &'a self,
        _request: ModelRequest,
        events: ModelEventSink,
    ) -> BoxFuture<'a, Result<ModelOutput>> {
        let attempt = self.calls.fetch_add(1, Ordering::SeqCst);
        if attempt > 0 {
            return Box::pin(async { Ok(scripted_message("done")) });
        }
        let started = Arc::clone(&self.started);
        let started_count = Arc::clone(&self.started_count);
        Box::pin(async move {
            for call_id in ["parallel-1", "parallel-2"] {
                events(ModelEvent::ToolCallReady(ToolCall {
                    call_id: call_id.into(),
                    name: "parallel_streaming_tool".into(),
                    arguments: serde_json::json!({"call_id": call_id}),
                }))?;
            }
            while started_count.load(Ordering::SeqCst) < 2 {
                started.notified().await;
            }
            ModelOutput::from_output(
                ["parallel-1", "parallel-2"]
                    .into_iter()
                    .map(|call_id| {
                        serde_json::json!({
                            "type": "function_call",
                            "call_id": call_id,
                            "name": "parallel_streaming_tool",
                            "arguments": format!("{{\"call_id\":\"{call_id}\"}}")
                        })
                    })
                    .collect(),
                false,
                scripted_usage(),
            )
        })
    }
}

impl Tool for ParallelStreamingTool {
    fn definition(&self) -> ToolDefinition {
        ToolDefinition {
            name: "parallel_streaming_tool".into(),
            description: "a parallel streaming test tool".into(),
            parameters: serde_json::json!({"type": "object"}),
        }
    }

    fn exposure(&self) -> ToolExposure {
        ToolExposure::Direct
    }

    fn execution_mode(&self) -> ExecutionMode {
        ExecutionMode::Parallel
    }

    fn call<'a>(
        &'a self,
        _context: ToolContext,
        _arguments: Value,
    ) -> BoxFuture<'a, Result<String>> {
        let calls = Arc::clone(&self.calls);
        let started = Arc::clone(&self.started);
        let started_count = Arc::clone(&self.started_count);
        Box::pin(async move {
            calls.fetch_add(1, Ordering::SeqCst);
            started_count.fetch_add(1, Ordering::SeqCst);
            started.notify_waiters();
            Ok("parallel result".into())
        })
    }
}

impl Model for BarrierStreamingModel {
    fn respond<'a>(
        &'a self,
        _request: ModelRequest,
        events: ModelEventSink,
    ) -> BoxFuture<'a, Result<ModelOutput>> {
        let attempt = self.calls.fetch_add(1, Ordering::SeqCst);
        if attempt > 0 {
            return Box::pin(async { Ok(scripted_message("done")) });
        }
        let barrier = Arc::clone(&self.barrier);
        Box::pin(async move {
            for (call_id, name) in [
                ("barrier-a", "parallel_a"),
                ("barrier-b", "exclusive_b"),
                ("barrier-c", "parallel_c"),
            ] {
                events(ModelEvent::ToolCallReady(ToolCall {
                    call_id: call_id.into(),
                    name: name.into(),
                    arguments: serde_json::json!({}),
                }))?;
            }
            barrier.c_prepared.notified().await;
            events(ModelEvent::TextDelta("barrier-admitted".into()))?;
            barrier.release_stream.notified().await;
            ModelOutput::from_output(
                [
                    ("barrier-a", "parallel_a"),
                    ("barrier-b", "exclusive_b"),
                    ("barrier-c", "parallel_c"),
                ]
                .into_iter()
                .map(|(call_id, name)| {
                    serde_json::json!({
                        "type": "function_call",
                        "call_id": call_id,
                        "name": name,
                        "arguments": "{}"
                    })
                })
                .collect(),
                false,
                scripted_usage(),
            )
        })
    }
}

impl Tool for BarrierStreamingTool {
    fn definition(&self) -> ToolDefinition {
        ToolDefinition {
            name: self.name.into(),
            description: "a mixed barrier streaming test tool".into(),
            parameters: serde_json::json!({"type": "object"}),
        }
    }

    fn exposure(&self) -> ToolExposure {
        ToolExposure::Direct
    }

    fn execution_mode(&self) -> ExecutionMode {
        if self.name == "exclusive_b" {
            ExecutionMode::Exclusive
        } else {
            ExecutionMode::Parallel
        }
    }

    fn call<'a>(
        &'a self,
        _context: ToolContext,
        _arguments: Value,
    ) -> BoxFuture<'a, Result<String>> {
        let barrier = Arc::clone(&self.barrier);
        let name = self.name;
        Box::pin(async move {
            barrier
                .order
                .lock()
                .expect("barrier order lock")
                .push(name.into());
            match name {
                "parallel_a" => {
                    barrier.a_started.notify_one();
                    barrier.release_a.notified().await;
                }
                "exclusive_b" => {
                    barrier.b_started.notify_one();
                    barrier.release_b.notified().await;
                }
                "parallel_c" => barrier.c_started.notify_one(),
                _ => unreachable!("unknown barrier tool"),
            }
            Ok(name.into())
        })
    }
}

impl Model for StreamingModel {
    fn respond<'a>(
        &'a self,
        _request: ModelRequest,
        events: ModelEventSink,
    ) -> BoxFuture<'a, Result<ModelOutput>> {
        let attempt = self.calls.fetch_add(1, Ordering::SeqCst);
        if attempt > 0 {
            return Box::pin(async { Ok(scripted_message("done")) });
        }
        let release = Arc::clone(&self.release);
        let terminal = self.terminal;
        let tool_finished = Arc::clone(&self.tool_finished);
        let tool_started = Arc::clone(&self.tool_started);
        let wait_for_tool_start = self.wait_for_tool_start;
        Box::pin(async move {
            events(ModelEvent::ToolCallReady(ToolCall {
                call_id: "stream-call".into(),
                name: "streaming_tool".into(),
                arguments: serde_json::json!({"value": "ready"}),
            }))?;
            if wait_for_tool_start {
                tool_started.notified().await;
            }
            if matches!(
                terminal,
                Terminal::Changed | Terminal::Error | Terminal::Complete
            ) {
                tool_finished.notified().await;
            }
            match terminal {
                Terminal::Complete => Ok(streaming_tool_output(false)),
                Terminal::Changed => Ok(streaming_tool_output_with_arguments(
                    "{\"value\":\"changed\"}",
                    false,
                )),
                Terminal::Error => Err(Error::Provider(ProviderError::stream_interrupted(None))),
                Terminal::Hold => {
                    release.notified().await;
                    Ok(streaming_tool_output(false))
                }
            }
        })
    }
}

impl Tool for StreamingTool {
    fn definition(&self) -> ToolDefinition {
        ToolDefinition {
            name: "streaming_tool".into(),
            description: "a deterministic streaming test tool".into(),
            parameters: serde_json::json!({"type": "object"}),
        }
    }

    fn exposure(&self) -> ToolExposure {
        ToolExposure::Direct
    }

    fn call<'a>(
        &'a self,
        _context: ToolContext,
        _arguments: Value,
    ) -> BoxFuture<'a, Result<String>> {
        self.calls.fetch_add(1, Ordering::SeqCst);
        let finished = Arc::clone(&self.finished);
        let release = self.release.clone();
        let observed = Arc::clone(&self.observed);
        let started = Arc::clone(&self.started);
        let tool_finished = Arc::clone(&self.tool_finished);
        Box::pin(async move {
            started.notify_one();
            observed.notify_one();
            if let Some(release) = release {
                release.notified().await;
            }
            finished.store(true, Ordering::SeqCst);
            tool_finished.notify_one();
            Ok("streamed result".into())
        })
    }
}

impl Middleware for StreamingHooks {
    fn name(&self) -> &'static str {
        "streaming_hooks"
    }

    fn pre_tool_use<'a>(
        &'a self,
        _context: &'a mut PreToolUseContext<'_>,
    ) -> BoxFuture<'a, Result<()>> {
        Box::pin(async move {
            self.pre_calls.fetch_add(1, Ordering::SeqCst);
            Ok(())
        })
    }

    fn post_tool_use<'a>(
        &'a self,
        _context: &'a mut PostToolUseContext<'_>,
    ) -> BoxFuture<'a, Result<()>> {
        Box::pin(async move {
            self.post_calls.fetch_add(1, Ordering::SeqCst);
            Ok(())
        })
    }
}

impl Middleware for PreHookEffects {
    fn name(&self) -> &'static str {
        "streaming_pre_hook_effects"
    }

    fn pre_tool_use<'a>(
        &'a self,
        context: &'a mut PreToolUseContext<'_>,
    ) -> BoxFuture<'a, Result<()>> {
        Box::pin(async move {
            self.calls.fetch_add(1, Ordering::SeqCst);
            context.push_input(crate::backend::model::internal_user_message(
                "streaming_pre_hook",
                "before tool",
            ));
            context.events.push(EventMsg::ContextCompacted);
            self.executed.notify_one();
            Ok(())
        })
    }
}

impl Model for PreHookModel {
    fn respond<'a>(
        &'a self,
        _request: ModelRequest,
        events: ModelEventSink,
    ) -> BoxFuture<'a, Result<ModelOutput>> {
        let attempt = self.calls.fetch_add(1, Ordering::SeqCst);
        if attempt > 0 {
            return Box::pin(async { Ok(scripted_message("done")) });
        }
        let release = Arc::clone(&self.release);
        Box::pin(async move {
            events(ModelEvent::ToolCallReady(ToolCall {
                call_id: "stream-call".into(),
                name: "streaming_tool".into(),
                arguments: serde_json::json!({"value": "ready"}),
            }))?;
            release.notified().await;
            ModelOutput::from_output(
                vec![
                    serde_json::json!({
                        "type": "message",
                        "role": "assistant",
                        "content": [{"type": "output_text", "text": "assistant prefix"}]
                    }),
                    serde_json::json!({
                        "type": "function_call",
                        "call_id": "stream-call",
                        "name": "streaming_tool",
                        "arguments": "{\"value\":\"ready\"}"
                    }),
                ],
                false,
                scripted_usage(),
            )
        })
    }
}

fn streaming_tool_output(end_turn: bool) -> ModelOutput {
    streaming_tool_output_with_arguments("{\"value\":\"ready\"}", end_turn)
}

fn streaming_tool_output_with_arguments(arguments: &str, end_turn: bool) -> ModelOutput {
    ModelOutput::from_output(
        vec![serde_json::json!({
            "type": "function_call",
            "call_id": "stream-call",
            "name": "streaming_tool",
            "arguments": arguments
        })],
        end_turn,
        scripted_usage(),
    )
    .expect("streaming tool output")
}

fn streaming_config(
    workspace: &Path,
    checkpoints: Arc<dyn CheckpointStore>,
    session_id: &str,
    model: Arc<dyn Model>,
    tool: Arc<dyn Tool>,
    hooks: Arc<dyn Middleware>,
) -> AgentConfig {
    AgentConfig::new(
        Arc::new(ModelRouter::new("streaming-test", model)),
        Arc::new(Sandbox::new(
            Arc::new(LocalSandbox::new(workspace).expect("local sandbox")),
            ApprovalPolicy::Allow,
        )),
        checkpoints,
        test_middleware(vec![Arc::new(Tools::new(vec![tool])), hooks]),
        "test prompt",
    )
    .session_context(test_session_context())
    .session_id(session_id)
}

fn streaming_config_with_tools(
    workspace: &Path,
    checkpoints: Arc<dyn CheckpointStore>,
    session_id: &str,
    model: Arc<dyn Model>,
    tools: Vec<Arc<dyn Tool>>,
    hooks: Arc<dyn Middleware>,
) -> AgentConfig {
    AgentConfig::new(
        Arc::new(ModelRouter::new("streaming-test", model)),
        Arc::new(Sandbox::new(
            Arc::new(LocalSandbox::new(workspace).expect("local sandbox")),
            ApprovalPolicy::Allow,
        )),
        checkpoints,
        test_middleware(vec![Arc::new(Tools::new(tools)), hooks]),
        "test prompt",
    )
    .session_context(test_session_context())
    .session_id(session_id)
}

async fn collect_until_turn_end(agent: &mut Agent) -> Vec<EventMsg> {
    tokio::time::timeout(std::time::Duration::from_secs(5), async {
        let mut events = Vec::new();
        while let Some(event) = agent.next_event().await {
            let terminal = matches!(
                event.msg,
                EventMsg::TurnComplete(_) | EventMsg::TurnAborted(_)
            );
            events.push(event.msg);
            if terminal {
                break;
            }
        }
        events
    })
    .await
    .expect("streaming turn did not reach a terminal event")
}

fn canonical_tool_items(context: &[Value]) -> Vec<String> {
    context
        .iter()
        .filter_map(|item| {
            let kind = item.get("type")?.as_str()?;
            let call_id = item.get("call_id")?.as_str()?;
            matches!(kind, "function_call" | "function_call_output")
                .then(|| format!("{kind}:{call_id}"))
        })
        .collect()
}

#[tokio::test]
async fn streaming_tool_runs_before_final_model_step_and_persists_once() {
    let workspace = tempfile::tempdir().expect("workspace");
    let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
        SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
            .expect("checkpoint store"),
    );
    let tool_started = Arc::new(Notify::new());
    let tool_finished = Arc::new(Notify::new());
    let tool_calls = Arc::new(AtomicUsize::new(0));
    let hooks = Arc::new(StreamingHooks::default());
    let model = Arc::new(StreamingModel {
        calls: AtomicUsize::new(0),
        release: Arc::new(Notify::new()),
        terminal: Terminal::Complete,
        tool_finished: Arc::clone(&tool_finished),
        tool_started: Arc::clone(&tool_started),
        wait_for_tool_start: true,
    });
    let mut agent = create_agent(streaming_config(
        workspace.path(),
        Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
        "streaming-success",
        model.clone(),
        Arc::new(StreamingTool {
            calls: Arc::clone(&tool_calls),
            finished: Arc::new(AtomicBool::new(false)),
            release: None,
            observed: Arc::new(Notify::new()),
            started: Arc::clone(&tool_started),
            tool_finished,
        }),
        hooks.clone(),
    ))
    .await
    .expect("create agent");
    agent
        .sender()
        .submit(user_op("stream a tool"))
        .expect("submit input");

    let events = collect_until_turn_end(&mut agent).await;
    let begin = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ToolCallBegin(call) if call.call_id == "stream-call"),
        )
        .expect("tool begin");
    let completed = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ModelStepCompleted(step) if step.step_index == 0),
        )
        .expect("model step completion");
    let end = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ToolCallEnd(call) if call.call_id == "stream-call"),
        )
        .expect("tool end");

    assert!(begin < completed && completed < end);
    assert_eq!(
        events
            .iter()
            .filter(|event| matches!(event, EventMsg::ToolCallBegin(_)))
            .count(),
        1
    );
    assert_eq!(
        events
            .iter()
            .filter(|event| matches!(event, EventMsg::ToolCallEnd(_)))
            .count(),
        1
    );
    assert_eq!(tool_calls.load(Ordering::SeqCst), 1);
    assert_eq!(hooks.pre_calls.load(Ordering::SeqCst), 1);
    assert_eq!(hooks.post_calls.load(Ordering::SeqCst), 1);
    assert_eq!(model.calls.load(Ordering::SeqCst), 2);

    let saved = checkpoints
        .load("streaming-success")
        .await
        .expect("load checkpoint")
        .expect("saved checkpoint");
    assert_eq!(
        canonical_tool_items(&saved.context),
        [
            "function_call:stream-call".to_string(),
            "function_call_output:stream-call".to_string(),
        ]
    );
}

#[tokio::test]
async fn streaming_prehook_effects_are_applied_before_tool_launch() {
    let workspace = tempfile::tempdir().expect("workspace");
    let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
        SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
            .expect("checkpoint store"),
    );
    let prehook = Arc::new(PreHookEffects {
        executed: Arc::new(Notify::new()),
        calls: AtomicUsize::new(0),
    });
    let tool_finished = Arc::new(Notify::new());
    let model = Arc::new(PreHookModel {
        calls: AtomicUsize::new(0),
        release: Arc::new(Notify::new()),
    });
    let mut agent = create_agent(streaming_config(
        workspace.path(),
        Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
        "streaming-prehook",
        model.clone(),
        Arc::new(StreamingTool {
            calls: Arc::new(AtomicUsize::new(0)),
            finished: Arc::new(AtomicBool::new(false)),
            release: None,
            observed: Arc::new(Notify::new()),
            started: Arc::new(Notify::new()),
            tool_finished,
        }),
        prehook.clone(),
    ))
    .await
    .expect("create agent");
    agent
        .sender()
        .submit(user_op("stream with pre-tool effects"))
        .expect("submit input");
    tokio::time::timeout(
        std::time::Duration::from_secs(5),
        drain_until_notified(&mut agent, &prehook.executed),
    )
    .await
    .expect("pre-tool hook executed");
    model.release.notify_one();

    let events = collect_until_turn_end(&mut agent).await;
    let completed = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ModelStepCompleted(step) if step.step_index == 0),
        )
        .expect("model step completion");
    let begin = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ToolCallBegin(call) if call.call_id == "stream-call"),
        )
        .expect("tool begin");
    let end = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ToolCallEnd(call) if call.call_id == "stream-call"),
        )
        .expect("tool end");

    assert!(completed < begin && begin < end);
    assert_eq!(prehook.calls.load(Ordering::SeqCst), 1);
    assert_eq!(
        events
            .iter()
            .filter(|event| matches!(event, EventMsg::ContextCompacted))
            .count(),
        1
    );

    let saved = checkpoints
        .load("streaming-prehook")
        .await
        .expect("load checkpoint")
        .expect("saved checkpoint");
    let ordered = saved
        .context
        .iter()
        .filter_map(|item| {
            if item.get("role").and_then(Value::as_str) == Some("assistant") {
                return Some("assistant".to_string());
            }
            if internal_message_kind(item) == Some("streaming_pre_hook") {
                return Some("prehook".to_string());
            }
            let kind = item.get("type").and_then(Value::as_str)?;
            let call_id = item.get("call_id").and_then(Value::as_str)?;
            matches!(kind, "function_call" | "function_call_output")
                .then(|| format!("{kind}:{call_id}"))
        })
        .collect::<Vec<_>>();
    assert_eq!(
        &ordered[..4],
        [
            "assistant".to_string(),
            "prehook".to_string(),
            "function_call:stream-call".to_string(),
            "function_call_output:stream-call".to_string(),
        ]
    );
}

#[tokio::test]
async fn streaming_tool_error_or_mismatch_does_not_retry_and_records_unknown_result() {
    for (session_id, terminal, prompt) in [
        (
            "streaming-error",
            Terminal::Error,
            "fail after streaming a tool",
        ),
        (
            "streaming-mismatch",
            Terminal::Changed,
            "change the streamed tool arguments",
        ),
    ] {
        let workspace = tempfile::tempdir().expect("workspace");
        let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
            SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
                .expect("checkpoint store"),
        );
        let tool_started = Arc::new(Notify::new());
        let tool_finished = Arc::new(Notify::new());
        let model = Arc::new(StreamingModel {
            calls: AtomicUsize::new(0),
            release: Arc::new(Notify::new()),
            terminal,
            tool_finished: Arc::clone(&tool_finished),
            tool_started: Arc::clone(&tool_started),
            wait_for_tool_start: true,
        });
        let mut agent = create_agent(streaming_config(
            workspace.path(),
            Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
            session_id,
            model.clone(),
            Arc::new(StreamingTool {
                calls: Arc::new(AtomicUsize::new(0)),
                finished: Arc::new(AtomicBool::new(false)),
                release: None,
                observed: Arc::new(Notify::new()),
                started: tool_started,
                tool_finished,
            }),
            Arc::new(StreamingHooks::default()),
        ))
        .await
        .expect("create agent");
        agent
            .sender()
            .submit(user_op(prompt))
            .expect("submit input");
        collect_until_turn_end(&mut agent).await;

        assert_eq!(model.calls.load(Ordering::SeqCst), 1);
        let saved = checkpoints
            .load(session_id)
            .await
            .expect("load checkpoint")
            .expect("saved checkpoint");
        assert_eq!(
            canonical_tool_items(&saved.context),
            [
                "function_call:stream-call".to_string(),
                "function_call_output:stream-call".to_string(),
            ]
        );
        let output = saved
            .context
            .iter()
            .find(|item| item.get("type").and_then(Value::as_str) == Some("function_call_output"))
            .and_then(|item| item.get("output"))
            .and_then(Value::as_str)
            .expect("unknown tool output");
        assert!(output.contains("result unknown"));
    }
}

#[tokio::test]
async fn streaming_parallel_tools_start_before_final_model_output_and_keep_order() {
    let workspace = tempfile::tempdir().expect("workspace");
    let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
        SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
            .expect("checkpoint store"),
    );
    let started = Arc::new(Notify::new());
    let started_count = Arc::new(AtomicUsize::new(0));
    let calls = Arc::new(AtomicUsize::new(0));
    let model = Arc::new(ParallelStreamingModel {
        calls: AtomicUsize::new(0),
        started: Arc::clone(&started),
        started_count: Arc::clone(&started_count),
    });
    let mut agent = create_agent(streaming_config(
        workspace.path(),
        Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
        "streaming-parallel",
        model.clone(),
        Arc::new(ParallelStreamingTool {
            calls: Arc::clone(&calls),
            started,
            started_count,
        }),
        Arc::new(StreamingHooks::default()),
    ))
    .await
    .expect("create agent");
    agent
        .sender()
        .submit(user_op("stream two tools"))
        .expect("submit input");

    let events = collect_until_turn_end(&mut agent).await;
    let completed = events
        .iter()
        .position(
            |event| matches!(event, EventMsg::ModelStepCompleted(step) if step.step_index == 0),
        )
        .expect("model step completion");
    for call_id in ["parallel-1", "parallel-2"] {
        let begin = events
            .iter()
            .position(
                |event| matches!(event, EventMsg::ToolCallBegin(call) if call.call_id == call_id),
            )
            .expect("tool begin");
        let end = events
            .iter()
            .position(
                |event| matches!(event, EventMsg::ToolCallEnd(call) if call.call_id == call_id),
            )
            .expect("tool end");
        assert!(begin < completed && completed < end);
    }
    assert_eq!(calls.load(Ordering::SeqCst), 2);
    assert_eq!(model.calls.load(Ordering::SeqCst), 2);

    let saved = checkpoints
        .load("streaming-parallel")
        .await
        .expect("load checkpoint")
        .expect("saved checkpoint");
    assert_eq!(
        canonical_tool_items(&saved.context),
        [
            "function_call:parallel-1".to_string(),
            "function_call:parallel-2".to_string(),
            "function_call_output:parallel-1".to_string(),
            "function_call_output:parallel-2".to_string(),
        ]
    );
}

#[tokio::test]
async fn streaming_mixed_parallel_and_exclusive_tools_respect_barriers() {
    let workspace = tempfile::tempdir().expect("workspace");
    let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
        SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
            .expect("checkpoint store"),
    );
    let barrier = Arc::new(BarrierState {
        a_started: Notify::new(),
        b_started: Notify::new(),
        c_started: Notify::new(),
        c_prepared: Notify::new(),
        release_a: Notify::new(),
        release_b: Notify::new(),
        release_stream: Notify::new(),
        order: Mutex::new(Vec::new()),
    });
    let model = Arc::new(BarrierStreamingModel {
        barrier: Arc::clone(&barrier),
        calls: AtomicUsize::new(0),
    });
    let tools = ["parallel_a", "exclusive_b", "parallel_c"]
        .into_iter()
        .map(|name| {
            Arc::new(BarrierStreamingTool {
                barrier: Arc::clone(&barrier),
                name,
            }) as Arc<dyn Tool>
        })
        .collect();
    let mut agent = create_agent(streaming_config_with_tools(
        workspace.path(),
        Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
        "streaming-mixed-barriers",
        model.clone(),
        tools,
        barrier.clone(),
    ))
    .await
    .expect("create agent");
    agent
        .sender()
        .submit(user_op("stream mixed barriers"))
        .expect("submit input");

    tokio::time::timeout(
        std::time::Duration::from_secs(5),
        drain_until_notified(&mut agent, &barrier.a_started),
    )
    .await
    .expect("parallel A started");
    assert_eq!(
        barrier.order.lock().expect("barrier order lock").as_slice(),
        ["parallel_a"]
    );
    tokio::time::timeout(std::time::Duration::from_secs(5), async {
        loop {
            let event = agent.next_event().await.expect("agent event");
            if matches!(
                event.msg,
                EventMsg::AssistantContentDelta(delta) if delta.delta == "barrier-admitted"
            ) {
                break;
            }
        }
    })
    .await
    .expect("all streamed tools admitted");
    assert_eq!(
        barrier.order.lock().expect("barrier order lock").as_slice(),
        ["parallel_a"]
    );
    barrier.release_a.notify_one();

    tokio::time::timeout(
        std::time::Duration::from_secs(5),
        drain_until_notified(&mut agent, &barrier.b_started),
    )
    .await
    .expect("exclusive B started");
    assert_eq!(
        barrier.order.lock().expect("barrier order lock").as_slice(),
        ["parallel_a", "exclusive_b"]
    );
    barrier.release_b.notify_one();

    tokio::time::timeout(
        std::time::Duration::from_secs(5),
        drain_until_notified(&mut agent, &barrier.c_started),
    )
    .await
    .expect("parallel C started");
    assert_eq!(
        barrier.order.lock().expect("barrier order lock").as_slice(),
        ["parallel_a", "exclusive_b", "parallel_c"]
    );
    assert_eq!(barrier.order.lock().expect("barrier order lock").len(), 3);
    barrier.release_stream.notify_one();

    let _events = collect_until_turn_end(&mut agent).await;
    assert_eq!(model.calls.load(Ordering::SeqCst), 2);

    let saved = checkpoints
        .load("streaming-mixed-barriers")
        .await
        .expect("load checkpoint")
        .expect("saved checkpoint");
    assert_eq!(
        canonical_tool_items(&saved.context),
        [
            "function_call:barrier-a".to_string(),
            "function_call:barrier-b".to_string(),
            "function_call:barrier-c".to_string(),
            "function_call_output:barrier-a".to_string(),
            "function_call_output:barrier-b".to_string(),
            "function_call_output:barrier-c".to_string(),
        ]
    );
}

#[tokio::test]
async fn interrupt_drops_a_running_streaming_tool() {
    let workspace = tempfile::tempdir().expect("workspace");
    let checkpoints: Arc<dyn CheckpointStore> = Arc::new(
        SqliteCheckpoint::new(workspace.path().join("checkpoints.sqlite3"))
            .expect("checkpoint store"),
    );
    let tool_started = Arc::new(Notify::new());
    let tool_finished = Arc::new(Notify::new());
    let tool_done = Arc::new(AtomicBool::new(false));
    let model_release = Arc::new(Notify::new());
    let model = Arc::new(StreamingModel {
        calls: AtomicUsize::new(0),
        release: Arc::clone(&model_release),
        terminal: Terminal::Hold,
        tool_finished: Arc::new(Notify::new()),
        tool_started: Arc::new(Notify::new()),
        wait_for_tool_start: false,
    });
    let mut agent = create_agent(streaming_config(
        workspace.path(),
        Arc::clone(&checkpoints) as Arc<dyn CheckpointStore>,
        "streaming-interrupt",
        model.clone(),
        Arc::new(StreamingTool {
            calls: Arc::new(AtomicUsize::new(0)),
            finished: Arc::clone(&tool_done),
            release: Some(Arc::clone(&tool_finished)),
            observed: Arc::clone(&tool_started),
            started: Arc::new(Notify::new()),
            tool_finished: Arc::new(Notify::new()),
        }),
        Arc::new(StreamingHooks::default()),
    ))
    .await
    .expect("create agent");
    agent
        .sender()
        .submit(user_op("interrupt the streaming tool"))
        .expect("submit input");
    let turn_id = loop {
        if let EventMsg::ModelStepStarted(step) = agent.next_event().await.expect("agent event").msg
        {
            break step.turn_id;
        }
    };
    tokio::time::timeout(
        std::time::Duration::from_secs(1),
        drain_until_notified(&mut agent, &tool_started),
    )
    .await
    .expect("tool started");
    agent
        .sender()
        .submit(Op::Interrupt { turn_id })
        .expect("interrupt turn");
    while !matches!(
        agent.next_event().await.expect("agent event").msg,
        EventMsg::TurnAborted(_)
    ) {}
    model_release.notify_waiters();
    tool_finished.notify_waiters();

    assert!(!tool_done.load(Ordering::SeqCst));
    assert_eq!(model.calls.load(Ordering::SeqCst), 1);
    let saved = checkpoints
        .load("streaming-interrupt")
        .await
        .expect("load checkpoint")
        .expect("saved checkpoint");
    assert_eq!(
        canonical_tool_items(&saved.context),
        [
            "function_call:stream-call".to_string(),
            "function_call_output:stream-call".to_string(),
        ]
    );
}