mlx90393 0.1.2

MLX90393 magnetometer driver
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
#![no_std]
#![allow(dead_code)]
#![allow(unused_variables)]

// mlx90393 librarry

//#![feature(inherent_associated_types)]
pub mod error;

use crate::data::MeasurementMode::{Single, WakeOnChange};
use crate::error::Error::{self};

pub mod data;
use crate::data::{Status, MeasurementMode, ScaledMeasurements, RawMeasurements, Resolution, Register_0x02, Register_0x01, Register_0x00, 
                     XYZOffset};

pub mod constants;
use crate::constants::{DIGITAL_FILTER_REGISTER, DeviceAddress, Exit_mode, GAIN_REGISTER, Memory_Recall, Memory_Store, 
    REGISTER_00, REGISTER_01, REGISTER_03, REGISTER_04, REGISTER_05, REGISTER_06, REGISTER_07, REGISTER_08, REGISTER_09, 
    RES_XYZ_REGISTER, Read_Measurement, Read_Register, Reset, SENS_XY, SENS_Z, Start_Burst_Mode, Start_Single_Measurement, 
    Start_Wake_On_Change, Write_Register};



// #[cfg(not(feature = "async"))]
use embedded_hal::{i2c::I2c, delay::DelayNs, digital::InputPin};
#[cfg(feature = "async")]
use embedded_hal_async::{i2c::I2c as AsyncI2c, delay::DelayNs as AsyncDelayNs, digital::Wait as InputPinWait};


use log::Level::Info;
use log::{debug, info, warn};

use libm::{powf, truncf, roundf};


/// the MLX90393 device
pub struct MLX90393<I2C, D, P> {
    /// I²C interface
    i2c: I2C,
    /// I²C device address
    address: DeviceAddress,
    delayer: D,
    t: u8, // time enable if == 1
    x: u8, // x field axis enabled if == 1
    y: u8, // y field axis enabled if == 1
    z: u8, // z field axis enabled if == 1
    conversion_time: u32,  // must be kept up to date as setting change
    gain_sel: u8 ,  // must be kept up to date as setting change
    hall_conf: u8, // " " "
    resolution: Resolution, // " " ""
    tcmp_enabled: bool,
    drdy_input:  Option<P>,  // data ready input pin
    measurement_mode: MeasurementMode,

}

#[cfg(not(feature = "async"))]
impl<I2C, D, E, P> MLX90393<I2C, D, P>
where  
    I2C: I2c<Error = E>,
    D: DelayNs,
    P: InputPin,
{

    /// create new MLX90393 driver with address, t,x,y,z and input pin
    /// if input pin is not None then it is expected to be wired to MLX90393 INT (DRDY) output pin
    /// and it will be checked every 1 msec in read_data_by_txyz_xxx fns, up to 200 times before timeout error
    pub fn new(i2c: I2C, address: DeviceAddress, delayer: D, 
                t: bool, x: bool, y: bool, z: bool, pin: Option<P>) -> Self {
        log::debug!("new called");
        Self {
            i2c,
            address: address,
            delayer,
            t: if t {1} else {0},
            x: if x {1} else {0},
            y: if y {1} else {0},
            z: if z {1} else {0},
            conversion_time: 0,
            gain_sel: 7,
            resolution: Resolution { x: 0, y: 0, z: 0 },
            hall_conf: 0xc,
            tcmp_enabled: false,
            drdy_input: pin,
            measurement_mode: MeasurementMode::Single,
        }
    }


    /// give back the I2C interface
    pub fn release(self) -> I2C {
        self.i2c
    }

}

#[cfg(feature = "async")]
impl<I2C, D, E, P> MLX90393<I2C, D, P>
where  
    I2C: AsyncI2c<Error = E>,
    D: AsyncDelayNs,
    P: InputPin,  // if P trait bound to InputPinAwait the pin.wait_for_rising_edge() gets stuck forever
                    // so using a simple sync trait bound instead.
{
    /// create new MLX90393 driver with address, t,x,y,z and input pin
    /// if input pin is Some then it is expected to be wired to MLX90393 INT (DRDY) output pin
    /// and it will be checked every 1 msec in read_data_by_txyz_xxx fns, up to 200 times before timeout error
    pub fn new(i2c: I2C, address: DeviceAddress, delayer: D, 
                t: bool, x: bool, y: bool, z: bool, pin: Option<P>) -> Self {
        log::debug!("new called");
        Self {
            i2c,
            address: address,
            delayer,
            t: if t {1} else {0},
            x: if x {1} else {0},
            y: if y {1} else {0},
            z: if z {1} else {0},
            conversion_time: 0,
            gain_sel: 7,
            resolution: Resolution { x: 0, y: 0, z: 0 },
            hall_conf: 0xc,
            tcmp_enabled: false,
            drdy_input: pin,
            measurement_mode: MeasurementMode::Single,
        }
    }

    //  RPi does not like a release method here /// give back the I2C interface
    // pub fn release(self) -> I2C {
    //     self.i2c
    // }

}

#[maybe_async_cfg::maybe(
    sync(
        cfg(not(feature = "async")),
        self = "MLX90393",
            idents(AsyncI2c(sync = "I2c"), AsyncDelayNs(sync = "DelayNs"), InputPinWait(sync = "InputPin"))
    ),
    async(feature = "async", keep_self)
)]

impl<I2C, D, E, P> MLX90393<I2C, D, P>
where  
    I2C: AsyncI2c<Error = E>,
    D: AsyncDelayNs,
    P: InputPin,
{

    // command_buf is an u8 array that starts with command byte followed by command data byte(s)
    async fn write_command<const N: usize>(&mut self, command_buf: [u8; N] ) -> Result<(), Error<E>> {
        // debug!("write_command : {:#?}", command_buf);
        debug!("in write_command: command = {:#02x}", command_buf[0]);
        debug!("  i2c address = {:#02x}", self.address as u8);
        self.i2c
            .write(self.address as u8, &command_buf).await
            .map_err(Error::I2c)?;
        Ok(())
    }

    async fn read_register( &mut self, register_address: u8, buffer: &mut [u8] ) -> Result<Status, Error<E>> {
        let mut command_buffer = [0u8; 2];
        command_buffer[0] = Read_Register;
        command_buffer[1] = (register_address & 0x3f)  << 2;
        let mut read_buffer = [0u8; 3];    
        self.i2c
            .write_read(self.address as u8, &command_buffer, &mut read_buffer).await
            .map_err(Error::I2c)?;
        let status: Status = Status(read_buffer[0]);  // status byte is always first byte
        buffer[0] = read_buffer[1];
        buffer[1] = read_buffer[2];
        Ok(status)
    }

    /// read register free memory (0x0A - 0x1F)
    pub async fn read_register_free( &mut self, register_address: u8 ) -> Result<u16, Error<E>> {
        if (register_address < 0x0a) || (register_address > 0x1f) {
            return Err(Error::OutOfRange(register_address));
        }
        let mut command_buffer = [0u8; 2];
        command_buffer[0] = Read_Register;
        command_buffer[1] = (register_address & 0x3f)  << 2;
        let mut read_buffer = [0u8; 3];    
        self.i2c
            .write_read(self.address as u8, &command_buffer, &mut read_buffer).await
            .map_err(Error::I2c)?;
        //let status: Status = Status(read_buffer[0]);  // status byte is always first byte
        let buffer = u16::from_be_bytes([read_buffer[0], read_buffer[1] ]);  // is byte order correct?
        //buffer[0] = read_buffer[1];
        //buffer[1] = read_buffer[2];
        Ok(buffer)
    }


    async fn write_register( &mut self, register_address: u8, data: &mut [u8] ) -> Result<Status, Error<E>> {
        let mut command_buffer = [0u8; 4];
        let mut buffer = [0u8; 1];
        command_buffer[0] = Write_Register;
        command_buffer[1] = data[0];
        command_buffer[2] = data[1];
        command_buffer[3] = (register_address & 0x3f) << 2;
        self.i2c.write_read(self.address as u8, &command_buffer, &mut buffer).await
            .map_err(Error::I2c)?;
        let status: Status = Status(buffer[0]);
        Ok(status)
    }

    /// write register free memory (register address 0x0A - 0x1F)
    pub async fn write_register_free(&mut self, register_address: u8, data: &mut u16 ) -> Result<(), Error<E>> {
        if (register_address < 0x0a) || (register_address > 0x1f) {
            return Err(Error::OutOfRange(register_address));
        }
        let mut command_buffer = [0u8; 4];
        let mut buffer = [0u8; 1];
        let data_buffer: [u8; 2] = data.to_be_bytes();
        command_buffer[0] = Write_Register;
        command_buffer[1] = data_buffer[0];
        command_buffer[2] = data_buffer[1];
        command_buffer[3] = (register_address & 0x3f) << 2;
        self.i2c.write_read(self.address as u8, &command_buffer, &mut buffer).await
            .map_err(Error::I2c)?;
        // let status: Status = Status(buffer[0]);

        Ok(())        
    }

    async fn read_status_byte( &mut self, buffer: &mut [u8] ) -> Result<(), Error<E>> {
        debug!("in read_status_byte()");
        self.i2c.read(self.address as u8, buffer).await
            .map_err(Error::I2c)?;
        Ok(())
    }

    async fn write_get_status<const N: usize>( &mut self, command_buffer: [u8; N]) ->
            Result<Status, Error<E>> {
        debug!("in write_get_status");
        let mut result_buffer = [0u8; 1];
        // self.i2c
        //     .write(self.address as u8, &command_buffer).await
        //     .map_err(Error::I2c)?;
        // debug!("  wrote command ok, reading status now");
        // self.delayer.delay_ms(5).await;
        // self.i2c
        //     .read(self.address as u8, &mut result_buffer).await
        //     .map_err(Error::I2c)?;


        self.i2c
            .write_read(self.address as u8, &command_buffer, &mut result_buffer).await
            .map_err(Error::I2c)?;
        Ok(Status(result_buffer[0]))

    }


    /// MLX90393 soft reset 
    pub async fn reset_device(&mut self) -> Result<(), Error<E>> {
        debug!("in reset_device()");
        // first send Exit command to exit the current measurement if in progress
        //self.write_command([Exit_mode]).await?;
        let status = self.write_get_status([Exit_mode]).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        debug!("  wrote Exit_mode command");
        self.delayer.delay_ms(2).await;
        //self.write_command([Reset]).await?;
        //self.delayer.delay_ms(20).await;
        //debug!(" sent Reset command, waited 20 msec, getting status byte");
        let status = self.write_get_status([Reset]).await?;
        self.delayer.delay_ms(5).await;

        //let mut status_byte: [u8; 1] = [0; 1];
        //self.read_status_byte(&mut status_byte).await?;
        //let status: Status = Status(status_byte[0]);
        if status.get_error() {
            return Err(Error::CommandError);
        } else {
            return Ok(());   
        }
    }

    /// set t,x,y,z properties for measurements
    pub fn set_txyz(&mut self, t: bool, x: bool, y: bool, z: bool)  {
        self.t = if t { 1} else {0};
        self.x = if x {1} else {0};
        self.y = if y {1} else {0};
        self.z = if z {1} else {0};
        let _ = self.calc_conversion_time();
    } 


    /// initial MLX90393
    pub async fn init_device(&mut self) -> Result<(), Error<E>> {
        debug!("in init_device()");
        self.reset_device().await?;
        debug!(" setting gain to 7 (default)");
        self.set_gain(7).await?;
        let new_gain = self.get_gain().await?;
        debug!("  read back gain = {:#02x}", new_gain);
        self.set_resolution(0, 0, 0).await?;  // ToDo:  should be 0, 0, 0;  testing
        let res = self.get_resolution().await?;
        debug!(" new resolution is : {:#?}", res);
        
        self.set_digital_filter(0).await?;
        debug!("set digital filter to 0");
        let dig_filt = self.get_digital_filter().await?;
        debug!("   read back digital filter = {:#02x}", dig_filt);
        self.set_over_sampling(0).await?;
        let osr = self.get_over_sampling().await?;
        debug!("  read back OSR = {:#02x}", osr);
        self.set_temperature_over_sampling(0).await?;
        let osr2 = self.get_temperature_over_sampling().await?;
        debug!("  read back temperature over sampling = {:#02x}", osr2);
        self.set_temperature_drift_compensation(false).await;
        let tcmp_en = self.get_temperature_drift_compensation().await?;
        debug!("set temperature_drift_compensation to {:#}", tcmp_en);  // note:  resolution must be set to 0 or 1 to enable this
        // self.set_burst_data_rate(10).await?;
        // let rate = self.get_burst_data_rate().await?;
        //debug!("set burst data rate to 10, read back = {:#}", rate);
        self.set_hallconf(0x0c).await?;
        self.measurement_mode = MeasurementMode::Single;  // default on power on

        self.calc_conversion_time().await?;
        match &mut self.drdy_input {      
            None => {
                debug!(" drdy_input not defined, using calculated delay for measurement ready")
            },
            Some(pin) => {
                debug!(" drdy_pin defined, enabling INTterrupt pin");
                self.set_trig_int(true).await?;
            },
        }

        Ok(())
    }

    /// send Exit command
    pub async fn send_exit(&mut self) -> Result<(), Error<E>> {
        let status = self.write_get_status([Exit_mode]).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        debug!("  wrote Exit_mode command");
        self.delayer.delay_ms(2).await;
        Ok(())
    }

    /// set gain
    pub async fn set_gain(&mut self, gain_value: u8) -> Result<(), Error<E>> {
        debug!("in set_gain()");
        let mut current_value = [0u8; 2];
        let status = self.read_register(GAIN_REGISTER, &mut current_value).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        //debug!(" current_value = {:#02x} {:#02x}", current_value[0], current_value[1]);  // high byte = current_value[0]
        let z_series: u8 = current_value[1] & 0b1000_0000;
        let hallconf: u8 = current_value[1] & 0b0000_1111;
        let new_gain: u8 = (gain_value & 0x07) << 0x04;
        let new_value: u8 = z_series | new_gain | hallconf;
        let mut data = [0u8; 2]; //  *************  2026.08.01 was 0u8, 2
        data[1] = new_value;
        data[0] = current_value[0];  // keep high byte as is
        let status = self.write_register(GAIN_REGISTER, &mut data ).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }

        self.hall_conf = hallconf;
        self.gain_sel =  gain_value;
            
        Ok(())
        
    }

    /// get gain
    pub async fn get_gain(&mut self) -> Result<u8, Error<E>> {
        debug!(" in get_gain()");
        let mut value = [0u8; 2];
        let status = self.read_register(GAIN_REGISTER, &mut value).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        value[1] = (value[1] & 0b0111_0000 ) >> 4;
        Ok(value[1])

    }

    /// set resolution of x, y and z axis
    pub async fn set_resolution(&mut self, x_res: u8, y_res: u8, z_res: u8) -> Result<(), Error<E>> {
        debug!("in set_resultion");
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(RES_XYZ_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        //debug!("  read_register(RES_XYZ_REGISTER )ok");
        // let reg_02:u16 = u16::from_be_bytes([read_buffer[0], read_buffer[1]]);  // here is ?
        let reg_02:u16 = u16::from_be_bytes(read_buffer); 
        
        let mut register_02: Register_0x02 = Register_0x02(reg_02);
        register_02.set_x_res(x_res);
        register_02.set_y_res(y_res);
        register_02.set_z_res(z_res);
        //debug!("   writing register_02 (0x02) = {:#?}", register_02);
        let mut write_buffer = register_02.0.to_be_bytes();
        let status = self.write_register(RES_XYZ_REGISTER, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        self.resolution = Resolution{x: x_res, y: y_res, z: z_res};
        Ok(())

    }

    /// get resolution of x, y and z axis
    pub async fn get_resolution(&mut self) -> Result<Resolution, Error<E>> {
        let mut current_res = [0u8; 2];
        let status = self.read_register(RES_XYZ_REGISTER, &mut current_res).await?;
        if (status.get_error()) {
            return Err(Error::CommandError);
        }
        let mut value = u16::from_be_bytes(current_res);
        let register_02 = Register_0x02(value);
        //debug!("  read register_02 = {:#?}", register_02);

        Ok(Resolution { x: register_02.get_x_res(), y: register_02.get_y_res(), z: register_02.get_z_res() })

    }

    /// set digital filter
    pub async fn set_digital_filter(&mut self, new_value: u8) -> Result<(), Error<E>> {
        if (new_value > 0x07) {
            return Err(Error::OutOfRange(new_value));
        }
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let mut register_02: Register_0x02 = Register_0x02(reg_02);
        register_02.set_dig_filt(new_value);
        //debug!("  set_digital_filter() new register 02 = {:#?}", register_02);
        let mut write_buffer = register_02.0.to_be_bytes();
        let status = self.write_register(DIGITAL_FILTER_REGISTER, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        self.calc_conversion_time().await?;
        Ok(())
    }

    /// get digital filter
    pub async fn get_digital_filter(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);   // ????
        let register_02: Register_0x02 = Register_0x02(reg_02);
        //debug!("   register_02 value is now {:#?}", register_02);

        Ok(register_02.get_dig_filt())
    }

    /// set over sampling of ADC
    pub async fn set_over_sampling (&mut self, new_value: u8) -> Result<(), Error<E>> {
        if (new_value > 0x03) {
            return Err(Error::OutOfRange(new_value));
        }
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?; // same reg 0x02
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let mut register_02: Register_0x02 = Register_0x02(reg_02);
        register_02.set_OSR(new_value & 0x03);
        let mut write_buffer = register_02.0.to_be_bytes();
        let status = self.write_register(DIGITAL_FILTER_REGISTER, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        self.calc_conversion_time().await?;
        Ok(())
    }

    /// get over sampling of ADC
    pub async fn get_over_sampling(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let register_02: Register_0x02 = Register_0x02(reg_02);

        Ok(register_02.get_OSR())
    }

    /// set temperature over sampling
    pub async fn set_temperature_over_sampling (&mut self, new_value: u8) -> Result<(), Error<E>> {
        if (new_value > 0x03) {
            return Err(Error::OutOfRange(new_value));
        }
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?; // same reg 0x02
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let mut register_02: Register_0x02 = Register_0x02(reg_02);
        register_02.set_OSR2(new_value & 0x03);
        let mut write_buffer = register_02.0.to_be_bytes();
        let status = self.write_register(DIGITAL_FILTER_REGISTER, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        self.calc_conversion_time().await?;
        Ok(())
    }

    /// get temperature ver sampling of ADC
    pub async fn get_temperature_over_sampling(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let register_02: Register_0x02 = Register_0x02(reg_02);

        Ok(register_02.get_OSR2())
    }

    /// set temperature drift compensation  note: resolution must be set to 0 or 1 to enable this
    pub async fn set_temperature_drift_compensation (&mut self, enable: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?; // same reg 0x02
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01:u16 = u16::from_be_bytes(read_buffer);
        let mut register_0x01: Register_0x01 = Register_0x01(reg_01);
        register_0x01.set_tcmp_en(enable);
        let mut write_buffer = register_0x01.0.to_be_bytes();
        debug!(" set_temperature_drift_compensation reg0x01 = {:#?}", register_0x01);
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        self.tcmp_enabled = enable;
        Ok(())
    }

    /// get temperature drift compensation
    pub async fn get_temperature_drift_compensation(&mut self) -> Result<bool, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01:u16 = u16::from_be_bytes(read_buffer);
        let register_0x01: Register_0x01 = Register_0x01(reg_01);
        debug!(" get_temperature_drift_compensation reg0x01 = {:#?}", register_0x01);
        self.tcmp_enabled = register_0x01.get_tcmp_en();
        Ok(register_0x01.get_tcmp_en())
    }

    /// set burst data rate in 20 msec units, 6 bits size
    /// the datasheet calls this a data rate when in fact it is an interval, oh well.
    pub async fn set_burst_data_rate(&mut self, rate: u8) -> Result<(), Error<E>> {
        if (rate & 0b1100_0000) != 0x00 {
            return Err(Error::OutOfRange(0b0011_1111));
        }
        let mut read_buffer = [0u8, 2];
        let status = self.read_register((REGISTER_01), &mut read_buffer).await?;
             if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01:u16 = u16::from_be_bytes(read_buffer);
        let mut register_0x01: Register_0x01 = Register_0x01(reg_01);
        register_0x01.set_burst_data_rate(rate & 0b0011_1111);
        let mut write_buffer = register_0x01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get burst data rate in 20 msec units
    pub async fn get_burst_data_rate(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register((REGISTER_01), &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01:u16 = u16::from_be_bytes(read_buffer);
        let register_0x01: Register_0x01 = Register_0x01(reg_01);
        Ok(register_0x01.get_burst_data_rate())
    }

    /// set hallconf in regsiter 0x00.  Note that the datasheet only mentions value == 0x0 and 0xc(default)
    pub async fn set_hallconf(&mut self, hallconf: u8) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_00, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_00: u16 = u16::from_be_bytes(read_buffer);
        let mut register_00: Register_0x00 = Register_0x00(reg_00);
        register_00.set_hallconf(hallconf & 0x0f);
        let mut write_buffer = register_00.0.to_be_bytes();
        let status = self.write_register(REGISTER_00, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }


        self.hall_conf = hallconf& 0x0f;

        Ok(())
    }

    /// get hallconf
    pub async fn get_hallconf(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_00, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_00: u16 = u16::from_be_bytes(read_buffer);
        let mut register_00: Register_0x00 = Register_0x00(reg_00);
        self.hall_conf = register_00.get_hallconf();
        Ok(register_00.get_hallconf())

    }

    /// set burst_sel
    pub async fn set_burst_sel(&mut self, burst_sel: u8) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let mut register_01: Register_0x01 = Register_0x01(reg_01);
        register_01.set_burst_sel(burst_sel & 0x03);
        let mut write_buffer = register_01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get burst_sel
    pub async fn get_burst_sel(&mut self) -> Result<u8, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let register_01 = Register_0x01(reg_01);
        Ok(register_01.get_burst_sel())
    }

    /// set z_series
    pub async fn set_z_series(&mut self, set: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_00, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_00: u16 = u16::from_be_bytes(read_buffer);
        let mut register_00: Register_0x00 = Register_0x00(reg_00);
        register_00.set_z_series(set);
        let mut write_buffer = register_00.0.to_be_bytes();
        let status = self.write_register(REGISTER_00, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get z_series
    pub async fn get_z_series(&mut self) -> Result<bool, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_00, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_00: u16 = u16::from_be_bytes(read_buffer);
        let register_00 = Register_0x00(reg_00);
        Ok(register_00.get_z_series())
    }

    /// memory_recall
    pub async fn memory_recall(&mut self) -> Result<(), Error<E>> {
        let status = self.write_get_status([Memory_Recall]).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// memory store:  See MLX90393 datasheet section 16, number of write cycles are limited
    pub async fn memory_store(&mut self) -> Result<(), Error<E>> {
        let status = self.write_get_status([Memory_Store]).await?;
        if status.get_error() {
                return Err(Error::CommandError);
        }
        Ok(())       
    }

    /// start measurement_mode by properties x,y,z, t values
    /// if mode is Burst the set_burst_sel method is called automatically, but you must first call set_burst_data_rate(rate).
    pub async fn start_meaasurement_mode_by_props(&mut self, measurement_mode: MeasurementMode) -> Result<bool, Error<E>> {
        let x_axis: bool = self.x != 0;
        //let x_axis: bool = if (self.x == 1) { true } else {false};
        let y_axis: bool = self.y != 0;
        //let y_axis: bool = if (self.y == 1) { true } else {false};
        let z_axis: bool = self.z != 0;
        // let z_axis: bool = if (self.z == 1) { true } else {false};
        let temp: bool = self.t != 0;
        //let temp: bool = if (self.t == 1) { true } else {false};
        return Ok(self.start_measurement_mode(measurement_mode, x_axis, y_axis, z_axis, temp).await? )
    }

    /// start_measurement_mode :  Single, Burst or WakeOnChange
    pub async fn start_measurement_mode(&mut self, measurement_mode: MeasurementMode, x: bool, y: bool, z: bool, t: bool) -> Result<bool, Error<E>> {
        // ToDo:  may need to send Exit_mode command if x,y,z,t changed but mode did not.
        debug!("in start_measurement_mode:  {:#?}", measurement_mode);
        let x_axis: u8 = if (x) {1} else {0};
        let y_axis: u8 = if (y) {1} else {0};
        let z_axis: u8 = if (z) {1} else {0};
        let temp: u8  =  if (t) {1} else {0};
        let sub_cmd: u8 = z_axis<<3 | y_axis <<2 | x_axis<< 1 | temp;
        if (self.measurement_mode != measurement_mode) { // if new measurement mode must exit current one
            let status = self.write_get_status([Exit_mode]).await?;
            if status.get_error() {
                return Err(Error::CommandError);
            }
            debug!("start_measurement_mode   wrote Exit_mode command");
            self.delayer.delay_ms(5).await;
            self.measurement_mode = measurement_mode;
        }
        if (measurement_mode == MeasurementMode::Burst) {
            self.set_burst_sel(sub_cmd).await?;
            let cmd: u8 = Start_Burst_Mode | sub_cmd;
            let status: Status = self.write_get_status([cmd]).await?;
            // get response status and check if correct mode is set
            
            //let mut status: Status = Status(status_byte[0]);
            if (status.get_burst_mode()) {
                self.measurement_mode = measurement_mode;
                debug!("  start_measurement_mode Burst Ok");
                return Ok(true);  
            } else {
                return Err(Error::CommandError);
            }
        } else if (measurement_mode == MeasurementMode::WakeOnChange) {
            let cmd: u8 = Start_Wake_On_Change | sub_cmd;
            // ??? self.write_command([cmd]).await?;
            // get response status and check if correct mode is set
            let status: Status = self.write_get_status([cmd]).await?;
            if status.get_woc_mode() {
                self.measurement_mode = measurement_mode;
                self.delayer.delay_ms(2).await;
                debug!("  start_measurement_mode WakeOnChange Ok");
                return Ok(true);
            } else {
               return Err(Error::CommandError);
            }

        } else if (measurement_mode == MeasurementMode::Single) {
            let cmd: u8 = Start_Single_Measurement | sub_cmd;
            // ?? self.write_command([cmd]).await?;
            // get response status and check if correct mode is set
            let status: Status = self.write_get_status([cmd]).await?;
            if status.get_single_mode() {
                self.measurement_mode = measurement_mode;
                self.delayer.delay_ms(2).await;
                debug!("  start_measurement_mode Single Ok");
                return Ok(true);
            } else {
                return Err(Error::CommandError);
            }
        } else {
            return Err(Error::CommandError);
        }
    }

    /// start a single measurement, using t,x,y,z property values
    async fn start_single_measurement(&mut self) -> Result<(), Error<E>> {

        //  redundant fn really.  same as start_measurement_by_props(MeasurementMode::Single)
        let status = self.write_get_status([Exit_mode]).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        debug!("  wrote Exit_mode command");

        let sub_cmd: u8 = self.z<<3 | self.y <<2 | self.x<< 1 | self.t;
        let cmd: u8 = Start_Single_Measurement | sub_cmd;
            // ?? self.write_command([cmd]).await?;
            // get response status and check if correct mode is set
        let status: Status = self.write_get_status([cmd]).await?;
        if status.get_single_mode() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// set x, y, z offset
    pub async fn set_xyz_offset(&mut self, xyz_offset: XYZOffset) -> Result<(), Error<E>> {
        let mut write_buffer = xyz_offset.x.to_be_bytes();
        let status = self.write_register(REGISTER_04, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        write_buffer = xyz_offset.y.to_be_bytes();
        let status = self.write_register(REGISTER_05, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        write_buffer = xyz_offset.z.to_be_bytes();
        let status = self.write_register(REGISTER_06, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get x,y,z offset
    pub async fn get_xyz_offset(&mut self) -> Result<XYZOffset, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_04, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let x_offset = u16::from_be_bytes(read_buffer);

        let status = self.read_register(REGISTER_05, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let y_offset =u16::from_be_bytes(read_buffer);

        let status = self.read_register(REGISTER_06, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let z_offset = u16::from_be_bytes(read_buffer);

        let xyz_offset = XYZOffset{x: x_offset , y: y_offset , z: z_offset };
        Ok(xyz_offset)
    }

    /// set WOC XY Threshold, units unknow (probably raw unscaled)
    pub async fn set_woxy_threshold(&mut self, woxy_threshold: u16) -> Result<(), Error<E>> {
        let mut write_buffer = woxy_threshold.to_be_bytes();
        let status = self.write_register(REGISTER_07, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// set WOC Z Threshold, units unknow (probably raw unscaled)
    pub async fn set_woz_threshold(&mut self, woz_threshold: u16) -> Result<(), Error<E>> {
        let mut write_buffer = woz_threshold.to_be_bytes();
        let status = self.write_register(REGISTER_08, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// set WOC T threshold, units unknow (probably raw unscaled)
    pub async fn set_wot_threshold(&mut self, wot_threshold: u16) -> Result<(), Error<E>> {
        let mut write_buffer = wot_threshold.to_be_bytes();
        let status = self.write_register(REGISTER_09, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// set TRIG_INT_SEL (in REGISTER 0x01):  false = TRIG_INT pin is in trigger mode, true = TRIG_INT pin acts as an interrupt pin
    pub async fn set_trig_int_sel(&mut self, trig_int_as_interrupt: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let mut register_01: Register_0x01 = Register_0x01(reg_01);
        register_01.set_trig_int(trig_int_as_interrupt);
        let mut write_buffer = register_01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get TRIG_INT_SEL (in REGISTER 0x01):  false = TRIG_INT pin is in trigger mode, true = TRIG_INT pin acts as an interrupt pin
    pub async fn get_trig_int_sel(&mut self) -> Result<bool, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let register_01: Register_0x01 = Register_0x01(reg_01);
        Ok(register_01.get_trig_int())
    }


    /// set EXT_INT_SEL (in REGISTER 0x01):  enable external trigger input when true, if TRIG_INT_SEL set to false
    pub async fn set_ext_int_sel(&mut self, ext_trig_enable: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let mut register_01: Register_0x01 = Register_0x01(reg_01);
        register_01.set_ext_trig(ext_trig_enable);
        let mut write_buffer = register_01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get EXT_INT_SEL (in REGISTER 0x01):  enable external trigger input when true, if TRIG_INT_SEL set to false
    pub async fn get_ext_int_sel(&mut self) -> Result<bool, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let register_01: Register_0x01 = Register_0x01(reg_01);
        Ok(register_01.get_ext_trg())
    }
    

    /// set trig_int(in REGISTER 0x01):  when false TRIG mode selected, if true then INTerrupt selected
    pub async fn set_trig_int(&mut self, trig_int: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let mut register_01: Register_0x01 = Register_0x01(reg_01);
        register_01.set_trig_int(trig_int);
        let mut write_buffer = register_01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }


    /// get trig_int(in REGISTER 0x01):  when false TRIG mode selected, if true then INTerrupt selected
    pub async fn get_trig_int(&mut self) -> Result<bool, Error<E>> {
        debug!("in get_trig_int()");
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        debug!("  read_register(REGISTER_01 ... ok");
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let register_01: Register_0x01 = Register_0x01(reg_01);
        Ok(register_01.get_trig_int())
    }

    /// set woc_dif in register 0x01:  set true wake-on-change comparison reference is previous measurement.  when false reference is 
    /// first/initial measurement
    pub async fn set_woc_diff(&mut self, enable: bool) -> Result<(), Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let mut register_01: Register_0x01 = Register_0x01(reg_01);
        register_01.set_woc_diff(enable);
        let mut write_buffer = register_01.0.to_be_bytes();
        let status = self.write_register(REGISTER_01, &mut write_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        Ok(())
    }

    /// get woc_diff from register 0x01:  true = WOC_DIFF is enabled, false = disabled 
    pub async fn get_woc_diff(&mut self) -> Result <bool, Error<E>> {
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(REGISTER_01, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_01: u16 = u16::from_be_bytes(read_buffer);
        let register_01: Register_0x01 = Register_0x01(reg_01);
        Ok(register_01.get_woc_diff())
    }


    /// get_measurements
    async fn get_measurements(&mut self, x: bool, y: bool, z: bool, t: bool) -> Result<RawMeasurements, Error<E>> {
        debug!(" in get_measurements");
        let x_axis: u8 = if (x) {1} else {0};
        let y_axis: u8 = if (y) {1} else {0};
        let z_axis: u8 = if (z) {1} else {0};
        let temp: u8 = if (t) {1} else {0};

        let data_length: u8 = ( temp* 2 + x_axis * 2 + y_axis * 2 + z_axis * 2) + 1;
        let mut command_buffer = [0u8; 1];
        // command_buffer[0] = Read_Measurement | (temp << 3) | (x_axis << 2) |
        //                                        (y_axis << 1) | (z_axis); 
        command_buffer[0] = Read_Measurement | (z_axis << 3) | (y_axis << 2) |
                                               (x_axis << 1) | (temp); 
        if data_length == 3 {
            debug!("  reading 3 bytes");
            let mut read_buffer = [0u8; 3];
            self.i2c
                .write_read(self.address as u8, &command_buffer, &mut read_buffer).await
                .map_err(Error::I2c)?;

            let status = Status(read_buffer[0]);
            if status.get_error() {
                return Err(Error::CommandError);
            }
            let measurements = self.unpack_txyz(&mut read_buffer, 3, x_axis, y_axis, z_axis, temp)?;
            return Ok(measurements);

        } else if data_length == 5 {
            debug!("  reading 5 bytes");
            let mut read_buffer = [0u8; 5];
            self.i2c
                .write_read(self.address as u8, &command_buffer, &mut read_buffer).await
                .map_err(Error::I2c)?;

            let status = Status(read_buffer[0]);
            if status.get_error() {
                return Err(Error::CommandError);
            }
            let measurements = self.unpack_txyz(&mut read_buffer, 5, x_axis, y_axis, z_axis, temp)?;
            return Ok(measurements);

        } else if data_length == 7 {
            debug!("  reading 7 bytes");
            let mut read_buffer = [0u8; 7];
            self.i2c
                .write_read(self.address as u8, &command_buffer,&mut read_buffer).await
                .map_err(Error::I2c)?;

            let status = Status(read_buffer[0]);
            if status.get_error() {
                return Err(Error::CommandError);
            }
            let measurements = self.unpack_txyz(&mut read_buffer, 7, x_axis, y_axis, z_axis, temp)?;
            return Ok(measurements);

        } else if data_length == 9 {
            debug!("  reading 9 bytes");
            let mut read_buffer = [0u8; 9];
            self.i2c
                .write_read(self.address as u8, &command_buffer, &mut read_buffer).await
                .map_err(Error::I2c)?;

            let status = Status(read_buffer[0]);
            if status.get_error() {
                return Err(Error::CommandError);
            }
            let measurements = self.unpack_txyz(&mut read_buffer, 9, x_axis, y_axis, z_axis, temp)?;
            return Ok(measurements);

        } else {
            warn!("get_measurements invalid read length, can only happen if all t,x,y,z properties are zero");
            return Err(Error::CommandError);
        }

    }

    // ToDo:  change to use t,x,y,z parameters instead of properties
    fn unpack_txyz(&mut self, read_buffer: &mut [u8], length: u8, x: u8, y: u8, z: u8, t:u8) -> Result<RawMeasurements, Error<E>> {

        let mut temp_data: u16 = 0;
        let mut x_data: u16 = 0;
        let mut y_data: u16 = 0;
        let mut z_data: u16 = 0;
        let data_length: u8 = (t * 2 + x * 2 + y * 2 + z * 2) + 1;

        let mut pos: usize = 1;
        if t == 1 {
            if pos+2 > length as usize {
                return Err(Error::OutOfRange(pos as u8 +2))
            }
            temp_data = u16::from_be_bytes([read_buffer[pos], read_buffer[pos+1]]);
            pos = pos + 2;
        }
        if (x == 1) {
            if (pos+2 > length as usize) {
                return Err(Error::OutOfRange(pos as u8+2))
            }
            x_data = u16::from_be_bytes([read_buffer[pos], read_buffer[pos+1]]);
            pos = pos + 2;
        }
        if (y == 1) {
            if (pos+2 > length as usize) {
                return Err(Error::OutOfRange(pos as u8+2))
            }
            y_data = u16::from_be_bytes([read_buffer[pos], read_buffer[pos+1]]);
            pos = pos + 2;
        }
        if (z == 1) {
            if (pos+2 > length as usize) {
                return Err(Error::OutOfRange(pos as u8+2))
            }
            z_data = u16::from_be_bytes([read_buffer[pos], read_buffer[pos+1]]);
        }
        Ok(RawMeasurements { t: temp_data, x: x_data, y: y_data, z: z_data })

    }

    /// read axis data by specifying txyz parameters
    pub async fn read_data_by_txyz_params(&mut self, t: bool, x: bool, y: bool, z: bool) -> Result<ScaledMeasurements, Error<E>> {
        if (self.measurement_mode== MeasurementMode::Single) {
            self.start_measurement_mode(MeasurementMode::Single, t, x, y, z).await?;
        } else {
            debug!(" read_data_by_txyz_params, not Single mode");
        }    
        match &mut self.drdy_input {      
            None => {
                debug!("  delaying {:#} msec", self.conversion_time);
                self.delayer.delay_ms(self.conversion_time).await;
            },
            Some(pin) => {
                debug!("  drdy input pin set, expecting TRIG_INT pin high when ready");
                // #[cfg(feature = "async")] {
                //     pin.wait_for_any_edge().await.unwrap();
                // // FIX:  this waits forever, which is a fairly long time
                // }

                // #[cfg(not(feature = "async"))] {
                    let mut counter = 0;
                    while ( pin.is_high().unwrap() == false) {
                        self.delayer.delay_ms(2).await;
                        counter = counter + 1;
                        if (self.measurement_mode == MeasurementMode::WakeOnChange) {
                            if (counter > 600000) {  // 10 minutes and let user do a match and if timeout call again
                                return Err(Error::MeasurementTimeout);
                            }
                        } else {
                            if counter > 2000 {  // was 200
                                return Err(Error::MeasurementTimeout);  // should be MeasurementTimeout
                            }
                        }
                    }
                    debug!(" input pin is high, after {counter} msec");
               // }
            }
        }

        let raw_measurements = self.get_measurements(x, y, z, t).await?;
        info!("  got raw_measurements = {:#?}", raw_measurements);
        let scaled_measurements = self.scale_raw_measurements(raw_measurements);
        return Ok(scaled_measurements);
    }
    
    /// read axis data by txyz property values defined in init_device call
    /// note: if mode == MeasurementMode::Single, the start_measurement_mode ...Single command is sent automatically
    /// other, for Burst or WOC mode first start_measure_mode...(Burst or WakeOnChange) once, then call read_data_by...repeatedly 
    pub async fn read_data_by_txyz_props(&mut self, mode: MeasurementMode) -> Result<ScaledMeasurements, Error<E>> {
        debug!("in read_data_by_props");
        if (mode == MeasurementMode::Single) {
            self.start_meaasurement_mode_by_props(MeasurementMode::Single).await?;
        }
        // if a DRDY input pin is set, read it here?  Otherwise delay wait enough time
        match &mut self.drdy_input {      
            None => {
                debug!("  delaying {:#} msec", self.conversion_time);
                self.delayer.delay_ms(self.conversion_time).await
            },
            Some(pin) => {
                // #[cfg(feature = "async")] {
                //     debug!("  waiting on input pin raising edge");
                //     pin.wait_for_rising_edge().await;
                // // FIX:  this waits forever, which is a fairly long time
                // }

             //   #[cfg(not(feature = "async"))] {
                    let mut counter = 0;
                    debug!("  drdy input pin set, expecting TRIG_INT high when ready");
                    while ( pin.is_high().unwrap() == false) {
                        self.delayer.delay_ms(2).await;
                        counter = counter + 1;
                        if counter > 2000 {  // was 200
                            //debug!("  counter = {:#}", counter);
                            return Err(Error::MeasurementTimeout);  // should be MeasurementTimeout
                        }
                    }
              //  }
            }
        }
        // if (self.drdy_input.is_none()) {
        //     self.delayer.delay_ms(self.conversion_time).await;
        // } else { // use drdy input pin == high when ready, do not wait forever
        // }
        let x_axis: bool = if (self.x == 1) {true} else {false};
        let y_axis: bool = if (self.y == 1) {true} else {false};
        let z_axis: bool = if (self.z == 1) {true} else {false};
        let temp: bool = if (self.t == 1) {true} else {false};

        let raw_measurements = self.get_measurements(x_axis, y_axis, z_axis, temp).await?;
        info!("  got raw_measurements = {:#?}", raw_measurements);
        let scaled_measurements = self.scale_raw_measurements(raw_measurements);
        return Ok(scaled_measurements);

    }

    fn scale_raw_measurements(&mut self, raw_measurements: RawMeasurements) -> ScaledMeasurements {
        let mut scaled_measurements: ScaledMeasurements = ScaledMeasurements { t: 0.0, x: 0.0, y: 0.0, z: 0.0 };
        const HALLCONF_0X0: f32 = 98.0/75.0;
        const HALLCONF_0XC: f32 = 1.0;

        let mut xy_scaler: f32 = 0.0;
        let mut z_scaler: f32 = 0.0;

        if self.hall_conf == 0x0 {
            xy_scaler = HALLCONF_0X0;
            z_scaler = HALLCONF_0X0;
        } else if self.hall_conf == 0xc {
            xy_scaler = HALLCONF_0XC;
            z_scaler = HALLCONF_0XC;
        }

        let gain_sel_xy_mult: f32 = SENS_XY[self.gain_sel as usize & 0x07];
        let gain_sel_z_mult : f32 = SENS_Z[self.gain_sel as usize & 0x07];

        // x **************************************
        if self.tcmp_enabled {
            scaled_measurements.x = ((f32::from(raw_measurements.x) ) - 32768.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.x) as f32);
        } else {
            if self.resolution.x == 0x00 || self.resolution.x == 0x01 {
                scaled_measurements.x = (f32::from(raw_measurements.x) ) * xy_scaler * gain_sel_xy_mult * ((1 << self.resolution.x) as f32);
            } else if (self.resolution.x == 0x02) {
                scaled_measurements.x = ((f32::from(raw_measurements.x) ) - 32768.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.x) as f32);
            } else if (self.resolution.x == 0x03) {
                scaled_measurements.x = ((f32::from(raw_measurements.x) ) - 16384.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.x) as f32);
            }
        }

        // y ***************************************
        if self.tcmp_enabled {
            scaled_measurements.y = ((f32::from(raw_measurements.y) ) - 32768.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.y) as f32);
        } else {
            if self.resolution.y == 0x00 || self.resolution.y == 0x01 {
                scaled_measurements.y = (f32::from(raw_measurements.y) ) * xy_scaler * gain_sel_xy_mult * ((1 << self.resolution.y) as f32);
            } else if (self.resolution.y == 0x02) {
                scaled_measurements.y = ((f32::from(raw_measurements.y) ) - 32768.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.y) as f32);
            } else if (self.resolution.y == 0x03) {
                scaled_measurements.y = ((f32::from(raw_measurements.y) ) - 16384.0) as f32  * xy_scaler * gain_sel_xy_mult * 
                                        ((1 << self.resolution.y) as f32);
            }
        } 

        // z *****************************************
        if self.tcmp_enabled {
            scaled_measurements.z = ((f32::from(raw_measurements.z) ) - 32768.0) as f32  * z_scaler * gain_sel_z_mult * 
                                        ((1 << self.resolution.z) as f32);
        } else {
            if self.resolution.z == 0x00 || self.resolution.z == 0x01 {
                scaled_measurements.z = (f32::from(raw_measurements.z) ) * z_scaler * gain_sel_z_mult * ((1 << self.resolution.z) as f32);
            } else if (self.resolution.z == 0x02) {
                scaled_measurements.z = ((f32::from(raw_measurements.z) ) - 32768.0) as f32  * z_scaler * gain_sel_z_mult * 
                                        ((1 << self.resolution.y) as f32);
            } else if (self.resolution.z == 0x03) {
                scaled_measurements.z = ((f32::from(raw_measurements.z) ) - 16384.0) as f32  * z_scaler * gain_sel_z_mult * 
                                        ((1 << self.resolution.z) as f32);
            }
        }

        // t *************************************
        scaled_measurements.t = 25.0 + (f32::from(raw_measurements.t) - 46244.0) / 45.2;   
        
        return scaled_measurements;
    }


    async fn calc_conversion_time(&mut self) -> Result<(), Error<E>> {
        // read OSR, OSR2, DIG_FILT from Register 0x02
        let mut read_buffer = [0u8, 2];
        let status = self.read_register(DIGITAL_FILTER_REGISTER, &mut read_buffer).await?;
        if status.get_error() {
            return Err(Error::CommandError);
        }
        let reg_02:u16 = u16::from_be_bytes(read_buffer);
        let register_02: Register_0x02 = Register_0x02(reg_02);
        let osr = register_02.get_OSR();
        let osr2 = register_02.get_OSR2();
        let dig_filt = register_02.get_dig_filt();

        let conversion_time = (3.0 * (2.0 + (1 << dig_filt) as f32) * ((1 << osr) as f32) * 0.064f32 +
                                ((1 << osr2) as f32) * 0.192f32 ) * 1.3f32;
        if conversion_time < 1.0f32 {
            self.conversion_time = 1;
        } else {
            self.conversion_time = roundf(conversion_time) as u32;
        }
        debug!("  conversion time = {:#}", self.conversion_time); 

        Ok(())

    }

}