mkmidilibrary 0.2.0

Music scoring and MIDI library for Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
//! MIDI message types
//!
//! This module defines all MIDI message types including channel messages,
//! system messages, and meta events.

use std::fmt;

/// MIDI channel voice message
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum MidiMessage {
    /// Note Off event (key released)
    NoteOff {
        channel: u8,
        key: u8,
        velocity: u8,
    },
    /// Note On event (key pressed)
    NoteOn {
        channel: u8,
        key: u8,
        velocity: u8,
    },
    /// Polyphonic key pressure (aftertouch per note)
    PolyPressure {
        channel: u8,
        key: u8,
        pressure: u8,
    },
    /// Control change
    ControlChange {
        channel: u8,
        controller: u8,
        value: u8,
    },
    /// Program change (instrument selection)
    ProgramChange {
        channel: u8,
        program: u8,
    },
    /// Channel pressure (aftertouch for whole channel)
    ChannelPressure {
        channel: u8,
        pressure: u8,
    },
    /// Pitch bend
    PitchBend {
        channel: u8,
        /// 14-bit value: 0x2000 = center, range 0x0000-0x3FFF
        value: u16,
    },
    /// System exclusive message
    SysEx(Vec<u8>),
    /// Meta event (in MIDI files only)
    Meta(MetaEvent),
    /// MIDI Time Code Quarter Frame
    MtcQuarterFrame(u8),
    /// Song Position Pointer
    SongPosition(u16),
    /// Song Select
    SongSelect(u8),
    /// Tune Request
    TuneRequest,
    /// Timing Clock
    TimingClock,
    /// Start
    Start,
    /// Continue
    Continue,
    /// Stop
    Stop,
    /// Active Sensing
    ActiveSensing,
    /// System Reset
    SystemReset,
}

impl MidiMessage {
    /// Create a Note On message
    pub fn note_on(channel: u8, key: u8, velocity: u8) -> Self {
        MidiMessage::NoteOn {
            channel: channel & 0x0F,
            key: key & 0x7F,
            velocity: velocity & 0x7F,
        }
    }

    /// Create a Note Off message
    pub fn note_off(channel: u8, key: u8, velocity: u8) -> Self {
        MidiMessage::NoteOff {
            channel: channel & 0x0F,
            key: key & 0x7F,
            velocity: velocity & 0x7F,
        }
    }

    /// Create a Control Change message
    pub fn control_change(channel: u8, controller: u8, value: u8) -> Self {
        MidiMessage::ControlChange {
            channel: channel & 0x0F,
            controller: controller & 0x7F,
            value: value & 0x7F,
        }
    }

    /// Create a Program Change message
    pub fn program_change(channel: u8, program: u8) -> Self {
        MidiMessage::ProgramChange {
            channel: channel & 0x0F,
            program: program & 0x7F,
        }
    }

    /// Create a Pitch Bend message
    pub fn pitch_bend(channel: u8, value: u16) -> Self {
        MidiMessage::PitchBend {
            channel: channel & 0x0F,
            value: value & 0x3FFF,
        }
    }

    /// Create a Pitch Bend message from signed value (-8192 to 8191)
    pub fn pitch_bend_signed(channel: u8, value: i16) -> Self {
        let unsigned = (value as i32 + 0x2000).clamp(0, 0x3FFF) as u16;
        Self::pitch_bend(channel, unsigned)
    }

    /// Create a sustain pedal (CC 64) message with an explicit value
    pub fn make_sustain(channel: u8, value: u8) -> Self {
        Self::control_change(channel, 64, value)
    }

    /// Create a sustain pedal on message (CC 64, value 127)
    pub fn make_sustain_on(channel: u8) -> Self {
        Self::make_sustain(channel, 127)
    }

    /// Create a sustain pedal off message (CC 64, value 0)
    pub fn make_sustain_off(channel: u8) -> Self {
        Self::make_sustain(channel, 0)
    }

    /// Create a soft pedal (CC 67) message with an explicit value
    pub fn make_soft(channel: u8, value: u8) -> Self {
        Self::control_change(channel, 67, value)
    }

    /// Create a soft pedal on message (CC 67, value 127)
    pub fn make_soft_on(channel: u8) -> Self {
        Self::make_soft(channel, 127)
    }

    /// Create a soft pedal off message (CC 67, value 0)
    pub fn make_soft_off(channel: u8) -> Self {
        Self::make_soft(channel, 0)
    }

    /// Create a patch (program) change message. Alias of `program_change`.
    pub fn make_patch_change(channel: u8, program: u8) -> Self {
        Self::program_change(channel, program)
    }

    /// Create a timbre change message. Alias of `program_change`.
    pub fn make_timbre(channel: u8, program: u8) -> Self {
        Self::program_change(channel, program)
    }

    /// Get the channel for channel messages
    pub fn channel(&self) -> Option<u8> {
        match self {
            MidiMessage::NoteOff { channel, .. }
            | MidiMessage::NoteOn { channel, .. }
            | MidiMessage::PolyPressure { channel, .. }
            | MidiMessage::ControlChange { channel, .. }
            | MidiMessage::ProgramChange { channel, .. }
            | MidiMessage::ChannelPressure { channel, .. }
            | MidiMessage::PitchBend { channel, .. } => Some(*channel),
            _ => None,
        }
    }

    /// Check if this is a Note On message
    pub fn is_note_on(&self) -> bool {
        matches!(self, MidiMessage::NoteOn { velocity, .. } if *velocity > 0)
    }

    /// Check if this is a Note Off message (including Note On with velocity 0)
    pub fn is_note_off(&self) -> bool {
        matches!(
            self,
            MidiMessage::NoteOff { .. } | MidiMessage::NoteOn { velocity: 0, .. }
        )
    }

    /// Check if this is a channel message
    pub fn is_channel_message(&self) -> bool {
        self.channel().is_some()
    }

    /// Check if this is a system message
    pub fn is_system_message(&self) -> bool {
        matches!(
            self,
            MidiMessage::SysEx(_)
                | MidiMessage::MtcQuarterFrame(_)
                | MidiMessage::SongPosition(_)
                | MidiMessage::SongSelect(_)
                | MidiMessage::TuneRequest
                | MidiMessage::TimingClock
                | MidiMessage::Start
                | MidiMessage::Continue
                | MidiMessage::Stop
                | MidiMessage::ActiveSensing
                | MidiMessage::SystemReset
        )
    }

    /// Check if this is a meta event
    pub fn is_meta(&self) -> bool {
        matches!(self, MidiMessage::Meta(_))
    }

    /// Check if this is a note on or note off message (velocity-0 note-on
    /// counts as a note off, per `is_note_off`).
    pub fn is_note(&self) -> bool {
        matches!(self, MidiMessage::NoteOn { .. } | MidiMessage::NoteOff { .. })
    }

    /// Check if this is a control change message
    pub fn is_controller(&self) -> bool {
        matches!(self, MidiMessage::ControlChange { .. })
    }

    /// Get the controller number for a control change message
    pub fn get_controller_number(&self) -> Option<u8> {
        match self {
            MidiMessage::ControlChange { controller, .. } => Some(*controller),
            _ => None,
        }
    }

    /// Get the controller value for a control change message
    pub fn get_controller_value(&self) -> Option<u8> {
        match self {
            MidiMessage::ControlChange { value, .. } => Some(*value),
            _ => None,
        }
    }

    /// Check if this is a sustain pedal (CC 64) message
    pub fn is_sustain(&self) -> bool {
        self.get_controller_number() == Some(64)
    }

    /// Check if this is a sustain-on message (CC 64, value >= 64)
    pub fn is_sustain_on(&self) -> bool {
        self.is_sustain() && self.get_controller_value().unwrap_or(0) >= 64
    }

    /// Check if this is a sustain-off message (CC 64, value < 64)
    pub fn is_sustain_off(&self) -> bool {
        self.is_sustain() && self.get_controller_value().unwrap_or(0) < 64
    }

    /// Check if this is a soft pedal (CC 67) message
    pub fn is_soft(&self) -> bool {
        self.get_controller_number() == Some(67)
    }

    /// Check if this is a soft-pedal-on message (CC 67, value >= 64)
    pub fn is_soft_on(&self) -> bool {
        self.is_soft() && self.get_controller_value().unwrap_or(0) >= 64
    }

    /// Check if this is a soft-pedal-off message (CC 67, value < 64)
    pub fn is_soft_off(&self) -> bool {
        self.is_soft() && self.get_controller_value().unwrap_or(0) < 64
    }

    /// Check if this is a program change (patch change) message
    pub fn is_patch_change(&self) -> bool {
        matches!(self, MidiMessage::ProgramChange { .. })
    }

    /// Check if this is a program change message. Alias of `is_patch_change`.
    pub fn is_timbre(&self) -> bool {
        self.is_patch_change()
    }

    /// Check if this is a note or channel pressure (aftertouch) message
    pub fn is_pressure(&self) -> bool {
        matches!(
            self,
            MidiMessage::PolyPressure { .. } | MidiMessage::ChannelPressure { .. }
        )
    }

    /// Check if this is a pressure (aftertouch) message. Alias of `is_pressure`.
    pub fn is_aftertouch(&self) -> bool {
        self.is_pressure()
    }

    /// Check if this is a pitch bend message
    pub fn is_pitchbend(&self) -> bool {
        matches!(self, MidiMessage::PitchBend { .. })
    }

    /// Get the status byte for this message
    pub fn status_byte(&self) -> Option<u8> {
        match self {
            MidiMessage::NoteOff { channel, .. } => Some(0x80 | channel),
            MidiMessage::NoteOn { channel, .. } => Some(0x90 | channel),
            MidiMessage::PolyPressure { channel, .. } => Some(0xA0 | channel),
            MidiMessage::ControlChange { channel, .. } => Some(0xB0 | channel),
            MidiMessage::ProgramChange { channel, .. } => Some(0xC0 | channel),
            MidiMessage::ChannelPressure { channel, .. } => Some(0xD0 | channel),
            MidiMessage::PitchBend { channel, .. } => Some(0xE0 | channel),
            MidiMessage::SysEx(_) => Some(0xF0),
            MidiMessage::MtcQuarterFrame(_) => Some(0xF1),
            MidiMessage::SongPosition(_) => Some(0xF2),
            MidiMessage::SongSelect(_) => Some(0xF3),
            MidiMessage::TuneRequest => Some(0xF6),
            MidiMessage::TimingClock => Some(0xF8),
            MidiMessage::Start => Some(0xFA),
            MidiMessage::Continue => Some(0xFB),
            MidiMessage::Stop => Some(0xFC),
            MidiMessage::ActiveSensing => Some(0xFE),
            MidiMessage::SystemReset => Some(0xFF),
            MidiMessage::Meta(_) => Some(0xFF), // Meta events use 0xFF prefix
        }
    }

    /// Convert to bytes for transmission
    pub fn to_bytes(&self) -> Vec<u8> {
        match self {
            MidiMessage::NoteOff {
                channel,
                key,
                velocity,
            } => vec![0x80 | channel, *key, *velocity],
            MidiMessage::NoteOn {
                channel,
                key,
                velocity,
            } => vec![0x90 | channel, *key, *velocity],
            MidiMessage::PolyPressure {
                channel,
                key,
                pressure,
            } => vec![0xA0 | channel, *key, *pressure],
            MidiMessage::ControlChange {
                channel,
                controller,
                value,
            } => vec![0xB0 | channel, *controller, *value],
            MidiMessage::ProgramChange { channel, program } => vec![0xC0 | channel, *program],
            MidiMessage::ChannelPressure { channel, pressure } => vec![0xD0 | channel, *pressure],
            MidiMessage::PitchBend { channel, value } => {
                vec![0xE0 | channel, (*value & 0x7F) as u8, (*value >> 7) as u8]
            }
            MidiMessage::SysEx(data) => {
                let mut bytes = vec![0xF0];
                bytes.extend(data);
                bytes.push(0xF7);
                bytes
            }
            MidiMessage::MtcQuarterFrame(data) => vec![0xF1, *data],
            MidiMessage::SongPosition(pos) => {
                vec![0xF2, (*pos & 0x7F) as u8, (*pos >> 7) as u8]
            }
            MidiMessage::SongSelect(song) => vec![0xF3, *song],
            MidiMessage::TuneRequest => vec![0xF6],
            MidiMessage::TimingClock => vec![0xF8],
            MidiMessage::Start => vec![0xFA],
            MidiMessage::Continue => vec![0xFB],
            MidiMessage::Stop => vec![0xFC],
            MidiMessage::ActiveSensing => vec![0xFE],
            MidiMessage::SystemReset => vec![0xFF],
            MidiMessage::Meta(meta) => meta.to_bytes(),
        }
    }

    /// Parse from bytes
    pub fn from_bytes(data: &[u8]) -> Option<(MidiMessage, usize)> {
        if data.is_empty() {
            return None;
        }

        let status = data[0];
        let channel = status & 0x0F;

        match status & 0xF0 {
            0x80 if data.len() >= 3 => Some((
                MidiMessage::NoteOff {
                    channel,
                    key: data[1],
                    velocity: data[2],
                },
                3,
            )),
            0x90 if data.len() >= 3 => Some((
                MidiMessage::NoteOn {
                    channel,
                    key: data[1],
                    velocity: data[2],
                },
                3,
            )),
            0xA0 if data.len() >= 3 => Some((
                MidiMessage::PolyPressure {
                    channel,
                    key: data[1],
                    pressure: data[2],
                },
                3,
            )),
            0xB0 if data.len() >= 3 => Some((
                MidiMessage::ControlChange {
                    channel,
                    controller: data[1],
                    value: data[2],
                },
                3,
            )),
            0xC0 if data.len() >= 2 => Some((
                MidiMessage::ProgramChange {
                    channel,
                    program: data[1],
                },
                2,
            )),
            0xD0 if data.len() >= 2 => Some((
                MidiMessage::ChannelPressure {
                    channel,
                    pressure: data[1],
                },
                2,
            )),
            0xE0 if data.len() >= 3 => Some((
                MidiMessage::PitchBend {
                    channel,
                    value: (data[1] as u16) | ((data[2] as u16) << 7),
                },
                3,
            )),
            0xF0 => match status {
                0xF0 => {
                    // SysEx - find end marker
                    if let Some(end) = data.iter().position(|&b| b == 0xF7) {
                        Some((MidiMessage::SysEx(data[1..end].to_vec()), end + 1))
                    } else {
                        None
                    }
                }
                0xF1 if data.len() >= 2 => Some((MidiMessage::MtcQuarterFrame(data[1]), 2)),
                0xF2 if data.len() >= 3 => Some((
                    MidiMessage::SongPosition((data[1] as u16) | ((data[2] as u16) << 7)),
                    3,
                )),
                0xF3 if data.len() >= 2 => Some((MidiMessage::SongSelect(data[1]), 2)),
                0xF6 => Some((MidiMessage::TuneRequest, 1)),
                0xF8 => Some((MidiMessage::TimingClock, 1)),
                0xFA => Some((MidiMessage::Start, 1)),
                0xFB => Some((MidiMessage::Continue, 1)),
                0xFC => Some((MidiMessage::Stop, 1)),
                0xFE => Some((MidiMessage::ActiveSensing, 1)),
                0xFF => {
                    // Could be system reset or meta event
                    if data.len() >= 2 && data[1] < 0x80 {
                        // Meta event
                        MetaEvent::from_bytes(&data[1..]).map(|(meta, len)| {
                            (MidiMessage::Meta(meta), len + 1)
                        })
                    } else {
                        Some((MidiMessage::SystemReset, 1))
                    }
                }
                _ => None,
            },
            _ => None,
        }
    }
}

/// Convert a frequency in Hz to a MIDI-style semitone number (A4 = 440Hz = 69.0).
/// Fractional results represent microtonal offsets from the nearest semitone.
pub fn frequency_to_semitones(frequency_hz: f64) -> f64 {
    69.0 + 12.0 * (frequency_hz / 440.0).log2()
}

impl fmt::Display for MidiMessage {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            MidiMessage::NoteOff {
                channel,
                key,
                velocity,
            } => {
                write!(f, "NoteOff(ch={}, key={}, vel={})", channel, key, velocity)
            }
            MidiMessage::NoteOn {
                channel,
                key,
                velocity,
            } => {
                write!(f, "NoteOn(ch={}, key={}, vel={})", channel, key, velocity)
            }
            MidiMessage::ControlChange {
                channel,
                controller,
                value,
            } => write!(f, "CC(ch={}, cc={}, val={})", channel, controller, value),
            MidiMessage::ProgramChange { channel, program } => {
                write!(f, "PC(ch={}, prog={})", channel, program)
            }
            MidiMessage::PitchBend { channel, value } => {
                write!(f, "PitchBend(ch={}, val={})", channel, value)
            }
            MidiMessage::Meta(meta) => write!(f, "{}", meta),
            _ => write!(f, "{:?}", self),
        }
    }
}

/// MIDI Meta Event (used in Standard MIDI Files)
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum MetaEvent {
    /// Sequence number
    SequenceNumber(u16),
    /// Text event
    Text(String),
    /// Copyright notice
    Copyright(String),
    /// Track/sequence name
    TrackName(String),
    /// Instrument name
    InstrumentName(String),
    /// Lyric
    Lyric(String),
    /// Marker
    Marker(String),
    /// Cue point
    CuePoint(String),
    /// Program name
    ProgramName(String),
    /// Device name
    DeviceName(String),
    /// MIDI channel prefix
    ChannelPrefix(u8),
    /// MIDI port
    MidiPort(u8),
    /// End of track
    EndOfTrack,
    /// Tempo in microseconds per quarter note
    Tempo(u32),
    /// SMPTE offset
    SmpteOffset {
        hours: u8,
        minutes: u8,
        seconds: u8,
        frames: u8,
        subframes: u8,
    },
    /// Time signature
    TimeSignature {
        numerator: u8,
        denominator_power: u8, // actual denominator = 2^denominator_power
        clocks_per_click: u8,
        notated_32nd_per_quarter: u8,
    },
    /// Key signature
    KeySignature {
        /// Negative = flats, positive = sharps
        sharps_flats: i8,
        /// 0 = major, 1 = minor
        minor: bool,
    },
    /// Sequencer-specific meta event
    SequencerSpecific(Vec<u8>),
    /// Unknown meta event
    Unknown { type_: u8, data: Vec<u8> },
}

impl MetaEvent {
    /// Create a tempo meta event from BPM
    pub fn tempo_from_bpm(bpm: f64) -> Self {
        let microseconds = (60_000_000.0 / bpm).round() as u32;
        MetaEvent::Tempo(microseconds)
    }

    /// Get BPM from tempo meta event
    pub fn tempo_to_bpm(&self) -> Option<f64> {
        if let MetaEvent::Tempo(us) = self {
            Some(60_000_000.0 / *us as f64)
        } else {
            None
        }
    }

    /// Get the raw microseconds-per-quarter-note value from a tempo meta event
    pub fn tempo_microseconds(&self) -> Option<u32> {
        match self {
            MetaEvent::Tempo(us) => Some(*us),
            _ => None,
        }
    }

    /// Get the duration of one quarter note, in seconds, from a tempo meta event
    pub fn tempo_seconds(&self) -> Option<f64> {
        self.tempo_microseconds().map(|us| us as f64 / 1_000_000.0)
    }

    /// Get ticks-per-second implied by this tempo, given a file's ticks-per-quarter
    pub fn tempo_ticks_per_second(&self, ticks_per_quarter: u16) -> Option<f64> {
        self.tempo_seconds()
            .map(|spq| ticks_per_quarter as f64 / spq)
    }

    /// Get seconds-per-tick implied by this tempo, given a file's ticks-per-quarter
    pub fn tempo_seconds_per_tick(&self, ticks_per_quarter: u16) -> Option<f64> {
        self.tempo_seconds()
            .map(|spq| spq / ticks_per_quarter as f64)
    }

    /// Create a time signature meta event
    pub fn time_signature(numerator: u8, denominator: u8) -> Self {
        // Convert denominator to power of 2
        let denominator_power = (denominator as f64).log2() as u8;
        MetaEvent::TimeSignature {
            numerator,
            denominator_power,
            clocks_per_click: 24,
            notated_32nd_per_quarter: 8,
        }
    }

    /// Create a time signature meta event for compound meters (e.g. 6/8),
    /// using a default of 36 MIDI clocks per metronome click (vs. 24 for
    /// `time_signature`), matching upstream midifile's `addCompoundTimeSignature`.
    pub fn compound_time_signature(numerator: u8, denominator: u8) -> Self {
        let denominator_power = (denominator as f64).log2() as u8;
        MetaEvent::TimeSignature {
            numerator,
            denominator_power,
            clocks_per_click: 36,
            notated_32nd_per_quarter: 8,
        }
    }

    /// Get the actual denominator from time signature
    pub fn time_signature_denominator(&self) -> Option<u8> {
        if let MetaEvent::TimeSignature {
            denominator_power, ..
        } = self
        {
            Some(1 << denominator_power)
        } else {
            None
        }
    }

    /// Create a key signature meta event
    pub fn key_signature(sharps: i8, minor: bool) -> Self {
        MetaEvent::KeySignature {
            sharps_flats: sharps,
            minor,
        }
    }

    /// Get the meta event type byte
    pub fn type_byte(&self) -> u8 {
        match self {
            MetaEvent::SequenceNumber(_) => 0x00,
            MetaEvent::Text(_) => 0x01,
            MetaEvent::Copyright(_) => 0x02,
            MetaEvent::TrackName(_) => 0x03,
            MetaEvent::InstrumentName(_) => 0x04,
            MetaEvent::Lyric(_) => 0x05,
            MetaEvent::Marker(_) => 0x06,
            MetaEvent::CuePoint(_) => 0x07,
            MetaEvent::ProgramName(_) => 0x08,
            MetaEvent::DeviceName(_) => 0x09,
            MetaEvent::ChannelPrefix(_) => 0x20,
            MetaEvent::MidiPort(_) => 0x21,
            MetaEvent::EndOfTrack => 0x2F,
            MetaEvent::Tempo(_) => 0x51,
            MetaEvent::SmpteOffset { .. } => 0x54,
            MetaEvent::TimeSignature { .. } => 0x58,
            MetaEvent::KeySignature { .. } => 0x59,
            MetaEvent::SequencerSpecific(_) => 0x7F,
            MetaEvent::Unknown { type_, .. } => *type_,
        }
    }

    /// Convert to bytes
    pub fn to_bytes(&self) -> Vec<u8> {
        let mut bytes = vec![0xFF, self.type_byte()];

        let data: Vec<u8> = match self {
            MetaEvent::SequenceNumber(n) => vec![(*n >> 8) as u8, *n as u8],
            MetaEvent::Text(s)
            | MetaEvent::Copyright(s)
            | MetaEvent::TrackName(s)
            | MetaEvent::InstrumentName(s)
            | MetaEvent::Lyric(s)
            | MetaEvent::Marker(s)
            | MetaEvent::CuePoint(s)
            | MetaEvent::ProgramName(s)
            | MetaEvent::DeviceName(s) => s.as_bytes().to_vec(),
            MetaEvent::ChannelPrefix(ch) => vec![*ch],
            MetaEvent::MidiPort(port) => vec![*port],
            MetaEvent::EndOfTrack => vec![],
            MetaEvent::Tempo(us) => vec![(*us >> 16) as u8, (*us >> 8) as u8, *us as u8],
            MetaEvent::SmpteOffset {
                hours,
                minutes,
                seconds,
                frames,
                subframes,
            } => vec![*hours, *minutes, *seconds, *frames, *subframes],
            MetaEvent::TimeSignature {
                numerator,
                denominator_power,
                clocks_per_click,
                notated_32nd_per_quarter,
            } => vec![
                *numerator,
                *denominator_power,
                *clocks_per_click,
                *notated_32nd_per_quarter,
            ],
            MetaEvent::KeySignature {
                sharps_flats,
                minor,
            } => vec![*sharps_flats as u8, if *minor { 1 } else { 0 }],
            MetaEvent::SequencerSpecific(data) | MetaEvent::Unknown { data, .. } => data.clone(),
        };

        // Write variable-length quantity for data length
        bytes.extend(Self::encode_varlen(data.len() as u32));
        bytes.extend(data);
        bytes
    }

    /// Parse from bytes (starting after 0xFF prefix)
    pub fn from_bytes(data: &[u8]) -> Option<(MetaEvent, usize)> {
        if data.is_empty() {
            return None;
        }

        let type_byte = data[0];
        let (length, varlen_size) = Self::decode_varlen(&data[1..])?;
        let data_start = 1 + varlen_size;
        let data_end = data_start + length as usize;

        if data.len() < data_end {
            return None;
        }

        let event_data = &data[data_start..data_end];

        let event = match type_byte {
            0x00 if event_data.len() >= 2 => {
                MetaEvent::SequenceNumber(((event_data[0] as u16) << 8) | event_data[1] as u16)
            }
            0x01 => MetaEvent::Text(String::from_utf8_lossy(event_data).to_string()),
            0x02 => MetaEvent::Copyright(String::from_utf8_lossy(event_data).to_string()),
            0x03 => MetaEvent::TrackName(String::from_utf8_lossy(event_data).to_string()),
            0x04 => MetaEvent::InstrumentName(String::from_utf8_lossy(event_data).to_string()),
            0x05 => MetaEvent::Lyric(String::from_utf8_lossy(event_data).to_string()),
            0x06 => MetaEvent::Marker(String::from_utf8_lossy(event_data).to_string()),
            0x07 => MetaEvent::CuePoint(String::from_utf8_lossy(event_data).to_string()),
            0x08 => MetaEvent::ProgramName(String::from_utf8_lossy(event_data).to_string()),
            0x09 => MetaEvent::DeviceName(String::from_utf8_lossy(event_data).to_string()),
            0x20 if !event_data.is_empty() => MetaEvent::ChannelPrefix(event_data[0]),
            0x21 if !event_data.is_empty() => MetaEvent::MidiPort(event_data[0]),
            0x2F => MetaEvent::EndOfTrack,
            0x51 if event_data.len() >= 3 => MetaEvent::Tempo(
                ((event_data[0] as u32) << 16)
                    | ((event_data[1] as u32) << 8)
                    | event_data[2] as u32,
            ),
            0x54 if event_data.len() >= 5 => MetaEvent::SmpteOffset {
                hours: event_data[0],
                minutes: event_data[1],
                seconds: event_data[2],
                frames: event_data[3],
                subframes: event_data[4],
            },
            0x58 if event_data.len() >= 4 => MetaEvent::TimeSignature {
                numerator: event_data[0],
                denominator_power: event_data[1],
                clocks_per_click: event_data[2],
                notated_32nd_per_quarter: event_data[3],
            },
            0x59 if event_data.len() >= 2 => MetaEvent::KeySignature {
                sharps_flats: event_data[0] as i8,
                minor: event_data[1] != 0,
            },
            0x7F => MetaEvent::SequencerSpecific(event_data.to_vec()),
            _ => MetaEvent::Unknown {
                type_: type_byte,
                data: event_data.to_vec(),
            },
        };

        Some((event, data_end))
    }

    /// Encode a variable-length quantity
    fn encode_varlen(mut value: u32) -> Vec<u8> {
        let mut bytes = Vec::new();
        bytes.push((value & 0x7F) as u8);
        value >>= 7;

        while value > 0 {
            bytes.push(((value & 0x7F) | 0x80) as u8);
            value >>= 7;
        }

        bytes.reverse();
        bytes
    }

    /// Decode a variable-length quantity
    fn decode_varlen(data: &[u8]) -> Option<(u32, usize)> {
        let mut value: u32 = 0;
        let mut bytes_read = 0;

        for &byte in data.iter().take(4) {
            bytes_read += 1;
            value = (value << 7) | (byte & 0x7F) as u32;

            if byte & 0x80 == 0 {
                return Some((value, bytes_read));
            }
        }

        None
    }
}

impl fmt::Display for MetaEvent {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            MetaEvent::Tempo(us) => {
                let bpm = 60_000_000.0 / *us as f64;
                write!(f, "Tempo({:.2} BPM)", bpm)
            }
            MetaEvent::TimeSignature {
                numerator,
                denominator_power,
                ..
            } => {
                let denom = 1 << denominator_power;
                write!(f, "TimeSignature({}/{})", numerator, denom)
            }
            MetaEvent::KeySignature {
                sharps_flats,
                minor,
            } => {
                let mode = if *minor { "minor" } else { "major" };
                write!(f, "KeySignature({} {})", sharps_flats, mode)
            }
            MetaEvent::TrackName(name) => write!(f, "TrackName({})", name),
            MetaEvent::EndOfTrack => write!(f, "EndOfTrack"),
            _ => write!(f, "{:?}", self),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_note_on_off() {
        let on = MidiMessage::note_on(0, 60, 100);
        assert!(on.is_note_on());
        assert!(!on.is_note_off());
        assert_eq!(on.channel(), Some(0));

        let off = MidiMessage::note_off(0, 60, 0);
        assert!(off.is_note_off());
        assert!(!off.is_note_on());
    }

    #[test]
    fn test_message_to_bytes() {
        let on = MidiMessage::note_on(0, 60, 100);
        let bytes = on.to_bytes();
        assert_eq!(bytes, vec![0x90, 60, 100]);

        let (parsed, _) = MidiMessage::from_bytes(&bytes).unwrap();
        assert_eq!(parsed, on);
    }

    #[test]
    fn test_pitch_bend() {
        let center = MidiMessage::pitch_bend(0, 0x2000);
        assert_eq!(center.channel(), Some(0));

        if let MidiMessage::PitchBend { value, .. } = center {
            assert_eq!(value, 0x2000);
        }

        let signed = MidiMessage::pitch_bend_signed(0, 0);
        if let MidiMessage::PitchBend { value, .. } = signed {
            assert_eq!(value, 0x2000);
        }
    }

    #[test]
    fn test_tempo_meta() {
        let tempo = MetaEvent::tempo_from_bpm(120.0);
        if let MetaEvent::Tempo(us) = tempo {
            assert_eq!(us, 500_000);
        }

        assert!((tempo.tempo_to_bpm().unwrap() - 120.0).abs() < 0.01);
    }

    #[test]
    fn test_time_signature_meta() {
        let ts = MetaEvent::time_signature(4, 4);
        assert_eq!(ts.time_signature_denominator(), Some(4));

        let ts = MetaEvent::time_signature(6, 8);
        assert_eq!(ts.time_signature_denominator(), Some(8));
    }

    #[test]
    fn test_controller_classification_and_constructors() {
        let sustain_on = MidiMessage::make_sustain_on(0);
        assert!(sustain_on.is_controller());
        assert!(sustain_on.is_sustain());
        assert!(sustain_on.is_sustain_on());
        assert!(!sustain_on.is_sustain_off());
        assert_eq!(sustain_on.get_controller_number(), Some(64));

        let sustain_off = MidiMessage::make_sustain_off(0);
        assert!(sustain_off.is_sustain_off());
        assert!(!sustain_off.is_sustain_on());

        let soft_on = MidiMessage::make_soft_on(1);
        assert!(soft_on.is_soft());
        assert!(soft_on.is_soft_on());

        let patch = MidiMessage::make_patch_change(0, 40);
        assert!(patch.is_patch_change());
        assert!(patch.is_timbre());

        assert!(MidiMessage::note_on(0, 60, 100).is_note());
        assert!(MidiMessage::note_off(0, 60, 0).is_note());
        assert!(MidiMessage::pitch_bend(0, 0x2000).is_pitchbend());
    }

    #[test]
    fn test_tempo_primitives() {
        let tempo = MetaEvent::tempo_from_bpm(120.0);
        assert_eq!(tempo.tempo_microseconds(), Some(500_000));
        assert!((tempo.tempo_seconds().unwrap() - 0.5).abs() < 1e-9);
        // At 480 ticks/quarter and 120bpm, 1 quarter (0.5s) = 480 ticks.
        assert!((tempo.tempo_ticks_per_second(480).unwrap() - 960.0).abs() < 1e-6);
        assert!((tempo.tempo_seconds_per_tick(480).unwrap() - 0.5 / 480.0).abs() < 1e-9);
    }

    #[test]
    fn test_frequency_to_semitones() {
        assert!((frequency_to_semitones(440.0) - 69.0).abs() < 1e-9);
        // One octave up from A4 is A5 (81 semitones from C-1... i.e. +12).
        assert!((frequency_to_semitones(880.0) - 81.0).abs() < 1e-9);
    }

    #[test]
    fn test_meta_event_roundtrip() {
        let events = vec![
            MetaEvent::TrackName("Test Track".to_string()),
            MetaEvent::Tempo(500_000),
            MetaEvent::time_signature(4, 4),
            MetaEvent::key_signature(0, false),
            MetaEvent::EndOfTrack,
        ];

        for event in events {
            let bytes = event.to_bytes();
            let (parsed, _) = MetaEvent::from_bytes(&bytes[1..]).unwrap();
            assert_eq!(parsed, event);
        }
    }
}