mkit-core 0.5.0

Content-addressed VCS primitives for mkit: BLAKE3 hashing, canonical objects, refs, packs, and transport traits
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
//! Windowed, resumable, sans-IO pack decoding (SPEC-PACKFILE ยง11).
//!
//! Entries are provisional until [`Step::Done`]. On any error the caller must
//! discard everything staged by this run, including entries from earlier slices.
//! This reader does not validate objects, resolve deltas, or write to a store.
//!
//! Wrong feed ranges, invalid window geometry, bad cursors, and checksum or
//! pack-id mismatches use [`PackError::PackfileCorrupted`]. Budget or allocation
//! failures use [`PackError::PackfileTooLarge`]. Framing and trailing-data errors
//! match [`super::PackEntries`]; zstd uses `ZstdEntryTruncated`,
//! `DecompressedSizeOverCap`, `DecompressedSizeMismatch`, and `ZstdDecompress`.
//! The decoded budget includes owned entry buffers, including carried wire bytes
//! plus decoded output when both are live. Decoder-internal memory is additional
//! (in particular the ruzstd ring buffer; see the parent module).
//!
//! A resumed run re-fetches its current window and checks the checkpoint's
//! prefix commitment before yielding entries. Completed windows are not re-read.
//! Without a requested pack id, the initial run first fetches the trailer
//! window(s), retaining that anchor in its cursor to bind even an unseen suffix.

use super::{
    DecodeLimits, MAGIC, MAX_ENTRIES, MAX_TOTAL_PAYLOAD, PackEntry, PackError, decode_payload,
    zstd_claim,
};
use crate::hash::Hash;
use std::borrow::Cow;
mod cursor;
mod tree;
pub use cursor::WindowCursor;
use tree::Tree;

/// A range which must be supplied in full to [`WindowReader::feed`].
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[non_exhaustive]
pub struct WindowRequest {
    pub offset: u64,
    pub len: u64,
}

/// Where the entry a reader last yielded sat in the pack: its complete
/// frame, type and length prefix included, exactly as `DecodedEntry` reports
/// it for the buffered decoder.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[non_exhaustive]
pub struct FrameInfo {
    /// Offset of the complete frame in the pack.
    pub offset: u64,
    /// Length of the complete frame, including its five header bytes.
    pub length: u64,
    /// Encoded frame type (`0x00`, `0x02`, `0x03` or `0x04`).
    pub wire_type: u8,
}

/// The next action for a window-reader driver.
#[derive(Debug)]
#[non_exhaustive]
pub enum Step {
    /// Fetch exactly this range, then call `feed`.
    NeedWindow(WindowRequest),
    /// An owned entry, provisional until `Done`.
    Entry(PackEntry<'static>),
    /// Framing, trailer, and optional requested pack id are verified.
    Done(WindowSummary),
}

/// Verified pack metadata; raw-only means every wire type was `0x00`.
#[derive(Debug, Clone, PartialEq, Eq)]
#[non_exhaustive]
pub struct WindowSummary {
    pub version: u32,
    pub entry_count: u32,
    pub raw_only: bool,
    pub first_non_raw: Option<u32>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum Phase {
    Anchor,
    Header,
    Boundary,
    Frame,
    Payload,
    Finish,
    Done,
    Failed,
}

/// An I/O-free decoder retaining only the current window and current entry.
///
/// **Binding.** `Done` means every entry yielded across the whole run chain (the original run and every resume
/// through its cursors) is an entry, in order, of the one pack whose bytes hash to the verified pack id: the trailer,
/// and `expected_pack_id` when set. A cursor from pack A used on a source that yields different bytes for any
/// not-yet-verified range fails with `PackfileCorrupted`, never `Done`. The reader does not re-read ranges it has
/// already verified. **Keeping the source immutable across resumes is the caller's job** (informative: WP-4.8 binds
/// R2 range reads to the object's etag). A source whose already-verified prefix changed after verification can still
/// reach `Done`, but only with entries of the verified pack.
#[derive(Debug)]
pub struct WindowReader {
    state: WindowCursor,
    limits: DecodeLimits,
    phase: Phase,
    window: Vec<u8>,
    start: u64,
    end: u64,
    before: (Tree, Tree),
    boundary: Option<WindowCursor>,
    request: Option<WindowRequest>,
    header: [u8; 5],
    header_used: usize,
    kind: u8,
    payload_len: u64,
    carry: Vec<u8>,
    trailer: [u8; 32],
    resume_prefix: Option<Hash>,
    last_frame: Option<FrameInfo>,
    #[cfg(test)]
    peak: usize,
}

fn us(n: u64) -> Result<usize, PackError> {
    usize::try_from(n).map_err(|_| PackError::PackfileTooLarge)
}
fn geometry(pack_len: u64, window: u64) -> Result<(), PackError> {
    if pack_len < 44 {
        return Err(PackError::PackfileTooShort);
    }
    if !(64 << 10..=64 << 20).contains(&window) || !window.is_power_of_two() {
        return Err(PackError::PackfileCorrupted);
    }
    if pack_len > MAX_TOTAL_PAYLOAD + u64::from(MAX_ENTRIES) * 5 + 44 {
        return Err(PackError::PackfileTooLarge);
    }
    Ok(())
}
fn copy_bytes(bytes: &[u8]) -> Result<Vec<u8>, PackError> {
    let mut out = Vec::new();
    out.try_reserve_exact(bytes.len())
        .map_err(|_| PackError::PackfileTooLarge)?;
    out.extend_from_slice(bytes);
    Ok(out)
}

impl WindowReader {
    /// Start a pack with power-of-two windows between 64 KiB and 64 MiB.
    ///
    /// # Errors
    /// Short pack lengths give `PackfileTooShort`; invalid geometry gives
    /// `PackfileCorrupted`.
    pub fn new(
        pack_len: u64,
        window_size: u64,
        limits: DecodeLimits,
        expected_pack_id: Option<Hash>,
    ) -> Result<Self, PackError> {
        geometry(pack_len, window_size)?;
        Ok(Self::from_state(
            WindowCursor::initial(pack_len, window_size, expected_pack_id),
            limits,
            if expected_pack_id.is_some() {
                Phase::Header
            } else {
                Phase::Anchor
            },
        ))
    }

    /// Restore an entry boundary. The first request contains the next entry.
    ///
    /// # Errors
    /// Inconsistent cursors give `PackfileCorrupted`.
    pub fn resume(cursor: &WindowCursor, limits: DecodeLimits) -> Result<Self, PackError> {
        cursor.validate()?;
        let mut reader = Self::from_state(cursor.clone(), limits, Phase::Boundary);
        reader.boundary = Some(cursor.clone());
        reader.resume_prefix = cursor.window_prefix;
        Ok(reader)
    }

    fn from_state(state: WindowCursor, limits: DecodeLimits, phase: Phase) -> Self {
        let start = state.completed * state.window_size; // validated cursor geometry
        let before = (state.trailer_tree.clone(), state.id_tree.clone());
        Self {
            state,
            limits,
            phase,
            window: Vec::new(),
            start,
            end: start,
            before,
            boundary: None,
            request: None,
            header: [0; 5],
            header_used: 0,
            kind: 0,
            payload_len: 0,
            carry: Vec::new(),
            trailer: [0; 32],
            resume_prefix: None,
            last_frame: None,
            #[cfg(test)]
            peak: 0,
        }
    }

    fn need(&mut self, offset: u64) -> Result<Step, PackError> {
        let len = self
            .state
            .pack_len
            .checked_sub(offset)
            .ok_or(PackError::PackfileCorrupted)?
            .min(self.state.window_size);
        if len == 0 {
            return Err(PackError::UnexpectedEof);
        }
        self.window = Vec::new();
        let request = WindowRequest { offset, len };
        self.request = Some(request);
        Ok(Step::NeedWindow(request))
    }

    /// Advance to a request, an entry, or verified completion.
    ///
    /// # Errors
    /// Malformed packs, resource limits, and failed integrity checks use the
    /// errors documented at module level. A parsing error makes the reader inert.
    pub fn step(&mut self) -> Result<Step, PackError> {
        if let Some(request) = self.request {
            return Ok(Step::NeedWindow(request));
        }
        let result = self.advance();
        if result.is_err() {
            self.phase = Phase::Failed;
        }
        result
    }

    fn advance(&mut self) -> Result<Step, PackError> {
        loop {
            match self.phase {
                Phase::Failed => return Err(PackError::PackfileCorrupted),
                Phase::Done => return Ok(Step::Done(self.summary())),
                Phase::Anchor => {
                    if self.end == self.state.pack_len {
                        self.state.anchor = Some(self.trailer);
                        self.trailer = [0; 32];
                        self.start = 0;
                        self.end = 0;
                        self.phase = Phase::Header;
                    } else {
                        let offset = if self.end == 0 {
                            (self.state.split() / self.state.window_size) * self.state.window_size
                        } else {
                            self.end
                        };
                        return self.need(offset);
                    }
                }
                Phase::Header => {
                    if let Some(step) = self.advance_header()? {
                        return Ok(step);
                    }
                }
                Phase::Boundary => {
                    // Resume must fetch the containing window, even at EOF.
                    if self.window.is_empty() {
                        return self.need(self.start);
                    }
                    if self.state.index == self.state.count {
                        self.phase = Phase::Finish;
                        continue;
                    }
                    self.header_used = 0;
                    self.phase = Phase::Frame;
                }
                Phase::Frame => {
                    if let Some(step) = self.advance_frame()? {
                        return Ok(step);
                    }
                }
                Phase::Payload => {
                    if let Some(step) = self.advance_payload()? {
                        return Ok(step);
                    }
                }
                Phase::Finish => {
                    if self.state.pos != self.state.split() {
                        return Err(PackError::TrailingData);
                    }
                    if self.end < self.state.pack_len {
                        return self.need(self.end);
                    }
                    if self
                        .state
                        .anchor
                        .is_some_and(|anchor| anchor != self.trailer)
                        || self.state.trailer_tree.root != Some(self.trailer)
                        || self
                            .state
                            .expected
                            .is_some_and(|id| self.state.id_tree.root != Some(id))
                    {
                        return Err(PackError::PackfileCorrupted);
                    }
                    self.phase = Phase::Done;
                }
            }
        }
    }

    fn advance_header(&mut self) -> Result<Option<Step>, PackError> {
        if self.window.is_empty() {
            return self.need(0).map(Some);
        }
        if &self.window[..4] != MAGIC {
            return Err(PackError::InvalidMagic);
        }
        self.state.version = u32::from_le_bytes(
            self.window[4..8]
                .try_into()
                .map_err(|_| PackError::UnexpectedEof)?,
        );
        if !matches!(self.state.version, 1 | 2) {
            return Err(PackError::UnsupportedVersion(self.state.version));
        }
        self.state.count = u32::from_le_bytes(
            self.window[8..12]
                .try_into()
                .map_err(|_| PackError::UnexpectedEof)?,
        );
        if self.state.count > MAX_ENTRIES {
            return Err(PackError::TooManyObjects(self.state.count));
        }
        self.phase = Phase::Boundary;
        self.boundary = Some(self.boundary_state());
        Ok(None)
    }

    fn advance_frame(&mut self) -> Result<Option<Step>, PackError> {
        if self
            .state
            .pos
            .checked_add(
                u64::try_from(5 - self.header_used).map_err(|_| PackError::PackfileTooLarge)?,
            )
            .is_none_or(|end| end > self.state.split())
        {
            return Err(PackError::UnexpectedEof);
        }
        if self.state.pos == self.end {
            return self.need(self.end).map(Some);
        }
        let begin = us(self
            .state
            .pos
            .checked_sub(self.start)
            .ok_or(PackError::PackfileCorrupted)?)?;
        let n = (5 - self.header_used).min(self.window.len() - begin);
        self.header[self.header_used..self.header_used + n]
            .copy_from_slice(&self.window[begin..begin + n]);
        self.header_used += n;
        self.state.pos = self
            .state
            .pos
            .checked_add(u64::try_from(n).map_err(|_| PackError::PackfileTooLarge)?)
            .ok_or(PackError::PackfileTooLarge)?;
        if self.header_used != 5 {
            return Ok(None);
        }
        self.kind = self.header[0];
        self.payload_len = u64::from(u32::from_le_bytes(
            self.header[1..]
                .try_into()
                .map_err(|_| PackError::UnexpectedEof)?,
        ));
        self.state.payload_sum = self
            .state
            .payload_sum
            .checked_add(self.payload_len)
            .ok_or(PackError::PackfileTooLarge)?;
        if self
            .limits
            .entry_geometry
            .is_some_and(|(frame, _)| self.payload_len > frame)
            || self.state.payload_sum > MAX_TOTAL_PAYLOAD
        {
            return Err(PackError::PackfileTooLarge);
        }
        if self.payload_len
            > self
                .state
                .split()
                .checked_sub(self.state.pos)
                .ok_or(PackError::UnexpectedEof)?
        {
            return Err(PackError::UnexpectedEof);
        }
        match self.kind {
            0 => {}
            2 | 4 if self.kind == 2 || self.state.version == 2 => {
                if self.payload_len < 32 {
                    return Err(PackError::DeltaEntryTruncated);
                }
            }
            3 if self.state.version == 2 => {}
            other => return Err(PackError::InvalidEntryType(other)),
        }
        if self.kind != 0 && self.state.first_non_raw.is_none() {
            self.state.first_non_raw = Some(self.state.index);
        }
        self.phase = Phase::Payload;
        Ok(None)
    }

    fn advance_payload(&mut self) -> Result<Option<Step>, PackError> {
        let carried = u64::try_from(self.carry.len()).map_err(|_| PackError::PackfileTooLarge)?;
        let remaining = self
            .payload_len
            .checked_sub(carried)
            .ok_or(PackError::PackfileCorrupted)?;
        if self.state.pos == self.end && remaining != 0 {
            return self.need(self.end).map(Some);
        }
        let begin = us(self
            .state
            .pos
            .checked_sub(self.start)
            .ok_or(PackError::PackfileCorrupted)?)?;
        let available =
            u64::try_from(self.window.len() - begin).map_err(|_| PackError::PackfileTooLarge)?;
        if self.carry.is_empty() && remaining <= available {
            let end = begin
                .checked_add(us(remaining)?)
                .ok_or(PackError::PackfileTooLarge)?;
            let payload = &self.window[begin..end];
            self.check_budget(payload, 0)?;
            let entry = own_entry(decode_payload(self.kind, self.state.version, payload)?)?;
            self.record_peak(entry_len(&entry));
            self.state.pos = self
                .state
                .pos
                .checked_add(remaining)
                .ok_or(PackError::PackfileTooLarge)?;
            self.entry_finished()?;
            return Ok(Some(Step::Entry(entry)));
        }
        if self.carry.is_empty() {
            if self.payload_len
                > self
                    .limits
                    .entry_geometry
                    .map_or(self.limits.max_decoded_bytes, |(frame, _)| frame)
            {
                return Err(PackError::PackfileTooLarge);
            }
            self.carry
                .try_reserve_exact(us(self.payload_len)?)
                .map_err(|_| PackError::PackfileTooLarge)?;
        }
        let n = remaining.min(available);
        let end = begin
            .checked_add(us(n)?)
            .ok_or(PackError::PackfileTooLarge)?;
        self.carry.extend_from_slice(&self.window[begin..end]);
        self.state.pos = self
            .state
            .pos
            .checked_add(n)
            .ok_or(PackError::PackfileTooLarge)?;
        self.record_peak(0);
        // Check a zstd claim as soon as its prefix has arrived.
        let prefix = if self.kind == 4 { 36 } else { 4 };
        if matches!(self.kind, 3 | 4) && self.carry.len() >= prefix {
            self.check_budget(&self.carry, self.payload_len)?;
        }
        if u64::try_from(self.carry.len()).map_err(|_| PackError::PackfileTooLarge)?
            == self.payload_len
        {
            self.check_budget(&self.carry, self.payload_len)?;
            let released = self.release_carried_window()?;
            let entry = if matches!(self.kind, 0 | 2) {
                let mut bytes = std::mem::take(&mut self.carry);
                if self.kind == 0 {
                    PackEntry::Raw {
                        bytes: Cow::Owned(bytes),
                    }
                } else {
                    let base = bytes[..32]
                        .try_into()
                        .map_err(|_| PackError::DeltaEntryTruncated)?;
                    bytes.drain(..32);
                    PackEntry::Delta {
                        base,
                        stream: Cow::Owned(bytes),
                    }
                }
            } else {
                let entry = own_entry(decode_payload(self.kind, self.state.version, &self.carry)?)?;
                self.record_peak(entry_len(&entry));
                self.carry = Vec::new();
                entry
            };
            if let Some(cursor) = released {
                let frame = self.last_frame;
                *self = Self::resume(&cursor, self.limits)?;
                self.last_frame = frame;
            } else {
                self.entry_finished()?;
            }
            return Ok(Some(Step::Entry(entry)));
        }
        Ok(None)
    }

    // Authenticate the post-entry prefix before releasing the carried frame's window.
    fn release_carried_window(&mut self) -> Result<Option<WindowCursor>, PackError> {
        if self.limits.entry_geometry.is_none() || !matches!(self.kind, 3 | 4) {
            return Ok(None);
        }
        self.entry_finished()?;
        let cursor = self.checkpoint().ok_or(PackError::PackfileCorrupted)?;
        self.window = Vec::new();
        Ok(Some(cursor))
    }

    fn check_budget(&self, payload: &[u8], carried: u64) -> Result<(), PackError> {
        if let Some((frame, stream)) = self.limits.entry_geometry {
            let claim = match self.kind {
                3 => zstd_claim(payload)?.0 as u64,
                4 => zstd_claim(payload.get(32..).ok_or(PackError::DeltaEntryTruncated)?)?.0 as u64,
                _ => self.payload_len,
            };
            let cap = match self.kind {
                2 => stream.saturating_add(32),
                4 => stream,
                _ => self.limits.max_decoded_bytes,
            };
            return if self.payload_len <= frame && claim <= cap {
                Ok(())
            } else {
                Err(PackError::PackfileTooLarge)
            };
        }
        let charge = if matches!(self.kind, 3 | 4) {
            let prefix = if self.kind == 4 { 32 } else { 0 };
            let (claim, _) = zstd_claim(
                payload
                    .get(prefix..)
                    .ok_or(PackError::DeltaEntryTruncated)?,
            )?;
            carried
                .checked_add(u64::try_from(claim).map_err(|_| PackError::PackfileTooLarge)?)
                .ok_or(PackError::PackfileTooLarge)?
        } else {
            self.payload_len
        };
        if charge > self.limits.max_decoded_bytes {
            Err(PackError::PackfileTooLarge)
        } else {
            Ok(())
        }
    }

    fn entry_finished(&mut self) -> Result<(), PackError> {
        let length = self
            .payload_len
            .checked_add(5)
            .ok_or(PackError::PackfileTooLarge)?;
        self.last_frame = Some(FrameInfo {
            offset: self
                .state
                .pos
                .checked_sub(length)
                .ok_or(PackError::PackfileCorrupted)?,
            length,
            wire_type: self.kind,
        });
        self.state.index = self
            .state
            .index
            .checked_add(1)
            .ok_or(PackError::PackfileTooLarge)?;
        self.phase = Phase::Boundary;
        self.boundary = Some(self.boundary_state());
        Ok(())
    }

    /// Supply exactly the outstanding range. Wrong ranges leave it pending.
    ///
    /// # Errors
    /// Wrong ranges give `PackfileCorrupted`; failed allocations give
    /// `PackfileTooLarge`.
    pub fn feed(&mut self, offset: u64, bytes: &[u8]) -> Result<(), PackError> {
        self.validate_feed(offset, bytes)?;
        let retain = self.retains_window();
        let buffer = if retain {
            copy_bytes(bytes)?
        } else {
            Vec::new()
        };
        self.feed_data(offset, bytes)?;
        if retain {
            self.window = buffer;
            self.record_peak(0);
        }
        Ok(())
    }

    /// Supply a range by transferring its buffer, avoiding two full-window copies.
    ///
    /// # Errors
    /// Wrong ranges give `PackfileCorrupted`; allocation failure gives `PackfileTooLarge`.
    pub fn feed_owned(&mut self, offset: u64, bytes: Vec<u8>) -> Result<(), PackError> {
        self.validate_feed(offset, &bytes)?;
        let retain = self.retains_window();
        let bytes = if retain && bytes.capacity() > us(self.state.window_size)? {
            copy_bytes(&bytes)?
        } else {
            bytes
        };
        self.feed_data(offset, &bytes)?;
        if retain {
            self.window = bytes;
            self.record_peak(0);
        }
        Ok(())
    }

    fn retains_window(&self) -> bool {
        !(self.phase == Phase::Anchor && self.state.pack_len > self.state.window_size)
    }

    fn validate_feed(&self, offset: u64, bytes: &[u8]) -> Result<WindowRequest, PackError> {
        let request = self.request.ok_or(PackError::PackfileCorrupted)?;
        if request.offset != offset
            || u64::try_from(bytes.len()).map_err(|_| PackError::PackfileTooLarge)? != request.len
        {
            return Err(PackError::PackfileCorrupted);
        }
        Ok(request)
    }

    fn feed_data(&mut self, offset: u64, bytes: &[u8]) -> Result<(), PackError> {
        let request = self.validate_feed(offset, bytes)?;
        if let Some(expected) = self.resume_prefix {
            let prefix_len = self
                .state
                .pos
                .checked_sub(offset)
                .ok_or(PackError::PackfileCorrupted)?;
            let prefix = bytes
                .get(..us(prefix_len)?)
                .ok_or(PackError::PackfileCorrupted)?;
            if crate::hash::hash(prefix) != expected {
                return Err(PackError::PackfileCorrupted);
            }
            self.resume_prefix = None;
        }
        if self.phase == Phase::Anchor && self.state.pack_len > self.state.window_size {
            self.end = offset
                .checked_add(request.len)
                .ok_or(PackError::PackfileCorrupted)?;
            self.collect_trailer(offset, bytes)?;
        } else {
            self.before = (self.state.trailer_tree.clone(), self.state.id_tree.clone());
            self.state.trailer_tree.absorb(
                offset,
                bytes,
                self.state.split(),
                self.state.window_size,
            )?;
            if self.state.expected.is_some() {
                self.state.id_tree.absorb(
                    offset,
                    bytes,
                    self.state.pack_len,
                    self.state.window_size,
                )?;
            }
            self.start = offset;
            self.end = offset
                .checked_add(request.len)
                .ok_or(PackError::PackfileCorrupted)?;
            self.collect_trailer(offset, bytes)?;
            if self.phase == Phase::Anchor {
                // A single-window pack already supplies the trailer and all
                // stream bytes. Reuse its buffer and hashes for header parsing.
                self.state.anchor = Some(self.trailer);
                self.phase = Phase::Header;
            }
        }
        self.request = None;
        Ok(())
    }

    fn collect_trailer(&mut self, offset: u64, bytes: &[u8]) -> Result<(), PackError> {
        let from = self.state.split().max(offset);
        if from < self.end {
            let src = us(from
                .checked_sub(offset)
                .ok_or(PackError::PackfileCorrupted)?)?;
            let dst = us(from
                .checked_sub(self.state.split())
                .ok_or(PackError::PackfileCorrupted)?)?;
            let n = us(self
                .end
                .checked_sub(from)
                .ok_or(PackError::PackfileCorrupted)?)?;
            self.trailer[dst..dst + n].copy_from_slice(&bytes[src..src + n]);
        }
        Ok(())
    }

    /// The frame of the entry the latest [`Step::Entry`] returned, or `None`
    /// before the first one. A resumed reader starts with `None`.
    #[must_use]
    pub fn last_frame(&self) -> Option<FrameInfo> {
        self.last_frame
    }

    /// A compact checkpoint only at an entry boundary, never within an entry.
    ///
    /// Hashes the current window prefix lazily on this call. Returns `None` if
    /// the reader has released the bytes needed for that prefix, including while
    /// fetching a split trailer or awaiting a resumed window. Keep the previous
    /// cursor in that case. No bytes are needed when the boundary is exactly at
    /// a window start. Mid-entry states, including carried straddling entries,
    /// never produce a checkpoint.
    #[must_use]
    pub fn checkpoint(&self) -> Option<WindowCursor> {
        if !matches!(self.phase, Phase::Boundary | Phase::Finish | Phase::Done) {
            return None;
        }
        let mut cursor = self.boundary.clone()?;
        if self.window.is_empty()
            && self.limits.entry_geometry.is_some()
            && self.resume_prefix.is_some()
        {
            return Some(cursor);
        }
        let start = cursor.completed.checked_mul(cursor.window_size)?;
        let prefix_len = cursor.pos.checked_sub(start)?;
        cursor.window_prefix = if prefix_len == 0 {
            None
        } else {
            if self.start != start {
                return None;
            }
            let end = usize::try_from(prefix_len).ok()?;
            Some(crate::hash::hash(self.window.get(..end)?))
        };
        Some(cursor)
    }

    fn boundary_state(&self) -> WindowCursor {
        let mut state = self.state.clone();
        state.completed = state.pos / state.window_size;
        if state.completed == self.start / state.window_size {
            state.trailer_tree = self.before.0.clone();
            state.id_tree = self.before.1.clone();
        }
        state
    }

    fn summary(&self) -> WindowSummary {
        WindowSummary {
            version: self.state.version,
            entry_count: self.state.count,
            raw_only: self.state.first_non_raw.is_none(),
            first_non_raw: self.state.first_non_raw,
        }
    }

    #[cfg_attr(not(test), allow(clippy::unused_self))] // counter exists only in tests
    fn record_peak(&mut self, extra: usize) {
        #[cfg(test)]
        {
            self.peak = self
                .peak
                .max(self.window.capacity() + self.carry.capacity() + extra);
        }
        #[cfg(not(test))]
        let _ = extra;
    }
}

fn own_entry(entry: PackEntry<'_>) -> Result<PackEntry<'static>, PackError> {
    fn own(bytes: Cow<'_, [u8]>) -> Result<Cow<'static, [u8]>, PackError> {
        Ok(Cow::Owned(match bytes {
            Cow::Owned(bytes) => bytes,
            Cow::Borrowed(bytes) => copy_bytes(bytes)?,
        }))
    }
    Ok(match entry {
        PackEntry::Raw { bytes } => PackEntry::Raw { bytes: own(bytes)? },
        PackEntry::Delta { base, stream } => PackEntry::Delta {
            base,
            stream: own(stream)?,
        },
    })
}
fn entry_len(entry: &PackEntry<'_>) -> usize {
    let bytes = match entry {
        PackEntry::Raw { bytes } => bytes,
        PackEntry::Delta { stream, .. } => stream,
    };
    match bytes {
        Cow::Borrowed(bytes) => bytes.len(),
        Cow::Owned(bytes) => bytes.capacity(),
    }
}

/// A synchronous source serving exact ranges, without retaining earlier windows.
pub trait WindowSource {
    /// Read exactly `len` bytes beginning at `offset`.
    ///
    /// # Errors
    /// Return a pack error for a short read or source failure.
    fn read_window(&mut self, offset: u64, len: u64) -> Result<Vec<u8>, PackError>;
}
impl WindowSource for &[u8] {
    fn read_window(&mut self, offset: u64, len: u64) -> Result<Vec<u8>, PackError> {
        let end = offset.checked_add(len).ok_or(PackError::UnexpectedEof)?;
        copy_bytes(
            self.get(us(offset)?..us(end)?)
                .ok_or(PackError::UnexpectedEof)?,
        )
    }
}

/// Drive a reader synchronously, dropping each window after feeding it.
///
/// # Errors
/// Propagates reader, source, or sink errors. All previously delivered entries
/// must be discarded on error, including a final integrity failure.
pub fn read_all<S: WindowSource>(
    source: &mut S,
    pack_len: u64,
    window_size: u64,
    limits: DecodeLimits,
    expected_pack_id: Option<Hash>,
    mut sink: impl FnMut(PackEntry<'static>) -> Result<(), PackError>,
) -> Result<WindowSummary, PackError> {
    let mut reader = WindowReader::new(pack_len, window_size, limits, expected_pack_id)?;
    loop {
        match reader.step()? {
            Step::NeedWindow(request) => {
                let bytes = source.read_window(request.offset, request.len)?;
                reader.feed_owned(request.offset, bytes)?;
            }
            Step::Entry(entry) => sink(entry)?,
            Step::Done(summary) => return Ok(summary),
        }
    }
}

#[cfg(test)]
mod tests;