mk-rs-core 0.1.1

mk-rust core: lexer, parser, DAG builder, scheduler
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
//! Recipe execution glue: elision, printing, shell dispatch.
//!
//! Takes a parsed Recipe and executes it through the Shell trait,
//! respecting attributes and CLI flags (-n, -e, -t, -s).

use std::collections::HashMap;
use std::path::{Path, PathBuf};

use crate::attr::Attributes;
use crate::error::{RecipeError, ShellError};
use crate::shell::{Shell, ShellResult};

// ── Recipe ─────────────────────────────────────────────────────────────────

/// A recipe ready to execute.
#[derive(Debug, Clone)]
pub struct Recipe {
    /// Target being built.
    pub target: String,
    /// All prerequisites.
    pub prereqs: Vec<String>,
    /// The recipe script text (raw, before first-char elision).
    pub script: String,
    /// Working directory.
    pub working_dir: PathBuf,
    /// Environment variables to pass to the shell.
    pub env: HashMap<String, String>,
    /// Rule attributes (affect execution behavior).
    pub attributes: Attributes,
    /// Stem from metarule match (None for concrete rules).
    pub stem: Option<String>,
    /// All targets of the rule (for $alltarget variable).
    pub all_targets: Vec<String>,
}

// ── Options ────────────────────────────────────────────────────────────────

/// Options controlling recipe execution behavior.
///
/// These correspond to CLI flags: -n (no-exec), -e (explain),
/// -t (touch), -q (quiet).
#[derive(Debug, Clone, Default)]
pub struct RecipeOptions {
    /// -n flag: print recipes but don't execute.
    pub no_exec: bool,
    /// -e flag: explain why recipe runs.
    pub explain: bool,
    /// -t flag: touch targets instead of running recipes.
    pub touch: bool,
    /// -q flag: quiet — don't print recipes (like Q attribute).
    pub silent: bool,
    /// Whether to use ANSI color in recipe output.
    pub color: bool,
}

// ── Public API ─────────────────────────────────────────────────────────────

/// Apply first-char elision to each line of a recipe.
///
/// In mk, the first character of every recipe line is stripped —
/// it's the indent marker (tab or space) that mkfile syntax requires
/// to distinguish recipe lines from rule headers.
///
/// Blank lines are preserved as-is.
///
/// # Examples
///
/// ```
/// let elided = mk_rs_core::recipe::elide_first_char("\techo hello\n\techo world");
/// assert_eq!(elided, "echo hello\necho world");
/// ```
pub fn elide_first_char(recipe: &str) -> String {
    let mut out = String::with_capacity(recipe.len());
    let mut first = true;
    for line in recipe.split('\n') {
        if first {
            first = false;
        } else {
            out.push('\n');
        }
        if line.is_empty() {
            continue;
        }
        // Strip exactly one character (the indent marker).
        let mut chars = line.chars();
        chars.next(); // skip first char
        out.push_str(chars.as_str());
    }
    out
}

/// Execute a single recipe through the configured shell.
///
/// # Algorithm (Phase 1a — serial, first-char elision, Q attribute)
///
/// 1. Apply first-char elision to the recipe script.
/// 2. If not quiet (not -s and not Q attribute), print the recipe.
/// 3. If `-n` (no-exec): print recipe and return fake success.
/// 4. If `-e` (explain): print staleness reason, then continue.
/// 5. If `-t` (touch): touch the target file, return fake success.
/// 6. Execute the elided recipe through the shell.
/// 7. If exit code ≠ 0, check D attribute (delete target on error).
///
/// Returns the shell result on success, or a `RecipeError` on failure.
pub fn run(
    recipe: &Recipe,
    shell: &dyn Shell,
    opts: &RecipeOptions,
) -> Result<ShellResult, RecipeError> {
    // Parser already strips indent — recipe text is already elided.
    let script = recipe.script.clone();

    // ── Quiet check ────────────────────────────────────────────────────
    let quiet = opts.silent || recipe.attributes.is_quiet();

    if !quiet {
        if opts.color {
            // ANSI: bold target, dim recipe lines
            eprintln!("\x1b[1m{}:\x1b[0m", recipe.target);
            for line in script.lines() {
                eprintln!("\x1b[2m\t{line}\x1b[0m");
            }
        } else {
            eprintln!("{}:", recipe.target);
            for line in script.lines() {
                eprintln!("\t{line}");
            }
        }
    }

    // ── -n: no-exec ────────────────────────────────────────────────────
    if opts.no_exec {
        return Ok(ShellResult {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
        });
    }

    // ── -e: explain ────────────────────────────────────────────────────
    if opts.explain {
        eprintln!(
            "  target '{}' is out of date because: prerequisites are newer",
            recipe.target
        );
    }

    // ── -t: touch ──────────────────────────────────────────────────────
    if opts.touch {
        touch_target(&recipe.target)?;
        return Ok(ShellResult {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
        });
    }

    // ── Execute ────────────────────────────────────────────────────────
    // Inject recipe-time variables into the environment.
    let mut env = recipe.env.clone();
    env.insert("target".to_string(), recipe.target.clone());
    env.insert("prereq".to_string(), recipe.prereqs.join(" "));
    env.insert("newprereq".to_string(), recipe.prereqs.join(" "));
    env.insert("pid".to_string(), std::process::id().to_string());
    env.insert("alltarget".to_string(), recipe.all_targets.join(" "));
    // $newmember: extract member names from archive prereqs like lib.a(foo.o) → foo.o
    env.insert("newmember".to_string(), extract_members(&recipe.prereqs));
    if let Some(ref stem) = recipe.stem {
        env.insert("stem".to_string(), stem.clone());
    }

    let result = shell
        .execute(&script, &env, &recipe.working_dir)
        .map_err(|e| match e {
            ShellError::CommandFailed { code, stderr } => RecipeError::CommandFailed { code, stderr },
            ShellError::ShellNotFound { .. } => RecipeError::Io(std::io::Error::new(
                std::io::ErrorKind::NotFound,
                e.to_string(),
            )),
            ShellError::Io(io) => RecipeError::Io(io),
        })?;

    // ── Check exit code ────────────────────────────────────────────────
    if result.exit_code != 0 {
        // D attribute: delete target file on error.
        // Phase 1b will fully implement this; Phase 1a notes it.
        if recipe.attributes.is_delete_on_error() {
            let target_path = Path::new(&recipe.target);
            if target_path.exists() {
                std::fs::remove_file(target_path).map_err(RecipeError::Io)?;
                return Err(RecipeError::TargetDeleted {
                    target: recipe.target.clone(),
                });
            }
        }
        return Err(RecipeError::CommandFailed {
            code: result.exit_code,
            stderr: result.stderr.clone(),
        });
    }

    Ok(result)
}

// ── Helpers ────────────────────────────────────────────────────────────────

/// Ensure the target exists on disk (for -t flag).
///
/// If the file doesn't exist, creates an empty file.
/// Extract member names from archive prerequisites.
/// Converts "lib.a(foo.o) lib.a(bar.o)" → "foo.o bar.o"
fn extract_members(prereqs: &[String]) -> String {
    prereqs
        .iter()
        .filter_map(|s| {
            // Find the last '(' and matching ')'
            let open = s.rfind('(')?;
            let close = s[open..].find(')')?;
            if open > 0 && close > 1 {
                Some(s[open + 1..open + close].to_string())
            } else {
                None
            }
        })
        .collect::<Vec<_>>()
        .join(" ")
}

/// If it does exist, leaves its mtime unchanged (mtime update requires
/// the `filetime` crate, not yet available in Phase 1a).
fn touch_target(target: &str) -> Result<(), RecipeError> {
    let path = Path::new(target);
    if !path.exists() {
        if let Some(parent) = path.parent() {
            if !parent.as_os_str().is_empty() {
                std::fs::create_dir_all(parent).map_err(RecipeError::Io)?;
            }
        }
        std::fs::write(path, "").map_err(RecipeError::Io)?;
    } else {
        // Update modification time by rewriting the file with its own content
        let content = std::fs::read(path).map_err(RecipeError::Io)?;
        std::fs::write(path, content).map_err(RecipeError::Io)?;
    }
    Ok(())
}

// ── Tests ──────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use std::path::Path;

    // ── Mock shell ─────────────────────────────────────────────────────

    struct MockShell {
        exit_code: i32,
        stdout: String,
        stderr: String,
        last_env: std::sync::Mutex<HashMap<String, String>>,
    }

    impl Shell for MockShell {
        fn name(&self) -> &str {
            "mock"
        }

        fn execute(
            &self,
            _recipe: &str,
            env: &HashMap<String, String>,
            _dir: &Path,
        ) -> Result<ShellResult, ShellError> {
            *self.last_env.lock().unwrap() = env.clone();
            Ok(ShellResult {
                exit_code: self.exit_code,
                stdout: self.stdout.clone(),
                stderr: self.stderr.clone(),
            })
        }

        fn find_unescaped(&self, _input: &str, _ch: char) -> Vec<usize> {
            vec![]
        }

        fn quote(&self, token: &str) -> String {
            token.to_string()
        }
    }

    fn make_recipe() -> Recipe {
        Recipe {
            target: "hello".into(),
            prereqs: vec!["hello.c".into()],
            script: "\tcc -o hello hello.c\n".into(),
            working_dir: PathBuf::from("."),
            env: HashMap::new(),
            attributes: Attributes::default(),
            stem: None,
            all_targets: vec!["hello".into()],
        }
    }

    // ── Elision tests ──────────────────────────────────────────────────

    #[test]
    fn elide_single_line_tab() {
        assert_eq!(elide_first_char("\techo hello"), "echo hello");
    }

    #[test]
    fn elide_single_line_space() {
        assert_eq!(elide_first_char(" echo hello"), "echo hello");
    }

    #[test]
    fn elide_multi_line() {
        let input = "\techo one\n\techo two";
        assert_eq!(elide_first_char(input), "echo one\necho two");
    }

    #[test]
    fn elide_preserves_blank_lines() {
        let input = "\techo one\n\n\techo two";
        assert_eq!(elide_first_char(input), "echo one\n\necho two");
    }

    #[test]
    fn elide_spaces_indent() {
        assert_eq!(elide_first_char("  echo hello"), " echo hello");
    }

    #[test]
    fn elide_empty_string() {
        assert_eq!(elide_first_char(""), "");
    }

    #[test]
    fn elide_single_char_lines() {
        // Single tab per line → after elision: empty strings
        assert_eq!(elide_first_char("\t\n\t"), "\n");
    }

    #[test]
    fn elide_only_blank_lines() {
        // Blank lines (no indent marker) → preserved as-is
        assert_eq!(elide_first_char("\n\n"), "\n\n");
    }

    // ── run() success tests ────────────────────────────────────────────

    #[test]
    fn run_success() {
        let shell = MockShell {
            exit_code: 0,
            stdout: "ok\n".into(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        let result = run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        assert_eq!(result.exit_code, 0);
        assert_eq!(result.stdout, "ok\n");
    }

    // ── run() failure tests ────────────────────────────────────────────

    #[test]
    fn run_command_failure() {
        let shell = MockShell {
            exit_code: 1,
            stdout: String::new(),
            stderr: "error".into(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        let result = run(&recipe, &shell, &RecipeOptions::default());
        assert!(result.is_err());
        match result.unwrap_err() {
            RecipeError::CommandFailed { code, .. } => assert_eq!(code, 1),
            other => panic!("expected CommandFailed, got {other:?}"),
        }
    }

    // ── -n (no-exec) tests ─────────────────────────────────────────────

    #[test]
    fn run_no_exec() {
        let shell = MockShell {
            exit_code: 0,
            stdout: "should not see this".into(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        let opts = RecipeOptions {
            no_exec: true,
            ..Default::default()
        };
        let result = run(&recipe, &shell, &opts).unwrap();
        assert_eq!(result.exit_code, 0);
        assert!(result.stdout.is_empty());
        assert!(result.stderr.is_empty());
    }

    // ── -t (touch) tests ───────────────────────────────────────────────

    #[test]
    fn run_touch_creates_file() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        // Use a temp-like target that won't conflict.
        recipe.target = "/tmp/mk-test-touch-target".into();

        // Ensure it doesn't exist before.
        let _ = std::fs::remove_file(&recipe.target);

        let opts = RecipeOptions {
            touch: true,
            ..Default::default()
        };
        let result = run(&recipe, &shell, &opts).unwrap();
        assert_eq!(result.exit_code, 0);
        assert!(Path::new(&recipe.target).exists());

        // Cleanup.
        let _ = std::fs::remove_file(&recipe.target);
    }

    #[test]
    fn run_touch_existing_file() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.target = "/tmp/mk-test-touch-existing".into();

        // Create the file first.
        std::fs::write(&recipe.target, "existing content").unwrap();

        let opts = RecipeOptions {
            touch: true,
            ..Default::default()
        };
        let result = run(&recipe, &shell, &opts).unwrap();
        assert_eq!(result.exit_code, 0);
        // File should still exist with original content.
        let content = std::fs::read_to_string(&recipe.target).unwrap();
        assert_eq!(content, "existing content");

        // Cleanup.
        let _ = std::fs::remove_file(&recipe.target);
    }

    // ── Q (quiet) attribute test ───────────────────────────────────────

    #[test]
    fn run_quiet_attribute_does_not_panic() {
        let shell = MockShell {
            exit_code: 0,
            stdout: "quiet-output".into(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.attributes = Attributes::default().with(Attributes::QUIET);
        let result = run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        assert_eq!(result.exit_code, 0);
        assert_eq!(result.stdout, "quiet-output");
    }

    // ── -s (silent) flag test ──────────────────────────────────────────

    #[test]
    fn run_silent_flag() {
        let shell = MockShell {
            exit_code: 0,
            stdout: "silent-output".into(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        let opts = RecipeOptions {
            silent: true,
            ..Default::default()
        };
        let result = run(&recipe, &shell, &opts).unwrap();
        assert_eq!(result.exit_code, 0);
        assert_eq!(result.stdout, "silent-output");
    }

    // ── -e (explain) test ──────────────────────────────────────────────

    #[test]
    fn run_explain_flag() {
        let shell = MockShell {
            exit_code: 0,
            stdout: "ok".into(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        let opts = RecipeOptions {
            explain: true,
            ..Default::default()
        };
        let result = run(&recipe, &shell, &opts).unwrap();
        assert_eq!(result.exit_code, 0);
    }

    // ── D (delete on error) attribute test ─────────────────────────────

    #[test]
    fn run_delete_on_error_attribute() {
        let shell = MockShell {
            exit_code: 1,
            stdout: String::new(),
            stderr: "fail".into(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.target = "/tmp/mk-test-delete-target".into();
        recipe.attributes = Attributes::default().with(Attributes::DELETE_ON_ERROR);

        // Create the target file first.
        std::fs::write(&recipe.target, "should be deleted").unwrap();

        let result = run(&recipe, &shell, &RecipeOptions::default());
        assert!(result.is_err());
        match result.unwrap_err() {
            RecipeError::TargetDeleted { target } => assert_eq!(target, recipe.target),
            other => panic!("expected TargetDeleted, got {other:?}"),
        }
        // File should be gone.
        assert!(!Path::new(&recipe.target).exists());
    }

    #[test]
    fn run_delete_on_error_no_file() {
        // D attribute when target file doesn't exist: should still error with
        // CommandFailed, not TargetDeleted.
        let shell = MockShell {
            exit_code: 1,
            stdout: String::new(),
            stderr: "fail".into(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.target = "/tmp/mk-test-delete-nonexistent".into();
        recipe.attributes = Attributes::default().with(Attributes::DELETE_ON_ERROR);

        // Ensure the file doesn't exist.
        let _ = std::fs::remove_file(&recipe.target);

        let result = run(&recipe, &shell, &RecipeOptions::default());
        assert!(result.is_err());
        match result.unwrap_err() {
            RecipeError::CommandFailed { code, .. } => assert_eq!(code, 1),
            other => panic!("expected CommandFailed, got {other:?}"),
        }
    }

    // ── Defaults tests ─────────────────────────────────────────────────

    #[test]
    fn recipe_options_default_all_false() {
        let opts = RecipeOptions::default();
        assert!(!opts.no_exec);
        assert!(!opts.explain);
        assert!(!opts.touch);
        assert!(!opts.silent);
    }

    #[test]
    fn shell_result_eq() {
        let a = ShellResult {
            exit_code: 0,
            stdout: "hi".into(),
            stderr: String::new(),
        };
        let b = ShellResult {
            exit_code: 0,
            stdout: "hi".into(),
            stderr: String::new(),
        };
        assert_eq!(a, b);
    }

    // ── Recipe-time variables test ─────────────────────────────────────

    #[test]
    fn run_injects_target_prereq_pid() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(env.get("target").map(|s| s.as_str()), Some("hello"));
        assert_eq!(
            env.get("prereq").map(|s| s.as_str()),
            Some("hello.c")
        );
        assert!(
            env.get("pid")
                .map(|s| s.parse::<u32>().is_ok())
                .unwrap_or(false),
            "pid should be a valid integer"
        );
    }

    #[test]
    fn run_injects_stem_for_metarule() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.stem = Some("hello".into());
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(env.get("stem").map(|s| s.as_str()), Some("hello"));
    }

    #[test]
    fn run_injects_newprereq() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert!(env.contains_key("newprereq"));
        assert_eq!(
            env.get("newprereq").map(|s| s.as_str()),
            Some("hello.c")
        );
    }

    #[test]
    fn run_injects_newmember_from_archive_prereq() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = Recipe {
            prereqs: vec!["lib.a(foo.o)".into(), "lib.a(bar.o)".into()],
            ..make_recipe()
        };
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(
            env.get("newmember").map(|s| s.as_str()),
            Some("foo.o bar.o")
        );
    }

    #[test]
    fn newmember_is_empty_without_archive_prereqs() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = Recipe {
            prereqs: vec!["hello.c".into()],
            ..make_recipe()
        };
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(
            env.get("newmember").map(|s| s.as_str()),
            Some("")
        );
    }

    #[test]
    fn run_injects_alltarget() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let mut recipe = make_recipe();
        recipe.all_targets = vec!["hello".into(), "hello_debug".into()];
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(
            env.get("alltarget").map(|s| s.as_str()),
            Some("hello hello_debug")
        );
    }

    #[test]
    fn run_injects_alltarget_single() {
        let shell = MockShell {
            exit_code: 0,
            stdout: String::new(),
            stderr: String::new(),
            last_env: std::sync::Mutex::new(HashMap::new()),
        };
        let recipe = make_recipe();
        run(&recipe, &shell, &RecipeOptions::default()).unwrap();
        let env = shell.last_env.lock().unwrap();
        assert_eq!(
            env.get("alltarget").map(|s| s.as_str()),
            Some("hello")
        );
    }
}