1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
use std::fmt::Display;
use miette::{Diagnostic, LabeledSpan, SourceCode};
use mit_commit::CommitMessage;
use thiserror::Error;
use crate::model::code::Code;
/// Information about the breaking of the lint
#[derive(Error, Debug, Eq, PartialEq, Clone)]
#[error("{error}")]
pub struct Problem {
error: String,
tip: String,
code: Code,
commit_message: String,
labels: Option<Vec<(String, usize, usize)>>,
url: Option<String>,
}
impl Diagnostic for Problem {
/// Unique diagnostic code that can be used to look up more information
/// about this Diagnostic. Ideally also globally unique, and documented in
/// the toplevel crate's documentation for easy searching. Rust path
/// format (`foo::bar::baz`) is recommended, but more classic codes like
/// `E0123` or Enums will work just fine.
fn code<'a>(&'a self) -> Option<Box<dyn Display + 'a>> {
Some(Box::new(format!("{:?}", self.code)))
}
/// Additional help text related to this Diagnostic. Do you have any
/// advice for the poor soul who's just run into this issue?
fn help<'a>(&'a self) -> Option<Box<dyn Display + 'a>> {
Some(Box::new(&self.tip))
}
fn url<'a>(&'a self) -> Option<Box<dyn Display + 'a>> {
self.url
.as_deref()
.map(|x| Box::new(x) as Box<dyn Display + 'a>)
}
fn source_code(&self) -> Option<&dyn SourceCode> {
if self.commit_message.is_empty() {
None
} else {
Some(&self.commit_message)
}
}
fn labels(&self) -> Option<Box<dyn Iterator<Item = LabeledSpan> + '_>> {
if self.commit_message.is_empty() {
return None;
}
self.labels.as_ref().map(|labels| {
Box::new(
labels.iter().map(|(label, offset, len)| {
LabeledSpan::new(Some(label.clone()), *offset, *len)
}),
) as Box<dyn Iterator<Item = LabeledSpan> + '_>
})
}
}
impl Problem {
/// Create a new problem
///
/// # Examples
///
/// ```rust
/// use std::option::Option::None;
///
/// use mit_lint::{Code, Problem};
/// let problem = Problem::new(
/// "Error title".to_string(),
/// "Some advice on how to fix it".to_string(),
/// Code::BodyWiderThan72Characters,
/// &"Commit Message".into(),
/// None,
/// None,
/// );
///
/// assert_eq!(problem.error(), "Error title".to_string())
/// ```
#[must_use]
pub fn new(
error: String,
tip: String,
code: Code,
commit_message: &CommitMessage<'_>,
labels: Option<Vec<(String, usize, usize)>>,
url: Option<String>,
) -> Self {
Self {
error,
tip,
code,
commit_message: String::from(commit_message.clone()),
labels,
url,
}
}
/// Get the code for this problem
///
/// # Examples
///
/// ```rust
/// use std::option::Option::None;
///
/// use mit_lint::{Code, Problem};
/// let problem = Problem::new(
/// "Error title".to_string(),
/// "Some advice on how to fix it".to_string(),
/// Code::BodyWiderThan72Characters,
/// &"Commit Message".into(),
/// None,
/// None,
/// );
///
/// assert_eq!(problem.code(), &Code::BodyWiderThan72Characters)
/// ```
#[must_use]
pub const fn code(&self) -> &Code {
&self.code
}
/// Get the commit message for this problem
///
/// # Examples
///
/// ```rust
/// use std::option::Option::None;
///
/// use mit_commit::CommitMessage;
/// use mit_lint::{Code, Problem};
/// let problem = Problem::new(
/// "Error title".to_string(),
/// "Some advice on how to fix it".to_string(),
/// Code::BodyWiderThan72Characters,
/// &"Commit Message".into(),
/// None,
/// None,
/// );
///
/// assert_eq!(
/// problem.commit_message(),
/// CommitMessage::from("Commit Message")
/// )
/// ```
#[must_use]
pub fn commit_message(&self) -> CommitMessage<'_> {
self.commit_message.clone().into()
}
/// Get the descriptive title for this error
///
/// # Examples
///
/// ```rust
/// use std::option::Option::None;
///
/// use mit_lint::{Code, Problem};
/// let problem = Problem::new(
/// "Error title".to_string(),
/// "Some advice on how to fix it".to_string(),
/// Code::BodyWiderThan72Characters,
/// &"Commit Message".into(),
/// None,
/// None,
/// );
///
/// assert_eq!(problem.error(), "Error title".to_string())
/// ```
#[must_use]
pub fn error(&self) -> &str {
&self.error
}
/// Get advice on how to fix the problem
///
/// This should be a description of why this is a problem, and how to fix it
///
/// # Examples
///
/// ```rust
/// use std::option::Option::None;
///
/// use mit_lint::{Code, Problem};
/// let problem = Problem::new(
/// "Error title".to_string(),
/// "Some advice on how to fix it".to_string(),
/// Code::BodyWiderThan72Characters,
/// &"Commit Message".into(),
/// None,
/// None,
/// );
///
/// assert_eq!(problem.tip(), "Some advice on how to fix it".to_string())
/// ```
#[must_use]
pub fn tip(&self) -> &str {
&self.tip
}
}
#[cfg(test)]
mod tests {
use super::*;
use std::option::Option::None;
use miette::Diagnostic;
use mit_commit::CommitMessage;
#[test]
fn test_error_returns_correct_value() {
let problem = Problem::new(
"Some error".into(),
String::new(),
Code::NotConventionalCommit,
&"".into(),
None,
None,
);
assert_eq!(problem.error(), "Some error");
}
#[test]
fn test_empty_commit_returns_no_labels() {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&"".into(),
Some(vec![("String".to_string(), 10_usize, 20_usize)]),
None,
);
assert!(problem.labels().is_none());
}
#[test]
fn test_empty_commit_returns_no_source_code() {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&"".into(),
Some(vec![("String".to_string(), 10_usize, 20_usize)]),
None,
);
assert!(problem.source_code().is_none());
}
#[allow(
clippy::needless_pass_by_value,
reason = "Cannot be passed by value, not supported by quickcheck"
)]
#[quickcheck]
fn test_error_matches_input(error: String) -> bool {
let problem = Problem::new(
error.clone(),
String::new(),
Code::NotConventionalCommit,
&CommitMessage::from(""),
None,
None,
);
problem.error() == error
}
#[test]
fn test_tip_returns_correct_value() {
let problem = Problem::new(
String::new(),
"Some tip".into(),
Code::NotConventionalCommit,
&"".into(),
None,
None,
);
assert_eq!(problem.tip(), "Some tip");
}
#[allow(
clippy::needless_pass_by_value,
reason = "Cannot be passed by value, not supported by quickcheck"
)]
#[quickcheck]
fn test_tip_matches_input(tip: String) -> bool {
let problem = Problem::new(
String::new(),
tip.to_string(),
Code::NotConventionalCommit,
&"".into(),
None,
None,
);
problem.tip() == tip
}
#[test]
fn test_code_returns_correct_value() {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&"".into(),
None,
None,
);
assert_eq!(problem.code(), &Code::NotConventionalCommit);
}
#[quickcheck]
fn test_code_matches_input(code: Code) {
let problem = Problem::new(String::new(), String::new(), code, &"".into(), None, None);
assert_eq!(problem.code(), &code, "Code should match the input value");
}
#[test]
fn test_commit_message_returns_correct_value() {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&CommitMessage::from("Commit message"),
None,
None,
);
assert_eq!(
problem.commit_message(),
CommitMessage::from("Commit message")
);
}
#[quickcheck]
fn test_commit_message_matches_input(message: String) {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&CommitMessage::from(message.clone()),
None,
None,
);
assert_eq!(
problem.commit_message(),
CommitMessage::from(message),
"Commit message should match the input value"
);
}
#[test]
fn test_labels_return_correct_values() {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&CommitMessage::from("Commit message"),
Some(vec![("String".to_string(), 10_usize, 20_usize)]),
None,
);
assert_eq!(
problem
.labels()
.unwrap()
.map(|x| (x.label().unwrap().to_string(), x.offset(), x.len()))
.collect::<Vec<_>>(),
vec![("String".to_string(), 10_usize, 20_usize)]
);
}
#[quickcheck]
fn test_labels_match_input_values(start: usize, offset: usize) {
let problem = Problem::new(
String::new(),
String::new(),
Code::NotConventionalCommit,
&CommitMessage::from("Commit message"),
Some(vec![("String".to_string(), start, offset)]),
None,
);
assert_eq!(
problem
.labels()
.unwrap()
.map(|x| (x.label().unwrap().to_string(), x.offset(), x.len()))
.collect::<Vec<_>>(),
vec![("String".to_string(), start, offset)]
);
}
}