mise 2026.6.5

Dev tools, env vars, and tasks in one CLI
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
use std::fmt::{Debug, Display};
use std::{
    collections::{BTreeMap, BTreeSet, HashSet},
    sync::Arc,
};

use crate::backend::backend_type::BackendType;
use crate::cli::args::{BackendArg, ToolArg};
use crate::config::{Config, Settings};
use crate::env;
use crate::registry::{REGISTRY, tool_enabled};
use crate::toolset::{ToolRequest, ToolSource, Toolset};
use indexmap::IndexMap;
use itertools::Itertools;

#[derive(Debug, Default, Clone)]
pub struct ToolRequestSet {
    pub tools: IndexMap<Arc<BackendArg>, Vec<ToolRequest>>,
    pub sources: BTreeMap<Arc<BackendArg>, ToolSource>,
    /// Tools that were filtered out because they don't exist in the registry (BackendType::Unknown)
    pub unknown_tools: Vec<Arc<BackendArg>>,
}

impl ToolRequestSet {
    pub fn new() -> Self {
        Self::default()
    }

    // pub fn tools_with_sources(&self) -> Vec<(&BackendArg, &Vec<ToolRequest>, &ToolSource)> {
    //     self.tools
    //         .iter()
    //         .map(|(backend, tvr)| (backend, tvr, self.sources.get(backend).unwrap()))
    //         .collect()
    // }

    // pub fn installed_tools(&self) -> eyre::Result<Vec<&ToolRequest>> {
    //     self.tools
    //         .values()
    //         .flatten()
    //         .map(|tvr| match tvr.is_installed()? {
    //             true => Ok(Some(tvr)),
    //             false => Ok(None),
    //         })
    //         .flatten_ok()
    //         .collect()
    // }

    pub async fn missing_tools(&self, config: &Arc<Config>) -> Vec<&ToolRequest> {
        let mut tools = vec![];
        for tr in self.tools.values().flatten() {
            if tr.is_os_supported() && !tr.is_installed(config).await {
                tools.push(tr);
            }
        }
        tools
    }

    pub fn list_tools(&self) -> Vec<&Arc<BackendArg>> {
        self.tools.keys().collect()
    }

    pub fn add_version(&mut self, tr: ToolRequest, source: &ToolSource) {
        let fa = tr.ba();
        if !self.tools.contains_key(fa) {
            self.sources.insert(fa.clone(), source.clone());
        }
        let list = self.tools.entry(tr.ba().clone()).or_default();
        list.push(tr);
    }

    pub fn iter(&self) -> impl Iterator<Item = (&Arc<BackendArg>, &Vec<ToolRequest>, &ToolSource)> {
        self.tools
            .iter()
            .map(|(backend, tvr)| (backend, tvr, self.sources.get(backend).unwrap()))
    }

    pub fn into_iter(
        self,
    ) -> impl Iterator<Item = (Arc<BackendArg>, Vec<ToolRequest>, ToolSource)> {
        self.tools.into_iter().map(move |(ba, tvr)| {
            let source = self.sources.get(&ba).unwrap().clone();
            (ba, tvr, source)
        })
    }

    pub fn filter_by_tool(&self, mut tools: HashSet<String>) -> ToolRequestSet {
        // add in the full names so something like cargo:cargo-binstall can be used in place of cargo-binstall
        for short in tools.clone().iter() {
            if let Some(rt) = REGISTRY.get(short.as_str()) {
                tools.extend(rt.backends().iter().map(|s| s.to_string()));
            }
        }
        self.iter()
            .filter(|(ba, ..)| tools.contains(&ba.short) || tools.contains(&ba.full()))
            .map(|(ba, trl, ts)| (ba.clone(), trl.clone(), ts.clone()))
            .collect::<ToolRequestSet>()
    }

    pub fn into_toolset(self) -> Toolset {
        self.into()
    }
}

impl Display for ToolRequestSet {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let versions = self.tools.values().flatten().join(" ");
        if versions.is_empty() {
            write!(f, "ToolRequestSet: <empty>")?;
        } else {
            write!(f, "ToolRequestSet: {versions}")?;
        }
        Ok(())
    }
}

impl FromIterator<(Arc<BackendArg>, Vec<ToolRequest>, ToolSource)> for ToolRequestSet {
    fn from_iter<T>(iter: T) -> Self
    where
        T: IntoIterator<Item = (Arc<BackendArg>, Vec<ToolRequest>, ToolSource)>,
    {
        let mut trs = ToolRequestSet::new();
        for (_ba, tvr, source) in iter {
            for tr in tvr {
                trs.add_version(tr.clone(), &source);
            }
        }
        trs
    }
}

#[derive(Debug, Default)]
pub struct ToolRequestSetBuilder {
    /// cli tool args
    args: Vec<ToolArg>,
    /// default to latest version if no version is specified (for `mise x`)
    default_to_latest: bool,
    /// tools which will be disabled
    disable_tools: BTreeSet<BackendArg>,
    /// tools which will be enabled
    enable_tools: Option<BTreeSet<BackendArg>>,
}

impl ToolRequestSetBuilder {
    pub fn new() -> Self {
        let settings = Settings::get();
        Self {
            disable_tools: settings.disable_tools().iter().map(|s| s.into()).collect(),
            enable_tools: settings
                .enable_tools()
                .map(|tools| tools.iter().map(|s| s.into()).collect()),
            ..Default::default()
        }
    }

    // pub fn add_arg(mut self, arg: ToolArg) -> Self {
    //     self.args.push(arg);
    //     self
    // }
    //
    // pub fn default_to_latest(mut self) -> Self {
    //     self.default_to_latest = true;
    //     self
    // }
    //

    pub async fn build(&self, config: &Arc<Config>) -> eyre::Result<ToolRequestSet> {
        let mut trs = ToolRequestSet::default();
        trs = self.load_config_files(config, trs).await?;
        trs = self.load_runtime_env(trs)?;
        trs = self.load_runtime_args(trs)?;

        for ba in trs.tools.keys().cloned().collect_vec() {
            if self.is_disabled(&ba) {
                if trs
                    .tools
                    .get(&ba)
                    .is_some_and(|requests| self.should_report_unknown_tool(&ba, requests))
                {
                    trs.unknown_tools.push(ba.clone());
                }
                trs.tools.shift_remove(&ba);
                trs.sources.remove(&ba);
            }
        }

        time!("tool_request_set::build");
        Ok(trs)
    }

    fn is_disabled(&self, ba: &BackendArg) -> bool {
        let backend_type = ba.backend_type();
        backend_type == BackendType::Unknown
            || (cfg!(windows) && backend_type == BackendType::Asdf)
            || !ba.is_os_supported()
            || !tool_enabled(self.enable_tools.as_ref(), &self.disable_tools, ba)
    }

    fn should_report_unknown_tool(&self, ba: &BackendArg, requests: &[ToolRequest]) -> bool {
        ba.backend_type() == BackendType::Unknown
            && tool_enabled(self.enable_tools.as_ref(), &self.disable_tools, ba)
            && requests.iter().any(ToolRequest::is_os_supported)
    }

    async fn load_config_files(
        &self,
        config: &Arc<Config>,
        mut trs: ToolRequestSet,
    ) -> eyre::Result<ToolRequestSet> {
        for cf in config.config_files.values().rev() {
            trs = merge(trs, cf.to_tool_request_set()?);
        }
        Ok(trs)
    }

    fn load_runtime_env(&self, mut trs: ToolRequestSet) -> eyre::Result<ToolRequestSet> {
        for (short, k, v) in tool_env_vars() {
            let ba: Arc<BackendArg> = Arc::new(short.as_str().into());
            let source = ToolSource::Environment(k, v.clone());
            let mut env_ts = ToolRequestSet::new();
            for v in v.split_whitespace() {
                let tvr = ToolRequest::new(ba.clone(), v, source.clone())?;
                env_ts.add_version(tvr, &source);
            }
            trs = merge(trs, env_ts);
        }
        Ok(trs)
    }

    fn load_runtime_args(&self, mut trs: ToolRequestSet) -> eyre::Result<ToolRequestSet> {
        for (_, args) in self.args.iter().into_group_map_by(|arg| arg.ba.clone()) {
            let mut arg_ts = ToolRequestSet::new();
            for arg in args {
                if let Some(tvr) = &arg.tvr {
                    arg_ts.add_version(tvr.clone(), &ToolSource::Argument);
                } else if self.default_to_latest {
                    // this logic is required for `mise x` because with that specific command mise
                    // should default to installing the "latest" version if no version is specified
                    // in mise.toml

                    if !trs.tools.contains_key(&arg.ba) {
                        // no active version, so use "latest"
                        let tr = ToolRequest::new(arg.ba.clone(), "latest", ToolSource::Argument)?;
                        arg_ts.add_version(tr, &ToolSource::Argument);
                    }
                }
            }
            trs = merge(trs, arg_ts);
        }

        let tool_args = env::TOOL_ARGS.read().unwrap();
        let mut arg_trs = ToolRequestSet::new();
        for arg in tool_args.iter() {
            if let Some(tvr) = &arg.tvr {
                let mut tvr = tvr.clone();
                // When CLI specifies a version for a tool that's in config,
                // merge config options (e.g. postinstall) into the CLI request
                if tvr.options().is_empty()
                    && let Some(config_tvr) = trs.tools.get(&arg.ba).and_then(|v| v.first())
                {
                    let config_opts = config_tvr.options();
                    if !config_opts.is_empty() {
                        tvr.set_options(config_opts);
                    }
                }
                arg_trs.add_version(tvr, &ToolSource::Argument);
            } else if !trs.tools.contains_key(&arg.ba) {
                // no active version, so use "latest"
                let tr = ToolRequest::new(arg.ba.clone(), "latest", ToolSource::Argument)?;
                arg_trs.add_version(tr, &ToolSource::Argument);
            }
        }
        trs = merge(trs, arg_trs);

        Ok(trs)
    }
}

fn merge(mut a: ToolRequestSet, mut b: ToolRequestSet) -> ToolRequestSet {
    // move things around such that the tools are in the config order
    a.tools.retain(|ba, _| !b.tools.contains_key(ba));
    a.sources.retain(|ba, _| !b.sources.contains_key(ba));
    b.tools.extend(a.tools);
    b.sources.extend(a.sources);
    b
}

/// Yields `(short, key, value)` for each `MISE_<TOOL>_VERSION` env var that
/// maps to a tool. `short` is the unaliased backend short name (so
/// `MISE_NODEJS_VERSION` yields `"node"`). Skips `MISE_VERSION` and the
/// `MISE_INSTALL_VERSION` / `MISE_TOOL_VERSION` vars set during hooks.
pub fn tool_env_vars() -> impl Iterator<Item = (String, String, String)> {
    env::vars_safe().filter_map(|(k, v)| {
        if !k.starts_with("MISE_") || !k.ends_with("_VERSION") || k == "MISE_VERSION" {
            return None;
        }
        let raw = k
            .trim_start_matches("MISE_")
            .trim_end_matches("_VERSION")
            .to_lowercase();
        if raw == "install" || raw == "tool" {
            return None;
        }
        let short = crate::backend::unalias_backend(&raw).to_string();
        Some((short, k, v))
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::toolset::{CoreToolOptions, ToolVersionOptions};

    #[test]
    fn test_load_runtime_env_with_valid_utf8() {
        // This test verifies that valid UTF-8 MISE_*_VERSION variables work correctly
        unsafe {
            std::env::set_var("MISE_NODE_VERSION", "20.0.0");
            std::env::set_var("MISE_PYTHON_VERSION", "3.11");
        }

        let builder = ToolRequestSetBuilder::new();
        let trs = builder.load_runtime_env(ToolRequestSet::new());

        // Should not panic and should successfully load the versions
        assert!(trs.is_ok());
        let trs = trs.unwrap();
        assert!(trs.tools.len() >= 2 || trs.tools.is_empty()); // May be empty if backends are disabled

        unsafe {
            std::env::remove_var("MISE_NODE_VERSION");
            std::env::remove_var("MISE_PYTHON_VERSION");
        }
    }

    #[test]
    fn test_tool_env_vars_unaliases_backend() {
        // MISE_NODEJS_VERSION should yield "node" (the unaliased backend
        // short name), not "nodejs" — otherwise the install command's
        // configured-tool check fails to match unaliased ToolArg shorts.
        unsafe {
            std::env::set_var("MISE_NODEJS_VERSION", "22.0.0");
            std::env::set_var("MISE_GOLANG_VERSION", "1.22.0");
        }

        let entries: Vec<(String, String, String)> = tool_env_vars()
            .filter(|(_, k, _)| k == "MISE_NODEJS_VERSION" || k == "MISE_GOLANG_VERSION")
            .collect();

        let nodejs = entries
            .iter()
            .find(|(_, k, _)| k == "MISE_NODEJS_VERSION")
            .expect("MISE_NODEJS_VERSION should yield an entry");
        assert_eq!(nodejs.0, "node");

        let golang = entries
            .iter()
            .find(|(_, k, _)| k == "MISE_GOLANG_VERSION")
            .expect("MISE_GOLANG_VERSION should yield an entry");
        assert_eq!(golang.0, "go");

        unsafe {
            std::env::remove_var("MISE_NODEJS_VERSION");
            std::env::remove_var("MISE_GOLANG_VERSION");
        }
    }

    #[test]
    fn test_tool_env_vars_skips_non_tool_vars() {
        unsafe {
            std::env::set_var("MISE_VERSION", "2026.4.28");
            std::env::set_var("MISE_INSTALL_VERSION", "1.0.0");
            std::env::set_var("MISE_TOOL_VERSION", "1.0.0");
        }

        let keys: HashSet<String> = tool_env_vars().map(|(_, k, _)| k).collect();
        assert!(!keys.contains("MISE_VERSION"));
        assert!(!keys.contains("MISE_INSTALL_VERSION"));
        assert!(!keys.contains("MISE_TOOL_VERSION"));

        unsafe {
            std::env::remove_var("MISE_VERSION");
            std::env::remove_var("MISE_INSTALL_VERSION");
            std::env::remove_var("MISE_TOOL_VERSION");
        }
    }

    #[test]
    fn test_load_runtime_env_ignores_non_mise_vars() {
        // Non-MISE variables should be ignored, even with special characters
        unsafe {
            std::env::set_var("HOMEBREW_INSTALL_BADGE", "");
            std::env::set_var("SOME_OTHER_VAR", "value");
        }

        let builder = ToolRequestSetBuilder::new();
        let result = builder.load_runtime_env(ToolRequestSet::new());

        // Should not panic when non-MISE vars are present
        assert!(result.is_ok());

        unsafe {
            std::env::remove_var("HOMEBREW_INSTALL_BADGE");
            std::env::remove_var("SOME_OTHER_VAR");
        }
    }

    fn unknown_tool_request(os: Option<Vec<String>>) -> (Arc<BackendArg>, Vec<ToolRequest>) {
        let ba = Arc::new(BackendArg::from("unknown-os-filtered-tool"));
        let options = ToolVersionOptions {
            core: CoreToolOptions {
                os,
                ..Default::default()
            },
            ..Default::default()
        };
        let request =
            ToolRequest::new_opts(ba.clone(), "latest", options, ToolSource::Unknown).unwrap();
        (ba, vec![request])
    }

    fn inactive_os() -> String {
        match crate::cli::version::OS.as_str() {
            "linux" => "macos",
            _ => "linux",
        }
        .to_string()
    }

    #[tokio::test]
    async fn test_should_not_report_unknown_tool_when_all_requests_are_os_inactive() {
        crate::toolset::install_state::init().await.unwrap();
        let builder = ToolRequestSetBuilder::default();
        let (ba, requests) = unknown_tool_request(Some(vec![inactive_os()]));

        assert!(!builder.should_report_unknown_tool(&ba, &requests));
    }

    #[tokio::test]
    async fn test_should_report_unknown_tool_when_any_request_is_os_active() {
        crate::toolset::install_state::init().await.unwrap();
        let builder = ToolRequestSetBuilder::default();
        let (ba, mut requests) = unknown_tool_request(Some(vec![inactive_os()]));
        let options = ToolVersionOptions {
            core: CoreToolOptions {
                os: Some(vec![crate::cli::version::OS.to_string()]),
                ..Default::default()
            },
            ..Default::default()
        };
        requests.push(
            ToolRequest::new_opts(ba.clone(), "latest", options, ToolSource::Unknown).unwrap(),
        );

        assert!(builder.should_report_unknown_tool(&ba, &requests));
    }

    #[tokio::test]
    async fn test_should_not_report_unknown_tool_when_tool_is_disabled() {
        crate::toolset::install_state::init().await.unwrap();
        let (ba, requests) = unknown_tool_request(None);
        let builder = ToolRequestSetBuilder {
            disable_tools: BTreeSet::from([BackendArg::from("unknown-os-filtered-tool")]),
            ..Default::default()
        };

        assert!(!builder.should_report_unknown_tool(&ba, &requests));
    }
}