mini_udp 0.3.0

A minimal implementation of a reliability protocol on top of UDP for game networking
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
use std::collections::VecDeque;

use crate::{
    communicator::SocketSendAddr,
    prelude::*,
    ring_buffer::{RingBuffer, wrapping_gt},
};

pub(crate) struct InnerUdpCommunicator<SEND: ByteRepr, RECV: ByteRepr, const PROTOCOL_VERSION: u32>
{
    pub reliable_send_packets: RingBuffer<(Instant, Packet<SEND>)>,
    pub reliable_ordered_send_packets: RingBuffer<(Instant, Packet<SEND>)>,
    pub reliable_received_packets: RingBuffer<()>,
    pub reliable_ordered_received_packets: RingBuffer<Packet<RECV>>,
    /// The sequence id of the next ordered packet to be read
    pub ordered_read_packet_head: u16,
    pub unreliable_send_packet_id: u16,
    pub unreliable_send_packets: VecDeque<Packet<SEND>>,
    pub reliable_send_queue: VecDeque<SEND>,
    pub reliable_ordered_send_queue: VecDeque<SEND>,
    pub unreliable_send_queue: VecDeque<SEND>,
    pub unordered_recv_queue: VecDeque<RECV>,
    pub ordered_recv_queue: VecDeque<RECV>,
    /// If this is `true`, a packet has been received more than once, potentially meaning that we
    /// have to send an ack to the other side.
    pub received_packet_duplicate: bool,
    pub last_seen: Instant,
    pub last_send: Instant,
    #[cfg(test)]
    pub received_reliable_packet_ids: std::collections::HashSet<u16>,
    #[cfg(test)]
    pub received_ordered_packet_ids: std::collections::HashSet<u16>,
}

impl<SEND: ByteRepr, RECV: ByteRepr, const PROTOCOL_VERSION: u32> Default
    for InnerUdpCommunicator<SEND, RECV, PROTOCOL_VERSION>
{
    fn default() -> Self {
        Self {
            reliable_send_packets: RingBuffer::new(),
            reliable_ordered_send_packets: RingBuffer::new(),
            reliable_received_packets: RingBuffer::new(),
            reliable_ordered_received_packets: RingBuffer::new(),
            ordered_read_packet_head: 0,
            unreliable_send_packet_id: 0,
            unreliable_send_packets: VecDeque::new(),
            reliable_send_queue: VecDeque::new(),
            reliable_ordered_send_queue: VecDeque::new(),
            unreliable_send_queue: VecDeque::new(),
            unordered_recv_queue: VecDeque::new(),
            ordered_recv_queue: VecDeque::new(),
            received_packet_duplicate: false,
            last_seen: Instant::now(),
            last_send: Instant::now(),
            #[cfg(test)]
            received_reliable_packet_ids: std::collections::HashSet::new(),
            #[cfg(test)]
            received_ordered_packet_ids: std::collections::HashSet::new(),
        }
    }
}

impl<SEND: ByteRepr, RECV: ByteRepr, const PROTOCOL_VERSION: u32>
    InnerUdpCommunicator<SEND, RECV, PROTOCOL_VERSION>
{
    /// [`crc::CRC_32_BZIP2`] with `init` set to [`PROTOCOL_VERSION`]
    const CRC_ALGORITHM: crc::Algorithm<u32> = crc::Algorithm {
        width: 32,
        poly: 0x04c11db7,
        init: PROTOCOL_VERSION,
        refin: false,
        refout: false,
        xorout: 0xffffffff,
        check: 0xfc891918,
        residue: 0xc704dd7b,
    };
    const CRC: crc::Crc<u32> = crc::Crc::<u32>::new(&Self::CRC_ALGORITHM);

    pub fn send<Addr>(
        &mut self,
        addr: Addr,
        socket: &mut UdpCommunicatorSocket,
    ) -> Result<(), ByteReprError>
    where
        Addr: SocketSendAddr,
    {
        if self.received_packet_duplicate
            && self.reliable_send_queue.is_empty()
            && self.reliable_ordered_send_queue.is_empty()
            && self.unreliable_send_queue.is_empty()
        {
            #[cfg(feature = "debug")]
            if socket.debug_logs {
                debug!("Sending heartbeat");
            }
            let sequence_id = self.unreliable_send_packet_id;
            self.unreliable_send_packet_id = self.unreliable_send_packet_id.wrapping_add(1);
            let packet = Packet::heartbeat(PacketAck::new(
                sequence_id,
                &self.reliable_received_packets,
                &self.reliable_ordered_received_packets,
            ));
            #[cfg(feature = "debug")]
            if socket.debug_logs {
                debug!("Constructed new hearbeat packet with id(unreliable): #{sequence_id}");
            }
            self.unreliable_send_packets.push_back(packet);
        }
        self.received_packet_duplicate = false;
        self.flush_messages(
            #[cfg(feature = "debug")]
            socket,
        );
        self.send_packets(addr, socket)
    }

    pub fn receive(&mut self, socket: &mut UdpCommunicatorSocket) {
        while let Ok(n) = socket.socket.recv(&mut socket.data_buffer) {
            #[cfg(feature = "debug")]
            if socket.delay_packet(None, n) {
                continue;
            }
            self.read_packet(n, socket);
        }
        #[cfg(feature = "debug")]
        while let Some((n, _)) = socket.read_delayed() {
            self.read_packet(n, socket);
        }
    }

    pub fn read_packet(&mut self, n: usize, socket: &mut UdpCommunicatorSocket) {
        #[cfg(feature = "debug")]
        let packet = Packet::<RECV>::from_bytes(&socket.data_buffer[4..n])
            .unwrap()
            .ack
            .sequence_id;
        #[cfg(feature = "debug")]
        // Fake UDP unreliability
        if let Some(p) = socket.corruption_probability
            && rand::random_bool(p)
        {
            let corrupt_num = rand::random_range(0..n * 8);
            if socket.debug_logs {
                debug!("Corrupting {corrupt_num} bits of packet #{packet}",);
            }
            for i in 0..corrupt_num {
                socket.data_buffer[i / 8] ^= 1 << (i % 8);
            }
        }
        let Ok(crc_bytes) = socket.data_buffer[..4].try_into() else {
            return;
        };
        let crc = u32::from_le_bytes(crc_bytes);
        if Self::CRC.checksum(&socket.data_buffer[4..n]) != crc {
            #[cfg(all(test, feature = "debug"))]
            warn!("CRC check failed, packet: {packet:#?}");
            return;
        }
        match Packet::<RECV>::from_bytes(&socket.data_buffer[4..n]) {
            Ok(packet) => {
                #[cfg(feature = "debug")]
                // Fake UDP unreliability
                if let Some(p) = socket.drop_probability
                    && rand::random_bool(p)
                {
                    return;
                }
                #[cfg(test)]
                debug!("Receiving packet #{}", packet.ack.sequence_id);
                self.last_seen = Instant::now();
                if !packet.reliable {
                    if packet.messages.is_empty() {
                        // Heartbeat
                        #[cfg(test)]
                        debug!("Received heartbeat packet #{}", packet.ack.sequence_id);
                    } else {
                        self.unordered_recv_queue.extend(packet.messages);
                    }
                    self.acknowledge(&packet.ack);
                    return;
                }

                if (packet.ordered
                    && self
                        .reliable_ordered_received_packets
                        .get(packet.ack.sequence_id)
                        .is_some())
                    || (!packet.ordered
                        && self
                            .reliable_received_packets
                            .get(packet.ack.sequence_id)
                            .is_some())
                {
                    self.received_packet_duplicate = true;
                    #[cfg(test)]
                    debug!(
                        "Received duplicate packet #{} (ordered = {})",
                        packet.ack.sequence_id, packet.ordered
                    );
                    return;
                }
                let newest_index = if packet.ordered {
                    self.reliable_ordered_received_packets.get_newest_index()
                } else {
                    self.reliable_received_packets.get_newest_index()
                };
                if wrapping_gt(newest_index.wrapping_sub(31), packet.ack.sequence_id, 64) {
                    self.received_packet_duplicate = true;
                    #[cfg(test)]
                    debug!(
                        "Received too old packet #{} (ordered = {})",
                        packet.ack.sequence_id, packet.ordered
                    );
                    return;
                }

                #[cfg(test)]
                assert!(
                    if packet.ordered {
                        &mut self.received_ordered_packet_ids
                    } else {
                        &mut self.received_reliable_packet_ids
                    }
                    .insert(packet.ack.sequence_id)
                );

                self.acknowledge(&packet.ack);
                if packet.ordered {
                    self.reliable_ordered_received_packets
                        .insert(packet.ack.sequence_id, packet);
                    for (id, packet) in self.reliable_ordered_received_packets.iter_mut() {
                        if id == self.ordered_read_packet_head {
                            self.ordered_read_packet_head =
                                self.ordered_read_packet_head.wrapping_add(1);
                            self.ordered_recv_queue.extend(packet.messages.drain(..));
                        } else if wrapping_gt(id, self.ordered_read_packet_head, 32) {
                            break;
                        }
                    }
                } else {
                    self.reliable_received_packets
                        .insert(packet.ack.sequence_id, ());
                    self.unordered_recv_queue.extend(packet.messages);
                }
            }
            Err(e) => warn!("Received invalid packet: {e}"),
        }
    }

    pub fn write_heartbeat(&mut self, #[cfg(feature = "debug")] socket: &UdpCommunicatorSocket) {
        let sequence_id = self.unreliable_send_packet_id;
        self.unreliable_send_packet_id = self.unreliable_send_packet_id.wrapping_add(1);
        let packet = Packet::heartbeat(PacketAck::new(
            sequence_id,
            &self.reliable_received_packets,
            &self.reliable_ordered_received_packets,
        ));
        #[cfg(feature = "debug")]
        if socket.debug_logs {
            debug!("Constructed new hearbeat packet with id(unreliable): #{sequence_id}");
        }
        self.unreliable_send_packets.push_back(packet);
    }

    fn flush_messages(&mut self, #[cfg(feature = "debug")] socket: &UdpCommunicatorSocket) {
        flush_messages(
            #[cfg(feature = "debug")]
            socket,
            &mut self.reliable_send_packets,
            &self.reliable_received_packets,
            &self.reliable_ordered_received_packets,
            &mut self.reliable_send_queue,
            false,
        );
        flush_messages(
            #[cfg(feature = "debug")]
            socket,
            &mut self.reliable_ordered_send_packets,
            &self.reliable_received_packets,
            &self.reliable_ordered_received_packets,
            &mut self.reliable_ordered_send_queue,
            true,
        );
        while !self.unreliable_send_queue.is_empty() {
            let mut available_bytes = MAX_PACKET_DATA_LEN;
            let mut included_msgs = 0;
            for msg in self.unreliable_send_queue.iter() {
                if msg.byte_len() <= available_bytes {
                    available_bytes -= msg.byte_len();
                    included_msgs += 1;
                } else {
                    // TODO! Maybe include other messages here that are small enough, but that
                    // would make message ordering arbitrary
                    break;
                }
            }
            if included_msgs == 0 {
                error!(
                    "Msg {:#?} is too large to fit {} bytes, but the max packet size is {}",
                    self.unreliable_send_queue[0],
                    self.unreliable_send_queue[0].byte_len(),
                    MAX_PACKET_DATA_LEN
                );
            }
            let sequence_id = self.unreliable_send_packet_id;
            self.unreliable_send_packet_id = self.unreliable_send_packet_id.wrapping_add(1);
            let packet = Packet {
                ack: PacketAck::new(
                    sequence_id,
                    &self.reliable_received_packets,
                    &self.reliable_ordered_received_packets,
                ),
                reliable: false,
                ordered: false,
                messages: self.unreliable_send_queue.drain(..included_msgs).collect(),
            };
            #[cfg(feature = "debug")]
            if socket.debug_logs {
                debug!(
                    "Constructed new unreliable packet #{sequence_id} with {included_msgs} messages"
                );
            }
            self.unreliable_send_packets.push_back(packet);
        }
    }

    fn send_packets<Addr>(
        &mut self,
        addr: Addr,
        socket: &mut UdpCommunicatorSocket,
    ) -> Result<(), ByteReprError>
    where
        Addr: SocketSendAddr,
    {
        let mut any_send = false;
        for (last_send, packet) in self
            .reliable_send_packets
            .values_mut()
            .chain(self.reliable_ordered_send_packets.values_mut())
        {
            let send_cooldown = if cfg!(test) {
                Duration::from_millis(3)
            } else if packet.ordered {
                socket.reliable_ordered_resend_interval
            } else {
                socket.reliable_unordered_resend_interval
            };
            if last_send.elapsed() > send_cooldown {
                *last_send = Instant::now();
                if let Err(e) = packet.write_to_bytes(&mut socket.data_buffer[4..]) {
                    panic!(
                        "{e}: {:?}\npacket len: {}\npacket max len: {}\ndatabuffer len: {}",
                        *packet,
                        packet.byte_len(),
                        Packet::<SEND>::MAX_BYTE_LEN,
                        socket.data_buffer.len()
                    );
                }
                let crc = Self::CRC.checksum(&socket.data_buffer[4..4 + packet.byte_len()]);
                socket.data_buffer[..4].copy_from_slice(&crc.to_le_bytes());
                if let Err(e) = addr.send(socket, ..4 + packet.byte_len()) {
                    error!("Failed to send packet: {e}");
                } else {
                    any_send = true;
                }
            }
        }
        for packet in self.unreliable_send_packets.drain(..) {
            packet.write_to_bytes(&mut socket.data_buffer[4..])?;
            let crc = Self::CRC.checksum(&socket.data_buffer[4..4 + packet.byte_len()]);
            socket.data_buffer[..4].copy_from_slice(&crc.to_le_bytes());
            if let Err(e) = addr.send(socket, ..4 + packet.byte_len()) {
                error!("Failed to send packet: {e}");
            } else {
                any_send = true;
            }
        }

        if any_send {
            self.last_send = Instant::now();
        }

        Ok(())
    }

    pub fn has_work(&self) -> bool {
        !(self.reliable_send_packets.is_empty()
            && self.reliable_ordered_send_packets.is_empty()
            && self.unreliable_send_packets.is_empty()
            && self.reliable_send_queue.is_empty()
            && self.reliable_ordered_send_queue.is_empty()
            && self.unreliable_send_queue.is_empty())
    }
}

fn flush_messages<SEND: ByteRepr, RECV: ByteRepr>(
    #[cfg(feature = "debug")] socket: &UdpCommunicatorSocket,
    send_packets: &mut RingBuffer<(Instant, Packet<SEND>)>,
    reliable_received: &RingBuffer<()>,
    ordered_received: &RingBuffer<Packet<RECV>>,
    send_queue: &mut VecDeque<SEND>,
    ordered: bool,
) {
    while !send_packets.push_will_override() && !send_queue.is_empty() {
        let mut available_bytes = MAX_PACKET_DATA_LEN;
        let mut included_msgs = 0;
        for msg in send_queue.iter() {
            if msg.byte_len() <= available_bytes {
                available_bytes -= msg.byte_len();
                included_msgs += 1;
            } else {
                // TODO! Include other messages here that are small enough, if the packet is not
                // ordered.
                break;
            }
        }
        if included_msgs == 0 {
            error!(
                "Msg {:#?} is too large to fit {} bytes, but the max packet size is {}",
                send_queue[0],
                send_queue[0].byte_len(),
                MAX_PACKET_DATA_LEN
            );
        }
        let sequence_id = send_packets.get_next_index();
        let packet = Packet {
            // TODO! Creating a new ack for every iteration is pointless, wasted work
            ack: PacketAck::new(sequence_id, reliable_received, ordered_received),
            reliable: true,
            ordered,
            messages: send_queue.drain(..included_msgs).collect(),
        };
        #[cfg(feature = "debug")]
        if socket.debug_logs {
            debug!(
                "Constructed new reliable {} packet #{sequence_id} with {included_msgs} messages",
                if ordered { "ordered" } else { "unordered" }
            );
        }
        send_packets.push((Instant::now() - Duration::from_secs(1), packet));
    }
}