use std::net::{IpAddr, SocketAddr};
use std::sync::Arc;
use hickory_resolver::net::NetError;
use hickory_resolver::proto::ProtoError;
use hickory_resolver::proto::rr::{Name, RData};
use log::debug;
use crate::MinecraftPinger;
use crate::common::ip_filter::IpFilter;
use crate::error::PingError;
fn is_ldh(byte: u8) -> bool {
byte.is_ascii_alphanumeric() || byte == b'-' || byte == b'_' || byte == b'.'
}
fn parse_host(host: &str) -> Result<Name, PingError> {
if host.contains(['\\', '*']) {
return Err(PingError::DnsParse(NetError::Proto(ProtoError::from(
format!("hostname contains an illegal character: {host}"),
))));
}
if host.is_ascii() && host.bytes().all(is_ldh) {
return Name::from_ascii(host).map_err(|e| PingError::DnsParse(e.into()));
}
Name::from_utf8(host).map_err(|e| PingError::DnsParse(e.into()))
}
pub(crate) async fn resolve_filtered_addrs(
pinger: &MinecraftPinger,
host: &str,
default_port: u16,
protocol: &str,
ip_filter: Option<&Arc<IpFilter>>,
) -> Result<(Option<String>, Vec<SocketAddr>), PingError> {
let (override_hostname, addrs) =
resolve_all_addrs(pinger, host, default_port, protocol).await?;
let Some(filter) = ip_filter.map(Arc::as_ref) else {
return Ok((override_hostname, addrs));
};
let (allowed, rejected): (Vec<SocketAddr>, Vec<SocketAddr>) =
addrs.into_iter().partition(|addr| filter(addr.ip()));
if !rejected.is_empty() {
debug!("IP filter rejected addresses: {:?}", rejected);
}
if allowed.is_empty() {
return Err(PingError::BlockedEndpoint(format!(
"every resolved address was rejected: {:?}",
rejected.iter().map(|a| a.ip()).collect::<Vec<_>>()
)));
}
Ok((override_hostname, allowed))
}
async fn resolve_all_addrs(
pinger: &MinecraftPinger,
host: &str,
default_port: u16,
protocol: &str,
) -> Result<(Option<String>, Vec<SocketAddr>), PingError> {
if let Ok(ip) = host.parse::<IpAddr>() {
return Ok((None, vec![SocketAddr::new(ip, default_port)]));
}
let srv_record = format!("_minecraft._{}.{}", protocol, host);
if let Ok(srv_name) = parse_host(&srv_record)
&& let Ok(lookup) = pinger.dns_resolver.srv_lookup(srv_name).await
{
let mut override_hostname: Option<String> = None;
let mut all_addrs = Vec::new();
for record in lookup.answers() {
if let RData::SRV(srv) = &record.data {
let srv_target = srv.target.to_string().trim_end_matches('.').to_string();
if !srv_target.parse::<IpAddr>().is_ok() {
override_hostname = Some(srv_target.clone());
}
if let Ok(ip_lookup) = pinger.dns_resolver.lookup_ip(srv.target.clone()).await {
let ips: Vec<SocketAddr> = ip_lookup
.iter()
.map(|ip| SocketAddr::new(ip, srv.port))
.collect();
all_addrs.extend(ips);
}
}
}
if !all_addrs.is_empty() {
return Ok((override_hostname, all_addrs));
}
}
let host_name = parse_host(host)?;
let ip_lookup = pinger
.dns_resolver
.lookup_ip(host_name)
.await
.map_err(PingError::DnsParse)?;
let all_addrs: Vec<SocketAddr> = ip_lookup
.iter()
.map(|ip| SocketAddr::new(ip, default_port))
.collect();
if all_addrs.is_empty() {
return Err(PingError::DnsIpNotFound);
}
Ok((None, all_addrs))
}
#[cfg(test)]
mod tests {
use super::*;
use crate::common::ip_filter::is_public_ip;
use std::net::{IpAddr, Ipv4Addr, SocketAddr};
use std::sync::Arc;
#[test]
fn test_parse_host_accepts_underscore_in_label() {
let name = parse_host("my_server.example.lan").unwrap();
assert_eq!(name.to_string(), "my_server.example.lan");
}
#[test]
fn test_parse_host_accepts_srv_prefix() {
let name = parse_host("_minecraft._tcp.example.com").unwrap();
assert_eq!(name.to_string(), "_minecraft._tcp.example.com");
}
#[test]
fn test_parse_host_accepts_idn() {
let name = parse_host("münchen.example.com").unwrap();
assert_eq!(name.to_ascii(), "xn--mnchen-3ya.example.com");
}
#[test]
fn test_parse_host_accepts_trailing_dot() {
let name = parse_host("example.com.").unwrap();
assert!(name.is_fqdn());
}
#[test]
fn test_parse_host_rejects_backslash_escape() {
assert!(parse_host("attacker.com\\.trusted.com").is_err());
assert!(parse_host("a\\_b.com").is_err());
}
#[test]
fn test_parse_host_rejects_wildcard() {
assert!(parse_host("*.example.com").is_err());
assert!(parse_host("*ac.example.com").is_err());
}
#[test]
fn test_parse_host_rejects_control_and_separators() {
assert!(parse_host("a b.com").is_err());
assert!(parse_host("a;b.com").is_err());
assert!(parse_host("a\nb.com").is_err());
assert!(parse_host("a\tb.com").is_err());
assert!(parse_host("a\0b.com").is_err());
assert!(parse_host("user@host.com").is_err());
assert!(parse_host("a\\/b.com").is_err());
}
#[test]
fn test_parse_host_rejects_oversized_label() {
let long = format!("{}.com", "a".repeat(64));
assert!(parse_host(&long).is_err());
}
#[test]
fn test_parse_host_rejects_empty_label() {
assert!(parse_host(".example.com").is_err());
assert!(parse_host("a..b.com").is_err());
}
#[test]
fn test_parse_host_error_is_dns_parse() {
assert!(matches!(parse_host("a b.com"), Err(PingError::DnsParse(_))));
}
#[test]
fn test_ip_filter_partition() {
let addrs = vec![
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8)), 25565),
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(10, 0, 0, 1)), 25565),
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(192, 168, 1, 1)), 25565),
];
let filter = Arc::new(is_public_ip);
let (allowed, rejected): (Vec<_>, Vec<_>) =
addrs.into_iter().partition(|addr| filter(addr.ip()));
assert_eq!(allowed.len(), 1);
assert_eq!(allowed[0].ip(), IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8)));
assert_eq!(rejected.len(), 2);
}
#[test]
fn test_ip_filter_all_rejected() {
let addrs = vec![
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(10, 0, 0, 1)), 25565),
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(192, 168, 1, 1)), 25565),
];
let filter = Arc::new(is_public_ip);
let (allowed, rejected): (Vec<_>, Vec<_>) =
addrs.into_iter().partition(|addr| filter(addr.ip()));
assert!(allowed.is_empty());
assert_eq!(rejected.len(), 2);
}
#[test]
fn test_ip_filter_none_returns_all() {
let addrs = vec![
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8)), 25565),
SocketAddr::new(IpAddr::V4(Ipv4Addr::new(10, 0, 0, 1)), 25565),
];
let filter: Option<&Arc<IpFilter>> = None;
let (allowed, rejected): (Vec<_>, Vec<_>) = addrs
.into_iter()
.partition(|addr| filter.is_none_or(|f| f(addr.ip())));
assert_eq!(allowed.len(), 2);
assert!(rejected.is_empty());
}
}