mindreader 0.5.0

Selective durable graph memory MCP server for AI agents, backed by Neo4j
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
//! MCP stdio adapter: eight tools, host-compatible schemas, lazy Neo4j.
//!
//! Advertises `recall`, `recall_semantic`, `write`, `revise`, `withdraw`,
//! `judge`, `place`, and `unify` as
//! plain tagged object schemas (no `anyOf`/`oneOf`/`allOf`). Initialize and
//! `tools/list` do not wait on Neo4j. Recoverable failures are structured
//! `isError` results. The 120/min burst-20 limiter and 45s timeout apply only
//! to `#[tool]` handlers through the process-local invoke path.

use crate::config::Config;
use crate::domain::DomainError;
use crate::error::{Error, Result as AppResult};
use crate::graph;
use crate::merge::UnifyArgs;
use crate::payload::ToolOutput;
use crate::search::RecallArgs;
use crate::semantic::{SemanticSearchArgs, MAX_SEMANTIC_TEXT_BYTES};
use crate::service::MemoryService;
use crate::tools::{JudgeArgs, PlaceArgs, ReviseArgs, WithdrawArgs, WriteArgs};
use neo4rs::Error as Neo4jError;
use rmcp::{
    handler::server::wrapper::Parameters,
    model::{
        CallToolResult, ErrorData as McpError, Implementation, InitializeRequestParams,
        InitializeResult, ProtocolVersion, ServerCapabilities, ServerInfo,
    },
    service::RequestContext,
    tool, tool_handler, tool_router, RoleServer, ServerHandler,
};
use serde_json::{json, Value};
use std::borrow::Cow;
use std::error::Error as StdError;
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};
use tokio::sync::OnceCell;
use tokio::time::timeout;

/// Per-invoke ceiling applied only to MCP `#[tool]` handlers via [`Mindreader::invoke`].
const INVOKE_TIMEOUT: Duration = Duration::from_secs(45);
/// Sustained token refill for the process-local MCP invoke limiter.
const RATE_LIMIT_PER_MINUTE: f64 = 120.0;
/// Burst capacity of the same limiter (20 tokens).
const RATE_LIMIT_BURST: f64 = 20.0;
/// Scheme-qualified IRI prefix accepted by the runtime (`scheme:rest`).
const IRI_PATTERN: &str = "^[A-Za-z][A-Za-z0-9+.-]*:";
/// Exact fact handles are internal relationship IRIs returned by Mindreader.
const FACT_IRI_PATTERN: &str = "^mindreader:relationship/";
/// At least one non-whitespace character; stricter semantics remain runtime-validated.
const NON_WHITESPACE_PATTERN: &str = r"\S";
/// Protocol versions this process will negotiate; initialize rejects anything else.
///
/// `2026-07-28` is preferred. `2025-11-25` is accepted so hosts that have not
/// adopted the newer initialize version (including Grok) can still complete the
/// handshake. The serve layer echoes the requested version when it is listed here.
const SUPPORTED_PROTOCOL_VERSIONS: &[ProtocolVersion] =
    &[ProtocolVersion::V_2026_07_28, ProtocolVersion::V_2025_11_25];

/// Reject initialize requests that are not in [`SUPPORTED_PROTOCOL_VERSIONS`].
fn require_supported_protocol(requested: ProtocolVersion) -> Result<(), McpError> {
    if SUPPORTED_PROTOCOL_VERSIONS.contains(&requested) {
        Ok(())
    } else {
        Err(McpError::unsupported_protocol_version(
            requested,
            SUPPORTED_PROTOCOL_VERSIONS,
        ))
    }
}

/// Wrap a plain object schema; callers must not introduce `anyOf`/`oneOf`/`allOf`.
fn object_schema(value: serde_json::Value) -> Arc<rmcp::model::JsonObject> {
    Arc::new(rmcp::model::object(value))
}

/// `scope` array: empty is global-only; named ids are an OR union of kebab-case layers.
fn scope_schema() -> serde_json::Value {
    serde_json::json!({
        "type": "array",
        "description": "Visibility union. [] selects only global/unlayered records. A named scope sees global records plus records in any requested layer. IDs use lowercase kebab-case with colon namespaces; colons are naming, not hierarchy. Copy exact values supplied by the task or host because changing an ID selects a different layer.",
        "uniqueItems": true,
        "items": {
            "type": "string",
            "pattern": "^[a-z0-9]+(?:-[a-z0-9]+)*(?::[a-z0-9]+(?:-[a-z0-9]+)*)*$"
        }
    })
}

/// Membership add/remove list using the same layer-id grammar as `scope`.
fn layer_list_schema(description: &str) -> serde_json::Value {
    let mut schema = scope_schema();
    schema["description"] = Value::String(description.to_string());
    schema["minItems"] = json!(1);
    schema
}

/// Closed `{kind, iri}` handle schema; `kind` is an enum so hosts never see a union.
fn target_schema_with_kinds(kinds: &[&str], description: &str) -> serde_json::Value {
    serde_json::json!({
        "type": "object",
        "description": description,
        "additionalProperties": false,
        "properties": {
            "kind": { "type": "string", "enum": kinds },
            "iri": {
                "type": "string",
                "minLength": 1,
                "pattern": IRI_PATTERN,
                "description": "Copy the scheme-qualified IRI from a returned handle; do not use a display name or reconstruct an IRI."
            }
        },
        "required": ["kind", "iri"]
    })
}

/// Pasteable node-or-fact handle advertised to judge and place.
fn target_schema() -> serde_json::Value {
    target_schema_with_kinds(
        &["node", "fact"],
        "A pasteable current node or fact handle returned by Mindreader.",
    )
}

/// Pasteable node handle (`kind=node`) used by unify review and unify inputs.
fn node_target_schema(description: &str) -> serde_json::Value {
    target_schema_with_kinds(&["node"], description)
}

/// Pasteable current fact handle (`kind=fact`) used by revise, withdraw, and results.
fn fact_target_schema() -> serde_json::Value {
    let mut schema = target_schema_with_kinds(
        &["fact"],
        "A pasteable current fact handle returned by recall, write, or revise.",
    );
    schema["properties"]["iri"]["pattern"] = json!(FACT_IRI_PATTERN);
    schema
}

/// ASCII Neo4j label token; interpolated labels are still allowlisted at runtime.
fn label_schema() -> serde_json::Value {
    json!({
        "type": "string",
        "minLength": 1,
        "pattern": "^[A-Za-z][A-Za-z0-9_]*$"
    })
}

/// Non-empty unique predicate names or IRIs (around-mode `p`).
fn predicate_list_schema(description: &str) -> serde_json::Value {
    json!({
        "type": "array",
        "description": description,
        "minItems": 1,
        "uniqueItems": true,
        "items": {
            "type": "string",
            "minLength": 1,
            "pattern": NON_WHITESPACE_PATTERN
        }
    })
}

/// Tagged `kind=node` subject bag; runtime requires `iri` or `name`.
fn entity_input_schema(description: &str) -> serde_json::Value {
    serde_json::json!({
        "type": "object",
        "description": description,
        "additionalProperties": false,
        "properties": {
            "kind": { "type": "string", "enum": ["node"] },
            "iri": {
                "type": "string",
                "minLength": 1,
                "pattern": IRI_PATTERN,
                "description": "Existing scheme-qualified node identity. Omit when minting from name."
            },
            "name": {
                "type": "string",
                "minLength": 1,
                "pattern": NON_WHITESPACE_PATTERN,
                "description": "Node display name and minting input when iri is omitted."
            },
            "labels": { "type": "array", "uniqueItems": true, "items": label_schema() }
        },
        "required": ["kind"]
    })
}

/// Tagged `node` or `literal` bag without schema unions; mixed fields fail at runtime.
fn object_input_schema(description: &str) -> serde_json::Value {
    serde_json::json!({
        "type": "object",
        "description": description,
        "additionalProperties": false,
        "properties": {
            "kind": { "type": "string", "enum": ["node", "literal"] },
            "iri": {
                "type": "string",
                "minLength": 1,
                "pattern": IRI_PATTERN,
                "description": "kind=node only: existing scheme-qualified identity. Omit when minting from name."
            },
            "name": {
                "type": "string",
                "minLength": 1,
                "pattern": NON_WHITESPACE_PATTERN,
                "description": "kind=node only: display name and minting input when iri is omitted."
            },
            "labels": {
                "type": "array",
                "uniqueItems": true,
                "description": "kind=node only: optional node labels.",
                "items": label_schema()
            },
            "value": {
                "type": "string",
                "description": "kind=literal only: required lexical value."
            },
            "datatype": {
                "type": "string",
                "minLength": 1,
                "pattern": NON_WHITESPACE_PATTERN,
                "description": "kind=literal only: optional datatype; omission means xsd:string."
            }
        },
        "required": ["kind"]
    })
}

/// Half-open world-time interval. Presence is explicit even when both bounds are open.
fn effective_interval_schema(nullable: bool) -> serde_json::Value {
    json!({
        "type": if nullable { json!(["object", "null"]) } else { json!("object") },
        "description": "State-only half-open effective interval [from,to). Bounds are complete timezone-qualified RFC 3339 instants such as 2024-01-01T00:00:00Z, not date-only strings; omitted bounds are open. Model point events with event/date facts instead.",
        "additionalProperties": false,
        "properties": {
            "from": { "type": "string", "format": "date-time" },
            "to": { "type": "string", "format": "date-time" }
        }
    })
}

/// Host-compatible `write` input: `facts[]` plus call-level `scope`.
fn schema_memory_write() -> Arc<rmcp::model::JsonObject> {
    // Host wrappers drop the whole server if any inputSchema uses anyOf.
    object_schema(serde_json::json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "facts": {
                "type": "array",
                "minItems": 1,
                "maxItems": 20,
                "description": "Atomic batch of 1–20 explicitly selected triples. Each item must stand alone as an assertion intended for later recall; do not bundle unrelated claims in one literal.",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "s": entity_input_schema("The assertion subject: who or what the fact is about. Use iri for an established identity; otherwise use name and optional labels. Runtime validation requires at least one of iri or name."),
                        "p": {
                            "type": "string",
                            "minLength": 1,
                            "description": "Predicate name or Property IRI describing the relationship from subject s to object o. Reuse established vocabulary for the same concept."
                        },
                        "o": object_input_schema("Object of the assertion. Use kind=node with iri or name for an entity; use kind=literal with value and optional datatype for a scalar."),
                        "spike": {
                            "type": "string",
                            "enum": ["Signal", "Pattern", "Insight", "Knowledge"],
                            "description": "Optional commitment for this exact fact: Signal raw evidence, Pattern recurrence, Insight interpretation, Knowledge a fact worth relying on. Omit rather than invent."
                        },
                        "contradicts": {
                            "type": "boolean",
                            "description": "Set true only when this fact and visible current alternatives are directly incompatible and should remain current."
                        },
                        "effective": effective_interval_schema(true)
                    },
                    "required": ["s", "p", "o"]
                }
            },
            "scope": scope_schema()
        },
        "required": ["facts", "scope"]
    }))
}

/// Shared `isError` fields merged into every advertised output schema.
fn error_envelope_properties() -> serde_json::Map<String, Value> {
    let Value::Object(map) = json!({
        "ok": { "type": "boolean" },
        "reason": { "type": "string" },
        "message": { "type": "string" },
        "retryable": { "type": "boolean" },
        "retryAfterMs": { "type": "integer", "minimum": 1 }
    }) else {
        unreachable!("literal object")
    };
    map
}

/// Successful tool fields plus the recoverable-error envelope; `ok` is required.
fn schema_out(mut properties: serde_json::Map<String, Value>) -> Arc<rmcp::model::JsonObject> {
    for (key, value) in error_envelope_properties() {
        properties.entry(key).or_insert(value);
    }
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": properties,
        "required": ["ok"]
    }))
}

/// Object-map helper so output schemas stay literal JSON without extra cloning.
fn props(value: Value) -> serde_json::Map<String, Value> {
    match value {
        Value::Object(map) => map,
        _ => serde_json::Map::new(),
    }
}

/// Agent-facing node or literal envelope, including mutability and pasteable target.
fn node_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "kind": { "type": "string", "enum": ["node", "literal"] },
            "iri": { "type": "string" },
            "name": { "type": ["string", "null"] },
            "labels": { "type": "array", "items": { "type": "string" } },
            "value": { "type": "string" },
            "datatype": { "type": "string" },
            "scope": scope_schema(),
            "weight": { "type": "integer" },
            "stub": { "type": "boolean" },
            "tool": { "type": "string" },
            "rateable": { "type": "boolean" },
            "mutable": { "type": "boolean" },
            "target": target_schema_with_kinds(&["node"], "Pasteable node handle.")
        },
        "required": ["kind", "iri"]
    })
}

/// Serialized fact relationship used in paths, conflicts, and `about` rows.
fn relationship_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "kind": { "type": "string", "enum": ["fact"] },
            "type": { "type": "string" },
            "iri": { "type": "string" },
            "from": { "type": "string" },
            "to": { "type": "string" },
            "propertyIri": { "type": "string" },
            "scope": scope_schema(),
            "weight": { "type": "integer" },
            "episodeId": { "type": "string" },
            "reason": { "type": "string" },
            "spike": { "type": ["string", "null"], "enum": ["Signal", "Pattern", "Insight", "Knowledge", null] },
            "effective": effective_interval_schema(true)
        },
        "required": ["kind", "type", "iri", "from", "to", "propertyIri", "scope", "weight"]
    })
}

/// Compact path witnesses returned by recall surfaces; concise omits edge IRIs.
fn compact_witness_path_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "nodes": { "type": "array", "items": { "type": "string" } },
            "edges": {
                "type": "array",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "iri": { "type": "string" },
                        "from": { "type": "string" },
                        "p": { "type": "string" },
                        "to": { "type": "string" }
                    },
                    "required": ["from", "p", "to"]
                }
            }
        },
        "required": ["nodes", "edges"]
    })
}

/// One set-valued alternative shown in `review.alternatives` (not a contradiction until asked).
fn conflict_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "relationship": relationship_schema(),
            "o": node_schema(),
            "p": { "type": "string" }
        },
        "required": ["relationship", "o", "p"]
    })
}

/// Agent-facing fact envelope: pasteable target, endpoints, memberships, and judgment flags.
fn fact_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "target": fact_target_schema(),
            "s": node_schema(),
            "p": { "type": "string" },
            "o": node_schema(),
            "scope": scope_schema(),
            "spike": { "type": ["string", "null"], "enum": ["Signal", "Pattern", "Insight", "Knowledge", null] },
            "score": { "type": "number" },
            "effectiveWeight": { "type": "integer" },
            "weight": { "type": "integer" },
            "rank": { "type": "integer", "minimum": 1 },
            "conflicts": { "type": "array", "items": conflict_schema() },
            "noop": { "type": "boolean" },
            "current": { "type": "boolean" },
            "rateable": { "type": "boolean" },
            "mutable": { "type": "boolean" },
            "validTo": { "type": "string" },
            "effective": effective_interval_schema(true),
            "transactionCurrent": { "type": "boolean" },
            "transaction": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "from": { "type": "string", "format": "date-time" },
                    "to": { "type": ["string", "null"], "format": "date-time" }
                },
                "required": ["from", "to"]
            }
        },
        "required": ["target", "s", "p", "o"]
    })
}

/// Recall fact items; `target` and operation flags are optional so concise payloads stay valid.
fn recall_fact_schema() -> Value {
    let mut schema = fact_schema();
    schema["required"] = json!(["s", "p", "o"]);
    schema
}

/// Fact envelope or null, used when a no-op revise returns no replacement body.
fn nullable_fact_schema() -> Value {
    let mut schema = fact_schema();
    schema["type"] = json!(["object", "null"]);
    schema
}

/// Neighbor Spike context attached to ranked recall (`about[]`).
fn about_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "node": node_schema(),
            "about": { "type": "string" },
            "rank": { "type": "string", "enum": ["Signal", "Pattern", "Insight", "Knowledge"] },
            "relationship": relationship_schema(),
            "effectiveWeight": { "type": "integer" }
        },
        "required": ["node", "about", "rank", "relationship", "effectiveWeight"]
    })
}

/// Provenance Episode for a state-changing mutation; null on no-op.
fn episode_schema() -> Value {
    json!({
        "type": ["object", "null"],
        "additionalProperties": false,
        "properties": {
            "iri": { "type": "string" },
            "at": { "type": "string" },
            "tool": {
                "type": "string",
                "enum": [
                    "judge", "place", "revise", "unify", "withdraw", "write"
                ]
            }
        },
        "required": ["iri", "at", "tool"]
    })
}

/// `{kind: node, iri}` handle used in unify inputs and the paste bag.
fn node_handle_schema(description: &str) -> Value {
    target_schema_with_kinds(&["node"], description)
}

/// Neutral paste bag; empty arrays and nulls are unused roles, not commands.
fn handles_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "description": "Pasteable identities from this result. Empty arrays and nulls are unused roles, not commands.",
        "properties": {
            "facts": { "type": "array", "items": fact_target_schema() },
            "nodes": { "type": "array", "items": node_handle_schema("Pasteable node handle.") },
            "current": {
                "type": ["object", "null"],
                "additionalProperties": false,
                "properties": {
                    "kind": { "type": "string", "enum": ["node", "fact"] },
                    "iri": { "type": "string", "minLength": 1 }
                }
            },
            "retired": {
                "type": ["object", "null"],
                "additionalProperties": false,
                "properties": {
                    "kind": { "type": "string", "enum": ["node", "fact"] },
                    "iri": { "type": "string", "minLength": 1 }
                }
            },
            "unify": {
                "type": "array",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "source": node_handle_schema("Absorbed node handle."),
                        "target": node_handle_schema("Surviving node handle.")
                    },
                    "required": ["source", "target"]
                }
            }
        },
        "required": ["facts", "nodes", "current", "retired", "unify"]
    })
}

/// Recall verbosity: answer-only `concise` or operation-ready `detailed`.
fn detail_schema() -> Value {
    json!({
        "type": "string",
        "enum": ["concise", "detailed"],
        "default": "detailed",
        "description": "concise returns answer-bearing graph content without handles, ranking, memberships, or operation eligibility. detailed is the full operation and audit envelope."
    })
}

/// Advisory unify suggestions and set-valued alternatives attached to write/revise.
fn review_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "unify": {
                "type": "array",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "source": node_target_schema("Pasteable absorbed node handle."),
                        "sourceName": { "type": "string" },
                        "target": node_target_schema("Pasteable surviving node handle."),
                        "targetName": { "type": "string" },
                        "similarity": { "type": "number", "minimum": 0, "maximum": 1 }
                    },
                    "required": ["source", "sourceName", "target", "targetName", "similarity"]
                }
            },
            "alternatives": {
                "type": "array",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "target": fact_target_schema(),
                        "conflicts": { "type": "array", "items": conflict_schema() }
                    },
                    "required": ["target", "conflicts"]
                }
            }
        },
        "required": ["unify", "alternatives"]
    })
}

/// Batch counts for judge and place (`requested` / `changed` / `noop`).
fn summary_schema() -> Value {
    json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "requested": { "type": "integer", "minimum": 1, "maximum": 20 },
            "changed": { "type": "integer", "minimum": 0, "maximum": 20 },
            "noop": { "type": "integer", "minimum": 0, "maximum": 20 }
        },
        "required": ["requested", "changed", "noop"]
    })
}

/// Process-local token bucket for MCP `#[tool]` handlers only.
struct TokenBucket {
    inner: Mutex<TokenBucketState>,
}

/// Token balance and last refill instant for the process-local limiter.
struct TokenBucketState {
    tokens: f64,
    last: Instant,
}

impl TokenBucket {
    /// Start full (burst 20) so the first 20 invokes do not wait on refill.
    fn new() -> Self {
        Self {
            inner: Mutex::new(TokenBucketState {
                tokens: RATE_LIMIT_BURST,
                last: Instant::now(),
            }),
        }
    }

    /// Take one token from the process-local 120/min burst-20 bucket.
    fn try_acquire(&self) -> std::result::Result<(), u64> {
        let mut state = self
            .inner
            .lock()
            .unwrap_or_else(|poisoned| poisoned.into_inner());
        let now = Instant::now();
        let elapsed = now.saturating_duration_since(state.last).as_secs_f64();
        state.tokens =
            (state.tokens + elapsed * (RATE_LIMIT_PER_MINUTE / 60.0)).min(RATE_LIMIT_BURST);
        state.last = now;
        if state.tokens >= 1.0 {
            state.tokens -= 1.0;
            Ok(())
        } else {
            let tokens_per_second = RATE_LIMIT_PER_MINUTE / 60.0;
            let retry_after_ms = ((1.0 - state.tokens) / tokens_per_second * 1_000.0)
                .ceil()
                .max(1.0) as u64;
            Err(retry_after_ms)
        }
    }
}

/// Stdio MCP server: eight-tool router, lazy Neo4j service, and invoke limiter.
#[derive(Clone)]
pub struct Mindreader {
    /// Filled on first invoke or warmup; initialize/`tools/list` leave it empty.
    service: Arc<OnceCell<MemoryService>>,
    /// Native config used on first Neo4j connect; unused by initialize/`tools/list`.
    cfg: Config,
    /// Process-local 120/min burst-20 bucket; never wraps in-process `tools::*`.
    limiter: Arc<TokenBucket>,
}

impl Mindreader {
    /// Construct the eight-tool router without connecting to Neo4j.
    fn from_config(cfg: Config) -> Self {
        Self {
            service: Arc::new(OnceCell::new()),
            cfg,
            limiter: Arc::new(TokenBucket::new()),
        }
    }

    /// Build the server without talking to Neo4j so MCP initialize/list_tools
    /// can run immediately.
    pub fn from_env() -> AppResult<Self> {
        Ok(Self::from_config(Config::from_env()?))
    }

    /// Eager connect (tests / smoke). Prefer `from_env` + serve for MCP.
    pub async fn connect() -> AppResult<Self> {
        let this = Self::from_env()?;
        this.ensure_connected().await?;
        Ok(this)
    }

    /// Connect, bootstrap the model, and initialize [`MemoryService`] once.
    pub async fn ensure_connected(&self) -> AppResult<()> {
        self.service
            .get_or_try_init(|| async {
                let g = graph::connect(&self.cfg).await?;
                let embedding_space = self.cfg.embedding.as_ref().map(|value| value.space());
                graph::bootstrap(
                    &g,
                    embedding_space.as_ref(),
                    crate::graph::SpaceReplace::Allow,
                )
                .await?;
                MemoryService::new(g, &self.cfg)
            })
            .await?;
        Ok(())
    }

    /// Sorted names of the eight advertised MCP tools.
    pub fn registered_tool_names() -> Vec<String> {
        let router = Self::tool_router();
        let mut names: Vec<String> = router.map.keys().map(|k| k.to_string()).collect();
        names.sort();
        names
    }

    /// Rate-limit and time-box one MCP `#[tool]` call after lazy Neo4j connect.
    async fn invoke<F, Fut>(&self, op: F) -> Result<CallToolResult, McpError>
    where
        F: FnOnce(MemoryService) -> Fut,
        Fut: std::future::Future<Output = AppResult<ToolOutput>>,
    {
        if let Err(retry_after_ms) = self.limiter.try_acquire() {
            return Ok(structured_error_with_retry_after(
                "rate_limited",
                "MCP invoke rate limit exceeded (120/min, burst 20)",
                retry_after_ms,
            ));
        }
        if let Err(error) = self.ensure_connected().await {
            return Ok(map_connect_error(error));
        }
        let Some(service) = self.service.get() else {
            return Ok(structured_error(
                "connect_failed",
                "neo4j not connected after bootstrap",
            ));
        };
        let service = service.clone();
        match timeout(INVOKE_TIMEOUT, op(service)).await {
            Ok(result) => Ok(map_tool_result(result)),
            Err(_) => Ok(structured_error(
                "timeout",
                "tool invoke exceeded 45 seconds",
            )),
        }
    }
}

/// Recoverable tool failure as `isError` with `{ok:false,reason,message,retryable}`.
fn structured_error(reason: &str, message: impl std::fmt::Display) -> CallToolResult {
    CallToolResult::structured_error(json!({
        "ok": false,
        "reason": reason,
        "message": message.to_string(),
        "retryable": error_retryable(reason),
    }))
}

/// Rate-limit `isError` that includes `retryAfterMs` from the token bucket.
fn structured_error_with_retry_after(
    reason: &str,
    message: impl std::fmt::Display,
    retry_after_ms: u64,
) -> CallToolResult {
    CallToolResult::structured_error(json!({
        "ok": false,
        "reason": reason,
        "message": message.to_string(),
        "retryable": error_retryable(reason),
        "retryAfterMs": retry_after_ms,
    }))
}

/// Only failures that are known safe to repeat are advertised as retryable.
fn error_retryable(reason: &str) -> bool {
    matches!(
        reason,
        "connect_failed" | "rate_limited" | "concurrent_mutation"
    )
}

/// Lazy Neo4j connect/bootstrap failure advertised as retryable `connect_failed`.
fn map_connect_error(error: Error) -> CallToolResult {
    structured_error("connect_failed", error)
}

/// Stamp `ok:true` on success objects, or map application errors to structured `isError`.
fn map_tool_result(result: AppResult<ToolOutput>) -> CallToolResult {
    match result {
        Ok(value) => {
            let mut value = value.into_object();
            value.insert("ok".into(), Value::Bool(true));
            CallToolResult::structured(Value::Object(value))
        }
        Err(error) => structured_error(classify_tool_error(&error), error),
    }
}

/// Map application errors to MCP `reason` codes; domain validation stays `invalid_input`.
fn classify_tool_error(error: &Error) -> &'static str {
    match error {
        Error::Domain(DomainError::InvalidInput(_)) => "invalid_input",
        Error::Domain(DomainError::Precondition(_)) => "precondition_failed",
        Error::ConcurrentMutation(_) => "concurrent_mutation",
        // Setup and missing-key failures; HTTP status variants map separately.
        Error::Embedding(_) => "missing_embedding",
        Error::EmbeddingSpace(_) => "embedding_space",
        Error::EmbeddingHttp { status: 429, .. } => "rate_limited",
        Error::EmbeddingHttp { .. } => "embedding_http",
        Error::Neo4j(_)
        | Error::Neo4jDecode(_)
        | Error::Graph(_)
        | Error::Io(_)
        | Error::Json(_) => "operation",
        Error::Context { source, .. } => classify_boxed_source(source.as_ref()),
        _ => "operation",
    }
}

/// Walk a boxed source chain so `Error::Context` still yields a stable MCP `reason`.
fn classify_boxed_source(source: &(dyn StdError + Send + Sync + 'static)) -> &'static str {
    if let Some(error) = source.downcast_ref::<Error>() {
        return classify_tool_error(error);
    }
    if let Some(domain) = source.downcast_ref::<DomainError>() {
        return match domain {
            DomainError::InvalidInput(_) => "invalid_input",
            DomainError::Precondition(_) => "precondition_failed",
        };
    }
    if source.downcast_ref::<Neo4jError>().is_some() {
        return "operation";
    }
    if let Some(cause) = source.source() {
        if let Some(error) = cause.downcast_ref::<Error>() {
            return classify_tool_error(error);
        }
        if let Some(domain) = cause.downcast_ref::<DomainError>() {
            return match domain {
                DomainError::InvalidInput(_) => "invalid_input",
                DomainError::Precondition(_) => "precondition_failed",
            };
        }
        if cause.downcast_ref::<Neo4jError>().is_some() {
            return "operation";
        }
    }
    "operation"
}

/// Host-compatible `recall` input: `scope` plus exactly one runtime selector.
fn schema_memory_recall() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "text": {
                "type": "string",
                "minLength": 1,
                "pattern": NON_WHITESPACE_PATTERN,
                "description": "Lexical fact query. Use concrete entity and action terms; do not embed parameter syntax such as effectiveAt in the text. Use only when text is the selected recall mode."
            },
            "iris": {
                "type": "array",
                "description": "One to 20 node IRIs. Results preserve input order and report misses.",
                "minItems": 1,
                "maxItems": 20,
                "uniqueItems": true,
                "items": {
                    "type": "string",
                    "minLength": 1,
                    "pattern": IRI_PATTERN
                }
            },
            "labels": {
                "type": "array",
                "description": "Recall selector for facts whose endpoints have these labels. Class and Property instead select the global schema catalog. In recall_semantic, labels is only a result filter.",
                "minItems": 1,
                "uniqueItems": true,
                "items": label_schema()
            },
            "around": {
                "type": "string",
                "minLength": 1,
                "pattern": IRI_PATTERN,
                "description": "Starting node IRI for bounded graph recall."
            },
            "hops": {
                "type": "integer",
                "description": "IRI mode only. 0 still returns incident facts on lookups[i].facts. 1 also fills top-level facts[] when detail is detailed. Concise IRI recall keeps its answer in lookups without duplicate top-level facts.",
                "enum": [0, 1]
            },
            "p": predicate_list_schema("Around mode only: exact predicate names or IRIs to filter before limiting. Omit this filter until the stored predicate vocabulary is known."),
            "depth": {
                "type": "integer",
                "description": "Around mode only: traversal depth.",
                "minimum": 1,
                "maximum": 3
            },
            "direction": {
                "type": "string",
                "description": "Around mode only: require every traversed edge to follow this direction from the start node.",
                "enum": ["both", "outgoing", "incoming"]
            },
            "history": {
                "type": "string",
                "minLength": 1,
                "pattern": IRI_PATTERN,
                "description": "One node or exact fact IRI. Returns its current and historical facts plus revision events."
            },
            "effectiveAt": {
                "type": "string",
                "format": "date-time",
                "description": "Optional state-as-of filter for text, non-catalog labels, iris, or around. Only explicitly time-qualified facts effective at this instant match; unknown-time facts are excluded. Do not use it merely to search for dated point events."
            },
            "detail": detail_schema(),
            "limit": {
                "type": "integer",
                "description": "Result budget for the selected mode: facts normally, catalog nodes in catalog mode, and facts per requested IRI in iris mode.",
                "minimum": 1,
                "maximum": 100,
                "default": 20
            }
        },
        "required": ["scope"]
    }))
}

/// Host-compatible `recall_semantic` input; `text` is required and embedded remotely.
fn schema_memory_recall_semantic() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "text": {
                "type": "string",
                "minLength": 1,
                "maxLength": MAX_SEMANTIC_TEXT_BYTES,
                "pattern": NON_WHITESPACE_PATTERN,
                "description": format!("Conceptual query sent to the configured embedding provider; maximum {MAX_SEMANTIC_TEXT_BYTES} UTF-8 bytes.")
            },
            "labels": {
                "type": "array",
                "description": "Optional labels used to filter semantic results.",
                "minItems": 1,
                "uniqueItems": true,
                "items": label_schema()
            },
            "effectiveAt": {
                "type": "string",
                "format": "date-time",
                "description": "Optional state-as-of filter. Direct, activation, and structural facts must be explicitly effective at this instant; unknown-time facts are excluded. Do not use it merely to search for dated point events."
            },
            "detail": detail_schema(),
            "limit": {
                "type": "integer",
                "description": "Maximum fused semantic results.",
                "minimum": 1,
                "maximum": 100,
                "default": 20
            }
        },
        "required": ["scope", "text"]
    }))
}

/// Host-compatible `revise` input: fact handle plus replacement object.
fn schema_memory_revise() -> Arc<rmcp::model::JsonObject> {
    let mut effective = effective_interval_schema(true);
    effective["description"] = Value::String(
        "Replacement fact's state interval. Omit to inherit the selected fact's interval; send null to clear temporal qualification; send an object to replace it."
            .into(),
    );
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "target": fact_target_schema(),
            "replacement": object_input_schema("Replacement object only; the selected fact's subject and predicate remain unchanged. Use kind=node with iri or name, or kind=literal with value and optional datatype."),
            "spike": {
                "type": "string",
                "enum": ["Signal", "Pattern", "Insight", "Knowledge"],
                "description": "Optional commitment for the replacement fact. Omit to preserve the selected fact's Spike."
            },
            "contradicts": {
                "type": "boolean",
                "description": "Set true only when the replacement and visible current alternatives are directly incompatible and should remain current."
            },
            "reason": { "type": "string", "description": "Optional audit reason for the correction." },
            "effective": effective
        },
        "required": ["scope", "target", "replacement"]
    }))
}

/// Host-compatible `withdraw` input; runtime requires exactly one of `target` or `subject`.
fn schema_memory_withdraw() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "target": fact_target_schema(),
            "subject": entity_input_schema("Subject node whose visible outgoing facts will be withdrawn. Use iri for an established identity; otherwise use name and optional labels. Runtime validation requires at least one of iri or name."),
            "p": {
                "type": "string",
                "minLength": 1,
                "description": "Exact predicate name or Property IRI limiting a subject withdrawal. Invalid with target; omitting it withdraws the subject's entire mutable outgoing slice."
            },
            "reason": { "type": "string", "description": "Optional audit reason." }
        },
        "required": ["scope"]
    }))
}

/// Host-compatible `judge` input: 1–20 unique `strengthen`/`weaken` ratings.
fn schema_memory_judge() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "ratings": {
                "type": "array",
                "minItems": 1,
                "maxItems": 20,
                "uniqueItems": true,
                "description": "Atomic, input-ordered ratings. Duplicate targets are invalid; any failure rolls back every rating.",
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "target": target_schema(),
                        "mode": {
                            "type": "string",
                            "enum": ["strengthen", "weaken"],
                            "description": "Retrieval-utility feedback: strengthen adds exactly +1 shared weight; weaken adds exactly -1. Correct false facts with revise or withdraw instead."
                        }
                    },
                    "required": ["target", "mode"]
                }
            }
        },
        "required": ["scope", "ratings"]
    }))
}

/// Host-compatible `place` input: visibility `scope` plus membership `edits`.
fn schema_memory_place() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "scope": scope_schema(),
            "edits": {
                "type": "array",
                "description": "Atomic membership edits. Duplicate targets, add/remove overlap, or invalid final endpoint closure rejects the batch. When moving a fact to a layer its endpoint lacks, include that endpoint's returned node handle in the same batch; persisted literals also use their returned kind=node handle here.",
                "minItems": 1,
                "maxItems": 20,
                "uniqueItems": true,
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "properties": {
                        "target": target_schema(),
                        "add": layer_list_schema("Named memberships to add. Must not overlap remove."),
                        "remove": layer_list_schema("Named memberships to remove. Must not overlap add. Removing the final named membership makes the target global.")
                    },
                    "required": ["target"]
                }
            }
        },
        "required": ["scope", "edits"]
    }))
}

/// Host-compatible `unify` input; no `scope` because unify is database-wide.
fn schema_memory_unify() -> Arc<rmcp::model::JsonObject> {
    object_schema(json!({
        "type": "object",
        "additionalProperties": false,
        "properties": {
            "source": node_handle_schema("Same-kind node that will be permanently absorbed and removed."),
            "target": node_handle_schema("Same-kind surviving node whose IRI and name remain. Review this direction before calling.")
        },
        "required": ["source", "target"]
    }))
}

/// Closed-world recall output: facts, lookups, catalog nodes, and the paste bag.
fn schema_out_memory_recall() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "mode": { "type": "string", "enum": ["text", "iris", "labels", "catalog", "around", "history"] },
        "detail": { "type": "string", "enum": ["concise", "detailed"] },
        "handles": handles_schema(),
        "scope": scope_schema(),
        "facts": { "type": "array", "items": recall_fact_schema() },
        "nodes": { "type": "array", "items": node_schema() },
        "paths": {
            "type": "array",
            "description": "For around recall, paths[i] is the deterministic best compact witness path for facts[i].",
            "items": compact_witness_path_schema()
        },
        "revisions": {
            "type": "array",
            "description": "History-only exact correction events, newest first. SUPERSEDES metadata is audit-only and never pasteable.",
            "items": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "replacement": fact_target_schema(),
                    "previous": fact_target_schema(),
                    "scope": scope_schema(),
                    "episode": episode_schema(),
                    "supersedes": {
                        "type": "object",
                        "additionalProperties": false,
                        "properties": {
                            "iri": { "type": "string" },
                            "from": { "type": "string" },
                            "to": { "type": "string" },
                            "reason": { "type": ["string", "null"] }
                        },
                        "required": ["iri", "from", "to", "reason"]
                    }
                },
                "required": ["replacement", "previous", "scope", "episode", "supersedes"]
            }
        },
        "revisionsTruncated": { "type": "boolean" },
        "about": { "type": "array", "items": about_schema() },
        "lookups": {
            "type": "array",
            "items": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "iri": { "type": "string" },
                    "found": { "type": "boolean" },
                    "node": node_schema(),
                    "facts": { "type": "array", "items": recall_fact_schema() },
                    "truncated": { "type": "boolean" }
                },
                "required": ["iri", "found", "truncated"]
            }
        },
        "from": { "type": "string" },
        "truncated": { "type": "boolean" }
    })))
}

/// Semantic recall output; `mode` is always `semantic` and activations may have been updated.
fn schema_out_memory_recall_semantic() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "mode": { "type": "string", "enum": ["semantic"] },
        "detail": { "type": "string", "enum": ["concise", "detailed"] },
        "handles": handles_schema(),
        "scope": scope_schema(),
        "facts": { "type": "array", "items": recall_fact_schema() },
        "nodes": { "type": "array", "items": node_schema() },
        "paths": {
            "type": "array",
            "items": compact_witness_path_schema()
        },
        "about": { "type": "array", "items": about_schema() },
        "lookups": {
            "type": "array",
            "items": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "iri": { "type": "string" },
                    "found": { "type": "boolean" },
                    "node": node_schema(),
                    "facts": { "type": "array", "items": recall_fact_schema() }
                },
                "required": ["iri", "found"]
            }
        },
        "from": { "type": "string" },
        "truncated": { "type": "boolean" }
    })))
}

/// Write output: one Episode when changed, written facts, and advisory review.
fn schema_out_memory_write() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "scope": scope_schema(),
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "facts": { "type": "array", "items": fact_schema() },
        "review": review_schema(),
        "handles": handles_schema()
    })))
}

/// Revise output: current and previous fact handles plus optional replacement body.
fn schema_out_memory_revise() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "scope": scope_schema(),
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "target": fact_target_schema(),
        "previousTarget": fact_target_schema(),
        "fact": nullable_fact_schema(),
        "review": review_schema(),
        "handles": handles_schema()
    })))
}

/// Withdraw output: soft-retired fact handles; Episode is null when nothing changed.
fn schema_out_memory_withdraw() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "scope": scope_schema(),
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "withdrawn": { "type": "integer" },
        "withdrawnTargets": { "type": "array", "items": fact_target_schema() },
        "reason": { "type": ["string", "null"] },
        "handles": handles_schema()
    })))
}

/// Judge output: per-rating before/after weights and a single Episode.
fn schema_out_memory_judge() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "scope": scope_schema(),
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "summary": summary_schema(),
        "items": {
            "type": "array",
            "items": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "index": { "type": "integer", "minimum": 0, "maximum": 19 },
                    "target": target_schema(),
                    "mode": { "type": "string", "enum": ["strengthen", "weaken"] },
                    "delta": { "type": "integer", "enum": [-1, 1] },
                    "before": { "type": "integer" },
                    "after": { "type": "integer" },
                    "status": { "type": "string", "enum": ["changed", "noop"] }
                },
                "required": ["index", "target", "mode", "delta", "before", "after", "status"]
            }
        },
        "handles": handles_schema()
    })))
}

/// Place output: per-edit before/after memberships and a single Episode if any changed.
fn schema_out_memory_place() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "scope": scope_schema(),
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "summary": summary_schema(),
        "items": {
            "type": "array",
            "items": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "index": { "type": "integer", "minimum": 0, "maximum": 19 },
                    "target": target_schema(),
                    "before": scope_schema(),
                    "memberships": scope_schema(),
                    "added": scope_schema(),
                    "removed": scope_schema(),
                    "status": { "type": "string", "enum": ["changed", "noop"] }
                },
                "required": ["index", "target", "before", "memberships", "added", "removed", "status"]
            }
        },
        "handles": handles_schema()
    })))
}

/// Unify output: surviving node after a permanent same-kind merge.
fn schema_out_memory_unify() -> Arc<rmcp::model::JsonObject> {
    schema_out(props(json!({
        "noop": { "type": "boolean" },
        "episode": episode_schema(),
        "node": node_schema(),
        "handles": handles_schema()
    })))
}

#[tool_router]
impl Mindreader {
    #[tool(
        name = "recall",
        title = "Recall visible memory",
        description = "Use proactively when deliberately stored graph knowledge could affect the work, including when resuming or making a consequential decision; the user need not request recall. This searches explicit assertions, not source conversations, without external calls or writes. Choose exactly one selector: text, iris, labels, around, or history. Use effectiveAt only for state-as-of retrieval; it excludes unknown-time facts. Use concise for answer content and detailed when handles or audit metadata may be needed.",
        input_schema = schema_memory_recall(),
        output_schema = schema_out_memory_recall(),
        annotations(title = "Recall visible memory", read_only_hint = true, destructive_hint = false, idempotent_hint = true, open_world_hint = false)
    )]
    /// Closed-world read: one selector, no embedding, no graph writes; limited and timed via `invoke`.
    async fn recall(
        &self,
        Parameters(args): Parameters<RecallArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.recall(args).await })
            .await
    }

    #[tool(
        name = "recall_semantic",
        title = "Recall by meaning",
        description = "Use only after warranted lexical recall cannot find a conceptually related assertion and sending the query text to the configured embedding provider is acceptable. This combines lexical evidence with expiring semantic activations and weaker graph context. It may maintain activations, so it is externally disclosing and non-idempotent. Use effectiveAt only for explicitly time-qualified state-as-of retrieval. An empty result creates no activation.",
        input_schema = schema_memory_recall_semantic(),
        output_schema = schema_out_memory_recall_semantic(),
        annotations(title = "Recall by meaning", read_only_hint = false, destructive_hint = false, idempotent_hint = false, open_world_hint = true)
    )]
    /// Embeds `text` and may persist expiring activations; not read-only; limited and timed via `invoke`.
    async fn recall_semantic(
        &self,
        Parameters(args): Parameters<SemanticSearchArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.recall_semantic(args).await })
            .await
    }

    #[tool(
        name = "write",
        title = "Write facts",
        description = "Use proactively when supported knowledge is deliberately selected for reuse; the user need not ask. This stores standalone triples, not conversation or inferred companion facts. Facts are set-valued: a different object or effective interval remains alongside current values, while exact reassertion merges memberships or is a no-op. Use effective intervals for states and explicit event/date facts for occurrences. Do not store secrets, transient chatter, raw dumps, or unsupported inference.",
        input_schema = schema_memory_write(),
        output_schema = schema_out_memory_write(),
        annotations(title = "Write facts", read_only_hint = false, destructive_hint = false, idempotent_hint = true, open_world_hint = false)
    )]
    async fn write(
        &self,
        Parameters(args): Parameters<WriteArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.write(args).await })
            .await
    }

    #[tool(
        name = "revise",
        title = "Revise a fact",
        description = "Use when one exact current fact or effective interval is wrong and its replacement is known. Paste that fact's target. Only memberships selected by scope move to the replacement; unrelated current values and memberships remain. Omitted effective inherits the old interval, null clears it, and an object replaces it. The correction and SUPERSEDES history commit atomically.",
        input_schema = schema_memory_revise(),
        output_schema = schema_out_memory_revise(),
        annotations(title = "Revise a fact", read_only_hint = false, destructive_hint = true, idempotent_hint = false, open_world_hint = false)
    )]
    async fn revise(
        &self,
        Parameters(args): Parameters<ReviseArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.revise(args).await })
            .await
    }

    #[tool(
        name = "withdraw",
        title = "Withdraw facts",
        description = "Use when stored knowledge should no longer be current and no replacement is known. Prefer one recalled fact target. Use subject with optional p only when the entire visible mutable slice should be withdrawn. Supply exactly one of target or subject. Withdrawal is soft and preserves history.",
        input_schema = schema_memory_withdraw(),
        output_schema = schema_out_memory_withdraw(),
        annotations(title = "Withdraw facts", read_only_hint = false, destructive_hint = true, idempotent_hint = false, open_world_hint = false)
    )]
    async fn withdraw(
        &self,
        Parameters(args): Parameters<WithdrawArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.withdraw(args).await })
            .await
    }

    #[tool(
        name = "judge",
        title = "Judge retrieved targets",
        description = "Use only after a recalled node or fact materially helped, distracted, or misled actual work. Judge retrieval utility, not truth; revise or withdraw a false claim instead. Each strengthen or weaken rating changes shared weight by exactly +1 or -1. Do not rate every result. The batch is atomic, and recall never changes weight automatically.",
        input_schema = schema_memory_judge(),
        output_schema = schema_out_memory_judge(),
        annotations(title = "Judge retrieved targets", read_only_hint = false, destructive_hint = true, idempotent_hint = false, open_world_hint = false)
    )]
    async fn judge(
        &self,
        Parameters(args): Parameters<JudgeArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.judge(args).await })
            .await
    }

    #[tool(
        name = "place",
        title = "Place layer memberships",
        description = "Use when existing nodes or facts belong in different visibility layers without changing their meaning. scope controls which targets are currently visible; each edit changes memberships with add and/or remove. This is visibility, not authorization. The batch is atomic and must leave every fact visible through both endpoints.",
        input_schema = schema_memory_place(),
        output_schema = schema_out_memory_place(),
        annotations(title = "Place layer memberships", read_only_hint = false, destructive_hint = true, idempotent_hint = true, open_world_hint = false)
    )]
    async fn place(
        &self,
        Parameters(args): Parameters<PlaceArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.place(args).await })
            .await
    }

    #[tool(
        name = "unify",
        title = "Permanently unify nodes",
        description = "Use only when evidence confirms that two same-kind nodes are the same identity and which one must survive. Never unify merely because names are similar. This database-wide, permanent operation absorbs source into target and reconciles all memberships and history. It has no scope and no undo.",
        input_schema = schema_memory_unify(),
        output_schema = schema_out_memory_unify(),
        annotations(title = "Permanently unify nodes", read_only_hint = false, destructive_hint = true, idempotent_hint = false, open_world_hint = false)
    )]
    async fn unify(
        &self,
        Parameters(args): Parameters<UnifyArgs>,
    ) -> Result<CallToolResult, McpError> {
        self.invoke(|service| async move { service.unify(args).await })
            .await
    }
}

#[tool_handler]
impl ServerHandler for Mindreader {
    /// Advertise tools-only capabilities, preferred protocol 2026-07-28, and the eight-tool instructions.
    fn get_info(&self) -> ServerInfo {
        ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
            .with_protocol_version(ProtocolVersion::V_2026_07_28)
            .with_server_info(Implementation::new(
                "mindreader",
                env!("CARGO_PKG_VERSION"),
            ))
            .with_instructions(
                "The agent owns selective prospective memory: proactively recall stored assertions when relevant; proactively write supported reusable triples. Unstored conversation is unavailable. scope is visibility: [] is global-only; named scopes also see global records. Facts are set-valued; revise exact facts for corrections. Use effective intervals for states, not events. Use recall_semantic after lexical recall when disclosure is acceptable. Never store secrets or assert CONTRADICTS/SUPERSEDES.",
            )
    }

    /// Negotiate `2026-07-28` or `2025-11-25`; unknown versions fail initialize.
    fn supported_protocol_versions(&self) -> Cow<'static, [ProtocolVersion]> {
        Cow::Borrowed(SUPPORTED_PROTOCOL_VERSIONS)
    }

    /// Handshake without Neo4j: accept a supported version and echo it on [`Self::get_info`].
    async fn initialize(
        &self,
        request: InitializeRequestParams,
        _context: RequestContext<RoleServer>,
    ) -> Result<InitializeResult, McpError> {
        require_supported_protocol(request.protocol_version.clone())?;
        let mut info = self.get_info();
        info.protocol_version = request.protocol_version;
        Ok(info)
    }
}

#[cfg(test)]
mod tests {
    use super::{
        classify_tool_error, map_connect_error, map_tool_result, require_supported_protocol,
        structured_error, Mindreader, TokenBucket, FACT_IRI_PATTERN, IRI_PATTERN,
        MAX_SEMANTIC_TEXT_BYTES,
    };
    use crate::config::Config;
    use crate::domain::DomainError;
    use crate::error::Error;
    use crate::payload::ToolOutput;
    use rmcp::ServerHandler;
    use serde_json::Value;

    fn test_server() -> Mindreader {
        Mindreader::from_config(Config::stub())
    }

    fn reason_of(result: rmcp::model::CallToolResult) -> String {
        assert_eq!(result.is_error, Some(true));
        result
            .structured_content
            .as_ref()
            .and_then(|value| value.get("reason"))
            .and_then(Value::as_str)
            .unwrap_or_default()
            .to_string()
    }

    fn tool_schema(name: &str) -> Value {
        Mindreader::tool_router()
            .list_all()
            .into_iter()
            .find(|tool| tool.name == name)
            .unwrap_or_else(|| panic!("missing tool {name}"))
            .schema_as_json_value()
    }

    fn assert_input_surface(name: &str, expected_properties: &[&str], expected_required: &[&str]) {
        let schema = tool_schema(name);
        let mut properties = schema["properties"]
            .as_object()
            .expect("input properties")
            .keys()
            .map(String::as_str)
            .collect::<Vec<_>>();
        properties.sort_unstable();
        let mut expected_properties = expected_properties.to_vec();
        expected_properties.sort_unstable();
        assert_eq!(properties, expected_properties, "{name} input properties");

        let required = schema["required"]
            .as_array()
            .expect("required fields")
            .iter()
            .map(|value| value.as_str().expect("required field name"))
            .collect::<Vec<_>>();
        assert_eq!(required, expected_required, "{name} required fields");
    }

    fn assert_no_union_keywords(value: &Value, tool: &str) {
        match value {
            Value::Object(map) => {
                assert!(
                    !map.contains_key("anyOf"),
                    "tool {tool} contains anyOf: {value}"
                );
                assert!(
                    !map.contains_key("oneOf"),
                    "tool {tool} contains oneOf: {value}"
                );
                assert!(
                    !map.contains_key("allOf"),
                    "tool {tool} contains allOf: {value}"
                );
                for child in map.values() {
                    assert_no_union_keywords(child, tool);
                }
            }
            Value::Array(values) => {
                for child in values {
                    assert_no_union_keywords(child, tool);
                }
            }
            _ => {}
        }
    }

    fn assert_object_schemas_are_closed(value: &Value, tool: &str) {
        match value {
            Value::Object(map) => {
                let is_object = map
                    .get("type")
                    .is_some_and(|schema_type| match schema_type {
                        Value::String(value) => value == "object",
                        Value::Array(values) => values.iter().any(|value| value == "object"),
                        _ => false,
                    });
                if is_object {
                    assert_eq!(
                        map.get("additionalProperties"),
                        Some(&Value::Bool(false)),
                        "tool {tool} contains an open object schema: {value}"
                    );
                }
                for child in map.values() {
                    assert_object_schemas_are_closed(child, tool);
                }
            }
            Value::Array(values) => {
                for child in values {
                    assert_object_schemas_are_closed(child, tool);
                }
            }
            _ => {}
        }
    }

    #[test]
    fn registers_eight_tools() {
        let names = Mindreader::registered_tool_names();
        let expected = [
            "judge",
            "place",
            "recall",
            "recall_semantic",
            "revise",
            "unify",
            "withdraw",
            "write",
        ];
        assert_eq!(names, expected);
        let router = Mindreader::tool_router();
        for name in expected {
            assert!(router.has_route(name), "missing route {name}");
        }
        assert_eq!(router.map.len(), 8);
    }

    #[test]
    fn mutation_schemas_advertise_tagged_inputs() {
        let router = Mindreader::tool_router();
        let tools: Vec<_> = router.list_all();
        let assert_schema = tools
            .iter()
            .find(|tool| tool.name == "write")
            .unwrap()
            .schema_as_json_value();
        let assert_props = assert_schema
            .get("properties")
            .and_then(|p| p.as_object())
            .unwrap();
        assert!(assert_props.get("s").is_none());
        assert!(assert_props.get("p").is_none());
        assert!(assert_props.get("o").is_none());
        assert!(assert_props.get("spike").is_none());
        assert!(assert_props.get("contradicts").is_none());
        let facts = &assert_props["facts"];
        assert_eq!(facts.get("maxItems").and_then(Value::as_u64), Some(20));
        assert_eq!(facts.get("minItems").and_then(Value::as_u64), Some(1));
        let item_props = facts["items"]["properties"].as_object().unwrap();
        assert_eq!(
            item_props["s"].get("type").and_then(Value::as_str),
            Some("object")
        );
        assert_eq!(
            item_props["o"].get("type").and_then(Value::as_str),
            Some("object")
        );
        assert_eq!(
            item_props["contradicts"]
                .get("type")
                .and_then(Value::as_str),
            Some("boolean")
        );
        assert_eq!(
            item_props["effective"]["type"],
            serde_json::json!(["object", "null"])
        );
        assert_eq!(item_props["effective"]["additionalProperties"], false);
        assert_eq!(
            item_props["s"]["properties"]["kind"]["enum"],
            serde_json::json!(["node"])
        );
        assert_eq!(
            item_props["o"]["properties"]["kind"]["enum"],
            serde_json::json!(["node", "literal"])
        );
        assert_eq!(item_props["p"]["minLength"], 1);
        let required = assert_schema
            .get("required")
            .and_then(|r| r.as_array())
            .cloned()
            .unwrap_or_default();
        assert_eq!(required, vec![Value::from("facts"), Value::from("scope")]);

        let revise_schema = tools
            .iter()
            .find(|tool| tool.name == "revise")
            .unwrap()
            .schema_as_json_value();
        let revise_required = revise_schema["required"].as_array().unwrap();
        for name in ["scope", "target", "replacement"] {
            assert!(revise_required.iter().any(|value| value == name));
        }
        assert_eq!(revise_schema["properties"]["replacement"]["type"], "object");
        assert_eq!(
            revise_schema["properties"]["effective"]["type"],
            serde_json::json!(["object", "null"])
        );
        assert_eq!(
            revise_schema["properties"]["target"]["properties"]["kind"]["enum"],
            serde_json::json!(["fact"])
        );

        let withdraw_schema = tools
            .iter()
            .find(|tool| tool.name == "withdraw")
            .unwrap()
            .schema_as_json_value();
        assert_eq!(
            withdraw_schema["properties"]["target"]["properties"]["kind"]["enum"],
            serde_json::json!(["fact"])
        );

        let judge_schema = tools
            .iter()
            .find(|tool| tool.name == "judge")
            .unwrap()
            .schema_as_json_value();
        assert_eq!(
            judge_schema["properties"]["ratings"]["items"]["properties"]["mode"]["enum"],
            serde_json::json!(["strengthen", "weaken"])
        );
        assert_eq!(judge_schema["properties"]["ratings"]["maxItems"], 20);

        let place_schema = tools
            .iter()
            .find(|tool| tool.name == "place")
            .unwrap()
            .schema_as_json_value();
        assert!(place_schema["properties"].get("target").is_none());
        assert!(place_schema["properties"].get("add").is_none());
        assert!(place_schema["properties"].get("remove").is_none());
        assert_eq!(place_schema["properties"]["edits"]["minItems"], 1);
        assert_eq!(place_schema["properties"]["edits"]["maxItems"], 20);
        assert_eq!(
            place_schema["required"],
            serde_json::json!(["scope", "edits"])
        );
    }

    #[test]
    fn tool_input_surfaces_are_exact() {
        assert_input_surface(
            "recall",
            &[
                "scope",
                "text",
                "iris",
                "labels",
                "around",
                "hops",
                "p",
                "depth",
                "direction",
                "history",
                "effectiveAt",
                "detail",
                "limit",
            ],
            &["scope"],
        );
        assert_input_surface(
            "recall_semantic",
            &["scope", "text", "labels", "effectiveAt", "detail", "limit"],
            &["scope", "text"],
        );
        assert_input_surface("write", &["facts", "scope"], &["facts", "scope"]);
        assert_input_surface(
            "revise",
            &[
                "scope",
                "target",
                "replacement",
                "spike",
                "contradicts",
                "reason",
                "effective",
            ],
            &["scope", "target", "replacement"],
        );
        assert_input_surface(
            "withdraw",
            &["scope", "target", "subject", "p", "reason"],
            &["scope"],
        );
        assert_input_surface("judge", &["scope", "ratings"], &["scope", "ratings"]);
        assert_input_surface("place", &["scope", "edits"], &["scope", "edits"]);
        assert_input_surface("unify", &["source", "target"], &["source", "target"]);
    }

    #[test]
    fn agent_critical_parameter_descriptions_are_explicit() {
        let recall = tool_schema("recall");
        let scope = recall["properties"]["scope"]["description"]
            .as_str()
            .expect("scope description");
        for expected in [
            "[] selects only global",
            "sees global records plus",
            "Copy exact values",
        ] {
            assert!(scope.contains(expected), "scope must explain {expected:?}");
        }
        assert!(recall["properties"]["labels"]["description"]
            .as_str()
            .is_some_and(|description| description.contains("selector")
                && description.contains("recall_semantic")));
        assert!(recall["properties"]["limit"]["description"]
            .as_str()
            .is_some_and(|description| description.contains("catalog nodes")
                && description.contains("per requested IRI")));

        let revise = tool_schema("revise");
        assert!(revise["properties"]["replacement"]["description"]
            .as_str()
            .is_some_and(
                |description| description.contains("subject and predicate remain unchanged")
            ));
        let effective = revise["properties"]["effective"]["description"]
            .as_str()
            .expect("revise effective description");
        for expected in ["Omit to inherit", "null to clear", "object to replace"] {
            assert!(
                effective.contains(expected),
                "revise effective must explain {expected:?}"
            );
        }

        let withdraw = tool_schema("withdraw");
        assert!(withdraw["properties"]["p"]["description"]
            .as_str()
            .is_some_and(|description| description.contains("Invalid with target")
                && description.contains("entire mutable outgoing slice")));

        let judge = tool_schema("judge");
        let mode = judge["properties"]["ratings"]["items"]["properties"]["mode"]["description"]
            .as_str()
            .expect("judge mode description");
        assert!(mode.contains("+1") && mode.contains("-1") && mode.contains("false facts"));

        let place = tool_schema("place");
        assert!(place["properties"]["edits"]["description"]
            .as_str()
            .is_some_and(|description| description.contains("endpoint closure")
                && description.contains("persisted literals")));
        assert!(
            place["properties"]["edits"]["items"]["properties"]["remove"]["description"]
                .as_str()
                .is_some_and(|description| description.contains("final named membership")
                    && description.contains("global"))
        );
    }

    #[test]
    fn input_schemas_do_not_prompt_inapplicable_defaults_or_mixed_object_fields() {
        let recall = tool_schema("recall");
        for field in ["hops", "depth", "direction"] {
            assert!(
                recall["properties"][field].get("default").is_none(),
                "selector-only {field} must not advertise a default that hosts may send with another selector"
            );
        }
        assert_eq!(recall["properties"]["around"]["pattern"], IRI_PATTERN);
        assert_eq!(
            recall["properties"]["iris"]["items"]["pattern"],
            IRI_PATTERN
        );

        let write = tool_schema("write");
        let object = &write["properties"]["facts"]["items"]["properties"]["o"];
        assert!(object["properties"]["datatype"].get("default").is_none());
        for field in ["iri", "name", "labels", "value", "datatype"] {
            let description = object["properties"][field]["description"]
                .as_str()
                .unwrap_or_else(|| panic!("object.{field} missing description"));
            assert!(
                description.contains("kind="),
                "object.{field} must identify its applicable kind"
            );
        }
        let revise = tool_schema("revise");
        assert_eq!(
            revise["properties"]["target"]["properties"]["iri"]["pattern"],
            FACT_IRI_PATTERN
        );

        let semantic = tool_schema("recall_semantic");
        assert_eq!(
            semantic["properties"]["text"]["maxLength"],
            MAX_SEMANTIC_TEXT_BYTES
        );

        let place = tool_schema("place");
        for field in ["add", "remove"] {
            assert_eq!(
                place["properties"]["edits"]["items"]["properties"][field]["minItems"],
                1
            );
        }
    }

    #[test]
    fn recall_schemas_advertise_effective_time_without_schema_unions() {
        let tools: Vec<_> = Mindreader::tool_router().list_all();
        for name in ["recall", "recall_semantic"] {
            let schema = tools
                .iter()
                .find(|tool| tool.name == name)
                .unwrap()
                .schema_as_json_value();
            assert_eq!(schema["properties"]["effectiveAt"]["format"], "date-time");
            assert_eq!(schema["properties"]["effectiveAt"]["type"], "string");
        }
    }

    #[test]
    fn scoped_tools_require_scope() {
        let router = Mindreader::tool_router();
        for tool in router.list_all() {
            let schema = tool.schema_as_json_value();
            let required = schema["required"].as_array().cloned().unwrap_or_default();
            if tool.name == "unify" {
                assert!(!required.iter().any(|value| value == "scope"));
            } else {
                assert!(
                    required.iter().any(|value| value == "scope"),
                    "{} must require scope",
                    tool.name
                );
            }
        }
    }

    #[test]
    fn tool_input_schemas_are_objects() {
        let router = Mindreader::tool_router();
        for tool in router.list_all() {
            let schema = tool.schema_as_json_value();
            assert_no_union_keywords(&schema, &tool.name);
            assert_eq!(
                schema.get("type").and_then(|v| v.as_str()),
                Some("object"),
                "tool {} inputSchema.type",
                tool.name
            );
            let props = schema
                .get("properties")
                .and_then(|p| p.as_object())
                .unwrap_or_else(|| panic!("tool {} missing properties", tool.name));
            for (k, v) in props {
                assert!(
                    v.is_object(),
                    "tool {} property {} must be an object schema, got {v}",
                    tool.name,
                    k
                );
            }
            if let Some(output) = tool.output_schema.as_ref() {
                let output = Value::Object((**output).clone());
                assert_no_union_keywords(&output, &tool.name);
            }
        }
    }

    #[test]
    fn get_info_prefers_2026_07_28_and_discovery_lists_host_compat() {
        let info = test_server().get_info();
        assert_eq!(
            info.protocol_version,
            rmcp::model::ProtocolVersion::V_2026_07_28
        );
        let tools = info.capabilities.tools.expect("tools capability");
        assert_ne!(tools.list_changed, Some(true));
        assert!(info.capabilities.prompts.is_none());
        assert!(info.capabilities.resources.is_none());
        let versions = test_server().supported_protocol_versions();
        assert_eq!(
            versions.as_ref(),
            &[
                rmcp::model::ProtocolVersion::V_2026_07_28,
                rmcp::model::ProtocolVersion::V_2025_11_25,
            ]
        );

        let discovery = rmcp::model::DiscoverResult::from_server_info(
            versions.into_owned(),
            test_server().get_info(),
        );
        let discovery = serde_json::to_value(discovery).expect("serialize discovery");
        assert_eq!(discovery["resultType"], "complete");
        assert_eq!(
            discovery["supportedVersions"],
            serde_json::json!(["2026-07-28", "2025-11-25"])
        );
    }

    #[test]
    fn accepts_2025_11_25_and_rejects_older_or_unknown_initialize_protocols() {
        assert!(require_supported_protocol(rmcp::model::ProtocolVersion::V_2026_07_28).is_ok());
        assert!(require_supported_protocol(rmcp::model::ProtocolVersion::V_2025_11_25).is_ok());
        for version in rmcp::model::ProtocolVersion::KNOWN_VERSIONS {
            if version != &rmcp::model::ProtocolVersion::V_2026_07_28
                && version != &rmcp::model::ProtocolVersion::V_2025_11_25
            {
                let error = require_supported_protocol(version.clone())
                    .expect_err("older protocol must be rejected");
                assert_eq!(error.message, "Unsupported protocol version");
            }
        }
        let unknown = serde_json::from_str::<rmcp::model::ProtocolVersion>("\"2099-01-01\"")
            .expect("deserialize open protocol version");
        require_supported_protocol(unknown).expect_err("unknown protocol must be rejected");
    }

    #[test]
    fn tool_annotations_are_present() {
        for tool in Mindreader::tool_router().list_all() {
            assert!(
                tool.title.as_ref().is_some_and(|title| !title.is_empty()),
                "{} missing top-level title",
                tool.name
            );
            let annotations = tool
                .annotations
                .as_ref()
                .unwrap_or_else(|| panic!("{} missing annotations", tool.name));
            assert!(
                annotations
                    .title
                    .as_ref()
                    .is_some_and(|title| !title.is_empty()),
                "{} missing title",
                tool.name
            );
            match tool.name.as_ref() {
                "recall" => {
                    assert_eq!(annotations.read_only_hint, Some(true));
                    assert_eq!(annotations.destructive_hint, Some(false));
                    assert_eq!(annotations.idempotent_hint, Some(true));
                    assert_eq!(annotations.open_world_hint, Some(false));
                }
                "recall_semantic" => {
                    assert_eq!(annotations.read_only_hint, Some(false));
                    assert_eq!(annotations.destructive_hint, Some(false));
                    assert_eq!(annotations.idempotent_hint, Some(false));
                    assert_eq!(annotations.open_world_hint, Some(true));
                }
                "write" => {
                    assert_eq!(annotations.read_only_hint, Some(false));
                    assert_eq!(annotations.destructive_hint, Some(false));
                    assert_eq!(annotations.idempotent_hint, Some(true));
                    assert_eq!(annotations.open_world_hint, Some(false));
                }
                "place" => {
                    assert_eq!(annotations.read_only_hint, Some(false));
                    assert_eq!(annotations.destructive_hint, Some(true));
                    assert_eq!(annotations.idempotent_hint, Some(true));
                    assert_eq!(annotations.open_world_hint, Some(false));
                }
                "revise" | "withdraw" | "judge" => {
                    assert_eq!(annotations.read_only_hint, Some(false));
                    assert_eq!(annotations.destructive_hint, Some(true));
                    assert_eq!(annotations.idempotent_hint, Some(false));
                    assert_eq!(annotations.open_world_hint, Some(false));
                }
                "unify" => {
                    assert_eq!(annotations.read_only_hint, Some(false));
                    assert_eq!(annotations.destructive_hint, Some(true));
                    assert_eq!(annotations.idempotent_hint, Some(false));
                    assert_eq!(annotations.open_world_hint, Some(false));
                }
                other => panic!("unexpected tool {other}"),
            }
        }
    }

    #[test]
    fn tool_output_schemas_are_objects() {
        for tool in Mindreader::tool_router().list_all() {
            let schema = tool
                .output_schema
                .as_ref()
                .unwrap_or_else(|| panic!("{} missing outputSchema", tool.name));
            let schema = Value::Object((**schema).clone());
            assert_no_union_keywords(&schema, &tool.name);
            assert_object_schemas_are_closed(&schema, &tool.name);
            assert_eq!(
                schema.get("type").and_then(Value::as_str),
                Some("object"),
                "tool {} outputSchema.type",
                tool.name
            );
            assert!(
                schema["required"]
                    .as_array()
                    .is_some_and(|required| required.iter().any(|value| value == "ok")),
                "tool {} output must require ok",
                tool.name
            );
        }
    }

    #[test]
    fn advertised_clamps() {
        let tools: Vec<_> = Mindreader::tool_router().list_all();
        let recall = tools
            .iter()
            .find(|tool| tool.name == "recall")
            .unwrap()
            .schema_as_json_value();
        assert_eq!(
            recall["properties"]["hops"]["enum"],
            serde_json::json!([0, 1])
        );
        assert_eq!(recall["properties"]["limit"]["minimum"], 1);
        assert_eq!(recall["properties"]["limit"]["maximum"], 100);
        assert_eq!(recall["properties"]["limit"]["default"], 20);
        assert_eq!(recall["properties"]["iris"]["minItems"], 1);
        assert_eq!(recall["properties"]["iris"]["maxItems"], 20);
        assert_eq!(recall["properties"]["depth"]["minimum"], 1);
        assert_eq!(recall["properties"]["depth"]["maximum"], 3);
        assert_eq!(
            recall["properties"]["detail"]["enum"],
            serde_json::json!(["concise", "detailed"])
        );
        assert!(recall["properties"].get("history").is_some());
        assert!(recall["properties"].get("semantic").is_none());

        let semantic = tools
            .iter()
            .find(|tool| tool.name == "recall_semantic")
            .unwrap()
            .schema_as_json_value();
        assert_eq!(semantic["required"], serde_json::json!(["scope", "text"]));
        assert_eq!(semantic["properties"]["limit"]["maximum"], 100);
        assert_eq!(semantic["properties"]["limit"]["default"], 20);
        assert!(semantic["properties"].get("iris").is_none());
        assert!(semantic["properties"].get("around").is_none());
    }

    #[test]
    fn output_schemas_use_only_current_field_names() {
        for tool in Mindreader::tool_router().list_all() {
            let output = tool.output_schema.as_ref().expect("output schema");
            let rendered = serde_json::to_string(output).expect("serialize output schema");
            for legacy in [
                "layers",
                "mergeSuggestions",
                "next",
                "targets",
                "ratings",
                "retracted",
                "propertyStub",
                "propertyCreated",
                "unifySuggestions",
                "siblings",
            ] {
                assert!(
                    !rendered.contains(&format!("\"{legacy}\":")),
                    "{} advertises legacy output field {legacy}",
                    tool.name
                );
            }
        }
        let tools: Vec<_> = Mindreader::tool_router().list_all();
        let revise = tools
            .iter()
            .find(|tool| tool.name == "revise")
            .unwrap()
            .output_schema
            .as_ref()
            .unwrap();
        assert!(revise["properties"].get("previousTarget").is_some());
        let withdraw = tools
            .iter()
            .find(|tool| tool.name == "withdraw")
            .unwrap()
            .output_schema
            .as_ref()
            .unwrap();
        assert!(withdraw["properties"].get("withdrawnTargets").is_some());
        assert!(withdraw["properties"].get("withdrawn").is_some());
    }

    #[test]
    fn instructions_and_descriptions_are_decision_oriented() {
        let info = test_server().get_info();
        let instructions = info.instructions.expect("instructions");
        assert!(instructions.len() <= 512, "instructions exceed 512 chars");
        assert!(instructions.contains("agent owns selective prospective memory"));
        assert!(instructions.contains("proactively recall"));
        assert!(instructions.contains("proactively write"));
        assert!(instructions.contains("[] is global-only"));
        assert!(instructions.contains("named scopes also see global records"));
        assert!(instructions.contains("Facts are set-valued"));
        assert!(instructions.contains("effective intervals for states"));
        assert!(instructions.contains("recall_semantic"));
        assert!(instructions.contains("CONTRADICTS"));
        let tools = Mindreader::tool_router().list_all();
        for tool in &tools {
            let description = tool
                .description
                .as_ref()
                .unwrap_or_else(|| panic!("{} missing description", tool.name));
            assert!(
                description.starts_with("Use "),
                "{} description must start with when-to-call: {description}",
                tool.name
            );
            assert!(
                description.len() <= 600,
                "{} description exceeds 600 chars: {description}",
                tool.name
            );
        }
        let recall = tools
            .iter()
            .find(|tool| tool.name == "recall")
            .unwrap()
            .description
            .as_deref()
            .unwrap();
        assert!(recall.contains("proactively"));
        assert!(recall.contains("user need not request recall"));
        let write = tools
            .iter()
            .find(|tool| tool.name == "write")
            .unwrap()
            .description
            .as_deref()
            .unwrap();
        assert!(write.contains("proactively"));
        assert!(write.contains("user need not ask"));
        assert!(write.contains("Facts are set-valued"));

        let semantic = tools
            .iter()
            .find(|tool| tool.name == "recall_semantic")
            .unwrap()
            .description
            .as_deref()
            .unwrap();
        assert!(semantic.contains("embedding provider"));
        assert!(semantic.contains("expiring semantic activations"));
        assert!(semantic.contains("non-idempotent"));
    }

    #[test]
    fn using_mindreader_skill_is_self_contained_and_covers_the_tool_contract() {
        let skill = include_str!("../skills/using-mindreader/SKILL.md");

        assert!(skill.split_whitespace().count() <= 2_000);
        assert!(!skill.contains("references/"));
        for tool in [
            "recall",
            "recall_semantic",
            "write",
            "revise",
            "withdraw",
            "judge",
            "place",
            "unify",
        ] {
            assert!(
                skill.contains(&format!("mindreader:{tool}")),
                "skill must route {tool}"
            );
        }
        for invariant in [
            "selective prospective memory",
            "Facts are set-valued",
            "effective interval",
            "provider disclosure",
            "raw conversation",
            "Missing memory remains unknown",
        ] {
            assert!(
                skill.contains(invariant),
                "skill must preserve {invariant:?}"
            );
        }
        assert!(!skill.contains("mindreader:memory_"));
    }

    #[test]
    fn map_tool_result_returns_structured_error() {
        let success = map_tool_result(Ok(ToolOutput::from_value(
            serde_json::json!({ "scope": [] }),
        )
        .unwrap()));
        assert_eq!(success.is_error, Some(false));
        assert_eq!(
            success
                .structured_content
                .as_ref()
                .and_then(|value| value.get("ok")),
            Some(&Value::Bool(true))
        );

        let invalid = map_tool_result(Err(DomainError::InvalidInput("bad layers".into()).into()));
        assert_eq!(reason_of(invalid), "invalid_input");

        let embedding = map_tool_result(Err(Error::Embedding("missing key".into())));
        assert_eq!(reason_of(embedding), "missing_embedding");

        let space = map_tool_result(Err(Error::EmbeddingSpace("dim mismatch".into())));
        let space_body = space
            .structured_content
            .expect("structured embedding_space");
        assert_eq!(space_body["reason"], "embedding_space");
        assert_eq!(space_body["retryable"], false);
        assert!(space_body.get("outcome").is_none());

        let wrapped_space = map_tool_result(Err(Error::EmbeddingSpace("dim mismatch".into())
            .context("query semantic activation vector index")));
        assert_eq!(reason_of(wrapped_space), "embedding_space");

        let concurrent = map_tool_result(Err(Error::ConcurrentMutation("fact".into())));
        assert_eq!(reason_of(concurrent), "concurrent_mutation");

        let connect = map_connect_error(Error::Graph("bolt offline".into()));
        assert_eq!(reason_of(connect), "connect_failed");

        let wrapped = map_tool_result(Err(Error::from(DomainError::InvalidInput(
            "wrapped".into(),
        ))
        .context("while validating")));
        assert_eq!(reason_of(wrapped), "invalid_input");
        assert_eq!(
            classify_tool_error(&Error::EmbeddingHttp {
                provider: "openai",
                status: 429,
                request_id: None,
                body: "slow down".into(),
            }),
            "rate_limited"
        );
        let limiter = structured_error("rate_limited", "MCP invoke rate limit exceeded");
        assert_eq!(reason_of(limiter), "rate_limited");

        let timeout = structured_error("timeout", "late");
        let body = timeout.structured_content.expect("structured timeout");
        assert_eq!(body["retryable"], false);
        assert!(body.get("outcome").is_none());
        let retryable = structured_error("connect_failed", "offline");
        let body = retryable
            .structured_content
            .expect("structured connect error");
        assert_eq!(body["retryable"], true);
        assert!(body.get("outcome").is_none());
    }

    #[test]
    fn token_bucket_reports_a_bounded_retry_delay() {
        let limiter = TokenBucket::new();
        for _ in 0..20 {
            assert_eq!(limiter.try_acquire(), Ok(()));
        }
        let retry_after_ms = limiter.try_acquire().expect_err("burst is exhausted");
        assert!((1..=500).contains(&retry_after_ms));
    }

    #[test]
    fn token_bucket_allows_an_eight_call_sequential_burst() {
        let limiter = TokenBucket::new();
        for _ in 0..8 {
            assert_eq!(limiter.try_acquire(), Ok(()));
        }
    }
}