mig-assembly 0.1.60

MIG-guided EDIFACT tree assembly — parse RawSegments into typed MIG trees
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
//! PID-specific MIG filtering using AHB segment numbers.
//!
//! The MIG XML defines ALL possible segments/groups for a message type.
//! The AHB for a specific PID references a subset via the `Number` attribute.
//! This module filters a full MIG schema to produce a PID-specific one
//! that the assembler can use without ambiguity.

use mig_types::schema::mig::{MigSchema, MigSegment, MigSegmentGroup};
use std::collections::HashSet;

/// Filter a MIG schema to only include segments and groups whose
/// segment `number` fields appear in the given AHB number set.
///
/// This resolves ambiguity when the MIG has multiple definitions
/// of the same group (e.g., two SG4 variants for IDE+Z01 vs IDE+24)
/// by keeping only the variant(s) that match the PID's AHB.
pub fn filter_mig_for_pid(mig: &MigSchema, ahb_numbers: &HashSet<String>) -> MigSchema {
    // Enable variant-aware assembly for message types whose same-tag group
    // variants carry distinct entry-segment qualifiers.
    //
    // * `variant_aware_top` — keeps top-level same-ID variants separate
    //   (PARTIN SG4+NAD+DEB/Z10/…, APERAK SG2+RFF+ACE/AGO/TN). This
    //   scopes each instance's `variant_mig_numbers` to its own variant,
    //   which the validator relies on to filter per-variant field rules
    //   (e.g. DTM belongs only to APERAK sg2_ace, not to every SG2+RFF+Zxx
    //   instance; FTX belongs only to PARTIN sg4_deb).
    // * `variant_aware_nested` — also keeps nested same-ID variants
    //   separate (UTILMD SG8 variants within SG4). Required for
    //   UTILMD's per-variant segment ordering.
    //
    // PARTIN's nested SG12 variants (sg12_z19 + sg12_z40 under sg4_su)
    // are left in merged mode: the BO4E reverse mapping relies on a
    // single merged group definition to preserve sibling order, and the
    // rule-scoping issue at SG4 doesn't exist inside SG12.
    let variant_aware_top = matches!(mig.message_type.as_str(), "UTILMD" | "PARTIN" | "APERAK");
    let variant_aware_nested = mig.message_type == "UTILMD";
    MigSchema {
        message_type: mig.message_type.clone(),
        variant: mig.variant.clone(),
        version: mig.version.clone(),
        publication_date: mig.publication_date.clone(),
        author: mig.author.clone(),
        format_version: mig.format_version.clone(),
        source_file: mig.source_file.clone(),
        segments: filter_segments(&mig.segments, ahb_numbers),
        segment_groups: filter_groups_with_mode(
            &mig.segment_groups,
            ahb_numbers,
            variant_aware_top,
            variant_aware_nested,
        ),
    }
}

/// Interchange-level segment tags that are always kept regardless of AHB filtering.
/// The AHB only covers message content (UNH→UNT), not the interchange wrapper.
const TRANSPORT_SEGMENTS: &[&str] = &["UNA", "UNB", "UNZ"];

/// Filter top-level segments: keep transport segments (UNA, UNB, UNZ),
/// those with no Number, or those whose Number is in the AHB set.
fn filter_segments(segments: &[MigSegment], ahb_numbers: &HashSet<String>) -> Vec<MigSegment> {
    segments
        .iter()
        .filter(|seg| {
            if TRANSPORT_SEGMENTS.contains(&seg.id.as_str()) {
                return true;
            }
            match &seg.number {
                None => true,
                Some(num) => ahb_numbers.contains(num),
            }
        })
        .cloned()
        .collect()
}

/// Filter segment groups: keep a group if its entry segment's Number
/// is in the AHB set (or has no Number). Within kept groups, recursively
/// filter segments and nested groups. Then merge groups with the same ID
/// into a single group definition so the assembler can handle all
/// repetitions of a group type (e.g., multiple SG8 SEQ variants).
fn filter_groups_with_mode(
    groups: &[MigSegmentGroup],
    ahb_numbers: &HashSet<String>,
    variant_aware: bool,
    variant_aware_nested: bool,
) -> Vec<MigSegmentGroup> {
    let filtered: Vec<MigSegmentGroup> = groups
        .iter()
        .filter(|group| group_matches_ahb(group, ahb_numbers))
        .map(|group| filter_group_contents_with_mode(group, ahb_numbers, variant_aware_nested))
        .collect();
    if variant_aware {
        tag_or_merge_same_id_groups(filtered)
    } else {
        merge_same_id_groups(filtered)
    }
}

/// Extracted qualifier info: (first_code, all_codes, qualifier_position).
type QualifierInfo = (String, Vec<String>, Option<(usize, usize)>);

/// For same-ID groups: keep separate (with variant_code) if ALL have extractable
/// qualifier codes; otherwise fall back to merging for backward compatibility.
fn tag_or_merge_same_id_groups(groups: Vec<MigSegmentGroup>) -> Vec<MigSegmentGroup> {
    let mut seen_ids: Vec<String> = Vec::new();
    let mut by_id: Vec<Vec<MigSegmentGroup>> = Vec::new();
    for g in groups {
        if let Some(pos) = seen_ids.iter().position(|id| *id == g.id) {
            by_id[pos].push(g);
        } else {
            seen_ids.push(g.id.clone());
            by_id.push(vec![g]);
        }
    }
    let mut result = Vec::new();
    for variants in by_id {
        if variants.len() == 1 {
            result.push(variants.into_iter().next().unwrap());
        } else {
            let quals: Vec<Option<QualifierInfo>> = variants
                .iter()
                .map(extract_entry_qualifier_with_position)
                .collect();
            if quals.iter().all(|c| c.is_some()) {
                let count = variants.len() as u32;
                for (mut g, qual) in variants.into_iter().zip(quals) {
                    let (code, all_codes, pos) = qual.unwrap();
                    g.variant_code = Some(code);
                    g.variant_codes = all_codes;
                    g.variant_qualifier_position = pos;
                    g.merged_variant_count = Some(count);
                    result.push(g);
                }
            } else {
                result.push(merge_group_variants(variants));
            }
        }
    }
    result
}

/// Extract qualifier code and its element position from a group's entry segment.
/// Returns (code, Some((element_idx, component_idx))) for composite positions,
/// (code, None) for the default position (0, 0).
fn extract_entry_qualifier_with_position(
    group: &MigSegmentGroup,
) -> Option<(String, Vec<String>, Option<(usize, usize)>)> {
    let entry = group.segments.first()?;
    // Check simple data elements first (default position 0,0)
    for (ei, de) in entry.data_elements.iter().enumerate() {
        if !de.codes.is_empty() {
            let first_code = de.codes.first()?.value.clone();
            let all_codes: Vec<String> = de.codes.iter().map(|c| c.value.clone()).collect();
            let pos = if ei == 0 { None } else { Some((ei, 0)) };
            return Some((first_code, all_codes, pos));
        }
    }
    // Check composites
    for comp in &entry.composites {
        for sub in &comp.data_elements {
            if !sub.codes.is_empty() {
                let first_code = sub.codes.first()?.value.clone();
                let all_codes: Vec<String> = sub.codes.iter().map(|c| c.value.clone()).collect();
                let pos = Some((comp.position, sub.position));
                return Some((first_code, all_codes, pos));
            }
        }
    }
    None
}

/// Check if a group should be kept: any segment within the group (or its
/// nested children) must have a Number in the AHB set, or no Number at all.
///
/// Previously this only checked the entry segment, which caused groups to be
/// dropped when the PID references segments in nested groups but not the
/// parent's entry segment (e.g., ORDERS PID 17112 references CCI Numbers
/// in SG30 but not the parent SG29's LIN Number).
fn group_matches_ahb(group: &MigSegmentGroup, ahb_numbers: &HashSet<String>) -> bool {
    // Check direct segments
    for seg in &group.segments {
        if let Some(num) = &seg.number {
            if ahb_numbers.contains(num) {
                return true;
            }
        }
    }
    // Check nested groups recursively
    for nested in &group.nested_groups {
        if group_matches_ahb(nested, ahb_numbers) {
            return true;
        }
    }
    // Keep groups where all segments lack Numbers (unnumbered = always included)
    !group.segments.is_empty() && group.segments.iter().all(|s| s.number.is_none())
}

fn filter_group_contents_with_mode(
    group: &MigSegmentGroup,
    ahb_numbers: &HashSet<String>,
    variant_aware: bool,
) -> MigSegmentGroup {
    MigSegmentGroup {
        id: group.id.clone(),
        name: group.name.clone(),
        description: group.description.clone(),
        counter: group.counter.clone(),
        level: group.level,
        max_rep_std: group.max_rep_std,
        max_rep_spec: group.max_rep_spec,
        status_std: group.status_std.clone(),
        status_spec: group.status_spec.clone(),
        segments: filter_segments(&group.segments, ahb_numbers),
        nested_groups: filter_groups_with_mode(
            &group.nested_groups,
            ahb_numbers,
            variant_aware,
            variant_aware,
        ),
        variant_code: group.variant_code.clone(),
        variant_qualifier_position: None,
        variant_codes: group.variant_codes.clone(),
        merged_variant_count: group.merged_variant_count,
    }
}

/// Merge groups with the same ID into a single group definition.
///
/// After PID filtering, the MIG may contain multiple groups with the same ID
/// but different variants (e.g., 4 SG8 definitions for SEQ+ZD7, Z98, ZF1, ZF3).
/// The assembler matches groups by entry tag only and would consume all repetitions
/// under the first definition. Merging produces a single group per ID with the union
/// of all segments and nested groups, enabling the assembler to handle all variants.
fn merge_same_id_groups(groups: Vec<MigSegmentGroup>) -> Vec<MigSegmentGroup> {
    // Collect groups by ID, preserving first-seen order
    let mut seen_ids: Vec<String> = Vec::new();
    let mut by_id: Vec<Vec<MigSegmentGroup>> = Vec::new();

    for g in groups {
        if let Some(pos) = seen_ids.iter().position(|id| *id == g.id) {
            by_id[pos].push(g);
        } else {
            seen_ids.push(g.id.clone());
            by_id.push(vec![g]);
        }
    }

    by_id
        .into_iter()
        .map(|variants| {
            if variants.len() == 1 {
                variants.into_iter().next().unwrap()
            } else {
                let count = variants.len() as u32;
                let mut merged = merge_group_variants(variants);
                merged.merged_variant_count = Some(count);
                merged
            }
        })
        .collect()
}

/// Merge multiple variants of the same group into one.
///
/// Segments are unioned by tag: for each tag, include the maximum number of
/// occurrences found in any single variant (e.g., if one variant has 2 CAV
/// segments and others have 1, the merged group has 2). Order is preserved
/// from the first variant that introduces each tag.
///
/// Nested groups are collected from all variants and recursively merged.
/// They are sorted by numeric suffix (SG9 before SG10) to maintain
/// standard EDIFACT group ordering.
fn merge_group_variants(variants: Vec<MigSegmentGroup>) -> MigSegmentGroup {
    let first = &variants[0];

    // Merge segments: use the longest variant as base ordering, then add
    // any additional tags from shorter variants. This ensures the merged
    // order respects the most complete variant's segment positions.
    //
    // Example: Z02 has [SEQ, PIA], Z20 has [SEQ, RFF, RFF, PIA].
    // Using Z20 as base gives [SEQ, RFF, RFF, PIA] — the assembler can
    // then handle both Z02 reps (skipping RFF slots) and Z20 reps correctly.
    // Without this, Z02-first ordering produces [SEQ, PIA, RFF, RFF],
    // which breaks Z20 assembly (PIA expected where RFF appears).
    let longest_idx = variants
        .iter()
        .enumerate()
        .max_by_key(|(_, v)| v.segments.len())
        .map(|(i, _)| i)
        .unwrap_or(0);

    // Start with the longest variant's segments as base
    let mut merged_segments: Vec<MigSegment> = variants[longest_idx].segments.clone();

    // Add segments from other variants that aren't sufficiently represented
    for (i, variant) in variants.iter().enumerate() {
        if i == longest_idx {
            continue;
        }
        for seg in &variant.segments {
            let count_in_merged = merged_segments.iter().filter(|s| s.id == seg.id).count();
            let count_in_variant = variant.segments.iter().filter(|s| s.id == seg.id).count();
            if count_in_variant > count_in_merged {
                for _ in 0..(count_in_variant - count_in_merged) {
                    merged_segments.push(seg.clone());
                }
            }
        }
    }

    // Collect all nested groups from all variants and recursively merge
    let mut all_nested: Vec<MigSegmentGroup> = Vec::new();
    for variant in &variants {
        all_nested.extend(variant.nested_groups.iter().cloned());
    }
    let mut merged_nested = merge_same_id_groups(all_nested);
    // Sort by group number (SG9 < SG10) for standard EDIFACT ordering
    merged_nested.sort_by_key(|g| extract_group_number(&g.id));

    MigSegmentGroup {
        id: first.id.clone(),
        name: first.name.clone(),
        description: first.description.clone(),
        counter: first.counter.clone(),
        level: first.level,
        max_rep_std: variants.iter().map(|v| v.max_rep_std).max().unwrap_or(1),
        max_rep_spec: variants.iter().map(|v| v.max_rep_spec).max().unwrap_or(1),
        status_std: first.status_std.clone(),
        status_spec: first.status_spec.clone(),
        segments: merged_segments,
        nested_groups: merged_nested,
        variant_code: first.variant_code.clone(),
        variant_qualifier_position: None,
        variant_codes: first.variant_codes.clone(),
        merged_variant_count: None,
    }
}

/// Extract numeric suffix from a group ID (e.g., "SG10" → 10).
fn extract_group_number(id: &str) -> u32 {
    id.strip_prefix("SG")
        .and_then(|s| s.parse().ok())
        .unwrap_or(u32::MAX)
}

#[cfg(test)]
mod tests {
    use super::*;
    use mig_types::schema::mig::MigSegment;

    fn seg(id: &str, number: Option<&str>) -> MigSegment {
        MigSegment {
            id: id.to_string(),
            name: id.to_string(),
            description: None,
            counter: None,
            level: 0,
            number: number.map(|n| n.to_string()),
            max_rep_std: 1,
            max_rep_spec: 1,
            status_std: None,
            status_spec: None,
            example: None,
            data_elements: vec![],
            composites: vec![],
        }
    }

    fn group(id: &str, segments: Vec<MigSegment>, nested: Vec<MigSegmentGroup>) -> MigSegmentGroup {
        MigSegmentGroup {
            id: id.to_string(),
            name: id.to_string(),
            description: None,
            counter: None,
            level: 1,
            max_rep_std: 99,
            max_rep_spec: 99,
            status_std: None,
            status_spec: None,
            segments,
            nested_groups: nested,
            variant_code: None,
            variant_qualifier_position: None,
            variant_codes: vec![],
            merged_variant_count: None,
        }
    }

    #[test]
    fn test_filter_selects_correct_sg4_variant() {
        // Simulate two SG4 variants like in real MIG
        let sg4_list = group("SG4", vec![seg("IDE", Some("00012"))], vec![]);
        let sg4_txn = group(
            "SG4",
            vec![
                seg("IDE", Some("00020")),
                seg("DTM", Some("00023")),
                seg("STS", Some("00035")),
            ],
            vec![
                group("SG5", vec![seg("LOC", Some("00049"))], vec![]),
                group("SG6", vec![seg("RFF", Some("00056"))], vec![]),
            ],
        );

        let mig = MigSchema {
            message_type: "UTILMD".to_string(),
            variant: None,
            version: "S2.1".to_string(),
            publication_date: String::new(),
            author: String::new(),
            format_version: "FV2504".to_string(),
            source_file: String::new(),
            segments: vec![seg("UNH", Some("00003")), seg("BGM", Some("00004"))],
            segment_groups: vec![sg4_list, sg4_txn],
        };

        // PID 55001 references Numbers 00003, 00004, 00020, 00023, 00035, 00049, 00056
        let ahb_numbers: HashSet<String> = [
            "00003", "00004", "00020", "00023", "00035", "00049", "00056",
        ]
        .iter()
        .map(|s| s.to_string())
        .collect();

        let filtered = filter_mig_for_pid(&mig, &ahb_numbers);

        // Should keep both top-level segments
        assert_eq!(filtered.segments.len(), 2);

        // Should keep only the transaction SG4 (00020), not the list SG4 (00012)
        assert_eq!(filtered.segment_groups.len(), 1);
        let sg4 = &filtered.segment_groups[0];
        assert_eq!(sg4.id, "SG4");
        assert_eq!(sg4.segments.len(), 3); // IDE, DTM, STS
        assert_eq!(sg4.nested_groups.len(), 2); // SG5, SG6
    }

    #[test]
    fn test_filter_keeps_transport_and_matching_segments() {
        let mig = MigSchema {
            message_type: "UTILMD".to_string(),
            variant: None,
            version: "S2.1".to_string(),
            publication_date: String::new(),
            author: String::new(),
            format_version: "FV2504".to_string(),
            source_file: String::new(),
            segments: vec![
                seg("UNA", None),          // Transport — always keep
                seg("UNB", Some("00001")), // Transport — always keep
                seg("UNH", Some("00003")), // In AHB
                seg("DTM", Some("00099")), // Not in AHB
                seg("UNZ", Some("00527")), // Transport — always keep
            ],
            segment_groups: vec![],
        };

        let ahb_numbers: HashSet<String> = ["00003"].iter().map(|s| s.to_string()).collect();
        let filtered = filter_mig_for_pid(&mig, &ahb_numbers);

        // UNA, UNB, UNH, UNZ kept; DTM filtered out
        assert_eq!(filtered.segments.len(), 4);
        assert_eq!(filtered.segments[0].id, "UNA");
        assert_eq!(filtered.segments[1].id, "UNB");
        assert_eq!(filtered.segments[2].id, "UNH");
        assert_eq!(filtered.segments[3].id, "UNZ");
    }

    #[test]
    fn test_filter_merges_same_id_groups() {
        // Simulate 3 SG8 variants (ZD7, Z98, ZF1) like in PID 55013
        let sg8_zd7 = group(
            "SG8",
            vec![seg("SEQ", Some("00089")), seg("RFF", Some("00090"))],
            vec![group(
                "SG10",
                vec![seg("CCI", Some("00092")), seg("CAV", Some("00093"))],
                vec![],
            )],
        );
        let sg8_z98 = group(
            "SG8",
            vec![seg("SEQ", Some("00114"))],
            vec![
                group("SG9", vec![seg("QTY", Some("00116"))], vec![]),
                group(
                    "SG10",
                    vec![seg("CCI", Some("00122")), seg("CAV", Some("00125"))],
                    vec![],
                ),
            ],
        );
        let sg8_zf3 = group(
            "SG8",
            vec![seg("SEQ", Some("00291")), seg("RFF", Some("00292"))],
            vec![group(
                "SG10",
                vec![
                    seg("CCI", Some("00295")),
                    seg("CAV", Some("00296")),
                    seg("CAV", Some("00297")),
                ],
                vec![],
            )],
        );

        let sg4 = group(
            "SG4",
            vec![seg("IDE", Some("00020"))],
            vec![sg8_zd7, sg8_z98, sg8_zf3],
        );

        let mig = MigSchema {
            message_type: "UTILMD".to_string(),
            variant: None,
            version: "S2.1".to_string(),
            publication_date: String::new(),
            author: String::new(),
            format_version: "FV2504".to_string(),
            source_file: String::new(),
            segments: vec![],
            segment_groups: vec![sg4],
        };

        let ahb_numbers: HashSet<String> = [
            "00020", "00089", "00090", "00092", "00093", "00114", "00116", "00122", "00125",
            "00291", "00292", "00295", "00296", "00297",
        ]
        .iter()
        .map(|s| s.to_string())
        .collect();

        let filtered = filter_mig_for_pid(&mig, &ahb_numbers);
        let sg4 = &filtered.segment_groups[0];

        // All 3 SG8 variants should be merged into 1
        assert_eq!(sg4.nested_groups.len(), 1, "SG8 variants should be merged");
        let sg8 = &sg4.nested_groups[0];
        assert_eq!(sg8.id, "SG8");

        // Merged segments: SEQ (from all) + RFF (from ZD7/ZF3)
        let seg_tags: Vec<&str> = sg8.segments.iter().map(|s| s.id.as_str()).collect();
        assert_eq!(seg_tags, vec!["SEQ", "RFF"]);

        // Merged nested groups: SG9 (from Z98) + SG10 (from all), sorted by number
        assert_eq!(sg8.nested_groups.len(), 2, "should have SG9 and SG10");
        assert_eq!(sg8.nested_groups[0].id, "SG9");
        assert_eq!(sg8.nested_groups[1].id, "SG10");

        // SG10 should have merged segments: CCI + 2 CAVs (max from ZF3)
        let sg10_tags: Vec<&str> = sg8.nested_groups[1]
            .segments
            .iter()
            .map(|s| s.id.as_str())
            .collect();
        assert_eq!(sg10_tags, vec!["CCI", "CAV", "CAV"]);
    }

    #[test]
    fn test_filter_removes_nested_groups_not_in_ahb() {
        let sg8_z79 = group(
            "SG8",
            vec![seg("SEQ", Some("00081"))],
            vec![group("SG10", vec![seg("CCI", Some("00083"))], vec![])],
        );
        let sg8_z99 = group(
            "SG8",
            vec![seg("SEQ", Some("00999"))], // Not in AHB
            vec![],
        );

        let sg4 = group(
            "SG4",
            vec![seg("IDE", Some("00020"))],
            vec![sg8_z79, sg8_z99],
        );

        let mig = MigSchema {
            message_type: "UTILMD".to_string(),
            variant: None,
            version: "S2.1".to_string(),
            publication_date: String::new(),
            author: String::new(),
            format_version: "FV2504".to_string(),
            source_file: String::new(),
            segments: vec![],
            segment_groups: vec![sg4],
        };

        let ahb_numbers: HashSet<String> = ["00020", "00081", "00083"]
            .iter()
            .map(|s| s.to_string())
            .collect();

        let filtered = filter_mig_for_pid(&mig, &ahb_numbers);

        let sg4 = &filtered.segment_groups[0];
        // Only the SG8 with SEQ Number 00081 should survive
        assert_eq!(sg4.nested_groups.len(), 1);
        assert_eq!(
            sg4.nested_groups[0].segments[0].number,
            Some("00081".to_string())
        );
    }

    #[test]
    fn test_variant_codes_include_all_entry_qualifier_codes() {
        use mig_types::schema::common::CodeDefinition;
        use mig_types::schema::mig::MigDataElement;

        let mut sg6_z13 = group("SG6", vec![seg("RFF", Some("00056"))], vec![]);
        sg6_z13.segments[0].data_elements.push(MigDataElement {
            id: "1153".to_string(),
            name: "Qualifier".to_string(),
            description: None,
            status_std: None,
            status_spec: None,
            format_std: None,
            format_spec: None,
            position: 0,
            codes: vec![CodeDefinition {
                value: "Z13".to_string(),
                name: "PI".to_string(),
                description: None,
            }],
        });

        let mut sg6_zeit = group("SG6", vec![seg("RFF", Some("00073"))], vec![]);
        sg6_zeit.segments[0].data_elements.push(MigDataElement {
            id: "1153".to_string(),
            name: "Qualifier".to_string(),
            description: None,
            status_std: None,
            status_spec: None,
            format_std: None,
            format_spec: None,
            position: 0,
            codes: vec![
                CodeDefinition {
                    value: "Z47".to_string(),
                    name: "A".to_string(),
                    description: None,
                },
                CodeDefinition {
                    value: "Z49".to_string(),
                    name: "B".to_string(),
                    description: None,
                },
            ],
        });

        let tagged = tag_or_merge_same_id_groups(vec![sg6_z13, sg6_zeit]);
        assert_eq!(tagged.len(), 2);
        assert_eq!(tagged[0].variant_code, Some("Z13".to_string()));
        assert_eq!(tagged[0].variant_codes, vec!["Z13"]);
        assert_eq!(tagged[1].variant_code, Some("Z47".to_string()));
        assert_eq!(tagged[1].variant_codes, vec!["Z47", "Z49"]);
    }
}