miden-protocol 0.17.0-rc.4

use alloc::vec::Vec;

use crate::block::{BlockNumber, BlockSignatures, SignatureVerificationError, ValidatorConfig};
use crate::protocol_config::NextProtocolConfig;
use crate::utils::serde::{
    ByteReader,
    ByteWriter,
    Deserializable,
    DeserializationError,
    Serializable,
};
use crate::{Felt, Hasher, Word, ZERO};

// BLOCK HEADER
// ================================================================================================

/// The header of a block. It contains metadata about the block, commitments to the current state of
/// the chain and the hash of the proof that attests to the integrity of the chain.
///
/// A block header includes the following fields:
///
/// - `version` specifies the version of the block header itself. It changes when fields are added
///   to or removed from the header, and when the scheme behind one of the header's commitments
///   changes, for example the structure of the SMTs or of the MMR.
/// - `timestamp` is the time when the block was created, in seconds since UNIX epoch. The u32 is
///   sufficient to represent timestamps up to year 2106.
/// - `block_num` is a unique sequential number of the current block.
/// - `prev_block_commitment` is the hash of the previous block header.
/// - `chain_commitment` is a commitment to an MMR of the entire chain where each block is a leaf.
/// - `account_root` is a commitment to account database.
/// - `nullifier_root` is a commitment to the nullifier database.
/// - `note_root` is a commitment to all notes created in the current block.
/// - `tx_commitment` is a commitment to the set of transaction IDs which affected accounts in the
///   block.
/// - `validator_config` is the set of validator public keys authorized to sign the *next* block,
///   together with the quorum, see [`ValidatorConfig`] for more details.
/// - `fee_parameters` are the parameters defining the base fees, see [`FeeParameters`] for more
///   details.
/// - `protocol_config_commitment` is the commitment to the chain's
///   [`ProtocolConfig`](crate::protocol_config::ProtocolConfig).
/// - `next_protocol_config` is the scheduled protocol upgrade, if any, see [`NextProtocolConfig`]
///   for more details.
/// - `sub_commitment` is a sequential hash of all fields except the note_root.
/// - `commitment` is a 2-to-1 hash of the sub_commitment and the note_root.
#[derive(Debug, Eq, PartialEq, Clone)]
pub struct BlockHeader {
    version: u8,
    timestamp: u32,
    block_num: BlockNumber,
    prev_block_commitment: Word,
    chain_commitment: Word,
    account_root: Word,
    nullifier_root: Word,
    note_root: Word,
    tx_commitment: Word,
    validator_config: ValidatorConfig,
    fee_parameters: FeeParameters,
    protocol_config_commitment: Word,
    next_protocol_config: Option<NextProtocolConfig>,
    sub_commitment: Word,
    commitment: Word,
}

impl BlockHeader {
    // CONSTANTS
    // --------------------------------------------------------------------------------------------

    /// Version 1 of the block header.
    ///
    /// It is encoded using 8 bits.
    const VERSION_1: u8 = 1;

    /// The number of field elements in the preimage of [`BlockHeader::sub_commitment`].
    const NUM_SUB_COMMITMENT_ELEMENTS: usize = 40;

    // CONSTRUCTORS
    // --------------------------------------------------------------------------------------------

    /// Creates a new block header.
    #[allow(clippy::too_many_arguments)]
    pub fn new(
        prev_block_commitment: Word,
        block_num: BlockNumber,
        chain_commitment: Word,
        account_root: Word,
        nullifier_root: Word,
        note_root: Word,
        tx_commitment: Word,
        validator_config: ValidatorConfig,
        fee_parameters: FeeParameters,
        protocol_config_commitment: Word,
        next_protocol_config: Option<NextProtocolConfig>,
        timestamp: u32,
    ) -> Self {
        let version = Self::VERSION_1;

        let sub_elements = Self::to_sub_elements(
            version,
            prev_block_commitment,
            block_num,
            chain_commitment,
            account_root,
            nullifier_root,
            tx_commitment,
            &validator_config,
            &fee_parameters,
            protocol_config_commitment,
            next_protocol_config.as_ref(),
            timestamp,
        );
        let sub_commitment = Hasher::hash_elements(&sub_elements);

        // The sub commitment is merged with the note_root - hash(sub_commitment, note_root) to
        // produce the final hash. This is done to make the note_root easily accessible
        // without having to unhash the entire header. Having the note_root easily
        // accessible is useful when authenticating notes.
        let commitment = Hasher::merge(&[sub_commitment, note_root]);

        Self {
            version,
            timestamp,
            block_num,
            prev_block_commitment,
            chain_commitment,
            account_root,
            nullifier_root,
            note_root,
            tx_commitment,
            validator_config,
            fee_parameters,
            protocol_config_commitment,
            next_protocol_config,
            sub_commitment,
            commitment,
        }
    }

    // ACCESSORS
    // --------------------------------------------------------------------------------------------

    /// Returns the block version.
    pub fn version(&self) -> u8 {
        self.version
    }

    /// Returns the commitment of the block header.
    pub fn commitment(&self) -> Word {
        self.commitment
    }

    /// Returns the sub commitment of the block header.
    ///
    /// The sub commitment is a sequential hash of all block header fields except the note root.
    /// This is used in the block commitment computation which is a 2-to-1 hash of the sub
    /// commitment and the note root [hash(sub_commitment, note_root)]. This procedure is used to
    /// make the note root easily accessible without having to unhash the entire header.
    pub fn sub_commitment(&self) -> Word {
        self.sub_commitment
    }

    /// Returns the commitment to the previous block header.
    pub fn prev_block_commitment(&self) -> Word {
        self.prev_block_commitment
    }

    /// Returns the block number.
    pub fn block_num(&self) -> BlockNumber {
        self.block_num
    }

    /// Returns the epoch to which this block belongs.
    ///
    /// This is the block number shifted right by [`BlockNumber::EPOCH_LENGTH_EXPONENT`].
    pub fn block_epoch(&self) -> u16 {
        self.block_num.block_epoch()
    }

    /// Returns the chain commitment.
    pub fn chain_commitment(&self) -> Word {
        self.chain_commitment
    }

    /// Returns the account database root.
    pub fn account_root(&self) -> Word {
        self.account_root
    }

    /// Returns the nullifier database root.
    pub fn nullifier_root(&self) -> Word {
        self.nullifier_root
    }

    /// Returns the note root.
    pub fn note_root(&self) -> Word {
        self.note_root
    }

    /// Returns the validator configuration authorized to sign the *next* block.
    ///
    /// A block's signatures are verified against the `validator_config` committed to by its parent
    /// block, not against this field. See the [`BlockHeader`] docs for details.
    pub fn validator_config(&self) -> &ValidatorConfig {
        &self.validator_config
    }

    /// Returns the commitment to all transactions in this block.
    ///
    /// The commitment is computed as sequential hash of (`transaction_id`, `account_id`) tuples.
    /// This makes it possible for the verifier to link transaction IDs to the accounts which
    /// they were executed against.
    pub fn tx_commitment(&self) -> Word {
        self.tx_commitment
    }

    /// Returns a reference to the [`FeeParameters`] in this header.
    pub fn fee_parameters(&self) -> &FeeParameters {
        &self.fee_parameters
    }

    /// Returns the commitment to the chain's
    /// [`ProtocolConfig`](crate::protocol_config::ProtocolConfig).
    pub fn protocol_config_commitment(&self) -> Word {
        self.protocol_config_commitment
    }

    /// Returns the protocol upgrade scheduled by this block, if any.
    pub fn next_protocol_config(&self) -> Option<&NextProtocolConfig> {
        self.next_protocol_config.as_ref()
    }

    /// Returns the commitment to the scheduled protocol upgrade, or [`Word::empty`] if no upgrade
    /// is scheduled.
    pub fn next_protocol_config_commitment(&self) -> Word {
        Self::compute_next_protocol_config_commitment(self.next_protocol_config.as_ref())
    }

    /// Returns the timestamp at which the block was created, in seconds since UNIX epoch.
    pub fn timestamp(&self) -> u32 {
        self.timestamp
    }

    /// Returns the block number of the epoch block to which this block belongs.
    pub fn epoch_block_num(&self) -> BlockNumber {
        BlockNumber::from_epoch(self.block_epoch())
    }

    // ELEMENT ENCODING
    // --------------------------------------------------------------------------------------------

    /// Returns this header as a sequence of field elements.
    ///
    /// The element layout is:
    ///
    /// ```text
    /// [
    ///     [version, block_num, timestamp, 0],
    ///     PREV_BLOCK_COMMITMENT,
    ///     CHAIN_COMMITMENT,
    ///     ACCOUNT_ROOT,
    ///     NULLIFIER_ROOT,
    ///     TX_COMMITMENT,
    ///     PROTOCOL_CONFIG_COMMITMENT,
    ///     VALIDATOR_CONFIG_COMMITMENT,
    ///     NEXT_PROTOCOL_CONFIG_COMMITMENT,
    ///     [verification_base_fee, 0, 0, 0],
    ///     NOTE_ROOT,
    /// ]
    /// ```
    ///
    /// This is the canonical encoding of a header. It is the layout of the kernel's block data
    /// memory section and the order in which the header is provided to the kernel, so keep it in
    /// sync with the kernel's `process_block_data` procedure.
    ///
    /// Note that [`BlockHeader::commitment`] is *not* the sequential hash of these elements: the
    /// note root is hashed separately so that it stays accessible without unhashing the whole
    /// header. All elements but the trailing note root form the preimage of
    /// [`BlockHeader::sub_commitment`].
    pub fn to_elements(&self) -> Vec<Felt> {
        let mut elements = Self::to_sub_elements(
            self.version,
            self.prev_block_commitment,
            self.block_num,
            self.chain_commitment,
            self.account_root,
            self.nullifier_root,
            self.tx_commitment,
            &self.validator_config,
            &self.fee_parameters,
            self.protocol_config_commitment,
            self.next_protocol_config.as_ref(),
            self.timestamp,
        );
        elements.extend_from_slice(self.note_root.as_elements());
        elements
    }

    // VALIDATION
    // --------------------------------------------------------------------------------------------

    /// Validates that `parent` precedes and authorizes this block.
    ///
    /// The `signatures` are positional with respect to the validator set committed to by `parent`
    /// (see [`ValidatorConfig`]): the signature at index `i` must verify against the parent's
    /// validator key at index `i`. Every validator in the parent's set must have signed.
    ///
    /// # Errors
    ///
    /// Returns an error if the block is the genesis block (no parent), the parent's number or
    /// commitment do not match, the number of signatures does not match the parent's validator
    /// count, or a signature does not verify against its validator key.
    pub(crate) fn validate_against_parent(
        &self,
        parent: &BlockHeader,
        signatures: &BlockSignatures,
    ) -> Result<(), ParentValidationError> {
        // Block 0 does not have a parent.
        let Some(expected_parent_num) = self.block_num().checked_sub(1) else {
            return Err(ParentValidationError::GenesisBlockHasNoParent {
                parent: parent.block_num(),
            });
        };

        // Check block numbers.
        if expected_parent_num != parent.block_num() {
            return Err(ParentValidationError::ParentNumberMismatch {
                expected: expected_parent_num,
                parent: parent.block_num(),
            });
        }

        // Check commitments.
        let expected_prev_commitment = self.prev_block_commitment();
        if expected_prev_commitment != parent.commitment() {
            return Err(ParentValidationError::ParentCommitmentMismatch {
                expected: expected_prev_commitment,
                parent: parent.commitment(),
            });
        }

        // Verify the signatures positionally against the parent's validator set using the shared,
        // canonical verifier, which also enforces that every validator signed.
        signatures
            .verify_against(self.commitment(), parent.validator_config())
            .map_err(|err| match err {
                SignatureVerificationError::SignatureCountMismatch { expected, actual } => {
                    ParentValidationError::SignatureCountMismatch { expected, actual }
                },
                SignatureVerificationError::InvalidSignatureAtPosition { position } => {
                    ParentValidationError::InvalidSignatureAtPosition { position }
                },
            })?;

        Ok(())
    }

    // HELPERS
    // --------------------------------------------------------------------------------------------

    /// Returns the preimage of the block's sub commitment as a sequence of field elements.
    ///
    /// This covers every header field except the note root. See [`BlockHeader::to_elements`] for
    /// the element layout.
    #[allow(clippy::too_many_arguments)]
    fn to_sub_elements(
        version: u8,
        prev_block_commitment: Word,
        block_num: BlockNumber,
        chain_commitment: Word,
        account_root: Word,
        nullifier_root: Word,
        tx_commitment: Word,
        validator_config: &ValidatorConfig,
        fee_parameters: &FeeParameters,
        protocol_config_commitment: Word,
        next_protocol_config: Option<&NextProtocolConfig>,
        timestamp: u32,
    ) -> Vec<Felt> {
        let mut elements: Vec<Felt> = Vec::with_capacity(Self::NUM_SUB_COMMITMENT_ELEMENTS);
        elements.extend([Felt::from(version), block_num.into(), Felt::from(timestamp), ZERO]);
        elements.extend_from_slice(prev_block_commitment.as_elements());
        elements.extend_from_slice(chain_commitment.as_elements());
        elements.extend_from_slice(account_root.as_elements());
        elements.extend_from_slice(nullifier_root.as_elements());
        elements.extend_from_slice(tx_commitment.as_elements());
        elements.extend_from_slice(protocol_config_commitment.as_elements());
        elements.extend(validator_config.to_commitment());
        elements.extend(Self::compute_next_protocol_config_commitment(next_protocol_config));
        elements.extend([Felt::from(fee_parameters.verification_base_fee()), ZERO, ZERO, ZERO]);
        elements
    }

    /// Returns the commitment to `next_protocol_config`, or [`Word::empty`] if no upgrade is
    /// scheduled.
    fn compute_next_protocol_config_commitment(
        next_protocol_config: Option<&NextProtocolConfig>,
    ) -> Word {
        next_protocol_config.map_or(Word::empty(), NextProtocolConfig::to_commitment)
    }

    // TEST HELPERS
    // --------------------------------------------------------------------------------------------

    /// Builds a minimal block header with a controllable block number, previous-block commitment,
    /// and validator key set.
    ///
    /// The remaining roots are zeroed except the note root and transaction commitment, which match
    /// the empty [`BlockBody`](super::BlockBody) the block tests pair this header with, so the
    /// self-consistency checks in `SignedBlock::validate` and  `ProvenBlock::validate` pass.
    #[cfg(test)]
    pub(crate) fn new_dummy(
        block_num: u32,
        prev_block_commitment: Word,
        validator_config: ValidatorConfig,
    ) -> Self {
        use crate::block::{BlockBody, FeeParameters};
        use crate::transaction::OrderedTransactionHeaders;

        let body = BlockBody::new_unchecked(
            Vec::new(),
            Vec::new(),
            Vec::new(),
            OrderedTransactionHeaders::new_unchecked(Vec::new()),
        );
        let note_root = body.compute_block_note_tree().root();
        let tx_commitment = body.transactions().commitment();

        BlockHeader::new(
            prev_block_commitment,
            BlockNumber::from(block_num),
            Word::empty(),
            Word::empty(),
            Word::empty(),
            note_root,
            tx_commitment,
            validator_config,
            FeeParameters::new(500),
            Word::empty(),
            None,
            0,
        )
    }
}

// SERIALIZATION
// ================================================================================================

impl Serializable for BlockHeader {
    fn write_into<W: ByteWriter>(&self, target: &mut W) {
        let Self {
            version,
            prev_block_commitment,
            block_num,
            chain_commitment,
            account_root,
            nullifier_root,
            note_root,
            tx_commitment,
            validator_config,
            fee_parameters,
            protocol_config_commitment,
            next_protocol_config,
            timestamp,
            // Don't serialize sub commitment and commitment as they can be derived.
            sub_commitment: _,
            commitment: _,
        } = self;

        version.write_into(target);
        prev_block_commitment.write_into(target);
        block_num.write_into(target);
        chain_commitment.write_into(target);
        account_root.write_into(target);
        nullifier_root.write_into(target);
        note_root.write_into(target);
        tx_commitment.write_into(target);
        validator_config.write_into(target);
        fee_parameters.write_into(target);
        protocol_config_commitment.write_into(target);
        next_protocol_config.write_into(target);
        timestamp.write_into(target);
    }
}

impl Deserializable for BlockHeader {
    fn read_from<R: ByteReader>(source: &mut R) -> Result<Self, DeserializationError> {
        let version = u8::read_from(source)?;

        if version != Self::VERSION_1 {
            return Err(DeserializationError::InvalidValue(format!(
                "block version is {} but only version {} is supported",
                version,
                Self::VERSION_1,
            )));
        }

        let prev_block_commitment = source.read()?;
        let block_num = source.read()?;
        let chain_commitment = source.read()?;
        let account_root = source.read()?;
        let nullifier_root = source.read()?;
        let note_root = source.read()?;
        let tx_commitment = source.read()?;
        let validator_config = source.read()?;
        let fee_parameters = source.read()?;
        let protocol_config_commitment = source.read()?;
        let next_protocol_config = <Option<NextProtocolConfig>>::read_from(source)?;
        let timestamp = source.read()?;

        Ok(Self::new(
            prev_block_commitment,
            block_num,
            chain_commitment,
            account_root,
            nullifier_root,
            note_root,
            tx_commitment,
            validator_config,
            fee_parameters,
            protocol_config_commitment,
            next_protocol_config,
            timestamp,
        ))
    }
}

// FEE PARAMETERS
// ================================================================================================

/// The fee-related parameters of a block.
///
/// This defines how to compute the fees of a transaction. Which asset fees are paid in is defined
/// by [`ProtocolConfig::fee_asset_id`](crate::protocol_config::ProtocolConfig::fee_asset_id).
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct FeeParameters {
    /// The base fee (in base units) capturing the cost for the verification of a transaction.
    verification_base_fee: u32,
}

impl FeeParameters {
    // CONSTRUCTORS
    // --------------------------------------------------------------------------------------------

    /// Creates [`FeeParameters`] from the provided inputs.
    pub fn new(verification_base_fee: u32) -> Self {
        Self { verification_base_fee }
    }

    // PUBLIC ACCESSORS
    // --------------------------------------------------------------------------------------------

    /// Returns the base fee capturing the cost for the verification of a transaction.
    pub fn verification_base_fee(&self) -> u32 {
        self.verification_base_fee
    }
}

impl Serializable for FeeParameters {
    fn write_into<W: ByteWriter>(&self, target: &mut W) {
        let Self { verification_base_fee } = self;

        verification_base_fee.write_into(target);
    }
}

impl Deserializable for FeeParameters {
    fn read_from<R: ByteReader>(source: &mut R) -> Result<Self, DeserializationError> {
        let verification_base_fee = source.read()?;

        Ok(Self::new(verification_base_fee))
    }
}

// PARENT VALIDATION ERROR
// ================================================================================================

/// Error returned when a block fails validation against its parent block.
///
/// This is the shared, block-type-agnostic error produced by
/// [`BlockHeader::validate_against_parent`]. Each block type maps it into its own error enum via
/// `From`, which preserves that type's specific error messages.
#[derive(Debug)]
pub(crate) enum ParentValidationError {
    SignatureCountMismatch {
        expected: usize,
        actual: usize,
    },
    InvalidSignatureAtPosition {
        position: usize,
    },
    ParentNumberMismatch {
        expected: BlockNumber,
        parent: BlockNumber,
    },
    ParentCommitmentMismatch {
        expected: Word,
        parent: Word,
    },
    GenesisBlockHasNoParent {
        parent: BlockNumber,
    },
}

// TESTS
// ================================================================================================

#[cfg(test)]
mod tests {
    use assert_matches::assert_matches;
    use miden_core::Word;
    use miden_crypto::rand::test_utils::rand_value;

    use super::*;

    #[test]
    fn block_header_deserialization_rejects_unsupported_version() {
        let error = BlockHeader::read_from_bytes(&[0]).unwrap_err();

        assert_matches!(error, DeserializationError::InvalidValue(message) => {
            assert!(message.contains("block version is 0"));
        });
    }

    #[test]
    fn test_serde() {
        let chain_commitment = rand_value::<Word>();
        let note_root = rand_value::<Word>();
        let header = BlockHeader::mock(0, Some(chain_commitment), Some(note_root), &[]);
        let serialized = header.to_bytes();
        let deserialized = BlockHeader::read_from_bytes(&serialized).unwrap();

        assert_eq!(deserialized, header);
    }

    /// Returns `header` with a protocol upgrade scheduled for block 42.
    fn with_scheduled_upgrade(header: &BlockHeader) -> BlockHeader {
        let next_protocol_config =
            NextProtocolConfig::new(BlockNumber::from(42u32), rand_value::<Word>()).unwrap();

        BlockHeader::new(
            header.prev_block_commitment(),
            header.block_num(),
            header.chain_commitment(),
            header.account_root(),
            header.nullifier_root(),
            header.note_root(),
            header.tx_commitment(),
            header.validator_config().clone(),
            header.fee_parameters().clone(),
            header.protocol_config_commitment(),
            Some(next_protocol_config),
            header.timestamp(),
        )
    }

    #[test]
    fn scheduled_upgrade_round_trips_and_changes_the_commitment() {
        let without_upgrade = BlockHeader::mock(0, None, None, &[]);
        let with_upgrade = with_scheduled_upgrade(&without_upgrade);

        assert_eq!(without_upgrade.next_protocol_config_commitment(), Word::empty());
        assert_ne!(with_upgrade.commitment(), without_upgrade.commitment());

        let deserialized = BlockHeader::read_from_bytes(&with_upgrade.to_bytes()).unwrap();
        assert_eq!(deserialized, with_upgrade);
    }

    /// The header's element encoding is the single definition of the block data layout, used by
    /// both the commitment and the kernel's advice inputs. This checks the two stay in agreement.
    #[test]
    fn to_elements_is_the_sub_commitment_preimage_plus_the_note_root() {
        let header = BlockHeader::mock(0, None, None, &[]);
        let elements = header.to_elements();

        let (sub_elements, note_root) = elements.split_at(BlockHeader::NUM_SUB_COMMITMENT_ELEMENTS);
        assert_eq!(Hasher::hash_elements(sub_elements), header.sub_commitment());
        assert_eq!(note_root, header.note_root().as_elements());
    }

    /// Builds a child of `parent` committing a fresh validator set of `next_count` validators as
    /// the signer of the *next* block.
    fn child_of(parent: &BlockHeader, child_num: u32, next_count: usize) -> BlockHeader {
        let (_, next_keys) = ValidatorConfig::random_with_signers(next_count);
        BlockHeader::new_dummy(child_num, parent.commitment(), next_keys)
    }

    #[test]
    fn validate_against_parent_accepts_all_signatures() {
        let (signers, keys) = ValidatorConfig::random_with_signers(5);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        let child = child_of(&parent, 1, 5);
        let signatures = keys.sign_all(&signers, child.commitment());

        child.validate_against_parent(&parent, &signatures).unwrap();
    }

    #[test]
    fn validate_against_parent_accepts_single_validator() {
        let (signers, keys) = ValidatorConfig::random_with_signers(1);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        let child = child_of(&parent, 1, 1);
        let signatures = keys.sign_all(&signers, child.commitment());

        child.validate_against_parent(&parent, &signatures).unwrap();
    }

    #[test]
    fn validate_against_parent_rejects_incomplete_signatures() {
        let (signers, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        let child = child_of(&parent, 1, 3);
        // Only one of three validators signs, so the resulting set is too short to align
        // positionally with the parent's validator keys. `BlockSignatures::new` does not check
        // this -- only `verify_against` (called by `validate_against_parent`) does.
        let signatures =
            BlockSignatures::new(alloc::vec![signers[0].sign(child.commitment())]).unwrap();

        let result = child.validate_against_parent(&parent, &signatures);
        assert!(matches!(
            result,
            Err(ParentValidationError::SignatureCountMismatch { expected: 3, actual: 1 })
        ));
    }

    #[test]
    fn validate_against_parent_rejects_signature_count_mismatch() {
        let (_, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        let child = child_of(&parent, 1, 3);

        // A block signed by a validator set of a different size cannot align positionally with the
        // parent's committed set. Deserialization does not check this, so build it directly.
        let (other_signers, other_keys) = ValidatorConfig::random_with_signers(4);
        let signatures = other_keys.sign_all(&other_signers, child.commitment());
        let bytes = signatures.to_bytes();
        let deserialized = BlockSignatures::read_from_bytes(&bytes).unwrap();

        let result = child.validate_against_parent(&parent, &deserialized);
        assert!(matches!(
            result,
            Err(ParentValidationError::SignatureCountMismatch { expected: 3, actual: 4 })
        ));
    }

    #[test]
    fn validate_against_parent_rejects_uncommitted_signatures() {
        let (_, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        let child = child_of(&parent, 1, 3);

        // The child is signed by a full, valid validator set of the same size the parent never
        // committed, so the signatures do not verify against the parent's validator keys.
        let (impostor_signers, impostor_keys) = ValidatorConfig::random_with_signers(3);
        let signatures = impostor_keys.sign_all(&impostor_signers, child.commitment());

        let result = child.validate_against_parent(&parent, &signatures);
        assert!(matches!(result, Err(ParentValidationError::InvalidSignatureAtPosition { .. })));
    }

    #[test]
    fn validate_against_parent_rejects_genesis() {
        let (signers, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        // Block 0 has no parent to anchor against.
        let child = BlockHeader::new_dummy(
            0,
            parent.commitment(),
            ValidatorConfig::random_with_signers(3).1,
        );
        let signatures = keys.sign_all(&signers, child.commitment());

        let result = child.validate_against_parent(&parent, &signatures);
        assert!(matches!(result, Err(ParentValidationError::GenesisBlockHasNoParent { .. })));
    }

    #[test]
    fn validate_against_parent_rejects_wrong_parent_number() {
        let (signers, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        // Child claims to be block 2, but the parent is block 0.
        let child = child_of(&parent, 2, 3);
        let signatures = keys.sign_all(&signers, child.commitment());

        let result = child.validate_against_parent(&parent, &signatures);
        assert!(matches!(result, Err(ParentValidationError::ParentNumberMismatch { .. })));
    }

    #[test]
    fn validate_against_parent_rejects_wrong_parent_commitment() {
        let (signers, keys) = ValidatorConfig::random_with_signers(3);
        let parent = BlockHeader::new_dummy(0, Word::empty(), keys.clone());
        // Child does not link to the parent's commitment.
        let child =
            BlockHeader::new_dummy(1, Word::empty(), ValidatorConfig::random_with_signers(3).1);
        let signatures = keys.sign_all(&signers, child.commitment());

        let result = child.validate_against_parent(&parent, &signatures);
        assert!(matches!(result, Err(ParentValidationError::ParentCommitmentMismatch { .. })));
    }
}