miden-processor 0.32.1

use alloc::{collections::BTreeMap, sync::Arc, vec::Vec};

use miden_air::trace::chiplets::hasher::{
    CONTROLLER_ROWS_PER_PERM_FELT, CONTROLLER_ROWS_PER_PERMUTATION, STATE_WIDTH,
};
use miden_core::{
    FMP_ADDR, FMP_INIT_VALUE,
    operations::Operation,
    serde::{ByteReader, ByteWriter, Deserializable, DeserializationError, Serializable},
};

use super::{
    block_stack::{BlockInfo, BlockStack, ExecutionContextInfo},
    stack::OverflowTable,
    trace_state::{
        AceReplay, AdviceReplay, BitwiseReplay, BlockAddressReplay, BlockStackReplay,
        CoreTraceFragmentContext, CoreTraceState, DecoderState, ExecutionContextReplay,
        ExecutionContextSystemInfo, ExecutionReplay, HasherRequestReplay, HasherResponseReplay,
        KernelReplay, MastForestResolutionReplay, MemoryReadsReplay, MemoryWritesReplay,
        RangeCheckerReplay, StackOverflowReplay, StackState, SystemState,
    },
    utils::split_u32_into_u16,
};
use crate::{
    ContextId, EMPTY_WORD, ExecutionError, FastProcessor, Felt, MIN_STACK_DEPTH, ONE, RowIndex,
    Word, ZERO,
    continuation_stack::{Continuation, ContinuationStack},
    crypto::merkle::MerklePath,
    mast::{
        BasicBlockNode, JoinNode, LoopNode, MastForest, MastForestId, MastNode, MastNodeExt,
        MastNodeId, SparseMastForest, SparseMastForestBuilder, SplitNode, VisitKind,
    },
    processor::{Processor, StackInterface, SystemInterface},
    trace::chiplets::{CircuitEvaluation, PTR_OFFSET_ELEM, PTR_OFFSET_WORD},
    tracer::{OperationHelperRegisters, Tracer},
    utils::Idx,
};

// STATE SNAPSHOT
// ================================================================================================

/// Execution state snapshot, used to record the state at the start of a trace fragment.
#[derive(Debug)]
struct StateSnapshot {
    state: CoreTraceState,
    /// Continuation stack with forest references already translated to [`MastForestId`]s into the
    /// `mast_forest_store` of the [`TraceReplay`] being built.
    continuation_stack: ContinuationStack<MastForestId>,
    /// The active forest at the start of this fragment, in `mast_forest_store`.
    initial_mast_forest_id: MastForestId,
}

// TRACE REPLAY
// ================================================================================================

#[derive(Debug)]
pub(crate) struct TraceReplay {
    /// The list of trace fragment contexts built during execution.
    pub(crate) core_trace_contexts: Vec<CoreTraceFragmentContext>,

    /// Sparse MAST forests, one per source [`MastForest`] visited during execution.
    ///
    /// Each entry contains only the [`MastNode`]s that were actually visited, while preserving the
    /// original [`MastNodeId`]s of the source forest. References from `CoreTraceFragmentContext`,
    /// `MastForestResolutionReplay`, and `HasherOp::HashBasicBlock` are encoded as
    /// [`MastForestId`]s into this vector.
    ///
    /// Serialized entries are trusted sparse replay data. Their node and digest maps are not
    /// checked against a source [`MastForest`] commitment on read; see
    /// <https://github.com/0xMiden/miden-vm/issues/3303>.
    pub(crate) mast_forest_store: Vec<Arc<SparseMastForest>>,

    // Replays that contain additional data needed to generate the range checker and chiplets
    // columns.
    pub(crate) range_checker_replay: RangeCheckerReplay,
    pub(crate) memory_writes: MemoryWritesReplay,
    pub(crate) bitwise_replay: BitwiseReplay,
    pub(crate) hasher_for_chiplet: HasherRequestReplay,
    pub(crate) kernel_replay: KernelReplay,
    pub(crate) ace_replay: AceReplay,

    /// The number of rows per core trace fragment, except for the last fragment which may be
    /// shorter.
    pub(crate) fragment_size: usize,

    /// The maximum number of field elements allowed on the operand stack in an active execution
    /// context.
    pub(crate) max_stack_depth: usize,
}

impl Serializable for TraceReplay {
    fn write_into<W: ByteWriter>(&self, target: &mut W) {
        target.write_usize(self.mast_forest_store.len());
        for forest in &self.mast_forest_store {
            forest.write_into(target);
        }
        self.core_trace_contexts.write_into(target);
        self.range_checker_replay.write_into(target);
        self.memory_writes.write_into(target);
        self.bitwise_replay.write_into(target);
        self.hasher_for_chiplet.write_into(target);
        self.kernel_replay.write_into(target);
        self.ace_replay.write_into(target);
        self.fragment_size.write_into(target);
        self.max_stack_depth.write_into(target);
    }
}

impl Deserializable for TraceReplay {
    fn read_from<R: ByteReader>(source: &mut R) -> Result<Self, DeserializationError> {
        let store_len = source.read_usize()?;
        let max_store_len = source.max_alloc(SparseMastForest::min_serialized_size());
        if store_len > max_store_len {
            return Err(DeserializationError::InvalidValue(format!(
                "MAST forest store length {store_len} exceeds reader allocation bound {max_store_len}"
            )));
        }

        let mut mast_forest_store = Vec::with_capacity(store_len);
        for _ in 0..store_len {
            mast_forest_store.push(Arc::new(SparseMastForest::read_from(source)?));
        }

        let context = Self {
            mast_forest_store,
            core_trace_contexts: Vec::<CoreTraceFragmentContext>::read_from(source)?,
            range_checker_replay: RangeCheckerReplay::read_from(source)?,
            memory_writes: MemoryWritesReplay::read_from(source)?,
            bitwise_replay: BitwiseReplay::read_from(source)?,
            hasher_for_chiplet: HasherRequestReplay::read_from(source)?,
            kernel_replay: KernelReplay::read_from(source)?,
            ace_replay: AceReplay::read_from(source)?,
            fragment_size: usize::read_from(source)?,
            max_stack_depth: usize::read_from(source)?,
        };
        validate_trace_generation_context_invariants(&context)?;
        validate_trace_generation_context_forest_ids(&context)?;
        Ok(context)
    }
}

fn validate_trace_generation_context_invariants(
    context: &TraceReplay,
) -> Result<(), DeserializationError> {
    if context.fragment_size == 0 {
        return Err(DeserializationError::InvalidValue(
            "trace generation fragment_size must be non-zero".into(),
        ));
    }
    if context.max_stack_depth < MIN_STACK_DEPTH {
        return Err(DeserializationError::InvalidValue(format!(
            "trace generation max_stack_depth {} is below minimum {MIN_STACK_DEPTH}",
            context.max_stack_depth
        )));
    }
    for (fragment_index, fragment) in context.core_trace_contexts.iter().enumerate() {
        let stack_depth = fragment.state.stack.stack_depth();
        if stack_depth > context.max_stack_depth {
            return Err(DeserializationError::InvalidValue(format!(
                "fragment {fragment_index}: stack depth {stack_depth} exceeds max_stack_depth {}",
                context.max_stack_depth
            )));
        }
    }
    Ok(())
}

fn validate_trace_generation_context_forest_ids(
    context: &TraceReplay,
) -> Result<(), DeserializationError> {
    let store_len = context.mast_forest_store.len();
    for (fragment_index, fragment) in context.core_trace_contexts.iter().enumerate() {
        validate_mast_forest_id(
            fragment.initial_mast_forest_id,
            store_len,
            "core trace fragment initial_mast_forest_id",
        )?;
        for forest_id in fragment.continuation.iter_enter_forest_ids() {
            validate_mast_forest_id(
                forest_id,
                store_len,
                "core trace fragment continuation EnterForest",
            )
            .map_err(|err| {
                DeserializationError::InvalidValue(format!("fragment {fragment_index}: {err}"))
            })?;
        }
        for forest_id in fragment.replay.mast_forest_resolution.iter_forest_ids() {
            validate_mast_forest_id(
                forest_id,
                store_len,
                "core trace fragment MastForestResolutionReplay",
            )
            .map_err(|err| {
                DeserializationError::InvalidValue(format!("fragment {fragment_index}: {err}"))
            })?;
        }
    }

    for forest_id in context.hasher_for_chiplet.iter_hash_basic_block_forest_ids() {
        validate_mast_forest_id(forest_id, store_len, "hasher HashBasicBlock replay")?;
    }

    Ok(())
}

fn validate_mast_forest_id(
    forest_id: MastForestId,
    store_len: usize,
    label: &str,
) -> Result<(), DeserializationError> {
    if forest_id.to_usize() >= store_len {
        return Err(DeserializationError::InvalidValue(format!(
            "{label} id {} is out of range for mast_forest_store length {store_len}",
            u32::from(forest_id)
        )));
    }
    Ok(())
}

/// Builder for recording the context to generate trace fragments during execution.
///
/// Specifically, this records the information necessary to be able to generate the trace in
/// fragments of configurable length. This requires storing state at the very beginning of the
/// fragment before any operations are executed, as well as recording the various values read during
/// execution in the corresponding "replays" (e.g. values read from memory are recorded in
/// `MemoryReadsReplay`, values read from the advice provider are recorded in `AdviceReplay``, etc).
///
/// Then, to generate a trace fragment, we initialize the state of the processor using the stored
/// snapshot from the beginning of the fragment, and replay the recorded values as they are
/// encountered during execution (e.g. when encountering a memory read operation, we will replay the
/// value rather than querying the memory chiplet).
#[derive(Debug)]
pub struct ExecutionTracer {
    // State stored at the start of a core trace fragment.
    //
    // This field is only set to `None` at initialization, and is populated when starting a new
    // trace fragment with `Self::start_new_fragment_context()`. Hence, on the first call to
    // `Self::start_new_fragment_context()`, we don't extract a new `TraceFragmentContext`, but in
    // every other call, we do.
    state_snapshot: Option<StateSnapshot>,

    // Replay data aggregated throughout the execution of a core trace fragment
    overflow_table: OverflowTable,
    overflow_replay: StackOverflowReplay,

    block_stack: BlockStack,
    block_stack_replay: BlockStackReplay,
    execution_context_replay: ExecutionContextReplay,

    hasher_chiplet_shim: HasherChipletShim,
    memory_reads: MemoryReadsReplay,
    advice: AdviceReplay,
    external: MastForestResolutionReplay,

    // Replays that contain additional data needed to generate the range checker and chiplets
    // columns.
    range_checker: RangeCheckerReplay,
    memory_writes: MemoryWritesReplay,
    bitwise: BitwiseReplay,
    kernel: KernelReplay,
    hasher_for_chiplet: HasherRequestReplay,
    ace: AceReplay,

    // Output
    fragment_contexts: Vec<CoreTraceFragmentContext>,

    /// Per-source-forest sparse builders, indexed by `mast_forest_indices`.
    ///
    /// Each builder accumulates the [`MastNodeId`]s of nodes visited inside its source forest
    /// during execution, and is finalized into an [`Arc<SparseMastForest>`] in
    /// [`Self::into_trace_replay`].
    mast_forest_builders: Vec<SparseMastForestBuilder>,

    /// Maps a source forest's `Arc::as_ptr` identity to its [`MastForestId`] in
    /// `mast_forest_builders` (and, by construction, the eventual id in
    /// `TraceReplay::mast_forest_store`).
    ///
    /// Pointer identity is sound here because the trace-generation flow never crosses a process
    /// boundary: the tracer builds the store and the replay processor consumes it in the same
    /// run.
    mast_forest_ids: BTreeMap<*const MastForest, MastForestId>,

    /// The number of rows per core trace fragment.
    fragment_size: usize,

    /// The maximum number of field elements allowed on the operand stack in an active execution
    /// context.
    max_stack_depth: usize,

    /// Flag set in `start_clock_cycle` when a Call/Syscall/Dyncall END is encountered, consumed
    /// in `finalize_clock_cycle` to call `overflow_table.restore_context()`. This is deferred to
    /// `finalize_clock_cycle` because `finalize_clock_cycle` is only called when the operation
    /// succeeds (i.e., the stack depth check passes).
    pending_restore_context: bool,

    /// Flag set in `start_clock_cycle` when an `EvalCircuit` operation is encountered, consumed
    /// in `finalize_clock_cycle` to record the memory reads performed by the operation.
    is_eval_circuit_op: bool,
}

impl ExecutionTracer {
    /// Creates a tracer whose hasher-chiplet requests stream to `hasher_sender` as they are
    /// recorded, instead of buffering for post-execution replay. Everything else records as in
    /// [`Self::new`].
    #[cfg(feature = "std")]
    pub(crate) fn new_with_streamed_hasher(
        fragment_size: usize,
        max_stack_depth: usize,
        hasher_sender: std::sync::mpsc::Sender<crate::trace::ResolvedHasherOp<'static>>,
    ) -> Self {
        let mut tracer = Self::new(fragment_size, max_stack_depth);
        tracer.hasher_for_chiplet = HasherRequestReplay::streamed(hasher_sender);
        tracer
    }

    /// Creates a new `ExecutionTracer` with the given fragment size.
    #[inline(always)]
    pub fn new(fragment_size: usize, max_stack_depth: usize) -> Self {
        Self {
            state_snapshot: None,
            overflow_table: OverflowTable::default(),
            overflow_replay: StackOverflowReplay::default(),
            block_stack: BlockStack::default(),
            block_stack_replay: BlockStackReplay::default(),
            execution_context_replay: ExecutionContextReplay::default(),
            hasher_chiplet_shim: HasherChipletShim::default(),
            memory_reads: MemoryReadsReplay::default(),
            range_checker: RangeCheckerReplay::default(),
            memory_writes: MemoryWritesReplay::default(),
            advice: AdviceReplay::default(),
            bitwise: BitwiseReplay::default(),
            kernel: KernelReplay::default(),
            hasher_for_chiplet: HasherRequestReplay::default(),
            ace: AceReplay::default(),
            external: MastForestResolutionReplay::default(),
            fragment_contexts: Vec::new(),
            mast_forest_builders: Vec::new(),
            mast_forest_ids: BTreeMap::new(),
            fragment_size,
            max_stack_depth,
            pending_restore_context: false,
            is_eval_circuit_op: false,
        }
    }

    /// Returns the [`MastForestId`] of `forest` in [`Self::mast_forest_builders`], creating a new
    /// builder for it on first encounter. Forests are identified by `Arc::as_ptr`.
    #[inline]
    fn forest_id(&mut self, forest: &Arc<MastForest>) -> MastForestId {
        let key = Arc::as_ptr(forest);
        if let Some(&id) = self.mast_forest_ids.get(&key) {
            return id;
        }

        let id = MastForestId::from(self.mast_forest_builders.len() as u32);
        self.mast_forest_builders.push(SparseMastForestBuilder::new(forest.clone()));
        self.mast_forest_ids.insert(key, id);
        id
    }

    /// Records that the node with id `node_id` was visited inside `forest`. Also records the
    /// node's immediate children (if any) as digest-only references.
    ///
    /// The parent is recorded as a [`VisitKind::FullVisit`] so its full [`MastNode`] is available
    /// at replay time. Children are recorded as [`VisitKind::DigestOnly`] because trace
    /// generation only needs their digest when building the parent's trace row (e.g. a Split
    /// node needs the digest of *both* branches even if only one is taken; a Join needs both
    /// children's digests; a Call needs the callee's digest). If a child is later actually
    /// entered, a subsequent `record_visit` call promotes it to a full visit.
    ///
    /// Keeping un-entered children as digest-only means accidental entry into a pruned node
    /// surfaces as a clean `get_node_by_id` miss rather than a partially-populated node.
    #[inline]
    fn record_visit(&mut self, forest: &Arc<MastForest>, node_id: MastNodeId) {
        let id = self.forest_id(forest);
        self.mast_forest_builders[id.to_usize()].record_visit(node_id, VisitKind::FullVisit);

        if let Some(node) = forest.get_node_by_id(node_id) {
            node.for_each_child(|child_id| {
                self.mast_forest_builders[id.to_usize()]
                    .record_visit(child_id, VisitKind::DigestOnly);
            });
        }
    }

    /// Translates a live continuation stack carrying `Arc<MastForest>` references into one carrying
    /// [`MastForestId`]s into `mast_forest_builders`.
    fn translate_continuation_stack(
        &mut self,
        live: ContinuationStack<Arc<MastForest>>,
    ) -> ContinuationStack<MastForestId> {
        let mut translated: ContinuationStack<MastForestId> = ContinuationStack::default();
        for cont in live.into_inner() {
            let translated_cont = match cont {
                Continuation::EnterForest {
                    forest,
                    package_debug_info,
                    inline_context_depth,
                } => Continuation::EnterForest {
                    forest: self.forest_id(&forest),
                    package_debug_info,
                    inline_context_depth,
                },
                Continuation::StartNode(id) => Continuation::StartNode(id),
                Continuation::FinishJoin(id) => Continuation::FinishJoin(id),
                Continuation::FinishSplit(id) => Continuation::FinishSplit(id),
                Continuation::FinishLoop(node_id) => Continuation::FinishLoop(node_id),
                Continuation::FinishCall(id) => Continuation::FinishCall(id),
                Continuation::FinishDyn(id) => Continuation::FinishDyn(id),
                Continuation::ResumeBasicBlock { node_id, batch_index, op_idx_in_batch } => {
                    Continuation::ResumeBasicBlock { node_id, batch_index, op_idx_in_batch }
                },
                Continuation::Respan { node_id, batch_index } => {
                    Continuation::Respan { node_id, batch_index }
                },
                Continuation::FinishBasicBlock(id) => Continuation::FinishBasicBlock(id),
            };
            translated.push_continuation(translated_cont);
        }
        translated
    }

    /// Converts the `ExecutionTracer` into a [`TraceReplay`] using the data accumulated during
    /// execution.
    #[inline(always)]
    pub(crate) fn into_trace_replay(mut self) -> TraceReplay {
        // If there is an ongoing trace state being built, finish it
        self.finish_current_fragment_context();

        // Finalize each per-source-forest builder into a `SparseMastForest`. Indices stored on
        // fragments and replays line up with the position in this vector by construction (the
        // builders were appended in the same order the indices were assigned).
        let mast_forest_store = self
            .mast_forest_builders
            .into_iter()
            .map(|builder| Arc::new(builder.finalize()))
            .collect();

        TraceReplay {
            core_trace_contexts: self.fragment_contexts,
            mast_forest_store,
            range_checker_replay: self.range_checker,
            memory_writes: self.memory_writes,
            bitwise_replay: self.bitwise,
            kernel_replay: self.kernel,
            hasher_for_chiplet: self.hasher_for_chiplet,
            ace_replay: self.ace,
            fragment_size: self.fragment_size,
            max_stack_depth: self.max_stack_depth,
        }
    }

    // HELPERS
    // -------------------------------------------------------------------------------------------

    /// Captures the internal state into a new [TraceFragmentContext] (stored internally), resets
    /// the internal replay state of the builder, and records a new state snapshot, marking the
    /// beginning of the next trace state.
    ///
    /// This must be called at the beginning of a new trace fragment, before executing the first
    /// operation. Internal replay fields are expected to be accessed during execution of this new
    /// fragment to record data to be replayed by the trace fragment generators.
    #[inline(always)]
    fn start_new_fragment_context(
        &mut self,
        system_state: SystemState,
        stack_top: [Felt; MIN_STACK_DEPTH],
        mut continuation_stack: ContinuationStack<Arc<MastForest>>,
        continuation: Continuation<Arc<MastForest>>,
        current_forest: Arc<MastForest>,
    ) {
        // If there is an ongoing snapshot, finish it
        self.finish_current_fragment_context();

        // Start a new snapshot
        let decoder_state = {
            if self.block_stack.is_empty() {
                DecoderState { current_addr: ZERO, parent_addr: ZERO }
            } else {
                let block_info = self.block_stack.peek();

                DecoderState {
                    current_addr: block_info.addr,
                    parent_addr: block_info.parent_addr,
                }
            }
        };
        let stack = {
            let stack_depth = MIN_STACK_DEPTH + self.overflow_table.num_elements_in_current_ctx();
            let last_overflow_addr = self.overflow_table.last_update_clk_in_current_ctx();
            StackState::new(stack_top, stack_depth, last_overflow_addr)
        };

        // Push new continuation corresponding to the current execution state
        continuation_stack.push_continuation(continuation);

        // Translate the live `Arc<MastForest>`-bearing continuation stack into one indexed by
        // `MastForestId` into `mast_forest_builders`, registering any newly-encountered forests
        // along the way.
        let initial_mast_forest_id = self.forest_id(&current_forest);
        let translated_stack = self.translate_continuation_stack(continuation_stack);

        self.state_snapshot = Some(StateSnapshot {
            state: CoreTraceState {
                system: system_state,
                decoder: decoder_state,
                stack,
            },
            continuation_stack: translated_stack,
            initial_mast_forest_id,
        });
    }

    #[inline(always)]
    fn record_control_node_start<P: Processor>(
        &mut self,
        node: &MastNode,
        processor: &P,
        current_forest: &MastForest,
    ) {
        let ctx_info = match node {
            MastNode::Join(node) => {
                let child1_hash = current_forest
                    .get_node_by_id(node.first())
                    .expect("join node's first child expected to be in the forest")
                    .digest();
                let child2_hash = current_forest
                    .get_node_by_id(node.second())
                    .expect("join node's second child expected to be in the forest")
                    .digest();
                self.hasher_for_chiplet.record_hash_control_block(
                    child1_hash,
                    child2_hash,
                    JoinNode::DOMAIN,
                    node.digest(),
                );

                None
            },
            MastNode::Split(node) => {
                let child1_hash = current_forest
                    .get_node_by_id(node.on_true())
                    .expect("split node's true child expected to be in the forest")
                    .digest();
                let child2_hash = current_forest
                    .get_node_by_id(node.on_false())
                    .expect("split node's false child expected to be in the forest")
                    .digest();
                self.hasher_for_chiplet.record_hash_control_block(
                    child1_hash,
                    child2_hash,
                    SplitNode::DOMAIN,
                    node.digest(),
                );

                None
            },
            MastNode::Loop(node) => {
                let body_hash = current_forest
                    .get_node_by_id(node.body())
                    .expect("loop node's body expected to be in the forest")
                    .digest();

                self.hasher_for_chiplet.record_hash_control_block(
                    body_hash,
                    EMPTY_WORD,
                    LoopNode::DOMAIN,
                    node.digest(),
                );

                None
            },
            MastNode::Call(node) => {
                let callee_hash = current_forest
                    .get_node_by_id(node.callee())
                    .expect("call node's callee expected to be in the forest")
                    .digest();

                self.hasher_for_chiplet.record_hash_control_block(
                    callee_hash,
                    EMPTY_WORD,
                    node.domain(),
                    node.digest(),
                );

                let overflow_addr = self.overflow_table.last_update_clk_in_current_ctx();
                Some(ExecutionContextInfo::new(
                    processor.system().ctx(),
                    processor.system().caller_hash(),
                    processor.stack().depth(),
                    overflow_addr,
                ))
            },
            MastNode::Dyn(dyn_node) => {
                self.hasher_for_chiplet.record_hash_control_block(
                    EMPTY_WORD,
                    EMPTY_WORD,
                    dyn_node.domain(),
                    dyn_node.digest(),
                );

                if dyn_node.is_dyncall() {
                    // DYNCALL drops the top stack element (the memory address holding the
                    // callee hash) and records the stack state *after* the drop as the new
                    // context.
                    //
                    // `record_control_node_start()` is called *before* `decrement_stack_size()`,
                    // so we must compute the post-drop overflow address without actually
                    // performing the pop.  We use `clk_after_pop_in_current_ctx()` which
                    // returns the clock of the second-to-last overflow entry (i.e. what
                    // `last_update_clk_in_current_ctx()` would return after the pop), or ZERO
                    // when the overflow stack has ≤1 entry and would become empty.
                    //
                    // When the stack is already at MIN_STACK_DEPTH the drop does not reduce
                    // the depth and the overflow address is ZERO — mirroring the same guard
                    // already present in the parallel-tracer path.  See #2813 / PR #2904.
                    let (stack_depth_after_drop, overflow_addr) =
                        if processor.stack().depth() > MIN_STACK_DEPTH as u32 {
                            (
                                processor.stack().depth() - 1,
                                self.overflow_table.clk_after_pop_in_current_ctx(),
                            )
                        } else {
                            (processor.stack().depth(), ZERO)
                        };
                    Some(ExecutionContextInfo::new(
                        processor.system().ctx(),
                        processor.system().caller_hash(),
                        stack_depth_after_drop,
                        overflow_addr,
                    ))
                } else {
                    None
                }
            },
            MastNode::Block(_) => panic!(
                "`ExecutionTracer::record_basic_block_start()` must be called instead for basic blocks"
            ),
            MastNode::External(_) => panic!(
                "External nodes are guaranteed to be resolved before record_control_node_start is called"
            ),
        };

        let block_addr = self.hasher_chiplet_shim.record_hash_control_block();
        let parent_addr = self.block_stack.push(block_addr, ctx_info);
        self.block_stack_replay.record_node_start_parent_addr(parent_addr);
    }

    /// Records the block address for an END operation based on the block being popped.
    #[inline(always)]
    fn record_node_end(&mut self, block_info: &BlockInfo) {
        let (prev_addr, prev_parent_addr) = if self.block_stack.is_empty() {
            (ZERO, ZERO)
        } else {
            let prev_block = self.block_stack.peek();
            (prev_block.addr, prev_block.parent_addr)
        };
        self.block_stack_replay
            .record_node_end(block_info.addr, prev_addr, prev_parent_addr);
    }

    /// Records the execution context system info for CALL/SYSCALL/DYNCALL operations.
    #[inline(always)]
    fn record_execution_context(&mut self, ctx_info: ExecutionContextSystemInfo) {
        self.execution_context_replay.record_execution_context(ctx_info);
    }

    /// Records the current core trace state, if any.
    ///
    /// Specifically, extracts the stored [SnapshotStart] as well as all the replay data recorded
    /// from the various components (e.g. memory, advice, etc) since the last call to this method.
    /// Resets the internal state to default values to prepare for the next trace fragment.
    ///
    /// Note that the very first time that this is called (at clock cycle 0), the snapshot will not
    /// contain any replay data, and so no core trace state will be recorded.
    #[inline(always)]
    fn finish_current_fragment_context(&mut self) {
        if let Some(snapshot) = self.state_snapshot.take() {
            // Extract the replays
            let (hasher_replay, block_addr_replay) = self.hasher_chiplet_shim.extract_replay();
            let memory_reads_replay = core::mem::take(&mut self.memory_reads);
            let advice_replay = core::mem::take(&mut self.advice);
            let external_replay = core::mem::take(&mut self.external);
            let stack_overflow_replay = core::mem::take(&mut self.overflow_replay);
            let block_stack_replay = core::mem::take(&mut self.block_stack_replay);
            let execution_context_replay = core::mem::take(&mut self.execution_context_replay);

            let trace_state = CoreTraceFragmentContext {
                state: snapshot.state,
                replay: ExecutionReplay {
                    hasher: hasher_replay,
                    block_address: block_addr_replay,
                    memory_reads: memory_reads_replay,
                    advice: advice_replay,
                    mast_forest_resolution: external_replay,
                    stack_overflow: stack_overflow_replay,
                    block_stack: block_stack_replay,
                    execution_context: execution_context_replay,
                },
                continuation: snapshot.continuation_stack,
                initial_mast_forest_id: snapshot.initial_mast_forest_id,
            };

            self.fragment_contexts.push(trace_state);
        }
    }

    /// Pushes the value at stack position 15 onto the overflow table. This must be called in
    /// `Tracer::start_clock_cycle()` *before* the processor increments the stack size, where stack
    /// position 15 at the start of the clock cycle corresponds to the element that overflows.
    #[inline(always)]
    fn increment_stack_size(&mut self, processor: &FastProcessor) {
        let new_overflow_value = processor.stack_get(15);
        self.overflow_table.push(new_overflow_value, processor.system().clock());
    }

    /// Pops a value from the overflow table and records it for replay.
    #[inline(always)]
    fn decrement_stack_size(&mut self) {
        if let Some(popped_value) = self.overflow_table.pop() {
            let new_overflow_addr = self.overflow_table.last_update_clk_in_current_ctx();
            self.overflow_replay.record_pop_overflow(popped_value, new_overflow_addr);
        }
    }
}

impl Tracer for ExecutionTracer {
    type Processor = FastProcessor;
    type Forest = Arc<MastForest>;

    /// When sufficiently many clock cycles have elapsed, starts a new trace state. Also updates the
    /// internal block stack.
    #[inline(always)]
    fn start_clock_cycle(
        &mut self,
        processor: &FastProcessor,
        continuation: Continuation<Arc<MastForest>>,
        continuation_stack: &ContinuationStack<Arc<MastForest>>,
        current_forest: &Arc<MastForest>,
    ) {
        // check if we need to start a new trace state
        if processor.system().clock().as_usize().is_multiple_of(self.fragment_size) {
            self.start_new_fragment_context(
                SystemState::from_processor(processor),
                processor
                    .stack_top()
                    .try_into()
                    .expect("stack_top expected to be MIN_STACK_DEPTH elements"),
                continuation_stack.clone(),
                continuation.clone(),
                current_forest.clone(),
            );
        }

        // Record that the node being executed at this cycle was visited inside `current_forest`.
        // This builds up the per-source-forest sparse subset used at trace generation time. Note
        // that an `ExecutionTracer`'s state is invalidated on error, so it is safe to record the
        // visit here even if the operation later fails (per Tracer invariants).
        if let Some(visited_node_id) = node_id_for_visit(&continuation) {
            self.record_visit(current_forest, visited_node_id);
        }

        match continuation {
            Continuation::ResumeBasicBlock { node_id, batch_index, op_idx_in_batch } => {
                // Update overflow table based on whether the operation increments or decrements
                // the stack size.
                let basic_block = current_forest[node_id].unwrap_basic_block();
                let op = &basic_block.op_batches()[batch_index].ops()[op_idx_in_batch];

                if op.increments_stack_size() {
                    self.increment_stack_size(processor);
                } else if op.decrements_stack_size() {
                    self.decrement_stack_size();
                }

                if matches!(op, Operation::EvalCircuit) {
                    self.is_eval_circuit_op = true;
                }
            },
            Continuation::StartNode(mast_node_id) => match &current_forest[mast_node_id] {
                MastNode::Join(_) | MastNode::Loop(_) => {
                    self.record_control_node_start(
                        &current_forest[mast_node_id],
                        processor,
                        current_forest,
                    );
                },
                MastNode::Split(_) => {
                    self.record_control_node_start(
                        &current_forest[mast_node_id],
                        processor,
                        current_forest,
                    );
                    self.decrement_stack_size();
                },
                MastNode::Call(_) => {
                    self.record_control_node_start(
                        &current_forest[mast_node_id],
                        processor,
                        current_forest,
                    );
                    self.overflow_table.start_context();
                },
                MastNode::Dyn(dyn_node) => {
                    self.record_control_node_start(
                        &current_forest[mast_node_id],
                        processor,
                        current_forest,
                    );
                    // DYN and DYNCALL both drop the memory address from the stack.
                    self.decrement_stack_size();

                    if dyn_node.is_dyncall() {
                        // Note: the overflow pop (stack size decrement above) must happen before
                        // starting the new context so that it operates on the old context's
                        // overflow table, per the semantics of dyncall.
                        self.overflow_table.start_context();
                    }
                },
                MastNode::Block(basic_block_node) => {
                    let forest_id = self.forest_id(current_forest);
                    self.hasher_for_chiplet.record_hash_basic_block(
                        forest_id,
                        mast_node_id,
                        basic_block_node,
                    );
                    let block_addr =
                        self.hasher_chiplet_shim.record_hash_basic_block(basic_block_node);
                    let parent_addr = self.block_stack.push(block_addr, None);
                    self.block_stack_replay.record_node_start_parent_addr(parent_addr);
                },
                MastNode::External(_) => unreachable!(
                    "start_clock_cycle is guaranteed not to be called on external nodes"
                ),
            },
            Continuation::Respan { node_id: _, batch_index: _ } => {
                self.block_stack.peek_mut().addr += CONTROLLER_ROWS_PER_PERM_FELT;
            },
            Continuation::FinishLoop(_) if processor.stack_get(0) == ONE => {
                // This is a REPEAT operation, which drops the condition (top element) off the stack
                self.decrement_stack_size();
            },
            Continuation::FinishJoin(_)
            | Continuation::FinishSplit(_)
            | Continuation::FinishCall(_)
            | Continuation::FinishDyn(_)
            | Continuation::FinishLoop(_) // not a REPEAT, which is handled separately above
            | Continuation::FinishBasicBlock(_) => {
                // The END of a loop drops the condition from the stack (the body always pushes it).
                if matches!(
                    &continuation,
                    Continuation::FinishLoop(_)
                ) {
                    self.decrement_stack_size();
                }

                // This is an END operation; pop the block stack and record the node end
                let block_info = self.block_stack.pop();
                self.record_node_end(&block_info);

                if let Some(ctx_info) = block_info.ctx_info {
                    self.record_execution_context(ExecutionContextSystemInfo {
                        parent_ctx: ctx_info.parent_ctx,
                        parent_fn_hash: ctx_info.parent_fn_hash,
                    });

                    self.pending_restore_context = true;
                }
            },
            Continuation::EnterForest { .. } => {
                panic!("EnterForest continuations are guaranteed not to be passed here")
            },
        }
    }

    #[inline(always)]
    fn record_mast_forest_resolution(&mut self, node_id: MastNodeId, forest: &Arc<MastForest>) {
        let forest_id = self.forest_id(forest);
        self.external.record_resolution(node_id, forest_id);
    }

    #[inline(always)]
    fn record_external_node_entered(
        &mut self,
        external_node_id: MastNodeId,
        forest: &Arc<MastForest>,
    ) {
        // External nodes don't go through `start_clock_cycle`, so we record their visit here so
        // the per-source-forest sparse builder includes them. The replay path needs the external
        // node present in the sparse forest because `execute_external_node` indexes the forest by
        // id to fetch the procedure digest.
        self.record_visit(forest, external_node_id);
    }

    #[inline(always)]
    fn record_hasher_permute(
        &mut self,
        input_state: [Felt; STATE_WIDTH],
        output_state: [Felt; STATE_WIDTH],
    ) {
        self.hasher_for_chiplet.record_permute_input(input_state);
        self.hasher_chiplet_shim.record_permute_output(output_state);
    }

    #[inline(always)]
    fn record_hasher_build_merkle_root(
        &mut self,
        node: Word,
        path: Option<&MerklePath>,
        depth: Felt,
        index: Felt,
        output_root: Word,
    ) {
        let path = path.expect("execution tracer expects a valid Merkle path");
        self.hasher_chiplet_shim.record_build_merkle_root(path, output_root);
        self.hasher_for_chiplet.record_build_merkle_root(node, path.clone(), index);
        self.range_checker.record_merkle_depth(depth);
    }

    #[inline(always)]
    fn record_hasher_update_merkle_root(
        &mut self,
        old_value: Word,
        new_value: Word,
        path: Option<&MerklePath>,
        depth: Felt,
        index: Felt,
        old_root: Word,
        new_root: Word,
    ) {
        let path = path.expect("execution tracer expects a valid Merkle path");
        self.hasher_chiplet_shim.record_update_merkle_root(path, old_root, new_root);
        self.hasher_for_chiplet.record_update_merkle_root(
            old_value,
            new_value,
            path.clone(),
            index,
        );
        self.range_checker.record_merkle_depth(depth);
    }

    #[inline(always)]
    fn record_memory_read_element(
        &mut self,
        element: Felt,
        addr: Felt,
        ctx: ContextId,
        clk: RowIndex,
    ) {
        self.memory_reads.record_read_element(element, addr, ctx, clk);
    }

    #[inline(always)]
    fn record_memory_read_word(&mut self, word: Word, addr: Felt, ctx: ContextId, clk: RowIndex) {
        self.memory_reads.record_read_word(word, addr, ctx, clk);
    }

    #[inline(always)]
    fn record_memory_write_element(
        &mut self,
        element: Felt,
        addr: Felt,
        ctx: ContextId,
        clk: RowIndex,
    ) {
        self.memory_writes.record_write_element(element, addr, ctx, clk);
    }

    #[inline(always)]
    fn record_memory_write_word(&mut self, word: Word, addr: Felt, ctx: ContextId, clk: RowIndex) {
        self.memory_writes.record_write_word(word, addr, ctx, clk);
    }

    #[inline(always)]
    fn record_memory_read_dword(
        &mut self,
        words: [Word; 2],
        addr: Felt,
        ctx: ContextId,
        clk: RowIndex,
    ) {
        self.memory_reads.record_read_word(words[0], addr, ctx, clk);
        self.memory_reads.record_read_word(words[1], addr + PTR_OFFSET_WORD, ctx, clk);
    }

    #[inline(always)]
    fn record_dyncall_memory(
        &mut self,
        callee_hash: Word,
        read_addr: Felt,
        read_ctx: ContextId,
        fmp_ctx: ContextId,
        clk: RowIndex,
    ) {
        self.memory_reads.record_read_word(callee_hash, read_addr, read_ctx, clk);
        self.memory_writes.record_write_element(FMP_INIT_VALUE, FMP_ADDR, fmp_ctx, clk);
    }

    #[inline(always)]
    fn record_crypto_stream(
        &mut self,
        plaintext: [Word; 2],
        src_addr: Felt,
        ciphertext: [Word; 2],
        dst_addr: Felt,
        ctx: ContextId,
        clk: RowIndex,
    ) {
        self.memory_reads.record_read_word(plaintext[0], src_addr, ctx, clk);
        self.memory_reads
            .record_read_word(plaintext[1], src_addr + PTR_OFFSET_WORD, ctx, clk);
        self.memory_writes.record_write_word(ciphertext[0], dst_addr, ctx, clk);
        self.memory_writes
            .record_write_word(ciphertext[1], dst_addr + PTR_OFFSET_WORD, ctx, clk);
    }

    #[inline(always)]
    fn record_pipe(&mut self, words: [Word; 2], addr: Felt, ctx: ContextId, clk: RowIndex) {
        self.advice.record_pop_stack_dword(words);
        self.memory_writes.record_write_word(words[0], addr, ctx, clk);
        self.memory_writes.record_write_word(words[1], addr + PTR_OFFSET_WORD, ctx, clk);
    }

    #[inline(always)]
    fn record_advice_pop_stack(&mut self, value: Felt) {
        self.advice.record_pop_stack(value);
    }

    #[inline(always)]
    fn record_advice_pop_stack_word(&mut self, word: Word) {
        self.advice.record_pop_stack_word(word);
    }

    #[inline(always)]
    fn record_u32and(&mut self, a: Felt, b: Felt) {
        self.bitwise.record_u32and(a, b);
    }

    #[inline(always)]
    fn record_u32xor(&mut self, a: Felt, b: Felt) {
        self.bitwise.record_u32xor(a, b);
    }

    #[inline(always)]
    fn record_u32_range_checks(&mut self, u32_lo: Felt, u32_hi: Felt) {
        let (t1, t0) = split_u32_into_u16(u32_lo.as_canonical_u64());
        let (t3, t2) = split_u32_into_u16(u32_hi.as_canonical_u64());

        self.range_checker.record_range_check_u32([t0, t1, t2, t3]);
    }

    #[inline(always)]
    fn record_u32div_range_checks(
        &mut self,
        quotient: Felt,
        remainder: Felt,
        remainder_diff: Felt,
    ) {
        self.record_u32_range_checks(quotient, remainder);
        let (d1, d0) = split_u32_into_u16(remainder_diff.as_canonical_u64());
        self.range_checker.record_u32div_remainder_diff([d0, d1]);
    }

    #[inline(always)]
    fn record_kernel_proc_access(&mut self, proc_hash: Word) {
        self.kernel.record_kernel_proc_access(proc_hash);
    }

    #[inline(always)]
    fn record_circuit_evaluation(&mut self, circuit_evaluation: CircuitEvaluation) {
        self.ace.record_circuit_evaluation(circuit_evaluation);
    }

    #[inline(always)]
    fn finalize_clock_cycle(
        &mut self,
        processor: &FastProcessor,
        _op_helper_registers: OperationHelperRegisters,
        _current_forest: &Arc<MastForest>,
    ) -> Result<(), ExecutionError> {
        // Restore the overflow table context for Call/Syscall/Dyncall END. This is deferred
        // from start_clock_cycle because finalize_clock_cycle is only called when the operation
        // succeeds (i.e., the stack depth check in processor.restore_context() passes).
        if self.pending_restore_context {
            // Restore context for call/syscall/dyncall: pop the current context's
            // (empty) overflow stack and restore the previous context's overflow state.
            self.overflow_table.restore_context().map_err(|_| {
                ExecutionError::Internal(
                    "overflow table restore_context failed during trace finalization",
                )
            })?;
            self.overflow_replay.record_restore_context_overflow_addr(
                MIN_STACK_DEPTH + self.overflow_table.num_elements_in_current_ctx(),
                self.overflow_table.last_update_clk_in_current_ctx(),
            );

            self.pending_restore_context = false;
        }

        // Record all memory reads performed during EvalCircuit operations. We run this in
        // `finalize_clock_cycle` to ensure that the memory reads are only recorded if the operation
        // succeeds (and hence the values read from the stack can be assumed to be valid).
        if self.is_eval_circuit_op {
            let ptr = processor.stack_get(0);
            let num_read = processor.stack_get(1).as_canonical_u64();
            let num_eval = processor.stack_get(2).as_canonical_u64();
            let ctx = processor.ctx();
            let clk = processor.clock();

            let num_read_rows = num_read / 2;

            let mut addr = ptr;
            for _ in 0..num_read_rows {
                let word = processor
                    .memory()
                    .read_word(ctx, addr, clk)
                    .expect("EvalCircuit memory read should not fail after successful execution");
                self.memory_reads.record_read_word(word, addr, ctx, clk);
                addr += PTR_OFFSET_WORD;
            }
            for _ in 0..num_eval {
                let element = processor
                    .memory()
                    .read_element(ctx, addr)
                    .expect("EvalCircuit memory read should not fail after successful execution");
                self.memory_reads.record_read_element(element, addr, ctx, clk);
                addr += PTR_OFFSET_ELEM;
            }

            self.is_eval_circuit_op = false;
        }

        Ok(())
    }
}

/// Extracts the [`MastNodeId`] that is being executed at the start of a clock cycle from the given
/// continuation, so that the node can be marked as visited in its source forest's sparse builder.
///
/// Continuations not passed to [`Tracer::start_clock_cycle`] (per the trait contract) are matched
/// pessimistically here, returning `None`.
#[inline]
fn node_id_for_visit<F>(continuation: &Continuation<F>) -> Option<MastNodeId> {
    match *continuation {
        Continuation::StartNode(id)
        | Continuation::FinishJoin(id)
        | Continuation::FinishSplit(id)
        | Continuation::FinishCall(id)
        | Continuation::FinishDyn(id)
        | Continuation::FinishBasicBlock(id) => Some(id),
        Continuation::FinishLoop(id) => Some(id),
        Continuation::ResumeBasicBlock { node_id, .. } | Continuation::Respan { node_id, .. } => {
            Some(node_id)
        },
        Continuation::EnterForest { .. } => None,
    }
}

// HASHER CHIPLET SHIM
// ================================================================================================

/// The number of controller rows per permutation request (input + output = 2), as u32.
const NUM_HASHER_ROWS_PER_PERMUTATION: u32 = CONTROLLER_ROWS_PER_PERMUTATION as u32;

/// Implements a shim for the hasher chiplet, where the responses of the hasher chiplet are emulated
/// and recorded for later replay.
///
/// This is used to simulate hasher operations in parallel trace generation without needing to
/// actually generate the hasher trace. All hasher operations are recorded during fast execution and
/// then replayed during core trace generation.
#[derive(Debug)]
pub struct HasherChipletShim {
    /// The address of the next MAST node encountered during execution. This field is used to keep
    /// track of the number of rows in the hasher chiplet, from which the address of the next MAST
    /// node is derived.
    addr: u32,
    /// Replay for the hasher chiplet responses, recording only the hasher chiplet responses.
    hasher_replay: HasherResponseReplay,
    block_addr_replay: BlockAddressReplay,
}

impl HasherChipletShim {
    /// Creates a new [HasherChipletShim].
    pub fn new() -> Self {
        Self {
            addr: 1,
            hasher_replay: HasherResponseReplay::default(),
            block_addr_replay: BlockAddressReplay::default(),
        }
    }

    /// Records the address returned from a call to `Hasher::hash_control_block()`.
    pub fn record_hash_control_block(&mut self) -> Felt {
        let block_addr = Felt::from_u32(self.addr);

        self.block_addr_replay.record_block_address(block_addr);
        self.addr += NUM_HASHER_ROWS_PER_PERMUTATION;

        block_addr
    }

    /// Records the address returned from a call to `Hasher::hash_basic_block()`.
    pub fn record_hash_basic_block(&mut self, basic_block_node: &BasicBlockNode) -> Felt {
        let block_addr = Felt::from_u32(self.addr);

        self.block_addr_replay.record_block_address(block_addr);
        self.addr += NUM_HASHER_ROWS_PER_PERMUTATION * basic_block_node.num_op_batches() as u32;

        block_addr
    }
    /// Records the result of a call to `Hasher::permute()`.
    pub fn record_permute_output(&mut self, hashed_state: [Felt; 12]) {
        self.hasher_replay.record_permute(Felt::from_u32(self.addr), hashed_state);
        self.addr += NUM_HASHER_ROWS_PER_PERMUTATION;
    }

    /// Records the result of a call to `Hasher::build_merkle_root()`.
    pub fn record_build_merkle_root(&mut self, path: &MerklePath, computed_root: Word) {
        self.hasher_replay
            .record_build_merkle_root(Felt::from_u32(self.addr), computed_root);
        self.addr += NUM_HASHER_ROWS_PER_PERMUTATION * path.depth() as u32;
    }

    /// Records the result of a call to `Hasher::update_merkle_root()`.
    pub fn record_update_merkle_root(&mut self, path: &MerklePath, old_root: Word, new_root: Word) {
        self.hasher_replay
            .record_update_merkle_root(Felt::from_u32(self.addr), old_root, new_root);

        // The Merkle path is verified twice: once for the old root and once for the new root.
        self.addr += 2 * NUM_HASHER_ROWS_PER_PERMUTATION * path.depth() as u32;
    }

    pub fn extract_replay(&mut self) -> (HasherResponseReplay, BlockAddressReplay) {
        (
            core::mem::take(&mut self.hasher_replay),
            core::mem::take(&mut self.block_addr_replay),
        )
    }
}

impl Default for HasherChipletShim {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod serialization_tests {
    use super::*;
    use crate::mast::BasicBlockNodeBuilder;

    fn empty_trace_generation_context(fragment_size: usize, max_stack_depth: usize) -> TraceReplay {
        TraceReplay {
            mast_forest_store: Vec::new(),
            core_trace_contexts: Vec::new(),
            range_checker_replay: RangeCheckerReplay::default(),
            memory_writes: MemoryWritesReplay::default(),
            bitwise_replay: BitwiseReplay::default(),
            hasher_for_chiplet: HasherRequestReplay::default(),
            kernel_replay: KernelReplay::default(),
            ace_replay: AceReplay::default(),
            fragment_size,
            max_stack_depth,
        }
    }

    fn one_node_sparse_forest() -> Arc<SparseMastForest> {
        let mut forest = MastForest::new();
        let root = BasicBlockNodeBuilder::new(vec![Operation::Noop])
            .add_to_forest(&mut forest)
            .unwrap();
        forest.make_root(root);

        let forest = Arc::new(forest);
        let mut builder = SparseMastForestBuilder::new(Arc::clone(&forest));
        builder.record_visit(root, VisitKind::FullVisit);
        Arc::new(builder.finalize())
    }

    fn core_trace_state() -> CoreTraceState {
        CoreTraceState {
            system: SystemState {
                clk: RowIndex::from(0u32),
                ctx: ContextId::root(),
                fn_hash: Word::default(),
                deferred_root: Word::default(),
            },
            decoder: DecoderState { current_addr: ZERO, parent_addr: ZERO },
            stack: StackState::new([ZERO; MIN_STACK_DEPTH], MIN_STACK_DEPTH, ZERO),
        }
    }

    fn valid_trace_generation_context() -> TraceReplay {
        TraceReplay {
            mast_forest_store: vec![one_node_sparse_forest()],
            core_trace_contexts: vec![CoreTraceFragmentContext {
                state: core_trace_state(),
                replay: ExecutionReplay::default(),
                continuation: ContinuationStack::default(),
                initial_mast_forest_id: MastForestId::from(0u32),
            }],
            range_checker_replay: RangeCheckerReplay::default(),
            memory_writes: MemoryWritesReplay::default(),
            bitwise_replay: BitwiseReplay::default(),
            hasher_for_chiplet: HasherRequestReplay::default(),
            kernel_replay: KernelReplay::default(),
            ace_replay: AceReplay::default(),
            fragment_size: 1,
            max_stack_depth: MIN_STACK_DEPTH,
        }
    }

    fn assert_context_read_rejects_bad_forest_id(context: TraceReplay, expected_label: &str) {
        let err = TraceReplay::read_from_bytes(&context.to_bytes()).unwrap_err();
        let DeserializationError::InvalidValue(message) = err else {
            panic!("expected invalid forest id error");
        };
        assert!(message.contains(expected_label), "{message}");
        assert!(message.contains("out of range for mast_forest_store length 1"), "{message}");
    }

    #[test]
    fn trace_generation_context_read_rejects_zero_fragment_size() {
        let context = empty_trace_generation_context(0, MIN_STACK_DEPTH);

        let err = TraceReplay::read_from_bytes(&context.to_bytes()).unwrap_err();
        let DeserializationError::InvalidValue(message) = err else {
            panic!("expected invalid fragment size error");
        };
        assert!(message.contains("fragment_size must be non-zero"));
    }

    #[test]
    fn trace_generation_context_read_rejects_max_stack_depth_below_minimum() {
        let context = empty_trace_generation_context(1, MIN_STACK_DEPTH - 1);

        let err = TraceReplay::read_from_bytes(&context.to_bytes()).unwrap_err();
        let DeserializationError::InvalidValue(message) = err else {
            panic!("expected invalid max stack depth error");
        };
        assert!(message.contains("max_stack_depth"));
    }

    #[test]
    fn trace_generation_context_read_rejects_bad_initial_forest_id() {
        let mut context = valid_trace_generation_context();
        context.core_trace_contexts[0].initial_mast_forest_id = MastForestId::from(1u32);

        assert_context_read_rejects_bad_forest_id(
            context,
            "core trace fragment initial_mast_forest_id",
        );
    }

    #[test]
    fn trace_generation_context_read_rejects_bad_continuation_forest_id() {
        let mut context = valid_trace_generation_context();
        context.core_trace_contexts[0]
            .continuation
            .push_enter_forest(MastForestId::from(1u32));

        assert_context_read_rejects_bad_forest_id(
            context,
            "core trace fragment continuation EnterForest",
        );
    }

    #[test]
    fn trace_generation_context_read_rejects_bad_resolution_replay_forest_id() {
        let mut context = valid_trace_generation_context();
        context.core_trace_contexts[0]
            .replay
            .mast_forest_resolution
            .record_resolution(MastNodeId::from(0), MastForestId::from(1u32));

        assert_context_read_rejects_bad_forest_id(
            context,
            "core trace fragment MastForestResolutionReplay",
        );
    }

    #[test]
    fn trace_generation_context_read_rejects_bad_hasher_replay_forest_id() {
        let mut context = valid_trace_generation_context();
        let basic_block = BasicBlockNodeBuilder::new(vec![Operation::Noop]).build().unwrap();
        context.hasher_for_chiplet.record_hash_basic_block(
            MastForestId::from(1u32),
            MastNodeId::from(0),
            &basic_block,
        );

        assert_context_read_rejects_bad_forest_id(context, "hasher HashBasicBlock replay");
    }
}