miden-crypto 0.24.0

Miden Cryptographic primitives
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
use alloc::vec::Vec;

use super::{
    EmptySubtreeRoots, InnerNode, NodeIndex, NodeMutation, SMT_DEPTH, SUBTREE_DEPTH, Subtree,
};
use crate::Word;

#[test]
fn test_initial_state() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let subtree = Subtree::new(root_index);

    assert_eq!(subtree.root_index(), root_index, "Root index should match the provided index");
    assert_eq!(subtree.len(), 0, "New subtree should be empty");
    assert!(subtree.is_empty(), "New subtree should report as empty");
}

#[test]
fn test_node_operations() {
    let subtree_root_idx = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let mut subtree = Subtree::new(subtree_root_idx);

    // Create test nodes and indices
    let node1_idx = NodeIndex::new(SUBTREE_DEPTH + 1, 0).unwrap();
    let node1 = InnerNode {
        left: Word::default(),
        right: Word::default(),
    };

    let node2_idx = NodeIndex::new(SUBTREE_DEPTH + 2, 3).unwrap();
    let node2 = InnerNode {
        left: Word::from([1u32; 4]),
        right: Word::from([2u32; 4]),
    };

    // Test insertion into empty subtree
    assert_eq!(subtree.len(), 0, "Subtree should be empty");

    let old_node = subtree.insert_inner_node(node1_idx, node1.clone());
    assert!(old_node.is_none(), "Old node should be empty");
    assert_eq!(subtree.len(), 1, "Subtree should have one node");

    let old_node = subtree.insert_inner_node(node2_idx, node2.clone());
    assert!(old_node.is_none(), "Old node should be empty");
    assert_eq!(subtree.len(), 2, "Subtree should have two nodes");

    // Test node retrieval
    assert_eq!(
        subtree.get_inner_node(node1_idx),
        Some(node1.clone()),
        "Should match the first node"
    );
    assert_eq!(
        subtree.get_inner_node(node2_idx),
        Some(node2.clone()),
        "Should match the second node"
    );

    let non_existent_idx = NodeIndex::new(SUBTREE_DEPTH + 3, 0).unwrap();
    assert!(
        subtree.get_inner_node(non_existent_idx).is_none(),
        "Should return None for non-existent node"
    );

    // Test node overwriting
    let node1_updated = InnerNode {
        left: Word::from([3u32; 4]),
        right: Word::from([4u32; 4]),
    };
    let previous_node = subtree.insert_inner_node(node1_idx, node1_updated.clone());
    assert_eq!(previous_node, Some(node1), "Overwriting should return the previous node");
    assert_eq!(subtree.len(), 2, "Length should not change on overwrite");
    assert_eq!(
        subtree.get_inner_node(node1_idx),
        Some(node1_updated.clone()),
        "Should retrieve the updated node"
    );

    // Test node removal
    let removed_node = subtree.remove_inner_node(node1_idx);
    assert_eq!(removed_node, Some(node1_updated), "Removing should return the removed node");
    assert_eq!(subtree.len(), 1, "Length should decrease after removal");
    assert!(
        subtree.get_inner_node(node1_idx).is_none(),
        "Removed node should no longer be retrievable"
    );

    // Test removing non-existent node
    let remove_result = subtree.remove_inner_node(node1_idx);
    assert!(remove_result.is_none(), "Removing non-existent node should return None");
    assert_eq!(subtree.len(), 1, "Length should not change when removing non-existent node");

    // Remove final node to test empty state
    let removed_node = subtree.remove_inner_node(node2_idx);
    assert_eq!(removed_node, Some(node2), "Should remove the final node");
    assert_eq!(subtree.len(), 0, "Subtree should be empty after removing all nodes");
    assert!(subtree.is_empty(), "Subtree should report as empty");

    // Test removing from empty subtree
    let remove_result = subtree.remove_inner_node(node1_idx);
    assert!(remove_result.is_none(), "Removing from empty subtree should return None");
    assert_eq!(subtree.len(), 0, "Length should remain zero");
}

#[test]
fn test_serialize_deserialize_empty_subtree() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 1).unwrap();
    let subtree = Subtree::new(root_index);

    let serialized = subtree.to_vec();

    // Should only contain magic + version + bitmask (all zeros) and no node data
    assert_eq!(
        serialized.len(),
        5 + Subtree::BITMASK_SIZE,
        "Empty subtree serialization should only contain bitmask"
    );
    assert!(
        serialized[..4] == *b"SMT1"
            && serialized[4] == 1
            && serialized[5..].iter().all(|&byte| byte == 0),
        "Magic + version should be set and all bitmask bytes should be zero"
    );

    let deserialized = Subtree::from_vec(root_index, &serialized)
        .expect("Deserialization of empty subtree should succeed");

    assert_eq!(deserialized.root_index(), root_index, "Deserialized root index should match");
    assert!(deserialized.is_empty(), "Deserialized subtree should be empty");
    assert_eq!(deserialized.len(), 0, "Deserialized subtree should have length 0");
}

#[test]
fn test_serialize_deserialize_subtree_with_nodes() {
    let subtree_root_idx = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let mut subtree = Subtree::new(subtree_root_idx);

    // Add nodes at positions: root (local index 0), first child (local index 1),
    // and last possible position (local index 254)
    let node0_idx_global = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let node1_idx_global = NodeIndex::new(SUBTREE_DEPTH + 1, 0).unwrap();
    let node254_idx_global = NodeIndex::new(SUBTREE_DEPTH + 7, 127).unwrap();

    let node0 = InnerNode {
        left: Word::from([1u32; 4]),
        right: Word::from([2u32; 4]),
    };
    let node1 = InnerNode {
        left: Word::from([3u32; 4]),
        right: Word::from([4u32; 4]),
    };
    let node254 = InnerNode {
        left: Word::from([5u32; 4]),
        right: Word::from([6u32; 4]),
    };

    subtree.insert_inner_node(node0_idx_global, node0.clone());
    subtree.insert_inner_node(node1_idx_global, node1.clone());
    subtree.insert_inner_node(node254_idx_global, node254.clone());

    assert_eq!(subtree.len(), 3, "Subtree should contain 3 nodes");

    // Test serialization
    let serialized = subtree.to_vec();
    let expected_size = 5 + Subtree::BITMASK_SIZE + 6 * Subtree::HASH_SIZE;
    assert_eq!(serialized.len(), expected_size, "Serialized size should be bitmask + 3 nodes");

    // Test deserialization
    let deserialized =
        Subtree::from_vec(subtree_root_idx, &serialized).expect("Deserialization should succeed");

    assert_eq!(deserialized.root_index(), subtree_root_idx, "Root index should match");
    assert_eq!(deserialized.len(), 3, "Deserialized subtree should have 3 nodes");
    assert!(!deserialized.is_empty(), "Deserialized subtree should not be empty");

    // Verify all nodes are correctly deserialized
    assert_eq!(
        deserialized.get_inner_node(node0_idx_global),
        Some(node0),
        "First node should be correctly deserialized"
    );
    assert_eq!(
        deserialized.get_inner_node(node1_idx_global),
        Some(node1),
        "Second node should be correctly deserialized"
    );
    assert_eq!(
        deserialized.get_inner_node(node254_idx_global),
        Some(node254),
        "Third node should be correctly deserialized"
    );

    // Verify bitmask correctness
    let (bitmask_bytes, _node_data) = serialized[5..].split_at(Subtree::BITMASK_SIZE);

    // byte 0: bits 0-3 must be set
    assert_eq!(bitmask_bytes[0], 0x0f, "byte 0 must have bits 0-3 set");

    // bytes 1‥=62 must be zero
    assert!(bitmask_bytes[1..63].iter().all(|&b| b == 0), "bytes 1‥62 must be zero");

    // byte 63: bits 4 & 5 must be set
    assert_eq!(bitmask_bytes[63], 0x30, "byte 63 must have bits 4 & 5 set");
}

/// Tests global to local index conversion with zero-based subtree root
#[test]
fn global_to_local_index_conversion_zero_base() {
    let base_idx = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    // Test various depth and value combinations
    let test_cases = [
        // (depth, value, expected_local_index, description)
        (SUBTREE_DEPTH, 0, 0, "root node"),
        (SUBTREE_DEPTH + 1, 0, 1, "left child"),
        (SUBTREE_DEPTH + 1, 1, 2, "right child"),
        (SUBTREE_DEPTH + 2, 0, 3, "left grandchild"),
        (SUBTREE_DEPTH + 2, 3, 6, "right grandchild at position 3"),
        (SUBTREE_DEPTH + 7, 0, 127, "deepest left node"),
        (SUBTREE_DEPTH + 7, 127, 254, "deepest right node"),
    ];

    for (depth, value, expected_local, description) in test_cases {
        let global_idx = NodeIndex::new(depth, value).unwrap();
        let local_idx = Subtree::global_to_local(global_idx, base_idx);
        assert_eq!(
            local_idx, expected_local,
            "Failed for {description}: depth={depth}, value={value}"
        );
    }
}

/// Tests global to local index conversion with non-zero subtree root
#[test]
fn global_to_local_index_conversion_nonzero_base() {
    let base_idx = NodeIndex::new(SUBTREE_DEPTH * 2, 1).unwrap();

    let test_cases = [
        // (depth, value, expected_local_index, description)
        (SUBTREE_DEPTH * 2, 1, 0, "subtree root itself"),
        (SUBTREE_DEPTH * 2 + 1, 2, 1, "left child (2 = 1<<1 | 0)"),
        (SUBTREE_DEPTH * 2 + 1, 3, 2, "right child (3 = 1<<1 | 1)"),
    ];

    for (depth, value, expected_local, description) in test_cases {
        let global_idx = NodeIndex::new(depth, value).unwrap();
        let local_idx = Subtree::global_to_local(global_idx, base_idx);
        assert_eq!(
            local_idx, expected_local,
            "Failed for {description}: depth={depth}, value={value}"
        );
    }
}

/// Tests that global_to_local panics when global depth is less than base depth
#[test]
#[should_panic(expected = "Global depth is less than base depth")]
fn global_to_local_panics_on_invalid_depth() {
    let base_idx = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let invalid_global_idx = NodeIndex::new(SUBTREE_DEPTH - 1, 0).unwrap();

    // This should panic because global depth cannot be less than base depth
    Subtree::global_to_local(invalid_global_idx, base_idx);
}

/// Tests finding subtree roots for nodes at various positions in the tree
#[test]
fn find_subtree_root_for_various_nodes() {
    // Test nodes within the first possible subtree (rooted at depth 0)
    let shallow_nodes =
        [NodeIndex::new(0, 0).unwrap(), NodeIndex::new(SUBTREE_DEPTH - 1, 0).unwrap()];

    for node_idx in shallow_nodes {
        assert_eq!(
            Subtree::find_subtree_root(node_idx),
            NodeIndex::root(),
            "Node at depth {} should belong to root subtree",
            node_idx.depth()
        );
    }

    // Test nodes in subtree rooted at (depth=SUBTREE_DEPTH, value=0)
    let subtree_0_root = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let subtree_0_nodes = [
        NodeIndex::new(SUBTREE_DEPTH, 0).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH + 1, 0).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH + 1, 1).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH * 2 - 1, (1 << (SUBTREE_DEPTH - 1)) - 1).unwrap(),
    ];

    for node_idx in subtree_0_nodes {
        assert_eq!(
            Subtree::find_subtree_root(node_idx),
            subtree_0_root,
            "Node at depth {}, value {} should belong to subtree rooted at depth {}, value 0",
            node_idx.depth(),
            node_idx.position(),
            SUBTREE_DEPTH
        );
    }

    // Test nodes in subtree rooted at (depth=SUBTREE_DEPTH, value=1)
    let subtree_1_root = NodeIndex::new(SUBTREE_DEPTH, 1).unwrap();
    let subtree_1_nodes = [
        NodeIndex::new(SUBTREE_DEPTH, 1).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH + 1, 2).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH + 1, 3).unwrap(),
    ];

    for node_idx in subtree_1_nodes {
        assert_eq!(
            Subtree::find_subtree_root(node_idx),
            subtree_1_root,
            "Node at depth {}, value {} should belong to subtree rooted at depth {}, value 1",
            node_idx.depth(),
            node_idx.position(),
            SUBTREE_DEPTH
        );
    }

    // Test nodes in subtree rooted at (depth=SUBTREE_DEPTH*2, value=3)
    let deep_subtree_root = NodeIndex::new(SUBTREE_DEPTH * 2, 3).unwrap();
    let deep_subtree_nodes = [
        NodeIndex::new(SUBTREE_DEPTH * 2, 3).unwrap(),
        NodeIndex::new(SUBTREE_DEPTH * 2 + 5, (3 << 5) | 17).unwrap(),
    ];

    for node_idx in deep_subtree_nodes {
        assert_eq!(
            Subtree::find_subtree_root(node_idx),
            deep_subtree_root,
            "Node at depth {}, value {} should belong to deep subtree",
            node_idx.depth(),
            node_idx.position()
        );
    }
}

#[test]
fn test_from_vec_rejects_unused_bitmask_bits() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    // Bits 510 and 511 are unused (only 255 nodes x 2 bits = 510 bits). Corrupted storage
    // could set these; from_vec should reject them.
    for bit in [510, 511] {
        let mut data = Vec::from(&b"SMT1"[..]);
        data.push(1);
        data.extend_from_slice(&[0u8; Subtree::BITMASK_SIZE]);
        data[5 + (bit / 8)] |= 1 << (bit % 8);

        assert!(
            matches!(
                Subtree::from_vec(root_index, &data),
                Err(super::SubtreeError::InvalidBitmask)
            ),
            "bit {bit} should be rejected"
        );
    }

    // Bit 509 is the last valid bit (node 254, right child) — should be accepted.
    let mut data = Vec::from(&b"SMT1"[..]);
    data.push(1);
    data.extend_from_slice(&[0u8; Subtree::BITMASK_SIZE]);
    data[5 + (509 / 8)] |= 1 << (509 % 8);
    data.extend_from_slice(&Word::from([99u32; 4]).as_bytes());

    assert!(Subtree::from_vec(root_index, &data).is_ok(), "bit 509 is valid");
}

#[test]
fn test_from_vec_rejects_invalid_field_element() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    // One hash slot with a limb >= the Goldilocks prime.
    let mut data = Vec::from(&b"SMT1"[..]);
    data.push(1);
    data.extend_from_slice(&[0u8; Subtree::BITMASK_SIZE]);
    data[5] |= 1;
    data.extend_from_slice(&u64::MAX.to_le_bytes());
    data.extend_from_slice(&[0u8; 24]);

    assert!(matches!(
        Subtree::from_vec(root_index, &data),
        Err(super::SubtreeError::InvalidHashData)
    ));
}

#[test]
fn test_from_vec_rejects_missing_magic() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    // Missing magic/version prefix should always be rejected.
    let mut data = vec![0u8; Subtree::BITMASK_SIZE];
    data[0] |= 1;
    data.extend_from_slice(&Word::from([42u32; 4]).as_bytes());

    assert!(matches!(
        Subtree::from_vec(root_index, &data),
        Err(super::SubtreeError::MissingFormatMagic)
    ));
}

#[test]
fn test_from_vec_rejects_unknown_version() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    let mut data = Vec::from(&b"SMT1"[..]);
    data.push(Subtree::FORMAT_VERSION + 1);
    data.extend_from_slice(&[0u8; Subtree::BITMASK_SIZE]);

    assert!(matches!(
        Subtree::from_vec(root_index, &data),
        Err(super::SubtreeError::UnsupportedVersion { .. })
    ));
}

#[test]
fn test_from_vec_rejects_unknown_version_with_extra_payload() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();

    let mut data = Vec::from(&b"SMT1"[..]);
    data.push(Subtree::FORMAT_VERSION + 1);
    data.extend_from_slice(&[0u8; Subtree::BITMASK_SIZE]);
    data.extend_from_slice(&Word::default().as_bytes());

    assert!(matches!(
        Subtree::from_vec(root_index, &data),
        Err(super::SubtreeError::UnsupportedVersion { .. })
    ));
}

#[test]
fn test_apply_mutations() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let mut subtree = Subtree::new(root_index);

    let idx1 = NodeIndex::new(SUBTREE_DEPTH + 1, 0).unwrap();
    let idx2 = NodeIndex::new(SUBTREE_DEPTH + 1, 1).unwrap();
    let node1 = InnerNode {
        left: Word::from([1u32; 4]),
        right: Word::from([2u32; 4]),
    };
    let node2 = InnerNode {
        left: Word::from([3u32; 4]),
        right: Word::from([4u32; 4]),
    };
    subtree.insert_inner_node(idx1, node1);
    subtree.insert_inner_node(idx2, node2.clone());
    assert_eq!(subtree.len(), 2);

    // Empty batch should be a no-op
    let empty: [(&NodeIndex, &NodeMutation); 0] = [];
    assert_eq!(subtree.would_patch_in_place(empty), None);
    subtree.apply_mutations(empty);
    assert_eq!(subtree.len(), 2);

    // Update node1 with different hashes but same structure (both children still non-empty).
    // This should take the patch-in-place path.
    let node1_updated = InnerNode {
        left: Word::from([10u32; 4]),
        right: Word::from([20u32; 4]),
    };
    let mutation = NodeMutation::Addition(node1_updated.clone());
    assert_eq!(subtree.would_patch_in_place([(&idx1, &mutation)]), Some(true));
    subtree.apply_mutations([(&idx1, &mutation)]);

    assert_eq!(subtree.len(), 2);
    assert_eq!(subtree.get_inner_node(idx1), Some(node1_updated));
    assert_eq!(subtree.get_inner_node(idx2), Some(node2.clone()));

    // Mixed batch: remove node1, add node3. This changes structure, triggering a rebuild.
    let idx3 = NodeIndex::new(SUBTREE_DEPTH + 2, 2).unwrap();
    let node3 = InnerNode {
        left: Word::from([5u32; 4]),
        right: Word::from([6u32; 4]),
    };
    let removal = NodeMutation::Removal;
    let addition = NodeMutation::Addition(node3.clone());
    assert_eq!(
        subtree.would_patch_in_place([(&idx1, &removal), (&idx3, &addition)]),
        Some(false)
    );
    subtree.apply_mutations([(&idx1, &removal), (&idx3, &addition)]);

    assert!(subtree.get_inner_node(idx1).is_none(), "node1 should be removed");
    assert_eq!(subtree.get_inner_node(idx2), Some(node2), "node2 should be unchanged");
    assert_eq!(subtree.get_inner_node(idx3), Some(node3));
    assert_eq!(subtree.len(), 2);

    // Remove remaining nodes to verify we get back to empty
    let r1 = NodeMutation::Removal;
    let r2 = NodeMutation::Removal;
    subtree.apply_mutations([(&idx2, &r1), (&idx3, &r2)]);
    assert!(subtree.is_empty());

    // Verify round-trip serialization on the emptied subtree
    let serialized = subtree.to_vec();
    let deserialized = Subtree::from_vec(root_index, &serialized).unwrap();
    assert!(deserialized.is_empty());
}

#[test]
fn test_apply_mutations_dedupes_duplicate_indices() {
    let root_index = NodeIndex::new(SUBTREE_DEPTH, 0).unwrap();
    let mut subtree = Subtree::new(root_index);

    let idx1 = NodeIndex::new(SUBTREE_DEPTH + 1, 0).unwrap();
    let idx2 = NodeIndex::new(SUBTREE_DEPTH + 1, 1).unwrap();
    let node1 = InnerNode {
        left: Word::from([1u32; 4]),
        right: Word::from([2u32; 4]),
    };
    let node2 = InnerNode {
        left: Word::from([3u32; 4]),
        right: Word::from([4u32; 4]),
    };
    subtree.insert_inner_node(idx1, node1);
    subtree.insert_inner_node(idx2, node2.clone());

    let empty_hash = *EmptySubtreeRoots::entry(SMT_DEPTH, idx1.depth() + 1);
    let left_only = InnerNode {
        left: Word::from([10u32; 4]),
        right: empty_hash,
    };
    let right_only = InnerNode {
        left: empty_hash,
        right: Word::from([20u32; 4]),
    };

    let m1 = NodeMutation::Addition(left_only);
    let m2 = NodeMutation::Addition(right_only.clone());
    subtree.apply_mutations([(&idx1, &m1), (&idx1, &m2)]);

    assert_eq!(subtree.get_inner_node(idx1), Some(right_only));
    assert_eq!(subtree.get_inner_node(idx2), Some(node2));
    assert_eq!(subtree.len(), 2);
}